@atlaskit/editor-plugin-list 1.0.0 → 1.1.0

package/CHANGELOG.md

@@ -1,5 +1,11 @@
 # @atlaskit/editor-plugin-list
 
+## 1.1.0
+
+### Minor Changes
+
+- [`4795a87a349`](https://bitbucket.org/atlassian/atlassian-frontend/commits/4795a87a349) - Migrating some actions of `editor-plugin-list` to commands. Adding sharedState for `editor-plugin-text-formatting`.
+
 ## 1.0.0
 
 ### Major Changes

package/dist/cjs/actions/outdent-list-items-selected.js

@@ -18,7 +18,7 @@ var _find = require("../utils/find");
 var _selection2 = require("../utils/selection");
 function ownKeys(object, enumerableOnly) { var keys = Object.keys(object); if (Object.getOwnPropertySymbols) { var symbols = Object.getOwnPropertySymbols(object); enumerableOnly && (symbols = symbols.filter(function (sym) { return Object.getOwnPropertyDescriptor(object, sym).enumerable; })), keys.push.apply(keys, symbols); } return keys; }
 function _objectSpread(target) { for (var i = 1; i < arguments.length; i++) { var source = null != arguments[i] ? arguments[i] : {}; i % 2 ? ownKeys(Object(source), !0).forEach(function (key) { (0, _defineProperty2.default)(target, key, source[key]); }) : Object.getOwnPropertyDescriptors ? Object.defineProperties(target, Object.getOwnPropertyDescriptors(source)) : ownKeys(Object(source)).forEach(function (key) { Object.defineProperty(target, key, Object.getOwnPropertyDescriptor(source, key)); }); } return target; }
-var outdentListItemsSelected = function outdentListItemsSelected(tr, state, featureFlags) {
+var outdentListItemsSelected = function outdentListItemsSelected(tr, featureFlags) {
   var originalSelection = tr.selection;
   var normalizedSelection = (0, _lists.normalizeListItemsSelection)({
     selection: tr.selection,
@@ -53,7 +53,6 @@ var outdentListItemsSelected = function outdentListItemsSelected(tr, state, feat
       extractListItemsRangeFromList({
         tr: tr,
         range: mappedRange,
-        state: state,
         featureFlags: featureFlags
       });
       hasNormalizedToPositionLiftedOut = hasNormalizedToPositionLiftedOut || oldTo >= range.from && oldTo < range.to;
@@ -176,7 +175,6 @@ var outdentRangeToParentList = function outdentRangeToParentList(_ref2) {
 var extractListItemsRangeFromList = function extractListItemsRangeFromList(_ref3) {
   var tr = _ref3.tr,
     range = _ref3.range,
-    state = _ref3.state,
     featureFlags = _ref3.featureFlags;
   var list = range.parent;
   var $start = tr.doc.resolve(range.start);

package/dist/cjs/commands/indent-list.js

@@ -8,6 +8,7 @@ exports.indentList = void 0;
 var _defineProperty2 = _interopRequireDefault(require("@babel/runtime/helpers/defineProperty"));
 var _analytics = require("@atlaskit/editor-common/analytics");
 var _lists = require("@atlaskit/editor-common/lists");
+var _preset = require("@atlaskit/editor-common/preset");
 var _utils = require("@atlaskit/editor-common/utils");
 var _history = require("@atlaskit/editor-prosemirror/history");
 var _indentListItemsSelected = require("../actions/indent-list-items-selected");
@@ -19,13 +20,13 @@ function _objectSpread(target) { for (var i = 1; i < arguments.length; i++) { va
 var indentList = function indentList(editorAnalyticsAPI) {
   return function () {
     var inputMethod = arguments.length > 0 && arguments[0] !== undefined ? arguments[0] : _analytics.INPUT_METHOD.KEYBOARD;
-    return function (state, dispatch) {
-      var tr = state.tr,
-        $from = state.selection.$from;
+    return function (_ref) {
+      var tr = _ref.tr;
+      var $from = tr.selection.$from;
 
       // don't indent if selection is not inside a list
-      if (!(0, _selection.isInsideListItem)(state)) {
-        return false;
+      if (!(0, _selection.isInsideListItem)(tr)) {
+        return null;
       }
 
       // Save the history, so it could undo/revert to the same state before the indent, see https://product-fabric.atlassian.net/browse/ED-14753
@@ -33,12 +34,12 @@ var indentList = function indentList(editorAnalyticsAPI) {
       var firstListItemSelectedAttributes = (0, _lists.getListItemAttributes)($from);
       var parentListNode = (0, _find.findFirstParentListNode)($from);
       if (!parentListNode || firstListItemSelectedAttributes && firstListItemSelectedAttributes.indentLevel === 0 && firstListItemSelectedAttributes.itemIndex === 0) {
-        if ((0, _selection.isInsideTableCell)(state)) {
+        if ((0, _selection.isInsideTableCell)(tr)) {
           // dont consume tab, as table-keymap should move cursor to next cell
-          return false;
+          return null;
         } else {
           // Even though this is a non-operation, we don't want to send this event to the browser. Because if we return false, the browser will move the focus to another place
-          return true;
+          return new _preset.PassiveTransaction();
         }
       }
       var currentListNode = parentListNode.node;
@@ -50,21 +51,18 @@ var indentList = function indentList(editorAnalyticsAPI) {
       });
       if (maximimunNestedLevelReached || !tr.docChanged) {
         // Even though this is a non-operation, we don't want to send this event to the browser. Because if we return false, the browser will move the focus to another place
-        return true;
+        return new _preset.PassiveTransaction();
       }
       editorAnalyticsAPI === null || editorAnalyticsAPI === void 0 ? void 0 : editorAnalyticsAPI.attachAnalyticsEvent({
         action: _analytics.ACTION.INDENTED,
         actionSubject: _analytics.ACTION_SUBJECT.LIST,
         actionSubjectId: actionSubjectId,
         eventType: _analytics.EVENT_TYPE.TRACK,
-        attributes: _objectSpread(_objectSpread({}, (0, _lists.getCommonListAnalyticsAttributes)(state)), {}, {
+        attributes: _objectSpread(_objectSpread({}, (0, _lists.getCommonListAnalyticsAttributes)(tr)), {}, {
           inputMethod: inputMethod
         })
       })(tr);
-      if (dispatch) {
-        dispatch(tr);
-      }
-      return true;
+      return tr;
     };
   };
 };

package/dist/cjs/commands/index.js

@@ -22,6 +22,7 @@ var _defineProperty2 = _interopRequireDefault(require("@babel/runtime/helpers/de
 var _analytics = require("@atlaskit/editor-common/analytics");
 var _commands = require("@atlaskit/editor-common/commands");
 var _lists = require("@atlaskit/editor-common/lists");
+var _preset = require("@atlaskit/editor-common/preset");
 var _selection = require("@atlaskit/editor-common/selection");
 var _utils = require("@atlaskit/editor-common/utils");
 var _commands2 = require("@atlaskit/editor-prosemirror/commands");
@@ -54,7 +55,7 @@ var enterKeyCommand = function enterKeyCommand(editorAnalyticsAPI) {
           /** Check if the wrapper has any visible content */
           var wrapperHasContent = (0, _utils.hasVisibleContent)(wrapper);
           if (!wrapperHasContent) {
-            return (0, _outdentList.outdentList)(editorAnalyticsAPI)(_analytics.INPUT_METHOD.KEYBOARD, featureFlags)(state, dispatch);
+            return (0, _preset.editorCommandToPMCommand)((0, _outdentList.outdentList)(editorAnalyticsAPI)(_analytics.INPUT_METHOD.KEYBOARD, featureFlags))(state, dispatch);
           } else if (!(0, _utils2.hasParentNodeOfType)(codeBlock)(selection)) {
             return splitListItem(listItem)(state, dispatch);
           }
@@ -73,10 +74,14 @@ var backspaceKeyCommand = function backspaceKeyCommand(editorAnalyticsAPI) {
       // directly to an empty list item above, or outdent this node
       (0, _utils.filterCommand)([_utils.isEmptySelectionAtStart,
       // list items might have multiple paragraphs; only do this at the first one
-      _isFirstChildOfParent.isFirstChildOfParent, _selection2.isInsideListItem], (0, _commands2.chainCommands)(deletePreviousEmptyListItem, (0, _outdentList.outdentList)(editorAnalyticsAPI)(_analytics.INPUT_METHOD.KEYBOARD, featureFlags))),
+      _isFirstChildOfParent.isFirstChildOfParent, function (state) {
+        return (0, _selection2.isInsideListItem)(state.tr);
+      }], (0, _commands2.chainCommands)(deletePreviousEmptyListItem, (0, _preset.editorCommandToPMCommand)((0, _outdentList.outdentList)(editorAnalyticsAPI)(_analytics.INPUT_METHOD.KEYBOARD, featureFlags)))),
       // if we're just inside a paragraph node (or gapcursor is shown) and backspace, then try to join
       // the text to the previous list item, if one exists
-      (0, _utils.filterCommand)([_utils.isEmptySelectionAtStart, _selection2.canJoinToPreviousListItem], joinToPreviousListItem))(state, dispatch);
+      (0, _utils.filterCommand)([_utils.isEmptySelectionAtStart, function (state) {
+        return (0, _selection2.canJoinToPreviousListItem)(state.tr);
+      }], joinToPreviousListItem))(state, dispatch);
     };
   };
 };
@@ -116,13 +121,13 @@ function untoggleSelectedList(tr) {
 }
 var toggleList = function toggleList(editorAnalyticsAPI) {
   return function (inputMethod, listType) {
-    return function (state, dispatch) {
-      var tr = state.tr;
+    return function (_ref) {
+      var tr = _ref.tr;
       var listInsideSelection = (0, _selection2.selectionContainsList)(tr);
-      var listNodeType = state.schema.nodes[listType];
+      var listNodeType = tr.doc.type.schema.nodes[listType];
       var actionSubjectId = listType === 'bulletList' ? _analytics.ACTION_SUBJECT_ID.FORMAT_LIST_BULLET : _analytics.ACTION_SUBJECT_ID.FORMAT_LIST_NUMBER;
       if (listInsideSelection) {
-        var selection = state.selection;
+        var selection = tr.selection;
 
         // for gap cursor or node selection - list is expected 1 level up (listItem -> list)
         // for text selection - list is expected 2 levels up (paragraph -> listItem -> list)
@@ -131,22 +136,19 @@ var toggleList = function toggleList(editorAnalyticsAPI) {
         var toNode = selection.$to.node(selection.$to.depth - positionDiff);
         var transformedFrom = listInsideSelection.type.name === 'bulletList' ? _analytics.ACTION_SUBJECT_ID.FORMAT_LIST_BULLET : _analytics.ACTION_SUBJECT_ID.FORMAT_LIST_NUMBER;
         if ((fromNode === null || fromNode === void 0 ? void 0 : fromNode.type.name) === listType && (toNode === null || toNode === void 0 ? void 0 : toNode.type.name) === listType) {
-          var _tr2 = state.tr;
-          untoggleSelectedList(_tr2);
+          var commonAttributes = (0, _lists.getCommonListAnalyticsAttributes)(tr);
+          untoggleSelectedList(tr);
           editorAnalyticsAPI === null || editorAnalyticsAPI === void 0 ? void 0 : editorAnalyticsAPI.attachAnalyticsEvent({
             action: _analytics.ACTION.CONVERTED,
             actionSubject: _analytics.ACTION_SUBJECT.LIST,
             actionSubjectId: _analytics.ACTION_SUBJECT_ID.TEXT,
             eventType: _analytics.EVENT_TYPE.TRACK,
-            attributes: _objectSpread(_objectSpread({}, (0, _lists.getCommonListAnalyticsAttributes)(state)), {}, {
+            attributes: _objectSpread(_objectSpread({}, commonAttributes), {}, {
               transformedFrom: transformedFrom,
               inputMethod: inputMethod
             })
-          })(_tr2);
-          if (dispatch) {
-            dispatch(_tr2);
-          }
-          return true;
+          })(tr);
+          return tr;
         }
         (0, _conversions.convertListType)({
           tr: tr,
@@ -157,7 +159,7 @@ var toggleList = function toggleList(editorAnalyticsAPI) {
           actionSubject: _analytics.ACTION_SUBJECT.LIST,
           actionSubjectId: actionSubjectId,
           eventType: _analytics.EVENT_TYPE.TRACK,
-          attributes: _objectSpread(_objectSpread({}, (0, _lists.getCommonListAnalyticsAttributes)(state)), {}, {
+          attributes: _objectSpread(_objectSpread({}, (0, _lists.getCommonListAnalyticsAttributes)(tr)), {}, {
             transformedFrom: transformedFrom,
             inputMethod: inputMethod
           })
@@ -181,27 +183,24 @@ var toggleList = function toggleList(editorAnalyticsAPI) {
       // If document wasn't changed, return false from the command to indicate that the
       // editing action failed
       if (!tr.docChanged) {
-        return false;
+        return null;
       }
-      if (dispatch) {
-        dispatch(tr);
-      }
-      return true;
+      return tr;
     };
   };
 };
 exports.toggleList = toggleList;
 var toggleBulletList = function toggleBulletList(editorAnalyticsAPI) {
-  return function (view) {
-    var inputMethod = arguments.length > 1 && arguments[1] !== undefined ? arguments[1] : _analytics.INPUT_METHOD.TOOLBAR;
-    return toggleList(editorAnalyticsAPI)(inputMethod, 'bulletList')(view.state, view.dispatch);
+  return function () {
+    var inputMethod = arguments.length > 0 && arguments[0] !== undefined ? arguments[0] : _analytics.INPUT_METHOD.TOOLBAR;
+    return toggleList(editorAnalyticsAPI)(inputMethod, 'bulletList');
   };
 };
 exports.toggleBulletList = toggleBulletList;
 var toggleOrderedList = function toggleOrderedList(editorAnalyticsAPI) {
-  return function (view) {
-    var inputMethod = arguments.length > 1 && arguments[1] !== undefined ? arguments[1] : _analytics.INPUT_METHOD.TOOLBAR;
-    return toggleList(editorAnalyticsAPI)(inputMethod, 'orderedList')(view.state, view.dispatch);
+  return function () {
+    var inputMethod = arguments.length > 0 && arguments[0] !== undefined ? arguments[0] : _analytics.INPUT_METHOD.TOOLBAR;
+    return toggleList(editorAnalyticsAPI)(inputMethod, 'orderedList');
   };
 };
 

package/dist/cjs/commands/outdent-list.js

@@ -8,6 +8,7 @@ exports.outdentList = void 0;
 var _defineProperty2 = _interopRequireDefault(require("@babel/runtime/helpers/defineProperty"));
 var _analytics = require("@atlaskit/editor-common/analytics");
 var _lists = require("@atlaskit/editor-common/lists");
+var _preset = require("@atlaskit/editor-common/preset");
 var _utils = require("@atlaskit/editor-common/utils");
 var _history = require("@atlaskit/editor-prosemirror/history");
 var _outdentListItemsSelected = require("../actions/outdent-list-items-selected");
@@ -20,26 +21,27 @@ var outdentList = function outdentList(editorAnalyticsAPI) {
   return function () {
     var inputMethod = arguments.length > 0 && arguments[0] !== undefined ? arguments[0] : _analytics.INPUT_METHOD.KEYBOARD;
     var featureFlags = arguments.length > 1 ? arguments[1] : undefined;
-    return function (state, dispatch) {
-      if (!(0, _selection.isInsideListItem)(state)) {
-        return false;
+    return function (_ref) {
+      var tr = _ref.tr;
+      if (!(0, _selection.isInsideListItem)(tr)) {
+        return null;
       }
-      var $from = state.selection.$from;
+      var $from = tr.selection.$from;
       var parentListNode = (0, _find.findFirstParentListNode)($from);
       if (!parentListNode) {
         // Even though this is a non-operation, we don't want to send this event to the browser. Because if we return false, the browser will move the focus to another place
-        return true;
+        return new _preset.PassiveTransaction();
       }
 
       // Save the history, so it could undo/revert to the same state before the outdent, see https://product-fabric.atlassian.net/browse/ED-14753
-      (0, _history.closeHistory)(state.tr);
+      (0, _history.closeHistory)(tr);
       var actionSubjectId = (0, _utils.isBulletList)(parentListNode.node) ? _analytics.ACTION_SUBJECT_ID.FORMAT_LIST_BULLET : _analytics.ACTION_SUBJECT_ID.FORMAT_LIST_NUMBER;
-      var customTr = state.tr;
-      (0, _outdentListItemsSelected.outdentListItemsSelected)(customTr, state, featureFlags);
+      var customTr = tr;
+      (0, _outdentListItemsSelected.outdentListItemsSelected)(customTr, featureFlags);
       if (!customTr || !customTr.docChanged) {
         // Even though this is a non-operation, we don't want to send this event to the browser. Because if we return false, the browser will move the focus to another place
         // If inside table cell and can't outdent list, then let it handle by table keymap
-        return !(0, _selection.isInsideTableCell)(state);
+        return !(0, _selection.isInsideTableCell)(customTr) ? new _preset.PassiveTransaction() : null;
       }
       var restartListsAttributes = {};
       if (featureFlags !== null && featureFlags !== void 0 && featureFlags.restartNumberedLists) {
@@ -56,14 +58,11 @@ var outdentList = function outdentList(editorAnalyticsAPI) {
         actionSubject: _analytics.ACTION_SUBJECT.LIST,
         actionSubjectId: actionSubjectId,
         eventType: _analytics.EVENT_TYPE.TRACK,
-        attributes: _objectSpread(_objectSpread(_objectSpread({}, (0, _lists.getCommonListAnalyticsAttributes)(state)), restartListsAttributes), {}, {
+        attributes: _objectSpread(_objectSpread(_objectSpread({}, (0, _lists.getCommonListAnalyticsAttributes)(customTr)), restartListsAttributes), {}, {
           inputMethod: inputMethod
         })
       })(customTr);
-      if (dispatch) {
-        dispatch(customTr);
-      }
-      return true;
+      return customTr;
     };
   };
 };

package/dist/cjs/plugin.js

@@ -28,13 +28,17 @@ var listPlugin = function listPlugin(options, api) {
   return {
     name: 'list',
     actions: {
-      indentList: (0, _commands.indentList)(editorAnalyticsAPI),
-      outdentList: (0, _commands.outdentList)(editorAnalyticsAPI),
-      toggleOrderedList: (0, _commands.toggleOrderedList)(editorAnalyticsAPI),
-      toggleBulletList: (0, _commands.toggleBulletList)(editorAnalyticsAPI),
       isInsideListItem: _selection.isInsideListItem,
       findRootParentListNode: _find.findRootParentListNode
     },
+    commands: {
+      indentList: (0, _commands.indentList)(editorAnalyticsAPI),
+      outdentList: function outdentList(inputMethod) {
+        return (0, _commands.outdentList)(editorAnalyticsAPI)(inputMethod, featureFlags);
+      },
+      toggleOrderedList: (0, _commands.toggleOrderedList)(editorAnalyticsAPI),
+      toggleBulletList: (0, _commands.toggleBulletList)(editorAnalyticsAPI)
+    },
     getSharedState: function getSharedState(editorState) {
       if (!editorState) {
         return undefined;

package/dist/cjs/pm-plugins/keymap.js

@@ -11,10 +11,10 @@ var _keymap = require("@atlaskit/editor-prosemirror/keymap");
 var _commands = require("../commands");
 function keymapPlugin(featureFlags, editorAnalyticsAPI) {
   var list = {};
-  (0, _keymaps.bindKeymapWithCommand)((0, _keymaps.findShortcutByKeymap)(_keymaps.toggleOrderedList), (0, _commands.toggleList)(editorAnalyticsAPI)(_analytics.INPUT_METHOD.KEYBOARD, 'orderedList'), list);
-  (0, _keymaps.bindKeymapWithCommand)((0, _keymaps.findShortcutByKeymap)(_keymaps.toggleBulletList), (0, _commands.toggleList)(editorAnalyticsAPI)(_analytics.INPUT_METHOD.KEYBOARD, 'bulletList'), list);
-  (0, _keymaps.bindKeymapWithCommand)(_keymaps.indentList.common, (0, _commands.indentList)(editorAnalyticsAPI)(_analytics.INPUT_METHOD.KEYBOARD), list);
-  (0, _keymaps.bindKeymapWithCommand)(_keymaps.outdentList.common, (0, _commands.outdentList)(editorAnalyticsAPI)(_analytics.INPUT_METHOD.KEYBOARD, featureFlags), list);
+  (0, _keymaps.bindKeymapWithEditorCommand)((0, _keymaps.findShortcutByKeymap)(_keymaps.toggleOrderedList), (0, _commands.toggleList)(editorAnalyticsAPI)(_analytics.INPUT_METHOD.KEYBOARD, 'orderedList'), list);
+  (0, _keymaps.bindKeymapWithEditorCommand)((0, _keymaps.findShortcutByKeymap)(_keymaps.toggleBulletList), (0, _commands.toggleList)(editorAnalyticsAPI)(_analytics.INPUT_METHOD.KEYBOARD, 'bulletList'), list);
+  (0, _keymaps.bindKeymapWithEditorCommand)(_keymaps.indentList.common, (0, _commands.indentList)(editorAnalyticsAPI)(_analytics.INPUT_METHOD.KEYBOARD), list);
+  (0, _keymaps.bindKeymapWithEditorCommand)(_keymaps.outdentList.common, (0, _commands.outdentList)(editorAnalyticsAPI)(_analytics.INPUT_METHOD.KEYBOARD, featureFlags), list);
   (0, _keymaps.bindKeymapWithCommand)(_keymaps.enter.common, (0, _commands.enterKeyCommand)(editorAnalyticsAPI)(featureFlags), list);
   (0, _keymaps.bindKeymapWithCommand)(_keymaps.backspace.common, (0, _commands.backspaceKeyCommand)(editorAnalyticsAPI)(featureFlags), list);
   (0, _keymaps.bindKeymapWithCommand)(_keymaps.deleteKey.common, (0, _commands.deleteKeyCommand)(editorAnalyticsAPI), list);

package/dist/cjs/utils/selection.js

@@ -39,27 +39,27 @@ var isWrappingPossible = function isWrappingPossible(nodeType, selection) {
 
 // canOutdent
 exports.isWrappingPossible = isWrappingPossible;
-var isInsideListItem = function isInsideListItem(state) {
-  var parent = state.selection.$from.parent;
-  var listItem = state.schema.nodes.listItem;
-  if (state.selection instanceof _selection.GapCursorSelection) {
+var isInsideListItem = function isInsideListItem(tr) {
+  var parent = tr.selection.$from.parent;
+  var listItem = tr.doc.type.schema.nodes.listItem;
+  if (tr.selection instanceof _selection.GapCursorSelection) {
     return (0, _utils.isListItemNode)(parent);
   }
-  return (0, _utils2.hasParentNodeOfType)(listItem)(state.selection) && (0, _utils.isParagraphNode)(parent);
+  return (0, _utils2.hasParentNodeOfType)(listItem)(tr.selection) && (0, _utils.isParagraphNode)(parent);
 };
 exports.isInsideListItem = isInsideListItem;
-var isInsideTableCell = function isInsideTableCell(state) {
-  var _state$schema$nodes = state.schema.nodes,
-    tableCell = _state$schema$nodes.tableCell,
-    tableHeader = _state$schema$nodes.tableHeader;
-  return !!(0, _utils2.findParentNodeOfType)([tableCell, tableHeader])(state.selection);
+var isInsideTableCell = function isInsideTableCell(tr) {
+  var _tr$doc$type$schema$n = tr.doc.type.schema.nodes,
+    tableCell = _tr$doc$type$schema$n.tableCell,
+    tableHeader = _tr$doc$type$schema$n.tableHeader;
+  return !!(0, _utils2.findParentNodeOfType)([tableCell, tableHeader])(tr.selection);
 };
 exports.isInsideTableCell = isInsideTableCell;
-var canJoinToPreviousListItem = function canJoinToPreviousListItem(state) {
-  var $from = state.selection.$from;
-  var $before = state.doc.resolve($from.pos - 1);
+var canJoinToPreviousListItem = function canJoinToPreviousListItem(tr) {
+  var $from = tr.selection.$from;
+  var $before = tr.doc.resolve($from.pos - 1);
   var nodeBefore = $before ? $before.nodeBefore : null;
-  if (state.selection instanceof _selection.GapCursorSelection) {
+  if (tr.selection instanceof _selection.GapCursorSelection) {
     nodeBefore = $from.nodeBefore;
   }
   return (0, _utils.isListNode)(nodeBefore);

package/dist/es2019/actions/outdent-list-items-selected.js

@@ -8,7 +8,7 @@ import { liftTarget, ReplaceAroundStep, ReplaceStep } from '@atlaskit/editor-pro
 import { getRestartListsAttributes, storeRestartListsAttributes } from '../utils/analytics';
 import { findFirstParentListItemNode, findRootParentListNode } from '../utils/find';
 import { createListNodeRange } from '../utils/selection';
-export const outdentListItemsSelected = (tr, state, featureFlags) => {
+export const outdentListItemsSelected = (tr, featureFlags) => {
   const originalSelection = tr.selection;
   const normalizedSelection = normalizeListItemsSelection({
     selection: tr.selection,
@@ -45,7 +45,6 @@ export const outdentListItemsSelected = (tr, state, featureFlags) => {
       extractListItemsRangeFromList({
         tr,
         range: mappedRange,
-        state,
         featureFlags
       });
       hasNormalizedToPositionLiftedOut = hasNormalizedToPositionLiftedOut || oldTo >= range.from && oldTo < range.to;
@@ -177,7 +176,6 @@ const outdentRangeToParentList = ({
 const extractListItemsRangeFromList = ({
   tr,
   range,
-  state,
   featureFlags
 }) => {
   const list = range.parent;

package/dist/es2019/commands/indent-list.js

@@ -1,5 +1,6 @@
 import { ACTION, ACTION_SUBJECT, ACTION_SUBJECT_ID, EVENT_TYPE, INPUT_METHOD } from '@atlaskit/editor-common/analytics';
 import { getCommonListAnalyticsAttributes, getListItemAttributes, hasValidListIndentationLevel } from '@atlaskit/editor-common/lists';
+import { PassiveTransaction } from '@atlaskit/editor-common/preset';
 import { isBulletList } from '@atlaskit/editor-common/utils';
 import { closeHistory } from '@atlaskit/editor-prosemirror/history';
 import { indentListItemsSelected as indentListAction } from '../actions/indent-list-items-selected';
@@ -7,17 +8,18 @@ import { MAX_NESTED_LIST_INDENTATION } from '../types';
 import { findFirstParentListNode } from '../utils/find';
 import { isInsideListItem, isInsideTableCell } from '../utils/selection';
 export const indentList = editorAnalyticsAPI => (inputMethod = INPUT_METHOD.KEYBOARD) => {
-  return function (state, dispatch) {
+  return function ({
+    tr
+  }) {
     const {
-      tr,
       selection: {
         $from
       }
-    } = state;
+    } = tr;
 
     // don't indent if selection is not inside a list
-    if (!isInsideListItem(state)) {
-      return false;
+    if (!isInsideListItem(tr)) {
+      return null;
     }
 
     // Save the history, so it could undo/revert to the same state before the indent, see https://product-fabric.atlassian.net/browse/ED-14753
@@ -25,12 +27,12 @@ export const indentList = editorAnalyticsAPI => (inputMethod = INPUT_METHOD.KEYB
     const firstListItemSelectedAttributes = getListItemAttributes($from);
     const parentListNode = findFirstParentListNode($from);
     if (!parentListNode || firstListItemSelectedAttributes && firstListItemSelectedAttributes.indentLevel === 0 && firstListItemSelectedAttributes.itemIndex === 0) {
-      if (isInsideTableCell(state)) {
+      if (isInsideTableCell(tr)) {
         // dont consume tab, as table-keymap should move cursor to next cell
-        return false;
+        return null;
       } else {
         // Even though this is a non-operation, we don't want to send this event to the browser. Because if we return false, the browser will move the focus to another place
-        return true;
+        return new PassiveTransaction();
       }
     }
     const currentListNode = parentListNode.node;
@@ -42,7 +44,7 @@ export const indentList = editorAnalyticsAPI => (inputMethod = INPUT_METHOD.KEYB
     });
     if (maximimunNestedLevelReached || !tr.docChanged) {
       // Even though this is a non-operation, we don't want to send this event to the browser. Because if we return false, the browser will move the focus to another place
-      return true;
+      return new PassiveTransaction();
     }
     editorAnalyticsAPI === null || editorAnalyticsAPI === void 0 ? void 0 : editorAnalyticsAPI.attachAnalyticsEvent({
       action: ACTION.INDENTED,
@@ -50,13 +52,10 @@ export const indentList = editorAnalyticsAPI => (inputMethod = INPUT_METHOD.KEYB
       actionSubjectId,
       eventType: EVENT_TYPE.TRACK,
       attributes: {
-        ...getCommonListAnalyticsAttributes(state),
+        ...getCommonListAnalyticsAttributes(tr),
         inputMethod
       }
     })(tr);
-    if (dispatch) {
-      dispatch(tr);
-    }
-    return true;
+    return tr;
   };
 };

package/dist/es2019/commands/index.js

@@ -1,6 +1,7 @@
 import { ACTION, ACTION_SUBJECT, ACTION_SUBJECT_ID, EVENT_TYPE, INPUT_METHOD } from '@atlaskit/editor-common/analytics';
 import { findCutBefore } from '@atlaskit/editor-common/commands';
 import { getCommonListAnalyticsAttributes, moveTargetIntoList } from '@atlaskit/editor-common/lists';
+import { editorCommandToPMCommand } from '@atlaskit/editor-common/preset';
 import { GapCursorSelection } from '@atlaskit/editor-common/selection';
 import { filterCommand as filter, hasVisibleContent, isEmptySelectionAtStart } from '@atlaskit/editor-common/utils';
 import { chainCommands } from '@atlaskit/editor-prosemirror/commands';
@@ -35,7 +36,7 @@ export const enterKeyCommand = editorAnalyticsAPI => featureFlags => (state, dis
       /** Check if the wrapper has any visible content */
       const wrapperHasContent = hasVisibleContent(wrapper);
       if (!wrapperHasContent) {
-        return outdentList(editorAnalyticsAPI)(INPUT_METHOD.KEYBOARD, featureFlags)(state, dispatch);
+        return editorCommandToPMCommand(outdentList(editorAnalyticsAPI)(INPUT_METHOD.KEYBOARD, featureFlags))(state, dispatch);
       } else if (!hasParentNodeOfType(codeBlock)(selection)) {
         return splitListItem(listItem)(state, dispatch);
       }
@@ -49,10 +50,10 @@ export const backspaceKeyCommand = editorAnalyticsAPI => featureFlags => (state,
   // directly to an empty list item above, or outdent this node
   filter([isEmptySelectionAtStart,
   // list items might have multiple paragraphs; only do this at the first one
-  isFirstChildOfParent, isInsideListItem], chainCommands(deletePreviousEmptyListItem, outdentList(editorAnalyticsAPI)(INPUT_METHOD.KEYBOARD, featureFlags))),
+  isFirstChildOfParent, state => isInsideListItem(state.tr)], chainCommands(deletePreviousEmptyListItem, editorCommandToPMCommand(outdentList(editorAnalyticsAPI)(INPUT_METHOD.KEYBOARD, featureFlags)))),
   // if we're just inside a paragraph node (or gapcursor is shown) and backspace, then try to join
   // the text to the previous list item, if one exists
-  filter([isEmptySelectionAtStart, canJoinToPreviousListItem], joinToPreviousListItem))(state, dispatch);
+  filter([isEmptySelectionAtStart, state => canJoinToPreviousListItem(state.tr)], joinToPreviousListItem))(state, dispatch);
 };
 export const deleteKeyCommand = editorAnalyticsAPI => joinListItemForward(editorAnalyticsAPI);
 
@@ -87,15 +88,16 @@ function untoggleSelectedList(tr) {
   return liftTextSelectionList(selection, tr);
 }
 export const toggleList = editorAnalyticsAPI => (inputMethod, listType) => {
-  return function (state, dispatch) {
-    let tr = state.tr;
+  return function ({
+    tr
+  }) {
     const listInsideSelection = selectionContainsList(tr);
-    const listNodeType = state.schema.nodes[listType];
+    const listNodeType = tr.doc.type.schema.nodes[listType];
     const actionSubjectId = listType === 'bulletList' ? ACTION_SUBJECT_ID.FORMAT_LIST_BULLET : ACTION_SUBJECT_ID.FORMAT_LIST_NUMBER;
     if (listInsideSelection) {
       const {
         selection
-      } = state;
+      } = tr;
 
       // for gap cursor or node selection - list is expected 1 level up (listItem -> list)
       // for text selection - list is expected 2 levels up (paragraph -> listItem -> list)
@@ -104,7 +106,7 @@ export const toggleList = editorAnalyticsAPI => (inputMethod, listType) => {
       const toNode = selection.$to.node(selection.$to.depth - positionDiff);
       const transformedFrom = listInsideSelection.type.name === 'bulletList' ? ACTION_SUBJECT_ID.FORMAT_LIST_BULLET : ACTION_SUBJECT_ID.FORMAT_LIST_NUMBER;
       if ((fromNode === null || fromNode === void 0 ? void 0 : fromNode.type.name) === listType && (toNode === null || toNode === void 0 ? void 0 : toNode.type.name) === listType) {
-        let tr = state.tr;
+        const commonAttributes = getCommonListAnalyticsAttributes(tr);
         untoggleSelectedList(tr);
         editorAnalyticsAPI === null || editorAnalyticsAPI === void 0 ? void 0 : editorAnalyticsAPI.attachAnalyticsEvent({
           action: ACTION.CONVERTED,
@@ -112,15 +114,12 @@ export const toggleList = editorAnalyticsAPI => (inputMethod, listType) => {
           actionSubjectId: ACTION_SUBJECT_ID.TEXT,
           eventType: EVENT_TYPE.TRACK,
           attributes: {
-            ...getCommonListAnalyticsAttributes(state),
+            ...commonAttributes,
             transformedFrom,
             inputMethod
           }
         })(tr);
-        if (dispatch) {
-          dispatch(tr);
-        }
-        return true;
+        return tr;
       }
       convertListType({
         tr,
@@ -132,7 +131,7 @@ export const toggleList = editorAnalyticsAPI => (inputMethod, listType) => {
         actionSubjectId,
         eventType: EVENT_TYPE.TRACK,
         attributes: {
-          ...getCommonListAnalyticsAttributes(state),
+          ...getCommonListAnalyticsAttributes(tr),
           transformedFrom,
           inputMethod
         }
@@ -156,19 +155,16 @@ export const toggleList = editorAnalyticsAPI => (inputMethod, listType) => {
     // If document wasn't changed, return false from the command to indicate that the
     // editing action failed
     if (!tr.docChanged) {
-      return false;
+      return null;
     }
-    if (dispatch) {
-      dispatch(tr);
-    }
-    return true;
+    return tr;
   };
 };
-export const toggleBulletList = editorAnalyticsAPI => (view, inputMethod = INPUT_METHOD.TOOLBAR) => {
-  return toggleList(editorAnalyticsAPI)(inputMethod, 'bulletList')(view.state, view.dispatch);
+export const toggleBulletList = editorAnalyticsAPI => (inputMethod = INPUT_METHOD.TOOLBAR) => {
+  return toggleList(editorAnalyticsAPI)(inputMethod, 'bulletList');
 };
-export const toggleOrderedList = editorAnalyticsAPI => (view, inputMethod = INPUT_METHOD.TOOLBAR) => {
-  return toggleList(editorAnalyticsAPI)(inputMethod, 'orderedList')(view.state, view.dispatch);
+export const toggleOrderedList = editorAnalyticsAPI => (inputMethod = INPUT_METHOD.TOOLBAR) => {
+  return toggleList(editorAnalyticsAPI)(inputMethod, 'orderedList');
 };
 
 /**