@atlaskit/editor-plugin-layout 13.3.21 → 13.3.23

package/CHANGELOG.md

@@ -1,5 +1,33 @@
 # @atlaskit/editor-plugin-layout
 
+## 13.3.23
+
+### Patch Changes
+
+- Updated dependencies
+
+## 13.3.22
+
+### Patch Changes
+
+- [`b90bdc71cdf99`](https://bitbucket.org/atlassian/atlassian-frontend-monorepo/commits/b90bdc71cdf99) -
+  Fix layout column delete shortcut deleting the whole column when the caret is a text selection
+  inside a column (e.g. a table nested in a layout), gated behind
+  platform_editor_layout_column_delete_shortcut_fix.
+
+  Adds a new experiment key `platform_editor_layout_column_delete_shortcut_fix` to
+  `@atlaskit/tmp-editor-statsig`. Usage:
+
+  ```ts
+  import { expValEquals } from '@atlaskit/tmp-editor-statsig/exp-val-equals';
+
+  if (expValEquals('platform_editor_layout_column_delete_shortcut_fix', 'isEnabled', true)) {
+  	// new behaviour: preserve the column when the caret is a text selection inside it
+  }
+  ```
+
+- Updated dependencies
+
 ## 13.3.21
 
 ### Patch Changes

package/dist/cjs/pm-plugins/actions.js

@@ -910,7 +910,11 @@ var deleteLayoutColumn = exports.deleteLayoutColumn = function deleteLayoutColum
     if (!(0, _expValEquals.expValEquals)('platform_editor_layout_column_menu', 'isEnabled', true)) {
       return null;
     }
-    var selectedLayoutColumnsResult = (0, _layoutColumnSelection.getLayoutColumnsFromContentSelection)(tr.selection);
+
+    // Only delete columns that are explicitly selected (a column NodeSelection or a selection
+    // fully containing columns). This stops a bare caret inside a column — including inside
+    // nested content such as a table — from deleting the whole column via the delete shortcut.
+    var selectedLayoutColumnsResult = (0, _expValEquals.expValEquals)('platform_editor_layout_column_delete_shortcut_fix', 'isEnabled', true) ? (0, _layoutColumnSelection.getSelectedLayoutColumnsFromSelection)(tr.selection) : (0, _layoutColumnSelection.getLayoutColumnsFromContentSelection)(tr.selection);
     if (!selectedLayoutColumnsResult || selectedLayoutColumnsResult.selectedLayoutColumns.length === 0) {
       return null;
     }

package/dist/es2019/pm-plugins/actions.js

@@ -874,7 +874,11 @@ export const deleteLayoutColumn = ({
   if (!expValEquals('platform_editor_layout_column_menu', 'isEnabled', true)) {
     return null;
   }
-  const selectedLayoutColumnsResult = getLayoutColumnsFromContentSelection(tr.selection);
+
+  // Only delete columns that are explicitly selected (a column NodeSelection or a selection
+  // fully containing columns). This stops a bare caret inside a column — including inside
+  // nested content such as a table — from deleting the whole column via the delete shortcut.
+  const selectedLayoutColumnsResult = expValEquals('platform_editor_layout_column_delete_shortcut_fix', 'isEnabled', true) ? getSelectedLayoutColumnsFromSelection(tr.selection) : getLayoutColumnsFromContentSelection(tr.selection);
   if (!selectedLayoutColumnsResult || selectedLayoutColumnsResult.selectedLayoutColumns.length === 0) {
     return null;
   }

package/dist/esm/pm-plugins/actions.js

@@ -900,7 +900,11 @@ export var deleteLayoutColumn = function deleteLayoutColumn() {
     if (!expValEquals('platform_editor_layout_column_menu', 'isEnabled', true)) {
       return null;
     }
-    var selectedLayoutColumnsResult = getLayoutColumnsFromContentSelection(tr.selection);
+
+    // Only delete columns that are explicitly selected (a column NodeSelection or a selection
+    // fully containing columns). This stops a bare caret inside a column — including inside
+    // nested content such as a table — from deleting the whole column via the delete shortcut.
+    var selectedLayoutColumnsResult = expValEquals('platform_editor_layout_column_delete_shortcut_fix', 'isEnabled', true) ? getSelectedLayoutColumnsFromSelection(tr.selection) : getLayoutColumnsFromContentSelection(tr.selection);
     if (!selectedLayoutColumnsResult || selectedLayoutColumnsResult.selectedLayoutColumns.length === 0) {
       return null;
     }

package/package.json

@@ -1,6 +1,6 @@
 {
 	"name": "@atlaskit/editor-plugin-layout",
-	"version": "13.3.21",
+	"version": "13.3.23",
 	"description": "Layout plugin for @atlaskit/editor-core",
 	"author": "Atlassian Pty Ltd",
 	"license": "Apache-2.0",
@@ -33,23 +33,23 @@
 		"@atlaskit/editor-plugin-selection": "^12.0.0",
 		"@atlaskit/editor-plugin-toolbar": "^9.0.0",
 		"@atlaskit/editor-plugin-ui-control-registry": "^6.0.0",
-		"@atlaskit/editor-plugin-user-intent": "^10.0.0",
+		"@atlaskit/editor-plugin-user-intent": "^10.1.0",
 		"@atlaskit/editor-plugin-width": "^13.0.0",
 		"@atlaskit/editor-prosemirror": "^8.0.0",
 		"@atlaskit/editor-shared-styles": "^4.0.0",
 		"@atlaskit/editor-toolbar": "^2.3.0",
 		"@atlaskit/editor-ui-control-model": "^2.2.0",
-		"@atlaskit/icon": "^37.1.0",
+		"@atlaskit/icon": "^37.2.0",
 		"@atlaskit/icon-lab": "^7.4.0",
 		"@atlaskit/platform-feature-flags": "^2.1.0",
-		"@atlaskit/tmp-editor-statsig": "^133.0.0",
+		"@atlaskit/tmp-editor-statsig": "^134.0.0",
 		"@atlaskit/tokens": "^16.3.0",
 		"@babel/runtime": "^7.0.0",
 		"@emotion/react": "^11.7.1",
 		"bind-event-listener": "^3.0.0"
 	},
 	"peerDependencies": {
-		"@atlaskit/editor-common": "^116.39.0",
+		"@atlaskit/editor-common": "^116.40.0",
 		"react": "^18.2.0",
 		"react-intl": "^5.25.1 || ^6.0.0 || ^7.0.0"
 	},