@atlaskit/editor-plugin-hyperlink 22.0.0 → 23.0.0

package/CHANGELOG.md

@@ -1,5 +1,18 @@
 # @atlaskit/editor-plugin-hyperlink
 
+## 23.0.0
+
+### Minor Changes
+
+- [`2b25e6e39edbf`](https://bitbucket.org/atlassian/atlassian-frontend-monorepo/commits/2b25e6e39edbf) -
+  Cleanup `feature_gate` `platform_editor_middle_click_no_link_toolbar`. Middle-clicking a link now
+  always opens it in a new tab and leaves the selection alone, so the link toolbar no longer opens
+  behind the new tab.
+
+### Patch Changes
+
+- Updated dependencies
+
 ## 22.0.0
 
 ### Patch Changes

package/dist/cjs/pm-plugins/main.js

@@ -12,7 +12,6 @@ var _link3 = require("@atlaskit/editor-common/link");
 var _safePlugin = require("@atlaskit/editor-common/safe-plugin");
 var _utils = require("@atlaskit/editor-common/utils");
 var _state = require("@atlaskit/editor-prosemirror/state");
-var _fg = require("@atlaskit/platform-feature-flags/fg");
 function ownKeys(e, r) { var t = Object.keys(e); if (Object.getOwnPropertySymbols) { var o = Object.getOwnPropertySymbols(e); r && (o = o.filter(function (r) { return Object.getOwnPropertyDescriptor(e, r).enumerable; })), t.push.apply(t, o); } return t; }
 function _objectSpread(e) { for (var r = 1; r < arguments.length; r++) { var t = null != arguments[r] ? arguments[r] : {}; r % 2 ? ownKeys(Object(t), !0).forEach(function (r) { (0, _defineProperty2.default)(e, r, t[r]); }) : Object.getOwnPropertyDescriptors ? Object.defineProperties(e, Object.getOwnPropertyDescriptors(t)) : ownKeys(Object(t)).forEach(function (r) { Object.defineProperty(e, r, Object.getOwnPropertyDescriptor(t, r)); }); } return e; } // eslint-disable-next-line @atlaskit/platform/prefer-crypto-random-uuid -- Use crypto.randomUUID instead
 var mapTransactionToState = function mapTransactionToState(state, tr) {
@@ -222,9 +221,6 @@ var plugin = exports.plugin = function plugin(dispatch, intl, editorAppearance,
           if (!href || !(0, _isSafeUrl.isSafeUrl)(href)) {
             return false;
           }
-          if (!(0, _fg.fg)('platform_editor_middle_click_no_link_toolbar')) {
-            return false;
-          }
           window.open(href, '_blank', 'noopener,noreferrer');
           return true;
         },
@@ -235,7 +231,7 @@ var plugin = exports.plugin = function plugin(dispatch, intl, editorAppearance,
           // link state will be update on slection change which happens on mousedown
           if (isLinkDirectTarget(event)) {
             // Leave middle-click alone so the browser can still open the link in a new tab.
-            if (event.button === 1 && (0, _fg.fg)('platform_editor_middle_click_no_link_toolbar')) {
+            if (event.button === 1) {
               return false;
             }
             event.preventDefault();
@@ -250,7 +246,7 @@ var plugin = exports.plugin = function plugin(dispatch, intl, editorAppearance,
           // the selection into the link or select the card node, which is what opens
           // the toolbar.
           var middleClickAnchor = event.button === 1 ? getLinkAnchor(event) : null;
-          if (middleClickAnchor && (0, _fg.fg)('platform_editor_middle_click_no_link_toolbar')) {
+          if (middleClickAnchor) {
             // Returning true only stops ProseMirror. The browser still places a caret
             // at the click point inside contenteditable, and a caret inside the link is
             // itself enough to open the toolbar, so the default has to be suppressed

package/dist/es2019/pm-plugins/main.js

@@ -5,7 +5,6 @@ import { InsertStatus, LinkAction, getActiveLinkMark } from '@atlaskit/editor-co
 import { SafePlugin } from '@atlaskit/editor-common/safe-plugin';
 import { canLinkBeCreatedInRange, shallowEqual } from '@atlaskit/editor-common/utils';
 import { PluginKey, TextSelection } from '@atlaskit/editor-prosemirror/state';
-import { fg } from '@atlaskit/platform-feature-flags/fg';
 const mapTransactionToState = (state, tr) => {
   if (!state) {
     return undefined;
@@ -221,9 +220,6 @@ export const plugin = (dispatch, intl, editorAppearance, _pluginInjectionApi, _o
         if (!href || !isSafeUrl(href)) {
           return false;
         }
-        if (!fg('platform_editor_middle_click_no_link_toolbar')) {
-          return false;
-        }
         window.open(href, '_blank', 'noopener,noreferrer');
         return true;
       },
@@ -234,7 +230,7 @@ export const plugin = (dispatch, intl, editorAppearance, _pluginInjectionApi, _o
         // link state will be update on slection change which happens on mousedown
         if (isLinkDirectTarget(event)) {
           // Leave middle-click alone so the browser can still open the link in a new tab.
-          if (event.button === 1 && fg('platform_editor_middle_click_no_link_toolbar')) {
+          if (event.button === 1) {
             return false;
           }
           event.preventDefault();
@@ -249,7 +245,7 @@ export const plugin = (dispatch, intl, editorAppearance, _pluginInjectionApi, _o
         // the selection into the link or select the card node, which is what opens
         // the toolbar.
         const middleClickAnchor = event.button === 1 ? getLinkAnchor(event) : null;
-        if (middleClickAnchor && fg('platform_editor_middle_click_no_link_toolbar')) {
+        if (middleClickAnchor) {
           // Returning true only stops ProseMirror. The browser still places a caret
           // at the click point inside contenteditable, and a caret inside the link is
           // itself enough to open the toolbar, so the default has to be suppressed

package/dist/esm/pm-plugins/main.js

@@ -8,7 +8,6 @@ import { InsertStatus, LinkAction, getActiveLinkMark } from '@atlaskit/editor-co
 import { SafePlugin } from '@atlaskit/editor-common/safe-plugin';
 import { canLinkBeCreatedInRange, shallowEqual } from '@atlaskit/editor-common/utils';
 import { PluginKey, TextSelection } from '@atlaskit/editor-prosemirror/state';
-import { fg } from '@atlaskit/platform-feature-flags/fg';
 var mapTransactionToState = function mapTransactionToState(state, tr) {
   if (!state) {
     return undefined;
@@ -216,9 +215,6 @@ export var plugin = function plugin(dispatch, intl, editorAppearance, _pluginInj
           if (!href || !isSafeUrl(href)) {
             return false;
           }
-          if (!fg('platform_editor_middle_click_no_link_toolbar')) {
-            return false;
-          }
           window.open(href, '_blank', 'noopener,noreferrer');
           return true;
         },
@@ -229,7 +225,7 @@ export var plugin = function plugin(dispatch, intl, editorAppearance, _pluginInj
           // link state will be update on slection change which happens on mousedown
           if (isLinkDirectTarget(event)) {
             // Leave middle-click alone so the browser can still open the link in a new tab.
-            if (event.button === 1 && fg('platform_editor_middle_click_no_link_toolbar')) {
+            if (event.button === 1) {
               return false;
             }
             event.preventDefault();
@@ -244,7 +240,7 @@ export var plugin = function plugin(dispatch, intl, editorAppearance, _pluginInj
           // the selection into the link or select the card node, which is what opens
           // the toolbar.
           var middleClickAnchor = event.button === 1 ? getLinkAnchor(event) : null;
-          if (middleClickAnchor && fg('platform_editor_middle_click_no_link_toolbar')) {
+          if (middleClickAnchor) {
             // Returning true only stops ProseMirror. The browser still places a caret
             // at the click point inside contenteditable, and a caret inside the link is
             // itself enough to open the toolbar, so the default has to be suppressed

package/package.json

@@ -1,6 +1,6 @@
 {
 	"name": "@atlaskit/editor-plugin-hyperlink",
-	"version": "22.0.0",
+	"version": "23.0.0",
 	"description": "Hyperlink plugin for @atlaskit/editor-core",
 	"author": "Atlassian Pty Ltd",
 	"license": "Apache-2.0",
@@ -23,20 +23,20 @@
 	"dependencies": {
 		"@atlaskit/adf-schema": "^57.6.0",
 		"@atlaskit/analytics-next": "^12.5.0",
-		"@atlaskit/editor-plugin-analytics": "^20.0.0",
-		"@atlaskit/editor-plugin-card": "^26.0.0",
-		"@atlaskit/editor-plugin-connectivity": "^20.0.0",
-		"@atlaskit/editor-plugin-editor-viewmode": "^22.0.0",
-		"@atlaskit/editor-plugin-primary-toolbar": "^21.0.0",
-		"@atlaskit/editor-plugin-selection-toolbar": "^21.0.0",
-		"@atlaskit/editor-plugin-toolbar": "^17.0.0",
-		"@atlaskit/editor-plugin-ui-control-registry": "^14.0.0",
-		"@atlaskit/editor-plugin-user-intent": "^18.0.0",
+		"@atlaskit/editor-plugin-analytics": "^21.0.0",
+		"@atlaskit/editor-plugin-card": "^27.0.0",
+		"@atlaskit/editor-plugin-connectivity": "^21.0.0",
+		"@atlaskit/editor-plugin-editor-viewmode": "^23.0.0",
+		"@atlaskit/editor-plugin-primary-toolbar": "^22.0.0",
+		"@atlaskit/editor-plugin-selection-toolbar": "^22.0.0",
+		"@atlaskit/editor-plugin-toolbar": "^18.0.0",
+		"@atlaskit/editor-plugin-ui-control-registry": "^15.0.0",
+		"@atlaskit/editor-plugin-user-intent": "^19.0.0",
 		"@atlaskit/editor-prosemirror": "^9.0.0",
 		"@atlaskit/editor-toolbar": "^2.7.0",
 		"@atlaskit/editor-toolbar-model": "^1.2.0",
 		"@atlaskit/editor-ui-control-model": "^2.10.0",
-		"@atlaskit/icon": "^37.7.0",
+		"@atlaskit/icon": "^38.0.0",
 		"@atlaskit/platform-feature-experiments": "^0.3.0",
 		"@atlaskit/platform-feature-flags": "^2.2.0",
 		"@atlaskit/prosemirror-input-rules": "^4.1.0",
@@ -46,7 +46,7 @@
 		"uuid": "^11.1.1"
 	},
 	"peerDependencies": {
-		"@atlaskit/editor-common": "^124.0.0",
+		"@atlaskit/editor-common": "^125.0.0",
 		"react": "^18.2.0 || ^19.2.0",
 		"react-dom": "^18.2.0 || ^19.2.0",
 		"react-intl": "^5.25.1 || ^6.0.0 || ^7.0.0"
@@ -58,10 +58,5 @@
 		"react-dom": "^19.2.0",
 		"react-intl": "^7.0.0",
 		"wait-for-expect": "^1.2.0"
-	},
-	"platform-feature-flags": {
-		"platform_editor_middle_click_no_link_toolbar": {
-			"type": "boolean"
-		}
 	}
 }