@atlaskit/editor-plugin-help-dialog 5.0.3 → 5.0.5

package/CHANGELOG.md

@@ -1,5 +1,20 @@
 # @atlaskit/editor-plugin-help-dialog
 
+## 5.0.5
+
+### Patch Changes
+
+- [`f1c0df3d21494`](https://bitbucket.org/atlassian/atlassian-frontend-monorepo/commits/f1c0df3d21494) -
+  ENGHEALTH-29983 fix help dialog footer a11y color contrast
+- Updated dependencies
+
+## 5.0.4
+
+### Patch Changes
+
+- [`984f973a1fb80`](https://bitbucket.org/atlassian/atlassian-frontend-monorepo/commits/984f973a1fb80) -
+  ED-29168: helpdialog hydration fix
+
 ## 5.0.3
 
 ### Patch Changes

package/dist/cjs/helpDialogPlugin.js

@@ -7,9 +7,11 @@ Object.defineProperty(exports, "__esModule", {
 exports.helpDialogPlugin = void 0;
 var _react = _interopRequireDefault(require("react"));
 var _analytics = require("@atlaskit/editor-common/analytics");
+var _coreUtils = require("@atlaskit/editor-common/core-utils");
 var _keymaps = require("@atlaskit/editor-common/keymaps");
 var _messages = require("@atlaskit/editor-common/messages");
 var _questionCircle = _interopRequireDefault(require("@atlaskit/icon/core/migration/question-circle"));
+var _expValEquals = require("@atlaskit/tmp-editor-statsig/exp-val-equals");
 var _actions = require("./pm-plugins/actions");
 var _commands = require("./pm-plugins/commands");
 var _keymap = require("./pm-plugins/keymap");
@@ -100,11 +102,14 @@ var helpDialogPlugin = exports.helpDialogPlugin = function helpDialogPlugin(_ref
     },
     contentComponent: function contentComponent(_ref5) {
       var editorView = _ref5.editorView;
-      if (!editorView) {
+      if ((0, _expValEquals.expValEquals)('platform_editor_hydratable_ui', 'isEnabled', true) && (!editorView || (0, _coreUtils.isSSR)())) {
         return null;
       }
       return /*#__PURE__*/_react.default.createElement(_HelpDialogLoader.HelpDialogLoader, {
-        pluginInjectionApi: api,
+        pluginInjectionApi: api
+        // temp non null assertion until platform_editor_hydratable_ui cleaned up
+        // eslint-disable-next-line @typescript-eslint/no-non-null-assertion
+        ,
         editorView: editorView,
         quickInsertEnabled: !!(api !== null && api !== void 0 && api.quickInsert)
       });

package/dist/cjs/ui/ModalFooter.js

@@ -10,6 +10,7 @@ var _react = require("@emotion/react");
 var _reactIntlNext = require("react-intl-next");
 var _keymaps = require("@atlaskit/editor-common/keymaps");
 var _messages = require("@atlaskit/editor-common/messages");
+var _platformFeatureFlags = require("@atlaskit/platform-feature-flags");
 var _styles = require("./styles");
 var _utils = require("./utils");
 /**
@@ -22,7 +23,7 @@ var ModalFooter = function ModalFooter() {
   return (
     // eslint-disable-next-line @atlaskit/ui-styling-standard/no-imported-style-values, @atlaskit/design-system/consistent-css-prop-usage -- Ignored via go/DSP-18766
     (0, _react.jsx)("div", {
-      css: _styles.footer
+      css: (0, _platformFeatureFlags.fg)('platform_editor_fix_help_dialog_color_contrast') ? _styles.footerNew : _styles.footer
     }, (0, _react.jsx)(_reactIntlNext.FormattedMessage
     // Ignored via go/ees005
     // eslint-disable-next-line react/jsx-props-no-spreading

package/dist/cjs/ui/styles.js

@@ -4,7 +4,7 @@ var _typeof = require("@babel/runtime/helpers/typeof");
 Object.defineProperty(exports, "__esModule", {
   value: true
 });
-exports.toolbarButton = exports.shortcutsArray = exports.row = exports.line = exports.header = exports.footer = exports.dialogHeader = exports.contentWrapper = exports.content = exports.componentFromKeymapWrapperStyles = exports.column = void 0;
+exports.toolbarButton = exports.shortcutsArray = exports.row = exports.line = exports.header = exports.footerNew = exports.footer = exports.dialogHeader = exports.contentWrapper = exports.content = exports.componentFromKeymapWrapperStyles = exports.column = void 0;
 var _react = require("@emotion/react");
 var _editorSharedStyles = require("@atlaskit/editor-shared-styles");
 var _colors = _interopRequireWildcard(require("@atlaskit/theme/colors"));
@@ -45,6 +45,17 @@ var footer = exports.footer = (0, _react.css)({
   boxShadow: "'none'"
 });
 
+// eslint-disable-next-line @atlaskit/ui-styling-standard/no-exported-styles, @atlaskit/ui-styling-standard/no-unsafe-values -- Ignored via go/DSP-18766
+var footerNew = exports.footerNew = (0, _react.css)({
+  // eslint-disable-next-line @atlaskit/ui-styling-standard/no-imported-style-values, @atlaskit/ui-styling-standard/no-unsafe-values -- Ignored via go/DSP-18766
+  zIndex: _editorSharedStyles.akEditorUnitZIndex,
+  color: "var(--ds-text-subtle, #44546F)",
+  font: "var(--ds-font-body, normal 400 14px/20px ui-sans-serif, -apple-system, BlinkMacSystemFont, \"Segoe UI\", Ubuntu, \"Helvetica Neue\", sans-serif)",
+  padding: "var(--ds-space-300, 24px)",
+  textAlign: 'right',
+  boxShadow: "'none'"
+});
+
 // eslint-disable-next-line @atlaskit/ui-styling-standard/no-exported-styles -- Ignored via go/DSP-18766
 var contentWrapper = exports.contentWrapper = (0, _react.css)({
   padding: "var(--ds-space-250, 20px)".concat(" ", "var(--ds-space-500, 40px)"),

package/dist/es2019/helpDialogPlugin.js

@@ -1,8 +1,10 @@
 import React from 'react';
 import { ACTION, ACTION_SUBJECT, ACTION_SUBJECT_ID, EVENT_TYPE, INPUT_METHOD } from '@atlaskit/editor-common/analytics';
+import { isSSR } from '@atlaskit/editor-common/core-utils';
 import { openHelp, tooltip } from '@atlaskit/editor-common/keymaps';
 import { toolbarInsertBlockMessages as messages } from '@atlaskit/editor-common/messages';
 import QuestionCircleIcon from '@atlaskit/icon/core/migration/question-circle';
+import { expValEquals } from '@atlaskit/tmp-editor-statsig/exp-val-equals';
 import { closeHelpAction, openHelpAction } from './pm-plugins/actions';
 import { openHelpCommand } from './pm-plugins/commands';
 import { keymapPlugin } from './pm-plugins/keymap';
@@ -92,11 +94,14 @@ export const helpDialogPlugin = ({
     contentComponent({
       editorView
     }) {
-      if (!editorView) {
+      if (expValEquals('platform_editor_hydratable_ui', 'isEnabled', true) && (!editorView || isSSR())) {
         return null;
       }
       return /*#__PURE__*/React.createElement(HelpDialogLoader, {
-        pluginInjectionApi: api,
+        pluginInjectionApi: api
+        // temp non null assertion until platform_editor_hydratable_ui cleaned up
+        // eslint-disable-next-line @typescript-eslint/no-non-null-assertion
+        ,
         editorView: editorView,
         quickInsertEnabled: !!(api !== null && api !== void 0 && api.quickInsert)
       });

package/dist/es2019/ui/ModalFooter.js

@@ -8,12 +8,13 @@ import { jsx } from '@emotion/react';
 import { FormattedMessage } from 'react-intl-next';
 import { openHelp } from '@atlaskit/editor-common/keymaps';
 import { helpDialogMessages as messages } from '@atlaskit/editor-common/messages';
-import { footer } from './styles';
+import { fg } from '@atlaskit/platform-feature-flags';
+import { footer, footerNew } from './styles';
 import { getComponentFromKeymap } from './utils';
 const ModalFooter = () =>
 // eslint-disable-next-line @atlaskit/ui-styling-standard/no-imported-style-values, @atlaskit/design-system/consistent-css-prop-usage -- Ignored via go/DSP-18766
 jsx("div", {
-  css: footer
+  css: fg('platform_editor_fix_help_dialog_color_contrast') ? footerNew : footer
 }, jsx(FormattedMessage
 // Ignored via go/ees005
 // eslint-disable-next-line react/jsx-props-no-spreading

package/dist/es2019/ui/styles.js

@@ -35,6 +35,17 @@ export const footer = css({
   boxShadow: "'none'"
 });
 
+// eslint-disable-next-line @atlaskit/ui-styling-standard/no-exported-styles, @atlaskit/ui-styling-standard/no-unsafe-values -- Ignored via go/DSP-18766
+export const footerNew = css({
+  // eslint-disable-next-line @atlaskit/ui-styling-standard/no-imported-style-values, @atlaskit/ui-styling-standard/no-unsafe-values -- Ignored via go/DSP-18766
+  zIndex: akEditorUnitZIndex,
+  color: "var(--ds-text-subtle, #44546F)",
+  font: "var(--ds-font-body, normal 400 14px/20px ui-sans-serif, -apple-system, BlinkMacSystemFont, \"Segoe UI\", Ubuntu, \"Helvetica Neue\", sans-serif)",
+  padding: "var(--ds-space-300, 24px)",
+  textAlign: 'right',
+  boxShadow: "'none'"
+});
+
 // eslint-disable-next-line @atlaskit/ui-styling-standard/no-exported-styles -- Ignored via go/DSP-18766
 export const contentWrapper = css({
   padding: `${"var(--ds-space-250, 20px)"} ${"var(--ds-space-500, 40px)"}`,

package/dist/esm/helpDialogPlugin.js

@@ -1,8 +1,10 @@
 import React from 'react';
 import { ACTION, ACTION_SUBJECT, ACTION_SUBJECT_ID, EVENT_TYPE, INPUT_METHOD } from '@atlaskit/editor-common/analytics';
+import { isSSR } from '@atlaskit/editor-common/core-utils';
 import { openHelp, tooltip } from '@atlaskit/editor-common/keymaps';
 import { toolbarInsertBlockMessages as messages } from '@atlaskit/editor-common/messages';
 import QuestionCircleIcon from '@atlaskit/icon/core/migration/question-circle';
+import { expValEquals } from '@atlaskit/tmp-editor-statsig/exp-val-equals';
 import { closeHelpAction, openHelpAction } from './pm-plugins/actions';
 import { openHelpCommand } from './pm-plugins/commands';
 import { keymapPlugin } from './pm-plugins/keymap';
@@ -94,11 +96,14 @@ export var helpDialogPlugin = function helpDialogPlugin(_ref2) {
     },
     contentComponent: function contentComponent(_ref5) {
       var editorView = _ref5.editorView;
-      if (!editorView) {
+      if (expValEquals('platform_editor_hydratable_ui', 'isEnabled', true) && (!editorView || isSSR())) {
         return null;
       }
       return /*#__PURE__*/React.createElement(HelpDialogLoader, {
-        pluginInjectionApi: api,
+        pluginInjectionApi: api
+        // temp non null assertion until platform_editor_hydratable_ui cleaned up
+        // eslint-disable-next-line @typescript-eslint/no-non-null-assertion
+        ,
         editorView: editorView,
         quickInsertEnabled: !!(api !== null && api !== void 0 && api.quickInsert)
       });

package/dist/esm/ui/ModalFooter.js

@@ -8,13 +8,14 @@ import { jsx } from '@emotion/react';
 import { FormattedMessage } from 'react-intl-next';
 import { openHelp } from '@atlaskit/editor-common/keymaps';
 import { helpDialogMessages as messages } from '@atlaskit/editor-common/messages';
-import { footer } from './styles';
+import { fg } from '@atlaskit/platform-feature-flags';
+import { footer, footerNew } from './styles';
 import { getComponentFromKeymap } from './utils';
 var ModalFooter = function ModalFooter() {
   return (
     // eslint-disable-next-line @atlaskit/ui-styling-standard/no-imported-style-values, @atlaskit/design-system/consistent-css-prop-usage -- Ignored via go/DSP-18766
     jsx("div", {
-      css: footer
+      css: fg('platform_editor_fix_help_dialog_color_contrast') ? footerNew : footer
     }, jsx(FormattedMessage
     // Ignored via go/ees005
     // eslint-disable-next-line react/jsx-props-no-spreading

package/dist/esm/ui/styles.js

@@ -35,6 +35,17 @@ export var footer = css({
   boxShadow: "'none'"
 });
 
+// eslint-disable-next-line @atlaskit/ui-styling-standard/no-exported-styles, @atlaskit/ui-styling-standard/no-unsafe-values -- Ignored via go/DSP-18766
+export var footerNew = css({
+  // eslint-disable-next-line @atlaskit/ui-styling-standard/no-imported-style-values, @atlaskit/ui-styling-standard/no-unsafe-values -- Ignored via go/DSP-18766
+  zIndex: akEditorUnitZIndex,
+  color: "var(--ds-text-subtle, #44546F)",
+  font: "var(--ds-font-body, normal 400 14px/20px ui-sans-serif, -apple-system, BlinkMacSystemFont, \"Segoe UI\", Ubuntu, \"Helvetica Neue\", sans-serif)",
+  padding: "var(--ds-space-300, 24px)",
+  textAlign: 'right',
+  boxShadow: "'none'"
+});
+
 // eslint-disable-next-line @atlaskit/ui-styling-standard/no-exported-styles -- Ignored via go/DSP-18766
 export var contentWrapper = css({
   padding: "var(--ds-space-250, 20px)".concat(" ", "var(--ds-space-500, 40px)"),

package/dist/types/ui/styles.d.ts

@@ -1,6 +1,7 @@
 import { type SerializedStyles } from '@emotion/react';
 export declare const header: SerializedStyles;
 export declare const footer: SerializedStyles;
+export declare const footerNew: SerializedStyles;
 export declare const contentWrapper: SerializedStyles;
 export declare const line: SerializedStyles;
 export declare const content: SerializedStyles;

package/dist/types-ts4.5/ui/styles.d.ts

@@ -1,6 +1,7 @@
 import { type SerializedStyles } from '@emotion/react';
 export declare const header: SerializedStyles;
 export declare const footer: SerializedStyles;
+export declare const footerNew: SerializedStyles;
 export declare const contentWrapper: SerializedStyles;
 export declare const line: SerializedStyles;
 export declare const content: SerializedStyles;

package/package.json

@@ -1,6 +1,6 @@
 {
 	"name": "@atlaskit/editor-plugin-help-dialog",
-	"version": "5.0.3",
+	"version": "5.0.5",
 	"description": "Help Dialog plugin for @atlaskit/editor-core",
 	"author": "Atlassian Pty Ltd",
 	"license": "Apache-2.0",
@@ -34,12 +34,12 @@
 		"@atlaskit/editor-prosemirror": "7.0.0",
 		"@atlaskit/editor-shared-styles": "^3.6.0",
 		"@atlaskit/heading": "^5.2.0",
-		"@atlaskit/icon": "^28.1.0",
+		"@atlaskit/icon": "^28.2.0",
 		"@atlaskit/modal-dialog": "^14.3.0",
 		"@atlaskit/platform-feature-flags": "^1.1.0",
-		"@atlaskit/primitives": "^14.14.0",
+		"@atlaskit/primitives": "^14.15.0",
 		"@atlaskit/theme": "^21.0.0",
-		"@atlaskit/tmp-editor-statsig": "^12.21.0",
+		"@atlaskit/tmp-editor-statsig": "^12.28.0",
 		"@atlaskit/tokens": "^6.3.0",
 		"@babel/runtime": "^7.0.0",
 		"@emotion/react": "^11.7.1",
@@ -50,7 +50,7 @@
 		"@testing-library/react": "^13.4.0"
 	},
 	"peerDependencies": {
-		"@atlaskit/editor-common": "^109.6.0",
+		"@atlaskit/editor-common": "^109.12.0",
 		"react": "^18.2.0"
 	},
 	"techstack": {
@@ -92,6 +92,9 @@
 		},
 		"platform_editor_breakout_resizing_hello_release": {
 			"type": "boolean"
+		},
+		"platform_editor_fix_help_dialog_color_contrast": {
+			"type": "boolean"
 		}
 	}
 }