@atlaskit/editor-plugin-floating-toolbar 4.1.8 → 4.1.10

package/CHANGELOG.md

@@ -1,5 +1,35 @@
 # @atlaskit/editor-plugin-floating-toolbar
 
+## 4.1.10
+
+### Patch Changes
+
+- [#159655](https://bitbucket.org/atlassian/atlassian-frontend-monorepo/pull-requests/159655)
+  [`24f8c627d50f2`](https://bitbucket.org/atlassian/atlassian-frontend-monorepo/commits/24f8c627d50f2) - ##
+  WHAT? Remove experimental graceful edit mode from view mode plugin and associated props.
+
+  ## WHY?
+
+  This experiment is being cleaned up and we are no longer proceeding in this direction.
+
+  ## HOW to adjust?
+
+  This experiment was only enabled for Confluence and should not have been enabled in other places.
+  If for some reason any of the following props/state/methdos were used please remove them:
+
+  - isConsumption
+  - contentMode
+  - initialContentMode
+  - updateContentMode
+
+- Updated dependencies
+
+## 4.1.9
+
+### Patch Changes
+
+- Updated dependencies
+
 ## 4.1.8
 
 ### Patch Changes

package/dist/cjs/floatingToolbarPlugin.js

@@ -31,7 +31,6 @@ var _plugin = require("./pm-plugins/toolbar-data/plugin");
 var _pluginKey = require("./pm-plugins/toolbar-data/plugin-key");
 var _utils2 = require("./pm-plugins/utils");
 var _ConfirmationModal = require("./ui/ConfirmationModal");
-var _ExpandButton = require("./ui/ExpandButton");
 var _ToolbarLoader = require("./ui/ToolbarLoader");
 var _utils3 = require("./ui/utils");
 function _getRequireWildcardCache(e) { if ("function" != typeof WeakMap) return null; var r = new WeakMap(), t = new WeakMap(); return (_getRequireWildcardCache = function _getRequireWildcardCache(e) { return e ? t : r; })(e); }
@@ -225,8 +224,6 @@ var useSharedState = (0, _hooks.sharedPluginStateHookMigratorFactory)(function (
 
   // editorViewMode
   var mode = (0, _useSharedPluginStateSelector.useSharedPluginStateSelector)(pluginInjectionApi, 'editorViewMode.mode');
-  var contentMode = (0, _useSharedPluginStateSelector.useSharedPluginStateSelector)(pluginInjectionApi, 'editorViewMode.contentMode');
-  var isConsumption = (0, _useSharedPluginStateSelector.useSharedPluginStateSelector)(pluginInjectionApi, 'editorViewMode.isConsumption');
 
   // userIntent
   var currentUserIntent = (0, _useSharedPluginStateSelector.useSharedPluginStateSelector)(pluginInjectionApi, 'userIntent.currentUserIntent');
@@ -244,8 +241,6 @@ var useSharedState = (0, _hooks.sharedPluginStateHookMigratorFactory)(function (
     floatingToolbarData: floatingToolbarData,
     editorDisabled: editorDisabledState,
     mode: mode,
-    contentMode: contentMode,
-    isConsumption: isConsumption,
     currentUserIntent: currentUserIntent,
     isDragging: isDragging,
     isMenuOpen: isMenuOpen
@@ -264,8 +259,6 @@ var useSharedState = (0, _hooks.sharedPluginStateHookMigratorFactory)(function (
     floatingToolbarData: floatingToolbarState === null || floatingToolbarState === void 0 ? void 0 : floatingToolbarState.floatingToolbarData,
     editorDisabled: editorDisabledState === null || editorDisabledState === void 0 ? void 0 : editorDisabledState.editorDisabled,
     mode: editorViewModeState === null || editorViewModeState === void 0 ? void 0 : editorViewModeState.mode,
-    contentMode: editorViewModeState === null || editorViewModeState === void 0 ? void 0 : editorViewModeState.contentMode,
-    isConsumption: editorViewModeState === null || editorViewModeState === void 0 ? void 0 : editorViewModeState.isConsumption,
     currentUserIntent: userIntentState === null || userIntentState === void 0 ? void 0 : userIntentState.currentUserIntent,
     isDragging: blockControlsState === null || blockControlsState === void 0 ? void 0 : blockControlsState.isDragging,
     isMenuOpen: blockControlsState === null || blockControlsState === void 0 ? void 0 : blockControlsState.isMenuOpen
@@ -282,11 +275,9 @@ function ContentComponent(_ref5) {
     dispatchAnalyticsEvent = _ref5.dispatchAnalyticsEvent;
   var _useSharedState = useSharedState(pluginInjectionApi),
     configWithNodeInfo = _useSharedState.configWithNodeInfo,
-    contentMode = _useSharedState.contentMode,
     currentUserIntent = _useSharedState.currentUserIntent,
     editorDisabled = _useSharedState.editorDisabled,
     floatingToolbarData = _useSharedState.floatingToolbarData,
-    isConsumption = _useSharedState.isConsumption,
     isDragging = _useSharedState.isDragging,
     isMenuOpen = _useSharedState.isMenuOpen,
     mode = _useSharedState.mode;
@@ -386,39 +377,6 @@ function ContentComponent(_ref5) {
   }
   var customPositionCalculation;
   var toolbarItems = pluginInjectionApi === null || pluginInjectionApi === void 0 || (_pluginInjectionApi$c = pluginInjectionApi.copyButton) === null || _pluginInjectionApi$c === void 0 ? void 0 : _pluginInjectionApi$c.actions.processCopyButtonItems(editorView.state)(Array.isArray(items) ? items : items(node), pluginInjectionApi === null || pluginInjectionApi === void 0 || (_pluginInjectionApi$d = pluginInjectionApi.decorations) === null || _pluginInjectionApi$d === void 0 ? void 0 : _pluginInjectionApi$d.actions.hoverDecoration);
-  var viewModeToolbarEntry = (0, _experiments.unstable_editorExperimentParam)('live_pages_graceful_edit', 'toolbar-entry', {
-    defaultValue: 'none',
-    typeGuard: function typeGuard(value) {
-      return typeof value === 'string' && ['text', 'nodes'].includes(value);
-    }
-  });
-  if (!(0, _experiments.editorExperiment)('live_pages_graceful_edit', 'control') && viewModeToolbarEntry !== 'none') {
-    if (contentMode === 'live-edit' && isConsumption) {
-      var hasOtherToolbarItems = toolbarItems && toolbarItems.length !== 0;
-      var shouldAddToolbarItems = viewModeToolbarEntry === 'expand-existing-only' ? hasOtherToolbarItems : true;
-      if (shouldAddToolbarItems) {
-        if (toolbarItems && toolbarItems.length > 0) {
-          toolbarItems.unshift({
-            type: 'separator'
-          });
-        }
-        toolbarItems === null || toolbarItems === void 0 || toolbarItems.unshift({
-          type: 'button',
-          title: 'Edit',
-          onClick: function onClick() {
-            var _pluginInjectionApi$c2, _pluginInjectionApi$e;
-            pluginInjectionApi === null || pluginInjectionApi === void 0 || (_pluginInjectionApi$c2 = pluginInjectionApi.core) === null || _pluginInjectionApi$c2 === void 0 || (_pluginInjectionApi$c2 = _pluginInjectionApi$c2.actions) === null || _pluginInjectionApi$c2 === void 0 || _pluginInjectionApi$c2.execute(pluginInjectionApi === null || pluginInjectionApi === void 0 || (_pluginInjectionApi$e = pluginInjectionApi.editorViewMode) === null || _pluginInjectionApi$e === void 0 ? void 0 : _pluginInjectionApi$e.commands.updateContentMode({
-              type: 'intent-to-edit'
-            }));
-            return false;
-          },
-          icon: function icon() {
-            return /*#__PURE__*/_react.default.createElement(_ExpandButton.ExpandButton, null);
-          }
-        });
-      }
-    }
-  }
   if (onPositionCalculated) {
     customPositionCalculation = function customPositionCalculation(nextPos) {
       return onPositionCalculated(editorView, nextPos);

package/dist/es2019/floatingToolbarPlugin.js

@@ -10,7 +10,7 @@ import { useSharedPluginStateSelector } from '@atlaskit/editor-common/use-shared
 import { AllSelection, PluginKey } from '@atlaskit/editor-prosemirror/state';
 import { findDomRefAtPos, findSelectedNodeOfType } from '@atlaskit/editor-prosemirror/utils';
 import { fg } from '@atlaskit/platform-feature-flags';
-import { editorExperiment, unstable_editorExperimentParam } from '@atlaskit/tmp-editor-statsig/experiments';
+import { editorExperiment } from '@atlaskit/tmp-editor-statsig/experiments';
 import { copyNode } from './pm-plugins/commands';
 import forceFocusPlugin, { forceFocusSelector } from './pm-plugins/force-focus';
 import { hideConfirmDialog } from './pm-plugins/toolbar-data/commands';
@@ -18,7 +18,6 @@ import { createPlugin as floatingToolbarDataPluginFactory } from './pm-plugins/t
 import { pluginKey as dataPluginKey } from './pm-plugins/toolbar-data/plugin-key';
 import { findNode } from './pm-plugins/utils';
 import { ConfirmationModal } from './ui/ConfirmationModal';
-import { ExpandButton } from './ui/ExpandButton';
 import { ToolbarLoader } from './ui/ToolbarLoader';
 import { consolidateOverflowDropdownItems } from './ui/utils';
 
@@ -208,8 +207,6 @@ const useSharedState = sharedPluginStateHookMigratorFactory(pluginInjectionApi =
 
   // editorViewMode
   const mode = useSharedPluginStateSelector(pluginInjectionApi, 'editorViewMode.mode');
-  const contentMode = useSharedPluginStateSelector(pluginInjectionApi, 'editorViewMode.contentMode');
-  const isConsumption = useSharedPluginStateSelector(pluginInjectionApi, 'editorViewMode.isConsumption');
 
   // userIntent
   const currentUserIntent = useSharedPluginStateSelector(pluginInjectionApi, 'userIntent.currentUserIntent');
@@ -227,8 +224,6 @@ const useSharedState = sharedPluginStateHookMigratorFactory(pluginInjectionApi =
     floatingToolbarData,
     editorDisabled: editorDisabledState,
     mode,
-    contentMode,
-    isConsumption,
     currentUserIntent,
     isDragging,
     isMenuOpen
@@ -249,8 +244,6 @@ const useSharedState = sharedPluginStateHookMigratorFactory(pluginInjectionApi =
     floatingToolbarData: floatingToolbarState === null || floatingToolbarState === void 0 ? void 0 : floatingToolbarState.floatingToolbarData,
     editorDisabled: editorDisabledState === null || editorDisabledState === void 0 ? void 0 : editorDisabledState.editorDisabled,
     mode: editorViewModeState === null || editorViewModeState === void 0 ? void 0 : editorViewModeState.mode,
-    contentMode: editorViewModeState === null || editorViewModeState === void 0 ? void 0 : editorViewModeState.contentMode,
-    isConsumption: editorViewModeState === null || editorViewModeState === void 0 ? void 0 : editorViewModeState.isConsumption,
     currentUserIntent: userIntentState === null || userIntentState === void 0 ? void 0 : userIntentState.currentUserIntent,
     isDragging: blockControlsState === null || blockControlsState === void 0 ? void 0 : blockControlsState.isDragging,
     isMenuOpen: blockControlsState === null || blockControlsState === void 0 ? void 0 : blockControlsState.isMenuOpen
@@ -268,11 +261,9 @@ export function ContentComponent({
   var _configWithNodeInfo$c, _configWithNodeInfo$c2, _items, _pluginInjectionApi$c, _pluginInjectionApi$d;
   const {
     configWithNodeInfo,
-    contentMode,
     currentUserIntent,
     editorDisabled,
     floatingToolbarData,
-    isConsumption,
     isDragging,
     isMenuOpen,
     mode
@@ -368,35 +359,6 @@ export function ContentComponent({
   }
   let customPositionCalculation;
   const toolbarItems = pluginInjectionApi === null || pluginInjectionApi === void 0 ? void 0 : (_pluginInjectionApi$c = pluginInjectionApi.copyButton) === null || _pluginInjectionApi$c === void 0 ? void 0 : _pluginInjectionApi$c.actions.processCopyButtonItems(editorView.state)(Array.isArray(items) ? items : items(node), pluginInjectionApi === null || pluginInjectionApi === void 0 ? void 0 : (_pluginInjectionApi$d = pluginInjectionApi.decorations) === null || _pluginInjectionApi$d === void 0 ? void 0 : _pluginInjectionApi$d.actions.hoverDecoration);
-  const viewModeToolbarEntry = unstable_editorExperimentParam('live_pages_graceful_edit', 'toolbar-entry', {
-    defaultValue: 'none',
-    typeGuard: value => typeof value === 'string' && ['text', 'nodes'].includes(value)
-  });
-  if (!editorExperiment('live_pages_graceful_edit', 'control') && viewModeToolbarEntry !== 'none') {
-    if (contentMode === 'live-edit' && isConsumption) {
-      const hasOtherToolbarItems = toolbarItems && toolbarItems.length !== 0;
-      const shouldAddToolbarItems = viewModeToolbarEntry === 'expand-existing-only' ? hasOtherToolbarItems : true;
-      if (shouldAddToolbarItems) {
-        if (toolbarItems && toolbarItems.length > 0) {
-          toolbarItems.unshift({
-            type: 'separator'
-          });
-        }
-        toolbarItems === null || toolbarItems === void 0 ? void 0 : toolbarItems.unshift({
-          type: 'button',
-          title: 'Edit',
-          onClick: () => {
-            var _pluginInjectionApi$c2, _pluginInjectionApi$c3, _pluginInjectionApi$e;
-            pluginInjectionApi === null || pluginInjectionApi === void 0 ? void 0 : (_pluginInjectionApi$c2 = pluginInjectionApi.core) === null || _pluginInjectionApi$c2 === void 0 ? void 0 : (_pluginInjectionApi$c3 = _pluginInjectionApi$c2.actions) === null || _pluginInjectionApi$c3 === void 0 ? void 0 : _pluginInjectionApi$c3.execute(pluginInjectionApi === null || pluginInjectionApi === void 0 ? void 0 : (_pluginInjectionApi$e = pluginInjectionApi.editorViewMode) === null || _pluginInjectionApi$e === void 0 ? void 0 : _pluginInjectionApi$e.commands.updateContentMode({
-              type: 'intent-to-edit'
-            }));
-            return false;
-          },
-          icon: () => /*#__PURE__*/React.createElement(ExpandButton, null)
-        });
-      }
-    }
-  }
   if (onPositionCalculated) {
     customPositionCalculation = nextPos => {
       return onPositionCalculated(editorView, nextPos);

package/dist/esm/floatingToolbarPlugin.js

@@ -14,7 +14,7 @@ import { useSharedPluginStateSelector } from '@atlaskit/editor-common/use-shared
 import { AllSelection, PluginKey } from '@atlaskit/editor-prosemirror/state';
 import { findDomRefAtPos, findSelectedNodeOfType } from '@atlaskit/editor-prosemirror/utils';
 import { fg } from '@atlaskit/platform-feature-flags';
-import { editorExperiment, unstable_editorExperimentParam } from '@atlaskit/tmp-editor-statsig/experiments';
+import { editorExperiment } from '@atlaskit/tmp-editor-statsig/experiments';
 import { copyNode as _copyNode } from './pm-plugins/commands';
 import forceFocusPlugin, { forceFocusSelector } from './pm-plugins/force-focus';
 import { hideConfirmDialog } from './pm-plugins/toolbar-data/commands';
@@ -22,7 +22,6 @@ import { createPlugin as floatingToolbarDataPluginFactory } from './pm-plugins/t
 import { pluginKey as dataPluginKey } from './pm-plugins/toolbar-data/plugin-key';
 import { findNode } from './pm-plugins/utils';
 import { ConfirmationModal } from './ui/ConfirmationModal';
-import { ExpandButton } from './ui/ExpandButton';
 import { ToolbarLoader } from './ui/ToolbarLoader';
 import { consolidateOverflowDropdownItems } from './ui/utils';
 
@@ -213,8 +212,6 @@ var useSharedState = sharedPluginStateHookMigratorFactory(function (pluginInject
 
   // editorViewMode
   var mode = useSharedPluginStateSelector(pluginInjectionApi, 'editorViewMode.mode');
-  var contentMode = useSharedPluginStateSelector(pluginInjectionApi, 'editorViewMode.contentMode');
-  var isConsumption = useSharedPluginStateSelector(pluginInjectionApi, 'editorViewMode.isConsumption');
 
   // userIntent
   var currentUserIntent = useSharedPluginStateSelector(pluginInjectionApi, 'userIntent.currentUserIntent');
@@ -232,8 +229,6 @@ var useSharedState = sharedPluginStateHookMigratorFactory(function (pluginInject
     floatingToolbarData: floatingToolbarData,
     editorDisabled: editorDisabledState,
     mode: mode,
-    contentMode: contentMode,
-    isConsumption: isConsumption,
     currentUserIntent: currentUserIntent,
     isDragging: isDragging,
     isMenuOpen: isMenuOpen
@@ -252,8 +247,6 @@ var useSharedState = sharedPluginStateHookMigratorFactory(function (pluginInject
     floatingToolbarData: floatingToolbarState === null || floatingToolbarState === void 0 ? void 0 : floatingToolbarState.floatingToolbarData,
     editorDisabled: editorDisabledState === null || editorDisabledState === void 0 ? void 0 : editorDisabledState.editorDisabled,
     mode: editorViewModeState === null || editorViewModeState === void 0 ? void 0 : editorViewModeState.mode,
-    contentMode: editorViewModeState === null || editorViewModeState === void 0 ? void 0 : editorViewModeState.contentMode,
-    isConsumption: editorViewModeState === null || editorViewModeState === void 0 ? void 0 : editorViewModeState.isConsumption,
     currentUserIntent: userIntentState === null || userIntentState === void 0 ? void 0 : userIntentState.currentUserIntent,
     isDragging: blockControlsState === null || blockControlsState === void 0 ? void 0 : blockControlsState.isDragging,
     isMenuOpen: blockControlsState === null || blockControlsState === void 0 ? void 0 : blockControlsState.isMenuOpen
@@ -270,11 +263,9 @@ export function ContentComponent(_ref5) {
     dispatchAnalyticsEvent = _ref5.dispatchAnalyticsEvent;
   var _useSharedState = useSharedState(pluginInjectionApi),
     configWithNodeInfo = _useSharedState.configWithNodeInfo,
-    contentMode = _useSharedState.contentMode,
     currentUserIntent = _useSharedState.currentUserIntent,
     editorDisabled = _useSharedState.editorDisabled,
     floatingToolbarData = _useSharedState.floatingToolbarData,
-    isConsumption = _useSharedState.isConsumption,
     isDragging = _useSharedState.isDragging,
     isMenuOpen = _useSharedState.isMenuOpen,
     mode = _useSharedState.mode;
@@ -374,39 +365,6 @@ export function ContentComponent(_ref5) {
   }
   var customPositionCalculation;
   var toolbarItems = pluginInjectionApi === null || pluginInjectionApi === void 0 || (_pluginInjectionApi$c = pluginInjectionApi.copyButton) === null || _pluginInjectionApi$c === void 0 ? void 0 : _pluginInjectionApi$c.actions.processCopyButtonItems(editorView.state)(Array.isArray(items) ? items : items(node), pluginInjectionApi === null || pluginInjectionApi === void 0 || (_pluginInjectionApi$d = pluginInjectionApi.decorations) === null || _pluginInjectionApi$d === void 0 ? void 0 : _pluginInjectionApi$d.actions.hoverDecoration);
-  var viewModeToolbarEntry = unstable_editorExperimentParam('live_pages_graceful_edit', 'toolbar-entry', {
-    defaultValue: 'none',
-    typeGuard: function typeGuard(value) {
-      return typeof value === 'string' && ['text', 'nodes'].includes(value);
-    }
-  });
-  if (!editorExperiment('live_pages_graceful_edit', 'control') && viewModeToolbarEntry !== 'none') {
-    if (contentMode === 'live-edit' && isConsumption) {
-      var hasOtherToolbarItems = toolbarItems && toolbarItems.length !== 0;
-      var shouldAddToolbarItems = viewModeToolbarEntry === 'expand-existing-only' ? hasOtherToolbarItems : true;
-      if (shouldAddToolbarItems) {
-        if (toolbarItems && toolbarItems.length > 0) {
-          toolbarItems.unshift({
-            type: 'separator'
-          });
-        }
-        toolbarItems === null || toolbarItems === void 0 || toolbarItems.unshift({
-          type: 'button',
-          title: 'Edit',
-          onClick: function onClick() {
-            var _pluginInjectionApi$c2, _pluginInjectionApi$e;
-            pluginInjectionApi === null || pluginInjectionApi === void 0 || (_pluginInjectionApi$c2 = pluginInjectionApi.core) === null || _pluginInjectionApi$c2 === void 0 || (_pluginInjectionApi$c2 = _pluginInjectionApi$c2.actions) === null || _pluginInjectionApi$c2 === void 0 || _pluginInjectionApi$c2.execute(pluginInjectionApi === null || pluginInjectionApi === void 0 || (_pluginInjectionApi$e = pluginInjectionApi.editorViewMode) === null || _pluginInjectionApi$e === void 0 ? void 0 : _pluginInjectionApi$e.commands.updateContentMode({
-              type: 'intent-to-edit'
-            }));
-            return false;
-          },
-          icon: function icon() {
-            return /*#__PURE__*/React.createElement(ExpandButton, null);
-          }
-        });
-      }
-    }
-  }
   if (onPositionCalculated) {
     customPositionCalculation = function customPositionCalculation(nextPos) {
       return onPositionCalculated(editorView, nextPos);

package/package.json

@@ -1,6 +1,6 @@
 {
 	"name": "@atlaskit/editor-plugin-floating-toolbar",
-	"version": "4.1.8",
+	"version": "4.1.10",
 	"description": "Floating toolbar plugin for @atlaskit/editor-core",
 	"author": "Atlassian Pty Ltd",
 	"license": "Apache-2.0",
@@ -25,32 +25,32 @@
 		".": "./src/index.ts"
 	},
 	"dependencies": {
-		"@atlaskit/adf-utils": "^19.19.0",
+		"@atlaskit/adf-utils": "^19.20.0",
 		"@atlaskit/button": "^23.2.0",
 		"@atlaskit/checkbox": "^17.1.0",
-		"@atlaskit/editor-common": "^105.8.0",
+		"@atlaskit/editor-common": "^105.10.0",
 		"@atlaskit/editor-palette": "^2.1.0",
 		"@atlaskit/editor-plugin-analytics": "^2.3.0",
 		"@atlaskit/editor-plugin-context-panel": "^4.1.0",
 		"@atlaskit/editor-plugin-copy-button": "^2.0.0",
 		"@atlaskit/editor-plugin-decorations": "^2.0.0",
 		"@atlaskit/editor-plugin-editor-disabled": "^2.0.0",
-		"@atlaskit/editor-plugin-editor-viewmode": "^3.1.0",
-		"@atlaskit/editor-plugin-emoji": "^3.6.0",
+		"@atlaskit/editor-plugin-editor-viewmode": "^4.0.0",
+		"@atlaskit/editor-plugin-emoji": "^3.7.0",
 		"@atlaskit/editor-plugin-extension": "^5.4.0",
 		"@atlaskit/editor-plugin-interaction": "^1.1.0",
-		"@atlaskit/editor-plugin-table": "^10.10.0",
+		"@atlaskit/editor-plugin-table": "^10.11.0",
 		"@atlaskit/editor-plugin-user-intent": "^0.1.0",
 		"@atlaskit/editor-prosemirror": "7.0.0",
 		"@atlaskit/emoji": "^69.2.0",
-		"@atlaskit/icon": "^26.1.0",
-		"@atlaskit/menu": "^7.1.0",
+		"@atlaskit/icon": "^26.3.0",
+		"@atlaskit/menu": "^8.0.0",
 		"@atlaskit/modal-dialog": "^14.2.0",
 		"@atlaskit/platform-feature-flags": "^1.1.0",
 		"@atlaskit/primitives": "^14.8.0",
 		"@atlaskit/select": "^20.6.0",
 		"@atlaskit/theme": "^18.0.0",
-		"@atlaskit/tmp-editor-statsig": "^4.23.0",
+		"@atlaskit/tmp-editor-statsig": "^5.0.0",
 		"@atlaskit/tokens": "^4.9.0",
 		"@atlaskit/tooltip": "^20.0.0",
 		"@babel/runtime": "^7.0.0",