@atlaskit/editor-plugin-floating-toolbar 1.2.1 → 1.2.3

package/CHANGELOG.md

@@ -1,5 +1,18 @@
 # @atlaskit/editor-plugin-floating-toolbar
 
+## 1.2.3
+
+### Patch Changes
+
+- [#80728](https://stash.atlassian.com/projects/CONFCLOUD/repos/confluence-frontend/pull-requests/80728) [`aac7ad9bb32d`](https://stash.atlassian.com/projects/CONFCLOUD/repos/confluence-frontend/commits/aac7ad9bb32d) - [ux] The table's floating toolbar dropdown menu a11y annnouncement.
+
+## 1.2.2
+
+### Patch Changes
+
+- [#83116](https://stash.atlassian.com/projects/CONFCLOUD/repos/confluence-frontend/pull-requests/83116) [`8d4e99057fe0`](https://stash.atlassian.com/projects/CONFCLOUD/repos/confluence-frontend/commits/8d4e99057fe0) - Upgrade Typescript from `4.9.5` to `5.4.2`
+- Updated dependencies
+
 ## 1.2.1
 
 ### Patch Changes

package/dist/cjs/plugin.js

@@ -108,6 +108,8 @@ var getDomRefFromSelection = function getDomRefFromSelection(view, dispatchAnaly
           position: view.state.selection.from,
           docSize: view.state.doc.nodeSize,
           error: error.toString(),
+          // @ts-expect-error - Object literal may only specify known properties, 'errorStack' does not exist in type
+          // This error was introduced after upgrading to TypeScript 5
           errorStack: error.stack || undefined
         }
       };

package/dist/cjs/ui/DropdownMenu.js

@@ -17,6 +17,7 @@ var _reactIntlNext = require("react-intl-next");
 var _floatingToolbar = require("@atlaskit/editor-common/floating-toolbar");
 var _done = _interopRequireDefault(require("@atlaskit/icon/glyph/editor/done"));
 var _menu = require("@atlaskit/menu");
+var _platformFeatureFlags = require("@atlaskit/platform-feature-flags");
 var _colors = require("@atlaskit/theme/colors");
 var _constants = require("@atlaskit/theme/constants");
 var _tooltip = _interopRequireDefault(require("@atlaskit/tooltip"));
@@ -133,6 +134,18 @@ var DropdownMenuItem = function DropdownMenuItem(_ref) {
       e.preventDefault();
     }
   }, [item.disabled]);
+  var isAriaChecked = function isAriaChecked(item) {
+    var selected = item.selected,
+      domItemOptions = item.domItemOptions;
+    if ((0, _platformFeatureFlags.getBooleanFF)('platform.editor.a11y-table-floating-toolbar-dropdown-menu_zkb33') && (domItemOptions === null || domItemOptions === void 0 ? void 0 : domItemOptions.type) === 'item-checkbox') {
+      return selected;
+    }
+    return undefined;
+  };
+  var hasRole = function hasRole(item) {
+    var domItemOptions = item.domItemOptions;
+    return (0, _platformFeatureFlags.getBooleanFF)('platform.editor.a11y-table-floating-toolbar-dropdown-menu_zkb33') && (domItemOptions === null || domItemOptions === void 0 ? void 0 : domItemOptions.type) === 'item-checkbox' ? 'menuitemcheckbox' : undefined;
+  };
   (0, _react.useEffect)(function () {
     var labelRefCurrent = labelRef.current;
     // eslint-disable-next-line @repo/internal/dom-events/no-unsafe-event-listeners
@@ -158,7 +171,9 @@ var DropdownMenuItem = function DropdownMenuItem(_ref) {
     onMouseLeave: handleItemMouseLeave,
     onMouseOut: handleItemMouseOut,
     onFocus: handleItemOnFocus,
-    onBlur: handleItemOnBlur
+    onBlur: handleItemOnBlur,
+    role: hasRole(item),
+    "aria-checked": isAriaChecked(item)
   }, (0, _react2.jsx)("span", {
     ref: labelRef,
     css: labelStyles
@@ -190,7 +205,8 @@ var Dropdown = /*#__PURE__*/function (_Component) {
         intl = _this$props.intl,
         editorView = _this$props.editorView;
       return (0, _react2.jsx)("div", {
-        css: menuContainerStyles
+        css: menuContainerStyles,
+        role: (0, _platformFeatureFlags.getBooleanFF)('platform.editor.a11y-table-floating-toolbar-dropdown-menu_zkb33') ? 'menu' : undefined
       }, items.filter(function (item) {
         return !item.hidden;
       }).map(function (item, idx) {
@@ -211,6 +227,15 @@ var Dropdown = /*#__PURE__*/function (_Component) {
         showSelected = _this$props$showSelec === void 0 ? true : _this$props$showSelec;
       var selected = item.selected;
       if (showSelected && selected) {
+        if ((0, _platformFeatureFlags.getBooleanFF)('platform.editor.a11y-table-floating-toolbar-dropdown-menu_zkb33')) {
+          return (0, _react2.jsx)("span", {
+            "aria-hidden": "true"
+          }, (0, _react2.jsx)(_done.default, {
+            primaryColor: "var(--ds-icon-selected, ".concat(_colors.B400, ")"),
+            size: "small",
+            label: intl.formatMessage(_floatingToolbar.messages.confirmModalOK)
+          }));
+        }
         return (0, _react2.jsx)(_done.default, {
           primaryColor: "var(--ds-icon-selected, ".concat(_colors.B400, ")"),
           size: "small",

package/dist/es2019/plugin.js

@@ -98,6 +98,8 @@ const getDomRefFromSelection = (view, dispatchAnalyticsEvent) => {
           position: view.state.selection.from,
           docSize: view.state.doc.nodeSize,
           error: error.toString(),
+          // @ts-expect-error - Object literal may only specify known properties, 'errorStack' does not exist in type
+          // This error was introduced after upgrading to TypeScript 5
           errorStack: error.stack || undefined
         }
       };

package/dist/es2019/ui/DropdownMenu.js

@@ -7,6 +7,7 @@ import { injectIntl } from 'react-intl-next';
 import { messages } from '@atlaskit/editor-common/floating-toolbar';
 import EditorDoneIcon from '@atlaskit/icon/glyph/editor/done';
 import { ButtonItem } from '@atlaskit/menu';
+import { getBooleanFF } from '@atlaskit/platform-feature-flags';
 import { B400 } from '@atlaskit/theme/colors';
 // eslint-disable-next-line @atlaskit/design-system/no-deprecated-imports
 import { gridSize } from '@atlaskit/theme/constants';
@@ -119,6 +120,22 @@ const DropdownMenuItem = ({
       e.preventDefault();
     }
   }, [item.disabled]);
+  const isAriaChecked = item => {
+    const {
+      selected,
+      domItemOptions
+    } = item;
+    if (getBooleanFF('platform.editor.a11y-table-floating-toolbar-dropdown-menu_zkb33') && (domItemOptions === null || domItemOptions === void 0 ? void 0 : domItemOptions.type) === 'item-checkbox') {
+      return selected;
+    }
+    return undefined;
+  };
+  const hasRole = item => {
+    const {
+      domItemOptions
+    } = item;
+    return getBooleanFF('platform.editor.a11y-table-floating-toolbar-dropdown-menu_zkb33') && (domItemOptions === null || domItemOptions === void 0 ? void 0 : domItemOptions.type) === 'item-checkbox' ? 'menuitemcheckbox' : undefined;
+  };
   useEffect(() => {
     const labelRefCurrent = labelRef.current;
     // eslint-disable-next-line @repo/internal/dom-events/no-unsafe-event-listeners
@@ -144,7 +161,9 @@ const DropdownMenuItem = ({
     onMouseLeave: handleItemMouseLeave,
     onMouseOut: handleItemMouseOut,
     onFocus: handleItemOnFocus,
-    onBlur: handleItemOnBlur
+    onBlur: handleItemOnBlur,
+    role: hasRole(item),
+    "aria-checked": isAriaChecked(item)
   }, jsx("span", {
     ref: labelRef,
     css: labelStyles
@@ -168,7 +187,8 @@ class Dropdown extends Component {
       editorView
     } = this.props;
     return jsx("div", {
-      css: menuContainerStyles
+      css: menuContainerStyles,
+      role: getBooleanFF('platform.editor.a11y-table-floating-toolbar-dropdown-menu_zkb33') ? 'menu' : undefined
     }, items.filter(item => !item.hidden).map((item, idx) => jsx(DropdownMenuItem, {
       key: idx,
       item: item,
@@ -186,6 +206,15 @@ class Dropdown extends Component {
       selected
     } = item;
     if (showSelected && selected) {
+      if (getBooleanFF('platform.editor.a11y-table-floating-toolbar-dropdown-menu_zkb33')) {
+        return jsx("span", {
+          "aria-hidden": "true"
+        }, jsx(EditorDoneIcon, {
+          primaryColor: `var(--ds-icon-selected, ${B400})`,
+          size: "small",
+          label: intl.formatMessage(messages.confirmModalOK)
+        }));
+      }
       return jsx(EditorDoneIcon, {
         primaryColor: `var(--ds-icon-selected, ${B400})`,
         size: "small",

package/dist/esm/plugin.js

@@ -99,6 +99,8 @@ var getDomRefFromSelection = function getDomRefFromSelection(view, dispatchAnaly
           position: view.state.selection.from,
           docSize: view.state.doc.nodeSize,
           error: error.toString(),
+          // @ts-expect-error - Object literal may only specify known properties, 'errorStack' does not exist in type
+          // This error was introduced after upgrading to TypeScript 5
           errorStack: error.stack || undefined
         }
       };

package/dist/esm/ui/DropdownMenu.js

@@ -15,6 +15,7 @@ import { injectIntl } from 'react-intl-next';
 import { messages } from '@atlaskit/editor-common/floating-toolbar';
 import EditorDoneIcon from '@atlaskit/icon/glyph/editor/done';
 import { ButtonItem } from '@atlaskit/menu';
+import { getBooleanFF } from '@atlaskit/platform-feature-flags';
 import { B400 } from '@atlaskit/theme/colors';
 // eslint-disable-next-line @atlaskit/design-system/no-deprecated-imports
 import { gridSize } from '@atlaskit/theme/constants';
@@ -129,6 +130,18 @@ var DropdownMenuItem = function DropdownMenuItem(_ref) {
       e.preventDefault();
     }
   }, [item.disabled]);
+  var isAriaChecked = function isAriaChecked(item) {
+    var selected = item.selected,
+      domItemOptions = item.domItemOptions;
+    if (getBooleanFF('platform.editor.a11y-table-floating-toolbar-dropdown-menu_zkb33') && (domItemOptions === null || domItemOptions === void 0 ? void 0 : domItemOptions.type) === 'item-checkbox') {
+      return selected;
+    }
+    return undefined;
+  };
+  var hasRole = function hasRole(item) {
+    var domItemOptions = item.domItemOptions;
+    return getBooleanFF('platform.editor.a11y-table-floating-toolbar-dropdown-menu_zkb33') && (domItemOptions === null || domItemOptions === void 0 ? void 0 : domItemOptions.type) === 'item-checkbox' ? 'menuitemcheckbox' : undefined;
+  };
   useEffect(function () {
     var labelRefCurrent = labelRef.current;
     // eslint-disable-next-line @repo/internal/dom-events/no-unsafe-event-listeners
@@ -154,7 +167,9 @@ var DropdownMenuItem = function DropdownMenuItem(_ref) {
     onMouseLeave: handleItemMouseLeave,
     onMouseOut: handleItemMouseOut,
     onFocus: handleItemOnFocus,
-    onBlur: handleItemOnBlur
+    onBlur: handleItemOnBlur,
+    role: hasRole(item),
+    "aria-checked": isAriaChecked(item)
   }, jsx("span", {
     ref: labelRef,
     css: labelStyles
@@ -186,7 +201,8 @@ var Dropdown = /*#__PURE__*/function (_Component) {
         intl = _this$props.intl,
         editorView = _this$props.editorView;
       return jsx("div", {
-        css: menuContainerStyles
+        css: menuContainerStyles,
+        role: getBooleanFF('platform.editor.a11y-table-floating-toolbar-dropdown-menu_zkb33') ? 'menu' : undefined
       }, items.filter(function (item) {
         return !item.hidden;
       }).map(function (item, idx) {
@@ -207,6 +223,15 @@ var Dropdown = /*#__PURE__*/function (_Component) {
         showSelected = _this$props$showSelec === void 0 ? true : _this$props$showSelec;
       var selected = item.selected;
       if (showSelected && selected) {
+        if (getBooleanFF('platform.editor.a11y-table-floating-toolbar-dropdown-menu_zkb33')) {
+          return jsx("span", {
+            "aria-hidden": "true"
+          }, jsx(EditorDoneIcon, {
+            primaryColor: "var(--ds-icon-selected, ".concat(B400, ")"),
+            size: "small",
+            label: intl.formatMessage(messages.confirmModalOK)
+          }));
+        }
         return jsx(EditorDoneIcon, {
           primaryColor: "var(--ds-icon-selected, ".concat(B400, ")"),
           size: "small",

package/dist/types/pm-plugins/toolbar-data/plugin-factory.d.ts

@@ -1 +1 @@
-export declare const createPluginState: (dispatch: import("@atlaskit/editor-common/event-dispatcher").Dispatch<any>, initialState: import("../..").FloatingToolbarPluginData | ((state: import("prosemirror-state").EditorState) => import("../..").FloatingToolbarPluginData)) => import("prosemirror-state").SafeStateField<import("../..").FloatingToolbarPluginData>, createCommand: <A = import("./types").FloatingToolbarPluginAction>(action: A | ((state: Readonly<import("prosemirror-state").EditorState>) => false | A), transform?: ((tr: import("prosemirror-state").Transaction, state: import("prosemirror-state").EditorState) => import("prosemirror-state").Transaction) | undefined) => import("@atlaskit/editor-common/types").Command, getPluginState: (state: import("prosemirror-state").EditorState) => import("../..").FloatingToolbarPluginData;
+export declare const createPluginState: (dispatch: import("@atlaskit/editor-common/event-dispatcher").Dispatch, initialState: import("../..").FloatingToolbarPluginData | ((state: import("prosemirror-state").EditorState) => import("../..").FloatingToolbarPluginData)) => import("prosemirror-state").SafeStateField<import("../..").FloatingToolbarPluginData>, createCommand: <A = import("./types").FloatingToolbarPluginAction>(action: A | ((state: Readonly<import("prosemirror-state").EditorState>) => false | A), transform?: ((tr: import("prosemirror-state").Transaction, state: import("prosemirror-state").EditorState) => import("prosemirror-state").Transaction) | undefined) => import("@atlaskit/editor-common/types").Command, getPluginState: (state: import("prosemirror-state").EditorState) => import("../..").FloatingToolbarPluginData;

package/dist/types/ui/ConfirmationModal.d.ts

@@ -1,6 +1,6 @@
 import React from 'react';
 import type { WrappedComponentProps } from 'react-intl-next';
 import type { ConfirmationDialogProps } from '@atlaskit/editor-common/types';
-export declare const ConfirmationModal: React.FC<import("react-intl-next").WithIntlProps<ConfirmationDialogProps & WrappedComponentProps<"intl">>> & {
-    WrappedComponent: React.ComponentType<ConfirmationDialogProps & WrappedComponentProps<"intl">>;
+export declare const ConfirmationModal: React.FC<import("react-intl-next").WithIntlProps<ConfirmationDialogProps & WrappedComponentProps>> & {
+    WrappedComponent: React.ComponentType<ConfirmationDialogProps & WrappedComponentProps>;
 };

package/dist/types/ui/DropdownMenu.d.ts

@@ -23,7 +23,7 @@ export interface DropdownButtonItemProps extends ButtonItemProps {
     onFocus?: (event: React.MouseEvent | React.KeyboardEvent) => void;
     onBlur?: (event: React.MouseEvent | React.KeyboardEvent) => void;
 }
-declare const _default: import("react").FC<import("react-intl-next").WithIntlProps<Props & WrappedComponentProps<"intl">>> & {
-    WrappedComponent: import("react").ComponentType<Props & WrappedComponentProps<"intl">>;
+declare const _default: import("react").FC<import("react-intl-next").WithIntlProps<Props & WrappedComponentProps>> & {
+    WrappedComponent: import("react").ComponentType<Props & WrappedComponentProps>;
 };
 export default _default;

package/dist/types/ui/Toolbar.d.ts

@@ -40,7 +40,7 @@ export interface State {
     scrollDisabled: boolean;
     mounted: boolean;
 }
-declare const _default: React.FC<import("react-intl-next").WithIntlProps<Props & WrappedComponentProps<"intl">>> & {
-    WrappedComponent: React.ComponentType<Props & WrappedComponentProps<"intl">>;
+declare const _default: React.FC<import("react-intl-next").WithIntlProps<Props & WrappedComponentProps>> & {
+    WrappedComponent: React.ComponentType<Props & WrappedComponentProps>;
 };
 export default _default;

package/dist/types-ts4.5/pm-plugins/toolbar-data/plugin-factory.d.ts

@@ -1 +1 @@
-export declare const createPluginState: (dispatch: import("@atlaskit/editor-common/event-dispatcher").Dispatch<any>, initialState: import("../..").FloatingToolbarPluginData | ((state: import("prosemirror-state").EditorState) => import("../..").FloatingToolbarPluginData)) => import("prosemirror-state").SafeStateField<import("../..").FloatingToolbarPluginData>, createCommand: <A = import("./types").FloatingToolbarPluginAction>(action: A | ((state: Readonly<import("prosemirror-state").EditorState>) => false | A), transform?: ((tr: import("prosemirror-state").Transaction, state: import("prosemirror-state").EditorState) => import("prosemirror-state").Transaction) | undefined) => import("@atlaskit/editor-common/types").Command, getPluginState: (state: import("prosemirror-state").EditorState) => import("../..").FloatingToolbarPluginData;
+export declare const createPluginState: (dispatch: import("@atlaskit/editor-common/event-dispatcher").Dispatch, initialState: import("../..").FloatingToolbarPluginData | ((state: import("prosemirror-state").EditorState) => import("../..").FloatingToolbarPluginData)) => import("prosemirror-state").SafeStateField<import("../..").FloatingToolbarPluginData>, createCommand: <A = import("./types").FloatingToolbarPluginAction>(action: A | ((state: Readonly<import("prosemirror-state").EditorState>) => false | A), transform?: ((tr: import("prosemirror-state").Transaction, state: import("prosemirror-state").EditorState) => import("prosemirror-state").Transaction) | undefined) => import("@atlaskit/editor-common/types").Command, getPluginState: (state: import("prosemirror-state").EditorState) => import("../..").FloatingToolbarPluginData;

package/dist/types-ts4.5/ui/ConfirmationModal.d.ts

@@ -1,6 +1,6 @@
 import React from 'react';
 import type { WrappedComponentProps } from 'react-intl-next';
 import type { ConfirmationDialogProps } from '@atlaskit/editor-common/types';
-export declare const ConfirmationModal: React.FC<import("react-intl-next").WithIntlProps<ConfirmationDialogProps & WrappedComponentProps<"intl">>> & {
-    WrappedComponent: React.ComponentType<ConfirmationDialogProps & WrappedComponentProps<"intl">>;
+export declare const ConfirmationModal: React.FC<import("react-intl-next").WithIntlProps<ConfirmationDialogProps & WrappedComponentProps>> & {
+    WrappedComponent: React.ComponentType<ConfirmationDialogProps & WrappedComponentProps>;
 };

package/dist/types-ts4.5/ui/DropdownMenu.d.ts

@@ -23,7 +23,7 @@ export interface DropdownButtonItemProps extends ButtonItemProps {
     onFocus?: (event: React.MouseEvent | React.KeyboardEvent) => void;
     onBlur?: (event: React.MouseEvent | React.KeyboardEvent) => void;
 }
-declare const _default: import("react").FC<import("react-intl-next").WithIntlProps<Props & WrappedComponentProps<"intl">>> & {
-    WrappedComponent: import("react").ComponentType<Props & WrappedComponentProps<"intl">>;
+declare const _default: import("react").FC<import("react-intl-next").WithIntlProps<Props & WrappedComponentProps>> & {
+    WrappedComponent: import("react").ComponentType<Props & WrappedComponentProps>;
 };
 export default _default;

package/dist/types-ts4.5/ui/Toolbar.d.ts

@@ -40,7 +40,7 @@ export interface State {
     scrollDisabled: boolean;
     mounted: boolean;
 }
-declare const _default: React.FC<import("react-intl-next").WithIntlProps<Props & WrappedComponentProps<"intl">>> & {
-    WrappedComponent: React.ComponentType<Props & WrappedComponentProps<"intl">>;
+declare const _default: React.FC<import("react-intl-next").WithIntlProps<Props & WrappedComponentProps>> & {
+    WrappedComponent: React.ComponentType<Props & WrappedComponentProps>;
 };
 export default _default;

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@atlaskit/editor-plugin-floating-toolbar",
-  "version": "1.2.1",
+  "version": "1.2.3",
   "description": "Floating toolbar plugin for @atlaskit/editor-core",
   "author": "Atlassian Pty Ltd",
   "license": "Apache-2.0",
@@ -25,26 +25,26 @@
   },
   "dependencies": {
     "@atlaskit/adf-utils": "^19.0.0",
-    "@atlaskit/button": "^17.7.0",
+    "@atlaskit/button": "^17.11.0",
     "@atlaskit/checkbox": "^13.1.0",
-    "@atlaskit/editor-common": "^78.14.0",
-    "@atlaskit/editor-palette": "1.5.2",
+    "@atlaskit/editor-common": "^78.23.0",
+    "@atlaskit/editor-palette": "1.5.3",
     "@atlaskit/editor-plugin-context-panel": "^1.0.0",
     "@atlaskit/editor-plugin-copy-button": "^1.0.0",
     "@atlaskit/editor-plugin-decorations": "^1.0.0",
     "@atlaskit/editor-plugin-editor-disabled": "^1.0.0",
     "@atlaskit/editor-plugin-editor-viewmode": "^1.0.0",
     "@atlaskit/editor-plugin-extension": "^1.1.0",
-    "@atlaskit/editor-plugin-table": "^7.5.0",
+    "@atlaskit/editor-plugin-table": "^7.6.0",
     "@atlaskit/editor-prosemirror": "3.0.0",
     "@atlaskit/emoji": "^67.6.0",
     "@atlaskit/icon": "^22.1.0",
     "@atlaskit/menu": "^2.1.0",
     "@atlaskit/modal-dialog": "^12.10.0",
     "@atlaskit/platform-feature-flags": "^0.2.5",
-    "@atlaskit/select": "^17.3.0",
-    "@atlaskit/theme": "^12.6.0",
-    "@atlaskit/tokens": "^1.41.0",
+    "@atlaskit/select": "^17.6.0",
+    "@atlaskit/theme": "^12.7.0",
+    "@atlaskit/tokens": "^1.43.0",
     "@atlaskit/tooltip": "^18.1.0",
     "@babel/runtime": "^7.0.0",
     "@emotion/react": "^11.7.1",
@@ -64,7 +64,7 @@
     "@testing-library/user-event": "^14.4.3",
     "enzyme": "^3.10.0",
     "react-dom": "^16.8.0",
-    "typescript": "~4.9.5",
+    "typescript": "~5.4.2",
     "wait-for-expect": "^1.2.0"
   },
   "techstack": {
@@ -90,11 +90,9 @@
       "ui-components": [
         "lite-mode"
       ],
-      "deprecation": [
-        "no-deprecated-imports"
-      ],
+      "deprecation": "no-deprecated-imports",
       "styling": [
-        "static",
+        "emotion",
         "emotion"
       ]
     }
@@ -111,6 +109,9 @@
   "platform-feature-flags": {
     "platform.editor.a11y-floating-toolbar-markup_vexmo": {
       "type": "boolean"
+    },
+    "platform.editor.a11y-table-floating-toolbar-dropdown-menu_zkb33": {
+      "type": "boolean"
     }
   }
-}
+}