@atlaskit/editor-plugin-expand 2.9.4 → 2.9.5

package/CHANGELOG.md

@@ -1,5 +1,15 @@
 # @atlaskit/editor-plugin-expand
 
+## 2.9.5
+
+### Patch Changes
+
+- [#159926](https://stash.atlassian.com/projects/CONFCLOUD/repos/confluence-frontend/pull-requests/159926)
+  [`f60e3e772ea72`](https://stash.atlassian.com/projects/CONFCLOUD/repos/confluence-frontend/commits/f60e3e772ea72) -
+  Add null check to fix crash in legacy toolbar while swapping ebetween view and edit mode in love
+  pages
+- Updated dependencies
+
 ## 2.9.4
 
 ### Patch Changes

package/dist/cjs/legacyExpand/toolbar.js

@@ -12,13 +12,16 @@ var _commands = require("./commands");
 var _pluginFactory = require("./pm-plugins/plugin-factory");
 var getToolbarConfig = exports.getToolbarConfig = function getToolbarConfig(api) {
   return function (state, _ref) {
-    var _api$decorations$acti, _api$decorations, _api$analytics;
+    var _api$decorations$acti, _api$decorations, _api$analytics, _getPluginState;
     var formatMessage = _ref.formatMessage;
     var _ref2 = (_api$decorations$acti = api === null || api === void 0 || (_api$decorations = api.decorations) === null || _api$decorations === void 0 ? void 0 : _api$decorations.actions) !== null && _api$decorations$acti !== void 0 ? _api$decorations$acti : {},
       hoverDecoration = _ref2.hoverDecoration;
     var editorAnalyticsAPI = api === null || api === void 0 || (_api$analytics = api.analytics) === null || _api$analytics === void 0 ? void 0 : _api$analytics.actions;
-    var _getPluginState = (0, _pluginFactory.getPluginState)(state),
-      expandRef = _getPluginState.expandRef;
+    // JST-1060364: We are observing this crashing the editor where the `expandPlugin` doesn't exist
+    // in the editor (resulting in `Cannot destructure property 'expandRef' of ...`).
+    // For now let's add a null check to ensure we don't crash while we investigate further.
+    var _ref3 = (_getPluginState = (0, _pluginFactory.getPluginState)(state)) !== null && _getPluginState !== void 0 ? _getPluginState : {},
+      expandRef = _ref3.expandRef;
     if (expandRef) {
       var _state$schema$nodes = state.schema.nodes,
         nestedExpand = _state$schema$nodes.nestedExpand,

package/dist/es2019/legacyExpand/toolbar.js

@@ -6,14 +6,17 @@ import { getPluginState } from './pm-plugins/plugin-factory';
 export const getToolbarConfig = api => (state, {
   formatMessage
 }) => {
-  var _api$decorations$acti, _api$decorations, _api$analytics;
+  var _api$decorations$acti, _api$decorations, _api$analytics, _getPluginState;
   const {
     hoverDecoration
   } = (_api$decorations$acti = api === null || api === void 0 ? void 0 : (_api$decorations = api.decorations) === null || _api$decorations === void 0 ? void 0 : _api$decorations.actions) !== null && _api$decorations$acti !== void 0 ? _api$decorations$acti : {};
   const editorAnalyticsAPI = api === null || api === void 0 ? void 0 : (_api$analytics = api.analytics) === null || _api$analytics === void 0 ? void 0 : _api$analytics.actions;
+  // JST-1060364: We are observing this crashing the editor where the `expandPlugin` doesn't exist
+  // in the editor (resulting in `Cannot destructure property 'expandRef' of ...`).
+  // For now let's add a null check to ensure we don't crash while we investigate further.
   const {
     expandRef
-  } = getPluginState(state);
+  } = (_getPluginState = getPluginState(state)) !== null && _getPluginState !== void 0 ? _getPluginState : {};
   if (expandRef) {
     const {
       nestedExpand,

package/dist/esm/legacyExpand/toolbar.js

@@ -5,13 +5,16 @@ import { deleteExpand } from './commands';
 import { getPluginState } from './pm-plugins/plugin-factory';
 export var getToolbarConfig = function getToolbarConfig(api) {
   return function (state, _ref) {
-    var _api$decorations$acti, _api$decorations, _api$analytics;
+    var _api$decorations$acti, _api$decorations, _api$analytics, _getPluginState;
     var formatMessage = _ref.formatMessage;
     var _ref2 = (_api$decorations$acti = api === null || api === void 0 || (_api$decorations = api.decorations) === null || _api$decorations === void 0 ? void 0 : _api$decorations.actions) !== null && _api$decorations$acti !== void 0 ? _api$decorations$acti : {},
       hoverDecoration = _ref2.hoverDecoration;
     var editorAnalyticsAPI = api === null || api === void 0 || (_api$analytics = api.analytics) === null || _api$analytics === void 0 ? void 0 : _api$analytics.actions;
-    var _getPluginState = getPluginState(state),
-      expandRef = _getPluginState.expandRef;
+    // JST-1060364: We are observing this crashing the editor where the `expandPlugin` doesn't exist
+    // in the editor (resulting in `Cannot destructure property 'expandRef' of ...`).
+    // For now let's add a null check to ensure we don't crash while we investigate further.
+    var _ref3 = (_getPluginState = getPluginState(state)) !== null && _getPluginState !== void 0 ? _getPluginState : {},
+      expandRef = _ref3.expandRef;
     if (expandRef) {
       var _state$schema$nodes = state.schema.nodes,
         nestedExpand = _state$schema$nodes.nestedExpand,

package/package.json

@@ -1,6 +1,6 @@
 {
 	"name": "@atlaskit/editor-plugin-expand",
-	"version": "2.9.4",
+	"version": "2.9.5",
 	"description": "Expand plugin for @atlaskit/editor-core",
 	"author": "Atlassian Pty Ltd",
 	"license": "Apache-2.0",
@@ -33,7 +33,7 @@
 	"dependencies": {
 		"@atlaskit/adf-schema": "^44.2.0",
 		"@atlaskit/button": "^20.3.0",
-		"@atlaskit/editor-common": "^94.11.0",
+		"@atlaskit/editor-common": "^94.12.0",
 		"@atlaskit/editor-plugin-analytics": "^1.10.0",
 		"@atlaskit/editor-plugin-decorations": "^1.3.0",
 		"@atlaskit/editor-plugin-editor-disabled": "^1.3.0",