@atlaskit/editor-plugin-expand 2.7.6 → 2.8.0

package/CHANGELOG.md

@@ -1,5 +1,19 @@
 # @atlaskit/editor-plugin-expand
 
+## 2.8.0
+
+### Minor Changes
+
+- [#146025](https://stash.atlassian.com/projects/CONFCLOUD/repos/confluence-frontend/pull-requests/146025)
+  [`03eae90c614d1`](https://stash.atlassian.com/projects/CONFCLOUD/repos/confluence-frontend/commits/03eae90c614d1) -
+  Remove platform.editor.live-view.disable-editing-in-view-mode_fi1rx feature flag
+
+## 2.7.7
+
+### Patch Changes
+
+- Updated dependencies
+
 ## 2.7.6
 
 ### Patch Changes

package/dist/cjs/legacyExpand/nodeviews/index.js

@@ -52,11 +52,11 @@ var toDOM = function toDOM(node, __livePage, intl, titleReadOnly, contentEditabl
     value: node.attrs.title,
     placeholder: intl && intl.formatMessage(_ui.expandMessages.expandPlaceholderText) || _ui.expandMessages.expandPlaceholderText.defaultMessage,
     type: 'text',
-    readonly: titleReadOnly && (0, _platformFeatureFlags.fg)('platform.editor.live-view.disable-editing-in-view-mode_fi1rx') ? 'true' : undefined
+    readonly: titleReadOnly ? 'true' : undefined
   }]]], ['div', {
     // prettier-ignore
     class: _styles.expandClassNames.content,
-    contenteditable: contentEditable && (0, _platformFeatureFlags.fg)('platform.editor.live-view.disable-editing-in-view-mode_fi1rx') ? contentEditable ? 'true' : 'false' : undefined
+    contenteditable: contentEditable !== undefined ? contentEditable ? 'true' : 'false' : undefined
   }, 0]];
 };
 var ExpandNodeView = exports.ExpandNodeView = /*#__PURE__*/function () {
@@ -398,7 +398,7 @@ var ExpandNodeView = exports.ExpandNodeView = /*#__PURE__*/function () {
     });
     (0, _defineProperty2.default)(this, "getContentEditable", function (node) {
       var contentEditable = _this.__livePage && (0, _platformFeatureFlags.fg)('platform.editor.live-pages-expand-divergence') ? !node.attrs.__expanded : node.attrs.__expanded;
-      if (_this.api && _this.api.editorDisabled && (0, _platformFeatureFlags.fg)('platform.editor.live-view.disable-editing-in-view-mode_fi1rx')) {
+      if (_this.api && _this.api.editorDisabled) {
         var _this$api$editorDisab;
         return !((_this$api$editorDisab = _this.api.editorDisabled.sharedState.currentState()) !== null && _this$api$editorDisab !== void 0 && _this$api$editorDisab.editorDisabled) && contentEditable;
       }
@@ -455,7 +455,7 @@ var ExpandNodeView = exports.ExpandNodeView = /*#__PURE__*/function () {
         // eslint-disable-next-line @repo/internal/dom-events/no-unsafe-event-listeners
         this.icon.addEventListener('keydown', this.handleIconKeyDown);
       }
-      if ((_this$api6 = this.api) !== null && _this$api6 !== void 0 && _this$api6.editorDisabled && (0, _platformFeatureFlags.fg)('platform.editor.live-view.disable-editing-in-view-mode_fi1rx')) {
+      if ((_this$api6 = this.api) !== null && _this$api6 !== void 0 && _this$api6.editorDisabled) {
         this.cleanUpEditorDisabledOnChange = this.api.editorDisabled.sharedState.onChange(function (sharedState) {
           var editorDisabled = sharedState.nextSharedState.editorDisabled;
           if (_this2.input) {

package/dist/cjs/singlePlayerExpand/node-views/index.js

@@ -18,7 +18,6 @@ var _utils = require("@atlaskit/editor-common/utils");
 var _history = require("@atlaskit/editor-prosemirror/history");
 var _model = require("@atlaskit/editor-prosemirror/model");
 var _state = require("@atlaskit/editor-prosemirror/state");
-var _platformFeatureFlags = require("@atlaskit/platform-feature-flags");
 var _commands = require("../commands");
 var _NodeView = require("../ui/NodeView");
 var ExpandNodeView = exports.ExpandNodeView = /*#__PURE__*/function () {
@@ -354,7 +353,7 @@ var ExpandNodeView = exports.ExpandNodeView = /*#__PURE__*/function () {
     });
     (0, _defineProperty2.default)(this, "getContentEditable", function (node) {
       var contentEditable = !(0, _expand.isExpandCollapsed)(node);
-      if (_this.api && _this.api.editorDisabled && (0, _platformFeatureFlags.fg)('platform.editor.live-view.disable-editing-in-view-mode_fi1rx')) {
+      if (_this.api && _this.api.editorDisabled) {
         var _this$api$editorDisab;
         return !((_this$api$editorDisab = _this.api.editorDisabled.sharedState.currentState()) !== null && _this$api$editorDisab !== void 0 && _this$api$editorDisab.editorDisabled) && contentEditable;
       }
@@ -398,7 +397,7 @@ var ExpandNodeView = exports.ExpandNodeView = /*#__PURE__*/function () {
     // Prevent ProseMirror from getting a focus event (causes weird selection issues).
     this.titleContainer.addEventListener('focus', this.handleFocus);
     this.icon.addEventListener('keydown', this.handleIconKeyDown);
-    if ((_this$api6 = this.api) !== null && _this$api6 !== void 0 && _this$api6.editorDisabled && (0, _platformFeatureFlags.fg)('platform.editor.live-view.disable-editing-in-view-mode_fi1rx')) {
+    if ((_this$api6 = this.api) !== null && _this$api6 !== void 0 && _this$api6.editorDisabled) {
       this.cleanUpEditorDisabledOnChange = this.api.editorDisabled.sharedState.onChange(function (sharedState) {
         var editorDisabled = sharedState.nextSharedState.editorDisabled;
         if (_this.input) {

package/dist/cjs/singlePlayerExpand/ui/NodeView.js

@@ -10,7 +10,6 @@ var _reactDom = _interopRequireDefault(require("react-dom"));
 var _expand = require("@atlaskit/editor-common/expand");
 var _styles = require("@atlaskit/editor-common/styles");
 var _ui = require("@atlaskit/editor-common/ui");
-var _platformFeatureFlags = require("@atlaskit/platform-feature-flags");
 var _ExpandButton = require("../ui/ExpandButton");
 var buildExpandClassName = exports.buildExpandClassName = function buildExpandClassName(type, expanded) {
   return "".concat(_styles.expandClassNames.prefix, " ").concat(_styles.expandClassNames.type(type), " ").concat(expanded ? _styles.expandClassNames.expanded : '');
@@ -43,11 +42,11 @@ var toDOM = exports.toDOM = function toDOM(node, __livePage, intl, titleReadOnly
     value: node.attrs.title,
     placeholder: intl && typeof intl.formatMessage === 'function' && intl.formatMessage(_ui.expandMessages.expandPlaceholderText) || _ui.expandMessages.expandPlaceholderText.defaultMessage,
     type: 'text',
-    readonly: (0, _platformFeatureFlags.getBooleanFF)('platform.editor.live-view.disable-editing-in-view-mode_fi1rx') && titleReadOnly ? 'true' : undefined
+    readonly: titleReadOnly ? 'true' : undefined
   }]]], ['div', {
     // prettier-ignore
     class: _styles.expandClassNames.content,
-    contenteditable: (0, _platformFeatureFlags.getBooleanFF)('platform.editor.live-view.disable-editing-in-view-mode_fi1rx') && contentEditable ? contentEditable ? 'true' : 'false' : undefined
+    contenteditable: contentEditable !== undefined ? contentEditable ? 'true' : 'false' : undefined
   }, 0]];
 };
 var renderIcon = exports.renderIcon = function renderIcon(icon, allowInteractiveExpand, expanded, intl) {

package/dist/es2019/legacyExpand/nodeviews/index.js

@@ -41,11 +41,11 @@ const toDOM = (node, __livePage, intl, titleReadOnly, contentEditable) => ['div'
   value: node.attrs.title,
   placeholder: intl && intl.formatMessage(expandMessages.expandPlaceholderText) || expandMessages.expandPlaceholderText.defaultMessage,
   type: 'text',
-  readonly: titleReadOnly && fg('platform.editor.live-view.disable-editing-in-view-mode_fi1rx') ? 'true' : undefined
+  readonly: titleReadOnly ? 'true' : undefined
 }]]], ['div', {
   // prettier-ignore
   class: expandClassNames.content,
-  contenteditable: contentEditable && fg('platform.editor.live-view.disable-editing-in-view-mode_fi1rx') ? contentEditable ? 'true' : 'false' : undefined
+  contenteditable: contentEditable !== undefined ? contentEditable ? 'true' : 'false' : undefined
 }, 0]];
 export class ExpandNodeView {
   constructor(_node, view, getPos, getIntl, isMobile, selectNearNode, api, allowInteractiveExpand = true, __livePage = false, cleanUpEditorDisabledOnChange) {
@@ -399,7 +399,7 @@ export class ExpandNodeView {
     });
     _defineProperty(this, "getContentEditable", node => {
       const contentEditable = this.__livePage && fg('platform.editor.live-pages-expand-divergence') ? !node.attrs.__expanded : node.attrs.__expanded;
-      if (this.api && this.api.editorDisabled && fg('platform.editor.live-view.disable-editing-in-view-mode_fi1rx')) {
+      if (this.api && this.api.editorDisabled) {
         var _this$api$editorDisab;
         return !((_this$api$editorDisab = this.api.editorDisabled.sharedState.currentState()) !== null && _this$api$editorDisab !== void 0 && _this$api$editorDisab.editorDisabled) && contentEditable;
       }
@@ -454,7 +454,7 @@ export class ExpandNodeView {
       // eslint-disable-next-line @repo/internal/dom-events/no-unsafe-event-listeners
       this.icon.addEventListener('keydown', this.handleIconKeyDown);
     }
-    if ((_this$api6 = this.api) !== null && _this$api6 !== void 0 && _this$api6.editorDisabled && fg('platform.editor.live-view.disable-editing-in-view-mode_fi1rx')) {
+    if ((_this$api6 = this.api) !== null && _this$api6 !== void 0 && _this$api6.editorDisabled) {
       this.cleanUpEditorDisabledOnChange = this.api.editorDisabled.sharedState.onChange(sharedState => {
         const editorDisabled = sharedState.nextSharedState.editorDisabled;
         if (this.input) {

package/dist/es2019/singlePlayerExpand/node-views/index.js

@@ -8,7 +8,6 @@ import { closestElement, isEmptyNode } from '@atlaskit/editor-common/utils';
 import { redo, undo } from '@atlaskit/editor-prosemirror/history';
 import { DOMSerializer } from '@atlaskit/editor-prosemirror/model';
 import { NodeSelection, Selection } from '@atlaskit/editor-prosemirror/state';
-import { fg } from '@atlaskit/platform-feature-flags';
 import { deleteExpand, setSelectionInsideExpand, toggleExpandExpanded, updateExpandTitle } from '../commands';
 import { buildExpandClassName, renderIcon, toDOM } from '../ui/NodeView';
 export class ExpandNodeView {
@@ -355,7 +354,7 @@ export class ExpandNodeView {
     });
     _defineProperty(this, "getContentEditable", node => {
       const contentEditable = !isExpandCollapsed(node);
-      if (this.api && this.api.editorDisabled && fg('platform.editor.live-view.disable-editing-in-view-mode_fi1rx')) {
+      if (this.api && this.api.editorDisabled) {
         var _this$api$editorDisab;
         return !((_this$api$editorDisab = this.api.editorDisabled.sharedState.currentState()) !== null && _this$api$editorDisab !== void 0 && _this$api$editorDisab.editorDisabled) && contentEditable;
       }
@@ -400,7 +399,7 @@ export class ExpandNodeView {
     // Prevent ProseMirror from getting a focus event (causes weird selection issues).
     this.titleContainer.addEventListener('focus', this.handleFocus);
     this.icon.addEventListener('keydown', this.handleIconKeyDown);
-    if ((_this$api6 = this.api) !== null && _this$api6 !== void 0 && _this$api6.editorDisabled && fg('platform.editor.live-view.disable-editing-in-view-mode_fi1rx')) {
+    if ((_this$api6 = this.api) !== null && _this$api6 !== void 0 && _this$api6.editorDisabled) {
       this.cleanUpEditorDisabledOnChange = this.api.editorDisabled.sharedState.onChange(sharedState => {
         const editorDisabled = sharedState.nextSharedState.editorDisabled;
         if (this.input) {

package/dist/es2019/singlePlayerExpand/ui/NodeView.js

@@ -3,7 +3,6 @@ import ReactDOM from 'react-dom';
 import { expandedState } from '@atlaskit/editor-common/expand';
 import { expandClassNames } from '@atlaskit/editor-common/styles';
 import { expandMessages } from '@atlaskit/editor-common/ui';
-import { getBooleanFF } from '@atlaskit/platform-feature-flags';
 import { ExpandButton } from '../ui/ExpandButton';
 export const buildExpandClassName = (type, expanded) => {
   return `${expandClassNames.prefix} ${expandClassNames.type(type)} ${expanded ? expandClassNames.expanded : ''}`;
@@ -36,11 +35,11 @@ export const toDOM = (node, __livePage, intl, titleReadOnly, contentEditable) =>
     value: node.attrs.title,
     placeholder: intl && typeof intl.formatMessage === 'function' && intl.formatMessage(expandMessages.expandPlaceholderText) || expandMessages.expandPlaceholderText.defaultMessage,
     type: 'text',
-    readonly: getBooleanFF('platform.editor.live-view.disable-editing-in-view-mode_fi1rx') && titleReadOnly ? 'true' : undefined
+    readonly: titleReadOnly ? 'true' : undefined
   }]]], ['div', {
     // prettier-ignore
     class: expandClassNames.content,
-    contenteditable: getBooleanFF('platform.editor.live-view.disable-editing-in-view-mode_fi1rx') && contentEditable ? contentEditable ? 'true' : 'false' : undefined
+    contenteditable: contentEditable !== undefined ? contentEditable ? 'true' : 'false' : undefined
   }, 0]];
 };
 export const renderIcon = (icon, allowInteractiveExpand, expanded, intl) => {

package/dist/esm/legacyExpand/nodeviews/index.js

@@ -44,11 +44,11 @@ var toDOM = function toDOM(node, __livePage, intl, titleReadOnly, contentEditabl
     value: node.attrs.title,
     placeholder: intl && intl.formatMessage(expandMessages.expandPlaceholderText) || expandMessages.expandPlaceholderText.defaultMessage,
     type: 'text',
-    readonly: titleReadOnly && fg('platform.editor.live-view.disable-editing-in-view-mode_fi1rx') ? 'true' : undefined
+    readonly: titleReadOnly ? 'true' : undefined
   }]]], ['div', {
     // prettier-ignore
     class: expandClassNames.content,
-    contenteditable: contentEditable && fg('platform.editor.live-view.disable-editing-in-view-mode_fi1rx') ? contentEditable ? 'true' : 'false' : undefined
+    contenteditable: contentEditable !== undefined ? contentEditable ? 'true' : 'false' : undefined
   }, 0]];
 };
 export var ExpandNodeView = /*#__PURE__*/function () {
@@ -390,7 +390,7 @@ export var ExpandNodeView = /*#__PURE__*/function () {
     });
     _defineProperty(this, "getContentEditable", function (node) {
       var contentEditable = _this.__livePage && fg('platform.editor.live-pages-expand-divergence') ? !node.attrs.__expanded : node.attrs.__expanded;
-      if (_this.api && _this.api.editorDisabled && fg('platform.editor.live-view.disable-editing-in-view-mode_fi1rx')) {
+      if (_this.api && _this.api.editorDisabled) {
         var _this$api$editorDisab;
         return !((_this$api$editorDisab = _this.api.editorDisabled.sharedState.currentState()) !== null && _this$api$editorDisab !== void 0 && _this$api$editorDisab.editorDisabled) && contentEditable;
       }
@@ -447,7 +447,7 @@ export var ExpandNodeView = /*#__PURE__*/function () {
         // eslint-disable-next-line @repo/internal/dom-events/no-unsafe-event-listeners
         this.icon.addEventListener('keydown', this.handleIconKeyDown);
       }
-      if ((_this$api6 = this.api) !== null && _this$api6 !== void 0 && _this$api6.editorDisabled && fg('platform.editor.live-view.disable-editing-in-view-mode_fi1rx')) {
+      if ((_this$api6 = this.api) !== null && _this$api6 !== void 0 && _this$api6.editorDisabled) {
         this.cleanUpEditorDisabledOnChange = this.api.editorDisabled.sharedState.onChange(function (sharedState) {
           var editorDisabled = sharedState.nextSharedState.editorDisabled;
           if (_this2.input) {

package/dist/esm/singlePlayerExpand/node-views/index.js

@@ -10,7 +10,6 @@ import { closestElement, isEmptyNode } from '@atlaskit/editor-common/utils';
 import { redo, undo } from '@atlaskit/editor-prosemirror/history';
 import { DOMSerializer } from '@atlaskit/editor-prosemirror/model';
 import { NodeSelection, Selection } from '@atlaskit/editor-prosemirror/state';
-import { fg } from '@atlaskit/platform-feature-flags';
 import { deleteExpand, setSelectionInsideExpand, toggleExpandExpanded, updateExpandTitle } from '../commands';
 import { buildExpandClassName, renderIcon, toDOM } from '../ui/NodeView';
 export var ExpandNodeView = /*#__PURE__*/function () {
@@ -346,7 +345,7 @@ export var ExpandNodeView = /*#__PURE__*/function () {
     });
     _defineProperty(this, "getContentEditable", function (node) {
       var contentEditable = !isExpandCollapsed(node);
-      if (_this.api && _this.api.editorDisabled && fg('platform.editor.live-view.disable-editing-in-view-mode_fi1rx')) {
+      if (_this.api && _this.api.editorDisabled) {
         var _this$api$editorDisab;
         return !((_this$api$editorDisab = _this.api.editorDisabled.sharedState.currentState()) !== null && _this$api$editorDisab !== void 0 && _this$api$editorDisab.editorDisabled) && contentEditable;
       }
@@ -390,7 +389,7 @@ export var ExpandNodeView = /*#__PURE__*/function () {
     // Prevent ProseMirror from getting a focus event (causes weird selection issues).
     this.titleContainer.addEventListener('focus', this.handleFocus);
     this.icon.addEventListener('keydown', this.handleIconKeyDown);
-    if ((_this$api6 = this.api) !== null && _this$api6 !== void 0 && _this$api6.editorDisabled && fg('platform.editor.live-view.disable-editing-in-view-mode_fi1rx')) {
+    if ((_this$api6 = this.api) !== null && _this$api6 !== void 0 && _this$api6.editorDisabled) {
       this.cleanUpEditorDisabledOnChange = this.api.editorDisabled.sharedState.onChange(function (sharedState) {
         var editorDisabled = sharedState.nextSharedState.editorDisabled;
         if (_this.input) {

package/dist/esm/singlePlayerExpand/ui/NodeView.js

@@ -3,7 +3,6 @@ import ReactDOM from 'react-dom';
 import { expandedState } from '@atlaskit/editor-common/expand';
 import { expandClassNames } from '@atlaskit/editor-common/styles';
 import { expandMessages } from '@atlaskit/editor-common/ui';
-import { getBooleanFF } from '@atlaskit/platform-feature-flags';
 import { ExpandButton } from '../ui/ExpandButton';
 export var buildExpandClassName = function buildExpandClassName(type, expanded) {
   return "".concat(expandClassNames.prefix, " ").concat(expandClassNames.type(type), " ").concat(expanded ? expandClassNames.expanded : '');
@@ -36,11 +35,11 @@ export var toDOM = function toDOM(node, __livePage, intl, titleReadOnly, content
     value: node.attrs.title,
     placeholder: intl && typeof intl.formatMessage === 'function' && intl.formatMessage(expandMessages.expandPlaceholderText) || expandMessages.expandPlaceholderText.defaultMessage,
     type: 'text',
-    readonly: getBooleanFF('platform.editor.live-view.disable-editing-in-view-mode_fi1rx') && titleReadOnly ? 'true' : undefined
+    readonly: titleReadOnly ? 'true' : undefined
   }]]], ['div', {
     // prettier-ignore
     class: expandClassNames.content,
-    contenteditable: getBooleanFF('platform.editor.live-view.disable-editing-in-view-mode_fi1rx') && contentEditable ? contentEditable ? 'true' : 'false' : undefined
+    contenteditable: contentEditable !== undefined ? contentEditable ? 'true' : 'false' : undefined
   }, 0]];
 };
 export var renderIcon = function renderIcon(icon, allowInteractiveExpand, expanded, intl) {

package/package.json

@@ -1,6 +1,6 @@
 {
 	"name": "@atlaskit/editor-plugin-expand",
-	"version": "2.7.6",
+	"version": "2.8.0",
 	"description": "Expand plugin for @atlaskit/editor-core",
 	"author": "Atlassian Pty Ltd",
 	"license": "Apache-2.0",
@@ -33,14 +33,14 @@
 	"dependencies": {
 		"@atlaskit/adf-schema": "^40.9.0",
 		"@atlaskit/button": "^20.2.0",
-		"@atlaskit/editor-common": "^91.0.0",
+		"@atlaskit/editor-common": "^91.1.0",
 		"@atlaskit/editor-plugin-analytics": "^1.8.0",
 		"@atlaskit/editor-plugin-decorations": "^1.3.0",
 		"@atlaskit/editor-plugin-editor-disabled": "^1.3.0",
 		"@atlaskit/editor-plugin-selection": "^1.4.0",
 		"@atlaskit/editor-plugin-selection-marker": "^1.5.0",
 		"@atlaskit/editor-prosemirror": "6.0.0",
-		"@atlaskit/editor-shared-styles": "^2.13.0",
+		"@atlaskit/editor-shared-styles": "^3.0.0",
 		"@atlaskit/editor-tables": "^2.8.0",
 		"@atlaskit/icon": "^22.18.0",
 		"@atlaskit/platform-feature-flags": "^0.3.0",
@@ -107,9 +107,6 @@
 		"platform.editor.single-player-expand": {
 			"type": "boolean"
 		},
-		"platform.editor.live-view.disable-editing-in-view-mode_fi1rx": {
-			"type": "boolean"
-		},
 		"platform_editor_nest_nested_expand_in_expand_jira": {
 			"type": "boolean"
 		},