@atlaskit/editor-plugin-emoji 17.2.2 → 17.2.4

package/CHANGELOG.md

@@ -1,5 +1,32 @@
 # @atlaskit/editor-plugin-emoji
 
+## 17.2.4
+
+### Patch Changes
+
+- Updated dependencies
+
+## 17.2.3
+
+### Patch Changes
+
+- [`3ae04490ac0f4`](https://bitbucket.org/atlassian/atlassian-frontend-monorepo/commits/3ae04490ac0f4) -
+  Render the disabled mention chip tooltip without React. Behind the
+  `platform_editor_use_vanilla_components` experiment, with no visual change.
+  - Disabled mention chips no longer mount a React tooltip, its portal, and the DOM-to-React event
+    bridge that fed it.
+  - Tooltips release their positioning instance when they close, rather than keeping one alive per
+    hovered chip.
+  - Tooltips remove their own element and attributes when destroyed, so mention and emoji chips no
+    longer leave orphaned popovers behind.
+  - Re-hovering a tooltip while it is closing keeps it open, matching `@atlaskit/tooltip`.
+    Previously the pending hide still landed and the tooltip disappeared under the pointer.
+  - Tooltips close when they hide, instead of waiting on a transition that nothing declares.
+    Required by the change above: releasing the positioning instance while the popover was still
+    open left it behind as an invisible hit target over the content.
+
+- Updated dependencies
+
 ## 17.2.2
 
 ### Patch Changes

package/dist/cjs/nodeviews/EmojiNodeView.js

@@ -22,6 +22,7 @@ var _vanillaTooltip = require("@atlaskit/editor-common/vanilla-tooltip");
 var _editorPluginConnectivity = require("@atlaskit/editor-plugin-connectivity");
 var _model = require("@atlaskit/editor-prosemirror/model");
 var _emojiIdToEmoji = require("@atlaskit/emoji/emoji-id-to-emoji");
+var _isExperimentEnabled = require("@atlaskit/platform-feature-experiments/is-experiment-enabled");
 var _fg = require("@atlaskit/platform-feature-flags/fg");
 var _expValEquals = require("@atlaskit/tmp-editor-statsig/exp-val-equals");
 var _expValEqualsNoExposure = require("@atlaskit/tmp-editor-statsig/exp-val-equals-no-exposure");
@@ -154,11 +155,16 @@ var EmojiNodeView = exports.EmojiNodeView = /*#__PURE__*/function () {
   return (0, _createClass2.default)(EmojiNodeView, [{
     key: "destroyTooltip",
     value: function destroyTooltip() {
-      var _this$destroyLazyTool, _this$tooltipInstance, _this$tooltipTarget, _this$tooltipTarget2;
+      var _this$destroyLazyTool, _this$tooltipInstance;
       (_this$destroyLazyTool = this.destroyLazyTooltipListeners) === null || _this$destroyLazyTool === void 0 || _this$destroyLazyTool.call(this);
       (_this$tooltipInstance = this.tooltipInstance) === null || _this$tooltipInstance === void 0 || _this$tooltipInstance.destroy();
-      (_this$tooltipTarget = this.tooltipTarget) === null || _this$tooltipTarget === void 0 || _this$tooltipTarget.removeAttribute('popovertarget');
-      (_this$tooltipTarget2 = this.tooltipTarget) === null || _this$tooltipTarget2 === void 0 || _this$tooltipTarget2.removeAttribute('aria-describedby');
+      // with platform_editor_use_vanilla_components the tooltipInstance?.destroy()
+      // will remove the popovertarget and aria-describedby attributes from the tooltipTarget
+      if (!(0, _isExperimentEnabled.isExperimentEnabled)('platform_editor_use_vanilla_components')) {
+        var _this$tooltipTarget, _this$tooltipTarget2;
+        (_this$tooltipTarget = this.tooltipTarget) === null || _this$tooltipTarget === void 0 || _this$tooltipTarget.removeAttribute('popovertarget');
+        (_this$tooltipTarget2 = this.tooltipTarget) === null || _this$tooltipTarget2 === void 0 || _this$tooltipTarget2.removeAttribute('aria-describedby');
+      }
       this.destroyLazyTooltipListeners = undefined;
       this.tooltipInstance = undefined;
       this.tooltipTarget = undefined;

package/dist/cjs/nodeviews/emojiNodeSpec.js

@@ -7,7 +7,7 @@ Object.defineProperty(exports, "__esModule", {
 exports.emojiNodeSpec = void 0;
 exports.emojiToDom = emojiToDom;
 var _defineProperty2 = _interopRequireDefault(require("@babel/runtime/helpers/defineProperty"));
-var _adfSchema = require("@atlaskit/adf-schema");
+var _emoji = require("@atlaskit/adf-schema/emoji");
 var _lazyNodeView = require("@atlaskit/editor-common/lazy-node-view");
 var _fg = require("@atlaskit/platform-feature-flags/fg");
 var _expValEquals = require("@atlaskit/tmp-editor-statsig/exp-val-equals");
@@ -22,7 +22,7 @@ var isSSR = Boolean(process.env.REACT_SSR);
  * @returns
  */
 var emojiNodeSpec = exports.emojiNodeSpec = function emojiNodeSpec() {
-  var emojiNode = (0, _fg.fg)('platform_editor_adf_with_localid') ? _adfSchema.emojiWithLocalId : _adfSchema.emoji;
+  var emojiNode = (0, _fg.fg)('platform_editor_adf_with_localid') ? _emoji.emojiWithLocalId : _emoji.emoji;
   if (isSSR) {
     return emojiNode;
   }

package/dist/es2019/nodeviews/EmojiNodeView.js

@@ -10,6 +10,7 @@ import { VanillaTooltip } from '@atlaskit/editor-common/vanilla-tooltip';
 import { isOfflineMode } from '@atlaskit/editor-plugin-connectivity';
 import { DOMSerializer } from '@atlaskit/editor-prosemirror/model';
 import { emojiIdToEmoji } from '@atlaskit/emoji/emoji-id-to-emoji';
+import { isExperimentEnabled } from '@atlaskit/platform-feature-experiments/is-experiment-enabled';
 import { fg } from '@atlaskit/platform-feature-flags/fg';
 import { expValEquals } from '@atlaskit/tmp-editor-statsig/exp-val-equals';
 import { expValEqualsNoExposure } from '@atlaskit/tmp-editor-statsig/exp-val-equals-no-exposure';
@@ -36,11 +37,16 @@ export function isSingleEmoji(fallbackText) {
 const EMOJI_TOOLTIP_CLASS = 'emoji-tooltip-editor';
 export class EmojiNodeView {
   destroyTooltip() {
-    var _this$destroyLazyTool, _this$tooltipInstance, _this$tooltipTarget, _this$tooltipTarget2;
+    var _this$destroyLazyTool, _this$tooltipInstance;
     (_this$destroyLazyTool = this.destroyLazyTooltipListeners) === null || _this$destroyLazyTool === void 0 ? void 0 : _this$destroyLazyTool.call(this);
     (_this$tooltipInstance = this.tooltipInstance) === null || _this$tooltipInstance === void 0 ? void 0 : _this$tooltipInstance.destroy();
-    (_this$tooltipTarget = this.tooltipTarget) === null || _this$tooltipTarget === void 0 ? void 0 : _this$tooltipTarget.removeAttribute('popovertarget');
-    (_this$tooltipTarget2 = this.tooltipTarget) === null || _this$tooltipTarget2 === void 0 ? void 0 : _this$tooltipTarget2.removeAttribute('aria-describedby');
+    // with platform_editor_use_vanilla_components the tooltipInstance?.destroy()
+    // will remove the popovertarget and aria-describedby attributes from the tooltipTarget
+    if (!isExperimentEnabled('platform_editor_use_vanilla_components')) {
+      var _this$tooltipTarget, _this$tooltipTarget2;
+      (_this$tooltipTarget = this.tooltipTarget) === null || _this$tooltipTarget === void 0 ? void 0 : _this$tooltipTarget.removeAttribute('popovertarget');
+      (_this$tooltipTarget2 = this.tooltipTarget) === null || _this$tooltipTarget2 === void 0 ? void 0 : _this$tooltipTarget2.removeAttribute('aria-describedby');
+    }
     this.destroyLazyTooltipListeners = undefined;
     this.tooltipInstance = undefined;
     this.tooltipTarget = undefined;

package/dist/es2019/nodeviews/emojiNodeSpec.js

@@ -1,4 +1,4 @@
-import { emoji, emojiWithLocalId } from '@atlaskit/adf-schema';
+import { emoji, emojiWithLocalId } from '@atlaskit/adf-schema/emoji';
 import { convertToInlineCss } from '@atlaskit/editor-common/lazy-node-view';
 import { fg } from '@atlaskit/platform-feature-flags/fg';
 import { expValEquals } from '@atlaskit/tmp-editor-statsig/exp-val-equals';

package/dist/esm/nodeviews/EmojiNodeView.js

@@ -14,6 +14,7 @@ import { VanillaTooltip } from '@atlaskit/editor-common/vanilla-tooltip';
 import { isOfflineMode } from '@atlaskit/editor-plugin-connectivity';
 import { DOMSerializer } from '@atlaskit/editor-prosemirror/model';
 import { emojiIdToEmoji } from '@atlaskit/emoji/emoji-id-to-emoji';
+import { isExperimentEnabled } from '@atlaskit/platform-feature-experiments/is-experiment-enabled';
 import { fg } from '@atlaskit/platform-feature-flags/fg';
 import { expValEquals } from '@atlaskit/tmp-editor-statsig/exp-val-equals';
 import { expValEqualsNoExposure } from '@atlaskit/tmp-editor-statsig/exp-val-equals-no-exposure';
@@ -146,11 +147,16 @@ export var EmojiNodeView = /*#__PURE__*/function () {
   return _createClass(EmojiNodeView, [{
     key: "destroyTooltip",
     value: function destroyTooltip() {
-      var _this$destroyLazyTool, _this$tooltipInstance, _this$tooltipTarget, _this$tooltipTarget2;
+      var _this$destroyLazyTool, _this$tooltipInstance;
       (_this$destroyLazyTool = this.destroyLazyTooltipListeners) === null || _this$destroyLazyTool === void 0 || _this$destroyLazyTool.call(this);
       (_this$tooltipInstance = this.tooltipInstance) === null || _this$tooltipInstance === void 0 || _this$tooltipInstance.destroy();
-      (_this$tooltipTarget = this.tooltipTarget) === null || _this$tooltipTarget === void 0 || _this$tooltipTarget.removeAttribute('popovertarget');
-      (_this$tooltipTarget2 = this.tooltipTarget) === null || _this$tooltipTarget2 === void 0 || _this$tooltipTarget2.removeAttribute('aria-describedby');
+      // with platform_editor_use_vanilla_components the tooltipInstance?.destroy()
+      // will remove the popovertarget and aria-describedby attributes from the tooltipTarget
+      if (!isExperimentEnabled('platform_editor_use_vanilla_components')) {
+        var _this$tooltipTarget, _this$tooltipTarget2;
+        (_this$tooltipTarget = this.tooltipTarget) === null || _this$tooltipTarget === void 0 || _this$tooltipTarget.removeAttribute('popovertarget');
+        (_this$tooltipTarget2 = this.tooltipTarget) === null || _this$tooltipTarget2 === void 0 || _this$tooltipTarget2.removeAttribute('aria-describedby');
+      }
       this.destroyLazyTooltipListeners = undefined;
       this.tooltipInstance = undefined;
       this.tooltipTarget = undefined;

package/dist/esm/nodeviews/emojiNodeSpec.js

@@ -1,7 +1,7 @@
 import _defineProperty from "@babel/runtime/helpers/defineProperty";
 function ownKeys(e, r) { var t = Object.keys(e); if (Object.getOwnPropertySymbols) { var o = Object.getOwnPropertySymbols(e); r && (o = o.filter(function (r) { return Object.getOwnPropertyDescriptor(e, r).enumerable; })), t.push.apply(t, o); } return t; }
 function _objectSpread(e) { for (var r = 1; r < arguments.length; r++) { var t = null != arguments[r] ? arguments[r] : {}; r % 2 ? ownKeys(Object(t), !0).forEach(function (r) { _defineProperty(e, r, t[r]); }) : Object.getOwnPropertyDescriptors ? Object.defineProperties(e, Object.getOwnPropertyDescriptors(t)) : ownKeys(Object(t)).forEach(function (r) { Object.defineProperty(e, r, Object.getOwnPropertyDescriptor(t, r)); }); } return e; }
-import { emoji, emojiWithLocalId } from '@atlaskit/adf-schema';
+import { emoji, emojiWithLocalId } from '@atlaskit/adf-schema/emoji';
 import { convertToInlineCss } from '@atlaskit/editor-common/lazy-node-view';
 import { fg } from '@atlaskit/platform-feature-flags/fg';
 import { expValEquals } from '@atlaskit/tmp-editor-statsig/exp-val-equals';

package/dist/types/pm-plugins/providers/EmojiNodeDataProvider.d.ts

@@ -1,4 +1,4 @@
-import type { EmojiDefinition } from '@atlaskit/adf-schema';
+import type { EmojiDefinition } from '@atlaskit/adf-schema/emoji';
 import type { JSONNode } from '@atlaskit/editor-json-transformer/types';
 import type { Node as PMNode } from '@atlaskit/editor-prosemirror/model';
 import type { EmojiResource, OptionalEmojiDescriptionWithVariations } from '@atlaskit/emoji';

package/package.json

@@ -1,6 +1,6 @@
 {
 	"name": "@atlaskit/editor-plugin-emoji",
-	"version": "17.2.2",
+	"version": "17.2.4",
 	"description": "Emoji plugin for @atlaskit/editor-core",
 	"publishConfig": {
 		"registry": "https://registry.npmjs.org/"
@@ -41,7 +41,7 @@
 		"@atlaskit/platform-feature-experiments": "^0.3.0",
 		"@atlaskit/platform-feature-flags": "^2.2.0",
 		"@atlaskit/prosemirror-input-rules": "^4.1.0",
-		"@atlaskit/tmp-editor-statsig": "^172.0.0",
+		"@atlaskit/tmp-editor-statsig": "^173.0.0",
 		"@atlaskit/tokens": "^16.11.0",
 		"@babel/runtime": "^7.0.0",
 		"@emotion/react": "^11.7.1",