@atlaskit/editor-plugin-decorations 8.0.28 → 8.0.29

package/CHANGELOG.md

@@ -1,5 +1,26 @@
 # @atlaskit/editor-plugin-decorations
 
+## 8.0.29
+
+### Patch Changes
+
+- [`a9fb116e4a8d8`](https://bitbucket.org/atlassian/atlassian-frontend-monorepo/commits/a9fb116e4a8d8) -
+  fix(editor): fix paragraph nodes not highlighting on hover over block menu delete action
+
+  Two root causes fixed:
+  1. CSS danger styles were gated behind
+     `expValNoExposure('platform_editor_block_menu', 'isEnabled', false)`, meaning they were
+     excluded when the new block menu was enabled. Removed the gate so danger styles are always
+     injected.
+
+  2. `hoverDecorationCommand` used `tr.selection` directly, which for paragraphs is a collapsed
+     `TextSelection` (cursor inside text). This caused `getSourceNodesFromSelectionRange` to return
+     an empty array, so no decorations were created. Fixed by passing `preservedSelection` (a
+     `NodeSelection` pointing at the whole paragraph node) from `blockControls` shared state through
+     to `hoverDecoration`.
+
+- Updated dependencies
+
 ## 8.0.28
 
 ### Patch Changes

package/dist/cjs/pm-plugins/commands.js

@@ -9,16 +9,20 @@ var _state = require("@atlaskit/editor-prosemirror/state");
 var _view = require("@atlaskit/editor-prosemirror/view");
 var _editorTables = require("@atlaskit/editor-tables");
 var _utils = require("@atlaskit/editor-tables/utils");
+var _platformFeatureFlags = require("@atlaskit/platform-feature-flags");
 var _experiments = require("@atlaskit/tmp-editor-statsig/experiments");
 var _main = require("./main");
 var hoverDecorationCommand = exports.hoverDecorationCommand = function hoverDecorationCommand(_ref) {
   var add = _ref.add,
     _ref$className = _ref.className,
-    className = _ref$className === void 0 ? 'danger selected' : _ref$className;
+    className = _ref$className === void 0 ? 'danger selected' : _ref$className,
+    providedSelection = _ref.selection;
   return function (_ref2) {
     var tr = _ref2.tr;
-    // Use the provided selection (e.g., preservedSelection) or fall back to tr.selection
-    var selection = tr.selection;
+    // [FEATURE FLAG: platform_editor_block_menu_jira_patch_1]
+    // Use the provided selection (e.g., preservedSelection) or fall back to tr.selection.
+    // To clean up: always use providedSelection || tr.selection, remove the feature flag check.
+    var selection = ((0, _platformFeatureFlags.fg)('platform_editor_block_menu_jira_patch_1') ? providedSelection : undefined) || tr.selection;
     var decorations = [];
     var handleTableSelection = function handleTableSelection() {
       var pos = arguments.length > 0 && arguments[0] !== undefined ? arguments[0] : selection.$from;

package/dist/es2019/pm-plugins/commands.js

@@ -3,16 +3,20 @@ import { NodeSelection, TextSelection } from '@atlaskit/editor-prosemirror/state
 import { Decoration, DecorationSet } from '@atlaskit/editor-prosemirror/view';
 import { CellSelection, TableMap } from '@atlaskit/editor-tables';
 import { findTableClosestToPos } from '@atlaskit/editor-tables/utils';
+import { fg } from '@atlaskit/platform-feature-flags';
 import { editorExperiment } from '@atlaskit/tmp-editor-statsig/experiments';
 import { ACTIONS, decorationStateKey } from './main';
 export const hoverDecorationCommand = ({
   add,
-  className = 'danger selected'
+  className = 'danger selected',
+  selection: providedSelection
 }) => ({
   tr
 }) => {
-  // Use the provided selection (e.g., preservedSelection) or fall back to tr.selection
-  const selection = tr.selection;
+  // [FEATURE FLAG: platform_editor_block_menu_jira_patch_1]
+  // Use the provided selection (e.g., preservedSelection) or fall back to tr.selection.
+  // To clean up: always use providedSelection || tr.selection, remove the feature flag check.
+  const selection = (fg('platform_editor_block_menu_jira_patch_1') ? providedSelection : undefined) || tr.selection;
   const decorations = [];
   const handleTableSelection = (pos = selection.$from) => {
     const table = findTableClosestToPos(pos);

package/dist/esm/pm-plugins/commands.js

@@ -3,16 +3,20 @@ import { NodeSelection, TextSelection } from '@atlaskit/editor-prosemirror/state
 import { Decoration, DecorationSet } from '@atlaskit/editor-prosemirror/view';
 import { CellSelection, TableMap } from '@atlaskit/editor-tables';
 import { findTableClosestToPos } from '@atlaskit/editor-tables/utils';
+import { fg } from '@atlaskit/platform-feature-flags';
 import { editorExperiment } from '@atlaskit/tmp-editor-statsig/experiments';
 import { ACTIONS, decorationStateKey } from './main';
 export var hoverDecorationCommand = function hoverDecorationCommand(_ref) {
   var add = _ref.add,
     _ref$className = _ref.className,
-    className = _ref$className === void 0 ? 'danger selected' : _ref$className;
+    className = _ref$className === void 0 ? 'danger selected' : _ref$className,
+    providedSelection = _ref.selection;
   return function (_ref2) {
     var tr = _ref2.tr;
-    // Use the provided selection (e.g., preservedSelection) or fall back to tr.selection
-    var selection = tr.selection;
+    // [FEATURE FLAG: platform_editor_block_menu_jira_patch_1]
+    // Use the provided selection (e.g., preservedSelection) or fall back to tr.selection.
+    // To clean up: always use providedSelection || tr.selection, remove the feature flag check.
+    var selection = (fg('platform_editor_block_menu_jira_patch_1') ? providedSelection : undefined) || tr.selection;
     var decorations = [];
     var handleTableSelection = function handleTableSelection() {
       var pos = arguments.length > 0 && arguments[0] !== undefined ? arguments[0] : selection.$from;

package/dist/types/decorationsPluginType.d.ts

@@ -1,10 +1,12 @@
 import type { NextEditorPlugin, EditorCommand } from '@atlaskit/editor-common/types';
+import type { Selection } from '@atlaskit/editor-prosemirror/state';
 import type { DecorationState, HoverDecorationHandler, removeDecoration } from './pm-plugins/main';
 export type HoverDecorationProps = {
     add: boolean;
     className?: string;
+    selection?: Selection;
 };
-export type HoverDecorationCommand = ({ add, className }: HoverDecorationProps) => EditorCommand;
+export type HoverDecorationCommand = ({ add, className, selection }: HoverDecorationProps) => EditorCommand;
 export type DecorationsPlugin = NextEditorPlugin<'decorations', {
     actions: {
         hoverDecoration: HoverDecorationHandler;

package/dist/types-ts4.5/decorationsPluginType.d.ts

@@ -1,10 +1,12 @@
 import type { NextEditorPlugin, EditorCommand } from '@atlaskit/editor-common/types';
+import type { Selection } from '@atlaskit/editor-prosemirror/state';
 import type { DecorationState, HoverDecorationHandler, removeDecoration } from './pm-plugins/main';
 export type HoverDecorationProps = {
     add: boolean;
     className?: string;
+    selection?: Selection;
 };
-export type HoverDecorationCommand = ({ add, className }: HoverDecorationProps) => EditorCommand;
+export type HoverDecorationCommand = ({ add, className, selection }: HoverDecorationProps) => EditorCommand;
 export type DecorationsPlugin = NextEditorPlugin<'decorations', {
     actions: {
         hoverDecoration: HoverDecorationHandler;

package/package.json

@@ -1,6 +1,6 @@
 {
 	"name": "@atlaskit/editor-plugin-decorations",
-	"version": "8.0.28",
+	"version": "8.0.29",
 	"description": "Decorations plugin for @atlaskit/editor-core",
 	"author": "Atlassian Pty Ltd",
 	"license": "Apache-2.0",
@@ -21,7 +21,8 @@
 	"dependencies": {
 		"@atlaskit/editor-prosemirror": "^7.3.0",
 		"@atlaskit/editor-tables": "^2.9.0",
-		"@atlaskit/tmp-editor-statsig": "^59.1.0",
+		"@atlaskit/platform-feature-flags": "^1.1.0",
+		"@atlaskit/tmp-editor-statsig": "^60.2.0",
 		"@babel/runtime": "^7.0.0"
 	},
 	"peerDependencies": {
@@ -65,5 +66,10 @@
 				"emotion"
 			]
 		}
+	},
+	"platform-feature-flags": {
+		"platform_editor_block_menu_jira_patch_1": {
+			"type": "boolean"
+		}
 	}
 }