@atlaskit/editor-plugin-collab-edit 16.0.1 → 16.0.2

package/CHANGELOG.md

@@ -1,5 +1,23 @@
 # @atlaskit/editor-plugin-collab-edit
 
+## 16.0.2
+
+### Patch Changes
+
+- [`b5b6cb8261481`](https://bitbucket.org/atlassian/atlassian-frontend-monorepo/commits/b5b6cb8261481) -
+  [CCI-18813] Fix the Post Stream Review modal anchoring far from the real edit (e.g. at an
+  unrelated panel) during backend AI streaming, when the only change to that node was a layout
+  `breakout` mark (e.g. a width change). The collab-edit segment producer recorded it as a
+  reviewable segment while the AI-plugin filter dropped it, leaving the modal anchored to a node
+  with no visible diff.
+
+  The layout-mark-aware slice comparison is now shared from `@atlaskit/editor-common` (new
+  `./collab-agent-review-slice-compare` entry point exporting `slicesEqualIgnoringLocalId`) and used
+  by both sides, so a `localId`-only or `breakout`-only difference is consistently treated as no
+  change. Real content and formatting edits are still recorded.
+
+- Updated dependencies
+
 ## 16.0.1
 
 ### Patch Changes

package/dist/cjs/pm-plugins/main/agent-review-segments.js

@@ -4,6 +4,7 @@ Object.defineProperty(exports, "__esModule", {
   value: true
 });
 exports.getAgentEditSegments = exports.REVIEW_MOMENT_AGENT_TYPES_CONFIG = void 0;
+var _collabAgentReviewSliceCompare = require("@atlaskit/editor-common/collab-agent-review-slice-compare");
 var _expVal = require("@atlaskit/platform-feature-experiments/exp-val");
 var _prosemirrorCollab = require("@atlaskit/prosemirror-collab");
 var _agentShimmerRanges = require("./agent-shimmer-ranges");
@@ -266,7 +267,11 @@ var getAgentEditSegments = exports.getAgentEditSegments = function getAgentEditS
         // Skip phantom artifacts: a same-size StepMap "touch" at an unrelated node
         // (e.g. a `localId` stamp on a panel during collab apply) expands to a
         // segment whose original and new content are identical — not a real change.
-        if (originalSlice.content.eq(newSlice.content)) {
+        // Layout-only marks (`breakout`) and `localId`s are ignored so a
+        // breakout-width-only change is not recorded as a coarse segment: the FE
+        // Review filter drops it anyway, so recording it here would anchor the modal
+        // to a node with no visible diff.
+        if ((0, _collabAgentReviewSliceCompare.slicesEqualIgnoringLocalId)(originalSlice, newSlice)) {
           return;
         }
         var kind = originalEmpty ? 'add' : newEmpty ? 'remove' : 'update';

package/dist/es2019/pm-plugins/main/agent-review-segments.js

@@ -1,3 +1,4 @@
+import { slicesEqualIgnoringLocalId } from '@atlaskit/editor-common/collab-agent-review-slice-compare';
 import { expVal } from '@atlaskit/platform-feature-experiments/exp-val';
 import { getCollabState } from '@atlaskit/prosemirror-collab';
 import { isPositionNeutralStep } from './agent-shimmer-ranges';
@@ -247,7 +248,11 @@ export const getAgentEditSegments = (json, steps, tr, view) => {
         // Skip phantom artifacts: a same-size StepMap "touch" at an unrelated node
         // (e.g. a `localId` stamp on a panel during collab apply) expands to a
         // segment whose original and new content are identical — not a real change.
-        if (originalSlice.content.eq(newSlice.content)) {
+        // Layout-only marks (`breakout`) and `localId`s are ignored so a
+        // breakout-width-only change is not recorded as a coarse segment: the FE
+        // Review filter drops it anyway, so recording it here would anchor the modal
+        // to a node with no visible diff.
+        if (slicesEqualIgnoringLocalId(originalSlice, newSlice)) {
           return;
         }
         const kind = originalEmpty ? 'add' : newEmpty ? 'remove' : 'update';

package/dist/esm/pm-plugins/main/agent-review-segments.js

@@ -1,3 +1,4 @@
+import { slicesEqualIgnoringLocalId } from '@atlaskit/editor-common/collab-agent-review-slice-compare';
 import { expVal } from '@atlaskit/platform-feature-experiments/exp-val';
 import { getCollabState } from '@atlaskit/prosemirror-collab';
 import { isPositionNeutralStep } from './agent-shimmer-ranges';
@@ -261,7 +262,11 @@ export var getAgentEditSegments = function getAgentEditSegments(json, steps, tr,
         // Skip phantom artifacts: a same-size StepMap "touch" at an unrelated node
         // (e.g. a `localId` stamp on a panel during collab apply) expands to a
         // segment whose original and new content are identical — not a real change.
-        if (originalSlice.content.eq(newSlice.content)) {
+        // Layout-only marks (`breakout`) and `localId`s are ignored so a
+        // breakout-width-only change is not recorded as a coarse segment: the FE
+        // Review filter drops it anyway, so recording it here would anchor the modal
+        // to a node with no visible diff.
+        if (slicesEqualIgnoringLocalId(originalSlice, newSlice)) {
           return;
         }
         var kind = originalEmpty ? 'add' : newEmpty ? 'remove' : 'update';

package/package.json

@@ -1,6 +1,6 @@
 {
 	"name": "@atlaskit/editor-plugin-collab-edit",
-	"version": "16.0.1",
+	"version": "16.0.2",
 	"description": "Collab Edit plugin for @atlaskit/editor-core",
 	"author": "Atlassian Pty Ltd",
 	"license": "Apache-2.0",
@@ -32,13 +32,13 @@
 		"@atlaskit/platform-feature-experiments": "^0.3.0",
 		"@atlaskit/platform-feature-flags": "^2.1.0",
 		"@atlaskit/prosemirror-collab": "^1.0.0",
-		"@atlaskit/tmp-editor-statsig": "^147.1.0",
+		"@atlaskit/tmp-editor-statsig": "^148.0.0",
 		"@atlaskit/tokens": "^16.7.0",
 		"@babel/runtime": "^7.0.0",
 		"memoize-one": "^6.0.0"
 	},
 	"peerDependencies": {
-		"@atlaskit/editor-common": "^119.4.0",
+		"@atlaskit/editor-common": "^119.5.0",
 		"react": "^18.2.0 || ^19.2.0",
 		"react-dom": "^18.2.0 || ^19.2.0"
 	},