@atlaskit/editor-plugin-code-block-advanced 23.0.0 → 24.0.0

package/CHANGELOG.md

@@ -1,5 +1,21 @@
 # @atlaskit/editor-plugin-code-block-advanced
 
+## 24.0.0
+
+### Patch Changes
+
+- [`e7cc9c65c49ee`](https://bitbucket.org/atlassian/atlassian-frontend-monorepo/commits/e7cc9c65c49ee) -
+  Updated codeblock cleanup hook to also call destroy method of the codemirror instance. This
+  reduces the event listener and dom element count which increases each time a code block is added
+  and removed
+- Updated dependencies
+
+## 23.0.1
+
+### Patch Changes
+
+- Updated dependencies
+
 ## 23.0.0
 
 ### Patch Changes

package/dist/cjs/nodeviews/codeBlockAdvanced.js

@@ -19,6 +19,7 @@ var _messages = require("@atlaskit/editor-common/messages");
 var _whitespace = require("@atlaskit/editor-common/whitespace");
 var _state2 = require("@atlaskit/editor-prosemirror/state");
 var _view2 = require("@atlaskit/editor-prosemirror/view");
+var _isExperimentEnabled = require("@atlaskit/platform-feature-experiments/is-experiment-enabled");
 var _fg = require("@atlaskit/platform-feature-flags/fg");
 var _expValEquals = require("@atlaskit/tmp-editor-statsig/exp-val-equals");
 var _expValEqualsNoExposure = require("@atlaskit/tmp-editor-statsig/exp-val-equals-no-exposure");
@@ -210,6 +211,9 @@ var CodeBlockAdvancedNodeView = /*#__PURE__*/function () {
       (_this$cleanupBorderAr2 = this.cleanupBorderAreaClick) === null || _this$cleanupBorderAr2 === void 0 || _this$cleanupBorderAr2.call(this);
       (_this$cleanupDisabled = this.cleanupDisabledState) === null || _this$cleanupDisabled === void 0 || _this$cleanupDisabled.call(this);
       (_this$unsubscribeCont = this.unsubscribeContentFormat) === null || _this$unsubscribeCont === void 0 || _this$unsubscribeCont.call(this);
+      if ((0, _isExperimentEnabled.isExperimentEnabled)('platform_editor_reduce_memory_leaks')) {
+        this.cm.destroy();
+      }
     }
   }, {
     key: "forwardUpdate",

package/dist/es2019/nodeviews/codeBlockAdvanced.js

@@ -9,6 +9,7 @@ import { blockTypeMessages } from '@atlaskit/editor-common/messages';
 import { ZERO_WIDTH_SPACE } from '@atlaskit/editor-common/whitespace';
 import { NodeSelection } from '@atlaskit/editor-prosemirror/state';
 import { DecorationSet } from '@atlaskit/editor-prosemirror/view';
+import { isExperimentEnabled } from '@atlaskit/platform-feature-experiments/is-experiment-enabled';
 import { fg } from '@atlaskit/platform-feature-flags/fg';
 import { expValEquals } from '@atlaskit/tmp-editor-statsig/exp-val-equals';
 import { expValEqualsNoExposure } from '@atlaskit/tmp-editor-statsig/exp-val-equals-no-exposure';
@@ -183,6 +184,9 @@ class CodeBlockAdvancedNodeView {
     (_this$cleanupBorderAr2 = this.cleanupBorderAreaClick) === null || _this$cleanupBorderAr2 === void 0 ? void 0 : _this$cleanupBorderAr2.call(this);
     (_this$cleanupDisabled = this.cleanupDisabledState) === null || _this$cleanupDisabled === void 0 ? void 0 : _this$cleanupDisabled.call(this);
     (_this$unsubscribeCont = this.unsubscribeContentFormat) === null || _this$unsubscribeCont === void 0 ? void 0 : _this$unsubscribeCont.call(this);
+    if (isExperimentEnabled('platform_editor_reduce_memory_leaks')) {
+      this.cm.destroy();
+    }
   }
   forwardUpdate(update) {
     var _this$getPos, _this$getPos2;

package/dist/esm/nodeviews/codeBlockAdvanced.js

@@ -14,6 +14,7 @@ import { blockTypeMessages } from '@atlaskit/editor-common/messages';
 import { ZERO_WIDTH_SPACE } from '@atlaskit/editor-common/whitespace';
 import { NodeSelection } from '@atlaskit/editor-prosemirror/state';
 import { DecorationSet } from '@atlaskit/editor-prosemirror/view';
+import { isExperimentEnabled } from '@atlaskit/platform-feature-experiments/is-experiment-enabled';
 import { fg } from '@atlaskit/platform-feature-flags/fg';
 import { expValEquals } from '@atlaskit/tmp-editor-statsig/exp-val-equals';
 import { expValEqualsNoExposure } from '@atlaskit/tmp-editor-statsig/exp-val-equals-no-exposure';
@@ -203,6 +204,9 @@ var CodeBlockAdvancedNodeView = /*#__PURE__*/function () {
       (_this$cleanupBorderAr2 = this.cleanupBorderAreaClick) === null || _this$cleanupBorderAr2 === void 0 || _this$cleanupBorderAr2.call(this);
       (_this$cleanupDisabled = this.cleanupDisabledState) === null || _this$cleanupDisabled === void 0 || _this$cleanupDisabled.call(this);
       (_this$unsubscribeCont = this.unsubscribeContentFormat) === null || _this$unsubscribeCont === void 0 || _this$unsubscribeCont.call(this);
+      if (isExperimentEnabled('platform_editor_reduce_memory_leaks')) {
+        this.cm.destroy();
+      }
     }
   }, {
     key: "forwardUpdate",

package/package.json

@@ -1,6 +1,6 @@
 {
 	"name": "@atlaskit/editor-plugin-code-block-advanced",
-	"version": "23.0.0",
+	"version": "24.0.0",
 	"description": "CodeBlockAdvanced plugin for @atlaskit/editor-core",
 	"author": "Atlassian Pty Ltd",
 	"license": "Apache-2.0",
@@ -22,16 +22,17 @@
 	"dependencies": {
 		"@atlaskit/adf-schema": "^57.6.0",
 		"@atlaskit/code": "^20.0.0",
-		"@atlaskit/editor-plugin-analytics": "^23.0.0",
-		"@atlaskit/editor-plugin-code-block": "^25.0.0",
-		"@atlaskit/editor-plugin-editor-disabled": "^23.0.0",
-		"@atlaskit/editor-plugin-find-replace": "^23.0.0",
-		"@atlaskit/editor-plugin-selection": "^23.0.0",
-		"@atlaskit/editor-plugin-selection-marker": "^23.0.0",
+		"@atlaskit/editor-plugin-analytics": "^24.0.0",
+		"@atlaskit/editor-plugin-code-block": "^26.0.0",
+		"@atlaskit/editor-plugin-editor-disabled": "^24.0.0",
+		"@atlaskit/editor-plugin-find-replace": "^24.0.0",
+		"@atlaskit/editor-plugin-selection": "^24.0.0",
+		"@atlaskit/editor-plugin-selection-marker": "^24.0.0",
 		"@atlaskit/editor-prosemirror": "^9.0.0",
+		"@atlaskit/platform-feature-experiments": "^0.3.0",
 		"@atlaskit/platform-feature-flags": "^2.2.0",
 		"@atlaskit/prosemirror-history": "^1.3.0",
-		"@atlaskit/tmp-editor-statsig": "^219.0.0",
+		"@atlaskit/tmp-editor-statsig": "^220.0.0",
 		"@atlaskit/tokens": "^20.1.0",
 		"@babel/runtime": "^7.0.0",
 		"@codemirror/autocomplete": "6.18.4",
@@ -50,7 +51,7 @@
 		"codemirror-lang-mermaid": "0.4.0"
 	},
 	"peerDependencies": {
-		"@atlaskit/editor-common": "^127.0.0",
+		"@atlaskit/editor-common": "^128.0.0",
 		"react": "^18.2.0 || ^19.2.0",
 		"react-intl": "^5.25.1 || ^6.0.0 || ^7.0.0"
 	},

package/src/nodeviews/codeBlockAdvanced.ts

@@ -30,6 +30,7 @@ import type {
 	NodeView,
 } from '@atlaskit/editor-prosemirror/view';
 import { DecorationSet } from '@atlaskit/editor-prosemirror/view';
+import { isExperimentEnabled } from '@atlaskit/platform-feature-experiments/is-experiment-enabled';
 import { fg } from '@atlaskit/platform-feature-flags/fg';
 import { expValEquals } from '@atlaskit/tmp-editor-statsig/exp-val-equals';
 import { expValEqualsNoExposure } from '@atlaskit/tmp-editor-statsig/exp-val-equals-no-exposure';
@@ -239,6 +240,9 @@ class CodeBlockAdvancedNodeView implements NodeView {
 		this.cleanupBorderAreaClick?.();
 		this.cleanupDisabledState?.();
 		this.unsubscribeContentFormat?.();
+		if (isExperimentEnabled('platform_editor_reduce_memory_leaks')) {
+			this.cm.destroy();
+		}
 	}
 
 	forwardUpdate(update: ViewUpdate): void {