@atlaskit/editor-plugin-code-block-advanced 2.4.0 → 3.0.0

package/CHANGELOG.md

@@ -1,5 +1,45 @@
 # @atlaskit/editor-plugin-code-block-advanced
 
+## 3.0.0
+
+### Major Changes
+
+- [#181024](https://bitbucket.org/atlassian/atlassian-frontend-monorepo/pull-requests/181024)
+  [`8e80c487ca307`](https://bitbucket.org/atlassian/atlassian-frontend-monorepo/commits/8e80c487ca307) - ##
+  Make `@atlaskit/editor-common` a peer dependency
+
+  **WHAT:** `@atlaskit/editor-common` has been moved from `dependencies` to `peerDependencies` in
+  all editor plugin packages.
+
+  **WHY:** This change ensures that only a single version of `@atlaskit/editor-common` is used in
+  consuming applications, preventing issues caused by multiple versions of singleton libraries (such
+  as context mismatches or duplicated state). This is especially important for packages that rely on
+  shared context or singletons.
+
+  **HOW TO ADJUST:**
+
+  - Consumers must now explicitly install `@atlaskit/editor-common` in their own project if they use
+    any of these editor plugins.
+  - Ensure the version you install matches the version required by the plugins.
+  - You can use the
+    [`check-peer-dependencies`](https://www.npmjs.com/package/check-peer-dependencies) package to
+    verify that all required peer dependencies are installed and compatible.
+  - Example install command:
+    ```
+    npm install @atlaskit/editor-common
+    ```
+    or
+    ```
+    yarn add @atlaskit/editor-common
+    ```
+
+  **Note:** This is a breaking change. If `@atlaskit/editor-common` is not installed at the
+  application level, you may see errors or unexpected behavior.
+
+### Patch Changes
+
+- Updated dependencies
+
 ## 2.4.0
 
 ### Minor Changes

package/afm-cc/tsconfig.json

@@ -17,9 +17,6 @@
         "../src/**/examples.*"
     ],
     "references": [
-        {
-            "path": "../../editor-common/afm-cc/tsconfig.json"
-        },
         {
             "path": "../../editor-plugin-code-block/afm-cc/tsconfig.json"
         },
@@ -43,6 +40,9 @@
         },
         {
             "path": "../../../design-system/tokens/afm-cc/tsconfig.json"
+        },
+        {
+            "path": "../../editor-common/afm-cc/tsconfig.json"
         }
     ]
 }

package/afm-jira/tsconfig.json

@@ -17,9 +17,6 @@
 		"../src/**/examples.*"
 	],
 	"references": [
-		{
-			"path": "../../editor-common/afm-jira/tsconfig.json"
-		},
 		{
 			"path": "../../editor-plugin-code-block/afm-jira/tsconfig.json"
 		},
@@ -43,6 +40,9 @@
 		},
 		{
 			"path": "../../../design-system/tokens/afm-jira/tsconfig.json"
+		},
+		{
+			"path": "../../editor-common/afm-jira/tsconfig.json"
 		}
 	]
 }

package/afm-post-office/tsconfig.json

@@ -17,9 +17,6 @@
 		"../src/**/examples.*"
 	],
 	"references": [
-		{
-			"path": "../../editor-common/afm-post-office/tsconfig.json"
-		},
 		{
 			"path": "../../editor-plugin-code-block/afm-post-office/tsconfig.json"
 		},
@@ -43,6 +40,9 @@
 		},
 		{
 			"path": "../../../design-system/tokens/afm-post-office/tsconfig.json"
+		},
+		{
+			"path": "../../editor-common/afm-post-office/tsconfig.json"
 		}
 	]
 }

package/dist/types/nodeviews/codeBlockAdvanced.d.ts

@@ -1,7 +1,7 @@
 import { type Extension } from '@codemirror/state';
-import { ViewUpdate } from '@codemirror/view';
+import { type ViewUpdate } from '@codemirror/view';
 import type { getPosHandler, getPosHandlerNode, ExtractInjectionAPI } from '@atlaskit/editor-common/types';
-import { Node as PMNode } from '@atlaskit/editor-prosemirror/model';
+import { type Node as PMNode } from '@atlaskit/editor-prosemirror/model';
 import type { Decoration, DecorationSource, EditorView, NodeView } from '@atlaskit/editor-prosemirror/view';
 import type { CodeBlockAdvancedPlugin } from '../codeBlockAdvancedPluginType';
 interface ConfigProps {

package/dist/types/nodeviews/codemirrorSync/syncCMWithPM.d.ts

@@ -1,5 +1,5 @@
-import { ViewUpdate } from '@codemirror/view';
-import { EditorView } from '@atlaskit/editor-prosemirror/view';
+import { type ViewUpdate } from '@codemirror/view';
+import { type EditorView } from '@atlaskit/editor-prosemirror/view';
 interface Props {
     view: EditorView;
     update: ViewUpdate;

package/dist/types/nodeviews/extensions/keymap/backspace.d.ts

@@ -1,7 +1,7 @@
-import { EditorView as CodeMirror } from '@codemirror/view';
+import { type EditorView as CodeMirror } from '@codemirror/view';
 import type { getPosHandlerNode } from '@atlaskit/editor-common/types';
 import type { Node as PMNode } from '@atlaskit/editor-prosemirror/model';
-import { EditorView } from '@atlaskit/editor-prosemirror/view';
+import { type EditorView } from '@atlaskit/editor-prosemirror/view';
 interface BackspaceProps {
     view: EditorView;
     cm: CodeMirror;

package/dist/types/nodeviews/extensions/keymap/index.d.ts

@@ -1,8 +1,8 @@
 import { type Extension } from '@codemirror/state';
-import { RelativeSelectionPos } from '@atlaskit/editor-common/selection';
+import { type RelativeSelectionPos } from '@atlaskit/editor-common/selection';
 import type { getPosHandlerNode } from '@atlaskit/editor-common/types';
 import type { Node as PMNode } from '@atlaskit/editor-prosemirror/model';
-import { EditorView } from '@atlaskit/editor-prosemirror/view';
+import { type EditorView } from '@atlaskit/editor-prosemirror/view';
 interface KeymapProps {
     view: EditorView;
     getNode: () => PMNode;

package/dist/types/nodeviews/extensions/keymap/maybeEscape.d.ts

@@ -1,8 +1,8 @@
-import { EditorView as CodeMirror } from '@codemirror/view';
+import { type EditorView as CodeMirror } from '@codemirror/view';
 import { RelativeSelectionPos } from '@atlaskit/editor-common/selection';
 import type { getPosHandlerNode } from '@atlaskit/editor-common/types';
 import type { Node as PMNode } from '@atlaskit/editor-prosemirror/model';
-import { EditorView } from '@atlaskit/editor-prosemirror/view';
+import { type EditorView } from '@atlaskit/editor-prosemirror/view';
 interface MaybeEscapeProps {
     unit: 'line' | 'char';
     dir: -1 | 1;

package/dist/types/nodeviews/extensions/prosemirrorDecorations.d.ts

@@ -1,5 +1,5 @@
-import { Facet } from '@codemirror/state';
-import { ViewPlugin, EditorView as CodeMirror, type DecorationSet, ViewUpdate } from '@codemirror/view';
+import { type Facet } from '@codemirror/state';
+import { ViewPlugin, type EditorView as CodeMirror, type DecorationSet, type ViewUpdate } from '@codemirror/view';
 import type { EditorView, DecorationSource } from '@atlaskit/editor-prosemirror/view';
 /**
  * Creates CodeMirror versions of the decorations provided by ProseMirror.

package/dist/types-ts4.5/nodeviews/codeBlockAdvanced.d.ts

@@ -1,7 +1,7 @@
 import { type Extension } from '@codemirror/state';
-import { ViewUpdate } from '@codemirror/view';
+import { type ViewUpdate } from '@codemirror/view';
 import type { getPosHandler, getPosHandlerNode, ExtractInjectionAPI } from '@atlaskit/editor-common/types';
-import { Node as PMNode } from '@atlaskit/editor-prosemirror/model';
+import { type Node as PMNode } from '@atlaskit/editor-prosemirror/model';
 import type { Decoration, DecorationSource, EditorView, NodeView } from '@atlaskit/editor-prosemirror/view';
 import type { CodeBlockAdvancedPlugin } from '../codeBlockAdvancedPluginType';
 interface ConfigProps {

package/dist/types-ts4.5/nodeviews/codemirrorSync/syncCMWithPM.d.ts

@@ -1,5 +1,5 @@
-import { ViewUpdate } from '@codemirror/view';
-import { EditorView } from '@atlaskit/editor-prosemirror/view';
+import { type ViewUpdate } from '@codemirror/view';
+import { type EditorView } from '@atlaskit/editor-prosemirror/view';
 interface Props {
     view: EditorView;
     update: ViewUpdate;

package/dist/types-ts4.5/nodeviews/extensions/keymap/backspace.d.ts

@@ -1,7 +1,7 @@
-import { EditorView as CodeMirror } from '@codemirror/view';
+import { type EditorView as CodeMirror } from '@codemirror/view';
 import type { getPosHandlerNode } from '@atlaskit/editor-common/types';
 import type { Node as PMNode } from '@atlaskit/editor-prosemirror/model';
-import { EditorView } from '@atlaskit/editor-prosemirror/view';
+import { type EditorView } from '@atlaskit/editor-prosemirror/view';
 interface BackspaceProps {
     view: EditorView;
     cm: CodeMirror;

package/dist/types-ts4.5/nodeviews/extensions/keymap/index.d.ts

@@ -1,8 +1,8 @@
 import { type Extension } from '@codemirror/state';
-import { RelativeSelectionPos } from '@atlaskit/editor-common/selection';
+import { type RelativeSelectionPos } from '@atlaskit/editor-common/selection';
 import type { getPosHandlerNode } from '@atlaskit/editor-common/types';
 import type { Node as PMNode } from '@atlaskit/editor-prosemirror/model';
-import { EditorView } from '@atlaskit/editor-prosemirror/view';
+import { type EditorView } from '@atlaskit/editor-prosemirror/view';
 interface KeymapProps {
     view: EditorView;
     getNode: () => PMNode;

package/dist/types-ts4.5/nodeviews/extensions/keymap/maybeEscape.d.ts

@@ -1,8 +1,8 @@
-import { EditorView as CodeMirror } from '@codemirror/view';
+import { type EditorView as CodeMirror } from '@codemirror/view';
 import { RelativeSelectionPos } from '@atlaskit/editor-common/selection';
 import type { getPosHandlerNode } from '@atlaskit/editor-common/types';
 import type { Node as PMNode } from '@atlaskit/editor-prosemirror/model';
-import { EditorView } from '@atlaskit/editor-prosemirror/view';
+import { type EditorView } from '@atlaskit/editor-prosemirror/view';
 interface MaybeEscapeProps {
     unit: 'line' | 'char';
     dir: -1 | 1;

package/dist/types-ts4.5/nodeviews/extensions/prosemirrorDecorations.d.ts

@@ -1,5 +1,5 @@
-import { Facet } from '@codemirror/state';
-import { ViewPlugin, EditorView as CodeMirror, type DecorationSet, ViewUpdate } from '@codemirror/view';
+import { type Facet } from '@codemirror/state';
+import { ViewPlugin, type EditorView as CodeMirror, type DecorationSet, type ViewUpdate } from '@codemirror/view';
 import type { EditorView, DecorationSource } from '@atlaskit/editor-prosemirror/view';
 /**
  * Creates CodeMirror versions of the decorations provided by ProseMirror.

package/package.json

@@ -1,6 +1,6 @@
 {
 	"name": "@atlaskit/editor-plugin-code-block-advanced",
-	"version": "2.4.0",
+	"version": "3.0.0",
 	"description": "CodeBlockAdvanced plugin for @atlaskit/editor-core",
 	"author": "Atlassian Pty Ltd",
 	"license": "Apache-2.0",
@@ -10,8 +10,7 @@
 	"atlassian": {
 		"team": "Editor: Lego",
 		"releaseModel": "continuous",
-		"singleton": true,
-		"runReact18": true
+		"singleton": true
 	},
 	"repository": "https://bitbucket.org/atlassian/atlassian-frontend-mirror",
 	"main": "dist/cjs/index.js",
@@ -33,15 +32,14 @@
 	},
 	"dependencies": {
 		"@atlaskit/adf-schema": "^47.6.0",
-		"@atlaskit/editor-common": "^107.2.0",
-		"@atlaskit/editor-plugin-code-block": "^4.4.0",
-		"@atlaskit/editor-plugin-editor-disabled": "^2.1.0",
-		"@atlaskit/editor-plugin-find-replace": "^2.7.0",
-		"@atlaskit/editor-plugin-selection": "^2.2.0",
-		"@atlaskit/editor-plugin-selection-marker": "^2.5.0",
+		"@atlaskit/editor-plugin-code-block": "^5.0.0",
+		"@atlaskit/editor-plugin-editor-disabled": "^3.0.0",
+		"@atlaskit/editor-plugin-find-replace": "^3.0.0",
+		"@atlaskit/editor-plugin-selection": "^3.0.0",
+		"@atlaskit/editor-plugin-selection-marker": "^3.0.0",
 		"@atlaskit/editor-prosemirror": "7.0.0",
 		"@atlaskit/platform-feature-flags": "^1.1.0",
-		"@atlaskit/tmp-editor-statsig": "^8.1.0",
+		"@atlaskit/tmp-editor-statsig": "^8.7.0",
 		"@atlaskit/tokens": "^5.4.0",
 		"@babel/runtime": "^7.0.0",
 		"@codemirror/autocomplete": "6.18.4",
@@ -56,6 +54,7 @@
 		"codemirror-lang-elixir": "4.0.0"
 	},
 	"peerDependencies": {
+		"@atlaskit/editor-common": "^107.6.0",
 		"react": "^18.2.0"
 	},
 	"devDependencies": {

package/src/nodeviews/codeBlockAdvanced.ts

@@ -6,12 +6,12 @@ import {
 	EditorSelection,
 	Facet,
 	EditorState as CodeMirrorState,
-	StateEffect,
+	type StateEffect,
 } from '@codemirror/state';
-import { EditorView as CodeMirror, lineNumbers, ViewUpdate, gutters } from '@codemirror/view';
+import { EditorView as CodeMirror, lineNumbers, type ViewUpdate, gutters } from '@codemirror/view';
 
 import { isCodeBlockWordWrapEnabled } from '@atlaskit/editor-common/code-block';
-import { RelativeSelectionPos } from '@atlaskit/editor-common/selection';
+import { type RelativeSelectionPos } from '@atlaskit/editor-common/selection';
 import type {
 	getPosHandler,
 	getPosHandlerNode,
@@ -19,7 +19,7 @@ import type {
 } from '@atlaskit/editor-common/types';
 import { ZERO_WIDTH_SPACE } from '@atlaskit/editor-common/whitespace';
 import { type EditorSelectionAPI } from '@atlaskit/editor-plugin-selection';
-import { Node as PMNode } from '@atlaskit/editor-prosemirror/model';
+import { type Node as PMNode } from '@atlaskit/editor-prosemirror/model';
 import { NodeSelection } from '@atlaskit/editor-prosemirror/state';
 import type {
 	Decoration,

package/src/nodeviews/codemirrorSync/syncCMWithPM.ts

@@ -1,7 +1,7 @@
-import { ViewUpdate } from '@codemirror/view';
+import { type ViewUpdate } from '@codemirror/view';
 
 import { TextSelection } from '@atlaskit/editor-prosemirror/state';
-import { EditorView } from '@atlaskit/editor-prosemirror/view';
+import { type EditorView } from '@atlaskit/editor-prosemirror/view';
 
 interface Props {
 	view: EditorView;

package/src/nodeviews/extensions/keymap/backspace.ts

@@ -1,9 +1,9 @@
-import { EditorView as CodeMirror } from '@codemirror/view';
+import { type EditorView as CodeMirror } from '@codemirror/view';
 
 import type { getPosHandlerNode } from '@atlaskit/editor-common/types';
 import type { Node as PMNode } from '@atlaskit/editor-prosemirror/model';
 import { TextSelection } from '@atlaskit/editor-prosemirror/state';
-import { EditorView } from '@atlaskit/editor-prosemirror/view';
+import { type EditorView } from '@atlaskit/editor-prosemirror/view';
 
 interface BackspaceProps {
 	view: EditorView;

package/src/nodeviews/extensions/keymap/index.ts

@@ -3,12 +3,12 @@ import { type Extension } from '@codemirror/state';
 import { type KeyBinding, keymap as cmKeymap } from '@codemirror/view';
 
 import { browser } from '@atlaskit/editor-common/browser';
-import { RelativeSelectionPos } from '@atlaskit/editor-common/selection';
+import { type RelativeSelectionPos } from '@atlaskit/editor-common/selection';
 import type { getPosHandlerNode } from '@atlaskit/editor-common/types';
 import { exitCode, selectAll } from '@atlaskit/editor-prosemirror/commands';
 import { undo, redo } from '@atlaskit/editor-prosemirror/history';
 import type { Node as PMNode } from '@atlaskit/editor-prosemirror/model';
-import { EditorView } from '@atlaskit/editor-prosemirror/view';
+import { type EditorView } from '@atlaskit/editor-prosemirror/view';
 import { fg } from '@atlaskit/platform-feature-flags';
 import { expValEquals } from '@atlaskit/tmp-editor-statsig/exp-val-equals';
 

package/src/nodeviews/extensions/keymap/maybeEscape.ts

@@ -1,10 +1,10 @@
-import { EditorView as CodeMirror } from '@codemirror/view';
+import { type EditorView as CodeMirror } from '@codemirror/view';
 
 import { RelativeSelectionPos } from '@atlaskit/editor-common/selection';
 import type { getPosHandlerNode } from '@atlaskit/editor-common/types';
 import type { Node as PMNode } from '@atlaskit/editor-prosemirror/model';
 import { Selection } from '@atlaskit/editor-prosemirror/state';
-import { EditorView } from '@atlaskit/editor-prosemirror/view';
+import { type EditorView } from '@atlaskit/editor-prosemirror/view';
 
 interface MaybeEscapeProps {
 	unit: 'line' | 'char';

package/src/nodeviews/extensions/prosemirrorDecorations.ts

@@ -1,11 +1,11 @@
-import { Facet } from '@codemirror/state';
+import { type Facet } from '@codemirror/state';
 import {
 	ViewPlugin,
 	WidgetType,
 	Decoration as CodeMirrorDecoration,
-	EditorView as CodeMirror,
+	type EditorView as CodeMirror,
 	type DecorationSet,
-	ViewUpdate,
+	type ViewUpdate,
 } from '@codemirror/view';
 
 import type { EditorView, Decoration, DecorationSource } from '@atlaskit/editor-prosemirror/view';