@atlaskit/editor-plugin-card 7.0.3 → 7.0.4

package/CHANGELOG.md

@@ -1,5 +1,14 @@
 # @atlaskit/editor-plugin-card
 
+## 7.0.4
+
+### Patch Changes
+
+- [#184895](https://bitbucket.org/atlassian/atlassian-frontend-monorepo/pull-requests/184895)
+  [`facd697d9125e`](https://bitbucket.org/atlassian/atlassian-frontend-monorepo/commits/facd697d9125e) -
+  Cleanup feature gate to remove card from state on destroy.
+- Updated dependencies
+
 ## 7.0.3
 
 ### Patch Changes

package/dist/cjs/nodeviews/blockCard.js

@@ -18,7 +18,6 @@ var _v = _interopRequireDefault(require("uuid/v4"));
 var _reactNodeView = _interopRequireDefault(require("@atlaskit/editor-common/react-node-view"));
 var _ui = require("@atlaskit/editor-common/ui");
 var _utils = require("@atlaskit/editor-common/utils");
-var _platformFeatureFlags = require("@atlaskit/platform-feature-flags");
 var _smartCard = require("@atlaskit/smart-card");
 var _datasource = require("../nodeviews/datasource");
 var _actions = require("../pm-plugins/actions");
@@ -87,14 +86,12 @@ var BlockCardComponent = exports.BlockCardComponent = /*#__PURE__*/function (_Re
   return (0, _createClass2.default)(BlockCardComponent, [{
     key: "componentWillUnmount",
     value: function componentWillUnmount() {
-      if ((0, _platformFeatureFlags.fg)('platform_editor_fix_advanced_code_crash')) {
-        this.removeCard();
-      }
+      this.removeCard();
     }
   }, {
     key: "removeCard",
     value: function removeCard() {
-      if (this.removeCardDispatched && (0, _platformFeatureFlags.fg)('platform_editor_cards_maxcallstackfix')) {
+      if (this.removeCardDispatched) {
         return;
       }
       this.removeCardDispatched = true;
@@ -149,7 +146,6 @@ var BlockCard = exports.BlockCard = /*#__PURE__*/function (_ReactNodeView) {
     (0, _defineProperty2.default)(_this2, "updateContentEditable", function (editorViewModeState, divElement) {
       divElement.contentEditable = (editorViewModeState === null || editorViewModeState === void 0 ? void 0 : editorViewModeState.mode) === 'view' ? 'false' : 'true';
     });
-    (0, _defineProperty2.default)(_this2, "removeCardDispatched", false);
     return _this2;
   }
   (0, _inherits2.default)(BlockCard, _ReactNodeView);
@@ -212,24 +208,7 @@ var BlockCard = exports.BlockCard = /*#__PURE__*/function (_ReactNodeView) {
     value: function destroy() {
       var _this$unsubscribe;
       (_this$unsubscribe = this.unsubscribe) === null || _this$unsubscribe === void 0 || _this$unsubscribe.call(this);
-      if ((0, _platformFeatureFlags.fg)('platform_editor_fix_advanced_code_crash')) {
-        _superPropGet(BlockCard, "destroy", this, 3)([]);
-      } else {
-        this.removeCard();
-      }
-    }
-  }, {
-    key: "removeCard",
-    value: function removeCard() {
-      if (this.removeCardDispatched && (0, _platformFeatureFlags.fg)('platform_editor_cards_maxcallstackfix')) {
-        return;
-      }
-      this.removeCardDispatched = true;
-      var tr = this.view.state.tr;
-      (0, _actions.removeCard)({
-        id: this.id
-      })(tr);
-      this.view.dispatch(tr);
+      _superPropGet(BlockCard, "destroy", this, 3)([]);
     }
   }]);
 }(_reactNodeView.default);

package/dist/cjs/nodeviews/embedCard.js

@@ -22,7 +22,6 @@ var _reactNodeView = _interopRequireDefault(require("@atlaskit/editor-common/rea
 var _ui = require("@atlaskit/editor-common/ui");
 var _utils = require("@atlaskit/editor-common/utils");
 var _editorSharedStyles = require("@atlaskit/editor-shared-styles");
-var _platformFeatureFlags = require("@atlaskit/platform-feature-flags");
 var _smartCard = require("@atlaskit/smart-card");
 var _actions = require("../pm-plugins/actions");
 var _ResizableEmbedCard = _interopRequireDefault(require("../ui/ResizableEmbedCard"));
@@ -281,14 +280,12 @@ var EmbedCardComponent = exports.EmbedCardComponent = /*#__PURE__*/function (_Re
   return (0, _createClass2.default)(EmbedCardComponent, [{
     key: "componentWillUnmount",
     value: function componentWillUnmount() {
-      if ((0, _platformFeatureFlags.fg)('platform_editor_fix_advanced_code_crash')) {
-        this.removeCard();
-      }
+      this.removeCard();
     }
   }, {
     key: "removeCard",
     value: function removeCard() {
-      if (this.removeCardDispatched && (0, _platformFeatureFlags.fg)('platform_editor_cards_maxcallstackfix')) {
+      if (this.removeCardDispatched) {
         return;
       }
       this.removeCardDispatched = true;
@@ -388,7 +385,6 @@ var EmbedCard = exports.EmbedCard = /*#__PURE__*/function (_ReactNodeView) {
     (0, _defineProperty2.default)(_this2, "updateContentEditable", function (editorViewModeState, divElement) {
       divElement.contentEditable = (editorViewModeState === null || editorViewModeState === void 0 ? void 0 : editorViewModeState.mode) === 'view' ? 'false' : 'true';
     });
-    (0, _defineProperty2.default)(_this2, "removeCardDispatched", false);
     return _this2;
   }
   (0, _inherits2.default)(EmbedCard, _ReactNodeView);
@@ -446,24 +442,7 @@ var EmbedCard = exports.EmbedCard = /*#__PURE__*/function (_ReactNodeView) {
     value: function destroy() {
       var _this$unsubscribe;
       (_this$unsubscribe = this.unsubscribe) === null || _this$unsubscribe === void 0 || _this$unsubscribe.call(this);
-      if ((0, _platformFeatureFlags.fg)('platform_editor_fix_advanced_code_crash')) {
-        _superPropGet(EmbedCard, "destroy", this, 3)([]);
-      } else {
-        this.removeCard();
-      }
-    }
-  }, {
-    key: "removeCard",
-    value: function removeCard() {
-      if (this.removeCardDispatched && (0, _platformFeatureFlags.fg)('platform_editor_cards_maxcallstackfix')) {
-        return;
-      }
-      this.removeCardDispatched = true;
-      var tr = this.view.state.tr;
-      (0, _actions.removeCard)({
-        id: this.id
-      })(tr);
-      this.view.dispatch(tr);
+      _superPropGet(EmbedCard, "destroy", this, 3)([]);
     }
   }]);
 }(_reactNodeView.default);

package/dist/es2019/nodeviews/blockCard.js

@@ -5,7 +5,6 @@ import uuid from 'uuid/v4';
 import ReactNodeView from '@atlaskit/editor-common/react-node-view';
 import { findOverflowScrollParent, UnsupportedBlock } from '@atlaskit/editor-common/ui';
 import { browser, canRenderDatasource } from '@atlaskit/editor-common/utils';
-import { fg } from '@atlaskit/platform-feature-flags';
 import { Card as SmartCard } from '@atlaskit/smart-card';
 import { Datasource } from '../nodeviews/datasource';
 import { registerCard, removeCard } from '../pm-plugins/actions';
@@ -70,12 +69,10 @@ export class BlockCardComponent extends React.PureComponent {
     this.scrollContainer = findOverflowScrollParent(props.view.dom) || undefined;
   }
   componentWillUnmount() {
-    if (fg('platform_editor_fix_advanced_code_crash')) {
-      this.removeCard();
-    }
+    this.removeCard();
   }
   removeCard() {
-    if (this.removeCardDispatched && fg('platform_editor_cards_maxcallstackfix')) {
+    if (this.removeCardDispatched) {
       return;
     }
     this.removeCardDispatched = true;
@@ -126,7 +123,6 @@ export class BlockCard extends ReactNodeView {
     _defineProperty(this, "updateContentEditable", (editorViewModeState, divElement) => {
       divElement.contentEditable = (editorViewModeState === null || editorViewModeState === void 0 ? void 0 : editorViewModeState.mode) === 'view' ? 'false' : 'true';
     });
-    _defineProperty(this, "removeCardDispatched", false);
   }
   createDomRef() {
     var _this$reactComponentP, _this$reactComponentP2, _this$reactComponentP3, _this$reactComponentP4;
@@ -174,24 +170,7 @@ export class BlockCard extends ReactNodeView {
   destroy() {
     var _this$unsubscribe;
     (_this$unsubscribe = this.unsubscribe) === null || _this$unsubscribe === void 0 ? void 0 : _this$unsubscribe.call(this);
-    if (fg('platform_editor_fix_advanced_code_crash')) {
-      super.destroy();
-    } else {
-      this.removeCard();
-    }
-  }
-  removeCard() {
-    if (this.removeCardDispatched && fg('platform_editor_cards_maxcallstackfix')) {
-      return;
-    }
-    this.removeCardDispatched = true;
-    const {
-      tr
-    } = this.view.state;
-    removeCard({
-      id: this.id
-    })(tr);
-    this.view.dispatch(tr);
+    super.destroy();
   }
 }
 export const blockCardNodeView = ({

package/dist/es2019/nodeviews/embedCard.js

@@ -9,7 +9,6 @@ import ReactNodeView from '@atlaskit/editor-common/react-node-view';
 import { findOverflowScrollParent, MediaSingle as RichMediaWrapper, UnsupportedBlock } from '@atlaskit/editor-common/ui';
 import { floatingLayouts, isRichMediaInsideOfBlockNode } from '@atlaskit/editor-common/utils';
 import { DEFAULT_EMBED_CARD_HEIGHT, DEFAULT_EMBED_CARD_WIDTH } from '@atlaskit/editor-shared-styles';
-import { fg } from '@atlaskit/platform-feature-flags';
 import { EmbedResizeMessageListener, Card as SmartCard } from '@atlaskit/smart-card';
 import { registerCard, removeCard } from '../pm-plugins/actions';
 import ResizableEmbedCard from '../ui/ResizableEmbedCard';
@@ -272,12 +271,10 @@ export class EmbedCardComponent extends React.PureComponent {
     this.scrollContainer = findOverflowScrollParent(props.view.dom) || undefined;
   }
   componentWillUnmount() {
-    if (fg('platform_editor_fix_advanced_code_crash')) {
-      this.removeCard();
-    }
+    this.removeCard();
   }
   removeCard() {
-    if (this.removeCardDispatched && fg('platform_editor_cards_maxcallstackfix')) {
+    if (this.removeCardDispatched) {
       return;
     }
     this.removeCardDispatched = true;
@@ -374,7 +371,6 @@ export class EmbedCard extends ReactNodeView {
     _defineProperty(this, "updateContentEditable", (editorViewModeState, divElement) => {
       divElement.contentEditable = (editorViewModeState === null || editorViewModeState === void 0 ? void 0 : editorViewModeState.mode) === 'view' ? 'false' : 'true';
     });
-    _defineProperty(this, "removeCardDispatched", false);
   }
   viewShouldUpdate(nextNode) {
     if (this.node.attrs !== nextNode.attrs) {
@@ -420,24 +416,7 @@ export class EmbedCard extends ReactNodeView {
   destroy() {
     var _this$unsubscribe;
     (_this$unsubscribe = this.unsubscribe) === null || _this$unsubscribe === void 0 ? void 0 : _this$unsubscribe.call(this);
-    if (fg('platform_editor_fix_advanced_code_crash')) {
-      super.destroy();
-    } else {
-      this.removeCard();
-    }
-  }
-  removeCard() {
-    if (this.removeCardDispatched && fg('platform_editor_cards_maxcallstackfix')) {
-      return;
-    }
-    this.removeCardDispatched = true;
-    const {
-      tr
-    } = this.view.state;
-    removeCard({
-      id: this.id
-    })(tr);
-    this.view.dispatch(tr);
+    super.destroy();
   }
 }
 export const embedCardNodeView = ({

package/dist/esm/nodeviews/blockCard.js

@@ -14,7 +14,6 @@ import uuid from 'uuid/v4';
 import ReactNodeView from '@atlaskit/editor-common/react-node-view';
 import { findOverflowScrollParent, UnsupportedBlock } from '@atlaskit/editor-common/ui';
 import { browser, canRenderDatasource } from '@atlaskit/editor-common/utils';
-import { fg } from '@atlaskit/platform-feature-flags';
 import { Card as SmartCard } from '@atlaskit/smart-card';
 import { Datasource } from '../nodeviews/datasource';
 import { registerCard, removeCard as _removeCard } from '../pm-plugins/actions';
@@ -81,14 +80,12 @@ export var BlockCardComponent = /*#__PURE__*/function (_React$PureComponent) {
   return _createClass(BlockCardComponent, [{
     key: "componentWillUnmount",
     value: function componentWillUnmount() {
-      if (fg('platform_editor_fix_advanced_code_crash')) {
-        this.removeCard();
-      }
+      this.removeCard();
     }
   }, {
     key: "removeCard",
     value: function removeCard() {
-      if (this.removeCardDispatched && fg('platform_editor_cards_maxcallstackfix')) {
+      if (this.removeCardDispatched) {
         return;
       }
       this.removeCardDispatched = true;
@@ -143,7 +140,6 @@ export var BlockCard = /*#__PURE__*/function (_ReactNodeView) {
     _defineProperty(_this2, "updateContentEditable", function (editorViewModeState, divElement) {
       divElement.contentEditable = (editorViewModeState === null || editorViewModeState === void 0 ? void 0 : editorViewModeState.mode) === 'view' ? 'false' : 'true';
     });
-    _defineProperty(_this2, "removeCardDispatched", false);
     return _this2;
   }
   _inherits(BlockCard, _ReactNodeView);
@@ -206,24 +202,7 @@ export var BlockCard = /*#__PURE__*/function (_ReactNodeView) {
     value: function destroy() {
       var _this$unsubscribe;
       (_this$unsubscribe = this.unsubscribe) === null || _this$unsubscribe === void 0 || _this$unsubscribe.call(this);
-      if (fg('platform_editor_fix_advanced_code_crash')) {
-        _superPropGet(BlockCard, "destroy", this, 3)([]);
-      } else {
-        this.removeCard();
-      }
-    }
-  }, {
-    key: "removeCard",
-    value: function removeCard() {
-      if (this.removeCardDispatched && fg('platform_editor_cards_maxcallstackfix')) {
-        return;
-      }
-      this.removeCardDispatched = true;
-      var tr = this.view.state.tr;
-      _removeCard({
-        id: this.id
-      })(tr);
-      this.view.dispatch(tr);
+      _superPropGet(BlockCard, "destroy", this, 3)([]);
     }
   }]);
 }(ReactNodeView);

package/dist/esm/nodeviews/embedCard.js

@@ -20,7 +20,6 @@ import ReactNodeView from '@atlaskit/editor-common/react-node-view';
 import { findOverflowScrollParent, MediaSingle as RichMediaWrapper, UnsupportedBlock } from '@atlaskit/editor-common/ui';
 import { floatingLayouts, isRichMediaInsideOfBlockNode } from '@atlaskit/editor-common/utils';
 import { DEFAULT_EMBED_CARD_HEIGHT, DEFAULT_EMBED_CARD_WIDTH } from '@atlaskit/editor-shared-styles';
-import { fg } from '@atlaskit/platform-feature-flags';
 import { EmbedResizeMessageListener, Card as SmartCard } from '@atlaskit/smart-card';
 import { registerCard, removeCard as _removeCard } from '../pm-plugins/actions';
 import ResizableEmbedCard from '../ui/ResizableEmbedCard';
@@ -274,14 +273,12 @@ export var EmbedCardComponent = /*#__PURE__*/function (_React$PureComponent) {
   return _createClass(EmbedCardComponent, [{
     key: "componentWillUnmount",
     value: function componentWillUnmount() {
-      if (fg('platform_editor_fix_advanced_code_crash')) {
-        this.removeCard();
-      }
+      this.removeCard();
     }
   }, {
     key: "removeCard",
     value: function removeCard() {
-      if (this.removeCardDispatched && fg('platform_editor_cards_maxcallstackfix')) {
+      if (this.removeCardDispatched) {
         return;
       }
       this.removeCardDispatched = true;
@@ -381,7 +378,6 @@ export var EmbedCard = /*#__PURE__*/function (_ReactNodeView) {
     _defineProperty(_this2, "updateContentEditable", function (editorViewModeState, divElement) {
       divElement.contentEditable = (editorViewModeState === null || editorViewModeState === void 0 ? void 0 : editorViewModeState.mode) === 'view' ? 'false' : 'true';
     });
-    _defineProperty(_this2, "removeCardDispatched", false);
     return _this2;
   }
   _inherits(EmbedCard, _ReactNodeView);
@@ -439,24 +435,7 @@ export var EmbedCard = /*#__PURE__*/function (_ReactNodeView) {
     value: function destroy() {
       var _this$unsubscribe;
       (_this$unsubscribe = this.unsubscribe) === null || _this$unsubscribe === void 0 || _this$unsubscribe.call(this);
-      if (fg('platform_editor_fix_advanced_code_crash')) {
-        _superPropGet(EmbedCard, "destroy", this, 3)([]);
-      } else {
-        this.removeCard();
-      }
-    }
-  }, {
-    key: "removeCard",
-    value: function removeCard() {
-      if (this.removeCardDispatched && fg('platform_editor_cards_maxcallstackfix')) {
-        return;
-      }
-      this.removeCardDispatched = true;
-      var tr = this.view.state.tr;
-      _removeCard({
-        id: this.id
-      })(tr);
-      this.view.dispatch(tr);
+      _superPropGet(EmbedCard, "destroy", this, 3)([]);
     }
   }]);
 }(ReactNodeView);

package/dist/types/nodeviews/blockCard.d.ts

@@ -35,8 +35,6 @@ export declare class BlockCard extends ReactNodeView<BlockCardNodeViewProps> {
     update(node: Node, decorations: ReadonlyArray<Decoration>, _innerDecorations?: DecorationSource): boolean;
     render(): React.JSX.Element;
     destroy(): void;
-    private removeCardDispatched;
-    private removeCard;
 }
 export interface BlockCardNodeViewProperties {
     pmPluginFactoryParams: PMPluginFactoryParams;

package/dist/types/nodeviews/embedCard.d.ts

@@ -52,8 +52,6 @@ export declare class EmbedCard extends ReactNodeView<EmbedCardNodeViewProps> {
     private updateContentEditable;
     render(): React.JSX.Element;
     destroy(): void;
-    private removeCardDispatched;
-    private removeCard;
 }
 export interface EmbedCardNodeViewProperties {
     allowResizing: EmbedCardNodeViewProps['allowResizing'];

package/dist/types-ts4.5/nodeviews/blockCard.d.ts

@@ -35,8 +35,6 @@ export declare class BlockCard extends ReactNodeView<BlockCardNodeViewProps> {
     update(node: Node, decorations: ReadonlyArray<Decoration>, _innerDecorations?: DecorationSource): boolean;
     render(): React.JSX.Element;
     destroy(): void;
-    private removeCardDispatched;
-    private removeCard;
 }
 export interface BlockCardNodeViewProperties {
     pmPluginFactoryParams: PMPluginFactoryParams;

package/dist/types-ts4.5/nodeviews/embedCard.d.ts

@@ -52,8 +52,6 @@ export declare class EmbedCard extends ReactNodeView<EmbedCardNodeViewProps> {
     private updateContentEditable;
     render(): React.JSX.Element;
     destroy(): void;
-    private removeCardDispatched;
-    private removeCard;
 }
 export interface EmbedCardNodeViewProperties {
     allowResizing: EmbedCardNodeViewProps['allowResizing'];

package/package.json

@@ -1,6 +1,6 @@
 {
 	"name": "@atlaskit/editor-plugin-card",
-	"version": "7.0.3",
+	"version": "7.0.4",
 	"description": "Card plugin for @atlaskit/editor-core",
 	"author": "Atlassian Pty Ltd",
 	"license": "Apache-2.0",
@@ -32,7 +32,7 @@
 		".": "./src/index.ts"
 	},
 	"dependencies": {
-		"@atlaskit/adf-schema": "^47.6.0",
+		"@atlaskit/adf-schema": "^49.0.5",
 		"@atlaskit/analytics-next": "^11.1.0",
 		"@atlaskit/button": "^23.2.0",
 		"@atlaskit/custom-steps": "^0.11.0",
@@ -59,9 +59,9 @@
 		"@atlaskit/menu": "^8.0.0",
 		"@atlaskit/platform-feature-flags": "^1.1.0",
 		"@atlaskit/primitives": "^14.10.0",
-		"@atlaskit/smart-card": "^39.2.0",
+		"@atlaskit/smart-card": "^39.4.0",
 		"@atlaskit/theme": "^19.0.0",
-		"@atlaskit/tmp-editor-statsig": "^9.1.0",
+		"@atlaskit/tmp-editor-statsig": "^9.4.0",
 		"@atlaskit/tokens": "^5.4.0",
 		"@babel/runtime": "^7.0.0",
 		"@emotion/react": "^11.7.1",
@@ -125,9 +125,6 @@
 		"platform_ssr_smartlinks_editor": {
 			"type": "boolean"
 		},
-		"platform_editor_fix_advanced_code_crash": {
-			"type": "boolean"
-		},
 		"prompt_whiteboard_competitor_link_gate": {
 			"type": "boolean"
 		},