@atlaskit/editor-plugin-card 6.6.9 → 6.6.11

package/CHANGELOG.md

@@ -1,5 +1,23 @@
 # @atlaskit/editor-plugin-card
 
+## 6.6.11
+
+### Patch Changes
+
+- [#174579](https://bitbucket.org/atlassian/atlassian-frontend-monorepo/pull-requests/174579)
+  [`523619ae64bbd`](https://bitbucket.org/atlassian/atlassian-frontend-monorepo/commits/523619ae64bbd) -
+  [ux] Clean up feature gate smart_link_editor_update_toolbar_open_link
+- Updated dependencies
+
+## 6.6.10
+
+### Patch Changes
+
+- [#174513](https://bitbucket.org/atlassian/atlassian-frontend-monorepo/pull-requests/174513)
+  [`9190f78c5c704`](https://bitbucket.org/atlassian/atlassian-frontend-monorepo/commits/9190f78c5c704) -
+  Remove platform_editor_exp_disable_lnv experiment key.
+- Updated dependencies
+
 ## 6.6.9
 
 ### Patch Changes

package/dist/cjs/nodeviews/lazy-block-card.js

@@ -11,9 +11,7 @@ var _experiments = require("@atlaskit/tmp-editor-statsig/experiments");
 var _blockCard = require("./blockCard");
 function _interopRequireWildcard(e, t) { if ("function" == typeof WeakMap) var r = new WeakMap(), n = new WeakMap(); return (_interopRequireWildcard = function _interopRequireWildcard(e, t) { if (!t && e && e.__esModule) return e; var o, i, f = { __proto__: null, default: e }; if (null === e || "object" != (0, _typeof2.default)(e) && "function" != typeof e) return f; if (o = t ? n : r) { if (o.has(e)) return o.get(e); o.set(e, f); } for (var _t in e) "default" !== _t && {}.hasOwnProperty.call(e, _t) && ((i = (o = Object.defineProperty) && Object.getOwnPropertyDescriptor(e, _t)) && (i.get || i.set) ? o(f, _t, i) : f[_t] = e[_t]); return f; })(e, t); }
 var lazyBlockCardView = exports.lazyBlockCardView = function lazyBlockCardView(props) {
-  if ((0, _experiments.editorExperiment)('platform_editor_exp_lazy_node_views', false) || (0, _experiments.editorExperiment)('platform_editor_exp_disable_lnv', true, {
-    exposure: true
-  })) {
+  if ((0, _experiments.editorExperiment)('platform_editor_exp_lazy_node_views', false)) {
     return (0, _blockCard.blockCardNodeView)(props);
   }
   return (0, _lazyNodeView.withLazyLoading)({

package/dist/cjs/nodeviews/lazy-embed-card.js

@@ -11,9 +11,7 @@ var _experiments = require("@atlaskit/tmp-editor-statsig/experiments");
 var _embedCard = require("./embedCard");
 function _interopRequireWildcard(e, t) { if ("function" == typeof WeakMap) var r = new WeakMap(), n = new WeakMap(); return (_interopRequireWildcard = function _interopRequireWildcard(e, t) { if (!t && e && e.__esModule) return e; var o, i, f = { __proto__: null, default: e }; if (null === e || "object" != (0, _typeof2.default)(e) && "function" != typeof e) return f; if (o = t ? n : r) { if (o.has(e)) return o.get(e); o.set(e, f); } for (var _t in e) "default" !== _t && {}.hasOwnProperty.call(e, _t) && ((i = (o = Object.defineProperty) && Object.getOwnPropertyDescriptor(e, _t)) && (i.get || i.set) ? o(f, _t, i) : f[_t] = e[_t]); return f; })(e, t); }
 var lazyEmbedCardView = exports.lazyEmbedCardView = function lazyEmbedCardView(props) {
-  if ((0, _experiments.editorExperiment)('platform_editor_exp_lazy_node_views', false) || (0, _experiments.editorExperiment)('platform_editor_exp_disable_lnv', true, {
-    exposure: true
-  })) {
+  if ((0, _experiments.editorExperiment)('platform_editor_exp_lazy_node_views', false)) {
     return (0, _embedCard.embedCardNodeView)(props);
   }
   return (0, _lazyNodeView.withLazyLoading)({

package/dist/cjs/ui/toolbar.js

@@ -81,19 +81,6 @@ var visitCardLink = exports.visitCardLink = function visitCardLink(editorAnalyti
       return false;
     }
     var type = state.selection.node.type;
-
-    // EDM-12466:
-    // During smart_link_editor_update_toolbar_open_link clean up
-    // Consider updating the code to use visitCardLink or visitCardLinkAnalyticsOnly for all input methods:
-    // INPUT_METHOD.FLOATING_TB | INPUT_METHOD.TOOLBAR | INPUT_METHOD.BUTTON | INPUT_METHOD.DOUBLE_CLICK || INPUT_METHOD.META_CLICK
-    if (!(0, _platformFeatureFlags.fg)('smart_link_editor_update_toolbar_open_link')) {
-      var _titleUrlPairFromNode = (0, _utils3.titleUrlPairFromNode)(state.selection.node),
-        url = _titleUrlPairFromNode.url;
-
-      // All card links should open in the same tab per https://product-fabric.atlassian.net/browse/MS-1583.
-      // We are in edit mode here, open the smart card URL in a new window.
-      window.open(url);
-    }
     if (dispatch) {
       var tr = state.tr;
       editorAnalyticsApi === null || editorAnalyticsApi === void 0 || editorAnalyticsApi.attachAnalyticsEvent((0, _analytics.buildVisitedNonHyperLinkPayload)(type.name, inputMethod))(tr);
@@ -226,8 +213,8 @@ var getToolbarViewedItem = function getToolbarViewedItem(url, display) {
 var generateToolbarItems = function generateToolbarItems(state, intl, providerFactory, cardOptions, lpLinkPicker, linkPicker, pluginInjectionApi) {
   return function (node) {
     var _pluginInjectionApi$a, _pluginInjectionApi$d, _pluginInjectionApi$d2, _pluginInjectionApi$a2, _node$attrs;
-    var _titleUrlPairFromNode2 = (0, _utils3.titleUrlPairFromNode)(node),
-      url = _titleUrlPairFromNode2.url;
+    var _titleUrlPairFromNode = (0, _utils3.titleUrlPairFromNode)(node),
+      url = _titleUrlPairFromNode.url;
     var _ref = (_pluginInjectionApi$a = pluginInjectionApi === null || pluginInjectionApi === void 0 ? void 0 : pluginInjectionApi.analytics) !== null && _pluginInjectionApi$a !== void 0 ? _pluginInjectionApi$a : {},
       editorAnalyticsApi = _ref.actions;
     var metadata = {};
@@ -349,7 +336,7 @@ var generateToolbarItems = function generateToolbarItems(state, intl, providerFa
         testId: 'link-toolbar-edit-link-button',
         onClick: (0, _EditLinkToolbar.getEditLinkCallback)(editorAnalyticsApi, true)
       }];
-      var toolbarItems = (0, _experiments.editorExperiment)('platform_editor_controls', 'control') ? [].concat(editItems, commentItems, [_objectSpread({
+      var toolbarItems = (0, _experiments.editorExperiment)('platform_editor_controls', 'control') ? [].concat(editItems, commentItems, [{
         id: 'editor.link.openLink',
         type: 'button',
         icon: _linkExternal.default,
@@ -357,11 +344,10 @@ var generateToolbarItems = function generateToolbarItems(state, intl, providerFa
         metadata: metadata,
         className: 'hyperlink-open-link',
         title: intl.formatMessage(_messages.linkMessages.openLink),
-        onClick: visitCardLink(editorAnalyticsApi, openLinkInputMethod)
-      }, (0, _platformFeatureFlags.fg)('smart_link_editor_update_toolbar_open_link') && {
+        onClick: visitCardLink(editorAnalyticsApi, openLinkInputMethod),
         href: url,
         target: '_blank'
-      }), {
+      }, {
         type: 'separator'
       }], (0, _toConsumableArray2.default)(getUnlinkButtonGroup(state, intl, node, inlineCard, editorAnalyticsApi)), [{
         type: 'copy-button',
@@ -387,7 +373,7 @@ var generateToolbarItems = function generateToolbarItems(state, intl, providerFa
         onBlur: hoverDecoration === null || hoverDecoration === void 0 ? void 0 : hoverDecoration(node.type, false),
         title: intl.formatMessage(_messages.default.remove),
         onClick: withToolbarMetadata(removeCard(editorAnalyticsApi))
-      }]) : [].concat(editButtonItems, (0, _toConsumableArray2.default)(getUnlinkButtonGroup(state, intl, node, inlineCard, editorAnalyticsApi)), [_objectSpread({
+      }]) : [].concat(editButtonItems, (0, _toConsumableArray2.default)(getUnlinkButtonGroup(state, intl, node, inlineCard, editorAnalyticsApi)), [{
         id: 'editor.link.openLink',
         type: 'button',
         icon: _linkExternal.default,
@@ -395,11 +381,10 @@ var generateToolbarItems = function generateToolbarItems(state, intl, providerFa
         metadata: metadata,
         className: 'hyperlink-open-link',
         title: intl.formatMessage(_messages.linkMessages.openLink),
-        onClick: visitCardLink(editorAnalyticsApi, openLinkInputMethod)
-      }, (0, _platformFeatureFlags.fg)('smart_link_editor_update_toolbar_open_link') && {
+        onClick: visitCardLink(editorAnalyticsApi, openLinkInputMethod),
         href: url,
         target: '_blank'
-      })], (0, _toConsumableArray2.default)(commentItems.length > 1 ? [{
+      }], (0, _toConsumableArray2.default)(commentItems.length > 1 ? [{
         type: 'separator',
         fullHeight: true
       }, commentItems[0]] : commentItems));
@@ -623,7 +608,7 @@ var getDatasourceButtonGroup = function getDatasourceButtonGroup(metadata, intl,
     }
   });
   if (node !== null && node !== void 0 && (_node$attrs2 = node.attrs) !== null && _node$attrs2 !== void 0 && _node$attrs2.url) {
-    toolbarItems.push(_objectSpread({
+    toolbarItems.push({
       id: 'editor.link.openLink',
       type: 'button',
       icon: _linkExternal.default,
@@ -631,11 +616,10 @@ var getDatasourceButtonGroup = function getDatasourceButtonGroup(metadata, intl,
       metadata: metadata,
       className: 'hyperlink-open-link',
       title: intl.formatMessage(_messages.linkMessages.openLink),
-      onClick: visitCardLink(editorAnalyticsApi, openLinkInputMethod)
-    }, (0, _platformFeatureFlags.fg)('smart_link_editor_update_toolbar_open_link') && {
+      onClick: visitCardLink(editorAnalyticsApi, openLinkInputMethod),
       href: node.attrs.url,
       target: '_blank'
-    }));
+    });
     if ((0, _experiments.editorExperiment)('platform_editor_controls', 'control')) {
       toolbarItems.push({
         type: 'separator'

package/dist/es2019/nodeviews/lazy-block-card.js

@@ -2,9 +2,7 @@ import { withLazyLoading } from '@atlaskit/editor-common/lazy-node-view';
 import { editorExperiment } from '@atlaskit/tmp-editor-statsig/experiments';
 import { blockCardNodeView } from './blockCard';
 export const lazyBlockCardView = props => {
-  if (editorExperiment('platform_editor_exp_lazy_node_views', false) || editorExperiment('platform_editor_exp_disable_lnv', true, {
-    exposure: true
-  })) {
+  if (editorExperiment('platform_editor_exp_lazy_node_views', false)) {
     return blockCardNodeView(props);
   }
   return withLazyLoading({

package/dist/es2019/nodeviews/lazy-embed-card.js

@@ -2,9 +2,7 @@ import { withLazyLoading } from '@atlaskit/editor-common/lazy-node-view';
 import { editorExperiment } from '@atlaskit/tmp-editor-statsig/experiments';
 import { embedCardNodeView } from './embedCard';
 export const lazyEmbedCardView = props => {
-  if (editorExperiment('platform_editor_exp_lazy_node_views', false) || editorExperiment('platform_editor_exp_disable_lnv', true, {
-    exposure: true
-  })) {
+  if (editorExperiment('platform_editor_exp_lazy_node_views', false)) {
     return embedCardNodeView(props);
   }
   return withLazyLoading({

package/dist/es2019/ui/toolbar.js

@@ -69,20 +69,6 @@ export const visitCardLink = (editorAnalyticsApi, inputMethod) => (state, dispat
   const {
     type
   } = state.selection.node;
-
-  // EDM-12466:
-  // During smart_link_editor_update_toolbar_open_link clean up
-  // Consider updating the code to use visitCardLink or visitCardLinkAnalyticsOnly for all input methods:
-  // INPUT_METHOD.FLOATING_TB | INPUT_METHOD.TOOLBAR | INPUT_METHOD.BUTTON | INPUT_METHOD.DOUBLE_CLICK || INPUT_METHOD.META_CLICK
-  if (!fg('smart_link_editor_update_toolbar_open_link')) {
-    const {
-      url
-    } = titleUrlPairFromNode(state.selection.node);
-
-    // All card links should open in the same tab per https://product-fabric.atlassian.net/browse/MS-1583.
-    // We are in edit mode here, open the smart card URL in a new window.
-    window.open(url);
-  }
   if (dispatch) {
     const {
       tr
@@ -351,10 +337,8 @@ const generateToolbarItems = (state, intl, providerFactory, cardOptions, lpLinkP
       className: 'hyperlink-open-link',
       title: intl.formatMessage(linkMessages.openLink),
       onClick: visitCardLink(editorAnalyticsApi, openLinkInputMethod),
-      ...(fg('smart_link_editor_update_toolbar_open_link') && {
-        href: url,
-        target: '_blank'
-      })
+      href: url,
+      target: '_blank'
     }, {
       type: 'separator'
     }, ...getUnlinkButtonGroup(state, intl, node, inlineCard, editorAnalyticsApi), {
@@ -390,10 +374,8 @@ const generateToolbarItems = (state, intl, providerFactory, cardOptions, lpLinkP
       className: 'hyperlink-open-link',
       title: intl.formatMessage(linkMessages.openLink),
       onClick: visitCardLink(editorAnalyticsApi, openLinkInputMethod),
-      ...(fg('smart_link_editor_update_toolbar_open_link') && {
-        href: url,
-        target: '_blank'
-      })
+      href: url,
+      target: '_blank'
     }, ...(commentItems.length > 1 ? [{
       type: 'separator',
       fullHeight: true
@@ -624,10 +606,8 @@ const getDatasourceButtonGroup = (metadata, intl, editorAnalyticsApi, node, hove
       className: 'hyperlink-open-link',
       title: intl.formatMessage(linkMessages.openLink),
       onClick: visitCardLink(editorAnalyticsApi, openLinkInputMethod),
-      ...(fg('smart_link_editor_update_toolbar_open_link') && {
-        href: node.attrs.url,
-        target: '_blank'
-      })
+      href: node.attrs.url,
+      target: '_blank'
     });
     if (editorExperiment('platform_editor_controls', 'control')) {
       toolbarItems.push({

package/dist/esm/nodeviews/lazy-block-card.js

@@ -2,9 +2,7 @@ import { withLazyLoading } from '@atlaskit/editor-common/lazy-node-view';
 import { editorExperiment } from '@atlaskit/tmp-editor-statsig/experiments';
 import { blockCardNodeView } from './blockCard';
 export var lazyBlockCardView = function lazyBlockCardView(props) {
-  if (editorExperiment('platform_editor_exp_lazy_node_views', false) || editorExperiment('platform_editor_exp_disable_lnv', true, {
-    exposure: true
-  })) {
+  if (editorExperiment('platform_editor_exp_lazy_node_views', false)) {
     return blockCardNodeView(props);
   }
   return withLazyLoading({

package/dist/esm/nodeviews/lazy-embed-card.js

@@ -2,9 +2,7 @@ import { withLazyLoading } from '@atlaskit/editor-common/lazy-node-view';
 import { editorExperiment } from '@atlaskit/tmp-editor-statsig/experiments';
 import { embedCardNodeView } from './embedCard';
 export var lazyEmbedCardView = function lazyEmbedCardView(props) {
-  if (editorExperiment('platform_editor_exp_lazy_node_views', false) || editorExperiment('platform_editor_exp_disable_lnv', true, {
-    exposure: true
-  })) {
+  if (editorExperiment('platform_editor_exp_lazy_node_views', false)) {
     return embedCardNodeView(props);
   }
   return withLazyLoading({

package/dist/esm/ui/toolbar.js

@@ -72,19 +72,6 @@ export var visitCardLink = function visitCardLink(editorAnalyticsApi, inputMetho
       return false;
     }
     var type = state.selection.node.type;
-
-    // EDM-12466:
-    // During smart_link_editor_update_toolbar_open_link clean up
-    // Consider updating the code to use visitCardLink or visitCardLinkAnalyticsOnly for all input methods:
-    // INPUT_METHOD.FLOATING_TB | INPUT_METHOD.TOOLBAR | INPUT_METHOD.BUTTON | INPUT_METHOD.DOUBLE_CLICK || INPUT_METHOD.META_CLICK
-    if (!fg('smart_link_editor_update_toolbar_open_link')) {
-      var _titleUrlPairFromNode = titleUrlPairFromNode(state.selection.node),
-        url = _titleUrlPairFromNode.url;
-
-      // All card links should open in the same tab per https://product-fabric.atlassian.net/browse/MS-1583.
-      // We are in edit mode here, open the smart card URL in a new window.
-      window.open(url);
-    }
     if (dispatch) {
       var tr = state.tr;
       editorAnalyticsApi === null || editorAnalyticsApi === void 0 || editorAnalyticsApi.attachAnalyticsEvent(buildVisitedNonHyperLinkPayload(type.name, inputMethod))(tr);
@@ -217,8 +204,8 @@ var getToolbarViewedItem = function getToolbarViewedItem(url, display) {
 var generateToolbarItems = function generateToolbarItems(state, intl, providerFactory, cardOptions, lpLinkPicker, linkPicker, pluginInjectionApi) {
   return function (node) {
     var _pluginInjectionApi$a, _pluginInjectionApi$d, _pluginInjectionApi$d2, _pluginInjectionApi$a2, _node$attrs;
-    var _titleUrlPairFromNode2 = titleUrlPairFromNode(node),
-      url = _titleUrlPairFromNode2.url;
+    var _titleUrlPairFromNode = titleUrlPairFromNode(node),
+      url = _titleUrlPairFromNode.url;
     var _ref = (_pluginInjectionApi$a = pluginInjectionApi === null || pluginInjectionApi === void 0 ? void 0 : pluginInjectionApi.analytics) !== null && _pluginInjectionApi$a !== void 0 ? _pluginInjectionApi$a : {},
       editorAnalyticsApi = _ref.actions;
     var metadata = {};
@@ -340,7 +327,7 @@ var generateToolbarItems = function generateToolbarItems(state, intl, providerFa
         testId: 'link-toolbar-edit-link-button',
         onClick: getEditLinkCallback(editorAnalyticsApi, true)
       }];
-      var toolbarItems = editorExperiment('platform_editor_controls', 'control') ? [].concat(editItems, commentItems, [_objectSpread({
+      var toolbarItems = editorExperiment('platform_editor_controls', 'control') ? [].concat(editItems, commentItems, [{
         id: 'editor.link.openLink',
         type: 'button',
         icon: LinkExternalIcon,
@@ -348,11 +335,10 @@ var generateToolbarItems = function generateToolbarItems(state, intl, providerFa
         metadata: metadata,
         className: 'hyperlink-open-link',
         title: intl.formatMessage(linkMessages.openLink),
-        onClick: visitCardLink(editorAnalyticsApi, openLinkInputMethod)
-      }, fg('smart_link_editor_update_toolbar_open_link') && {
+        onClick: visitCardLink(editorAnalyticsApi, openLinkInputMethod),
         href: url,
         target: '_blank'
-      }), {
+      }, {
         type: 'separator'
       }], _toConsumableArray(getUnlinkButtonGroup(state, intl, node, inlineCard, editorAnalyticsApi)), [{
         type: 'copy-button',
@@ -378,7 +364,7 @@ var generateToolbarItems = function generateToolbarItems(state, intl, providerFa
         onBlur: hoverDecoration === null || hoverDecoration === void 0 ? void 0 : hoverDecoration(node.type, false),
         title: intl.formatMessage(commonMessages.remove),
         onClick: withToolbarMetadata(removeCard(editorAnalyticsApi))
-      }]) : [].concat(editButtonItems, _toConsumableArray(getUnlinkButtonGroup(state, intl, node, inlineCard, editorAnalyticsApi)), [_objectSpread({
+      }]) : [].concat(editButtonItems, _toConsumableArray(getUnlinkButtonGroup(state, intl, node, inlineCard, editorAnalyticsApi)), [{
         id: 'editor.link.openLink',
         type: 'button',
         icon: LinkExternalIcon,
@@ -386,11 +372,10 @@ var generateToolbarItems = function generateToolbarItems(state, intl, providerFa
         metadata: metadata,
         className: 'hyperlink-open-link',
         title: intl.formatMessage(linkMessages.openLink),
-        onClick: visitCardLink(editorAnalyticsApi, openLinkInputMethod)
-      }, fg('smart_link_editor_update_toolbar_open_link') && {
+        onClick: visitCardLink(editorAnalyticsApi, openLinkInputMethod),
         href: url,
         target: '_blank'
-      })], _toConsumableArray(commentItems.length > 1 ? [{
+      }], _toConsumableArray(commentItems.length > 1 ? [{
         type: 'separator',
         fullHeight: true
       }, commentItems[0]] : commentItems));
@@ -614,7 +599,7 @@ var getDatasourceButtonGroup = function getDatasourceButtonGroup(metadata, intl,
     }
   });
   if (node !== null && node !== void 0 && (_node$attrs2 = node.attrs) !== null && _node$attrs2 !== void 0 && _node$attrs2.url) {
-    toolbarItems.push(_objectSpread({
+    toolbarItems.push({
       id: 'editor.link.openLink',
       type: 'button',
       icon: LinkExternalIcon,
@@ -622,11 +607,10 @@ var getDatasourceButtonGroup = function getDatasourceButtonGroup(metadata, intl,
       metadata: metadata,
       className: 'hyperlink-open-link',
       title: intl.formatMessage(linkMessages.openLink),
-      onClick: visitCardLink(editorAnalyticsApi, openLinkInputMethod)
-    }, fg('smart_link_editor_update_toolbar_open_link') && {
+      onClick: visitCardLink(editorAnalyticsApi, openLinkInputMethod),
       href: node.attrs.url,
       target: '_blank'
-    }));
+    });
     if (editorExperiment('platform_editor_controls', 'control')) {
       toolbarItems.push({
         type: 'separator'

package/package.json

@@ -1,6 +1,6 @@
 {
 	"name": "@atlaskit/editor-plugin-card",
-	"version": "6.6.9",
+	"version": "6.6.11",
 	"description": "Card plugin for @atlaskit/editor-core",
 	"author": "Atlassian Pty Ltd",
 	"license": "Apache-2.0",
@@ -61,10 +61,10 @@
 		"@atlaskit/menu": "^8.0.0",
 		"@atlaskit/platform-feature-flags": "^1.1.0",
 		"@atlaskit/primitives": "^14.9.0",
-		"@atlaskit/smart-card": "^38.12.0",
+		"@atlaskit/smart-card": "^38.13.0",
 		"@atlaskit/theme": "^18.0.0",
-		"@atlaskit/tmp-editor-statsig": "^7.2.0",
-		"@atlaskit/tokens": "^5.3.0",
+		"@atlaskit/tmp-editor-statsig": "^8.0.0",
+		"@atlaskit/tokens": "^5.4.0",
 		"@babel/runtime": "^7.0.0",
 		"@emotion/react": "^11.7.1",
 		"lodash": "^4.17.21",
@@ -132,9 +132,6 @@
 		"platform_editor_controls_patch_12": {
 			"type": "boolean"
 		},
-		"smart_link_editor_update_toolbar_open_link": {
-			"type": "boolean"
-		},
 		"platform_editor_fix_advanced_code_crash": {
 			"type": "boolean"
 		},