@atlaskit/editor-plugin-card 6.6.2 → 6.6.4

This diff represents the content of publicly available package versions that have been released to one of the supported registries. The information contained in this diff is provided for informational purposes only and reflects changes between package versions as they appear in their respective public registries.
package/CHANGELOG.md CHANGED
@@ -1,5 +1,22 @@
1
1
  # @atlaskit/editor-plugin-card
2
2
 
3
+ ## 6.6.4
4
+
5
+ ### Patch Changes
6
+
7
+ - [#169870](https://bitbucket.org/atlassian/atlassian-frontend-monorepo/pull-requests/169870)
8
+ [`07d290a3b8ee1`](https://bitbucket.org/atlassian/atlassian-frontend-monorepo/commits/07d290a3b8ee1) -
9
+ [ED-28198] Add tooltip for edit link toolbar icon button
10
+ - Updated dependencies
11
+
12
+ ## 6.6.3
13
+
14
+ ### Patch Changes
15
+
16
+ - [#166368](https://bitbucket.org/atlassian/atlassian-frontend-monorepo/pull-requests/166368)
17
+ [`5f46eb74d8fa5`](https://bitbucket.org/atlassian/atlassian-frontend-monorepo/commits/5f46eb74d8fa5) -
18
+ [ux] ED-27810: Added the link preference button when control is on
19
+
3
20
  ## 6.6.2
4
21
 
5
22
  ### Patch Changes
@@ -13,11 +13,11 @@ var _messages = require("@atlaskit/editor-common/messages");
13
13
  var _ui = require("@atlaskit/editor-common/ui");
14
14
  var _uiMenu = require("@atlaskit/editor-common/ui-menu");
15
15
  var _edit = _interopRequireDefault(require("@atlaskit/icon/core/edit"));
16
- var _chevronDown = _interopRequireDefault(require("@atlaskit/icon/utility/migration/chevron-down"));
16
+ var _chevronDown = _interopRequireDefault(require("@atlaskit/icon/core/migration/chevron-down"));
17
17
  var _menu = require("@atlaskit/menu");
18
18
  var _platformFeatureFlags = require("@atlaskit/platform-feature-flags");
19
19
  var _compiled = require("@atlaskit/primitives/compiled");
20
- var _experiments = require("@atlaskit/tmp-editor-statsig/experiments");
20
+ var _expValEqualsNoExposure = require("@atlaskit/tmp-editor-statsig/exp-val-equals-no-exposure");
21
21
  var _utils = require("../../pm-plugins/utils");
22
22
  var _editDatasourceAction = require("../editDatasourceAction");
23
23
  /**
@@ -64,9 +64,11 @@ var EditToolbarButtonPresentation = function EditToolbarButtonPresentation(_ref)
64
64
  (0, _utils.focusEditorView)(editorView);
65
65
  }
66
66
  }, [currentAppearance, datasourceId, editorAnalyticsApi, editorView, extensionKey]);
67
- var icon = (0, _experiments.editorExperiment)('platform_editor_controls', 'variant1') ? (0, _react2.jsx)(_edit.default, {
67
+ var isControlsOn = (0, _expValEqualsNoExposure.expValEqualsNoExposure)('platform_editor_controls', 'cohort', 'variant1');
68
+ var icon = isControlsOn ? (0, _react2.jsx)(_edit.default, {
68
69
  label: ""
69
70
  }) : undefined;
71
+ var tooltipContent = isControlsOn && (0, _platformFeatureFlags.fg)('platform_editor_controls_patch_13') ? intl.formatMessage(_messages.linkToolbarMessages.editLink) : undefined;
70
72
  switch (editVariant) {
71
73
  case 'edit-link':
72
74
  {
@@ -75,11 +77,12 @@ var EditToolbarButtonPresentation = function EditToolbarButtonPresentation(_ref)
75
77
  }, (0, _react2.jsx)(_ui.FloatingToolbarButton, {
76
78
  testId: "edit-link",
77
79
  onClick: onEditLink,
78
- icon: icon
79
- }, (0, _experiments.editorExperiment)('platform_editor_controls', 'control') && (0, _react2.jsx)(_reactIntlNext.FormattedMessage
80
+ icon: icon,
81
+ tooltipContent: tooltipContent
82
+ }, !isControlsOn && (0, _react2.jsx)(_reactIntlNext.FormattedMessage
80
83
  // Ignored via go/ees005
81
84
  // eslint-disable-next-line react/jsx-props-no-spreading
82
- , _messages.linkToolbarMessages.editLink)), (!(0, _experiments.editorExperiment)('platform_editor_controls', 'variant1') || !(0, _platformFeatureFlags.fg)('platform_editor_controls_patch_6')) && (0, _react2.jsx)(_ui.FloatingToolbarSeparator, null));
85
+ , _messages.linkToolbarMessages.editLink)), (!isControlsOn || !(0, _platformFeatureFlags.fg)('platform_editor_controls_patch_6')) && (0, _react2.jsx)(_ui.FloatingToolbarSeparator, null));
83
86
  }
84
87
  case 'edit-datasource':
85
88
  {
@@ -92,7 +95,7 @@ var EditToolbarButtonPresentation = function EditToolbarButtonPresentation(_ref)
92
95
  }, (0, _react2.jsx)(_reactIntlNext.FormattedMessage
93
96
  // Ignored via go/ees005
94
97
  // eslint-disable-next-line react/jsx-props-no-spreading
95
- , _messages.linkToolbarMessages.editDatasourceStandalone)), (!(0, _experiments.editorExperiment)('platform_editor_controls', 'variant1') || !(0, _platformFeatureFlags.fg)('platform_editor_controls_patch_6')) && (0, _react2.jsx)(_ui.FloatingToolbarSeparator, null));
98
+ , _messages.linkToolbarMessages.editDatasourceStandalone)), (!isControlsOn || !(0, _platformFeatureFlags.fg)('platform_editor_controls_patch_6')) && (0, _react2.jsx)(_ui.FloatingToolbarSeparator, null));
96
99
  }
97
100
  case 'edit-dropdown':
98
101
  {
@@ -103,7 +106,8 @@ var EditToolbarButtonPresentation = function EditToolbarButtonPresentation(_ref)
103
106
  iconAfter: (0, _react2.jsx)("span", {
104
107
  css: dropdownExpandContainer
105
108
  }, (0, _react2.jsx)(_chevronDown.default, {
106
- label: intl.formatMessage(_messages.cardMessages.editDropdownTriggerTitle)
109
+ label: intl.formatMessage(_messages.cardMessages.editDropdownTriggerTitle),
110
+ size: "small"
107
111
  })),
108
112
  onClick: toggleOpen,
109
113
  selected: isOpen,
@@ -112,7 +116,7 @@ var EditToolbarButtonPresentation = function EditToolbarButtonPresentation(_ref)
112
116
  }, (0, _react2.jsx)(_reactIntlNext.FormattedMessage
113
117
  // Ignored via go/ees005
114
118
  // eslint-disable-next-line react/jsx-props-no-spreading
115
- , _messages.cardMessages.editDropdownTriggerTitle)), (!(0, _experiments.editorExperiment)('platform_editor_controls', 'variant1') || !(0, _platformFeatureFlags.fg)('platform_editor_controls_patch_6')) && (0, _react2.jsx)(_ui.FloatingToolbarSeparator, null));
119
+ , _messages.cardMessages.editDropdownTriggerTitle)), (!isControlsOn || !(0, _platformFeatureFlags.fg)('platform_editor_controls_patch_6')) && (0, _react2.jsx)(_ui.FloatingToolbarSeparator, null));
116
120
  return (0, _react2.jsx)(_compiled.Flex, {
117
121
  ref: containerRef
118
122
  }, (0, _react2.jsx)(_uiMenu.DropdownContainer, {
@@ -13,7 +13,7 @@ var _reactIntlNext = require("react-intl-next");
13
13
  var _messages = require("@atlaskit/editor-common/messages");
14
14
  var _ui = require("@atlaskit/editor-common/ui");
15
15
  var _uiMenu = require("@atlaskit/editor-common/ui-menu");
16
- var _chevronDown = _interopRequireDefault(require("@atlaskit/icon/utility/migration/chevron-down"));
16
+ var _chevronDown = _interopRequireDefault(require("@atlaskit/icon/core/migration/chevron-down"));
17
17
  var _linkProvider = require("@atlaskit/link-provider");
18
18
  var _menu = require("@atlaskit/menu");
19
19
  var _platformFeatureFlags = require("@atlaskit/platform-feature-flags");
@@ -129,7 +129,8 @@ var EditToolbarButtonWithCardContext = function EditToolbarButtonWithCardContext
129
129
  iconAfter: (0, _react2.jsx)("span", {
130
130
  css: dropdownExpandContainer
131
131
  }, (0, _react2.jsx)(_chevronDown.default, {
132
- label: intl.formatMessage(_messages.cardMessages.editDropdownTriggerTitle)
132
+ label: intl.formatMessage(_messages.cardMessages.editDropdownTriggerTitle),
133
+ size: "small"
133
134
  })),
134
135
  onClick: toggleOpen,
135
136
  selected: isOpen,
@@ -13,7 +13,7 @@ var _react = _interopRequireWildcard(require("react"));
13
13
  var _card = require("@atlaskit/editor-common/card");
14
14
  var _ui = require("@atlaskit/editor-common/ui");
15
15
  var _uiMenu = require("@atlaskit/editor-common/ui-menu");
16
- var _chevronDown = _interopRequireDefault(require("@atlaskit/icon/utility/migration/chevron-down"));
16
+ var _chevronDown = _interopRequireDefault(require("@atlaskit/icon/core/migration/chevron-down"));
17
17
  var _platformFeatureFlags = require("@atlaskit/platform-feature-flags");
18
18
  var _compiled = require("@atlaskit/primitives/compiled");
19
19
  var _LinkToolbarAppearanceDropdown = require("./LinkToolbarAppearanceDropdown");
@@ -176,7 +176,8 @@ var CustomHyperlinkDropdown = function CustomHyperlinkDropdown(props) {
176
176
  }),
177
177
  iconAfter: /*#__PURE__*/_react.default.createElement(_chevronDown.default, {
178
178
  label: "",
179
- spacing: "compact"
179
+ spacing: "compact",
180
+ size: "small"
180
181
  })
181
182
  }, title);
182
183
  return /*#__PURE__*/_react.default.createElement(_compiled.Flex, {
@@ -674,10 +674,24 @@ var getDatasourceButtonGroup = function getDatasourceButtonGroup(metadata, intl,
674
674
  // testId is required to show focus on trigger button on ESC key press
675
675
  // see hideOnEsc in platform/packages/editor/editor-plugin-floating-toolbar/src/ui/Dropdown.tsx
676
676
  var testId = (0, _platformFeatureFlags.fg)('platform_editor_controls_patch_8') ? 'datasource-overflow-dropdown-trigger' : undefined;
677
- toolbarItems.push({
678
- type: 'separator',
679
- fullHeight: true
680
- });
677
+
678
+ // When canShowAppearanceSwitch is true, and platform_editor_controls is on, the link appearance dropdown shows, which includes a link preference button
679
+ // So only add the link appearance button when canShowAppearanceSwitch is false
680
+ if (!canShowAppearanceSwitch() && (0, _platformFeatureFlags.fg)('platform_editor_controls_patch_12')) {
681
+ var linkPreferenceButton = getSettingsButton(intl, editorAnalyticsApi, cardOptions === null || cardOptions === void 0 ? void 0 : cardOptions.userPreferencesLink);
682
+ toolbarItems.push({
683
+ type: 'separator',
684
+ fullHeight: true
685
+ }, linkPreferenceButton, {
686
+ type: 'separator',
687
+ fullHeight: true
688
+ });
689
+ } else {
690
+ toolbarItems.push({
691
+ type: 'separator',
692
+ fullHeight: true
693
+ });
694
+ }
681
695
  var overflowMenuConfig = [{
682
696
  type: 'overflow-dropdown',
683
697
  testId: testId,
@@ -11,11 +11,11 @@ import { linkToolbarMessages, cardMessages as messages } from '@atlaskit/editor-
11
11
  import { FloatingToolbarButton as Button, FloatingToolbarSeparator as Separator } from '@atlaskit/editor-common/ui';
12
12
  import { ArrowKeyNavigationType, DropdownContainer as UiDropdown } from '@atlaskit/editor-common/ui-menu';
13
13
  import EditIcon from '@atlaskit/icon/core/edit';
14
- import ChevronDownIcon from '@atlaskit/icon/utility/migration/chevron-down';
14
+ import ChevronDownIcon from '@atlaskit/icon/core/migration/chevron-down';
15
15
  import { ButtonItem } from '@atlaskit/menu';
16
16
  import { fg } from '@atlaskit/platform-feature-flags';
17
17
  import { Flex } from '@atlaskit/primitives/compiled';
18
- import { editorExperiment } from '@atlaskit/tmp-editor-statsig/experiments';
18
+ import { expValEqualsNoExposure } from '@atlaskit/tmp-editor-statsig/exp-val-equals-no-exposure';
19
19
  import { focusEditorView } from '../../pm-plugins/utils';
20
20
  import { editDatasource } from '../editDatasourceAction';
21
21
  const dropdownExpandContainer = css({
@@ -47,9 +47,11 @@ const EditToolbarButtonPresentation = ({
47
47
  focusEditorView(editorView);
48
48
  }
49
49
  }, [currentAppearance, datasourceId, editorAnalyticsApi, editorView, extensionKey]);
50
- const icon = editorExperiment('platform_editor_controls', 'variant1') ? jsx(EditIcon, {
50
+ const isControlsOn = expValEqualsNoExposure('platform_editor_controls', 'cohort', 'variant1');
51
+ const icon = isControlsOn ? jsx(EditIcon, {
51
52
  label: ""
52
53
  }) : undefined;
54
+ const tooltipContent = isControlsOn && fg('platform_editor_controls_patch_13') ? intl.formatMessage(linkToolbarMessages.editLink) : undefined;
53
55
  switch (editVariant) {
54
56
  case 'edit-link':
55
57
  {
@@ -58,11 +60,12 @@ const EditToolbarButtonPresentation = ({
58
60
  }, jsx(Button, {
59
61
  testId: "edit-link",
60
62
  onClick: onEditLink,
61
- icon: icon
62
- }, editorExperiment('platform_editor_controls', 'control') && jsx(FormattedMessage
63
+ icon: icon,
64
+ tooltipContent: tooltipContent
65
+ }, !isControlsOn && jsx(FormattedMessage
63
66
  // Ignored via go/ees005
64
67
  // eslint-disable-next-line react/jsx-props-no-spreading
65
- , linkToolbarMessages.editLink)), (!editorExperiment('platform_editor_controls', 'variant1') || !fg('platform_editor_controls_patch_6')) && jsx(Separator, null));
68
+ , linkToolbarMessages.editLink)), (!isControlsOn || !fg('platform_editor_controls_patch_6')) && jsx(Separator, null));
66
69
  }
67
70
  case 'edit-datasource':
68
71
  {
@@ -75,7 +78,7 @@ const EditToolbarButtonPresentation = ({
75
78
  }, jsx(FormattedMessage
76
79
  // Ignored via go/ees005
77
80
  // eslint-disable-next-line react/jsx-props-no-spreading
78
- , linkToolbarMessages.editDatasourceStandalone)), (!editorExperiment('platform_editor_controls', 'variant1') || !fg('platform_editor_controls_patch_6')) && jsx(Separator, null));
81
+ , linkToolbarMessages.editDatasourceStandalone)), (!isControlsOn || !fg('platform_editor_controls_patch_6')) && jsx(Separator, null));
79
82
  }
80
83
  case 'edit-dropdown':
81
84
  {
@@ -86,7 +89,8 @@ const EditToolbarButtonPresentation = ({
86
89
  iconAfter: jsx("span", {
87
90
  css: dropdownExpandContainer
88
91
  }, jsx(ChevronDownIcon, {
89
- label: intl.formatMessage(messages.editDropdownTriggerTitle)
92
+ label: intl.formatMessage(messages.editDropdownTriggerTitle),
93
+ size: "small"
90
94
  })),
91
95
  onClick: toggleOpen,
92
96
  selected: isOpen,
@@ -95,7 +99,7 @@ const EditToolbarButtonPresentation = ({
95
99
  }, jsx(FormattedMessage
96
100
  // Ignored via go/ees005
97
101
  // eslint-disable-next-line react/jsx-props-no-spreading
98
- , messages.editDropdownTriggerTitle)), (!editorExperiment('platform_editor_controls', 'variant1') || !fg('platform_editor_controls_patch_6')) && jsx(Separator, null));
102
+ , messages.editDropdownTriggerTitle)), (!isControlsOn || !fg('platform_editor_controls_patch_6')) && jsx(Separator, null));
99
103
  return jsx(Flex, {
100
104
  ref: containerRef
101
105
  }, jsx(UiDropdown, {
@@ -10,7 +10,7 @@ import { FormattedMessage } from 'react-intl-next';
10
10
  import { linkToolbarMessages, cardMessages as messages } from '@atlaskit/editor-common/messages';
11
11
  import { FloatingToolbarButton as Button, FloatingToolbarSeparator as Separator } from '@atlaskit/editor-common/ui';
12
12
  import { ArrowKeyNavigationType, DropdownContainer as UiDropdown } from '@atlaskit/editor-common/ui-menu';
13
- import ChevronDownIcon from '@atlaskit/icon/utility/migration/chevron-down';
13
+ import ChevronDownIcon from '@atlaskit/icon/core/migration/chevron-down';
14
14
  import { useSmartLinkContext } from '@atlaskit/link-provider';
15
15
  import { ButtonItem } from '@atlaskit/menu';
16
16
  import { fg } from '@atlaskit/platform-feature-flags';
@@ -114,7 +114,8 @@ const EditToolbarButtonWithCardContext = props => {
114
114
  iconAfter: jsx("span", {
115
115
  css: dropdownExpandContainer
116
116
  }, jsx(ChevronDownIcon, {
117
- label: intl.formatMessage(messages.editDropdownTriggerTitle)
117
+ label: intl.formatMessage(messages.editDropdownTriggerTitle),
118
+ size: "small"
118
119
  })),
119
120
  onClick: toggleOpen,
120
121
  selected: isOpen,
@@ -2,7 +2,7 @@ import React, { useEffect, useRef, useState } from 'react';
2
2
  import { appearancePropsMap } from '@atlaskit/editor-common/card';
3
3
  import { FloatingToolbarButton as Button, FloatingToolbarSeparator as Separator } from '@atlaskit/editor-common/ui';
4
4
  import { ArrowKeyNavigationType, DropdownContainer as UiDropdown } from '@atlaskit/editor-common/ui-menu';
5
- import ChevronDownIcon from '@atlaskit/icon/utility/migration/chevron-down';
5
+ import ChevronDownIcon from '@atlaskit/icon/core/migration/chevron-down';
6
6
  import { fg } from '@atlaskit/platform-feature-flags';
7
7
  import { Flex } from '@atlaskit/primitives/compiled';
8
8
  import { LinkAppearanceMenu } from './LinkToolbarAppearanceDropdown';
@@ -91,7 +91,8 @@ const CustomHyperlinkDropdown = props => {
91
91
  }),
92
92
  iconAfter: /*#__PURE__*/React.createElement(ChevronDownIcon, {
93
93
  label: "",
94
- spacing: "compact"
94
+ spacing: "compact",
95
+ size: "small"
95
96
  })
96
97
  }, title);
97
98
  return /*#__PURE__*/React.createElement(Flex, {
@@ -667,10 +667,24 @@ const getDatasourceButtonGroup = (metadata, intl, editorAnalyticsApi, node, hove
667
667
  // testId is required to show focus on trigger button on ESC key press
668
668
  // see hideOnEsc in platform/packages/editor/editor-plugin-floating-toolbar/src/ui/Dropdown.tsx
669
669
  const testId = fg('platform_editor_controls_patch_8') ? 'datasource-overflow-dropdown-trigger' : undefined;
670
- toolbarItems.push({
671
- type: 'separator',
672
- fullHeight: true
673
- });
670
+
671
+ // When canShowAppearanceSwitch is true, and platform_editor_controls is on, the link appearance dropdown shows, which includes a link preference button
672
+ // So only add the link appearance button when canShowAppearanceSwitch is false
673
+ if (!canShowAppearanceSwitch() && fg('platform_editor_controls_patch_12')) {
674
+ const linkPreferenceButton = getSettingsButton(intl, editorAnalyticsApi, cardOptions === null || cardOptions === void 0 ? void 0 : cardOptions.userPreferencesLink);
675
+ toolbarItems.push({
676
+ type: 'separator',
677
+ fullHeight: true
678
+ }, linkPreferenceButton, {
679
+ type: 'separator',
680
+ fullHeight: true
681
+ });
682
+ } else {
683
+ toolbarItems.push({
684
+ type: 'separator',
685
+ fullHeight: true
686
+ });
687
+ }
674
688
  const overflowMenuConfig = [{
675
689
  type: 'overflow-dropdown',
676
690
  testId,
@@ -12,11 +12,11 @@ import { linkToolbarMessages, cardMessages as messages } from '@atlaskit/editor-
12
12
  import { FloatingToolbarButton as Button, FloatingToolbarSeparator as Separator } from '@atlaskit/editor-common/ui';
13
13
  import { ArrowKeyNavigationType, DropdownContainer as UiDropdown } from '@atlaskit/editor-common/ui-menu';
14
14
  import EditIcon from '@atlaskit/icon/core/edit';
15
- import ChevronDownIcon from '@atlaskit/icon/utility/migration/chevron-down';
15
+ import ChevronDownIcon from '@atlaskit/icon/core/migration/chevron-down';
16
16
  import { ButtonItem } from '@atlaskit/menu';
17
17
  import { fg } from '@atlaskit/platform-feature-flags';
18
18
  import { Flex } from '@atlaskit/primitives/compiled';
19
- import { editorExperiment } from '@atlaskit/tmp-editor-statsig/experiments';
19
+ import { expValEqualsNoExposure } from '@atlaskit/tmp-editor-statsig/exp-val-equals-no-exposure';
20
20
  import { focusEditorView } from '../../pm-plugins/utils';
21
21
  import { editDatasource } from '../editDatasourceAction';
22
22
  var dropdownExpandContainer = css({
@@ -56,9 +56,11 @@ var EditToolbarButtonPresentation = function EditToolbarButtonPresentation(_ref)
56
56
  focusEditorView(editorView);
57
57
  }
58
58
  }, [currentAppearance, datasourceId, editorAnalyticsApi, editorView, extensionKey]);
59
- var icon = editorExperiment('platform_editor_controls', 'variant1') ? jsx(EditIcon, {
59
+ var isControlsOn = expValEqualsNoExposure('platform_editor_controls', 'cohort', 'variant1');
60
+ var icon = isControlsOn ? jsx(EditIcon, {
60
61
  label: ""
61
62
  }) : undefined;
63
+ var tooltipContent = isControlsOn && fg('platform_editor_controls_patch_13') ? intl.formatMessage(linkToolbarMessages.editLink) : undefined;
62
64
  switch (editVariant) {
63
65
  case 'edit-link':
64
66
  {
@@ -67,11 +69,12 @@ var EditToolbarButtonPresentation = function EditToolbarButtonPresentation(_ref)
67
69
  }, jsx(Button, {
68
70
  testId: "edit-link",
69
71
  onClick: onEditLink,
70
- icon: icon
71
- }, editorExperiment('platform_editor_controls', 'control') && jsx(FormattedMessage
72
+ icon: icon,
73
+ tooltipContent: tooltipContent
74
+ }, !isControlsOn && jsx(FormattedMessage
72
75
  // Ignored via go/ees005
73
76
  // eslint-disable-next-line react/jsx-props-no-spreading
74
- , linkToolbarMessages.editLink)), (!editorExperiment('platform_editor_controls', 'variant1') || !fg('platform_editor_controls_patch_6')) && jsx(Separator, null));
77
+ , linkToolbarMessages.editLink)), (!isControlsOn || !fg('platform_editor_controls_patch_6')) && jsx(Separator, null));
75
78
  }
76
79
  case 'edit-datasource':
77
80
  {
@@ -84,7 +87,7 @@ var EditToolbarButtonPresentation = function EditToolbarButtonPresentation(_ref)
84
87
  }, jsx(FormattedMessage
85
88
  // Ignored via go/ees005
86
89
  // eslint-disable-next-line react/jsx-props-no-spreading
87
- , linkToolbarMessages.editDatasourceStandalone)), (!editorExperiment('platform_editor_controls', 'variant1') || !fg('platform_editor_controls_patch_6')) && jsx(Separator, null));
90
+ , linkToolbarMessages.editDatasourceStandalone)), (!isControlsOn || !fg('platform_editor_controls_patch_6')) && jsx(Separator, null));
88
91
  }
89
92
  case 'edit-dropdown':
90
93
  {
@@ -95,7 +98,8 @@ var EditToolbarButtonPresentation = function EditToolbarButtonPresentation(_ref)
95
98
  iconAfter: jsx("span", {
96
99
  css: dropdownExpandContainer
97
100
  }, jsx(ChevronDownIcon, {
98
- label: intl.formatMessage(messages.editDropdownTriggerTitle)
101
+ label: intl.formatMessage(messages.editDropdownTriggerTitle),
102
+ size: "small"
99
103
  })),
100
104
  onClick: toggleOpen,
101
105
  selected: isOpen,
@@ -104,7 +108,7 @@ var EditToolbarButtonPresentation = function EditToolbarButtonPresentation(_ref)
104
108
  }, jsx(FormattedMessage
105
109
  // Ignored via go/ees005
106
110
  // eslint-disable-next-line react/jsx-props-no-spreading
107
- , messages.editDropdownTriggerTitle)), (!editorExperiment('platform_editor_controls', 'variant1') || !fg('platform_editor_controls_patch_6')) && jsx(Separator, null));
111
+ , messages.editDropdownTriggerTitle)), (!isControlsOn || !fg('platform_editor_controls_patch_6')) && jsx(Separator, null));
108
112
  return jsx(Flex, {
109
113
  ref: containerRef
110
114
  }, jsx(UiDropdown, {
@@ -13,7 +13,7 @@ import { FormattedMessage } from 'react-intl-next';
13
13
  import { linkToolbarMessages, cardMessages as messages } from '@atlaskit/editor-common/messages';
14
14
  import { FloatingToolbarButton as Button, FloatingToolbarSeparator as Separator } from '@atlaskit/editor-common/ui';
15
15
  import { ArrowKeyNavigationType, DropdownContainer as UiDropdown } from '@atlaskit/editor-common/ui-menu';
16
- import ChevronDownIcon from '@atlaskit/icon/utility/migration/chevron-down';
16
+ import ChevronDownIcon from '@atlaskit/icon/core/migration/chevron-down';
17
17
  import { useSmartLinkContext } from '@atlaskit/link-provider';
18
18
  import { ButtonItem } from '@atlaskit/menu';
19
19
  import { fg } from '@atlaskit/platform-feature-flags';
@@ -123,7 +123,8 @@ var EditToolbarButtonWithCardContext = function EditToolbarButtonWithCardContext
123
123
  iconAfter: jsx("span", {
124
124
  css: dropdownExpandContainer
125
125
  }, jsx(ChevronDownIcon, {
126
- label: intl.formatMessage(messages.editDropdownTriggerTitle)
126
+ label: intl.formatMessage(messages.editDropdownTriggerTitle),
127
+ size: "small"
127
128
  })),
128
129
  onClick: toggleOpen,
129
130
  selected: isOpen,
@@ -5,7 +5,7 @@ import React, { useEffect, useRef, useState } from 'react';
5
5
  import { appearancePropsMap } from '@atlaskit/editor-common/card';
6
6
  import { FloatingToolbarButton as Button, FloatingToolbarSeparator as Separator } from '@atlaskit/editor-common/ui';
7
7
  import { ArrowKeyNavigationType, DropdownContainer as UiDropdown } from '@atlaskit/editor-common/ui-menu';
8
- import ChevronDownIcon from '@atlaskit/icon/utility/migration/chevron-down';
8
+ import ChevronDownIcon from '@atlaskit/icon/core/migration/chevron-down';
9
9
  import { fg } from '@atlaskit/platform-feature-flags';
10
10
  import { Flex } from '@atlaskit/primitives/compiled';
11
11
  import { LinkAppearanceMenu } from './LinkToolbarAppearanceDropdown';
@@ -167,7 +167,8 @@ var CustomHyperlinkDropdown = function CustomHyperlinkDropdown(props) {
167
167
  }),
168
168
  iconAfter: /*#__PURE__*/React.createElement(ChevronDownIcon, {
169
169
  label: "",
170
- spacing: "compact"
170
+ spacing: "compact",
171
+ size: "small"
171
172
  })
172
173
  }, title);
173
174
  return /*#__PURE__*/React.createElement(Flex, {
@@ -665,10 +665,24 @@ var getDatasourceButtonGroup = function getDatasourceButtonGroup(metadata, intl,
665
665
  // testId is required to show focus on trigger button on ESC key press
666
666
  // see hideOnEsc in platform/packages/editor/editor-plugin-floating-toolbar/src/ui/Dropdown.tsx
667
667
  var testId = fg('platform_editor_controls_patch_8') ? 'datasource-overflow-dropdown-trigger' : undefined;
668
- toolbarItems.push({
669
- type: 'separator',
670
- fullHeight: true
671
- });
668
+
669
+ // When canShowAppearanceSwitch is true, and platform_editor_controls is on, the link appearance dropdown shows, which includes a link preference button
670
+ // So only add the link appearance button when canShowAppearanceSwitch is false
671
+ if (!canShowAppearanceSwitch() && fg('platform_editor_controls_patch_12')) {
672
+ var linkPreferenceButton = getSettingsButton(intl, editorAnalyticsApi, cardOptions === null || cardOptions === void 0 ? void 0 : cardOptions.userPreferencesLink);
673
+ toolbarItems.push({
674
+ type: 'separator',
675
+ fullHeight: true
676
+ }, linkPreferenceButton, {
677
+ type: 'separator',
678
+ fullHeight: true
679
+ });
680
+ } else {
681
+ toolbarItems.push({
682
+ type: 'separator',
683
+ fullHeight: true
684
+ });
685
+ }
672
686
  var overflowMenuConfig = [{
673
687
  type: 'overflow-dropdown',
674
688
  testId: testId,
package/package.json CHANGED
@@ -1,6 +1,6 @@
1
1
  {
2
2
  "name": "@atlaskit/editor-plugin-card",
3
- "version": "6.6.2",
3
+ "version": "6.6.4",
4
4
  "description": "Card plugin for @atlaskit/editor-core",
5
5
  "author": "Atlassian Pty Ltd",
6
6
  "license": "Apache-2.0",
@@ -61,9 +61,9 @@
61
61
  "@atlaskit/menu": "^8.0.0",
62
62
  "@atlaskit/platform-feature-flags": "^1.1.0",
63
63
  "@atlaskit/primitives": "^14.8.0",
64
- "@atlaskit/smart-card": "^38.8.0",
64
+ "@atlaskit/smart-card": "^38.9.0",
65
65
  "@atlaskit/theme": "^18.0.0",
66
- "@atlaskit/tmp-editor-statsig": "^6.0.0",
66
+ "@atlaskit/tmp-editor-statsig": "^6.1.0",
67
67
  "@atlaskit/tokens": "^5.1.0",
68
68
  "@babel/runtime": "^7.0.0",
69
69
  "@emotion/react": "^11.7.1",
@@ -141,6 +141,9 @@
141
141
  "platform_editor_controls_patch_9": {
142
142
  "type": "boolean"
143
143
  },
144
+ "platform_editor_controls_patch_12": {
145
+ "type": "boolean"
146
+ },
144
147
  "smart_link_editor_update_toolbar_open_link": {
145
148
  "type": "boolean"
146
149
  },
@@ -158,6 +161,9 @@
158
161
  },
159
162
  "platform_editor_cards_maxcallstackfix": {
160
163
  "type": "boolean"
164
+ },
165
+ "platform_editor_controls_patch_13": {
166
+ "type": "boolean"
161
167
  }
162
168
  },
163
169
  "stricter": {