@atlaskit/editor-plugin-card 6.1.1 → 6.1.3

package/CHANGELOG.md

@@ -1,5 +1,20 @@
 # @atlaskit/editor-plugin-card
 
+## 6.1.3
+
+### Patch Changes
+
+- [#150558](https://bitbucket.org/atlassian/atlassian-frontend-monorepo/pull-requests/150558)
+  [`2b8be3c33b348`](https://bitbucket.org/atlassian/atlassian-frontend-monorepo/commits/2b8be3c33b348) -
+  ED-27612: prevent infinite loop on card delete
+- Updated dependencies
+
+## 6.1.2
+
+### Patch Changes
+
+- Updated dependencies
+
 ## 6.1.1
 
 ### Patch Changes

package/compass.yml

@@ -0,0 +1,40 @@
+name: '@atlaskit/editor-plugin-card'
+description: |-
+  This is an editor plugin for Atlassian's rich text editor that enables support for "smart cards" and advanced linking features within the editor. It integrates with the Atlassian linking platform to allow users to insert, display, and interact with rich link previews (smart cards) directly in the editor surface.
+  This plugin is typically consumed via `@atlaskit/editor-core` as a plugin dependency and is essential for products that require embedding and managing smart links in their content.
+configVersion: 1
+typeId: LIBRARY
+ownerId: 'ari:cloud:identity::team/9683a6ac-2d3f-44c8-a0fe-56128ca69e20'
+fields:
+  tier: 4
+  lifecycle: Active
+  isMonorepoProject: true
+labels:
+  - atlassian-platform
+links:
+  - name: Bandicoots
+    type: PROJECT
+    url: 'https://product-fabric.atlassian.net/jira/software/c/projects/EDM/boards/5176'
+  - name: '#help-twg-linking-platform'
+    type: CHAT_CHANNEL
+    url: 'https://atlassian.enterprise.slack.com/archives/CFKGAQZRV'
+  - name: 'On-Call Schedule'
+    type: ON_CALL
+    url: 'https://atlassian.app.opsgenie.com/settings/schedule/detail/b9c8b313-dd6d-4a41-8eeb-d7a9df55be9d'
+  - name: source code
+    type: REPOSITORY
+    url: 'https://bitbucket.org/atlassian/atlassian-frontend/src/master/packages/editor/editor-plugin-card'
+customFields:
+  - name: 'FinOps_COGS_Cost_Center'
+    type: single_select
+    value: 'a681c808-9c58-45e5-9b3a-b5cc330c4b3a'
+  - name: 'FinOps_R&D_Cost_Center'
+    type: single_select
+    value: 'd9c71b12-1c77-4c68-a769-ba0e26bc8cac'
+  - name: 'FinOps_Service_Group'
+    type: single_select
+    value: '9120e03c-440b-489d-ac42-07903a2c611d'
+  - name: 'business-unit'
+    type: text
+    value: 'Eng - X Product Collab'
+relationships: {}

package/dist/cjs/nodeviews/blockCard.js

@@ -18,6 +18,7 @@ var _v = _interopRequireDefault(require("uuid/v4"));
 var _reactNodeView = _interopRequireDefault(require("@atlaskit/editor-common/react-node-view"));
 var _ui = require("@atlaskit/editor-common/ui");
 var _utils = require("@atlaskit/editor-common/utils");
+var _platformFeatureFlags = require("@atlaskit/platform-feature-flags");
 var _smartCard = require("@atlaskit/smart-card");
 var _datasource = require("../nodeviews/datasource");
 var _actions = require("../pm-plugins/actions");
@@ -125,6 +126,7 @@ var BlockCard = exports.BlockCard = /*#__PURE__*/function (_ReactNodeView) {
     (0, _defineProperty2.default)(_this2, "updateContentEditable", function (editorViewModeState, divElement) {
       divElement.contentEditable = (editorViewModeState === null || editorViewModeState === void 0 ? void 0 : editorViewModeState.mode) === 'view' ? 'false' : 'true';
     });
+    (0, _defineProperty2.default)(_this2, "removeCardDispatched", false);
     return _this2;
   }
   (0, _inherits2.default)(BlockCard, _ReactNodeView);
@@ -190,6 +192,10 @@ var BlockCard = exports.BlockCard = /*#__PURE__*/function (_ReactNodeView) {
   }, {
     key: "removeCard",
     value: function removeCard() {
+      if (this.removeCardDispatched && (0, _platformFeatureFlags.fg)('platform_editor_cards_maxcallstackfix')) {
+        return;
+      }
+      this.removeCardDispatched = true;
       var tr = this.view.state.tr;
       (0, _actions.removeCard)({
         id: this.id

package/dist/cjs/nodeviews/embedCard.js

@@ -23,6 +23,7 @@ var _ui = require("@atlaskit/editor-common/ui");
 var _useSharedPluginStateSelector = require("@atlaskit/editor-common/use-shared-plugin-state-selector");
 var _utils = require("@atlaskit/editor-common/utils");
 var _editorSharedStyles = require("@atlaskit/editor-shared-styles");
+var _platformFeatureFlags = require("@atlaskit/platform-feature-flags");
 var _smartCard = require("@atlaskit/smart-card");
 var _actions = require("../pm-plugins/actions");
 var _ResizableEmbedCard = _interopRequireDefault(require("../ui/ResizableEmbedCard"));
@@ -364,6 +365,7 @@ var EmbedCard = exports.EmbedCard = /*#__PURE__*/function (_ReactNodeView) {
     (0, _defineProperty2.default)(_this2, "updateContentEditable", function (editorViewModeState, divElement) {
       divElement.contentEditable = (editorViewModeState === null || editorViewModeState === void 0 ? void 0 : editorViewModeState.mode) === 'view' ? 'false' : 'true';
     });
+    (0, _defineProperty2.default)(_this2, "removeCardDispatched", false);
     return _this2;
   }
   (0, _inherits2.default)(EmbedCard, _ReactNodeView);
@@ -424,6 +426,10 @@ var EmbedCard = exports.EmbedCard = /*#__PURE__*/function (_ReactNodeView) {
   }, {
     key: "removeCard",
     value: function removeCard() {
+      if (this.removeCardDispatched && (0, _platformFeatureFlags.fg)('platform_editor_cards_maxcallstackfix')) {
+        return;
+      }
+      this.removeCardDispatched = true;
       var tr = this.view.state.tr;
       (0, _actions.removeCard)({
         id: this.id

package/dist/es2019/nodeviews/blockCard.js

@@ -5,6 +5,7 @@ import uuid from 'uuid/v4';
 import ReactNodeView from '@atlaskit/editor-common/react-node-view';
 import { findOverflowScrollParent, UnsupportedBlock } from '@atlaskit/editor-common/ui';
 import { browser, canRenderDatasource } from '@atlaskit/editor-common/utils';
+import { fg } from '@atlaskit/platform-feature-flags';
 import { Card as SmartCard } from '@atlaskit/smart-card';
 import { Datasource } from '../nodeviews/datasource';
 import { registerCard, removeCard } from '../pm-plugins/actions';
@@ -104,6 +105,7 @@ export class BlockCard extends ReactNodeView {
     _defineProperty(this, "updateContentEditable", (editorViewModeState, divElement) => {
       divElement.contentEditable = (editorViewModeState === null || editorViewModeState === void 0 ? void 0 : editorViewModeState.mode) === 'view' ? 'false' : 'true';
     });
+    _defineProperty(this, "removeCardDispatched", false);
   }
   createDomRef() {
     var _this$reactComponentP, _this$reactComponentP2, _this$reactComponentP3, _this$reactComponentP4;
@@ -152,6 +154,10 @@ export class BlockCard extends ReactNodeView {
     this.removeCard();
   }
   removeCard() {
+    if (this.removeCardDispatched && fg('platform_editor_cards_maxcallstackfix')) {
+      return;
+    }
+    this.removeCardDispatched = true;
     const {
       tr
     } = this.view.state;

package/dist/es2019/nodeviews/embedCard.js

@@ -10,6 +10,7 @@ import { findOverflowScrollParent, MediaSingle as RichMediaWrapper, UnsupportedB
 import { useSharedPluginStateSelector } from '@atlaskit/editor-common/use-shared-plugin-state-selector';
 import { floatingLayouts, isRichMediaInsideOfBlockNode } from '@atlaskit/editor-common/utils';
 import { DEFAULT_EMBED_CARD_HEIGHT, DEFAULT_EMBED_CARD_WIDTH } from '@atlaskit/editor-shared-styles';
+import { fg } from '@atlaskit/platform-feature-flags';
 import { EmbedResizeMessageListener, Card as SmartCard } from '@atlaskit/smart-card';
 import { registerCard, removeCard } from '../pm-plugins/actions';
 import ResizableEmbedCard from '../ui/ResizableEmbedCard';
@@ -352,6 +353,7 @@ export class EmbedCard extends ReactNodeView {
     _defineProperty(this, "updateContentEditable", (editorViewModeState, divElement) => {
       divElement.contentEditable = (editorViewModeState === null || editorViewModeState === void 0 ? void 0 : editorViewModeState.mode) === 'view' ? 'false' : 'true';
     });
+    _defineProperty(this, "removeCardDispatched", false);
   }
   viewShouldUpdate(nextNode) {
     if (this.node.attrs !== nextNode.attrs) {
@@ -398,6 +400,10 @@ export class EmbedCard extends ReactNodeView {
     this.removeCard();
   }
   removeCard() {
+    if (this.removeCardDispatched && fg('platform_editor_cards_maxcallstackfix')) {
+      return;
+    }
+    this.removeCardDispatched = true;
     const {
       tr
     } = this.view.state;

package/dist/esm/nodeviews/blockCard.js

@@ -14,6 +14,7 @@ import uuid from 'uuid/v4';
 import ReactNodeView from '@atlaskit/editor-common/react-node-view';
 import { findOverflowScrollParent, UnsupportedBlock } from '@atlaskit/editor-common/ui';
 import { browser, canRenderDatasource } from '@atlaskit/editor-common/utils';
+import { fg } from '@atlaskit/platform-feature-flags';
 import { Card as SmartCard } from '@atlaskit/smart-card';
 import { Datasource } from '../nodeviews/datasource';
 import { registerCard, removeCard as _removeCard } from '../pm-plugins/actions';
@@ -119,6 +120,7 @@ export var BlockCard = /*#__PURE__*/function (_ReactNodeView) {
     _defineProperty(_this2, "updateContentEditable", function (editorViewModeState, divElement) {
       divElement.contentEditable = (editorViewModeState === null || editorViewModeState === void 0 ? void 0 : editorViewModeState.mode) === 'view' ? 'false' : 'true';
     });
+    _defineProperty(_this2, "removeCardDispatched", false);
     return _this2;
   }
   _inherits(BlockCard, _ReactNodeView);
@@ -184,6 +186,10 @@ export var BlockCard = /*#__PURE__*/function (_ReactNodeView) {
   }, {
     key: "removeCard",
     value: function removeCard() {
+      if (this.removeCardDispatched && fg('platform_editor_cards_maxcallstackfix')) {
+        return;
+      }
+      this.removeCardDispatched = true;
       var tr = this.view.state.tr;
       _removeCard({
         id: this.id

package/dist/esm/nodeviews/embedCard.js

@@ -21,6 +21,7 @@ import { findOverflowScrollParent, MediaSingle as RichMediaWrapper, UnsupportedB
 import { useSharedPluginStateSelector } from '@atlaskit/editor-common/use-shared-plugin-state-selector';
 import { floatingLayouts, isRichMediaInsideOfBlockNode } from '@atlaskit/editor-common/utils';
 import { DEFAULT_EMBED_CARD_HEIGHT, DEFAULT_EMBED_CARD_WIDTH } from '@atlaskit/editor-shared-styles';
+import { fg } from '@atlaskit/platform-feature-flags';
 import { EmbedResizeMessageListener, Card as SmartCard } from '@atlaskit/smart-card';
 import { registerCard, removeCard as _removeCard } from '../pm-plugins/actions';
 import ResizableEmbedCard from '../ui/ResizableEmbedCard';
@@ -357,6 +358,7 @@ export var EmbedCard = /*#__PURE__*/function (_ReactNodeView) {
     _defineProperty(_this2, "updateContentEditable", function (editorViewModeState, divElement) {
       divElement.contentEditable = (editorViewModeState === null || editorViewModeState === void 0 ? void 0 : editorViewModeState.mode) === 'view' ? 'false' : 'true';
     });
+    _defineProperty(_this2, "removeCardDispatched", false);
     return _this2;
   }
   _inherits(EmbedCard, _ReactNodeView);
@@ -417,6 +419,10 @@ export var EmbedCard = /*#__PURE__*/function (_ReactNodeView) {
   }, {
     key: "removeCard",
     value: function removeCard() {
+      if (this.removeCardDispatched && fg('platform_editor_cards_maxcallstackfix')) {
+        return;
+      }
+      this.removeCardDispatched = true;
       var tr = this.view.state.tr;
       _removeCard({
         id: this.id

package/dist/types/nodeviews/blockCard.d.ts

@@ -32,6 +32,7 @@ export declare class BlockCard extends ReactNodeView<BlockCardNodeViewProps> {
     update(node: Node, decorations: ReadonlyArray<Decoration>, _innerDecorations?: DecorationSource): boolean;
     render(): React.JSX.Element;
     destroy(): void;
+    private removeCardDispatched;
     private removeCard;
 }
 export interface BlockCardNodeViewProperties {

package/dist/types/nodeviews/embedCard.d.ts

@@ -49,6 +49,7 @@ export declare class EmbedCard extends ReactNodeView<EmbedCardNodeViewProps> {
     private updateContentEditable;
     render(): React.JSX.Element;
     destroy(): void;
+    private removeCardDispatched;
     private removeCard;
 }
 export interface EmbedCardNodeViewProperties {

package/dist/types/ui/OpenButtonOverlay/types.d.ts

@@ -1,6 +1,6 @@
 /// <reference types="react" />
 import type { EditorAnalyticsAPI } from '@atlaskit/editor-common/analytics';
-import { EditorAppearance } from '@atlaskit/editor-common/types';
+import type { EditorAppearance } from '@atlaskit/editor-common/types';
 import type { EditorView } from '@atlaskit/editor-prosemirror/view';
 export type OpenButtonOverlayProps = React.HTMLAttributes<HTMLSpanElement> & {
     isVisible?: boolean;

package/dist/types-ts4.5/nodeviews/blockCard.d.ts

@@ -32,6 +32,7 @@ export declare class BlockCard extends ReactNodeView<BlockCardNodeViewProps> {
     update(node: Node, decorations: ReadonlyArray<Decoration>, _innerDecorations?: DecorationSource): boolean;
     render(): React.JSX.Element;
     destroy(): void;
+    private removeCardDispatched;
     private removeCard;
 }
 export interface BlockCardNodeViewProperties {

package/dist/types-ts4.5/nodeviews/embedCard.d.ts

@@ -49,6 +49,7 @@ export declare class EmbedCard extends ReactNodeView<EmbedCardNodeViewProps> {
     private updateContentEditable;
     render(): React.JSX.Element;
     destroy(): void;
+    private removeCardDispatched;
     private removeCard;
 }
 export interface EmbedCardNodeViewProperties {

package/dist/types-ts4.5/ui/OpenButtonOverlay/types.d.ts

@@ -1,6 +1,6 @@
 /// <reference types="react" />
 import type { EditorAnalyticsAPI } from '@atlaskit/editor-common/analytics';
-import { EditorAppearance } from '@atlaskit/editor-common/types';
+import type { EditorAppearance } from '@atlaskit/editor-common/types';
 import type { EditorView } from '@atlaskit/editor-prosemirror/view';
 export type OpenButtonOverlayProps = React.HTMLAttributes<HTMLSpanElement> & {
     isVisible?: boolean;

package/package.json

@@ -1,6 +1,6 @@
 {
 	"name": "@atlaskit/editor-plugin-card",
-	"version": "6.1.1",
+	"version": "6.1.3",
 	"description": "Card plugin for @atlaskit/editor-core",
 	"author": "Atlassian Pty Ltd",
 	"license": "Apache-2.0",
@@ -35,9 +35,9 @@
 	"dependencies": {
 		"@atlaskit/adf-schema": "^47.6.0",
 		"@atlaskit/analytics-next": "^11.0.0",
-		"@atlaskit/button": "^23.0.0",
+		"@atlaskit/button": "^23.2.0",
 		"@atlaskit/custom-steps": "^0.11.0",
-		"@atlaskit/editor-common": "^105.5.0",
+		"@atlaskit/editor-common": "^105.6.0",
 		"@atlaskit/editor-plugin-analytics": "^2.3.0",
 		"@atlaskit/editor-plugin-base": "^3.0.0",
 		"@atlaskit/editor-plugin-connectivity": "^2.0.0",
@@ -51,19 +51,19 @@
 		"@atlaskit/editor-prosemirror": "7.0.0",
 		"@atlaskit/editor-shared-styles": "^3.4.0",
 		"@atlaskit/frontend-utilities": "^3.0.0",
-		"@atlaskit/icon": "^26.0.0",
+		"@atlaskit/icon": "^26.1.0",
 		"@atlaskit/link-analytics": "^10.0.0",
 		"@atlaskit/link-client-extension": "^5.0.0",
 		"@atlaskit/link-datasource": "^4.10.0",
 		"@atlaskit/linking-common": "^9.0.0",
 		"@atlaskit/linking-types": "^9.10.0",
-		"@atlaskit/menu": "^6.0.0",
+		"@atlaskit/menu": "^7.1.0",
 		"@atlaskit/platform-feature-flags": "^1.1.0",
-		"@atlaskit/primitives": "^14.7.0",
-		"@atlaskit/smart-card": "^38.1.0",
+		"@atlaskit/primitives": "^14.8.0",
+		"@atlaskit/smart-card": "^38.2.0",
 		"@atlaskit/theme": "^18.0.0",
 		"@atlaskit/tmp-editor-statsig": "^4.22.0",
-		"@atlaskit/tokens": "^4.8.0",
+		"@atlaskit/tokens": "^4.9.0",
 		"@babel/runtime": "^7.0.0",
 		"@emotion/react": "^11.7.1",
 		"lodash": "^4.17.21",
@@ -157,6 +157,9 @@
 		},
 		"prompt_whiteboard_competitor_link_gate": {
 			"type": "boolean"
+		},
+		"platform_editor_cards_maxcallstackfix": {
+			"type": "boolean"
 		}
 	},
 	"stricter": {