@atlaskit/editor-plugin-card 33.0.5 → 34.0.1

package/CHANGELOG.md

@@ -1,5 +1,23 @@
 # @atlaskit/editor-plugin-card
 
+## 34.0.1
+
+### Patch Changes
+
+- [`fc2f6ea92bf86`](https://bitbucket.org/atlassian/atlassian-frontend-monorepo/commits/fc2f6ea92bf86) -
+  Behind `platform_editor_reduce_memory_leaks`: stop retaining deleted inline and block cards.
+  Pending `registerCard` animation frames are cancelled on unmount, resolve-request cancel callbacks
+  are dropped once they fire, the `removeOverlay` callback is cleared when its card is removed and
+  no longer closes over the node view scope, and the inline card overlay cancels its resize debounce
+  on cleanup.
+- Updated dependencies
+
+## 34.0.0
+
+### Patch Changes
+
+- Updated dependencies
+
 ## 33.0.5
 
 ### Patch Changes

package/dist/cjs/nodeviews/blockCard.js

@@ -51,7 +51,7 @@ var BlockCardComponent = exports.BlockCardComponent = /*#__PURE__*/function (_Re
 
       // don't dispatch immediately since we might be in the middle of
       // rendering a nodeview
-      (0, _rafSchd.default)(function () {
+      var scheduleRegisterCard = (0, _rafSchd.default)(function () {
         var pos = getPos();
         if (typeof pos !== 'number') {
           return;
@@ -62,7 +62,11 @@ var BlockCardComponent = exports.BlockCardComponent = /*#__PURE__*/function (_Re
           pos: pos,
           id: _this.props.id
         })(view.state.tr));
-      })();
+      });
+      if ((0, _isExperimentEnabled.isExperimentEnabled)('platform_editor_reduce_memory_leaks')) {
+        _this.pendingRegisterCard = scheduleRegisterCard;
+      }
+      scheduleRegisterCard();
     });
     (0, _defineProperty2.default)(_this, "removeCardDispatched", false);
     (0, _defineProperty2.default)(_this, "gapCursorSpan", function () {
@@ -94,6 +98,11 @@ var BlockCardComponent = exports.BlockCardComponent = /*#__PURE__*/function (_Re
   return (0, _createClass2.default)(BlockCardComponent, [{
     key: "componentWillUnmount",
     value: function componentWillUnmount() {
+      if ((0, _isExperimentEnabled.isExperimentEnabled)('platform_editor_reduce_memory_leaks')) {
+        var _this$pendingRegister;
+        (_this$pendingRegister = this.pendingRegisterCard) === null || _this$pendingRegister === void 0 || _this$pendingRegister.cancel();
+        this.pendingRegisterCard = undefined;
+      }
       this.removeCard();
     }
   }, {

package/dist/cjs/nodeviews/inlineCardBase.js

@@ -43,6 +43,16 @@ var InlineCard = exports.InlineCard = /*#__PURE__*/(0, _react.memo)(function (_r
   // eslint-disable-next-line @atlaskit/platform/prefer-crypto-random-uuid -- Use crypto.randomUUID instead
   var refId = (0, _react.useRef)((0, _uuid.v4)());
   var removeCardDispatched = (0, _react.useRef)(false);
+  var pendingRegisterCard = (0, _react.useRef)(null);
+  (0, _react.useEffect)(function () {
+    return function () {
+      if ((0, _isExperimentEnabled.isExperimentEnabled)('platform_editor_reduce_memory_leaks')) {
+        var _pendingRegisterCard$;
+        (_pendingRegisterCard$ = pendingRegisterCard.current) === null || _pendingRegisterCard$ === void 0 || _pendingRegisterCard$.cancel();
+        pendingRegisterCard.current = null;
+      }
+    };
+  }, []);
   var _ref2 = (cardContext === null || cardContext === void 0 || (_cardContext$value = cardContext.value) === null || _cardContext$value === void 0 ? void 0 : _cardContext$value.store) || {},
     getSmartlinkState = _ref2.getState;
   var cardState = getSmartlinkState === null || getSmartlinkState === void 0 ? void 0 : getSmartlinkState()[url || ''];
@@ -74,7 +84,7 @@ var InlineCard = exports.InlineCard = /*#__PURE__*/(0, _react.memo)(function (_r
       url = data.url;
     // don't dispatch immediately since we might be in the middle of
     // rendering a nodeview
-    (0, _rafSchd.default)(function () {
+    var scheduleRegisterCard = (0, _rafSchd.default)(function () {
       // prosemirror-bump-fix
       var pos = getPos();
       if (typeof pos !== 'number') {
@@ -89,7 +99,11 @@ var InlineCard = exports.InlineCard = /*#__PURE__*/(0, _react.memo)(function (_r
       })(tr);
       onRes === null || onRes === void 0 || onRes(tr, title);
       view.dispatch(tr);
-    })();
+    });
+    if ((0, _isExperimentEnabled.isExperimentEnabled)('platform_editor_reduce_memory_leaks')) {
+      pendingRegisterCard.current = scheduleRegisterCard;
+    }
+    scheduleRegisterCard();
   }, [getPos, view, onRes]);
   var onError = (0, _react.useCallback)(function (data) {
     var url = data.url,

package/dist/cjs/nodeviews/inlineCardWithAwareness.js

@@ -14,6 +14,7 @@ var _useSharedPluginStateWithSelector = require("@atlaskit/editor-common/useShar
 var _state = require("@atlaskit/editor-prosemirror/state");
 var _extractSmartLinkEmbed = require("@atlaskit/link-extractors/extract-smart-link-embed");
 var _isWithinPreviewPanelIframe = require("@atlaskit/linking-common/utils/is-within-preview-panel-iframe");
+var _isExperimentEnabled = require("@atlaskit/platform-feature-experiments/is-experiment-enabled");
 var _smartCard = require("@atlaskit/smart-card");
 var _useSmartLinkDestinationUrl = require("@atlaskit/smart-card/hook/use-smart-link-destination-url");
 var _expValEquals = require("@atlaskit/tmp-editor-statsig/exp-val-equals");
@@ -23,6 +24,14 @@ var _AwarenessWrapper = require("../ui/AwarenessWrapper");
 var _PreviewInvoker = require("../ui/preview/PreviewInvoker");
 var _inlineCardBase = require("./inlineCardBase");
 function _interopRequireWildcard(e, t) { if ("function" == typeof WeakMap) var r = new WeakMap(), n = new WeakMap(); return (_interopRequireWildcard = function _interopRequireWildcard(e, t) { if (!t && e && e.__esModule) return e; var o, i, f = { __proto__: null, default: e }; if (null === e || "object" != _typeof(e) && "function" != typeof e) return f; if (o = t ? n : r) { if (o.has(e)) return o.get(e); o.set(e, f); } for (var _t in e) "default" !== _t && {}.hasOwnProperty.call(e, _t) && ((i = (o = Object.defineProperty) && Object.getOwnPropertyDescriptor(e, _t)) && (i.get || i.set) ? o(f, _t, i) : f[_t] = e[_t]); return f; })(e, t); }
+// Module scope so the stored callback's closure chain cannot reach the
+// component scope (getPos, node, view) via V8 context sharing.
+var createRemoveOverlay = function createRemoveOverlay(setIsInsertedRef) {
+  return function () {
+    var _setIsInsertedRef$cur;
+    return (_setIsInsertedRef$cur = setIsInsertedRef.current) === null || _setIsInsertedRef$cur === void 0 ? void 0 : _setIsInsertedRef$cur.call(setIsInsertedRef, false);
+  };
+};
 var selector = function selector(states) {
   var _states$editorViewMod, _states$selectionStat;
   return {
@@ -54,6 +63,14 @@ var InlineCardWithAwareness = exports.InlineCardWithAwareness = /*#__PURE__*/(0,
     _useState4 = (0, _slicedToArray2.default)(_useState3, 2),
     isInserted = _useState4[0],
     setIsInserted = _useState4[1];
+  var setIsInsertedRef = (0, _react.useRef)(setIsInserted);
+  (0, _react.useEffect)(function () {
+    return function () {
+      if ((0, _isExperimentEnabled.isExperimentEnabled)('platform_editor_reduce_memory_leaks')) {
+        setIsInsertedRef.current = undefined;
+      }
+    };
+  }, []);
   var _useState5 = (0, _react.useState)(false),
     _useState6 = (0, _slicedToArray2.default)(_useState5, 2),
     isResolvedViewRendered = _useState6[0],
@@ -62,14 +79,13 @@ var InlineCardWithAwareness = exports.InlineCardWithAwareness = /*#__PURE__*/(0,
   var destinationUrl = (0, _useSmartLinkDestinationUrl.useSmartLinkDestinationUrl)(node.attrs.url);
   var onResolve = (0, _react.useCallback)(function (tr, title) {
     var metadata = tr.getMeta(_pluginKey.pluginKey);
+    var removeOverlay = (0, _isExperimentEnabled.isExperimentEnabled)('platform_editor_reduce_memory_leaks') ? createRemoveOverlay(setIsInsertedRef) : function () {
+      return setIsInserted(false);
+    };
     if (metadata && metadata.type === 'REGISTER') {
-      (0, _actions.registerRemoveOverlay)(function () {
-        return setIsInserted(false);
-      }, metadata.info)(tr);
+      (0, _actions.registerRemoveOverlay)(removeOverlay, metadata.info)(tr);
     } else {
-      (0, _actions.registerRemoveOverlay)(function () {
-        return setIsInserted(false);
-      })(tr);
+      (0, _actions.registerRemoveOverlay)(removeOverlay)(tr);
     }
     if (title) {
       setIsResolvedViewRendered(true);

package/dist/cjs/pm-plugins/main.js

@@ -15,6 +15,7 @@ var _smartCard = require("@atlaskit/editor-common/styles/smartCard");
 var _state = require("@atlaskit/editor-prosemirror/state");
 var _utils = require("@atlaskit/editor-prosemirror/utils");
 var _constants = require("@atlaskit/linking-common/constants");
+var _isExperimentEnabled = require("@atlaskit/platform-feature-experiments/is-experiment-enabled");
 var _blockCard = require("../nodeviews/blockCard");
 var _embedCard = require("../nodeviews/embedCard");
 var _inlineCard = require("../nodeviews/inlineCard");
@@ -239,7 +240,13 @@ var createPlugin = exports.createPlugin = function createPlugin(options, pluginI
                  */
                 var invoke = (0, _rafSchd.default)(function () {
                   var _pluginInjectionApi$a, _pluginInjectionApi$a2, _pluginInjectionApi$a3, _currentState$embedCa;
-                  return (0, _resolve.resolveWithProvider)(view, _provider, request, options, pluginInjectionApi === null || pluginInjectionApi === void 0 || (_pluginInjectionApi$a = pluginInjectionApi.analytics) === null || _pluginInjectionApi$a === void 0 ? void 0 : _pluginInjectionApi$a.actions, (_pluginInjectionApi$a2 = pluginInjectionApi === null || pluginInjectionApi === void 0 || (_pluginInjectionApi$a3 = pluginInjectionApi.analytics) === null || _pluginInjectionApi$a3 === void 0 || (_pluginInjectionApi$a3 = _pluginInjectionApi$a3.sharedState.currentState()) === null || _pluginInjectionApi$a3 === void 0 ? void 0 : _pluginInjectionApi$a3.createAnalyticsEvent) !== null && _pluginInjectionApi$a2 !== void 0 ? _pluginInjectionApi$a2 : undefined, currentState === null || currentState === void 0 || (_currentState$embedCa = currentState.embedCardTransformers) === null || _currentState$embedCa === void 0 ? void 0 : _currentState$embedCa.embedCardNodeTransformer);
+                  if ((0, _isExperimentEnabled.isExperimentEnabled)('platform_editor_reduce_memory_leaks')) {
+                    var index = rafCancellationCallbacks.indexOf(invoke.cancel);
+                    if (index !== -1) {
+                      rafCancellationCallbacks.splice(index, 1);
+                    }
+                  }
+                  (0, _resolve.resolveWithProvider)(view, _provider, request, options, pluginInjectionApi === null || pluginInjectionApi === void 0 || (_pluginInjectionApi$a = pluginInjectionApi.analytics) === null || _pluginInjectionApi$a === void 0 ? void 0 : _pluginInjectionApi$a.actions, (_pluginInjectionApi$a2 = pluginInjectionApi === null || pluginInjectionApi === void 0 || (_pluginInjectionApi$a3 = pluginInjectionApi.analytics) === null || _pluginInjectionApi$a3 === void 0 || (_pluginInjectionApi$a3 = _pluginInjectionApi$a3.sharedState.currentState()) === null || _pluginInjectionApi$a3 === void 0 ? void 0 : _pluginInjectionApi$a3.createAnalyticsEvent) !== null && _pluginInjectionApi$a2 !== void 0 ? _pluginInjectionApi$a2 : undefined, currentState === null || currentState === void 0 || (_currentState$embedCa = currentState.embedCardTransformers) === null || _currentState$embedCa === void 0 ? void 0 : _currentState$embedCa.embedCardNodeTransformer);
                 });
                 rafCancellationCallbacks.push(invoke.cancel);
                 invoke();

package/dist/cjs/pm-plugins/reducers.js

@@ -8,6 +8,7 @@ Object.defineProperty(exports, "__esModule", {
 exports.default = void 0;
 var _objectWithoutProperties2 = _interopRequireDefault(require("@babel/runtime/helpers/objectWithoutProperties"));
 var _defineProperty2 = _interopRequireDefault(require("@babel/runtime/helpers/defineProperty"));
+var _isExperimentEnabled = require("@atlaskit/platform-feature-experiments/is-experiment-enabled");
 function _toPropertyKey(t) { var i = _toPrimitive(t, "string"); return "symbol" == _typeof(i) ? i : i + ""; }
 function _toPrimitive(t, r) { if ("object" != _typeof(t) || !t) return t; var e = t[Symbol.toPrimitive]; if (void 0 !== e) { var i = e.call(t, r || "default"); if ("object" != _typeof(i)) return i; throw new TypeError("@@toPrimitive must return a primitive value."); } return ("string" === r ? String : Number)(t); }
 function ownKeys(e, r) { var t = Object.keys(e); if (Object.getOwnPropertySymbols) { var o = Object.getOwnPropertySymbols(e); r && (o = o.filter(function (r) { return Object.getOwnPropertyDescriptor(e, r).enumerable; })), t.push.apply(t, o); } return t; }
@@ -36,10 +37,18 @@ var register = function register(state, action) {
   });
 };
 var removeCard = function removeCard(state, action) {
+  var cards = state.cards.filter(function (card) {
+    return card.id !== action.info.id;
+  });
+  if ((0, _isExperimentEnabled.isExperimentEnabled)('platform_editor_reduce_memory_leaks') && state.removeOverlayCardId !== undefined && state.removeOverlayCardId === action.info.id) {
+    return _objectSpread(_objectSpread({}, state), {}, {
+      cards: cards,
+      removeOverlay: undefined,
+      removeOverlayCardId: undefined
+    });
+  }
   return _objectSpread(_objectSpread({}, state), {}, {
-    cards: state.cards.filter(function (card) {
-      return card.id !== action.info.id;
-    })
+    cards: cards
   });
 };
 var setProvider = function setProvider(state, action) {
@@ -91,18 +100,28 @@ var hideDatasourceModal = function hideDatasourceModal(state) {
   });
 };
 var clearOverlayCandidate = function clearOverlayCandidate(state) {
+  if ((0, _isExperimentEnabled.isExperimentEnabled)('platform_editor_reduce_memory_leaks')) {
+    return _objectSpread(_objectSpread({}, state), {}, {
+      overlayCandidatePosition: undefined,
+      removeOverlay: undefined,
+      removeOverlayCardId: undefined
+    });
+  }
   return _objectSpread(_objectSpread({}, state), {}, {
     overlayCandidatePosition: undefined
   });
 };
 var registerRemoveOverlayOnInsertedLink = function registerRemoveOverlayOnInsertedLink(state, action) {
+  var _action$info2;
   return _objectSpread(_objectSpread({}, state), {}, {
     cards: action.info ? state.cards.filter(function (card) {
       var _action$info;
       return card.pos !== ((_action$info = action.info) === null || _action$info === void 0 ? void 0 : _action$info.pos);
     }).concat(action.info) : state.cards,
     removeOverlay: action.callback
-  });
+  }, (0, _isExperimentEnabled.isExperimentEnabled)('platform_editor_reduce_memory_leaks') ? {
+    removeOverlayCardId: (_action$info2 = action.info) === null || _action$info2 === void 0 ? void 0 : _action$info2.id
+  } : {});
 };
 var setDatasourceStash = function setDatasourceStash(state, action) {
   return _objectSpread(_objectSpread({}, state), {}, {

package/dist/cjs/ui/DatasourceAppearanceButton.js

@@ -13,7 +13,7 @@ var _datasource = require("@atlaskit/editor-common/utils/datasource");
 var _state = require("@atlaskit/editor-prosemirror/state");
 var _schema = require("@atlaskit/link-datasource/utils/schema");
 var _useSmartLinkContext = require("@atlaskit/link-provider/use-smart-link-context");
-var _compiled = require("@atlaskit/primitives/compiled");
+var _flex = require("@atlaskit/primitives/compiled/flex");
 var _doc = require("../pm-plugins/doc");
 var _pluginKey = require("../pm-plugins/plugin-key");
 var _DatasourceIcon = require("./DatasourceIcon");
@@ -95,7 +95,7 @@ var DatasourceAppearanceButtonWithCardContext = function DatasourceAppearanceBut
     }
   }
   var buttonLabel = intl.formatMessage(_card.messages.datasourceAppearanceTitle);
-  return (0, _react2.jsx)(_compiled.Flex, null, (0, _react2.jsx)(_Button.default, {
+  return (0, _react2.jsx)(_flex.Flex, null, (0, _react2.jsx)(_Button.default, {
     css: buttonStyles,
     title: buttonLabel,
     icon: (0, _react2.jsx)(_DatasourceIcon.DatasourceIcon, {

package/dist/cjs/ui/EditToolbarButton/EditToolbarButtonPresentation.js

@@ -18,7 +18,7 @@ var _DropdownContainer = require("@atlaskit/editor-common/ui-menu/DropdownContai
 var _chevronDown = _interopRequireDefault(require("@atlaskit/icon/core/chevron-down"));
 var _edit = _interopRequireDefault(require("@atlaskit/icon/core/edit"));
 var _buttonItem = _interopRequireDefault(require("@atlaskit/menu/button-item"));
-var _compiled = require("@atlaskit/primitives/compiled");
+var _flex = require("@atlaskit/primitives/compiled/flex");
 var _utils = require("../../pm-plugins/utils");
 var _editDatasourceAction = require("../editDatasourceAction");
 /**
@@ -73,7 +73,7 @@ var EditToolbarButtonPresentation = function EditToolbarButtonPresentation(_ref)
   switch (editVariant) {
     case 'edit-link':
       {
-        return (0, _react2.jsx)(_compiled.Flex, {
+        return (0, _react2.jsx)(_flex.Flex, {
           gap: "space.050"
         }, (0, _react2.jsx)(_Button.default, {
           testId: "edit-link",
@@ -91,7 +91,7 @@ var EditToolbarButtonPresentation = function EditToolbarButtonPresentation(_ref)
       }
     case 'edit-datasource':
       {
-        return (0, _react2.jsx)(_compiled.Flex, {
+        return (0, _react2.jsx)(_flex.Flex, {
           gap: "space.050"
         }, (0, _react2.jsx)(_Button.default, {
           testId: "edit-datasource",
@@ -107,7 +107,7 @@ var EditToolbarButtonPresentation = function EditToolbarButtonPresentation(_ref)
       }
     case 'edit-dropdown':
       {
-        var trigger = (0, _react2.jsx)(_compiled.Flex, {
+        var trigger = (0, _react2.jsx)(_flex.Flex, {
           gap: "space.050"
         }, (0, _react2.jsx)(_Button.default, {
           testId: "edit-dropdown-trigger",
@@ -128,7 +128,7 @@ var EditToolbarButtonPresentation = function EditToolbarButtonPresentation(_ref)
         , _card.messages.editDropdownTriggerTitle)), !areAnyNewToolbarFlagsEnabled && (0, _react2.jsx)(_Separator.default, {
           areAnyNewToolbarFlagsEnabled: false
         }));
-        return (0, _react2.jsx)(_compiled.Flex, {
+        return (0, _react2.jsx)(_flex.Flex, {
           ref: containerRef
         }, (0, _react2.jsx)(_DropdownContainer.DropdownContainer, {
           mountTo: containerRef.current,

package/dist/cjs/ui/EditToolbarButton/index.js

@@ -19,7 +19,7 @@ var _DropdownContainer = require("@atlaskit/editor-common/ui-menu/DropdownContai
 var _chevronDown = _interopRequireDefault(require("@atlaskit/icon/core/chevron-down"));
 var _useSmartLinkContext = require("@atlaskit/link-provider/use-smart-link-context");
 var _buttonItem = _interopRequireDefault(require("@atlaskit/menu/button-item"));
-var _compiled = require("@atlaskit/primitives/compiled");
+var _flex = require("@atlaskit/primitives/compiled/flex");
 var _editorExperiment = require("@atlaskit/tmp-editor-statsig/editor-experiment");
 var _utils = require("../../pm-plugins/utils");
 var _editDatasourceAction = require("../editDatasourceAction");
@@ -100,7 +100,7 @@ var EditToolbarButtonWithCardContext = function EditToolbarButtonWithCardContext
   switch (editVariant) {
     case 'edit-link':
       {
-        return (0, _react2.jsx)(_compiled.Flex, {
+        return (0, _react2.jsx)(_flex.Flex, {
           gap: "space.050"
         }, (0, _react2.jsx)(_Button.default, {
           testId: "edit-link",
@@ -115,7 +115,7 @@ var EditToolbarButtonWithCardContext = function EditToolbarButtonWithCardContext
       }
     case 'edit-datasource':
       {
-        return (0, _react2.jsx)(_compiled.Flex, {
+        return (0, _react2.jsx)(_flex.Flex, {
           gap: "space.050"
         }, (0, _react2.jsx)(_Button.default, {
           testId: "edit-datasource",
@@ -131,7 +131,7 @@ var EditToolbarButtonWithCardContext = function EditToolbarButtonWithCardContext
       }
     case 'edit-dropdown':
       {
-        var trigger = (0, _react2.jsx)(_compiled.Flex, {
+        var trigger = (0, _react2.jsx)(_flex.Flex, {
           gap: "space.050"
         }, (0, _react2.jsx)(_Button.default, {
           testId: "edit-dropdown-trigger",
@@ -152,7 +152,7 @@ var EditToolbarButtonWithCardContext = function EditToolbarButtonWithCardContext
         , _card.messages.editDropdownTriggerTitle)), !(0, _editorExperiment.editorExperiment)('platform_editor_controls', 'variant1') && (0, _react2.jsx)(_Separator.default, {
           areAnyNewToolbarFlagsEnabled: false
         }));
-        return (0, _react2.jsx)(_compiled.Flex, {
+        return (0, _react2.jsx)(_flex.Flex, {
           ref: containerRef
         }, (0, _react2.jsx)(_DropdownContainer.DropdownContainer, {
           mountTo: containerRef.current,

package/dist/cjs/ui/HyperlinkToolbarAppearance.js

@@ -13,7 +13,7 @@ var _react = _interopRequireWildcard(require("react"));
 var _enums = require("@atlaskit/editor-common/analytics/types/enums");
 var _Separator = _interopRequireDefault(require("@atlaskit/editor-common/FloatingToolbar/Separator"));
 var _toolbarFlagCheck = require("@atlaskit/editor-common/toolbar-flag-check");
-var _compiled = require("@atlaskit/primitives/compiled");
+var _flex = require("@atlaskit/primitives/compiled/flex");
 var _DatasourceAppearanceButton = require("./DatasourceAppearanceButton");
 var _LinkToolbarAppearance = require("./LinkToolbarAppearance");
 function _interopRequireWildcard(e, t) { if ("function" == typeof WeakMap) var r = new WeakMap(), n = new WeakMap(); return (_interopRequireWildcard = function _interopRequireWildcard(e, t) { if (!t && e && e.__esModule) return e; var o, i, f = { __proto__: null, default: e }; if (null === e || "object" != _typeof(e) && "function" != typeof e) return f; if (o = t ? n : r) { if (o.has(e)) return o.get(e); o.set(e, f); } for (var _t5 in e) "default" !== _t5 && {}.hasOwnProperty.call(e, _t5) && ((i = (o = Object.defineProperty) && Object.getOwnPropertyDescriptor(e, _t5)) && (i.get || i.set) ? o(f, _t5, i) : f[_t5] = e[_t5]); return f; })(e, t); }
@@ -138,7 +138,7 @@ function HyperlinkToolbarAppearance(props) {
     return null;
   }
   var areAnyNewToolbarFlagsEnabled = (0, _toolbarFlagCheck.areToolbarFlagsEnabled)(Boolean((_props$editorPluginAp2 = props.editorPluginApi) === null || _props$editorPluginAp2 === void 0 ? void 0 : _props$editorPluginAp2.toolbar));
-  return /*#__PURE__*/_react.default.createElement(_compiled.Flex, null, /*#__PURE__*/_react.default.createElement(_LinkToolbarAppearance.LinkToolbarAppearance, {
+  return /*#__PURE__*/_react.default.createElement(_flex.Flex, null, /*#__PURE__*/_react.default.createElement(_LinkToolbarAppearance.LinkToolbarAppearance, {
     key: "link-appearance",
     url: url,
     intl: intl,

package/dist/cjs/ui/HyperlinkToolbarAppearanceDropdown.js

@@ -17,7 +17,7 @@ var _toolbarFlagCheck = require("@atlaskit/editor-common/toolbar-flag-check");
 var _types = require("@atlaskit/editor-common/ui-menu/ArrowKeyNavigationProvider/types");
 var _DropdownContainer = require("@atlaskit/editor-common/ui-menu/DropdownContainer");
 var _chevronDown = _interopRequireDefault(require("@atlaskit/icon/core/chevron-down"));
-var _compiled = require("@atlaskit/primitives/compiled");
+var _flex = require("@atlaskit/primitives/compiled/flex");
 var _LinkToolbarAppearanceDropdown = require("./LinkToolbarAppearanceDropdown");
 function _interopRequireWildcard(e, t) { if ("function" == typeof WeakMap) var r = new WeakMap(), n = new WeakMap(); return (_interopRequireWildcard = function _interopRequireWildcard(e, t) { if (!t && e && e.__esModule) return e; var o, i, f = { __proto__: null, default: e }; if (null === e || "object" != _typeof(e) && "function" != typeof e) return f; if (o = t ? n : r) { if (o.has(e)) return o.get(e); o.set(e, f); } for (var _t5 in e) "default" !== _t5 && {}.hasOwnProperty.call(e, _t5) && ((i = (o = Object.defineProperty) && Object.getOwnPropertyDescriptor(e, _t5)) && (i.get || i.set) ? o(f, _t5, i) : f[_t5] = e[_t5]); return f; })(e, t); }
 var CustomHyperlinkDropdown = function CustomHyperlinkDropdown(props) {
@@ -185,7 +185,7 @@ var CustomHyperlinkDropdown = function CustomHyperlinkDropdown(props) {
     }),
     areAnyNewToolbarFlagsEnabled: areAnyNewToolbarFlagsEnabled
   }, title);
-  return /*#__PURE__*/_react.default.createElement(_compiled.Flex, {
+  return /*#__PURE__*/_react.default.createElement(_flex.Flex, {
     ref: containerRef,
     gap: "space.075"
   }, /*#__PURE__*/_react.default.createElement(_DropdownContainer.DropdownContainer, {

package/dist/cjs/ui/InlineCardOverlay/index.js

@@ -17,6 +17,7 @@ var _reactIntl = require("react-intl");
 var _card = require("@atlaskit/editor-common/messages/card");
 var _whitespace = require("@atlaskit/editor-common/whitespace/whitespace");
 var _customize = _interopRequireDefault(require("@atlaskit/icon/core/customize"));
+var _isExperimentEnabled = require("@atlaskit/platform-feature-experiments/is-experiment-enabled");
 var _useSmartLinkDestinationUrl = require("@atlaskit/smart-card/hook/use-smart-link-destination-url");
 var _utils = require("./utils");
 var _excluded = ["children", "isSelected", "isVisible", "testId", "url"];
@@ -221,6 +222,9 @@ var InlineCardOverlay = function InlineCardOverlay(_ref) {
     observer.observe(parent);
     return function () {
       observer.disconnect();
+      if ((0, _isExperimentEnabled.isExperimentEnabled)('platform_editor_reduce_memory_leaks')) {
+        updateOverlay.cancel();
+      }
     };
   }, [isVisible, setVisibility]);
   var destinationUrl = (_useSmartLinkDestinat = (0, _useSmartLinkDestinationUrl.useSmartLinkDestinationUrl)(url)) !== null && _useSmartLinkDestinat !== void 0 ? _useSmartLinkDestinat : url;

package/dist/cjs/ui/OpenPreviewButton/index.js

@@ -13,7 +13,9 @@ var _link = require("@atlaskit/editor-common/messages/link");
 var _panelRight = _interopRequireDefault(require("@atlaskit/icon/core/panel-right"));
 var _extractSmartLinkEmbed = require("@atlaskit/link-extractors/extract-smart-link-embed");
 var _useSmartLinkContext2 = require("@atlaskit/link-provider/use-smart-link-context");
-var _compiled = require("@atlaskit/primitives/compiled");
+var _box = require("@atlaskit/primitives/compiled/box");
+var _flex = require("@atlaskit/primitives/compiled/flex");
+var _inline = require("@atlaskit/primitives/compiled/inline");
 var _smartCard = require("@atlaskit/smart-card");
 var _expValEquals = require("@atlaskit/tmp-editor-statsig/exp-val-equals");
 var _utils = require("../../pm-plugins/utils");
@@ -71,24 +73,24 @@ var OpenPreviewPanelToolbarButton = exports.OpenPreviewPanelToolbarButton = func
     /*#__PURE__*/
     // This is a hack required for Jira until areToolbarFlagsEnabled are enabled to ensure the icon has padding
     // Padding is removed when areToolbarFlagsEnabled for a button with icon only in platform/packages/editor/editor-common/src/ui/FloatingToolbar/Button.tsx
-    _react.default.createElement(_compiled.Inline, {
+    _react.default.createElement(_inline.Inline, {
       as: "span",
       space: "space.050",
       alignBlock: "center"
-    }, /*#__PURE__*/_react.default.createElement(_compiled.Box, {
+    }, /*#__PURE__*/_react.default.createElement(_box.Box, {
       as: "span",
       "aria-hidden": true,
       role: "presentation"
     }), /*#__PURE__*/_react.default.createElement(_panelRight.default, {
       label: "",
       spacing: "spacious"
-    }), /*#__PURE__*/_react.default.createElement(_compiled.Box, {
+    }), /*#__PURE__*/_react.default.createElement(_box.Box, {
       as: "span",
       "aria-hidden": true,
       role: "presentation"
     }));
     if (openPreviewPanel && isPanelAvailable) {
-      return /*#__PURE__*/_react.default.createElement(_compiled.Flex, {
+      return /*#__PURE__*/_react.default.createElement(_flex.Flex, {
         gap: "space.050"
       }, /*#__PURE__*/_react.default.createElement(_Button.default, {
         testId: "open-preview-panel-floating-toolbar-button",

package/dist/cjs/ui/PasteDisplayAsMenu.js

@@ -30,7 +30,9 @@ var _smartLinkCard = _interopRequireDefault(require("@atlaskit/icon/core/smart-l
 var _smartLinkEmbed = _interopRequireDefault(require("@atlaskit/icon/core/smart-link-embed"));
 var _smartLinkInline = _interopRequireDefault(require("@atlaskit/icon/core/smart-link-inline"));
 var _useSmartCardContext = require("@atlaskit/link-provider/use-smart-card-context");
-var _compiled = require("@atlaskit/primitives/compiled");
+var _box = require("@atlaskit/primitives/compiled/box");
+var _flex = require("@atlaskit/primitives/compiled/flex");
+var _pressable = require("@atlaskit/primitives/compiled/pressable");
 var _expValEqualsNoExposure = require("@atlaskit/tmp-editor-statsig/exp-val-equals-no-exposure");
 var _doc = require("../pm-plugins/doc");
 var _currentPastedSmartLink = require("./currentPastedSmartLink");
@@ -62,12 +64,12 @@ var AppearanceOptionIconButton = function AppearanceOptionIconButton(_ref) {
     label = _ref.label,
     Icon = _ref.Icon,
     onClick = _ref.onClick;
-  return /*#__PURE__*/_react.default.createElement(_compiled.Box, {
+  return /*#__PURE__*/_react.default.createElement(_box.Box, {
     xcss: styles.iconWrapper
   }, /*#__PURE__*/_react.default.createElement(_toolbarTooltip.ToolbarTooltip, {
     content: label,
     position: "bottom"
-  }, /*#__PURE__*/_react.default.createElement(_compiled.Pressable, {
+  }, /*#__PURE__*/_react.default.createElement(_pressable.Pressable, {
     xcss: (0, _css.cx)(styles.iconButton, isDisabled && styles.iconButtonDisabled, !isDisabled && currentAppearance === appearance && styles.iconButtonSelected),
     "aria-label": label,
     "aria-pressed": currentAppearance === appearance,
@@ -344,7 +346,7 @@ var PasteDisplayAsMenuHorizontalView = function PasteDisplayAsMenuHorizontalView
   var isEmbedSupported =
   // Whatever was pasted already displays this way, so the option must stay selectable.
   currentAppearance === 'embed' || Boolean(isEmbedSupportedFromAppearanceContext || isEmbedSupportedFromSelection);
-  return /*#__PURE__*/_react.default.createElement(_compiled.Flex, {
+  return /*#__PURE__*/_react.default.createElement(_flex.Flex, {
     xcss: styles.appearanceBox,
     gap: "space.050"
   }, /*#__PURE__*/_react.default.createElement(AppearanceOptionIconButton, {

package/dist/es2019/nodeviews/blockCard.js

@@ -38,7 +38,7 @@ export class BlockCardComponent extends React.PureComponent {
 
       // don't dispatch immediately since we might be in the middle of
       // rendering a nodeview
-      rafSchedule(() => {
+      const scheduleRegisterCard = rafSchedule(() => {
         const pos = getPos();
         if (typeof pos !== 'number') {
           return;
@@ -49,7 +49,11 @@ export class BlockCardComponent extends React.PureComponent {
           pos,
           id: this.props.id
         })(view.state.tr));
-      })();
+      });
+      if (isExperimentEnabled('platform_editor_reduce_memory_leaks')) {
+        this.pendingRegisterCard = scheduleRegisterCard;
+      }
+      scheduleRegisterCard();
     });
     _defineProperty(this, "removeCardDispatched", false);
     _defineProperty(this, "gapCursorSpan", () => {
@@ -78,6 +82,11 @@ export class BlockCardComponent extends React.PureComponent {
     findOverflowScrollParent(props.view.dom) || undefined;
   }
   componentWillUnmount() {
+    if (isExperimentEnabled('platform_editor_reduce_memory_leaks')) {
+      var _this$pendingRegister;
+      (_this$pendingRegister = this.pendingRegisterCard) === null || _this$pendingRegister === void 0 ? void 0 : _this$pendingRegister.cancel();
+      this.pendingRegisterCard = undefined;
+    }
     this.removeCard();
   }
   removeCard() {

package/dist/es2019/nodeviews/inlineCardBase.js

@@ -35,6 +35,16 @@ export const InlineCard = /*#__PURE__*/memo(({
   // eslint-disable-next-line @atlaskit/platform/prefer-crypto-random-uuid -- Use crypto.randomUUID instead
   const refId = useRef(uuid());
   const removeCardDispatched = useRef(false);
+  const pendingRegisterCard = useRef(null);
+  useEffect(() => {
+    return () => {
+      if (isExperimentEnabled('platform_editor_reduce_memory_leaks')) {
+        var _pendingRegisterCard$;
+        (_pendingRegisterCard$ = pendingRegisterCard.current) === null || _pendingRegisterCard$ === void 0 ? void 0 : _pendingRegisterCard$.cancel();
+        pendingRegisterCard.current = null;
+      }
+    };
+  }, []);
   const {
     getState: getSmartlinkState
   } = (cardContext === null || cardContext === void 0 ? void 0 : (_cardContext$value = cardContext.value) === null || _cardContext$value === void 0 ? void 0 : _cardContext$value.store) || {};
@@ -69,7 +79,7 @@ export const InlineCard = /*#__PURE__*/memo(({
     } = data;
     // don't dispatch immediately since we might be in the middle of
     // rendering a nodeview
-    rafSchedule(() => {
+    const scheduleRegisterCard = rafSchedule(() => {
       // prosemirror-bump-fix
       const pos = getPos();
       if (typeof pos !== 'number') {
@@ -84,7 +94,11 @@ export const InlineCard = /*#__PURE__*/memo(({
       })(tr);
       onRes === null || onRes === void 0 ? void 0 : onRes(tr, title);
       view.dispatch(tr);
-    })();
+    });
+    if (isExperimentEnabled('platform_editor_reduce_memory_leaks')) {
+      pendingRegisterCard.current = scheduleRegisterCard;
+    }
+    scheduleRegisterCard();
   }, [getPos, view, onRes]);
   const onError = useCallback(data => {
     const {

package/dist/es2019/nodeviews/inlineCardWithAwareness.js

@@ -1,10 +1,11 @@
-import React, { memo, useCallback, useMemo, useState } from 'react';
+import React, { memo, useCallback, useEffect, useMemo, useRef, useState } from 'react';
 import { ACTION_SUBJECT_ID, EVENT_TYPE, ACTION, ACTION_SUBJECT } from '@atlaskit/editor-common/analytics/types/enums';
 import HoverLinkOverlay from '@atlaskit/editor-common/HoverLinkOverlay';
 import { useSharedPluginStateWithSelector } from '@atlaskit/editor-common/useSharedPluginStateWithSelector';
 import { NodeSelection } from '@atlaskit/editor-prosemirror/state';
 import { extractSmartLinkEmbed } from '@atlaskit/link-extractors/extract-smart-link-embed';
 import { isWithinPreviewPanelIFrame } from '@atlaskit/linking-common/utils/is-within-preview-panel-iframe';
+import { isExperimentEnabled } from '@atlaskit/platform-feature-experiments/is-experiment-enabled';
 import { getObjectAri, getObjectName, getObjectIconUrl } from '@atlaskit/smart-card';
 import { useSmartLinkDestinationUrl } from '@atlaskit/smart-card/hook/use-smart-link-destination-url';
 import { expValEquals } from '@atlaskit/tmp-editor-statsig/exp-val-equals';
@@ -13,6 +14,12 @@ import { pluginKey } from '../pm-plugins/plugin-key';
 import { AwarenessWrapper } from '../ui/AwarenessWrapper';
 import { PreviewInvoker } from '../ui/preview/PreviewInvoker';
 import { InlineCard } from './inlineCardBase';
+// Module scope so the stored callback's closure chain cannot reach the
+// component scope (getPos, node, view) via V8 context sharing.
+const createRemoveOverlay = setIsInsertedRef => () => {
+  var _setIsInsertedRef$cur;
+  return (_setIsInsertedRef$cur = setIsInsertedRef.current) === null || _setIsInsertedRef$cur === void 0 ? void 0 : _setIsInsertedRef$cur.call(setIsInsertedRef, false);
+};
 const selector = states => {
   var _states$editorViewMod, _states$selectionStat;
   return {
@@ -39,15 +46,24 @@ export const InlineCardWithAwareness = /*#__PURE__*/memo(({
   var _pluginInjectionApi$c;
   const [isHovered, setIsHovered] = useState(false);
   const [isInserted, setIsInserted] = useState(false);
+  const setIsInsertedRef = useRef(setIsInserted);
+  useEffect(() => {
+    return () => {
+      if (isExperimentEnabled('platform_editor_reduce_memory_leaks')) {
+        setIsInsertedRef.current = undefined;
+      }
+    };
+  }, []);
   const [isResolvedViewRendered, setIsResolvedViewRendered] = useState(false);
   const editorAppearance = pluginInjectionApi === null || pluginInjectionApi === void 0 ? void 0 : (_pluginInjectionApi$c = pluginInjectionApi.card.sharedState.currentState()) === null || _pluginInjectionApi$c === void 0 ? void 0 : _pluginInjectionApi$c.editorAppearance;
   const destinationUrl = useSmartLinkDestinationUrl(node.attrs.url);
   const onResolve = useCallback((tr, title) => {
     const metadata = tr.getMeta(pluginKey);
+    const removeOverlay = isExperimentEnabled('platform_editor_reduce_memory_leaks') ? createRemoveOverlay(setIsInsertedRef) : () => setIsInserted(false);
     if (metadata && metadata.type === 'REGISTER') {
-      registerRemoveOverlay(() => setIsInserted(false), metadata.info)(tr);
+      registerRemoveOverlay(removeOverlay, metadata.info)(tr);
     } else {
-      registerRemoveOverlay(() => setIsInserted(false))(tr);
+      registerRemoveOverlay(removeOverlay)(tr);
     }
     if (title) {
       setIsResolvedViewRendered(true);

package/dist/es2019/pm-plugins/main.js

@@ -6,6 +6,7 @@ import { DATASOURCE_INNER_CONTAINER_CLASSNAME } from '@atlaskit/editor-common/st
 import { NodeSelection } from '@atlaskit/editor-prosemirror/state';
 import { findDomRefAtPos } from '@atlaskit/editor-prosemirror/utils';
 import { DATASOURCE_DEFAULT_LAYOUT } from '@atlaskit/linking-common/constants';
+import { isExperimentEnabled } from '@atlaskit/platform-feature-experiments/is-experiment-enabled';
 import { blockCardNodeView } from '../nodeviews/blockCard';
 import { embedCardNodeView } from '../nodeviews/embedCard';
 import { InlineCardNodeView } from '../nodeviews/inlineCard';
@@ -236,7 +237,13 @@ export const createPlugin = (options, pluginInjectionApi) => pmPluginFactoryPara
                */
               const invoke = rafSchedule(() => {
                 var _pluginInjectionApi$a, _pluginInjectionApi$a2, _pluginInjectionApi$a3, _pluginInjectionApi$a4, _currentState$embedCa;
-                return resolveWithProvider(view, provider, request, options, pluginInjectionApi === null || pluginInjectionApi === void 0 ? void 0 : (_pluginInjectionApi$a = pluginInjectionApi.analytics) === null || _pluginInjectionApi$a === void 0 ? void 0 : _pluginInjectionApi$a.actions, (_pluginInjectionApi$a2 = pluginInjectionApi === null || pluginInjectionApi === void 0 ? void 0 : (_pluginInjectionApi$a3 = pluginInjectionApi.analytics) === null || _pluginInjectionApi$a3 === void 0 ? void 0 : (_pluginInjectionApi$a4 = _pluginInjectionApi$a3.sharedState.currentState()) === null || _pluginInjectionApi$a4 === void 0 ? void 0 : _pluginInjectionApi$a4.createAnalyticsEvent) !== null && _pluginInjectionApi$a2 !== void 0 ? _pluginInjectionApi$a2 : undefined, currentState === null || currentState === void 0 ? void 0 : (_currentState$embedCa = currentState.embedCardTransformers) === null || _currentState$embedCa === void 0 ? void 0 : _currentState$embedCa.embedCardNodeTransformer);
+                if (isExperimentEnabled('platform_editor_reduce_memory_leaks')) {
+                  const index = rafCancellationCallbacks.indexOf(invoke.cancel);
+                  if (index !== -1) {
+                    rafCancellationCallbacks.splice(index, 1);
+                  }
+                }
+                resolveWithProvider(view, provider, request, options, pluginInjectionApi === null || pluginInjectionApi === void 0 ? void 0 : (_pluginInjectionApi$a = pluginInjectionApi.analytics) === null || _pluginInjectionApi$a === void 0 ? void 0 : _pluginInjectionApi$a.actions, (_pluginInjectionApi$a2 = pluginInjectionApi === null || pluginInjectionApi === void 0 ? void 0 : (_pluginInjectionApi$a3 = pluginInjectionApi.analytics) === null || _pluginInjectionApi$a3 === void 0 ? void 0 : (_pluginInjectionApi$a4 = _pluginInjectionApi$a3.sharedState.currentState()) === null || _pluginInjectionApi$a4 === void 0 ? void 0 : _pluginInjectionApi$a4.createAnalyticsEvent) !== null && _pluginInjectionApi$a2 !== void 0 ? _pluginInjectionApi$a2 : undefined, currentState === null || currentState === void 0 ? void 0 : (_currentState$embedCa = currentState.embedCardTransformers) === null || _currentState$embedCa === void 0 ? void 0 : _currentState$embedCa.embedCardNodeTransformer);
               });
               rafCancellationCallbacks.push(invoke.cancel);
               invoke();