@atlaskit/editor-plugin-card 16.3.4 → 16.4.1

package/CHANGELOG.md

@@ -1,5 +1,28 @@
 # @atlaskit/editor-plugin-card
 
+## 16.4.1
+
+### Patch Changes
+
+- [`3a31723096050`](https://bitbucket.org/atlassian/atlassian-frontend-monorepo/commits/3a31723096050) -
+  Swap feature gate from `platform-native-embeds-short-link-expansion` to
+  `platform_native_embeds_rollout_non_maui_experience` for Confluence short-link URL expansion in
+  native embeds. This consolidates the short-link expansion behaviour under the existing non-MaUI
+  experience rollout gate.
+
+## 16.4.0
+
+### Minor Changes
+
+- [`aef936f5a23ea`](https://bitbucket.org/atlassian/atlassian-frontend-monorepo/commits/aef936f5a23ea) -
+  Rename the changeboard smart link drag-and-drop experiment from
+  `cc_dnd_smart_link_changeboard_po_template` to `cc_dnd_smart_link_changeboard_platform_css` across
+  the card plugin and editor statsig config.
+
+### Patch Changes
+
+- Updated dependencies
+
 ## 16.3.4
 
 ### Patch Changes

package/dist/cjs/nodeviews/genericCard.js

@@ -19,7 +19,6 @@ var _analyticsNext = require("@atlaskit/analytics-next");
 var _hooks = require("@atlaskit/editor-common/hooks");
 var _utils = require("@atlaskit/editor-common/utils");
 var _link = _interopRequireDefault(require("@atlaskit/link"));
-var _platformFeatureFlags = require("@atlaskit/platform-feature-flags");
 var _doc = require("../pm-plugins/doc");
 var _state = require("../pm-plugins/util/state");
 var _utils2 = require("../pm-plugins/utils");
@@ -95,21 +94,13 @@ function Card(SmartCardComponent, UnsupportedComponent) {
         }
         if (this.state.isError) {
           if (url) {
-            return (0, _platformFeatureFlags.fg)('dst-a11y__replace-anchor-with-link__linking-platfo') ? /*#__PURE__*/_react.default.createElement(_link.default, {
+            return /*#__PURE__*/_react.default.createElement(_link.default, {
               href: url
               // eslint-disable-next-line @atlassian/perf-linting/no-unstable-inline-props -- Ignored via go/ees017 (to be fixed)
               ,
               onClick: function onClick(e) {
                 e.preventDefault();
               }
-            }, url) :
-            /*#__PURE__*/
-            // eslint-disable-next-line @atlaskit/design-system/no-html-anchor
-            _react.default.createElement("a", {
-              href: url,
-              onClick: function onClick(e) {
-                e.preventDefault();
-              }
             }, url);
           } else {
             return /*#__PURE__*/_react.default.createElement(UnsupportedComponent, null);

package/dist/cjs/nodeviews/inlineCard.js

@@ -203,7 +203,7 @@ function InlineCardNodeView(props) {
     isPageSSRed = props.isPageSSRed,
     provider = props.provider,
     CompetitorPrompt = props.CompetitorPrompt;
-  var _useSharedPluginState = (0, _hooks.useSharedPluginStateWithSelector)(pluginInjectionApi, (0, _expVal.expValNoExposure)('cc_dnd_smart_link_changeboard_po_template', 'isEnabled', false) && (0, _platformFeatureFlags.fg)('cc_drag_and_drop_smart_link_from_content_to_tree') ? ['editorViewMode', 'card'] : ['editorViewMode'], (0, _expVal.expValNoExposure)('cc_dnd_smart_link_changeboard_po_template', 'isEnabled', false) && (0, _platformFeatureFlags.fg)('cc_drag_and_drop_smart_link_from_content_to_tree') ? selectorWithCard : selectorWithoutCard),
+  var _useSharedPluginState = (0, _hooks.useSharedPluginStateWithSelector)(pluginInjectionApi, (0, _expVal.expVal)('cc_dnd_smart_link_changeboard_platform_css', 'isEnabled', false) && (0, _platformFeatureFlags.fg)('cc_drag_and_drop_smart_link_from_content_to_tree') ? ['editorViewMode', 'card'] : ['editorViewMode'], (0, _expVal.expVal)('cc_dnd_smart_link_changeboard_platform_css', 'isEnabled', false) && (0, _platformFeatureFlags.fg)('cc_drag_and_drop_smart_link_from_content_to_tree') ? selectorWithCard : selectorWithoutCard),
     mode = _useSharedPluginState.mode,
     resolvedInlineSmartLinks = _useSharedPluginState.resolvedInlineSmartLinks;
   var url = node.attrs.url;

package/dist/cjs/pm-plugins/doc.js

@@ -80,7 +80,7 @@ var replaceQueuedUrlWithCard = exports.replaceQueuedUrlWithCard = function repla
 
     // If an embed card transformer is provided and the resolved card is an embedCard,
     // attempt to transform it into an alternative node representation first.
-    if (cardData.type === 'embedCard' && embedCardNodeTransformer && (0, _platformFeatureFlags.fg)('platform-native-embeds-short-link-expansion')) {
+    if (cardData.type === 'embedCard' && embedCardNodeTransformer && (0, _platformFeatureFlags.fg)('platform_native_embeds_rollout_non_maui_experience')) {
       var transformResult = embedCardNodeTransformer(schema, cardData.attrs);
       // The transformer may return a Promise for async transformations (e.g. short-link expansion).
       // When async, we snapshot the current requests and positions now (before any dispatch),

package/dist/cjs/pm-plugins/main.js

@@ -125,7 +125,7 @@ var createPlugin = exports.createPlugin = function createPlugin(options, pluginI
           var newState = (0, _reducers.default)(pluginStateWithUpdatedPos, meta);
 
           // Track the first resolved inline smart link for PO spotlight DOM targeting
-          if (meta.type === 'RESOLVE' && pluginState !== null && pluginState !== void 0 && (_pluginState$requests = pluginState.requests) !== null && _pluginState$requests !== void 0 && _pluginState$requests.length && (0, _expVal.expValNoExposure)('cc_dnd_smart_link_changeboard_po_template', 'isEnabled', false) && (0, _platformFeatureFlags.fg)('cc_drag_and_drop_smart_link_from_content_to_tree')) {
+          if (meta.type === 'RESOLVE' && pluginState !== null && pluginState !== void 0 && (_pluginState$requests = pluginState.requests) !== null && _pluginState$requests !== void 0 && _pluginState$requests.length && (0, _expVal.expVal)('cc_dnd_smart_link_changeboard_platform_css', 'isEnabled', false) && (0, _platformFeatureFlags.fg)('cc_drag_and_drop_smart_link_from_content_to_tree')) {
             var resolvedRequest = pluginState.requests.find(function (req) {
               return req.url === meta.url;
             });

package/dist/es2019/nodeviews/genericCard.js

@@ -6,7 +6,6 @@ import { AnalyticsContext } from '@atlaskit/analytics-next';
 import { useSharedPluginStateWithSelector } from '@atlaskit/editor-common/hooks';
 import { getAnalyticsEditorAppearance } from '@atlaskit/editor-common/utils';
 import Link from '@atlaskit/link';
-import { fg } from '@atlaskit/platform-feature-flags';
 import { changeSelectedCardToLinkFallback } from '../pm-plugins/doc';
 import { getPluginState } from '../pm-plugins/util/state';
 import { titleUrlPairFromNode } from '../pm-plugins/utils';
@@ -73,21 +72,13 @@ export function Card(SmartCardComponent, UnsupportedComponent) {
       }
       if (this.state.isError) {
         if (url) {
-          return fg('dst-a11y__replace-anchor-with-link__linking-platfo') ? /*#__PURE__*/React.createElement(Link, {
+          return /*#__PURE__*/React.createElement(Link, {
             href: url
             // eslint-disable-next-line @atlassian/perf-linting/no-unstable-inline-props -- Ignored via go/ees017 (to be fixed)
             ,
             onClick: e => {
               e.preventDefault();
             }
-          }, url) :
-          /*#__PURE__*/
-          // eslint-disable-next-line @atlaskit/design-system/no-html-anchor
-          React.createElement("a", {
-            href: url,
-            onClick: e => {
-              e.preventDefault();
-            }
           }, url);
         } else {
           return /*#__PURE__*/React.createElement(UnsupportedComponent, null);

package/dist/es2019/nodeviews/inlineCard.js

@@ -12,7 +12,7 @@ import { Card as SmartCard } from '@atlaskit/smart-card';
 import { CardSSR } from '@atlaskit/smart-card/ssr';
 import { expValEquals } from '@atlaskit/tmp-editor-statsig/exp-val-equals';
 import { editorExperiment } from '@atlaskit/tmp-editor-statsig/experiments';
-import { expValNoExposure } from '@atlaskit/tmp-editor-statsig/expVal';
+import { expVal } from '@atlaskit/tmp-editor-statsig/expVal';
 import { registerCard, removeCard } from '../pm-plugins/actions';
 import { getAwarenessProps } from '../pm-plugins/utils';
 import { visitCardLinkAnalytics } from '../ui/toolbar';
@@ -204,7 +204,7 @@ export function InlineCardNodeView(props) {
   const {
     mode,
     resolvedInlineSmartLinks
-  } = useSharedPluginStateWithSelector(pluginInjectionApi, expValNoExposure('cc_dnd_smart_link_changeboard_po_template', 'isEnabled', false) && fg('cc_drag_and_drop_smart_link_from_content_to_tree') ? ['editorViewMode', 'card'] : ['editorViewMode'], expValNoExposure('cc_dnd_smart_link_changeboard_po_template', 'isEnabled', false) && fg('cc_drag_and_drop_smart_link_from_content_to_tree') ? selectorWithCard : selectorWithoutCard);
+  } = useSharedPluginStateWithSelector(pluginInjectionApi, expVal('cc_dnd_smart_link_changeboard_platform_css', 'isEnabled', false) && fg('cc_drag_and_drop_smart_link_from_content_to_tree') ? ['editorViewMode', 'card'] : ['editorViewMode'], expVal('cc_dnd_smart_link_changeboard_platform_css', 'isEnabled', false) && fg('cc_drag_and_drop_smart_link_from_content_to_tree') ? selectorWithCard : selectorWithoutCard);
   const url = node.attrs.url;
   const CompetitorPromptComponent = CompetitorPrompt && url ? /*#__PURE__*/React.createElement(CompetitorPrompt, {
     sourceUrl: url,

package/dist/es2019/pm-plugins/doc.js

@@ -70,7 +70,7 @@ export const replaceQueuedUrlWithCard = (url, cardData, analyticsAction, editorA
 
   // If an embed card transformer is provided and the resolved card is an embedCard,
   // attempt to transform it into an alternative node representation first.
-  if (cardData.type === 'embedCard' && embedCardNodeTransformer && fg('platform-native-embeds-short-link-expansion')) {
+  if (cardData.type === 'embedCard' && embedCardNodeTransformer && fg('platform_native_embeds_rollout_non_maui_experience')) {
     const transformResult = embedCardNodeTransformer(schema, cardData.attrs);
     // The transformer may return a Promise for async transformations (e.g. short-link expansion).
     // When async, we snapshot the current requests and positions now (before any dispatch),

package/dist/es2019/pm-plugins/main.js

@@ -6,7 +6,7 @@ import { NodeSelection } from '@atlaskit/editor-prosemirror/state';
 import { findDomRefAtPos } from '@atlaskit/editor-prosemirror/utils';
 import { DATASOURCE_DEFAULT_LAYOUT } from '@atlaskit/linking-common';
 import { fg } from '@atlaskit/platform-feature-flags';
-import { expValNoExposure } from '@atlaskit/tmp-editor-statsig/expVal';
+import { expVal } from '@atlaskit/tmp-editor-statsig/expVal';
 import { InlineCardNodeView } from '../nodeviews/inlineCard';
 import { lazyBlockCardView } from '../nodeviews/lazy-block-card';
 import { lazyEmbedCardView } from '../nodeviews/lazy-embed-card';
@@ -116,7 +116,7 @@ export const createPlugin = (options, pluginInjectionApi) => pmPluginFactoryPara
         const newState = reducer(pluginStateWithUpdatedPos, meta);
 
         // Track the first resolved inline smart link for PO spotlight DOM targeting
-        if (meta.type === 'RESOLVE' && pluginState !== null && pluginState !== void 0 && (_pluginState$requests = pluginState.requests) !== null && _pluginState$requests !== void 0 && _pluginState$requests.length && expValNoExposure('cc_dnd_smart_link_changeboard_po_template', 'isEnabled', false) && fg('cc_drag_and_drop_smart_link_from_content_to_tree')) {
+        if (meta.type === 'RESOLVE' && pluginState !== null && pluginState !== void 0 && (_pluginState$requests = pluginState.requests) !== null && _pluginState$requests !== void 0 && _pluginState$requests.length && expVal('cc_dnd_smart_link_changeboard_platform_css', 'isEnabled', false) && fg('cc_drag_and_drop_smart_link_from_content_to_tree')) {
           const resolvedRequest = pluginState.requests.find(req => req.url === meta.url);
           if ((resolvedRequest === null || resolvedRequest === void 0 ? void 0 : resolvedRequest.appearance) === 'inline') {
             var _newState$resolvedInl, _newState$resolvedInl2;

package/dist/esm/nodeviews/genericCard.js

@@ -13,7 +13,6 @@ import { AnalyticsContext } from '@atlaskit/analytics-next';
 import { useSharedPluginStateWithSelector } from '@atlaskit/editor-common/hooks';
 import { getAnalyticsEditorAppearance } from '@atlaskit/editor-common/utils';
 import Link from '@atlaskit/link';
-import { fg } from '@atlaskit/platform-feature-flags';
 import { changeSelectedCardToLinkFallback } from '../pm-plugins/doc';
 import { getPluginState } from '../pm-plugins/util/state';
 import { titleUrlPairFromNode } from '../pm-plugins/utils';
@@ -86,21 +85,13 @@ export function Card(SmartCardComponent, UnsupportedComponent) {
         }
         if (this.state.isError) {
           if (url) {
-            return fg('dst-a11y__replace-anchor-with-link__linking-platfo') ? /*#__PURE__*/React.createElement(Link, {
+            return /*#__PURE__*/React.createElement(Link, {
               href: url
               // eslint-disable-next-line @atlassian/perf-linting/no-unstable-inline-props -- Ignored via go/ees017 (to be fixed)
               ,
               onClick: function onClick(e) {
                 e.preventDefault();
               }
-            }, url) :
-            /*#__PURE__*/
-            // eslint-disable-next-line @atlaskit/design-system/no-html-anchor
-            React.createElement("a", {
-              href: url,
-              onClick: function onClick(e) {
-                e.preventDefault();
-              }
             }, url);
           } else {
             return /*#__PURE__*/React.createElement(UnsupportedComponent, null);

package/dist/esm/nodeviews/inlineCard.js

@@ -12,7 +12,7 @@ import { Card as SmartCard } from '@atlaskit/smart-card';
 import { CardSSR } from '@atlaskit/smart-card/ssr';
 import { expValEquals } from '@atlaskit/tmp-editor-statsig/exp-val-equals';
 import { editorExperiment } from '@atlaskit/tmp-editor-statsig/experiments';
-import { expValNoExposure } from '@atlaskit/tmp-editor-statsig/expVal';
+import { expVal } from '@atlaskit/tmp-editor-statsig/expVal';
 import { registerCard, removeCard } from '../pm-plugins/actions';
 import { getAwarenessProps } from '../pm-plugins/utils';
 import { visitCardLinkAnalytics } from '../ui/toolbar';
@@ -191,7 +191,7 @@ export function InlineCardNodeView(props) {
     isPageSSRed = props.isPageSSRed,
     provider = props.provider,
     CompetitorPrompt = props.CompetitorPrompt;
-  var _useSharedPluginState = useSharedPluginStateWithSelector(pluginInjectionApi, expValNoExposure('cc_dnd_smart_link_changeboard_po_template', 'isEnabled', false) && fg('cc_drag_and_drop_smart_link_from_content_to_tree') ? ['editorViewMode', 'card'] : ['editorViewMode'], expValNoExposure('cc_dnd_smart_link_changeboard_po_template', 'isEnabled', false) && fg('cc_drag_and_drop_smart_link_from_content_to_tree') ? selectorWithCard : selectorWithoutCard),
+  var _useSharedPluginState = useSharedPluginStateWithSelector(pluginInjectionApi, expVal('cc_dnd_smart_link_changeboard_platform_css', 'isEnabled', false) && fg('cc_drag_and_drop_smart_link_from_content_to_tree') ? ['editorViewMode', 'card'] : ['editorViewMode'], expVal('cc_dnd_smart_link_changeboard_platform_css', 'isEnabled', false) && fg('cc_drag_and_drop_smart_link_from_content_to_tree') ? selectorWithCard : selectorWithoutCard),
     mode = _useSharedPluginState.mode,
     resolvedInlineSmartLinks = _useSharedPluginState.resolvedInlineSmartLinks;
   var url = node.attrs.url;

package/dist/esm/pm-plugins/doc.js

@@ -74,7 +74,7 @@ export var replaceQueuedUrlWithCard = function replaceQueuedUrlWithCard(url, car
 
     // If an embed card transformer is provided and the resolved card is an embedCard,
     // attempt to transform it into an alternative node representation first.
-    if (cardData.type === 'embedCard' && embedCardNodeTransformer && fg('platform-native-embeds-short-link-expansion')) {
+    if (cardData.type === 'embedCard' && embedCardNodeTransformer && fg('platform_native_embeds_rollout_non_maui_experience')) {
       var transformResult = embedCardNodeTransformer(schema, cardData.attrs);
       // The transformer may return a Promise for async transformations (e.g. short-link expansion).
       // When async, we snapshot the current requests and positions now (before any dispatch),

package/dist/esm/pm-plugins/main.js

@@ -10,7 +10,7 @@ import { NodeSelection } from '@atlaskit/editor-prosemirror/state';
 import { findDomRefAtPos } from '@atlaskit/editor-prosemirror/utils';
 import { DATASOURCE_DEFAULT_LAYOUT } from '@atlaskit/linking-common';
 import { fg } from '@atlaskit/platform-feature-flags';
-import { expValNoExposure } from '@atlaskit/tmp-editor-statsig/expVal';
+import { expVal } from '@atlaskit/tmp-editor-statsig/expVal';
 import { InlineCardNodeView } from '../nodeviews/inlineCard';
 import { lazyBlockCardView } from '../nodeviews/lazy-block-card';
 import { lazyEmbedCardView } from '../nodeviews/lazy-embed-card';
@@ -118,7 +118,7 @@ export var createPlugin = function createPlugin(options, pluginInjectionApi) {
           var newState = reducer(pluginStateWithUpdatedPos, meta);
 
           // Track the first resolved inline smart link for PO spotlight DOM targeting
-          if (meta.type === 'RESOLVE' && pluginState !== null && pluginState !== void 0 && (_pluginState$requests = pluginState.requests) !== null && _pluginState$requests !== void 0 && _pluginState$requests.length && expValNoExposure('cc_dnd_smart_link_changeboard_po_template', 'isEnabled', false) && fg('cc_drag_and_drop_smart_link_from_content_to_tree')) {
+          if (meta.type === 'RESOLVE' && pluginState !== null && pluginState !== void 0 && (_pluginState$requests = pluginState.requests) !== null && _pluginState$requests !== void 0 && _pluginState$requests.length && expVal('cc_dnd_smart_link_changeboard_platform_css', 'isEnabled', false) && fg('cc_drag_and_drop_smart_link_from_content_to_tree')) {
             var resolvedRequest = pluginState.requests.find(function (req) {
               return req.url === meta.url;
             });

package/package.json

@@ -1,6 +1,6 @@
 {
 	"name": "@atlaskit/editor-plugin-card",
-	"version": "16.3.4",
+	"version": "16.4.1",
 	"description": "Card plugin for @atlaskit/editor-core",
 	"author": "Atlassian Pty Ltd",
 	"license": "Apache-2.0",
@@ -62,7 +62,7 @@
 		"@atlaskit/primitives": "^19.0.0",
 		"@atlaskit/prosemirror-history": "^0.2.0",
 		"@atlaskit/smart-card": "^44.3.0",
-		"@atlaskit/tmp-editor-statsig": "^70.2.0",
+		"@atlaskit/tmp-editor-statsig": "^70.4.0",
 		"@atlaskit/tokens": "^13.0.0",
 		"@babel/runtime": "^7.0.0",
 		"@emotion/react": "^11.7.1",
@@ -72,7 +72,7 @@
 		"uuid": "^3.1.0"
 	},
 	"peerDependencies": {
-		"@atlaskit/editor-common": "^114.11.0",
+		"@atlaskit/editor-common": "^114.12.0",
 		"@atlaskit/link-provider": "^4.3.0",
 		"react": "^18.2.0",
 		"react-intl": "^5.25.1 || ^6.0.0 || ^7.0.0"
@@ -111,7 +111,7 @@
 		}
 	},
 	"platform-feature-flags": {
-		"platform-native-embeds-short-link-expansion": {
+		"platform_native_embeds_rollout_non_maui_experience": {
 			"type": "boolean"
 		},
 		"cc_drag_and_drop_smart_link_from_content_to_tree": {
@@ -120,9 +120,6 @@
 		"confluence-issue-terminology-refresh": {
 			"type": "boolean"
 		},
-		"dst-a11y__replace-anchor-with-link__linking-platfo": {
-			"type": "boolean"
-		},
 		"platform_editor_adf_with_localid": {
 			"type": "boolean"
 		},