@atlaskit/editor-plugin-card 13.0.1 → 13.0.3

package/CHANGELOG.md

@@ -1,5 +1,20 @@
 # @atlaskit/editor-plugin-card
 
+## 13.0.3
+
+### Patch Changes
+
+- Updated dependencies
+
+## 13.0.2
+
+### Patch Changes
+
+- [`14aa7871be0b7`](https://bitbucket.org/atlassian/atlassian-frontend-monorepo/commits/14aa7871be0b7) -
+  [ux] EDITOR-5513: fix(editor-plugin-card): guard inline card cleanup to dispatch removeCard at
+  most once per effect cycle
+- Updated dependencies
+
 ## 13.0.1
 
 ### Patch Changes

package/dist/cjs/nodeviews/inlineCard.js

@@ -49,12 +49,18 @@ var InlineCard = exports.InlineCard = /*#__PURE__*/(0, _react.memo)(function (_r
     data = _node$attrs.data;
   // eslint-disable-next-line @atlaskit/platform/prefer-crypto-random-uuid -- Use crypto.randomUUID instead
   var refId = (0, _react.useRef)((0, _v.default)());
+  var removeCardDispatched = (0, _react.useRef)(false);
   var _ref2 = (cardContext === null || cardContext === void 0 || (_cardContext$value = cardContext.value) === null || _cardContext$value === void 0 ? void 0 : _cardContext$value.store) || {},
     getSmartlinkState = _ref2.getState;
   var cardState = getSmartlinkState === null || getSmartlinkState === void 0 ? void 0 : getSmartlinkState()[url || ''];
   (0, _react.useEffect)(function () {
     var id = refId.current;
+    removeCardDispatched.current = false;
     return function () {
+      if ((0, _expValEquals.expValEquals)('platform_editor_inline_card_dispatch_guard', 'isEnabled', true) && removeCardDispatched.current) {
+        return;
+      }
+      removeCardDispatched.current = true;
       var tr = view.state.tr;
       (0, _actions.removeCard)({
         id: id
@@ -167,6 +173,7 @@ var selector = function selector(states) {
 };
 
 /**
+ * Inline card node view component that renders a Smart Link inline card within the editor.
  *
  * @param props
  * @example

package/dist/es2019/nodeviews/inlineCard.js

@@ -39,13 +39,19 @@ export const InlineCard = /*#__PURE__*/memo(({
   } = node.attrs;
   // eslint-disable-next-line @atlaskit/platform/prefer-crypto-random-uuid -- Use crypto.randomUUID instead
   const refId = useRef(uuid());
+  const removeCardDispatched = useRef(false);
   const {
     getState: getSmartlinkState
   } = (cardContext === null || cardContext === void 0 ? void 0 : (_cardContext$value = cardContext.value) === null || _cardContext$value === void 0 ? void 0 : _cardContext$value.store) || {};
   const cardState = getSmartlinkState === null || getSmartlinkState === void 0 ? void 0 : getSmartlinkState()[url || ''];
   useEffect(() => {
     const id = refId.current;
+    removeCardDispatched.current = false;
     return () => {
+      if (expValEquals('platform_editor_inline_card_dispatch_guard', 'isEnabled', true) && removeCardDispatched.current) {
+        return;
+      }
+      removeCardDispatched.current = true;
       const {
         tr
       } = view.state;
@@ -163,6 +169,7 @@ const selector = states => {
 };
 
 /**
+ * Inline card node view component that renders a Smart Link inline card within the editor.
  *
  * @param props
  * @example

package/dist/esm/nodeviews/inlineCard.js

@@ -37,12 +37,18 @@ export var InlineCard = /*#__PURE__*/memo(function (_ref) {
     data = _node$attrs.data;
   // eslint-disable-next-line @atlaskit/platform/prefer-crypto-random-uuid -- Use crypto.randomUUID instead
   var refId = useRef(uuid());
+  var removeCardDispatched = useRef(false);
   var _ref2 = (cardContext === null || cardContext === void 0 || (_cardContext$value = cardContext.value) === null || _cardContext$value === void 0 ? void 0 : _cardContext$value.store) || {},
     getSmartlinkState = _ref2.getState;
   var cardState = getSmartlinkState === null || getSmartlinkState === void 0 ? void 0 : getSmartlinkState()[url || ''];
   useEffect(function () {
     var id = refId.current;
+    removeCardDispatched.current = false;
     return function () {
+      if (expValEquals('platform_editor_inline_card_dispatch_guard', 'isEnabled', true) && removeCardDispatched.current) {
+        return;
+      }
+      removeCardDispatched.current = true;
       var tr = view.state.tr;
       removeCard({
         id: id
@@ -155,6 +161,7 @@ var selector = function selector(states) {
 };
 
 /**
+ * Inline card node view component that renders a Smart Link inline card within the editor.
  *
  * @param props
  * @example

package/dist/types/nodeviews/inlineCard.d.ts

@@ -7,6 +7,7 @@ import { type InlineCardWithAwarenessProps } from './inlineCardWithAwareness';
 export declare const InlineCard: React.MemoExoticComponent<({ node, cardContext, actionOptions, useAlternativePreloader, view, getPos, onClick, onResolve, isHovered, showHoverPreview, hoverPreviewOptions, isPageSSRed, pluginInjectionApi, disablePreviewPanel, }: SmartCardProps) => React.JSX.Element | null>;
 export type InlineCardNodeViewProps = Pick<SmartCardProps, 'useAlternativePreloader' | 'actionOptions' | 'allowEmbeds' | 'allowBlockCards' | 'enableInlineUpgradeFeatures' | 'pluginInjectionApi' | 'onClickCallback' | 'isPageSSRed' | 'CompetitorPrompt' | 'provider'>;
 /**
+ * Inline card node view component that renders a Smart Link inline card within the editor.
  *
  * @param props
  * @example

package/dist/types-ts4.5/nodeviews/inlineCard.d.ts

@@ -7,6 +7,7 @@ import { type InlineCardWithAwarenessProps } from './inlineCardWithAwareness';
 export declare const InlineCard: React.MemoExoticComponent<({ node, cardContext, actionOptions, useAlternativePreloader, view, getPos, onClick, onResolve, isHovered, showHoverPreview, hoverPreviewOptions, isPageSSRed, pluginInjectionApi, disablePreviewPanel, }: SmartCardProps) => React.JSX.Element | null>;
 export type InlineCardNodeViewProps = Pick<SmartCardProps, 'useAlternativePreloader' | 'actionOptions' | 'allowEmbeds' | 'allowBlockCards' | 'enableInlineUpgradeFeatures' | 'pluginInjectionApi' | 'onClickCallback' | 'isPageSSRed' | 'CompetitorPrompt' | 'provider'>;
 /**
+ * Inline card node view component that renders a Smart Link inline card within the editor.
  *
  * @param props
  * @example

package/package.json

@@ -1,6 +1,6 @@
 {
 	"name": "@atlaskit/editor-plugin-card",
-	"version": "13.0.1",
+	"version": "13.0.3",
 	"description": "Card plugin for @atlaskit/editor-core",
 	"author": "Atlassian Pty Ltd",
 	"license": "Apache-2.0",
@@ -62,7 +62,7 @@
 		"@atlaskit/prosemirror-history": "^0.2.0",
 		"@atlaskit/smart-card": "^43.26.0",
 		"@atlaskit/theme": "^22.0.0",
-		"@atlaskit/tmp-editor-statsig": "^36.0.0",
+		"@atlaskit/tmp-editor-statsig": "^37.0.0",
 		"@atlaskit/tokens": "^11.1.0",
 		"@babel/runtime": "^7.0.0",
 		"@emotion/react": "^11.7.1",
@@ -72,7 +72,7 @@
 		"uuid": "^3.1.0"
 	},
 	"peerDependencies": {
-		"@atlaskit/editor-common": "^112.0.0",
+		"@atlaskit/editor-common": "^112.2.0",
 		"@atlaskit/link-provider": "^4.2.0",
 		"react": "^18.2.0",
 		"react-intl-next": "npm:react-intl@^5.18.1"