@atlaskit/editor-plugin-card 1.14.4 → 1.14.5

package/dist/es2019/ui/{NewInlineCardOverlay → LeftIconOverlay}/index.js

@@ -9,93 +9,84 @@ import { useIntl } from 'react-intl-next';
 import { cardMessages as messages } from '@atlaskit/editor-common/messages';
 import { ZERO_WIDTH_JOINER } from '@atlaskit/editor-common/utils';
 import PreferencesIcon from '@atlaskit/icon/glyph/preferences';
-import { B100, N0, N700 } from '@atlaskit/theme/colors';
-import { getChildElement, getIconSize, getInlineCardAvailableWidth, getOverlayWidths, isOneLine } from '../InlineCardOverlay/utils';
+import { N0, N30A, N40A, N60A, N700 } from '@atlaskit/theme/colors';
+import Tooltip from '@atlaskit/tooltip';
+import { getChildElement, getInlineCardAvailableWidth, isOneLine } from '../InlineCardOverlay/utils';
 const DEBOUNCE_IN_MS = 5;
-const ESTIMATED_MIN_WIDTH_IN_PX = 16;
 const PADDING_IN_PX = 4;
-const ICON_WIDTH_IN_PX = 14;
+const ICON_WIDTH_IN_PX = 16;
 const ICON_AND_LABEL_CLASSNAME = 'ak-editor-card-overlay-icon-and-label';
-const OVERLAY_LABEL_CLASSNAME = 'ak-editor-card-overlay-label';
 const OVERLAY_MARKER_CLASSNAME = 'ak-editor-card-overlay-marker';
 const TEXT_NODE_SELECTOR = ['p', 'h1', 'h2', 'h3', 'h4', 'h5', 'h6'].join(',');
 const SMART_LINK_BACKGROUND_COLOR = `var(--ds-surface-raised, ${N0})`;
-// TODO: This should be lighter to match the rest of the button
-const SMART_LINK_ACTIVE_COLOR = `var(--ds-background-selected, ${B100})`;
+const CONFIGURE_ICON_BACKGROUND_COLOR = `var(--ds-background-neutral, ${N30A})`;
+const CONFIGURE_ICON_BACKGROUND_HOVERED_COLOR = `var(--ds-background-neutral-hovered, ${N40A})`;
+const CONFIGURE_ICON_BACKGROUND_ACTIVE_COLOR = `var(--ds-background-neutral-pressed, ${N60A})`;
 const containerStyles = css({
   position: 'relative',
-  lineHeight: 'normal',
-  ':active': {
-    [`.${ICON_AND_LABEL_CLASSNAME}`]: {
-      background: SMART_LINK_ACTIVE_COLOR
-    }
-  }
+  lineHeight: 'normal'
 });
 const overlayStyles = css({
+  position: 'absolute',
+  // Vertically align. Required for overlay to be centered inside the inline link (the inline lozenge is slightly larger than the designs)
+  transform: 'translate(0%, -50%)',
+  top: '50%',
   // Set default styling to be invisible but available in dom for width calculation.
   visibility: 'hidden',
-  marginTop: "var(--ds-space-050, 4px)",
-  position: 'absolute',
-  verticalAlign: 'text-top',
-  height: '1lh',
-  '@supports not (height: 1lh)': {
-    height: '1.2em'
-  },
   overflow: 'hidden',
   // EDM-1717: box-shadow Safari fix bring load wrapper zIndex to 1
-  zIndex: 2,
-  pointerEvents: 'none'
+  zIndex: 2
 });
 const showOverlayStyles = css({
   visibility: 'visible'
 });
 const iconStyles = css({
-  // Position icon in the middle
+  background: CONFIGURE_ICON_BACKGROUND_COLOR,
+  ':hover': {
+    background: CONFIGURE_ICON_BACKGROUND_HOVERED_COLOR
+  },
+  ':active': {
+    background: CONFIGURE_ICON_BACKGROUND_ACTIVE_COLOR
+  },
   span: {
-    display: 'flex'
-  }
-});
-const labelStyles = css({
-  fontSize: '0.875em',
-  fontWeight: '600',
-  width: 'max-content'
+    // If PreferencesIcon left as inline-block (default), height is incorrect and border radius is clipped when parent element
+    // uses 1lh height (rather than 100%)
+    display: 'block'
+  },
+  // Note: The spec recomends 3px, but the icon doesn't fit left of the lozenge text if this size
+  padding: "var(--ds-space-025, 2px)",
+  borderRadius: '3px'
 });
 const iconAndLabelStyles = css({
   display: 'flex',
   alignItems: 'center',
   height: '100%',
-  marginLeft: "var(--ds-space-050, 4px)",
-  marginRight: "var(--ds-space-025, 2px)",
+  // eslint-disable-next-line @atlaskit/design-system/use-tokens-space
+  marginLeft: '2.5px',
+  // Margin from very left of entire card (inclusive of blue)
+
+  // This exists so if we set a semi-transparent background above, the provider icon doesn't show
   background: SMART_LINK_BACKGROUND_COLOR,
+  // Ensure we don't have a white gap when the inline-card is in an active state
+  borderRadius: '3px',
   color: `var(--ds-text-subtlest, ${N700})`
 });
-const overflowingContainerStyles = css({
-  display: 'flex',
-  flexDirection: 'row-reverse',
-  alignItems: 'center',
-  width: 'max-content',
-  height: '100%'
-});
-const NarrowInlineCardOverlay = ({
+const LeftIconOverlay = ({
   children,
   isSelected = false,
   isVisible = false,
   testId = 'inline-card-overlay',
-  url,
   ...props
 }) => {
   const [showOverlay, setShowOverlay] = useState(false);
   const [availableWidth, setAvailableWidth] = useState(undefined);
-  const maxOverlayWidth = useRef(0);
-  const minOverlayWidth = useRef(ESTIMATED_MIN_WIDTH_IN_PX);
-  const parentWidth = useRef(0);
-  const iconSize = useRef('small');
   const containerRef = useRef(null);
 
-  // TODO EDM-9843: Use availableWidth for small link edge case
+  // TODO EDM-9853: Use availableWidth for small link edge case
+  // Calculation logic will need to updated.
   availableWidth;
   const setVisibility = useCallback(() => {
-    if (!containerRef.current || !maxOverlayWidth.current) {
+    if (!containerRef.current) {
       return;
     }
     const marker = getChildElement(containerRef, `.${OVERLAY_MARKER_CLASSNAME}`);
@@ -120,30 +111,9 @@ const NarrowInlineCardOverlay = ({
     }
   }, [isSelected]);
   useLayoutEffect(() => {
-    // Using useLayoutEffect here.
-    // 1) We want all to be able to determine whether to display label before
-    //    the overlay becomes visible.
-    // 2) We need to wait for the refs to be assigned to be able to do determine
-    //    the width of the overlay.
     if (!containerRef.current) {
       return;
     }
-
-    // This should run only once
-    if (!maxOverlayWidth.current) {
-      const iconAndLabel = getChildElement(containerRef, `.${ICON_AND_LABEL_CLASSNAME}`);
-      const label = getChildElement(containerRef, `.${OVERLAY_LABEL_CLASSNAME}`);
-      if (iconAndLabel && label) {
-        // Set overlay max (label + icon) and min (icon only) width.
-        const {
-          max,
-          min
-        } = getOverlayWidths(iconAndLabel, label);
-        maxOverlayWidth.current = max;
-        minOverlayWidth.current = min;
-        iconSize.current = getIconSize(label);
-      }
-    }
     if (isVisible) {
       setVisibility();
     }
@@ -164,13 +134,6 @@ const NarrowInlineCardOverlay = ({
       if (!size) {
         return;
       }
-      if (!parentWidth.current) {
-        parentWidth.current = size;
-      }
-      if (parentWidth.current === size) {
-        return;
-      }
-      parentWidth.current = size;
       setVisibility();
     }, DEBOUNCE_IN_MS);
     const observer = new ResizeObserver(updateOverlay);
@@ -180,34 +143,28 @@ const NarrowInlineCardOverlay = ({
     };
   }, [isVisible, setVisibility]);
   const intl = useIntl();
-  const label = intl.formatMessage(messages.inlineOverlay);
+  const configureLinkLabel = intl.formatMessage(messages.inlineConfigureLink);
   return jsx("span", _extends({}, props, {
     css: containerStyles,
     ref: containerRef
-  }), isVisible && jsx(React.Fragment, null, jsx("span", {
+  }), isVisible && jsx(Tooltip, {
+    content: configureLinkLabel
+  }, tooltipProps => jsx(React.Fragment, null, jsx("span", {
     "aria-hidden": "true",
     className: OVERLAY_MARKER_CLASSNAME
-  }, ZERO_WIDTH_JOINER), jsx("a", {
+  }, ZERO_WIDTH_JOINER), jsx("span", {
     css: [overlayStyles, showOverlay && showOverlayStyles],
-    "data-testid": testId,
-    href: url,
-    onClick: e => e.preventDefault(),
-    tabIndex: -1
-  }, jsx("span", {
-    css: overflowingContainerStyles
-  }, jsx("span", {
+    tabIndex: -1,
+    "data-testid": testId
+  }, jsx("span", _extends({}, tooltipProps, {
     css: iconAndLabelStyles,
     className: ICON_AND_LABEL_CLASSNAME
-  }, jsx("span", {
+  }), jsx("span", {
     css: iconStyles
   }, jsx(PreferencesIcon, {
-    label: label,
-    size: iconSize.current,
+    label: configureLinkLabel,
+    size: 'small',
     testId: `${testId}-icon`
-  })), jsx("span", {
-    css: labelStyles,
-    className: OVERLAY_LABEL_CLASSNAME,
-    "data-testid": `${testId}-label`
-  }))))), children);
+  })))))), children);
 };
-export default NarrowInlineCardOverlay;
+export default LeftIconOverlay;

package/dist/es2019/ui/ResizableEmbedCard.js

@@ -289,10 +289,14 @@ export default class ResizableEmbedCard extends React.Component {
     return jsx("span", {
       "data-testid": 'resizable-embed-card-height-definer',
       style: {
+        // eslint-disable-next-line @atlaskit/ui-styling-standard/enforce-style-prop -- Ignored via go/DSP-18766
         display: 'block',
         /* Fixes extra padding problem in Firefox */
+        // eslint-disable-next-line @atlaskit/ui-styling-standard/enforce-style-prop -- Ignored via go/DSP-18766
         fontSize: 0,
+        // eslint-disable-next-line @atlaskit/ui-styling-standard/enforce-style-prop -- Ignored via go/DSP-18766
         lineHeight: 0,
+        // eslint-disable-next-line @atlaskit/ui-styling-standard/enforce-style-prop -- Ignored via go/DSP-18766
         ...heightDefiningStyles
       }
     });

package/dist/esm/nodeviews/datasource.js

@@ -275,6 +275,7 @@ export var Datasource = /*#__PURE__*/function (_ReactNodeView) {
         url: attrs.url,
         datasourceId: attrs === null || attrs === void 0 || (_attrs$datasource = attrs.datasource) === null || _attrs$datasource === void 0 ? void 0 : _attrs$datasource.id
       }, jsx("div", {
+        // eslint-disable-next-line @atlaskit/ui-styling-standard/no-classname-prop -- Ignored via go/DSP-18766
         className: DATASOURCE_INNER_CONTAINER_CLASSNAME,
         style: {
           minWidth: this.isNodeNested ? '100%' : calcBreakoutWidth(attrs.layout || DATASOURCE_DEFAULT_LAYOUT, this.tableWidth)

package/dist/esm/nodeviews/inlineCardWithAwareness.js

@@ -120,7 +120,10 @@ var InlineCard = function InlineCard(_ref) {
       markMostRecentlyInsertedLink: markMostRecentlyInsertedLink,
       pluginInjectionApi: pluginInjectionApi,
       setOverlayHoveredStyles: setOverlayHoveredStyles
-    }, innerCard) : /*#__PURE__*/React.createElement("span", {
+    }, innerCard) :
+    /*#__PURE__*/
+    // eslint-disable-next-line @atlaskit/ui-styling-standard/no-classname-prop -- Ignored via go/DSP-18766
+    React.createElement("span", {
       className: "card"
     }, innerCard);
   }, [cardContext, getPos, innerCard, isHovered, isInserted, isOverlayEnabled, isPulseEnabled, isResolvedViewRendered, isSelected, markMostRecentlyInsertedLink, pluginInjectionApi, setOverlayHoveredStyles, url]);

package/dist/esm/ui/AwarenessWrapper/index.js

@@ -8,7 +8,7 @@ import useLinkUpgradeDiscoverability from '../../common/hooks/useLinkUpgradeDisc
 import { isLocalStorageKeyDiscovered, LOCAL_STORAGE_DISCOVERY_KEY_SMART_LINK, LOCAL_STORAGE_DISCOVERY_KEY_TOOLBAR, markLocalStorageKeyDiscovered, ONE_DAY_IN_MILLISECONDS } from '../../common/local-storage';
 import { getResolvedAttributesFromStore } from '../../utils';
 import InlineCardOverlay from '../InlineCardOverlay';
-import NewInlineCardOverlay from '../NewInlineCardOverlay';
+import LeftIconOverlay from '../LeftIconOverlay';
 import { DiscoveryPulse } from '../Pulse';
 // editor adds a standard line-height that is bigger than an inline smart link
 // due to that the link has a bit of white space around it, which doesn't look right when there is pulse around it
@@ -73,7 +73,7 @@ export var AwarenessWrapper = function AwarenessWrapper(_ref) {
   var cardWithOverlay = useMemo(function () {
     if (shouldShowLinkOverlay) {
       if (getBooleanFF('platform.linking-platform.smart-links-in-live-pages')) {
-        return jsx(NewInlineCardOverlay, {
+        return jsx(LeftIconOverlay, {
           isSelected: isSelected,
           isVisible: isResolvedViewRendered && (isInserted || isHovered || isSelected),
           onMouseEnter: function onMouseEnter() {
@@ -81,8 +81,7 @@ export var AwarenessWrapper = function AwarenessWrapper(_ref) {
           },
           onMouseLeave: function onMouseLeave() {
             return handleOverlayChange(false);
-          },
-          url: url
+          }
         }, children);
       }
       return jsx(InlineCardOverlay, {
@@ -101,19 +100,22 @@ export var AwarenessWrapper = function AwarenessWrapper(_ref) {
   }, [shouldShowLinkOverlay, isSelected, isResolvedViewRendered, isInserted, isHovered, url, children, handleOverlayChange]);
   return useMemo(function () {
     var _cardContext$value;
-    return jsx("span", {
-      css: shouldShowLinkPulse && loaderWrapperStyles,
-      className: "card"
-    }, jsx(AnalyticsContext, {
-      data: {
-        attributes: getResolvedAttributesFromStore(url, 'inline', cardContext === null || cardContext === void 0 || (_cardContext$value = cardContext.value) === null || _cardContext$value === void 0 ? void 0 : _cardContext$value.store)
-      }
-    }, jsx(DiscoveryPulse, {
-      localStorageKey: LOCAL_STORAGE_DISCOVERY_KEY_SMART_LINK,
-      localStorageKeyExpirationInMs: ONE_DAY_IN_MILLISECONDS,
-      discoveryMode: "start",
-      shouldShowPulse: isResolvedViewRendered && shouldShowLinkPulse,
-      testId: "link-discovery-pulse"
-    }, cardWithOverlay)));
+    return (
+      // eslint-disable-next-line @atlaskit/ui-styling-standard/no-classname-prop -- Ignored via go/DSP-18766
+      jsx("span", {
+        css: shouldShowLinkPulse && loaderWrapperStyles,
+        className: "card"
+      }, jsx(AnalyticsContext, {
+        data: {
+          attributes: getResolvedAttributesFromStore(url, 'inline', cardContext === null || cardContext === void 0 || (_cardContext$value = cardContext.value) === null || _cardContext$value === void 0 ? void 0 : _cardContext$value.store)
+        }
+      }, jsx(DiscoveryPulse, {
+        localStorageKey: LOCAL_STORAGE_DISCOVERY_KEY_SMART_LINK,
+        localStorageKeyExpirationInMs: ONE_DAY_IN_MILLISECONDS,
+        discoveryMode: "start",
+        shouldShowPulse: isResolvedViewRendered && shouldShowLinkPulse,
+        testId: "link-discovery-pulse"
+      }, cardWithOverlay)))
+    );
   }, [shouldShowLinkPulse, url, cardContext === null || cardContext === void 0 || (_cardContext$value2 = cardContext.value) === null || _cardContext$value2 === void 0 ? void 0 : _cardContext$value2.store, isResolvedViewRendered, cardWithOverlay]);
 };

package/dist/esm/ui/DatasourceModal/index.js

@@ -24,7 +24,7 @@ export var DatasourceModal = function DatasourceModal(_ref) {
   var onClose = useCallback(function () {
     dispatch(hideDatasourceModal(transaction));
   }, [dispatch, transaction]);
-  var onInsert = useOnInsert(view, existingNode);
+  var updateAdf = useUpdateAdf(view, existingNode);
   var isRegularCardNode = !!(existingNode && !(existingNode !== null && existingNode !== void 0 && (_existingNode$attrs = existingNode.attrs) !== null && _existingNode$attrs !== void 0 && _existingNode$attrs.datasource));
   var _ref2 = (existingNode === null || existingNode === void 0 || (_existingNode$attrs2 = existingNode.attrs) === null || _existingNode$attrs2 === void 0 ? void 0 : _existingNode$attrs2.datasource) || {},
     _ref2$id = _ref2.id,
@@ -57,10 +57,10 @@ export var DatasourceModal = function DatasourceModal(_ref) {
     columnCustomSizes: columnCustomSizes,
     wrappedColumnKeys: wrappedColumnKeys,
     onCancel: onClose,
-    onInsert: onInsert
+    onInsert: updateAdf
   });
 };
-var useOnInsert = function useOnInsert(view, existingNode) {
+var useUpdateAdf = function useUpdateAdf(view, existingNode) {
   return useCallback(function (newAdf, analyticEvent) {
     if (analyticEvent) {
       analyticEvent.update(function (payload) {
@@ -111,10 +111,9 @@ var resolveColumnsConfig = function resolveColumnsConfig(views) {
     tableView = _views[0];
   var visibleColumnKeys = [];
   var wrappedColumnKeys = [];
-  var columnCustomSizes;
+  var columnCustomSizes = {};
   var columns = tableView === null || tableView === void 0 || (_tableView$properties = tableView.properties) === null || _tableView$properties === void 0 ? void 0 : _tableView$properties.columns;
   if (columns) {
-    columnCustomSizes = {};
     var _iterator = _createForOfIteratorHelper(columns),
       _step;
     try {

package/dist/esm/ui/InlineCardOverlay/index.js

@@ -231,7 +231,9 @@ var InlineCardOverlay = function InlineCardOverlay(_ref) {
   }, jsx("span", {
     css: overflowingContainerStyles
   }, jsx("span", {
-    css: iconAndLabelStyles,
+    css: iconAndLabelStyles
+    // eslint-disable-next-line @atlaskit/ui-styling-standard/no-classname-prop -- Ignored via go/DSP-18766
+    ,
     className: ICON_AND_LABEL_CLASSNAME
   }, jsx("span", {
     css: iconStyles
@@ -240,11 +242,15 @@ var InlineCardOverlay = function InlineCardOverlay(_ref) {
     size: iconSize.current,
     testId: "".concat(testId, "-icon")
   })), showLabel && jsx("span", {
-    css: labelStyles,
+    css: labelStyles
+    // eslint-disable-next-line @atlaskit/ui-styling-standard/no-classname-prop -- Ignored via go/DSP-18766
+    ,
     className: OVERLAY_LABEL_CLASSNAME,
     "data-testid": "".concat(testId, "-label")
   }, label)), jsx("span", {
-    css: gradientStyles,
+    css: gradientStyles
+    // eslint-disable-next-line @atlaskit/ui-styling-standard/no-classname-prop -- Ignored via go/DSP-18766
+    ,
     className: OVERLAY_GRADIENT_CLASSNAME,
     "data-testid": "".concat(testId, "-gradient")
   })))));

package/dist/esm/ui/{NewInlineCardOverlay → LeftIconOverlay}/index.js

@@ -1,8 +1,7 @@
 import _extends from "@babel/runtime/helpers/extends";
 import _slicedToArray from "@babel/runtime/helpers/slicedToArray";
 import _objectWithoutProperties from "@babel/runtime/helpers/objectWithoutProperties";
-import _defineProperty from "@babel/runtime/helpers/defineProperty";
-var _excluded = ["children", "isSelected", "isVisible", "testId", "url"];
+var _excluded = ["children", "isSelected", "isVisible", "testId"];
 /* eslint-disable @atlaskit/design-system/no-nested-styles */
 /* eslint-disable @atlaskit/design-system/prefer-primitives */
 /** @jsx jsx */
@@ -13,72 +12,69 @@ import { useIntl } from 'react-intl-next';
 import { cardMessages as messages } from '@atlaskit/editor-common/messages';
 import { ZERO_WIDTH_JOINER } from '@atlaskit/editor-common/utils';
 import PreferencesIcon from '@atlaskit/icon/glyph/preferences';
-import { B100, N0, N700 } from '@atlaskit/theme/colors';
-import { getChildElement, getIconSize, getInlineCardAvailableWidth, getOverlayWidths, isOneLine } from '../InlineCardOverlay/utils';
+import { N0, N30A, N40A, N60A, N700 } from '@atlaskit/theme/colors';
+import Tooltip from '@atlaskit/tooltip';
+import { getChildElement, getInlineCardAvailableWidth, isOneLine } from '../InlineCardOverlay/utils';
 var DEBOUNCE_IN_MS = 5;
-var ESTIMATED_MIN_WIDTH_IN_PX = 16;
 var PADDING_IN_PX = 4;
-var ICON_WIDTH_IN_PX = 14;
+var ICON_WIDTH_IN_PX = 16;
 var ICON_AND_LABEL_CLASSNAME = 'ak-editor-card-overlay-icon-and-label';
-var OVERLAY_LABEL_CLASSNAME = 'ak-editor-card-overlay-label';
 var OVERLAY_MARKER_CLASSNAME = 'ak-editor-card-overlay-marker';
 var TEXT_NODE_SELECTOR = ['p', 'h1', 'h2', 'h3', 'h4', 'h5', 'h6'].join(',');
 var SMART_LINK_BACKGROUND_COLOR = "var(--ds-surface-raised, ".concat(N0, ")");
-// TODO: This should be lighter to match the rest of the button
-var SMART_LINK_ACTIVE_COLOR = "var(--ds-background-selected, ".concat(B100, ")");
+var CONFIGURE_ICON_BACKGROUND_COLOR = "var(--ds-background-neutral, ".concat(N30A, ")");
+var CONFIGURE_ICON_BACKGROUND_HOVERED_COLOR = "var(--ds-background-neutral-hovered, ".concat(N40A, ")");
+var CONFIGURE_ICON_BACKGROUND_ACTIVE_COLOR = "var(--ds-background-neutral-pressed, ".concat(N60A, ")");
 var containerStyles = css({
   position: 'relative',
-  lineHeight: 'normal',
-  ':active': _defineProperty({}, ".".concat(ICON_AND_LABEL_CLASSNAME), {
-    background: SMART_LINK_ACTIVE_COLOR
-  })
+  lineHeight: 'normal'
 });
 var overlayStyles = css({
+  position: 'absolute',
+  // Vertically align. Required for overlay to be centered inside the inline link (the inline lozenge is slightly larger than the designs)
+  transform: 'translate(0%, -50%)',
+  top: '50%',
   // Set default styling to be invisible but available in dom for width calculation.
   visibility: 'hidden',
-  marginTop: "var(--ds-space-050, 4px)",
-  position: 'absolute',
-  verticalAlign: 'text-top',
-  height: '1lh',
-  '@supports not (height: 1lh)': {
-    height: '1.2em'
-  },
   overflow: 'hidden',
   // EDM-1717: box-shadow Safari fix bring load wrapper zIndex to 1
-  zIndex: 2,
-  pointerEvents: 'none'
+  zIndex: 2
 });
 var showOverlayStyles = css({
   visibility: 'visible'
 });
 var iconStyles = css({
-  // Position icon in the middle
+  background: CONFIGURE_ICON_BACKGROUND_COLOR,
+  ':hover': {
+    background: CONFIGURE_ICON_BACKGROUND_HOVERED_COLOR
+  },
+  ':active': {
+    background: CONFIGURE_ICON_BACKGROUND_ACTIVE_COLOR
+  },
   span: {
-    display: 'flex'
-  }
-});
-var labelStyles = css({
-  fontSize: '0.875em',
-  fontWeight: '600',
-  width: 'max-content'
+    // If PreferencesIcon left as inline-block (default), height is incorrect and border radius is clipped when parent element
+    // uses 1lh height (rather than 100%)
+    display: 'block'
+  },
+  // Note: The spec recomends 3px, but the icon doesn't fit left of the lozenge text if this size
+  padding: "var(--ds-space-025, 2px)",
+  borderRadius: '3px'
 });
 var iconAndLabelStyles = css({
   display: 'flex',
   alignItems: 'center',
   height: '100%',
-  marginLeft: "var(--ds-space-050, 4px)",
-  marginRight: "var(--ds-space-025, 2px)",
+  // eslint-disable-next-line @atlaskit/design-system/use-tokens-space
+  marginLeft: '2.5px',
+  // Margin from very left of entire card (inclusive of blue)
+
+  // This exists so if we set a semi-transparent background above, the provider icon doesn't show
   background: SMART_LINK_BACKGROUND_COLOR,
+  // Ensure we don't have a white gap when the inline-card is in an active state
+  borderRadius: '3px',
   color: "var(--ds-text-subtlest, ".concat(N700, ")")
 });
-var overflowingContainerStyles = css({
-  display: 'flex',
-  flexDirection: 'row-reverse',
-  alignItems: 'center',
-  width: 'max-content',
-  height: '100%'
-});
-var NarrowInlineCardOverlay = function NarrowInlineCardOverlay(_ref) {
+var LeftIconOverlay = function LeftIconOverlay(_ref) {
   var children = _ref.children,
     _ref$isSelected = _ref.isSelected,
     isSelected = _ref$isSelected === void 0 ? false : _ref$isSelected,
@@ -86,7 +82,6 @@ var NarrowInlineCardOverlay = function NarrowInlineCardOverlay(_ref) {
     isVisible = _ref$isVisible === void 0 ? false : _ref$isVisible,
     _ref$testId = _ref.testId,
     testId = _ref$testId === void 0 ? 'inline-card-overlay' : _ref$testId,
-    url = _ref.url,
     props = _objectWithoutProperties(_ref, _excluded);
   var _useState = useState(false),
     _useState2 = _slicedToArray(_useState, 2),
@@ -96,16 +91,13 @@ var NarrowInlineCardOverlay = function NarrowInlineCardOverlay(_ref) {
     _useState4 = _slicedToArray(_useState3, 2),
     availableWidth = _useState4[0],
     setAvailableWidth = _useState4[1];
-  var maxOverlayWidth = useRef(0);
-  var minOverlayWidth = useRef(ESTIMATED_MIN_WIDTH_IN_PX);
-  var parentWidth = useRef(0);
-  var iconSize = useRef('small');
   var containerRef = useRef(null);
 
-  // TODO EDM-9843: Use availableWidth for small link edge case
+  // TODO EDM-9853: Use availableWidth for small link edge case
+  // Calculation logic will need to updated.
   availableWidth;
   var setVisibility = useCallback(function () {
-    if (!containerRef.current || !maxOverlayWidth.current) {
+    if (!containerRef.current) {
       return;
     }
     var marker = getChildElement(containerRef, ".".concat(OVERLAY_MARKER_CLASSNAME));
@@ -130,29 +122,9 @@ var NarrowInlineCardOverlay = function NarrowInlineCardOverlay(_ref) {
     }
   }, [isSelected]);
   useLayoutEffect(function () {
-    // Using useLayoutEffect here.
-    // 1) We want all to be able to determine whether to display label before
-    //    the overlay becomes visible.
-    // 2) We need to wait for the refs to be assigned to be able to do determine
-    //    the width of the overlay.
     if (!containerRef.current) {
       return;
     }
-
-    // This should run only once
-    if (!maxOverlayWidth.current) {
-      var iconAndLabel = getChildElement(containerRef, ".".concat(ICON_AND_LABEL_CLASSNAME));
-      var _label = getChildElement(containerRef, ".".concat(OVERLAY_LABEL_CLASSNAME));
-      if (iconAndLabel && _label) {
-        // Set overlay max (label + icon) and min (icon only) width.
-        var _getOverlayWidths = getOverlayWidths(iconAndLabel, _label),
-          max = _getOverlayWidths.max,
-          min = _getOverlayWidths.min;
-        maxOverlayWidth.current = max;
-        minOverlayWidth.current = min;
-        iconSize.current = getIconSize(_label);
-      }
-    }
     if (isVisible) {
       setVisibility();
     }
@@ -173,13 +145,6 @@ var NarrowInlineCardOverlay = function NarrowInlineCardOverlay(_ref) {
       if (!size) {
         return;
       }
-      if (!parentWidth.current) {
-        parentWidth.current = size;
-      }
-      if (parentWidth.current === size) {
-        return;
-      }
-      parentWidth.current = size;
       setVisibility();
     }, DEBOUNCE_IN_MS);
     var observer = new ResizeObserver(updateOverlay);
@@ -189,36 +154,30 @@ var NarrowInlineCardOverlay = function NarrowInlineCardOverlay(_ref) {
     };
   }, [isVisible, setVisibility]);
   var intl = useIntl();
-  var label = intl.formatMessage(messages.inlineOverlay);
+  var configureLinkLabel = intl.formatMessage(messages.inlineConfigureLink);
   return jsx("span", _extends({}, props, {
     css: containerStyles,
     ref: containerRef
-  }), isVisible && jsx(React.Fragment, null, jsx("span", {
-    "aria-hidden": "true",
-    className: OVERLAY_MARKER_CLASSNAME
-  }, ZERO_WIDTH_JOINER), jsx("a", {
-    css: [overlayStyles, showOverlay && showOverlayStyles],
-    "data-testid": testId,
-    href: url,
-    onClick: function onClick(e) {
-      return e.preventDefault();
-    },
-    tabIndex: -1
-  }, jsx("span", {
-    css: overflowingContainerStyles
-  }, jsx("span", {
-    css: iconAndLabelStyles,
-    className: ICON_AND_LABEL_CLASSNAME
-  }, jsx("span", {
-    css: iconStyles
-  }, jsx(PreferencesIcon, {
-    label: label,
-    size: iconSize.current,
-    testId: "".concat(testId, "-icon")
-  })), jsx("span", {
-    css: labelStyles,
-    className: OVERLAY_LABEL_CLASSNAME,
-    "data-testid": "".concat(testId, "-label")
-  }))))), children);
+  }), isVisible && jsx(Tooltip, {
+    content: configureLinkLabel
+  }, function (tooltipProps) {
+    return jsx(React.Fragment, null, jsx("span", {
+      "aria-hidden": "true",
+      className: OVERLAY_MARKER_CLASSNAME
+    }, ZERO_WIDTH_JOINER), jsx("span", {
+      css: [overlayStyles, showOverlay && showOverlayStyles],
+      tabIndex: -1,
+      "data-testid": testId
+    }, jsx("span", _extends({}, tooltipProps, {
+      css: iconAndLabelStyles,
+      className: ICON_AND_LABEL_CLASSNAME
+    }), jsx("span", {
+      css: iconStyles
+    }, jsx(PreferencesIcon, {
+      label: configureLinkLabel,
+      size: 'small',
+      testId: "".concat(testId, "-icon")
+    })))));
+  }), children);
 };
-export default NarrowInlineCardOverlay;
+export default LeftIconOverlay;

package/dist/esm/ui/ResizableEmbedCard.js

@@ -308,9 +308,12 @@ var ResizableEmbedCard = /*#__PURE__*/function (_React$Component) {
       return jsx("span", {
         "data-testid": 'resizable-embed-card-height-definer',
         style: _objectSpread({
+          // eslint-disable-next-line @atlaskit/ui-styling-standard/enforce-style-prop -- Ignored via go/DSP-18766
           display: 'block',
           /* Fixes extra padding problem in Firefox */
+          // eslint-disable-next-line @atlaskit/ui-styling-standard/enforce-style-prop -- Ignored via go/DSP-18766
           fontSize: 0,
+          // eslint-disable-next-line @atlaskit/ui-styling-standard/enforce-style-prop -- Ignored via go/DSP-18766
           lineHeight: 0
         }, heightDefiningStyles)
       });