@atlaskit/editor-plugin-card 1.1.2 → 1.1.3

package/CHANGELOG.md

@@ -1,5 +1,11 @@
 # @atlaskit/editor-plugin-card
 
+## 1.1.3
+
+### Patch Changes
+
+- [#78367](https://stash.atlassian.com/projects/CONFCLOUD/repos/confluence-frontend/pull-requests/78367) [`bc524e57ea86`](https://stash.atlassian.com/projects/CONFCLOUD/repos/confluence-frontend/commits/bc524e57ea86) - [ux] Fixes an issue where doing a select all inside an input field in an embed card would select the node.
+
 ## 1.1.2
 
 ### Patch Changes

package/dist/cjs/nodeviews/embedCard.js

@@ -23,6 +23,7 @@ var _reactNodeView = _interopRequireDefault(require("@atlaskit/editor-common/rea
 var _ui = require("@atlaskit/editor-common/ui");
 var _utils = require("@atlaskit/editor-common/utils");
 var _editorSharedStyles = require("@atlaskit/editor-shared-styles");
+var _platformFeatureFlags = require("@atlaskit/platform-feature-flags");
 var _smartCard = require("@atlaskit/smart-card");
 var _actions = require("../pm-plugins/actions");
 var _ResizableEmbedCard = _interopRequireDefault(require("../ui/ResizableEmbedCard"));
@@ -365,9 +366,16 @@ var EmbedCard = exports.EmbedCard = /*#__PURE__*/function (_ReactNodeView) {
     value: function createDomRef() {
       var domRef = document.createElement('div');
       if (this.reactComponentProps.platform !== 'mobile') {
-        // workaround Chrome bug in https://product-fabric.atlassian.net/browse/ED-5379
-        // see also: https://github.com/ProseMirror/prosemirror/issues/884
-        domRef.contentEditable = 'true';
+        // This fixes an issue with input fields in cross domain iframes (ie. databases and jira fields from different domains)
+        // It is a tradeoff for the bug mentioned below that occurs in Chrome.
+        // See: HOT-107830
+        if ((0, _platformFeatureFlags.getBooleanFF)('platform.editor.card.fix-embed-card-select-all')) {
+          domRef.contentEditable = 'false';
+        } else {
+          // workaround Chrome bug in https://product-fabric.atlassian.net/browse/ED-5379
+          // see also: https://github.com/ProseMirror/prosemirror/issues/884
+          domRef.contentEditable = 'true';
+        }
         domRef.setAttribute('spellcheck', 'false');
       }
       return domRef;

package/dist/es2019/nodeviews/embedCard.js

@@ -9,6 +9,7 @@ import ReactNodeView from '@atlaskit/editor-common/react-node-view';
 import { findOverflowScrollParent, MediaSingle as RichMediaWrapper, UnsupportedBlock } from '@atlaskit/editor-common/ui';
 import { floatingLayouts, isRichMediaInsideOfBlockNode } from '@atlaskit/editor-common/utils';
 import { DEFAULT_EMBED_CARD_HEIGHT, DEFAULT_EMBED_CARD_WIDTH } from '@atlaskit/editor-shared-styles';
+import { getBooleanFF } from '@atlaskit/platform-feature-flags';
 import { EmbedResizeMessageListener, Card as SmartCard } from '@atlaskit/smart-card';
 import { registerCard } from '../pm-plugins/actions';
 import ResizableEmbedCard from '../ui/ResizableEmbedCard';
@@ -342,9 +343,16 @@ export class EmbedCard extends ReactNodeView {
   createDomRef() {
     const domRef = document.createElement('div');
     if (this.reactComponentProps.platform !== 'mobile') {
-      // workaround Chrome bug in https://product-fabric.atlassian.net/browse/ED-5379
-      // see also: https://github.com/ProseMirror/prosemirror/issues/884
-      domRef.contentEditable = 'true';
+      // This fixes an issue with input fields in cross domain iframes (ie. databases and jira fields from different domains)
+      // It is a tradeoff for the bug mentioned below that occurs in Chrome.
+      // See: HOT-107830
+      if (getBooleanFF('platform.editor.card.fix-embed-card-select-all')) {
+        domRef.contentEditable = 'false';
+      } else {
+        // workaround Chrome bug in https://product-fabric.atlassian.net/browse/ED-5379
+        // see also: https://github.com/ProseMirror/prosemirror/issues/884
+        domRef.contentEditable = 'true';
+      }
       domRef.setAttribute('spellcheck', 'false');
     }
     return domRef;

package/dist/esm/nodeviews/embedCard.js

@@ -20,6 +20,7 @@ import ReactNodeView from '@atlaskit/editor-common/react-node-view';
 import { findOverflowScrollParent, MediaSingle as RichMediaWrapper, UnsupportedBlock } from '@atlaskit/editor-common/ui';
 import { floatingLayouts, isRichMediaInsideOfBlockNode } from '@atlaskit/editor-common/utils';
 import { DEFAULT_EMBED_CARD_HEIGHT, DEFAULT_EMBED_CARD_WIDTH } from '@atlaskit/editor-shared-styles';
+import { getBooleanFF } from '@atlaskit/platform-feature-flags';
 import { EmbedResizeMessageListener, Card as SmartCard } from '@atlaskit/smart-card';
 import { registerCard } from '../pm-plugins/actions';
 import ResizableEmbedCard from '../ui/ResizableEmbedCard';
@@ -358,9 +359,16 @@ export var EmbedCard = /*#__PURE__*/function (_ReactNodeView) {
     value: function createDomRef() {
       var domRef = document.createElement('div');
       if (this.reactComponentProps.platform !== 'mobile') {
-        // workaround Chrome bug in https://product-fabric.atlassian.net/browse/ED-5379
-        // see also: https://github.com/ProseMirror/prosemirror/issues/884
-        domRef.contentEditable = 'true';
+        // This fixes an issue with input fields in cross domain iframes (ie. databases and jira fields from different domains)
+        // It is a tradeoff for the bug mentioned below that occurs in Chrome.
+        // See: HOT-107830
+        if (getBooleanFF('platform.editor.card.fix-embed-card-select-all')) {
+          domRef.contentEditable = 'false';
+        } else {
+          // workaround Chrome bug in https://product-fabric.atlassian.net/browse/ED-5379
+          // see also: https://github.com/ProseMirror/prosemirror/issues/884
+          domRef.contentEditable = 'true';
+        }
         domRef.setAttribute('spellcheck', 'false');
       }
       return domRef;

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@atlaskit/editor-plugin-card",
-  "version": "1.1.2",
+  "version": "1.1.3",
   "description": "Card plugin for @atlaskit/editor-core",
   "author": "Atlassian Pty Ltd",
   "license": "Apache-2.0",
@@ -114,6 +114,9 @@
     },
     "platform.linking-platform.enable-datasource-appearance-toolbar": {
       "type": "boolean"
+    },
+    "platform.editor.card.fix-embed-card-select-all": {
+      "type": "boolean"
     }
   },
   "stricter": {