@atlaskit/editor-plugin-card 0.13.2 → 0.13.4

package/CHANGELOG.md

@@ -1,5 +1,19 @@
 # @atlaskit/editor-plugin-card
 
+## 0.13.4
+
+### Patch Changes
+
+- [#43379](https://bitbucket.org/atlassian/atlassian-frontend/pull-requests/43379) [`482c025520d`](https://bitbucket.org/atlassian/atlassian-frontend/commits/482c025520d) - ED-20763 Upgrade ADF schema version to 33.2.3 for MBE nodes.
+- [#43352](https://bitbucket.org/atlassian/atlassian-frontend/pull-requests/43352) [`087515ab3ea`](https://bitbucket.org/atlassian/atlassian-frontend/commits/087515ab3ea) - [ux] Added on selection behaviour for inline link
+- Updated dependencies
+
+## 0.13.3
+
+### Patch Changes
+
+- [#43175](https://bitbucket.org/atlassian/atlassian-frontend/pull-requests/43175) [`a72cac2bc28`](https://bitbucket.org/atlassian/atlassian-frontend/commits/a72cac2bc28) - [ux] Added a check for showLinkOverlay for hover/unhover scenarios
+
 ## 0.13.2
 
 ### Patch Changes

package/dist/cjs/common/hooks/useLinkUpgradeDiscoverability.js

@@ -39,9 +39,8 @@ var useLinkUpgradeDiscoverability = function useLinkUpgradeDiscoverability(_ref)
   }, [cardContext === null || cardContext === void 0 ? void 0 : cardContext.extractors, url, urlState === null || urlState === void 0 ? void 0 : urlState.status]);
   var shouldShowLinkPulse = (0, _react.useMemo)(function () {
     var _pluginInjectionApi$c;
-    var isKeyDiscovered = (0, _localStorage.isLocalStorageKeyDiscovered)(_localStorage.LOCAL_STORAGE_DISCOVERY_KEY_SMART_LINK);
     var awarenessCandidatePosition = pluginInjectionApi === null || pluginInjectionApi === void 0 || (_pluginInjectionApi$c = pluginInjectionApi.card) === null || _pluginInjectionApi$c === void 0 || (_pluginInjectionApi$c = _pluginInjectionApi$c.sharedState) === null || _pluginInjectionApi$c === void 0 || (_pluginInjectionApi$c = _pluginInjectionApi$c.currentState()) === null || _pluginInjectionApi$c === void 0 ? void 0 : _pluginInjectionApi$c.inlineCardAwarenessCandidatePosition;
-    return isPulseEnabled && !isKeyDiscovered && linkPosition === awarenessCandidatePosition && canBeUpgradedToEmbed;
+    return isPulseEnabled && linkPosition === awarenessCandidatePosition && canBeUpgradedToEmbed;
   }, [canBeUpgradedToEmbed, isPulseEnabled, linkPosition, pluginInjectionApi === null || pluginInjectionApi === void 0 || (_pluginInjectionApi$c2 = pluginInjectionApi.card) === null || _pluginInjectionApi$c2 === void 0 ? void 0 : _pluginInjectionApi$c2.sharedState]);
   var shouldShowLinkOverlay = (urlState === null || urlState === void 0 ? void 0 : urlState.status) === 'resolved' && isOverlayEnabled;
   var shouldShowToolbarPulse = (0, _react.useMemo)(function () {

package/dist/cjs/common/local-storage.js

@@ -8,7 +8,7 @@ var _frontendUtilities = require("@atlaskit/frontend-utilities");
 var LOCAL_STORAGE_CLIENT_KEY = exports.LOCAL_STORAGE_CLIENT_KEY = '@atlaskit/editor-plugin-card';
 var LOCAL_STORAGE_DISCOVERED_KEY = exports.LOCAL_STORAGE_DISCOVERED_KEY = 'discovered';
 var LOCAL_STORAGE_DISCOVERY_KEY_SMART_LINK = exports.LOCAL_STORAGE_DISCOVERY_KEY_SMART_LINK = 'smart-link-upgrade-pulse';
-var LOCAL_STORAGE_DISCOVERY_KEY_TOOLBAR = exports.LOCAL_STORAGE_DISCOVERY_KEY_TOOLBAR = 'link-toolbar-button-group';
+var LOCAL_STORAGE_DISCOVERY_KEY_TOOLBAR = exports.LOCAL_STORAGE_DISCOVERY_KEY_TOOLBAR = 'toolbar-upgrade-pulse';
 var ONE_DAY_IN_MILLISECONDS = exports.ONE_DAY_IN_MILLISECONDS = 86400000;
 var storageClient = new _frontendUtilities.StorageClient(LOCAL_STORAGE_CLIENT_KEY);
 var isLocalStorageKeyDiscovered = exports.isLocalStorageKeyDiscovered = function isLocalStorageKeyDiscovered(key) {

package/dist/cjs/common/pulse/index.js

@@ -4,7 +4,7 @@ var _typeof = require("@babel/runtime/helpers/typeof");
 Object.defineProperty(exports, "__esModule", {
   value: true
 });
-exports.default = exports.DiscoveryPulse = void 0;
+exports.DiscoveryPulse = void 0;
 var _react = _interopRequireWildcard(require("react"));
 var _linkingCommon = require("@atlaskit/linking-common");
 var _localStorage = require("../local-storage");
@@ -29,5 +29,4 @@ var DiscoveryPulse = exports.DiscoveryPulse = function DiscoveryPulse(_ref) {
     isDiscovered: discovered
   };
   return /*#__PURE__*/_react.default.createElement(_linkingCommon.Pulse, pulseProps, children);
-};
-var _default = exports.default = _linkingCommon.Pulse;
+};

package/dist/cjs/nodeviews/inlineCard.js

@@ -17,6 +17,7 @@ var _react = _interopRequireDefault(require("react"));
 var _propTypes = _interopRequireDefault(require("prop-types"));
 var _rafSchd = _interopRequireDefault(require("raf-schd"));
 var _ui = require("@atlaskit/editor-common/ui");
+var _state = require("@atlaskit/editor-prosemirror/state");
 var _platformFeatureFlags = require("@atlaskit/platform-feature-flags");
 var _smartCard = require("@atlaskit/smart-card");
 var _actions = require("../pm-plugins/actions");
@@ -120,6 +121,7 @@ var InlineCardComponent = exports.InlineCardComponent = /*#__PURE__*/function (_
 var WrappedInlineCard = (0, _genericCard.Card)(InlineCardComponent, _ui.UnsupportedInline);
 var WrappedInlineCardWithAwareness = (0, _genericCard.Card)(_inlineCardWithAwareness.InlineCardWithAwareness, _ui.UnsupportedInline);
 function InlineCardNodeView(props) {
+  var _view$state$selection, _view$state$selection2;
   var useAlternativePreloader = props.useAlternativePreloader,
     node = props.node,
     view = props.view,
@@ -144,6 +146,7 @@ function InlineCardNodeView(props) {
   var canBeUpgradedToBlock = !!linkPosition && allowBlockCards ? (0, _utils.isBlockSupportedAtPosition)(linkPosition, editorState, 'inline') : false;
   var isPulseEnabled = enableInlineUpgradeFeatures && canBeUpgradedToEmbed;
   var isOverlayEnabled = enableInlineUpgradeFeatures && (canBeUpgradedToEmbed || canBeUpgradedToBlock);
+  var isSelected = view.state.selection instanceof _state.NodeSelection && ((_view$state$selection = view.state.selection) === null || _view$state$selection === void 0 || (_view$state$selection = _view$state$selection.node) === null || _view$state$selection === void 0 ? void 0 : _view$state$selection.type) === view.state.schema.nodes.inlineCard && ((_view$state$selection2 = view.state.selection) === null || _view$state$selection2 === void 0 ? void 0 : _view$state$selection2.from) === getPos();
   return /*#__PURE__*/_react.default.createElement(WrappedInlineCardWithAwareness, {
     node: node,
     view: view,
@@ -152,6 +155,7 @@ function InlineCardNodeView(props) {
     useAlternativePreloader: useAlternativePreloader,
     isOverlayEnabled: isOverlayEnabled,
     isPulseEnabled: isPulseEnabled,
-    pluginInjectionApi: pluginInjectionApi
+    pluginInjectionApi: pluginInjectionApi,
+    isSelected: isSelected
   });
 }

package/dist/cjs/nodeviews/inlineCardWithAwareness.js

@@ -5,6 +5,7 @@ Object.defineProperty(exports, "__esModule", {
   value: true
 });
 exports.InlineCardWithAwareness = void 0;
+var _extends2 = _interopRequireDefault(require("@babel/runtime/helpers/extends"));
 var _slicedToArray2 = _interopRequireDefault(require("@babel/runtime/helpers/slicedToArray"));
 var _react = require("react");
 var _react2 = require("@emotion/react");
@@ -35,7 +36,8 @@ var InlineCard = function InlineCard(_ref) {
     getPos = _ref.getPos,
     isOverlayEnabled = _ref.isOverlayEnabled,
     isPulseEnabled = _ref.isPulseEnabled,
-    pluginInjectionApi = _ref.pluginInjectionApi;
+    pluginInjectionApi = _ref.pluginInjectionApi,
+    isSelected = _ref.isSelected;
   var _node$attrs = node.attrs,
     url = _node$attrs.url,
     data = _node$attrs.data;
@@ -61,7 +63,15 @@ var InlineCard = function InlineCard(_ref) {
       isOverlayEnabled: isOverlayEnabled,
       isPulseEnabled: isPulseEnabled
     }),
-    shouldShowLinkPulse = _useLinkUpgradeDiscov.shouldShowLinkPulse;
+    shouldShowLinkPulse = _useLinkUpgradeDiscov.shouldShowLinkPulse,
+    shouldShowToolbarPulse = _useLinkUpgradeDiscov.shouldShowToolbarPulse,
+    shouldShowLinkOverlay = _useLinkUpgradeDiscov.shouldShowLinkOverlay;
+
+  // If the toolbar pulse has not yet been invalidated and this is a case where we will be showing it,
+  // we need to invalidate the link pulse too. Toolbar pulse will be invalidated in the corresponding component.
+  if (isSelected && shouldShowToolbarPulse && !(0, _localStorage.isLocalStorageKeyDiscovered)(_localStorage.LOCAL_STORAGE_DISCOVERY_KEY_TOOLBAR)) {
+    (0, _localStorage.markLocalStorageKeyDiscovered)(_localStorage.LOCAL_STORAGE_DISCOVERY_KEY_SMART_LINK);
+  }
   var scrollContainer = (0, _react.useMemo)(function () {
     return (0, _ui.findOverflowScrollParent)(view.dom) || undefined;
   }, [view.dom]);
@@ -113,32 +123,23 @@ var InlineCard = function InlineCard(_ref) {
       showServerActions: showServerActions
     }));
   }, [data, isOverlayVisible, onError, onResolve, scrollContainer, showServerActions, url, useAlternativePreloader]);
-
-  // TODO: add proper show/hide conditions for overlay in EDM-8239
   var card = (0, _react.useMemo)(function () {
-    return shouldShowLinkPulse ? (0, _react2.jsx)("span", {
+    return (0, _react2.jsx)("span", (0, _extends2.default)({
+      css: shouldShowLinkPulse && loaderWrapperStyles,
+      className: "card"
+    }, shouldShowLinkOverlay ? {
       onMouseEnter: function onMouseEnter() {
         return setIsOverlayVisible(true);
       },
       onMouseLeave: function onMouseLeave() {
         return setIsOverlayVisible(false);
-      },
-      css: loaderWrapperStyles,
-      className: "card"
-    }, (0, _react2.jsx)(_pulse.DiscoveryPulse, {
+      }
+    } : {}), shouldShowLinkPulse ? (0, _react2.jsx)(_pulse.DiscoveryPulse, {
       localStorageKey: _localStorage.LOCAL_STORAGE_DISCOVERY_KEY_SMART_LINK,
       localStorageKeyExpirationInMs: _localStorage.ONE_DAY_IN_MILLISECONDS,
       discoveryMode: 'start'
-    }, innerCard)) : (0, _react2.jsx)("span", {
-      onMouseEnter: function onMouseEnter() {
-        return setIsOverlayVisible(true);
-      },
-      onMouseLeave: function onMouseLeave() {
-        return setIsOverlayVisible(false);
-      },
-      className: "card"
-    }, innerCard);
-  }, [innerCard, shouldShowLinkPulse]);
+    }, innerCard) : innerCard);
+  }, [shouldShowLinkPulse, shouldShowLinkOverlay, innerCard]);
 
   // [WS-2307]: we only render card wrapped into a Provider when the value is ready,
   // otherwise if we got data, we can render the card directly since it doesn't need the Provider

package/dist/cjs/ui/LinkToolbarAppearance.js

@@ -54,7 +54,7 @@ var LinkToolbarAppearance = exports.LinkToolbarAppearance = /*#__PURE__*/functio
         editorAnalyticsApi = _this$props.editorAnalyticsApi,
         cardActions = _this$props.cardActions,
         _this$props$showUpgra = _this$props.showUpgradeDiscoverability,
-        showUpgradeDiscoverability = _this$props$showUpgra === void 0 ? false : _this$props$showUpgra;
+        showUpgradeDiscoverability = _this$props$showUpgra === void 0 ? true : _this$props$showUpgra;
       var preview = allowEmbeds && cardContext && url && cardContext.extractors.getPreview(url, platform);
       var defaultCommand = function defaultCommand() {
         return false;
@@ -115,7 +115,7 @@ var LinkToolbarAppearance = exports.LinkToolbarAppearance = /*#__PURE__*/functio
         options.push(embedOption);
       }
       var LinkToolbarButtons = /*#__PURE__*/_react.default.createElement(_card.LinkToolbarButtonGroup, {
-        key: _localStorage.LOCAL_STORAGE_DISCOVERY_KEY_TOOLBAR,
+        key: "link-toolbar-button-group",
         options: options.map(function (option) {
           return (0, _card.getButtonGroupOption)(intl, dispatchCommand, _objectSpread(_objectSpread({}, option), {}, {
             onClick: (0, _card.commandWithMetadata)(option.onClick, {
@@ -127,13 +127,9 @@ var LinkToolbarAppearance = exports.LinkToolbarAppearance = /*#__PURE__*/functio
       var status = url ? cardContext === null || cardContext === void 0 || (_cardContext$store2 = cardContext.store) === null || _cardContext$store2 === void 0 || (_cardContext$store2 = _cardContext$store2.getState()[url]) === null || _cardContext$store2 === void 0 ? void 0 : _cardContext$store2.status : '';
       var embedEnabled = embedOption ? !embedOption.disabled : false;
       if ((0, _toolbar.shouldRenderToolbarPulse)(embedEnabled, currentAppearance !== null && currentAppearance !== void 0 ? currentAppearance : '', status !== null && status !== void 0 ? status : '', showUpgradeDiscoverability)) {
-        return (
-          /*#__PURE__*/
-          // This div is necessary because the toolbar uses :first-child to add margins and can't add margins to the pulse element
-          _react.default.createElement("div", null, /*#__PURE__*/_react.default.createElement(_pulse.DiscoveryPulse, {
-            localStorageKey: "toolbar-upgrade-pulse"
-          }, LinkToolbarButtons))
-        );
+        return /*#__PURE__*/_react.default.createElement(_pulse.DiscoveryPulse, {
+          localStorageKey: _localStorage.LOCAL_STORAGE_DISCOVERY_KEY_TOOLBAR
+        }, LinkToolbarButtons);
       }
       return LinkToolbarButtons;
     });

package/dist/es2019/common/hooks/useLinkUpgradeDiscoverability.js

@@ -1,5 +1,5 @@
 import { useEffect, useMemo, useState } from 'react';
-import { isLocalStorageKeyDiscovered, LOCAL_STORAGE_DISCOVERY_KEY_SMART_LINK, LOCAL_STORAGE_DISCOVERY_KEY_TOOLBAR } from '../local-storage';
+import { isLocalStorageKeyDiscovered, LOCAL_STORAGE_DISCOVERY_KEY_TOOLBAR } from '../local-storage';
 const useLinkUpgradeDiscoverability = ({
   url,
   linkPosition,
@@ -29,9 +29,8 @@ const useLinkUpgradeDiscoverability = ({
   }, [cardContext === null || cardContext === void 0 ? void 0 : cardContext.extractors, url, urlState === null || urlState === void 0 ? void 0 : urlState.status]);
   const shouldShowLinkPulse = useMemo(() => {
     var _pluginInjectionApi$c, _pluginInjectionApi$c2, _pluginInjectionApi$c3;
-    const isKeyDiscovered = isLocalStorageKeyDiscovered(LOCAL_STORAGE_DISCOVERY_KEY_SMART_LINK);
     const awarenessCandidatePosition = pluginInjectionApi === null || pluginInjectionApi === void 0 ? void 0 : (_pluginInjectionApi$c = pluginInjectionApi.card) === null || _pluginInjectionApi$c === void 0 ? void 0 : (_pluginInjectionApi$c2 = _pluginInjectionApi$c.sharedState) === null || _pluginInjectionApi$c2 === void 0 ? void 0 : (_pluginInjectionApi$c3 = _pluginInjectionApi$c2.currentState()) === null || _pluginInjectionApi$c3 === void 0 ? void 0 : _pluginInjectionApi$c3.inlineCardAwarenessCandidatePosition;
-    return isPulseEnabled && !isKeyDiscovered && linkPosition === awarenessCandidatePosition && canBeUpgradedToEmbed;
+    return isPulseEnabled && linkPosition === awarenessCandidatePosition && canBeUpgradedToEmbed;
   }, [canBeUpgradedToEmbed, isPulseEnabled, linkPosition, pluginInjectionApi === null || pluginInjectionApi === void 0 ? void 0 : (_pluginInjectionApi$c4 = pluginInjectionApi.card) === null || _pluginInjectionApi$c4 === void 0 ? void 0 : _pluginInjectionApi$c4.sharedState]);
   const shouldShowLinkOverlay = (urlState === null || urlState === void 0 ? void 0 : urlState.status) === 'resolved' && isOverlayEnabled;
   const shouldShowToolbarPulse = useMemo(() => isPulseEnabled && !isLocalStorageKeyDiscovered(LOCAL_STORAGE_DISCOVERY_KEY_TOOLBAR) && canBeUpgradedToEmbed, [canBeUpgradedToEmbed, isPulseEnabled]);

package/dist/es2019/common/local-storage.js

@@ -2,7 +2,7 @@ import { StorageClient } from '@atlaskit/frontend-utilities';
 export const LOCAL_STORAGE_CLIENT_KEY = '@atlaskit/editor-plugin-card';
 export const LOCAL_STORAGE_DISCOVERED_KEY = 'discovered';
 export const LOCAL_STORAGE_DISCOVERY_KEY_SMART_LINK = 'smart-link-upgrade-pulse';
-export const LOCAL_STORAGE_DISCOVERY_KEY_TOOLBAR = 'link-toolbar-button-group';
+export const LOCAL_STORAGE_DISCOVERY_KEY_TOOLBAR = 'toolbar-upgrade-pulse';
 export const ONE_DAY_IN_MILLISECONDS = 86400000;
 const storageClient = new StorageClient(LOCAL_STORAGE_CLIENT_KEY);
 export const isLocalStorageKeyDiscovered = key => {

package/dist/es2019/common/pulse/index.js

@@ -20,5 +20,4 @@ export const DiscoveryPulse = ({
     isDiscovered: discovered
   };
   return /*#__PURE__*/React.createElement(Pulse, pulseProps, children);
-};
-export default Pulse;
+};

package/dist/es2019/nodeviews/inlineCard.js

@@ -3,6 +3,7 @@ import React from 'react';
 import PropTypes from 'prop-types';
 import rafSchedule from 'raf-schd';
 import { findOverflowScrollParent, UnsupportedInline } from '@atlaskit/editor-common/ui';
+import { NodeSelection } from '@atlaskit/editor-prosemirror/state';
 import { getBooleanFF } from '@atlaskit/platform-feature-flags';
 import { Card as SmartCard } from '@atlaskit/smart-card';
 import { registerCard } from '../pm-plugins/actions';
@@ -100,6 +101,7 @@ _defineProperty(InlineCardComponent, "contextTypes", {
 const WrappedInlineCard = Card(InlineCardComponent, UnsupportedInline);
 const WrappedInlineCardWithAwareness = Card(InlineCardWithAwareness, UnsupportedInline);
 export function InlineCardNodeView(props) {
+  var _view$state$selection, _view$state$selection2, _view$state$selection3;
   const {
     useAlternativePreloader,
     node,
@@ -126,6 +128,7 @@ export function InlineCardNodeView(props) {
   const canBeUpgradedToBlock = !!linkPosition && allowBlockCards ? isBlockSupportedAtPosition(linkPosition, editorState, 'inline') : false;
   const isPulseEnabled = enableInlineUpgradeFeatures && canBeUpgradedToEmbed;
   const isOverlayEnabled = enableInlineUpgradeFeatures && (canBeUpgradedToEmbed || canBeUpgradedToBlock);
+  const isSelected = view.state.selection instanceof NodeSelection && ((_view$state$selection = view.state.selection) === null || _view$state$selection === void 0 ? void 0 : (_view$state$selection2 = _view$state$selection.node) === null || _view$state$selection2 === void 0 ? void 0 : _view$state$selection2.type) === view.state.schema.nodes.inlineCard && ((_view$state$selection3 = view.state.selection) === null || _view$state$selection3 === void 0 ? void 0 : _view$state$selection3.from) === getPos();
   return /*#__PURE__*/React.createElement(WrappedInlineCardWithAwareness, {
     node: node,
     view: view,
@@ -134,6 +137,7 @@ export function InlineCardNodeView(props) {
     useAlternativePreloader: useAlternativePreloader,
     isOverlayEnabled: isOverlayEnabled,
     isPulseEnabled: isPulseEnabled,
-    pluginInjectionApi: pluginInjectionApi
+    pluginInjectionApi: pluginInjectionApi,
+    isSelected: isSelected
   });
 }

package/dist/es2019/nodeviews/inlineCardWithAwareness.js

@@ -1,3 +1,4 @@
+import _extends from "@babel/runtime/helpers/extends";
 /** @jsx jsx */
 import { memo, useCallback, useMemo, useState } from 'react';
 import { css, jsx } from '@emotion/react';
@@ -5,7 +6,7 @@ import rafSchedule from 'raf-schd';
 import { findOverflowScrollParent } from '@atlaskit/editor-common/ui';
 import { Card as SmartCard } from '@atlaskit/smart-card';
 import useLinkUpgradeDiscoverability from '../common/hooks/useLinkUpgradeDiscoverability';
-import { LOCAL_STORAGE_DISCOVERY_KEY_SMART_LINK, ONE_DAY_IN_MILLISECONDS } from '../common/local-storage';
+import { isLocalStorageKeyDiscovered, LOCAL_STORAGE_DISCOVERY_KEY_SMART_LINK, LOCAL_STORAGE_DISCOVERY_KEY_TOOLBAR, markLocalStorageKeyDiscovered, ONE_DAY_IN_MILLISECONDS } from '../common/local-storage';
 import { DiscoveryPulse } from '../common/pulse';
 import { registerCard } from '../pm-plugins/actions';
 import InlineCardOverlay from '../ui/InlineCardOverlay';
@@ -26,7 +27,8 @@ const InlineCard = ({
   getPos,
   isOverlayEnabled,
   isPulseEnabled,
-  pluginInjectionApi
+  pluginInjectionApi,
+  isSelected
 }) => {
   const {
     url,
@@ -44,7 +46,9 @@ const InlineCard = ({
     return typeof pos === 'number' ? pos : undefined;
   }, [getPos]);
   const {
-    shouldShowLinkPulse
+    shouldShowLinkPulse,
+    shouldShowToolbarPulse,
+    shouldShowLinkOverlay
   } = useLinkUpgradeDiscoverability({
     url,
     linkPosition: linkPosition || -1,
@@ -53,6 +57,12 @@ const InlineCard = ({
     isOverlayEnabled,
     isPulseEnabled
   });
+
+  // If the toolbar pulse has not yet been invalidated and this is a case where we will be showing it,
+  // we need to invalidate the link pulse too. Toolbar pulse will be invalidated in the corresponding component.
+  if (isSelected && shouldShowToolbarPulse && !isLocalStorageKeyDiscovered(LOCAL_STORAGE_DISCOVERY_KEY_TOOLBAR)) {
+    markLocalStorageKeyDiscovered(LOCAL_STORAGE_DISCOVERY_KEY_SMART_LINK);
+  }
   const scrollContainer = useMemo(() => findOverflowScrollParent(view.dom) || undefined, [view.dom]);
   const onResolve = useCallback(data => {
     if (!getPos || typeof getPos === 'boolean') {
@@ -104,22 +114,17 @@ const InlineCard = ({
     inlinePreloaderStyle: useAlternativePreloader ? 'on-right-without-skeleton' : undefined,
     showServerActions: showServerActions
   })), [data, isOverlayVisible, onError, onResolve, scrollContainer, showServerActions, url, useAlternativePreloader]);
-
-  // TODO: add proper show/hide conditions for overlay in EDM-8239
-  const card = useMemo(() => shouldShowLinkPulse ? jsx("span", {
-    onMouseEnter: () => setIsOverlayVisible(true),
-    onMouseLeave: () => setIsOverlayVisible(false),
-    css: loaderWrapperStyles,
+  const card = useMemo(() => jsx("span", _extends({
+    css: shouldShowLinkPulse && loaderWrapperStyles,
     className: "card"
-  }, jsx(DiscoveryPulse, {
+  }, shouldShowLinkOverlay ? {
+    onMouseEnter: () => setIsOverlayVisible(true),
+    onMouseLeave: () => setIsOverlayVisible(false)
+  } : {}), shouldShowLinkPulse ? jsx(DiscoveryPulse, {
     localStorageKey: LOCAL_STORAGE_DISCOVERY_KEY_SMART_LINK,
     localStorageKeyExpirationInMs: ONE_DAY_IN_MILLISECONDS,
     discoveryMode: 'start'
-  }, innerCard)) : jsx("span", {
-    onMouseEnter: () => setIsOverlayVisible(true),
-    onMouseLeave: () => setIsOverlayVisible(false),
-    className: "card"
-  }, innerCard), [innerCard, shouldShowLinkPulse]);
+  }, innerCard) : innerCard), [shouldShowLinkPulse, shouldShowLinkOverlay, innerCard]);
 
   // [WS-2307]: we only render card wrapped into a Provider when the value is ready,
   // otherwise if we got data, we can render the card directly since it doesn't need the Provider

package/dist/es2019/ui/LinkToolbarAppearance.js

@@ -25,7 +25,7 @@ export class LinkToolbarAppearance extends React.Component {
         platform,
         editorAnalyticsApi,
         cardActions,
-        showUpgradeDiscoverability = false
+        showUpgradeDiscoverability = true
       } = this.props;
       const preview = allowEmbeds && cardContext && url && cardContext.extractors.getPreview(url, platform);
       const defaultCommand = () => false;
@@ -85,7 +85,7 @@ export class LinkToolbarAppearance extends React.Component {
         options.push(embedOption);
       }
       const LinkToolbarButtons = /*#__PURE__*/React.createElement(LinkToolbarButtonGroup, {
-        key: LOCAL_STORAGE_DISCOVERY_KEY_TOOLBAR,
+        key: "link-toolbar-button-group",
         options: options.map(option => getButtonGroupOption(intl, dispatchCommand, {
           ...option,
           onClick: commandWithMetadata(option.onClick, {
@@ -96,13 +96,9 @@ export class LinkToolbarAppearance extends React.Component {
       const status = url ? cardContext === null || cardContext === void 0 ? void 0 : (_cardContext$store2 = cardContext.store) === null || _cardContext$store2 === void 0 ? void 0 : (_cardContext$store2$g = _cardContext$store2.getState()[url]) === null || _cardContext$store2$g === void 0 ? void 0 : _cardContext$store2$g.status : '';
       const embedEnabled = embedOption ? !embedOption.disabled : false;
       if (shouldRenderToolbarPulse(embedEnabled, currentAppearance !== null && currentAppearance !== void 0 ? currentAppearance : '', status !== null && status !== void 0 ? status : '', showUpgradeDiscoverability)) {
-        return (
-          /*#__PURE__*/
-          // This div is necessary because the toolbar uses :first-child to add margins and can't add margins to the pulse element
-          React.createElement("div", null, /*#__PURE__*/React.createElement(DiscoveryPulse, {
-            localStorageKey: "toolbar-upgrade-pulse"
-          }, LinkToolbarButtons))
-        );
+        return /*#__PURE__*/React.createElement(DiscoveryPulse, {
+          localStorageKey: LOCAL_STORAGE_DISCOVERY_KEY_TOOLBAR
+        }, LinkToolbarButtons);
       }
       return LinkToolbarButtons;
     });

package/dist/esm/common/hooks/useLinkUpgradeDiscoverability.js

@@ -1,6 +1,6 @@
 import _slicedToArray from "@babel/runtime/helpers/slicedToArray";
 import { useEffect, useMemo, useState } from 'react';
-import { isLocalStorageKeyDiscovered, LOCAL_STORAGE_DISCOVERY_KEY_SMART_LINK, LOCAL_STORAGE_DISCOVERY_KEY_TOOLBAR } from '../local-storage';
+import { isLocalStorageKeyDiscovered, LOCAL_STORAGE_DISCOVERY_KEY_TOOLBAR } from '../local-storage';
 var useLinkUpgradeDiscoverability = function useLinkUpgradeDiscoverability(_ref) {
   var _cardContext$store, _pluginInjectionApi$c2;
   var url = _ref.url,
@@ -32,9 +32,8 @@ var useLinkUpgradeDiscoverability = function useLinkUpgradeDiscoverability(_ref)
   }, [cardContext === null || cardContext === void 0 ? void 0 : cardContext.extractors, url, urlState === null || urlState === void 0 ? void 0 : urlState.status]);
   var shouldShowLinkPulse = useMemo(function () {
     var _pluginInjectionApi$c;
-    var isKeyDiscovered = isLocalStorageKeyDiscovered(LOCAL_STORAGE_DISCOVERY_KEY_SMART_LINK);
     var awarenessCandidatePosition = pluginInjectionApi === null || pluginInjectionApi === void 0 || (_pluginInjectionApi$c = pluginInjectionApi.card) === null || _pluginInjectionApi$c === void 0 || (_pluginInjectionApi$c = _pluginInjectionApi$c.sharedState) === null || _pluginInjectionApi$c === void 0 || (_pluginInjectionApi$c = _pluginInjectionApi$c.currentState()) === null || _pluginInjectionApi$c === void 0 ? void 0 : _pluginInjectionApi$c.inlineCardAwarenessCandidatePosition;
-    return isPulseEnabled && !isKeyDiscovered && linkPosition === awarenessCandidatePosition && canBeUpgradedToEmbed;
+    return isPulseEnabled && linkPosition === awarenessCandidatePosition && canBeUpgradedToEmbed;
   }, [canBeUpgradedToEmbed, isPulseEnabled, linkPosition, pluginInjectionApi === null || pluginInjectionApi === void 0 || (_pluginInjectionApi$c2 = pluginInjectionApi.card) === null || _pluginInjectionApi$c2 === void 0 ? void 0 : _pluginInjectionApi$c2.sharedState]);
   var shouldShowLinkOverlay = (urlState === null || urlState === void 0 ? void 0 : urlState.status) === 'resolved' && isOverlayEnabled;
   var shouldShowToolbarPulse = useMemo(function () {

package/dist/esm/common/local-storage.js

@@ -2,7 +2,7 @@ import { StorageClient } from '@atlaskit/frontend-utilities';
 export var LOCAL_STORAGE_CLIENT_KEY = '@atlaskit/editor-plugin-card';
 export var LOCAL_STORAGE_DISCOVERED_KEY = 'discovered';
 export var LOCAL_STORAGE_DISCOVERY_KEY_SMART_LINK = 'smart-link-upgrade-pulse';
-export var LOCAL_STORAGE_DISCOVERY_KEY_TOOLBAR = 'link-toolbar-button-group';
+export var LOCAL_STORAGE_DISCOVERY_KEY_TOOLBAR = 'toolbar-upgrade-pulse';
 export var ONE_DAY_IN_MILLISECONDS = 86400000;
 var storageClient = new StorageClient(LOCAL_STORAGE_CLIENT_KEY);
 export var isLocalStorageKeyDiscovered = function isLocalStorageKeyDiscovered(key) {

package/dist/esm/common/pulse/index.js

@@ -20,5 +20,4 @@ export var DiscoveryPulse = function DiscoveryPulse(_ref) {
     isDiscovered: discovered
   };
   return /*#__PURE__*/React.createElement(Pulse, pulseProps, children);
-};
-export default Pulse;
+};

package/dist/esm/nodeviews/inlineCard.js

@@ -11,6 +11,7 @@ import React from 'react';
 import PropTypes from 'prop-types';
 import rafSchedule from 'raf-schd';
 import { findOverflowScrollParent, UnsupportedInline } from '@atlaskit/editor-common/ui';
+import { NodeSelection } from '@atlaskit/editor-prosemirror/state';
 import { getBooleanFF } from '@atlaskit/platform-feature-flags';
 import { Card as SmartCard } from '@atlaskit/smart-card';
 import { registerCard } from '../pm-plugins/actions';
@@ -113,6 +114,7 @@ _defineProperty(InlineCardComponent, "contextTypes", {
 var WrappedInlineCard = Card(InlineCardComponent, UnsupportedInline);
 var WrappedInlineCardWithAwareness = Card(InlineCardWithAwareness, UnsupportedInline);
 export function InlineCardNodeView(props) {
+  var _view$state$selection, _view$state$selection2;
   var useAlternativePreloader = props.useAlternativePreloader,
     node = props.node,
     view = props.view,
@@ -137,6 +139,7 @@ export function InlineCardNodeView(props) {
   var canBeUpgradedToBlock = !!linkPosition && allowBlockCards ? isBlockSupportedAtPosition(linkPosition, editorState, 'inline') : false;
   var isPulseEnabled = enableInlineUpgradeFeatures && canBeUpgradedToEmbed;
   var isOverlayEnabled = enableInlineUpgradeFeatures && (canBeUpgradedToEmbed || canBeUpgradedToBlock);
+  var isSelected = view.state.selection instanceof NodeSelection && ((_view$state$selection = view.state.selection) === null || _view$state$selection === void 0 || (_view$state$selection = _view$state$selection.node) === null || _view$state$selection === void 0 ? void 0 : _view$state$selection.type) === view.state.schema.nodes.inlineCard && ((_view$state$selection2 = view.state.selection) === null || _view$state$selection2 === void 0 ? void 0 : _view$state$selection2.from) === getPos();
   return /*#__PURE__*/React.createElement(WrappedInlineCardWithAwareness, {
     node: node,
     view: view,
@@ -145,6 +148,7 @@ export function InlineCardNodeView(props) {
     useAlternativePreloader: useAlternativePreloader,
     isOverlayEnabled: isOverlayEnabled,
     isPulseEnabled: isPulseEnabled,
-    pluginInjectionApi: pluginInjectionApi
+    pluginInjectionApi: pluginInjectionApi,
+    isSelected: isSelected
   });
 }

package/dist/esm/nodeviews/inlineCardWithAwareness.js

@@ -1,3 +1,4 @@
+import _extends from "@babel/runtime/helpers/extends";
 import _slicedToArray from "@babel/runtime/helpers/slicedToArray";
 /** @jsx jsx */
 import { memo, useCallback, useMemo, useState } from 'react';
@@ -6,7 +7,7 @@ import rafSchedule from 'raf-schd';
 import { findOverflowScrollParent } from '@atlaskit/editor-common/ui';
 import { Card as SmartCard } from '@atlaskit/smart-card';
 import useLinkUpgradeDiscoverability from '../common/hooks/useLinkUpgradeDiscoverability';
-import { LOCAL_STORAGE_DISCOVERY_KEY_SMART_LINK, ONE_DAY_IN_MILLISECONDS } from '../common/local-storage';
+import { isLocalStorageKeyDiscovered, LOCAL_STORAGE_DISCOVERY_KEY_SMART_LINK, LOCAL_STORAGE_DISCOVERY_KEY_TOOLBAR, markLocalStorageKeyDiscovered, ONE_DAY_IN_MILLISECONDS } from '../common/local-storage';
 import { DiscoveryPulse } from '../common/pulse';
 import { registerCard } from '../pm-plugins/actions';
 import InlineCardOverlay from '../ui/InlineCardOverlay';
@@ -27,7 +28,8 @@ var InlineCard = function InlineCard(_ref) {
     getPos = _ref.getPos,
     isOverlayEnabled = _ref.isOverlayEnabled,
     isPulseEnabled = _ref.isPulseEnabled,
-    pluginInjectionApi = _ref.pluginInjectionApi;
+    pluginInjectionApi = _ref.pluginInjectionApi,
+    isSelected = _ref.isSelected;
   var _node$attrs = node.attrs,
     url = _node$attrs.url,
     data = _node$attrs.data;
@@ -53,7 +55,15 @@ var InlineCard = function InlineCard(_ref) {
       isOverlayEnabled: isOverlayEnabled,
       isPulseEnabled: isPulseEnabled
     }),
-    shouldShowLinkPulse = _useLinkUpgradeDiscov.shouldShowLinkPulse;
+    shouldShowLinkPulse = _useLinkUpgradeDiscov.shouldShowLinkPulse,
+    shouldShowToolbarPulse = _useLinkUpgradeDiscov.shouldShowToolbarPulse,
+    shouldShowLinkOverlay = _useLinkUpgradeDiscov.shouldShowLinkOverlay;
+
+  // If the toolbar pulse has not yet been invalidated and this is a case where we will be showing it,
+  // we need to invalidate the link pulse too. Toolbar pulse will be invalidated in the corresponding component.
+  if (isSelected && shouldShowToolbarPulse && !isLocalStorageKeyDiscovered(LOCAL_STORAGE_DISCOVERY_KEY_TOOLBAR)) {
+    markLocalStorageKeyDiscovered(LOCAL_STORAGE_DISCOVERY_KEY_SMART_LINK);
+  }
   var scrollContainer = useMemo(function () {
     return findOverflowScrollParent(view.dom) || undefined;
   }, [view.dom]);
@@ -105,32 +115,23 @@ var InlineCard = function InlineCard(_ref) {
       showServerActions: showServerActions
     }));
   }, [data, isOverlayVisible, onError, onResolve, scrollContainer, showServerActions, url, useAlternativePreloader]);
-
-  // TODO: add proper show/hide conditions for overlay in EDM-8239
   var card = useMemo(function () {
-    return shouldShowLinkPulse ? jsx("span", {
+    return jsx("span", _extends({
+      css: shouldShowLinkPulse && loaderWrapperStyles,
+      className: "card"
+    }, shouldShowLinkOverlay ? {
       onMouseEnter: function onMouseEnter() {
         return setIsOverlayVisible(true);
       },
       onMouseLeave: function onMouseLeave() {
         return setIsOverlayVisible(false);
-      },
-      css: loaderWrapperStyles,
-      className: "card"
-    }, jsx(DiscoveryPulse, {
+      }
+    } : {}), shouldShowLinkPulse ? jsx(DiscoveryPulse, {
       localStorageKey: LOCAL_STORAGE_DISCOVERY_KEY_SMART_LINK,
       localStorageKeyExpirationInMs: ONE_DAY_IN_MILLISECONDS,
       discoveryMode: 'start'
-    }, innerCard)) : jsx("span", {
-      onMouseEnter: function onMouseEnter() {
-        return setIsOverlayVisible(true);
-      },
-      onMouseLeave: function onMouseLeave() {
-        return setIsOverlayVisible(false);
-      },
-      className: "card"
-    }, innerCard);
-  }, [innerCard, shouldShowLinkPulse]);
+    }, innerCard) : innerCard);
+  }, [shouldShowLinkPulse, shouldShowLinkOverlay, innerCard]);
 
   // [WS-2307]: we only render card wrapped into a Provider when the value is ready,
   // otherwise if we got data, we can render the card directly since it doesn't need the Provider

package/dist/esm/ui/LinkToolbarAppearance.js

@@ -44,7 +44,7 @@ export var LinkToolbarAppearance = /*#__PURE__*/function (_React$Component) {
         editorAnalyticsApi = _this$props.editorAnalyticsApi,
         cardActions = _this$props.cardActions,
         _this$props$showUpgra = _this$props.showUpgradeDiscoverability,
-        showUpgradeDiscoverability = _this$props$showUpgra === void 0 ? false : _this$props$showUpgra;
+        showUpgradeDiscoverability = _this$props$showUpgra === void 0 ? true : _this$props$showUpgra;
       var preview = allowEmbeds && cardContext && url && cardContext.extractors.getPreview(url, platform);
       var defaultCommand = function defaultCommand() {
         return false;
@@ -105,7 +105,7 @@ export var LinkToolbarAppearance = /*#__PURE__*/function (_React$Component) {
         options.push(embedOption);
       }
       var LinkToolbarButtons = /*#__PURE__*/React.createElement(LinkToolbarButtonGroup, {
-        key: LOCAL_STORAGE_DISCOVERY_KEY_TOOLBAR,
+        key: "link-toolbar-button-group",
         options: options.map(function (option) {
           return getButtonGroupOption(intl, dispatchCommand, _objectSpread(_objectSpread({}, option), {}, {
             onClick: commandWithMetadata(option.onClick, {
@@ -117,13 +117,9 @@ export var LinkToolbarAppearance = /*#__PURE__*/function (_React$Component) {
       var status = url ? cardContext === null || cardContext === void 0 || (_cardContext$store2 = cardContext.store) === null || _cardContext$store2 === void 0 || (_cardContext$store2 = _cardContext$store2.getState()[url]) === null || _cardContext$store2 === void 0 ? void 0 : _cardContext$store2.status : '';
       var embedEnabled = embedOption ? !embedOption.disabled : false;
       if (shouldRenderToolbarPulse(embedEnabled, currentAppearance !== null && currentAppearance !== void 0 ? currentAppearance : '', status !== null && status !== void 0 ? status : '', showUpgradeDiscoverability)) {
-        return (
-          /*#__PURE__*/
-          // This div is necessary because the toolbar uses :first-child to add margins and can't add margins to the pulse element
-          React.createElement("div", null, /*#__PURE__*/React.createElement(DiscoveryPulse, {
-            localStorageKey: "toolbar-upgrade-pulse"
-          }, LinkToolbarButtons))
-        );
+        return /*#__PURE__*/React.createElement(DiscoveryPulse, {
+          localStorageKey: LOCAL_STORAGE_DISCOVERY_KEY_TOOLBAR
+        }, LinkToolbarButtons);
       }
       return LinkToolbarButtons;
     });

package/dist/types/common/local-storage.d.ts

@@ -1,7 +1,7 @@
 export declare const LOCAL_STORAGE_CLIENT_KEY = "@atlaskit/editor-plugin-card";
 export declare const LOCAL_STORAGE_DISCOVERED_KEY = "discovered";
 export declare const LOCAL_STORAGE_DISCOVERY_KEY_SMART_LINK = "smart-link-upgrade-pulse";
-export declare const LOCAL_STORAGE_DISCOVERY_KEY_TOOLBAR = "link-toolbar-button-group";
+export declare const LOCAL_STORAGE_DISCOVERY_KEY_TOOLBAR = "toolbar-upgrade-pulse";
 export declare const ONE_DAY_IN_MILLISECONDS = 86400000;
 export declare const isLocalStorageKeyDiscovered: (key: string) => boolean;
 export declare const markLocalStorageKeyDiscovered: (key: string, expiration?: number) => void;

package/dist/types/common/pulse/index.d.ts

@@ -1,5 +1,4 @@
 /// <reference types="react" />
-import { Pulse } from '@atlaskit/linking-common';
 export type PulseDiscoveryMode = 'start' | 'iteration';
 export interface PulseProps {
     /**
@@ -25,4 +24,3 @@ export interface PulseProps {
     discoveryMode?: PulseDiscoveryMode;
 }
 export declare const DiscoveryPulse: ({ children, localStorageKey, isDiscovered, localStorageKeyExpirationInMs, discoveryMode, }: PulseProps) => JSX.Element;
-export default Pulse;

package/dist/types/nodeviews/genericCard.d.ts

@@ -33,6 +33,7 @@ export interface CardProps extends CardNodeViewProps {
     isOverlayEnabled?: boolean;
     isPulseEnabled?: boolean;
     linkPosition?: number;
+    isSelected?: boolean;
 }
 export interface SmartCardProps extends CardProps {
     cardContext?: EditorContext<CardContext | undefined>;

package/dist/types/nodeviews/inlineCardWithAwareness.d.ts

@@ -1,4 +1,4 @@
 /// <reference types="react" />
 import { jsx } from '@emotion/react';
 import type { SmartCardProps } from './genericCard';
-export declare const InlineCardWithAwareness: import("react").MemoExoticComponent<({ node, cardContext, showServerActions, useAlternativePreloader, view, getPos, isOverlayEnabled, isPulseEnabled, pluginInjectionApi, }: SmartCardProps) => jsx.JSX.Element | null>;
+export declare const InlineCardWithAwareness: import("react").MemoExoticComponent<({ node, cardContext, showServerActions, useAlternativePreloader, view, getPos, isOverlayEnabled, isPulseEnabled, pluginInjectionApi, isSelected, }: SmartCardProps) => jsx.JSX.Element | null>;

package/dist/types-ts4.5/common/local-storage.d.ts

@@ -1,7 +1,7 @@
 export declare const LOCAL_STORAGE_CLIENT_KEY = "@atlaskit/editor-plugin-card";
 export declare const LOCAL_STORAGE_DISCOVERED_KEY = "discovered";
 export declare const LOCAL_STORAGE_DISCOVERY_KEY_SMART_LINK = "smart-link-upgrade-pulse";
-export declare const LOCAL_STORAGE_DISCOVERY_KEY_TOOLBAR = "link-toolbar-button-group";
+export declare const LOCAL_STORAGE_DISCOVERY_KEY_TOOLBAR = "toolbar-upgrade-pulse";
 export declare const ONE_DAY_IN_MILLISECONDS = 86400000;
 export declare const isLocalStorageKeyDiscovered: (key: string) => boolean;
 export declare const markLocalStorageKeyDiscovered: (key: string, expiration?: number) => void;

package/dist/types-ts4.5/common/pulse/index.d.ts

@@ -1,5 +1,4 @@
 /// <reference types="react" />
-import { Pulse } from '@atlaskit/linking-common';
 export type PulseDiscoveryMode = 'start' | 'iteration';
 export interface PulseProps {
     /**
@@ -25,4 +24,3 @@ export interface PulseProps {
     discoveryMode?: PulseDiscoveryMode;
 }
 export declare const DiscoveryPulse: ({ children, localStorageKey, isDiscovered, localStorageKeyExpirationInMs, discoveryMode, }: PulseProps) => JSX.Element;
-export default Pulse;

package/dist/types-ts4.5/nodeviews/genericCard.d.ts

@@ -33,6 +33,7 @@ export interface CardProps extends CardNodeViewProps {
     isOverlayEnabled?: boolean;
     isPulseEnabled?: boolean;
     linkPosition?: number;
+    isSelected?: boolean;
 }
 export interface SmartCardProps extends CardProps {
     cardContext?: EditorContext<CardContext | undefined>;

package/dist/types-ts4.5/nodeviews/inlineCardWithAwareness.d.ts

@@ -1,4 +1,4 @@
 /// <reference types="react" />
 import { jsx } from '@emotion/react';
 import type { SmartCardProps } from './genericCard';
-export declare const InlineCardWithAwareness: import("react").MemoExoticComponent<({ node, cardContext, showServerActions, useAlternativePreloader, view, getPos, isOverlayEnabled, isPulseEnabled, pluginInjectionApi, }: SmartCardProps) => jsx.JSX.Element | null>;
+export declare const InlineCardWithAwareness: import("react").MemoExoticComponent<({ node, cardContext, showServerActions, useAlternativePreloader, view, getPos, isOverlayEnabled, isPulseEnabled, pluginInjectionApi, isSelected, }: SmartCardProps) => jsx.JSX.Element | null>;

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@atlaskit/editor-plugin-card",
-  "version": "0.13.2",
+  "version": "0.13.4",
   "description": "Card plugin for @atlaskit/editor-core",
   "author": "Atlassian Pty Ltd",
   "license": "Apache-2.0",
@@ -31,10 +31,10 @@
     ".": "./src/index.ts"
   },
   "dependencies": {
-    "@atlaskit/adf-schema": "^32.0.0",
+    "@atlaskit/adf-schema": "^33.2.3",
     "@atlaskit/analytics-next": "^9.1.0",
-    "@atlaskit/custom-steps": "^0.0.2",
-    "@atlaskit/editor-common": "^76.20.0",
+    "@atlaskit/custom-steps": "^0.0.3",
+    "@atlaskit/editor-common": "^76.22.0",
     "@atlaskit/editor-plugin-analytics": "^0.3.0",
     "@atlaskit/editor-plugin-decorations": "^0.2.0",
     "@atlaskit/editor-plugin-feature-flags": "^1.0.0",
@@ -48,9 +48,9 @@
     "@atlaskit/icon": "^21.12.0",
     "@atlaskit/link-analytics": "^8.3.0",
     "@atlaskit/link-client-extension": "^1.8.0",
-    "@atlaskit/link-datasource": "^1.16.0",
+    "@atlaskit/link-datasource": "^1.17.0",
     "@atlaskit/linking-common": "^4.18.0",
-    "@atlaskit/linking-types": "^8.4.0",
+    "@atlaskit/linking-types": "^8.5.0",
     "@atlaskit/platform-feature-flags": "^0.2.0",
     "@atlaskit/primitives": "^1.9.0",
     "@atlaskit/smart-card": "^26.42.0",