@atlaskit/editor-plugin-breakout 22.0.8 → 22.0.10

package/CHANGELOG.md

@@ -1,5 +1,22 @@
 # @atlaskit/editor-plugin-breakout
 
+## 22.0.10
+
+### Patch Changes
+
+- [`5655e3d4d88fc`](https://bitbucket.org/atlassian/atlassian-frontend-monorepo/commits/5655e3d4d88fc) -
+  Clean up experiment `platform_editor_reduce_event_listener_count`. The treatment behaviour is now
+  permanent: node views that render nothing no longer mount a React portal, breakout resize tooltips
+  mount on first hover, and layout column dividers are keyed by section ordinal and found via a
+  scoped document walk.
+- Updated dependencies
+
+## 22.0.9
+
+### Patch Changes
+
+- Updated dependencies
+
 ## 22.0.8
 
 ### Patch Changes

package/dist/cjs/pm-plugins/pragmatic-resizer.js

@@ -128,9 +128,6 @@ var createPragmaticResizer = exports.createPragmaticResizer = function createPra
     intl = _ref3.intl,
     nodeViewPortalProviderAPI = _ref3.nodeViewPortalProviderAPI;
   var state = 'default';
-  // Read once per resizer: `isExperimentEnabled` fires an exposure event, and `registerEvents` is
-  // bound to several elements so checking it inside the handler would emit one per element hovered.
-  var isDeferredTooltipEnabled = (0, _isExperimentEnabled.isExperimentEnabled)('platform_editor_reduce_event_listener_count');
   var isLeftResizeHandleDisabled = (0, _expValEquals.expValEquals)('platform_editor_lovability_resize_dividers_panels', 'isEnabled', true) || (0, _isExperimentEnabled.isExperimentEnabled)('platform_editor_lovability_resize_extensions') || (0, _isExperimentEnabled.isExperimentEnabled)('platform_editor_remove_left_resize_handle');
   var createHandle = function createHandle(side) {
     var handle = document.createElement('div');
@@ -183,8 +180,8 @@ var createPragmaticResizer = exports.createPragmaticResizer = function createPra
     };
     var vanillaTooltip;
 
-    // Tracks whether there is anything to tear down. On the deferred path the tooltip mounts
-    // on first hover and so may never mount at all.
+    // Tracks whether there is anything to tear down: the tooltip mounts on first hover and so
+    // may never mount at all.
     var isTooltipMounted = false;
     var mountTooltip = function mountTooltip() {
       if (isTooltipMounted) {
@@ -219,22 +216,8 @@ var createPragmaticResizer = exports.createPragmaticResizer = function createPra
     //
     // Parking the rail also needs `width: 100%`: without the ADS tooltip's wrappers (stretched
     // by `pragmaticResizerStylesForTooltip`) it would size to its content as a flex item.
-    if ((0, _isExperimentEnabled.isExperimentEnabled)('platform_editor_use_vanilla_components')) {
-      // Always parks, and always defers whatever `platform_editor_reduce_event_listener_count`
-      // says: no portal means no listener cost, and first hover is when the node name reads
-      // correctly.
-      rail.style.width = '100%';
-      tooltipContainer.appendChild(rail);
-    } else {
-      // Remove this while at `platform_editor_use_vanilla_components` cleanup.
-      if (isDeferredTooltipEnabled) {
-        rail.style.width = '100%';
-        tooltipContainer.appendChild(rail);
-      } else {
-        // Not `mountTooltip`: that would set `isTooltipMounted` where the control arm never did.
-        renderTooltip();
-      }
-    }
+    rail.style.width = '100%';
+    tooltipContainer.appendChild(rail);
     return {
       handle: handle,
       rail: rail,
@@ -255,9 +238,9 @@ var createPragmaticResizer = exports.createPragmaticResizer = function createPra
           return;
         }
 
-        // The eager path always mounted, so it always removes — unchanged from before. Only
-        // the deferred path can reach `destroyTooltip` without having mounted anything.
-        if (isDeferredTooltipEnabled && !isTooltipMounted) {
+        // The tooltip mounts on first hover, so `destroyTooltip` can be reached without
+        // anything having been mounted.
+        if (!isTooltipMounted) {
           return;
         }
         nodeViewPortalProviderAPI.remove(key);
@@ -332,16 +315,11 @@ var createPragmaticResizer = exports.createPragmaticResizer = function createPra
     return [(0, _bindEventListener.bind)(element, {
       type: 'mouseenter',
       listener: function listener(event) {
-        if (isDeferredTooltipEnabled) {
-          rightHandle.mountTooltip();
-          leftHandle === null || leftHandle === void 0 || leftHandle.mountTooltip();
-        }
-        // Always mounts on first hover, so it also mounts when the deferred experiment is
-        // off. `mountTooltip` is a no-op once mounted, so the overlap is safe. At
-        // cleanup, drop the gate and delete the block above — this covers both.
+        // Mounted on first hover rather than up front, so a handle that is never
+        // hovered costs no portal and no listeners.
+        rightHandle.mountTooltip();
+        leftHandle === null || leftHandle === void 0 || leftHandle.mountTooltip();
         if ((0, _isExperimentEnabled.isExperimentEnabled)('platform_editor_use_vanilla_components')) {
-          rightHandle.mountTooltip();
-          leftHandle === null || leftHandle === void 0 || leftHandle.mountTooltip();
           // After the mount above, so the tooltip always exists to be opened.
           openTooltipAt(hoverAnchor, event);
         }

package/dist/es2019/pm-plugins/pragmatic-resizer.js

@@ -117,9 +117,6 @@ export const createPragmaticResizer = ({
   nodeViewPortalProviderAPI
 }) => {
   let state = 'default';
-  // Read once per resizer: `isExperimentEnabled` fires an exposure event, and `registerEvents` is
-  // bound to several elements so checking it inside the handler would emit one per element hovered.
-  const isDeferredTooltipEnabled = isExperimentEnabled('platform_editor_reduce_event_listener_count');
   const isLeftResizeHandleDisabled = expValEquals('platform_editor_lovability_resize_dividers_panels', 'isEnabled', true) || isExperimentEnabled('platform_editor_lovability_resize_extensions') || isExperimentEnabled('platform_editor_remove_left_resize_handle');
   const createHandle = side => {
     const handle = document.createElement('div');
@@ -168,8 +165,8 @@ export const createPragmaticResizer = ({
     }), tooltipContainer, key);
     let vanillaTooltip;
 
-    // Tracks whether there is anything to tear down. On the deferred path the tooltip mounts
-    // on first hover and so may never mount at all.
+    // Tracks whether there is anything to tear down: the tooltip mounts on first hover and so
+    // may never mount at all.
     let isTooltipMounted = false;
     const mountTooltip = () => {
       if (isTooltipMounted) {
@@ -204,22 +201,8 @@ export const createPragmaticResizer = ({
     //
     // Parking the rail also needs `width: 100%`: without the ADS tooltip's wrappers (stretched
     // by `pragmaticResizerStylesForTooltip`) it would size to its content as a flex item.
-    if (isExperimentEnabled('platform_editor_use_vanilla_components')) {
-      // Always parks, and always defers whatever `platform_editor_reduce_event_listener_count`
-      // says: no portal means no listener cost, and first hover is when the node name reads
-      // correctly.
-      rail.style.width = '100%';
-      tooltipContainer.appendChild(rail);
-    } else {
-      // Remove this while at `platform_editor_use_vanilla_components` cleanup.
-      if (isDeferredTooltipEnabled) {
-        rail.style.width = '100%';
-        tooltipContainer.appendChild(rail);
-      } else {
-        // Not `mountTooltip`: that would set `isTooltipMounted` where the control arm never did.
-        renderTooltip();
-      }
-    }
+    rail.style.width = '100%';
+    tooltipContainer.appendChild(rail);
     return {
       handle,
       rail,
@@ -240,9 +223,9 @@ export const createPragmaticResizer = ({
           return;
         }
 
-        // The eager path always mounted, so it always removes — unchanged from before. Only
-        // the deferred path can reach `destroyTooltip` without having mounted anything.
-        if (isDeferredTooltipEnabled && !isTooltipMounted) {
+        // The tooltip mounts on first hover, so `destroyTooltip` can be reached without
+        // anything having been mounted.
+        if (!isTooltipMounted) {
           return;
         }
         nodeViewPortalProviderAPI.remove(key);
@@ -316,16 +299,11 @@ export const createPragmaticResizer = ({
     return [bind(element, {
       type: 'mouseenter',
       listener: event => {
-        if (isDeferredTooltipEnabled) {
-          rightHandle.mountTooltip();
-          leftHandle === null || leftHandle === void 0 ? void 0 : leftHandle.mountTooltip();
-        }
-        // Always mounts on first hover, so it also mounts when the deferred experiment is
-        // off. `mountTooltip` is a no-op once mounted, so the overlap is safe. At
-        // cleanup, drop the gate and delete the block above — this covers both.
+        // Mounted on first hover rather than up front, so a handle that is never
+        // hovered costs no portal and no listeners.
+        rightHandle.mountTooltip();
+        leftHandle === null || leftHandle === void 0 ? void 0 : leftHandle.mountTooltip();
         if (isExperimentEnabled('platform_editor_use_vanilla_components')) {
-          rightHandle.mountTooltip();
-          leftHandle === null || leftHandle === void 0 ? void 0 : leftHandle.mountTooltip();
           // After the mount above, so the tooltip always exists to be opened.
           openTooltipAt(hoverAnchor, event);
         }

package/dist/esm/pm-plugins/pragmatic-resizer.js

@@ -119,9 +119,6 @@ export var createPragmaticResizer = function createPragmaticResizer(_ref3) {
     intl = _ref3.intl,
     nodeViewPortalProviderAPI = _ref3.nodeViewPortalProviderAPI;
   var state = 'default';
-  // Read once per resizer: `isExperimentEnabled` fires an exposure event, and `registerEvents` is
-  // bound to several elements so checking it inside the handler would emit one per element hovered.
-  var isDeferredTooltipEnabled = isExperimentEnabled('platform_editor_reduce_event_listener_count');
   var isLeftResizeHandleDisabled = expValEquals('platform_editor_lovability_resize_dividers_panels', 'isEnabled', true) || isExperimentEnabled('platform_editor_lovability_resize_extensions') || isExperimentEnabled('platform_editor_remove_left_resize_handle');
   var createHandle = function createHandle(side) {
     var handle = document.createElement('div');
@@ -174,8 +171,8 @@ export var createPragmaticResizer = function createPragmaticResizer(_ref3) {
     };
     var vanillaTooltip;
 
-    // Tracks whether there is anything to tear down. On the deferred path the tooltip mounts
-    // on first hover and so may never mount at all.
+    // Tracks whether there is anything to tear down: the tooltip mounts on first hover and so
+    // may never mount at all.
     var isTooltipMounted = false;
     var mountTooltip = function mountTooltip() {
       if (isTooltipMounted) {
@@ -210,22 +207,8 @@ export var createPragmaticResizer = function createPragmaticResizer(_ref3) {
     //
     // Parking the rail also needs `width: 100%`: without the ADS tooltip's wrappers (stretched
     // by `pragmaticResizerStylesForTooltip`) it would size to its content as a flex item.
-    if (isExperimentEnabled('platform_editor_use_vanilla_components')) {
-      // Always parks, and always defers whatever `platform_editor_reduce_event_listener_count`
-      // says: no portal means no listener cost, and first hover is when the node name reads
-      // correctly.
-      rail.style.width = '100%';
-      tooltipContainer.appendChild(rail);
-    } else {
-      // Remove this while at `platform_editor_use_vanilla_components` cleanup.
-      if (isDeferredTooltipEnabled) {
-        rail.style.width = '100%';
-        tooltipContainer.appendChild(rail);
-      } else {
-        // Not `mountTooltip`: that would set `isTooltipMounted` where the control arm never did.
-        renderTooltip();
-      }
-    }
+    rail.style.width = '100%';
+    tooltipContainer.appendChild(rail);
     return {
       handle: handle,
       rail: rail,
@@ -246,9 +229,9 @@ export var createPragmaticResizer = function createPragmaticResizer(_ref3) {
           return;
         }
 
-        // The eager path always mounted, so it always removes — unchanged from before. Only
-        // the deferred path can reach `destroyTooltip` without having mounted anything.
-        if (isDeferredTooltipEnabled && !isTooltipMounted) {
+        // The tooltip mounts on first hover, so `destroyTooltip` can be reached without
+        // anything having been mounted.
+        if (!isTooltipMounted) {
           return;
         }
         nodeViewPortalProviderAPI.remove(key);
@@ -323,16 +306,11 @@ export var createPragmaticResizer = function createPragmaticResizer(_ref3) {
     return [bind(element, {
       type: 'mouseenter',
       listener: function listener(event) {
-        if (isDeferredTooltipEnabled) {
-          rightHandle.mountTooltip();
-          leftHandle === null || leftHandle === void 0 || leftHandle.mountTooltip();
-        }
-        // Always mounts on first hover, so it also mounts when the deferred experiment is
-        // off. `mountTooltip` is a no-op once mounted, so the overlap is safe. At
-        // cleanup, drop the gate and delete the block above — this covers both.
+        // Mounted on first hover rather than up front, so a handle that is never
+        // hovered costs no portal and no listeners.
+        rightHandle.mountTooltip();
+        leftHandle === null || leftHandle === void 0 || leftHandle.mountTooltip();
         if (isExperimentEnabled('platform_editor_use_vanilla_components')) {
-          rightHandle.mountTooltip();
-          leftHandle === null || leftHandle === void 0 || leftHandle.mountTooltip();
           // After the mount above, so the tooltip always exists to be opened.
           openTooltipAt(hoverAnchor, event);
         }

package/package.json

@@ -1,6 +1,6 @@
 {
 	"name": "@atlaskit/editor-plugin-breakout",
-	"version": "22.0.8",
+	"version": "22.0.10",
 	"description": "Breakout plugin for @atlaskit/editor-core",
 	"author": "Atlassian Pty Ltd",
 	"license": "Apache-2.0",
@@ -36,7 +36,7 @@
 		"@atlaskit/platform-feature-flags": "^2.2.0",
 		"@atlaskit/pragmatic-drag-and-drop": "^4.0.0",
 		"@atlaskit/theme": "^28.2.0",
-		"@atlaskit/tmp-editor-statsig": "^217.0.0",
+		"@atlaskit/tmp-editor-statsig": "^218.0.0",
 		"@atlaskit/tokens": "^20.1.0",
 		"@atlaskit/tooltip": "^24.3.0",
 		"@babel/runtime": "^7.0.0",