@atlaskit/editor-plugin-block-controls 7.18.1 → 7.18.2

package/CHANGELOG.md

@@ -1,5 +1,12 @@
 # @atlaskit/editor-plugin-block-controls
 
+## 7.18.2
+
+### Patch Changes
+
+- [`275b01c2a180f`](https://bitbucket.org/atlassian/atlassian-frontend-monorepo/commits/275b01c2a180f) -
+  EDITOR-3911 fix key handling while preserving selection
+
 ## 7.18.1
 
 ### Patch Changes

package/dist/cjs/pm-plugins/selection-preservation/pm-plugin.js

@@ -137,15 +137,18 @@ var createSelectionPreservationPlugin = exports.createSelectionPreservationPlugi
           }
           var blockMenuOpen = (api === null || api === void 0 || (_api$userIntent = api.userIntent) === null || _api$userIntent === void 0 || (_api$userIntent = _api$userIntent.sharedState.currentState()) === null || _api$userIntent === void 0 ? void 0 : _api$userIntent.currentUserIntent) === 'blockMenuOpen';
 
-          // When block menu isn't open and user presses any key, stop preserving selection
-          if (!blockMenuOpen) {
-            var tr = view.state.tr;
-            (0, _editorCommands.stopPreservingSelection)({
-              tr: tr
-            });
-            view.dispatch(tr);
-            return false;
+          // When block menu is open, prevent all key events to avoid changing selection or editing content
+          if (blockMenuOpen) {
+            return true;
           }
+
+          // When block menu isn't open and user presses any key, stop preserving selection
+          var tr = view.state.tr;
+          (0, _editorCommands.stopPreservingSelection)({
+            tr: tr
+          });
+          view.dispatch(tr);
+          return false;
         }
       }
     });

package/dist/es2019/pm-plugins/selection-preservation/pm-plugin.js

@@ -131,15 +131,18 @@ export const createSelectionPreservationPlugin = api => () => {
         }
         const blockMenuOpen = (api === null || api === void 0 ? void 0 : (_api$userIntent = api.userIntent) === null || _api$userIntent === void 0 ? void 0 : (_api$userIntent$share = _api$userIntent.sharedState.currentState()) === null || _api$userIntent$share === void 0 ? void 0 : _api$userIntent$share.currentUserIntent) === 'blockMenuOpen';
 
-        // When block menu isn't open and user presses any key, stop preserving selection
-        if (!blockMenuOpen) {
-          const tr = view.state.tr;
-          stopPreservingSelection({
-            tr
-          });
-          view.dispatch(tr);
-          return false;
+        // When block menu is open, prevent all key events to avoid changing selection or editing content
+        if (blockMenuOpen) {
+          return true;
         }
+
+        // When block menu isn't open and user presses any key, stop preserving selection
+        const tr = view.state.tr;
+        stopPreservingSelection({
+          tr
+        });
+        view.dispatch(tr);
+        return false;
       }
     }
   });

package/dist/esm/pm-plugins/selection-preservation/pm-plugin.js

@@ -131,15 +131,18 @@ export var createSelectionPreservationPlugin = function createSelectionPreservat
           }
           var blockMenuOpen = (api === null || api === void 0 || (_api$userIntent = api.userIntent) === null || _api$userIntent === void 0 || (_api$userIntent = _api$userIntent.sharedState.currentState()) === null || _api$userIntent === void 0 ? void 0 : _api$userIntent.currentUserIntent) === 'blockMenuOpen';
 
-          // When block menu isn't open and user presses any key, stop preserving selection
-          if (!blockMenuOpen) {
-            var tr = view.state.tr;
-            stopPreservingSelection({
-              tr: tr
-            });
-            view.dispatch(tr);
-            return false;
+          // When block menu is open, prevent all key events to avoid changing selection or editing content
+          if (blockMenuOpen) {
+            return true;
           }
+
+          // When block menu isn't open and user presses any key, stop preserving selection
+          var tr = view.state.tr;
+          stopPreservingSelection({
+            tr: tr
+          });
+          view.dispatch(tr);
+          return false;
         }
       }
     });

package/package.json

@@ -1,6 +1,6 @@
 {
 	"name": "@atlaskit/editor-plugin-block-controls",
-	"version": "7.18.1",
+	"version": "7.18.2",
 	"description": "Block controls plugin for @atlaskit/editor-core",
 	"author": "Atlassian Pty Ltd",
 	"license": "Apache-2.0",