@atlaskit/editor-plugin-block-controls 3.19.9 → 3.19.11

package/CHANGELOG.md

@@ -1,5 +1,22 @@
 # @atlaskit/editor-plugin-block-controls
 
+## 3.19.11
+
+### Patch Changes
+
+- [#177025](https://bitbucket.org/atlassian/atlassian-frontend-monorepo/pull-requests/177025)
+  [`b000694948f37`](https://bitbucket.org/atlassian/atlassian-frontend-monorepo/commits/b000694948f37) -
+  [ED-27900] Fix cursor disappear when focusing editor at the first line by pressing Tab or down
+  arrow key at page title
+
+## 3.19.10
+
+### Patch Changes
+
+- [#175523](https://bitbucket.org/atlassian/atlassian-frontend-monorepo/pull-requests/175523)
+  [`0623f8fb2b5ee`](https://bitbucket.org/atlassian/atlassian-frontend-monorepo/commits/0623f8fb2b5ee) -
+  Fix a bug where slash command via quick insert button is not inserted at the correct location
+
 ## 3.19.9
 
 ### Patch Changes

package/dist/cjs/pm-plugins/decorations-quick-insert-button.js

@@ -53,6 +53,10 @@ var quickInsertButtonDecoration = exports.quickInsertButtonDecoration = function
   };
   return _view.Decoration.widget(rootPos, function (view, getPos) {
     var element = document.createElement('span');
+    if ((0, _platformFeatureFlags.fg)('platform_editor_controls_patch_15')) {
+      // inline decoration causes cursor disappear when focusing editor at the first line (e.g. press Tab when title is focused)
+      element.style.display = 'block';
+    }
     element.contentEditable = 'false';
     element.setAttribute('data-blocks-quick-insert-container', 'true');
     element.setAttribute('data-testid', 'block-ctrl-quick-insert-button');

package/dist/cjs/ui/quick-insert-button.js

@@ -249,7 +249,7 @@ var TypeAheadControl = exports.TypeAheadControl = function TypeAheadControl(_ref
             });
           }
         }
-        if (currentSelection instanceof _cellSelection.CellSelection && (0, _platformFeatureFlags.fg)('platform_editor_controls_patch_4')) {
+        if (currentSelection instanceof _cellSelection.CellSelection) {
           // find the last inline position in the selection
           var lastInlinePosition = _state.TextSelection.near(view.state.selection.$to, -1);
           lastInlinePosition && api.core.actions.execute(function (_ref4) {
@@ -306,7 +306,7 @@ var TypeAheadControl = exports.TypeAheadControl = function TypeAheadControl(_ref
     style: positionStyles,
     xcss: [containerStaticStyles, isTypeAheadOpen && !(0, _platformFeatureFlags.fg)('platform_editor_controls_widget_visibility') && disabledContainerStyles]
   }, (0, _react2.jsx)("span", {
-    css: [tooltipContainerStyles, (0, _platformFeatureFlags.fg)('platform_editor_controls_patch_4') && tooltipContainerStylesStickyHeader, (0, _platformFeatureFlags.fg)('platform_editor_controls_patch_4') && tooltipContainerStylesStickyHeaderWithMarksFix]
+    css: [tooltipContainerStyles, tooltipContainerStylesStickyHeader, tooltipContainerStylesStickyHeaderWithMarksFix]
   }, tooltipPressable()));
 };
 var QuickInsertWithVisibility = exports.QuickInsertWithVisibility = function QuickInsertWithVisibility(_ref5) {

package/dist/cjs/ui/utils/editor-commands.js

@@ -5,6 +5,7 @@ Object.defineProperty(exports, "__esModule", {
 });
 exports.createNewLine = void 0;
 var _state = require("@atlaskit/editor-prosemirror/state");
+var _platformFeatureFlags = require("@atlaskit/platform-feature-flags");
 var createNewLine = exports.createNewLine = function createNewLine(start) {
   return function (_ref) {
     var _tr$doc$nodeAt;
@@ -15,6 +16,6 @@ var createNewLine = exports.createNewLine = function createNewLine(start) {
     }
     var position = start + nodeSize;
     tr.insert(position, tr.doc.type.schema.nodes.paragraph.create());
-    return tr.setSelection(_state.TextSelection.create(tr.doc, position));
+    return tr.setSelection((0, _platformFeatureFlags.fg)('platform_editor_controls_patch_14') ? _state.TextSelection.near(tr.doc.resolve(position)) : _state.TextSelection.create(tr.doc, position));
   };
 };

package/dist/es2019/pm-plugins/decorations-quick-insert-button.js

@@ -44,6 +44,10 @@ export const quickInsertButtonDecoration = (api, formatMessage, rootPos, anchorN
   };
   return Decoration.widget(rootPos, (view, getPos) => {
     const element = document.createElement('span');
+    if (fg('platform_editor_controls_patch_15')) {
+      // inline decoration causes cursor disappear when focusing editor at the first line (e.g. press Tab when title is focused)
+      element.style.display = 'block';
+    }
     element.contentEditable = 'false';
     element.setAttribute('data-blocks-quick-insert-container', 'true');
     element.setAttribute('data-testid', 'block-ctrl-quick-insert-button');

package/dist/es2019/ui/quick-insert-button.js

@@ -244,7 +244,7 @@ export const TypeAheadControl = ({
             });
           }
         }
-        if (currentSelection instanceof CellSelection && fg('platform_editor_controls_patch_4')) {
+        if (currentSelection instanceof CellSelection) {
           // find the last inline position in the selection
           const lastInlinePosition = TextSelection.near(view.state.selection.$to, -1);
           lastInlinePosition && api.core.actions.execute(({
@@ -300,7 +300,7 @@ export const TypeAheadControl = ({
     style: positionStyles,
     xcss: [containerStaticStyles, isTypeAheadOpen && !fg('platform_editor_controls_widget_visibility') && disabledContainerStyles]
   }, jsx("span", {
-    css: [tooltipContainerStyles, fg('platform_editor_controls_patch_4') && tooltipContainerStylesStickyHeader, fg('platform_editor_controls_patch_4') && tooltipContainerStylesStickyHeaderWithMarksFix]
+    css: [tooltipContainerStyles, tooltipContainerStylesStickyHeader, tooltipContainerStylesStickyHeaderWithMarksFix]
   }, tooltipPressable()));
 };
 export const QuickInsertWithVisibility = ({

package/dist/es2019/ui/utils/editor-commands.js

@@ -1,4 +1,5 @@
 import { TextSelection } from '@atlaskit/editor-prosemirror/state';
+import { fg } from '@atlaskit/platform-feature-flags';
 export const createNewLine = start => ({
   tr
 }) => {
@@ -9,5 +10,5 @@ export const createNewLine = start => ({
   }
   const position = start + nodeSize;
   tr.insert(position, tr.doc.type.schema.nodes.paragraph.create());
-  return tr.setSelection(TextSelection.create(tr.doc, position));
+  return tr.setSelection(fg('platform_editor_controls_patch_14') ? TextSelection.near(tr.doc.resolve(position)) : TextSelection.create(tr.doc, position));
 };

package/dist/esm/pm-plugins/decorations-quick-insert-button.js

@@ -46,6 +46,10 @@ export var quickInsertButtonDecoration = function quickInsertButtonDecoration(ap
   };
   return Decoration.widget(rootPos, function (view, getPos) {
     var element = document.createElement('span');
+    if (fg('platform_editor_controls_patch_15')) {
+      // inline decoration causes cursor disappear when focusing editor at the first line (e.g. press Tab when title is focused)
+      element.style.display = 'block';
+    }
     element.contentEditable = 'false';
     element.setAttribute('data-blocks-quick-insert-container', 'true');
     element.setAttribute('data-testid', 'block-ctrl-quick-insert-button');

package/dist/esm/ui/quick-insert-button.js

@@ -244,7 +244,7 @@ export var TypeAheadControl = function TypeAheadControl(_ref) {
             });
           }
         }
-        if (currentSelection instanceof CellSelection && fg('platform_editor_controls_patch_4')) {
+        if (currentSelection instanceof CellSelection) {
           // find the last inline position in the selection
           var lastInlinePosition = TextSelection.near(view.state.selection.$to, -1);
           lastInlinePosition && api.core.actions.execute(function (_ref4) {
@@ -301,7 +301,7 @@ export var TypeAheadControl = function TypeAheadControl(_ref) {
     style: positionStyles,
     xcss: [containerStaticStyles, isTypeAheadOpen && !fg('platform_editor_controls_widget_visibility') && disabledContainerStyles]
   }, jsx("span", {
-    css: [tooltipContainerStyles, fg('platform_editor_controls_patch_4') && tooltipContainerStylesStickyHeader, fg('platform_editor_controls_patch_4') && tooltipContainerStylesStickyHeaderWithMarksFix]
+    css: [tooltipContainerStyles, tooltipContainerStylesStickyHeader, tooltipContainerStylesStickyHeaderWithMarksFix]
   }, tooltipPressable()));
 };
 export var QuickInsertWithVisibility = function QuickInsertWithVisibility(_ref5) {

package/dist/esm/ui/utils/editor-commands.js

@@ -1,4 +1,5 @@
 import { TextSelection } from '@atlaskit/editor-prosemirror/state';
+import { fg } from '@atlaskit/platform-feature-flags';
 export var createNewLine = function createNewLine(start) {
   return function (_ref) {
     var _tr$doc$nodeAt;
@@ -9,6 +10,6 @@ export var createNewLine = function createNewLine(start) {
     }
     var position = start + nodeSize;
     tr.insert(position, tr.doc.type.schema.nodes.paragraph.create());
-    return tr.setSelection(TextSelection.create(tr.doc, position));
+    return tr.setSelection(fg('platform_editor_controls_patch_14') ? TextSelection.near(tr.doc.resolve(position)) : TextSelection.create(tr.doc, position));
   };
 };

package/package.json

@@ -1,6 +1,6 @@
 {
 	"name": "@atlaskit/editor-plugin-block-controls",
-	"version": "3.19.9",
+	"version": "3.19.11",
 	"description": "Block controls plugin for @atlaskit/editor-core",
 	"author": "Atlassian Pty Ltd",
 	"license": "Apache-2.0",
@@ -33,7 +33,7 @@
 	},
 	"dependencies": {
 		"@atlaskit/adf-schema": "^47.6.0",
-		"@atlaskit/editor-common": "^107.1.0",
+		"@atlaskit/editor-common": "^107.3.0",
 		"@atlaskit/editor-plugin-accessibility-utils": "^2.0.0",
 		"@atlaskit/editor-plugin-analytics": "^2.3.0",
 		"@atlaskit/editor-plugin-editor-disabled": "^2.1.0",
@@ -48,15 +48,15 @@
 		"@atlaskit/editor-prosemirror": "7.0.0",
 		"@atlaskit/editor-shared-styles": "^3.4.0",
 		"@atlaskit/editor-tables": "^2.9.0",
-		"@atlaskit/icon": "^27.1.0",
+		"@atlaskit/icon": "^27.2.0",
 		"@atlaskit/link": "^3.2.0",
 		"@atlaskit/platform-feature-flags": "^1.1.0",
 		"@atlaskit/pragmatic-drag-and-drop": "^1.7.0",
 		"@atlaskit/pragmatic-drag-and-drop-auto-scroll": "^2.1.0",
 		"@atlaskit/pragmatic-drag-and-drop-react-drop-indicator": "^3.2.0",
-		"@atlaskit/primitives": "^14.9.0",
+		"@atlaskit/primitives": "^14.10.0",
 		"@atlaskit/theme": "^18.0.0",
-		"@atlaskit/tmp-editor-statsig": "^8.0.0",
+		"@atlaskit/tmp-editor-statsig": "^8.4.0",
 		"@atlaskit/tokens": "^5.4.0",
 		"@atlaskit/tooltip": "^20.3.0",
 		"@babel/runtime": "^7.0.0",
@@ -159,9 +159,6 @@
 		"platform_editor_controls_widget_visibility": {
 			"type": "boolean"
 		},
-		"platform_editor_controls_patch_4": {
-			"type": "boolean"
-		},
 		"platform_editor_no_cursor_on_live_doc_init": {
 			"type": "boolean"
 		},
@@ -183,11 +180,17 @@
 		"platform_editor_controls_patch_13": {
 			"type": "boolean"
 		},
+		"platform_editor_controls_patch_14": {
+			"type": "boolean"
+		},
 		"platform_editor_breakout_resizing_hello_release": {
 			"type": "boolean"
 		},
 		"platform_editor_block_controls_drop_target_mem_fix": {
 			"type": "boolean"
+		},
+		"platform_editor_controls_patch_15": {
+			"type": "boolean"
 		}
 	}
 }