@atlaskit/editor-plugin-block-controls 23.0.2 → 23.0.4

package/dist/esm/ui/block-controls-surface-drag-handle.js

@@ -18,14 +18,12 @@ import { blockControlsMessages } from '@atlaskit/editor-common/messages';
 import DragHandleVerticalIcon from '@atlaskit/icon/core/drag-handle-vertical';
 import { isExperimentEnabled } from '@atlaskit/platform-feature-experiments/is-experiment-enabled';
 import { fg } from '@atlaskit/platform-feature-flags/fg';
-import { expValEquals } from '@atlaskit/tmp-editor-statsig/exp-val-equals';
 import Tooltip from '@atlaskit/tooltip/Tooltip';
 import { selectionPreservationPluginKey } from '../pm-plugins/selection-preservation/plugin-key';
 import { prepareCollapsedHeadingSelection } from '../pm-plugins/utils/collapsed-heading';
 import { expandAndUpdateSelection } from '../pm-plugins/utils/expand-and-update-selection';
 import { isHandleCorrelatedToSelection } from '../pm-plugins/utils/getSelection';
 import { buildLayoutColumnMenuMeta } from './block-controls-surface-drag-handle-utils';
-import { DRAG_HANDLE_MAX_SHIFT_CLICK_DEPTH } from './consts';
 import { DragHandleNestedIcon } from './drag-handle-nested-icon';
 import { shouldUseNestedDragHandleIcon } from './should-use-nested-drag-handle-icon';
 import { useSurfaceEditorView } from './surface-editor-view-context';
@@ -82,19 +80,17 @@ export var BlockControlsSurfaceDragHandle = function BlockControlsSurfaceDragHan
     return posRef.current;
   }, []);
   var _useSharedPluginState = useSharedPluginStateWithSelector(api, ['blockControls', 'interaction', 'selection'], function (states) {
-      var _states$blockControls, _states$blockControls2, _states$interactionSt, _states$blockControls3, _states$selectionStat;
+      var _states$blockControls, _states$blockControls2, _states$interactionSt, _states$selectionStat;
       return {
         activeNodeAnchorName: (_states$blockControls = states.blockControlsState) === null || _states$blockControls === void 0 || (_states$blockControls = _states$blockControls.activeNode) === null || _states$blockControls === void 0 ? void 0 : _states$blockControls.anchorName,
         handleOptions: (_states$blockControls2 = states.blockControlsState) === null || _states$blockControls2 === void 0 || (_states$blockControls2 = _states$blockControls2.activeNode) === null || _states$blockControls2 === void 0 ? void 0 : _states$blockControls2.handleOptions,
         interactionState: (_states$interactionSt = states.interactionState) === null || _states$interactionSt === void 0 ? void 0 : _states$interactionSt.interactionState,
-        isShiftDown: (_states$blockControls3 = states.blockControlsState) === null || _states$blockControls3 === void 0 ? void 0 : _states$blockControls3.isShiftDown,
         selection: (_states$selectionStat = states.selectionState) === null || _states$selectionStat === void 0 ? void 0 : _states$selectionStat.selection
       };
     }),
     activeNodeAnchorName = _useSharedPluginState.activeNodeAnchorName,
     handleOptions = _useSharedPluginState.handleOptions,
     interactionState = _useSharedPluginState.interactionState,
-    isShiftDown = _useSharedPluginState.isShiftDown,
     selection = _useSharedPluginState.selection;
   var _useState = useState(false),
     _useState2 = _slicedToArray(_useState, 2),
@@ -105,21 +101,9 @@ export var BlockControlsSurfaceDragHandle = function BlockControlsSurfaceDragHan
   }, [pos, selection, view]);
   var isLayoutColumn = nodeType === 'layoutColumn';
   var isTopLevelNode = (activeNode === null || activeNode === void 0 ? void 0 : activeNode.parentType) === 'doc';
-  var isDisabled = useMemo(function () {
-    var _api$blockControls$sh;
-    if (!isShiftDown || !view || view.state.selection.empty || !fg('platform_editor_elements_dnd_shift_click_select')) {
-      return false;
-    }
-    if (isLayoutColumn && expValEquals('platform_editor_layout_column_menu', 'isEnabled', true)) {
-      return false;
-    }
-    var multiSelect = api === null || api === void 0 || (_api$blockControls$sh = api.blockControls.sharedState.currentState()) === null || _api$blockControls$sh === void 0 ? void 0 : _api$blockControls$sh.multiSelectDnD;
-    var $anchor = (multiSelect === null || multiSelect === void 0 ? void 0 : multiSelect.anchor) !== undefined ? view.state.doc.resolve(multiSelect.anchor) : view.state.selection.$anchor;
-    return !isTopLevelNode || $anchor.depth > DRAG_HANDLE_MAX_SHIFT_CLICK_DEPTH;
-  }, [api, isLayoutColumn, isShiftDown, isTopLevelNode, view]);
   var getAnchorName = useCallback(function () {
-    var _api$blockControls$sh2, _ref2, _ref3, _dom$getAttribute, _dom$closest;
-    var surfaceAnchor = posRef.current === undefined ? undefined : api === null || api === void 0 || (_api$blockControls$sh2 = api.blockControls.sharedState.currentState()) === null || _api$blockControls$sh2 === void 0 || (_api$blockControls$sh2 = _api$blockControls$sh2.surfaceAnchors) === null || _api$blockControls$sh2 === void 0 ? void 0 : _api$blockControls$sh2.get(posRef.current);
+    var _api$blockControls$sh, _ref2, _ref3, _dom$getAttribute, _dom$closest;
+    var surfaceAnchor = posRef.current === undefined ? undefined : api === null || api === void 0 || (_api$blockControls$sh = api.blockControls.sharedState.currentState()) === null || _api$blockControls$sh === void 0 || (_api$blockControls$sh = _api$blockControls$sh.surfaceAnchors) === null || _api$blockControls$sh === void 0 ? void 0 : _api$blockControls$sh.get(posRef.current);
     if (surfaceAnchor) {
       return surfaceAnchor;
     }
@@ -187,7 +171,7 @@ export var BlockControlsSurfaceDragHandle = function BlockControlsSurfaceDragHan
   }, [api]);
   var handleClick = useCallback(function (event) {
     var _api$core2;
-    if (!view || isDisabled) {
+    if (!view) {
       return;
     }
     var openedViaKeyboard = event.detail === 0;
@@ -198,7 +182,7 @@ export var BlockControlsSurfaceDragHandle = function BlockControlsSurfaceDragHan
       if (startPos === undefined) {
         return tr;
       }
-      if (nodeType === 'layoutColumn' && expValEquals('platform_editor_layout_column_menu', 'isEnabled', true)) {
+      if (nodeType === 'layoutColumn') {
         tr.setMeta('toggleLayoutColumnMenu', buildLayoutColumnMenuMeta(startPos, openedViaKeyboard));
       }
       var selection = (_selectionPreservatio = (_selectionPreservatio2 = selectionPreservationPluginKey.getState(view.state)) === null || _selectionPreservatio2 === void 0 ? void 0 : _selectionPreservatio2.preservedSelection) !== null && _selectionPreservatio !== void 0 ? _selectionPreservatio : tr.selection;
@@ -247,7 +231,7 @@ export var BlockControlsSurfaceDragHandle = function BlockControlsSurfaceDragHan
       return tr;
     });
     view.focus();
-  }, [activeNode === null || activeNode === void 0 ? void 0 : activeNode.rootPos, api, getAnchorName, getPos, isDisabled, nodeType, view]);
+  }, [activeNode === null || activeNode === void 0 ? void 0 : activeNode.rootPos, api, getAnchorName, getPos, nodeType, view]);
   var label = formatMessage(blockControlsMessages.dragToMoveClickToOpen, {
     br: ' '
   });
@@ -275,7 +259,6 @@ export var BlockControlsSurfaceDragHandle = function BlockControlsSurfaceDragHan
     ref: buttonRef,
     type: "button",
     "aria-label": label,
-    disabled: isDisabled,
     onClick: handleClick,
     onMouseDown: handleMouseDown
     // eslint-disable-next-line @atlaskit/design-system/no-direct-use-of-web-platform-drag-and-drop -- Pragmatic DnD owns this native drag source.

package/dist/esm/ui/consts.js

@@ -40,14 +40,6 @@ export var DRAG_HANDLE_LAYOUT_SECTION_TOP_ADJUSTMENT = 8;
 export var DRAG_HANDLE_PARAGRAPH_TOP_ADJUSTMENT = 2;
 export var DRAG_HANDLE_PARAGRAPH_SMALL_TOP_ADJUSTMENT = 0;
 export var DRAG_HANDLE_WRAPPED_MEDIA_EMBED_TOP_ADJUSTMENT = 8;
-
-/** We only want to shift-select nodes that are at the top level of a document.
- *  This is because funky things happen when selecting inside of tableCells, but we
- *  also want to avoid heavily nested cases to descope potential corner cases.
- *  Various top level nodes have their selection 'from' at depths other than 0,
- *  so we allow for some leniency to capture them all. e.g. Table is depth 3.
- */
-export var DRAG_HANDLE_MAX_SHIFT_CLICK_DEPTH = 3;
 export var STICKY_CONTROLS_TOP_MARGIN = 8;
 export var STICKY_CONTROLS_TOP_MARGIN_FOR_STICKY_HEADER = 24;
 export var QUICK_INSERT_HEIGHT = 24;

package/dist/esm/ui/drag-handle.js

@@ -39,7 +39,7 @@ import { getMultiSelectAnalyticsAttributes } from '../pm-plugins/utils/analytics
 import { getControlBottomCSSValue, getControlHeightCSSValue, getLeftPosition, getNodeHeight, getTopPosition, shouldBeSticky, shouldMaskNodeControls } from '../pm-plugins/utils/drag-handle-positions';
 import { expandAndUpdateSelection } from '../pm-plugins/utils/expand-and-update-selection';
 import { isHandleCorrelatedToSelection, selectNode } from '../pm-plugins/utils/getSelection';
-import { ACTIVE_DRAG_HANDLE_ATTR, ACTIVE_DRAG_HANDLE_FALLBACK_ANCHOR_NAME, DRAG_HANDLE_BORDER_RADIUS, DRAG_HANDLE_HEIGHT, DRAG_HANDLE_MAX_SHIFT_CLICK_DEPTH, DRAG_HANDLE_ZINDEX, dragHandleGap, nodeMargins, spacingBetweenNodesForPreview, STICKY_CONTROLS_TOP_MARGIN, STICKY_CONTROLS_TOP_MARGIN_FOR_STICKY_HEADER, topPositionAdjustment } from './consts';
+import { ACTIVE_DRAG_HANDLE_ATTR, ACTIVE_DRAG_HANDLE_FALLBACK_ANCHOR_NAME, DRAG_HANDLE_BORDER_RADIUS, DRAG_HANDLE_HEIGHT, DRAG_HANDLE_ZINDEX, dragHandleGap, nodeMargins, spacingBetweenNodesForPreview, STICKY_CONTROLS_TOP_MARGIN, STICKY_CONTROLS_TOP_MARGIN_FOR_STICKY_HEADER, topPositionAdjustment } from './consts';
 import { DragHandleNestedIcon } from './drag-handle-nested-icon';
 import { dragPreview } from './drag-preview';
 import { shouldUseNestedDragHandleIcon } from './should-use-nested-drag-handle-icon';
@@ -329,16 +329,12 @@ var getNodeMargins = function getNodeMargins(node) {
   return nodeMargins[nodeTypeName] || nodeMargins['default'];
 };
 
-// Kill switch OFF: omit `isOpen` so the reducer toggles per clicked column. ON: keep
-// `isOpen: true` for legacy always-open. Centralised so all dispatch sites stay in sync.
+// Omit `isOpen` so the reducer toggles the menu for a re-clicked layout column.
 var buildToggleLayoutColumnMenuMeta = function buildToggleLayoutColumnMenuMeta(anchorPos, openedViaKeyboard) {
-  return _objectSpread(_objectSpread({
-    anchorPos: anchorPos
-  }, fg('platform_editor_layout_column_menu_kill_switch_1') ? {
-    isOpen: true
-  } : {}), {}, {
+  return {
+    anchorPos: anchorPos,
     openedViaKeyboard: openedViaKeyboard
-  });
+  };
 };
 var getDragHandleAnchorReference = function getDragHandleAnchorReference(_ref) {
   var edge = _ref.edge,
@@ -349,7 +345,6 @@ var getDragHandleAnchorReference = function getDragHandleAnchorReference(_ref) {
   return "anchor(".concat(safeAnchorName, " ").concat(edge, ")");
 };
 export var DragHandle = function DragHandle(_ref2) {
-  var _api$blockControls7;
   var view = _ref2.view,
     api = _ref2.api,
     formatMessage = _ref2.formatMessage,
@@ -364,41 +359,35 @@ export var DragHandle = function DragHandle(_ref2) {
     _useState2 = _slicedToArray(_useState, 2),
     dragHandleSelected = _useState2[0],
     setDragHandleSelected = _useState2[1];
-  var _useState3 = useState(false),
+  var _useState3 = useState(768),
     _useState4 = _slicedToArray(_useState3, 2),
-    dragHandleDisabled = _useState4[0],
-    setDragHandleDisabled = _useState4[1];
-  var _useState5 = useState(768),
-    _useState6 = _slicedToArray(_useState5, 2),
-    blockCardWidth = _useState6[0],
-    setBlockCardWidth = _useState6[1];
-  var _useState7 = useState({
+    blockCardWidth = _useState4[0],
+    setBlockCardWidth = _useState4[1];
+  var _useState5 = useState({
       display: 'none'
     }),
-    _useState8 = _slicedToArray(_useState7, 2),
-    positionStylesOld = _useState8[0],
-    setPositionStylesOld = _useState8[1];
+    _useState6 = _slicedToArray(_useState5, 2),
+    positionStylesOld = _useState6[0],
+    setPositionStylesOld = _useState6[1];
   // Tracks whether the initial position calculation has been performed at least once.
   // The reliable-anchor early-return optimisation must not fire before the first calculation,
   // otherwise positionStylesOld stays as { display: 'none' } and the handle is never shown.
   var hasCalculatedInitialPosition = useRef(false);
-  var _useState9 = useState(Boolean(handleOptions === null || handleOptions === void 0 ? void 0 : handleOptions.isFocused)),
-    _useState0 = _slicedToArray(_useState9, 2),
-    isFocused = _useState0[0],
-    setIsFocused = _useState0[1];
+  var _useState7 = useState(Boolean(handleOptions === null || handleOptions === void 0 ? void 0 : handleOptions.isFocused)),
+    _useState8 = _slicedToArray(_useState7, 2),
+    isFocused = _useState8[0],
+    setIsFocused = _useState8[1];
   var _useSharedPluginState = useSharedPluginStateWithSelector(api, ['featureFlags', 'selection', 'blockControls', 'interaction', 'userIntent'], function (states) {
-      var _states$featureFlagsS, _states$selectionStat, _states$blockControls, _states$interactionSt, _states$userIntentSta;
+      var _states$featureFlagsS, _states$selectionStat, _states$interactionSt, _states$userIntentSta;
       return {
         macroInteractionUpdates: (_states$featureFlagsS = states.featureFlagsState) === null || _states$featureFlagsS === void 0 ? void 0 : _states$featureFlagsS.macroInteractionUpdates,
         selection: (_states$selectionStat = states.selectionState) === null || _states$selectionStat === void 0 ? void 0 : _states$selectionStat.selection,
-        isShiftDown: (_states$blockControls = states.blockControlsState) === null || _states$blockControls === void 0 ? void 0 : _states$blockControls.isShiftDown,
         interactionState: (_states$interactionSt = states.interactionState) === null || _states$interactionSt === void 0 ? void 0 : _states$interactionSt.interactionState,
         currentUserIntent: (_states$userIntentSta = states.userIntentState) === null || _states$userIntentSta === void 0 ? void 0 : _states$userIntentSta.currentUserIntent
       };
     }),
     macroInteractionUpdates = _useSharedPluginState.macroInteractionUpdates,
     selection = _useSharedPluginState.selection,
-    isShiftDown = _useSharedPluginState.isShiftDown,
     interactionState = _useSharedPluginState.interactionState,
     currentUserIntent = _useSharedPluginState.currentUserIntent;
   var start = getPos();
@@ -469,7 +458,7 @@ export var DragHandle = function DragHandle(_ref2) {
       if (startPos === undefined) {
         return tr;
       }
-      if (nodeType === 'layoutColumn' && expValEquals('platform_editor_layout_column_menu', 'isEnabled', true)) {
+      if (nodeType === 'layoutColumn') {
         tr.setMeta('toggleLayoutColumnMenu', buildToggleLayoutColumnMenuMeta(startPos, false));
       }
       var resolvedStartPos = tr.doc.resolve(startPos);
@@ -539,7 +528,7 @@ export var DragHandle = function DragHandle(_ref2) {
         api === null || api === void 0 || (_api$blockControls3 = api.blockControls) === null || _api$blockControls3 === void 0 || _api$blockControls3.commands.startPreservingSelection()({
           tr: tr
         });
-        if (nodeType === 'layoutColumn' && expValEquals('platform_editor_layout_column_menu', 'isEnabled', true)) {
+        if (nodeType === 'layoutColumn') {
           tr.setMeta('toggleLayoutColumnMenu', buildToggleLayoutColumnMenuMeta(startPos, true));
         }
         var triggerByNode = {
@@ -949,20 +938,6 @@ export var DragHandle = function DragHandle(_ref2) {
     }
     setDragHandleSelected(isHandleCorrelatedToSelection(view.state, selection, start));
   }, [start, selection, view]);
-  useEffect(function () {
-    var _api$blockControls$sh3;
-    if (isShiftDown === undefined || view.state.selection.empty || !fg('platform_editor_elements_dnd_shift_click_select')) {
-      return;
-    }
-    var mSelect = api === null || api === void 0 || (_api$blockControls$sh3 = api.blockControls.sharedState.currentState()) === null || _api$blockControls$sh3 === void 0 ? void 0 : _api$blockControls$sh3.multiSelectDnD;
-    var $anchor = (mSelect === null || mSelect === void 0 ? void 0 : mSelect.anchor) !== undefined ? view.state.doc.resolve(mSelect === null || mSelect === void 0 ? void 0 : mSelect.anchor) : view.state.selection.$anchor;
-    var isLayoutColumnMenuEnabled = expValEquals('platform_editor_layout_column_menu', 'isEnabled', true);
-    if (isShiftDown && !(isLayoutColumnMenuEnabled && isLayoutColumn) && (!isTopLevelNodeValue || isTopLevelNodeValue && $anchor.depth > DRAG_HANDLE_MAX_SHIFT_CLICK_DEPTH)) {
-      setDragHandleDisabled(true);
-    } else {
-      setDragHandleDisabled(false);
-    }
-  }, [api === null || api === void 0 || (_api$blockControls7 = api.blockControls) === null || _api$blockControls7 === void 0 ? void 0 : _api$blockControls7.sharedState, isLayoutColumn, isShiftDown, isTopLevelNodeValue, view]);
   var dragHandleMessage = formatMessage(blockControlsMessages.dragToMoveClickToOpen, {
     br: jsx("br", null)
   });
@@ -1064,7 +1039,6 @@ export var DragHandle = function DragHandle(_ref2) {
         // eslint-disable-next-line @atlaskit/design-system/no-direct-use-of-web-platform-drag-and-drop
         ,
         onDrop: handleOnDrop,
-        disabled: dragHandleDisabled,
         "data-editor-block-ctrl-drag-handle": true,
         "data-blocks-drag-handle": fg('confluence_remix_button_right_side_block_fg') || undefined,
         "data-testid": "block-ctrl-drag-handle",
@@ -1131,22 +1105,6 @@ export var DragHandle = function DragHandle(_ref2) {
       css: [shouldMaskNodeControls(nodeType, isTopLevelNodeValue) && buttonWrapperStylesNoBackground, buttonWrapperStylesPatch]
     }, renderButton()))));
   };
-  var stickyWithoutTooltip = function stickyWithoutTooltip() {
-    return jsx(Box
-    // eslint-disable-next-line @atlaskit/ui-styling-standard/enforce-style-prop
-    , {
-      style: positionStylesOld
-      // eslint-disable-next-line @atlassian/perf-linting/no-unstable-inline-props -- Ignored via go/ees017 (to be fixed)
-      ,
-      xcss: [dragHandleContainerStyles],
-      as: "span",
-      testId: "block-ctrl-drag-handle-container"
-    }, jsx("span", {
-      css: [tooltipContainerStyles, shouldMaskNodeControls(nodeType, isTopLevelNodeValue) && tooltipContainerStylesStickyHeaderWithMask, !shouldMaskNodeControls(nodeType, isTopLevelNodeValue) && tooltipContainerStylesStickyHeaderWithoutMask]
-    }, jsx("span", {
-      css: [shouldMaskNodeControls(nodeType, isTopLevelNodeValue) && buttonWrapperStylesNoBackground, buttonWrapperStylesPatch]
-    }, renderButton())));
-  };
   var buttonWithTooltip = function buttonWithTooltip() {
     return jsx(Tooltip, {
       content: tooltipContent,
@@ -1161,13 +1119,10 @@ export var DragHandle = function DragHandle(_ref2) {
       }
     }, renderButton());
   };
-  var tooltipContent = isLayoutColumn && expValEquals('platform_editor_layout_column_menu', 'isEnabled', true) && currentUserIntent === 'layoutColumnMenuPopupOpen' ? null : jsx(TooltipContentWithMultipleShortcuts, {
+  var tooltipContent = isLayoutColumn && currentUserIntent === 'layoutColumnMenuPopupOpen' ? null : jsx(TooltipContentWithMultipleShortcuts, {
     helpDescriptors: helpDescriptors
   });
-  var isTooltip = !dragHandleDisabled;
-  var stickyRender = isTooltip ? stickyWithTooltip() : stickyWithoutTooltip();
-  var render = isTooltip ? buttonWithTooltip() : renderButton();
-  return editorExperiment('platform_editor_controls', 'variant1') ? stickyRender : render;
+  return editorExperiment('platform_editor_controls', 'variant1') ? stickyWithTooltip() : buttonWithTooltip();
 };
 export var DragHandleWithVisibility = function DragHandleWithVisibility(_ref0) {
   var view = _ref0.view,
@@ -1180,9 +1135,9 @@ export var DragHandleWithVisibility = function DragHandleWithVisibility(_ref0) {
     isTopLevelNode = _ref0.isTopLevelNode,
     anchorRectCache = _ref0.anchorRectCache;
   var rightSideControlsEnabled = useSharedPluginStateWithSelector(api, ['blockControls'], function (states) {
-    var _states$blockControls2, _states$blockControls3;
+    var _states$blockControls, _states$blockControls2;
     return {
-      rightSideControlsEnabled: (_states$blockControls2 = (_states$blockControls3 = states.blockControlsState) === null || _states$blockControls3 === void 0 ? void 0 : _states$blockControls3.rightSideControlsEnabled) !== null && _states$blockControls2 !== void 0 ? _states$blockControls2 : false
+      rightSideControlsEnabled: (_states$blockControls = (_states$blockControls2 = states.blockControlsState) === null || _states$blockControls2 === void 0 ? void 0 : _states$blockControls2.rightSideControlsEnabled) !== null && _states$blockControls !== void 0 ? _states$blockControls : false
     };
   }).rightSideControlsEnabled;
   // Layout column drag handles sit at the top-centre of each column, not on a left/right edge.

package/dist/esm/ui/should-use-nested-drag-handle-icon.js

@@ -1,14 +1,9 @@
-import { fg } from '@atlaskit/platform-feature-flags/fg';
-
-// Nested icon for non-top-level nodes. Exception: with the
-// kill switch OFF, layout columns use the full block handle instead.
-// TODO: EDITOR-7732 - remove this whole function when
-// `platform_editor_layout_column_menu_kill_switch_1` is cleaned up
+// Nested layout columns use the full block handle; other non-top-level nodes use the nested icon.
 export var shouldUseNestedDragHandleIcon = function shouldUseNestedDragHandleIcon(isTopLevelNode, isLayoutColumn) {
   if (isTopLevelNode) {
     return false;
   }
-  if (isLayoutColumn && !fg('platform_editor_layout_column_menu_kill_switch_1')) {
+  if (isLayoutColumn) {
     return false;
   }
   return true;

package/dist/types/blockControlsPluginType.d.ts

@@ -74,7 +74,6 @@ export interface PluginState {
     isPMDragging: boolean;
     isResizerResizing: boolean;
     isSelectedViaDragHandle?: boolean;
-    isShiftDown?: boolean;
     lastDragCancelled: boolean;
     menuTriggerBy?: string;
     menuTriggerByNode?: TriggerByNode;
@@ -108,7 +107,6 @@ export type BlockControlsSharedState = {
     isMouseOut?: boolean;
     isPMDragging: boolean;
     isSelectedViaDragHandle?: boolean;
-    isShiftDown?: boolean;
     lastDragCancelled: boolean;
     menuTriggerBy?: string;
     menuTriggerByNode?: TriggerByNode;

package/dist/types/pm-plugins/main.d.ts

@@ -32,7 +32,6 @@ export declare const apply: (api: ExtractInjectionAPI<BlockControlsPlugin> | und
     isPMDragging: any;
     isResizerResizing: boolean;
     isSelectedViaDragHandle: any;
-    isShiftDown: any;
     lastDragCancelled: any;
     menuTriggerBy: any;
     menuTriggerByNode: any;
@@ -57,7 +56,6 @@ export declare const createPlugin: (api: ExtractInjectionAPI<BlockControlsPlugin
     isPMDragging: any;
     isResizerResizing: boolean;
     isSelectedViaDragHandle: any;
-    isShiftDown: any;
     lastDragCancelled: any;
     menuTriggerBy: any;
     menuTriggerByNode: any;

package/dist/types/pm-plugins/utils/selection.d.ts

@@ -1,7 +1,7 @@
 import type { ExtractInjectionAPI } from '@atlaskit/editor-common/types';
 import type { ResolvedPos } from '@atlaskit/editor-prosemirror/model';
-import { NodeSelection, TextSelection } from '@atlaskit/editor-prosemirror/state';
-import type { ReadonlyTransaction, Selection, Transaction } from '@atlaskit/editor-prosemirror/state';
+import { TextSelection } from '@atlaskit/editor-prosemirror/state';
+import type { NodeSelection, ReadonlyTransaction, Selection, Transaction } from '@atlaskit/editor-prosemirror/state';
 import type { CellSelection } from '@atlaskit/editor-tables';
 import type { BlockControlsPlugin } from '../../blockControlsPluginType';
 export declare const getMultiSelectionIfPosInside: (api: ExtractInjectionAPI<BlockControlsPlugin>, pos: number, tr?: Transaction) => {
@@ -21,18 +21,6 @@ export declare const getSelectedSlicePosition: (handlePos: number, tr: Transacti
     from: number;
     to: number;
 };
-/**
- * Takes a position and expands the selection to encompass the node at that position. Ignores empty or out of range selections.
- * Ignores positions that are in text blocks (i.e. not start of a node)
- * @returns TextSelection if expanded, otherwise returns Selection that was passed in.
- */
-export declare const expandSelectionHeadToNodeAtPos: (selection: Selection, nodePos: number) => Selection;
-/**
- * This swaps the anchor/head for NodeSelections when its anchor > pos.
- * This is because NodeSelection always has an anchor at the start of the node,
- * which may not align with the existing selection.
- */
-export declare const alignAnchorHeadInDirectionOfPos: (selection: Selection, pos: number) => Selection;
 /**
  * This maps a preserved selection through a transaction, expanding text selections to block boundaries.
  *

package/dist/types/ui/block-controls-surface-drag-handle-utils.d.ts

@@ -1,7 +1,6 @@
 import type { Node as PMNode } from '@atlaskit/editor-prosemirror/model';
 export declare const buildLayoutColumnMenuMeta: (anchorPos: number, openedViaKeyboard: boolean) => {
     anchorPos: number;
-    isOpen?: true;
     openedViaKeyboard: boolean;
 };
 export declare const getNodeSpacingForDragPreview: (node?: PMNode | null) => {

package/dist/types/ui/consts.d.ts

@@ -21,13 +21,6 @@ export declare const DRAG_HANDLE_LAYOUT_SECTION_TOP_ADJUSTMENT = 8;
 export declare const DRAG_HANDLE_PARAGRAPH_TOP_ADJUSTMENT = 2;
 export declare const DRAG_HANDLE_PARAGRAPH_SMALL_TOP_ADJUSTMENT = 0;
 export declare const DRAG_HANDLE_WRAPPED_MEDIA_EMBED_TOP_ADJUSTMENT = 8;
-/** We only want to shift-select nodes that are at the top level of a document.
- *  This is because funky things happen when selecting inside of tableCells, but we
- *  also want to avoid heavily nested cases to descope potential corner cases.
- *  Various top level nodes have their selection 'from' at depths other than 0,
- *  so we allow for some leniency to capture them all. e.g. Table is depth 3.
- */
-export declare const DRAG_HANDLE_MAX_SHIFT_CLICK_DEPTH = 3;
 export declare const STICKY_CONTROLS_TOP_MARGIN = 8;
 export declare const STICKY_CONTROLS_TOP_MARGIN_FOR_STICKY_HEADER = 24;
 export declare const QUICK_INSERT_HEIGHT = 24;

package/package.json

@@ -1,6 +1,6 @@
 {
 	"name": "@atlaskit/editor-plugin-block-controls",
-	"version": "23.0.2",
+	"version": "23.0.4",
 	"description": "Block controls plugin for @atlaskit/editor-core",
 	"author": "Atlassian Pty Ltd",
 	"license": "Apache-2.0",
@@ -51,7 +51,7 @@
 		"@atlaskit/editor-tables": "^3.2.0",
 		"@atlaskit/editor-ui-control-model": "^2.10.0",
 		"@atlaskit/icon": "^38.0.0",
-		"@atlaskit/icon-lab": "^7.10.0",
+		"@atlaskit/icon-lab": "^7.11.0",
 		"@atlaskit/link": "^5.1.0",
 		"@atlaskit/platform-feature-experiments": "^0.3.0",
 		"@atlaskit/platform-feature-flags": "^2.2.0",
@@ -61,7 +61,7 @@
 		"@atlaskit/primitives": "^22.5.0",
 		"@atlaskit/section-message": "^10.2.0",
 		"@atlaskit/theme": "^28.2.0",
-		"@atlaskit/tmp-editor-statsig": "^211.0.0",
+		"@atlaskit/tmp-editor-statsig": "^213.0.0",
 		"@atlaskit/tokens": "^20.1.0",
 		"@atlaskit/tooltip": "^24.3.0",
 		"@babel/runtime": "^7.0.0",
@@ -73,15 +73,12 @@
 		"uuid": "^11.1.1"
 	},
 	"peerDependencies": {
-		"@atlaskit/editor-common": "^126.1.0",
+		"@atlaskit/editor-common": "^126.2.0",
 		"react": "^18.2.0 || ^19.2.0",
 		"react-dom": "^18.2.0 || ^19.2.0",
 		"react-intl": "^5.25.1 || ^6.0.0 || ^7.0.0"
 	},
 	"platform-feature-flags": {
-		"platform_editor_elements_dnd_shift_click_select": {
-			"type": "boolean"
-		},
 		"platform_editor_ease_of_use_metrics": {
 			"type": "boolean"
 		},
@@ -103,10 +100,6 @@
 		"platform_editor_controls_reliable_anchor_patch_1": {
 			"type": "boolean"
 		},
-		"platform_editor_layout_column_menu_kill_switch_1": {
-			"type": "boolean",
-			"referenceOnly": true
-		},
 		"platform-dst-top-layer-tooltip": {
 			"type": "boolean",
 			"referenceOnly": true