@atlaskit/editor-plugin-block-controls 20.1.4 → 20.1.5

package/CHANGELOG.md

@@ -1,5 +1,14 @@
 # @atlaskit/editor-plugin-block-controls
 
+## 20.1.5
+
+### Patch Changes
+
+- [`b03ff8f616c5c`](https://bitbucket.org/atlassian/atlassian-frontend-monorepo/commits/b03ff8f616c5c) -
+  EDITOR-9229: Fixed the block-controls surface anchor for `table` nodes matching any
+  `.resizer-item` in the table's subtree, which caused the table's anchor-name to be assigned to a
+  nested `mediaSingle`/ embed resizer inside a table cell instead of the table's own resize-handle.
+
 ## 20.1.4
 
 ### Patch Changes

package/dist/cjs/ui/global-styles.js

@@ -431,12 +431,19 @@ var sparseSurfaceAnchorStyles = (0, _react.css)({
     '[data-block-controls-surface-anchor][data-block-controls-surface-node-type="multiBodiedExtension"]:not(:has(.extension-container[data-layout]))': {
       anchorName: sparseSurfaceAnchorName
     },
+    // `.pm-table-resizer-container` wraps the ENTIRE table, including cell content, so a
+    // nested `mediaSingle`/ embed resizer inside a cell is also a descendant of it — a plain
+    // descendant selector can't tell the table's own resize handle apart from a media resizer.
+    // The table's own `.resizer-item.display-handle` is a direct child of
+    // `.pm-table-resizer-container`, while any nested cell content sits many levels deeper, so
+    // the `>` direct child combinator is required to avoid hijacking the table's anchor-name
+    // onto a nested cell's media resizer instead of the table's own resize-handle chrome.
     // eslint-disable-next-line @atlaskit/ui-styling-standard/no-nested-selectors, @atlaskit/ui-styling-standard/no-unsafe-selectors
-    '[data-block-controls-surface-anchor][data-block-controls-surface-node-type="table"]:has(.resizer-item) .resizer-item': {
+    '[data-block-controls-surface-anchor][data-block-controls-surface-node-type="table"]:has(.pm-table-resizer-container > .resizer-item) .pm-table-resizer-container > .resizer-item': {
       anchorName: sparseSurfaceAnchorName
     },
     // eslint-disable-next-line @atlaskit/ui-styling-standard/no-nested-selectors, @atlaskit/ui-styling-standard/no-unsafe-selectors
-    '[data-block-controls-surface-anchor][data-block-controls-surface-node-type="table"]:not(:has(.resizer-item))': {
+    '[data-block-controls-surface-anchor][data-block-controls-surface-node-type="table"]:not(:has(.pm-table-resizer-container > .resizer-item))': {
       anchorName: sparseSurfaceAnchorName
     }
   }

package/dist/es2019/ui/global-styles.js

@@ -517,12 +517,19 @@ const sparseSurfaceAnchorStyles = css({
     '[data-block-controls-surface-anchor][data-block-controls-surface-node-type="multiBodiedExtension"]:not(:has(.extension-container[data-layout]))': {
       anchorName: sparseSurfaceAnchorName
     },
+    // `.pm-table-resizer-container` wraps the ENTIRE table, including cell content, so a
+    // nested `mediaSingle`/ embed resizer inside a cell is also a descendant of it — a plain
+    // descendant selector can't tell the table's own resize handle apart from a media resizer.
+    // The table's own `.resizer-item.display-handle` is a direct child of
+    // `.pm-table-resizer-container`, while any nested cell content sits many levels deeper, so
+    // the `>` direct child combinator is required to avoid hijacking the table's anchor-name
+    // onto a nested cell's media resizer instead of the table's own resize-handle chrome.
     // eslint-disable-next-line @atlaskit/ui-styling-standard/no-nested-selectors, @atlaskit/ui-styling-standard/no-unsafe-selectors
-    '[data-block-controls-surface-anchor][data-block-controls-surface-node-type="table"]:has(.resizer-item) .resizer-item': {
+    '[data-block-controls-surface-anchor][data-block-controls-surface-node-type="table"]:has(.pm-table-resizer-container > .resizer-item) .pm-table-resizer-container > .resizer-item': {
       anchorName: sparseSurfaceAnchorName
     },
     // eslint-disable-next-line @atlaskit/ui-styling-standard/no-nested-selectors, @atlaskit/ui-styling-standard/no-unsafe-selectors
-    '[data-block-controls-surface-anchor][data-block-controls-surface-node-type="table"]:not(:has(.resizer-item))': {
+    '[data-block-controls-surface-anchor][data-block-controls-surface-node-type="table"]:not(:has(.pm-table-resizer-container > .resizer-item))': {
       anchorName: sparseSurfaceAnchorName
     }
   }

package/dist/esm/ui/global-styles.js

@@ -424,12 +424,19 @@ var sparseSurfaceAnchorStyles = css({
     '[data-block-controls-surface-anchor][data-block-controls-surface-node-type="multiBodiedExtension"]:not(:has(.extension-container[data-layout]))': {
       anchorName: sparseSurfaceAnchorName
     },
+    // `.pm-table-resizer-container` wraps the ENTIRE table, including cell content, so a
+    // nested `mediaSingle`/ embed resizer inside a cell is also a descendant of it — a plain
+    // descendant selector can't tell the table's own resize handle apart from a media resizer.
+    // The table's own `.resizer-item.display-handle` is a direct child of
+    // `.pm-table-resizer-container`, while any nested cell content sits many levels deeper, so
+    // the `>` direct child combinator is required to avoid hijacking the table's anchor-name
+    // onto a nested cell's media resizer instead of the table's own resize-handle chrome.
     // eslint-disable-next-line @atlaskit/ui-styling-standard/no-nested-selectors, @atlaskit/ui-styling-standard/no-unsafe-selectors
-    '[data-block-controls-surface-anchor][data-block-controls-surface-node-type="table"]:has(.resizer-item) .resizer-item': {
+    '[data-block-controls-surface-anchor][data-block-controls-surface-node-type="table"]:has(.pm-table-resizer-container > .resizer-item) .pm-table-resizer-container > .resizer-item': {
       anchorName: sparseSurfaceAnchorName
     },
     // eslint-disable-next-line @atlaskit/ui-styling-standard/no-nested-selectors, @atlaskit/ui-styling-standard/no-unsafe-selectors
-    '[data-block-controls-surface-anchor][data-block-controls-surface-node-type="table"]:not(:has(.resizer-item))': {
+    '[data-block-controls-surface-anchor][data-block-controls-surface-node-type="table"]:not(:has(.pm-table-resizer-container > .resizer-item))': {
       anchorName: sparseSurfaceAnchorName
     }
   }

package/package.json

@@ -1,6 +1,6 @@
 {
 	"name": "@atlaskit/editor-plugin-block-controls",
-	"version": "20.1.4",
+	"version": "20.1.5",
 	"description": "Block controls plugin for @atlaskit/editor-core",
 	"author": "Atlassian Pty Ltd",
 	"license": "Apache-2.0",