@atlaskit/editor-plugin-block-controls 1.10.6 → 1.11.0

package/dist/esm/pm-plugins/decorations.js

@@ -7,9 +7,26 @@ import { Decoration } from '@atlaskit/editor-prosemirror/view';
 import { fg } from '@atlaskit/platform-feature-flags';
 import { DragHandle } from '../ui/drag-handle';
 import { DropTarget } from '../ui/drop-target';
+import { isBlocksDragTargetDebug } from '../utils/drag-target-debug';
 import { canMoveToIndex } from '../utils/validation';
-var IGNORE_NODES = ['tableCell', 'tableHeader', 'tableRow', 'layoutColumn'];
-var NESTED_DEPTH = fg('platform_editor_elements_dnd_nested') ? 100 : 0;
+var IGNORE_NODES = ['tableCell', 'tableHeader', 'tableRow', 'layoutColumn', 'listItem'];
+var IGNORE_NODES_AND_DESCENDANTS = ['listItem'];
+var PARENT_WITH_END_DROP_TARGET = ['tableCell', 'tableHeader', 'panel', 'layoutColumn', 'expand', 'nestedExpand'];
+var getNestedDepth = function getNestedDepth() {
+  return fg('platform_editor_elements_dnd_nested') ? 100 : 0;
+};
+var createDropTargetDecoration = function createDropTargetDecoration(pos, dropTargetDec) {
+  return Decoration.widget(pos, function () {
+    var element = document.createElement('div');
+    element.setAttribute('data-blocks-drop-target-container', 'true');
+    element.style.clear = 'unset';
+    ReactDOM.render(dropTargetDec, element);
+    return element;
+  }, {
+    type: 'drop-target-decoration',
+    side: -1
+  });
+};
 export var dropTargetDecorations = function dropTargetDecorations(oldState, newState, api, formatMessage, activeNodeType) {
   var decs = [];
   unmountDecorations('data-blocks-drop-target-container');
@@ -17,53 +34,61 @@ export var dropTargetDecorations = function dropTargetDecorations(oldState, newS
   // and allows us to easily map the updated position in the plugin apply method.
   var decorationState = [];
   var prevNode;
-  var state = fg('platform_editor_element_drag_and_drop_ed_24372') ? newState : oldState;
-  state.doc.nodesBetween(0, newState.doc.nodeSize - 2, function (node, pos, parent, index) {
+  newState.doc.nodesBetween(0, newState.doc.nodeSize - 2, function (node, pos, parent, index) {
     var depth = 0;
     var nodeType = newState.doc.type.schema.nodes[activeNodeType];
+    var endDec = null;
     if (fg('platform_editor_elements_dnd_nested')) {
       depth = newState.doc.resolve(pos).depth;
-      if (node.isInline) {
+      if (node.isInline || !parent) {
         return false;
       }
       if (IGNORE_NODES.includes(node.type.name)) {
         return true; //skip over, don't consider it a valid depth
       }
-      var canDrop = parent && activeNodeType && canMoveToIndex(parent, index, nodeType);
+      var canDrop = activeNodeType && canMoveToIndex(parent, index, nodeType);
 
       //NOTE: This will block drop targets showing for nodes that are valid after transformation (i.e. expand -> nestedExpand)
-      if (!canDrop) {
+      if (!canDrop && !isBlocksDragTargetDebug()) {
         return false; //not valid pos, so nested not valid either
       }
       decorationState.push({
         id: pos,
         pos: pos
       });
+      if (parent.lastChild === node && PARENT_WITH_END_DROP_TARGET.includes(parent.type.name)) {
+        var endpos = pos + node.nodeSize;
+        endDec = {
+          id: endpos,
+          pos: endpos
+        };
+        decorationState.push({
+          id: endpos,
+          pos: endpos
+        });
+      }
     } else {
       decorationState.push({
         id: index,
         pos: pos
       });
     }
-    var dropTargetDec = /*#__PURE__*/createElement(DropTarget, {
+    decs.push(createDropTargetDecoration(pos, /*#__PURE__*/createElement(DropTarget, {
       api: api,
       id: fg('platform_editor_elements_dnd_nested') ? pos : index,
       formatMessage: formatMessage,
       prevNode: prevNode,
       nextNode: node
-    });
-    decs.push(Decoration.widget(pos, function () {
-      var element = document.createElement('div');
-      element.setAttribute('data-blocks-drop-target-container', 'true');
-      element.style.clear = 'unset';
-      ReactDOM.render(dropTargetDec, element);
-      return element;
-    }, {
-      type: 'drop-target-decoration',
-      side: -1
-    }));
+    })));
+    if (endDec) {
+      decs.push(createDropTargetDecoration(endDec.pos, /*#__PURE__*/createElement(DropTarget, {
+        api: api,
+        id: endDec.id,
+        formatMessage: formatMessage
+      })));
+    }
     prevNode = node;
-    return depth < NESTED_DEPTH;
+    return depth < getNestedDepth();
   });
 
   /**
@@ -73,7 +98,6 @@ export var dropTargetDecorations = function dropTargetDecorations(oldState, newS
    * node and not its size.
    *
    */
-
   var lastPos = newState.doc.content.size;
   if (fg('platform_editor_elements_dnd_nested')) {
     decorationState.push({
@@ -114,12 +138,13 @@ export var emptyParagraphNodeDecorations = function emptyParagraphNodeDecoration
 };
 export var nodeDecorations = function nodeDecorations(newState) {
   var decs = [];
-  newState.doc.descendants(function (node, pos, _parent, index) {
+  newState.doc.descendants(function (node, pos, parent, index) {
     var _Decoration$node2;
     var depth = 0;
     var anchorName;
     if (fg('platform_editor_elements_dnd_nested')) {
-      if (node.isInline) {
+      // Doesn't descend into a node
+      if (node.isInline || IGNORE_NODES_AND_DESCENDANTS.includes((parent === null || parent === void 0 ? void 0 : parent.type.name) || '')) {
         return false;
       }
       if (IGNORE_NODES.includes(node.type.name)) {
@@ -135,15 +160,14 @@ export var nodeDecorations = function nodeDecorations(newState) {
     }, _defineProperty(_Decoration$node2, 'data-drag-handler-anchor-name', anchorName), _defineProperty(_Decoration$node2, 'data-drag-handler-node-type', node.type.name), _defineProperty(_Decoration$node2, 'data-drag-handler-anchor-depth', "".concat(depth)), _Decoration$node2), {
       type: 'node-decoration'
     }));
-    return depth < NESTED_DEPTH;
+    return depth < getNestedDepth();
   });
   return decs;
 };
 export var dragHandleDecoration = function dragHandleDecoration(api, getIntl, pos, anchorName, nodeType, handleOptions) {
   var unbind;
-  var elementType = fg('platform_editor_element_drag_and_drop_ed_24150') ? 'span' : 'div';
   return Decoration.widget(pos, function (view, getPos) {
-    var element = document.createElement(elementType);
+    var element = document.createElement('span');
     // Need to set it to inline to avoid text being split when merging two paragraphs
     element.style.display = 'inline';
     element.setAttribute('data-testid', 'block-ctrl-decorator-widget');
@@ -156,9 +180,7 @@ export var dragHandleDecoration = function dragHandleDecoration(api, getIntl, po
         }
       });
     }
-    if (fg('platform_editor_element_drag_and_drop_ed_23896')) {
-      unmountDecorations('data-blocks-drag-handle-container');
-    }
+    unmountDecorations('data-blocks-drag-handle-container');
 
     // There are times when global clear: "both" styles are applied to this decoration causing jumpiness
     // due to margins applied to other nodes eg. Headings
@@ -177,13 +199,10 @@ export var dragHandleDecoration = function dragHandleDecoration(api, getIntl, po
   }, {
     side: -1,
     id: 'drag-handle',
-    destroy: function destroy(node) {
+    destroy: function destroy() {
       if (fg('platform_editor_elements_dnd_nested')) {
         unbind && unbind();
       }
-      if (!fg('platform_editor_element_drag_and_drop_ed_23896')) {
-        ReactDOM.unmountComponentAtNode(node);
-      }
     }
   });
 };

package/dist/esm/pm-plugins/main.js

@@ -1,6 +1,5 @@
 import _toConsumableArray from "@babel/runtime/helpers/toConsumableArray";
 import rafSchedule from 'raf-schd';
-import { AnalyticsStep } from '@atlaskit/adf-schema/steps';
 import { ACTION, ACTION_SUBJECT, ACTION_SUBJECT_ID, EVENT_TYPE } from '@atlaskit/editor-common/analytics';
 import { SafePlugin } from '@atlaskit/editor-common/safe-plugin';
 import { browser } from '@atlaskit/editor-common/utils';
@@ -86,7 +85,7 @@ export var createPlugin = function createPlugin(api, getIntl) {
         return initialState;
       },
       apply: function apply(tr, currentState, oldState, newState) {
-        var _meta$activeNode, _meta$activeNode$hand, _meta$activeNode4, _meta$isDragging, _meta$editorHeight, _meta$editorWidthLeft, _meta$editorWidthRigh, _meta$isPMDragging;
+        var _meta$activeNode, _meta$activeNode$hand, _activeNodeWithNewNod, _meta$activeNode3, _meta$isDragging, _meta$editorHeight, _meta$editorWidthLeft, _meta$editorWidthRigh, _meta$isPMDragging;
         var activeNode = currentState.activeNode,
           decorations = currentState.decorations,
           isMenuOpen = currentState.isMenuOpen,
@@ -99,20 +98,12 @@ export var createPlugin = function createPlugin(api, getIntl) {
           isPMDragging = currentState.isPMDragging;
         var activeNodeWithNewNodeType = null;
         var meta = tr.getMeta(key);
-        // when creating analytics during drag/drop events, PM thinks the doc has changed
-        // so tr.docChange is true and causes some decorations to not render
-        var isAnalyticTr = tr.steps.every(function (step) {
-          return step instanceof AnalyticsStep;
-        });
 
         // If tables or media are being resized, we want to hide the drag handle
         var resizerMeta = tr.getMeta('is-resizer-resizing');
         isResizerResizing = resizerMeta !== null && resizerMeta !== void 0 ? resizerMeta : isResizerResizing;
         var nodeCountChanged = oldState.doc.childCount !== newState.doc.childCount;
-        var shouldRemoveHandle = true;
-        if (fg('platform_editor_elements_drag_and_drop_ed_24000')) {
-          shouldRemoveHandle = !tr.getMeta('isRemote');
-        }
+        var shouldRemoveHandle = !tr.getMeta('isRemote');
 
         // During resize, remove the drag handle widget so its dom positioning doesn't need to be maintained
         // Also remove the handle when the node is moved or the node count changes. This helps prevent incorrect positioning
@@ -140,16 +131,14 @@ export var createPlugin = function createPlugin(api, getIntl) {
         if (!fg('platform_editor_elements_dnd_nested')) {
           isDecsMissing = !(isDragging || meta !== null && meta !== void 0 && meta.isDragging) && decsLength !== newState.doc.childCount;
         }
-        if (fg('platform_editor_element_drag_and_drop_ed_24372')) {
-          var dropTargetLen = decorations.find().filter(function (_ref8) {
-            var spec = _ref8.spec;
-            return spec.type === 'drop-target-decoration';
-          }).length;
+        var dropTargetLen = decorations.find().filter(function (_ref8) {
+          var spec = _ref8.spec;
+          return spec.type === 'drop-target-decoration';
+        }).length;
 
-          //TODO: Fix this logic for nested scenarios
-          if (!fg('platform_editor_elements_dnd_nested')) {
-            isDropTargetsMissing = isDragging && (meta === null || meta === void 0 ? void 0 : meta.isDragging) !== false && dropTargetLen !== newState.doc.childCount + 1;
-          }
+        //TODO: Fix this logic for nested scenarios
+        if (!fg('platform_editor_elements_dnd_nested')) {
+          isDropTargetsMissing = isDragging && (meta === null || meta === void 0 ? void 0 : meta.isDragging) !== false && dropTargetLen !== newState.doc.childCount + 1;
         }
 
         // This is not targeted enough - it's trying to catch events like expand being set to breakout
@@ -168,15 +157,11 @@ export var createPlugin = function createPlugin(api, getIntl) {
 
         // Draw node and mouseWrapper decorations at top level node if decorations is empty, editor height changes or node is moved
         if (redrawDecorations && !isResizerResizing && api) {
-          if (fg('platform_editor_elements_drag_and_drop_ed_24000')) {
-            var oldNodeDecs = decorations.find().filter(function (_ref9) {
-              var spec = _ref9.spec;
-              return spec.type !== 'drop-target-decoration';
-            });
-            decorations = decorations.remove(oldNodeDecs);
-          } else {
-            decorations = DecorationSet.create(newState.doc, []);
-          }
+          var oldNodeDecs = decorations.find().filter(function (_ref9) {
+            var spec = _ref9.spec;
+            return spec.type !== 'drop-target-decoration';
+          });
+          decorations = decorations.remove(oldNodeDecs);
           var nodeDecs = nodeDecorations(newState);
           decorations = decorations.add(newState.doc, _toConsumableArray(nodeDecs));
 
@@ -188,9 +173,7 @@ export var createPlugin = function createPlugin(api, getIntl) {
 
             // When a node type changed to be nested inside another node, the position of the active node is off by 1
             // This is a workaround to fix the position of the active node when it is nested
-
-            var shouldUpdateNestedPosition = fg('platform_editor_element_drag_and_drop_ed_24049') ? tr.docChanged && !nodeCountChanged : true;
-            if (shouldUpdateNestedPosition && mappedPosisiton === prevMappedPos + 1) {
+            if (tr.docChanged && !nodeCountChanged && mappedPosisiton === prevMappedPos + 1) {
               mappedPosisiton = prevMappedPos;
             }
             var newActiveNode = tr.doc.nodeAt(mappedPosisiton);
@@ -220,90 +203,50 @@ export var createPlugin = function createPlugin(api, getIntl) {
           var decs = dragHandleDecoration(api, getIntl, meta.activeNode.pos, meta.activeNode.anchorName, meta.activeNode.nodeType, meta.activeNode.handleOptions);
           decorations = decorations.add(newState.doc, [decs]);
         }
-        if (fg('platform.editor.elements.drag-and-drop-ed-23816')) {
-          var _activeNodeWithNewNod;
-          // Remove previous drag handle widget and draw new drag handle widget when node type changes
-          if (activeNodeWithNewNodeType && ((_activeNodeWithNewNod = activeNodeWithNewNodeType) === null || _activeNodeWithNewNod === void 0 ? void 0 : _activeNodeWithNewNod.nodeType) !== (activeNode === null || activeNode === void 0 ? void 0 : activeNode.nodeType) && api) {
-            var _oldHandle2 = decorations.find().filter(function (_ref11) {
-              var spec = _ref11.spec;
-              return spec.id === 'drag-handle';
-            });
-            decorations = decorations.remove(_oldHandle2);
-            var _decs = dragHandleDecoration(api, getIntl, activeNodeWithNewNodeType.pos, activeNodeWithNewNodeType.anchorName, activeNodeWithNewNodeType.nodeType);
-            decorations = decorations.add(newState.doc, [_decs]);
-          }
+
+        // Remove previous drag handle widget and draw new drag handle widget when node type changes
+        if (activeNodeWithNewNodeType && ((_activeNodeWithNewNod = activeNodeWithNewNodeType) === null || _activeNodeWithNewNod === void 0 ? void 0 : _activeNodeWithNewNod.nodeType) !== (activeNode === null || activeNode === void 0 ? void 0 : activeNode.nodeType) && api) {
+          var _oldHandle2 = decorations.find().filter(function (_ref11) {
+            var spec = _ref11.spec;
+            return spec.id === 'drag-handle';
+          });
+          decorations = decorations.remove(_oldHandle2);
+          var _decs = dragHandleDecoration(api, getIntl, activeNodeWithNewNodeType.pos, activeNodeWithNewNodeType.anchorName, activeNodeWithNewNodeType.nodeType);
+          decorations = decorations.add(newState.doc, [_decs]);
         }
         var shouldUpdateDropTargets = (meta === null || meta === void 0 ? void 0 : meta.isDragging) || isDropTargetsMissing;
-        var shouldMapDropTargets = false;
-        if (fg('platform_editor_element_drag_and_drop_ed_24372')) {
-          shouldMapDropTargets = !shouldUpdateDropTargets && tr.docChanged && isDragging && (meta === null || meta === void 0 ? void 0 : meta.isDragging) !== false && !(meta !== null && meta !== void 0 && meta.nodeMoved);
-          if ((meta === null || meta === void 0 ? void 0 : meta.isDragging) === false || isDropTargetsMissing) {
-            // Remove drop target decoration when dragging stops
-            var dropTargetDecs = decorations.find().filter(function (_ref12) {
-              var spec = _ref12.spec;
-              return spec.type === 'drop-target-decoration';
-            });
-            decorations = decorations.remove(dropTargetDecs);
-          }
-          if (api) {
-            // Add drop targets when node is being dragged
-            // if the transaction is only for analytics and user is dragging, continue to draw drop targets
-            if (shouldUpdateDropTargets || isBlocksDragTargetDebug()) {
-              var _meta$activeNode2;
-              var _dropTargetDecoration = dropTargetDecorations(oldState, newState, api, formatMessage, meta === null || meta === void 0 || (_meta$activeNode2 = meta.activeNode) === null || _meta$activeNode2 === void 0 ? void 0 : _meta$activeNode2.nodeType),
-                _decs2 = _dropTargetDecoration.decs,
-                updatedDecorationState = _dropTargetDecoration.decorationState;
-              decorationState = updatedDecorationState;
-              decorations = decorations.add(newState.doc, _decs2);
-            }
-          }
-
-          //Map drop target decoration positions when the document changes
-          if (shouldMapDropTargets) {
-            decorationState = decorationState.map(function (_ref13) {
-              var id = _ref13.id,
-                pos = _ref13.pos;
-              return {
-                id: id,
-                pos: tr.mapping.map(pos)
-              };
-            });
-          }
-        } else {
-          if (api) {
-            // Add drop targets when node is being dragged
-            // if the transaction is only for analytics and user is dragging, continue to draw drop targets
-            var shouldShowDragTarget = (meta === null || meta === void 0 ? void 0 : meta.isDragging) && (!tr.docChanged || tr.docChanged && isAnalyticTr);
-            if (shouldShowDragTarget || isBlocksDragTargetDebug()) {
-              var _meta$activeNode3;
-              var _dropTargetDecoration2 = dropTargetDecorations(oldState, newState, api, formatMessage, meta === null || meta === void 0 || (_meta$activeNode3 = meta.activeNode) === null || _meta$activeNode3 === void 0 ? void 0 : _meta$activeNode3.nodeType),
-                _decs3 = _dropTargetDecoration2.decs,
-                _updatedDecorationState = _dropTargetDecoration2.decorationState;
-              decorationState = _updatedDecorationState;
-              decorations = decorations.add(newState.doc, _decs3);
-            }
-          }
-
+        var shouldMapDropTargets = !shouldUpdateDropTargets && tr.docChanged && isDragging && (meta === null || meta === void 0 ? void 0 : meta.isDragging) !== false && !(meta !== null && meta !== void 0 && meta.nodeMoved);
+        if ((meta === null || meta === void 0 ? void 0 : meta.isDragging) === false || isDropTargetsMissing) {
           // Remove drop target decoration when dragging stops
-          if ((meta === null || meta === void 0 ? void 0 : meta.isDragging) === false && (fg('platform_editor_element_drag_and_drop_ed_24330') ? true : !tr.docChanged)) {
-            var _dropTargetDecs = decorations.find().filter(function (_ref14) {
-              var spec = _ref14.spec;
-              return spec.type === 'drop-target-decoration';
-            });
-            decorations = decorations.remove(_dropTargetDecs);
+          var dropTargetDecs = decorations.find().filter(function (_ref12) {
+            var spec = _ref12.spec;
+            return spec.type === 'drop-target-decoration';
+          });
+          decorations = decorations.remove(dropTargetDecs);
+        }
+        if (api) {
+          // Add drop targets when node is being dragged
+          // if the transaction is only for analytics and user is dragging, continue to draw drop targets
+          if (shouldUpdateDropTargets || isBlocksDragTargetDebug()) {
+            var _meta$activeNode2;
+            var _dropTargetDecoration = dropTargetDecorations(oldState, newState, api, formatMessage, meta === null || meta === void 0 || (_meta$activeNode2 = meta.activeNode) === null || _meta$activeNode2 === void 0 ? void 0 : _meta$activeNode2.nodeType),
+              _decs2 = _dropTargetDecoration.decs,
+              updatedDecorationState = _dropTargetDecoration.decorationState;
+            decorationState = updatedDecorationState;
+            decorations = decorations.add(newState.doc, _decs2);
           }
+        }
 
-          // Map drop target decoration positions when the document changes
-          if (tr.docChanged && isDragging) {
-            decorationState = decorationState.map(function (_ref15) {
-              var id = _ref15.id,
-                pos = _ref15.pos;
-              return {
-                id: id,
-                pos: tr.mapping.map(pos)
-              };
-            });
-          }
+        //Map drop target decoration positions when the document changes
+        if (shouldMapDropTargets) {
+          decorationState = decorationState.map(function (_ref13) {
+            var id = _ref13.id,
+              pos = _ref13.pos;
+            return {
+              id: id,
+              pos: tr.mapping.map(pos)
+            };
+          });
         }
 
         // Map decorations if document changes and node decorations do not need to be redrawn
@@ -311,8 +254,8 @@ export var createPlugin = function createPlugin(api, getIntl) {
           decorations = decorations.map(tr.mapping, tr.doc);
         }
         var isEmptyDoc = newState.doc.childCount === 1 && newState.doc.nodeSize <= 4;
-        var hasNodeDecoration = decorations.find().some(function (_ref16) {
-          var spec = _ref16.spec;
+        var hasNodeDecoration = decorations.find().some(function (_ref14) {
+          var spec = _ref14.spec;
           return spec.type === 'node-decoration';
         });
         if (!hasNodeDecoration && isEmptyDoc) {
@@ -320,24 +263,15 @@ export var createPlugin = function createPlugin(api, getIntl) {
         }
 
         // Map active node position when the document changes
-        var mappedActiveNodePos;
-        if (fg('platform.editor.elements.drag-and-drop-ed-23816')) {
-          mappedActiveNodePos = tr.docChanged && activeNode ? activeNodeWithNewNodeType || {
-            pos: tr.mapping.map(activeNode.pos),
-            anchorName: activeNode.anchorName,
-            nodeType: activeNode.nodeType
-          } : activeNode;
-        } else {
-          mappedActiveNodePos = tr.docChanged && activeNode ? {
-            pos: tr.mapping.map(activeNode.pos),
-            anchorName: activeNode.anchorName,
-            nodeType: activeNode.nodeType
-          } : activeNode;
-        }
+        var mappedActiveNodePos = tr.docChanged && activeNode ? activeNodeWithNewNodeType || {
+          pos: tr.mapping.map(activeNode.pos),
+          anchorName: activeNode.anchorName,
+          nodeType: activeNode.nodeType
+        } : activeNode;
         return {
           decorations: decorations,
           decorationState: decorationState,
-          activeNode: isEmptyDoc || isHandleMissing ? null : (_meta$activeNode4 = meta === null || meta === void 0 ? void 0 : meta.activeNode) !== null && _meta$activeNode4 !== void 0 ? _meta$activeNode4 : mappedActiveNodePos,
+          activeNode: isEmptyDoc || isHandleMissing ? null : (_meta$activeNode3 = meta === null || meta === void 0 ? void 0 : meta.activeNode) !== null && _meta$activeNode3 !== void 0 ? _meta$activeNode3 : mappedActiveNodePos,
           isDragging: (_meta$isDragging = meta === null || meta === void 0 ? void 0 : meta.isDragging) !== null && _meta$isDragging !== void 0 ? _meta$isDragging : isDragging,
           isMenuOpen: meta !== null && meta !== void 0 && meta.toggleMenu ? !isMenuOpen : isMenuOpen,
           editorHeight: (_meta$editorHeight = meta === null || meta === void 0 ? void 0 : meta.editorHeight) !== null && _meta$editorHeight !== void 0 ? _meta$editorHeight : currentState.editorHeight,

package/dist/esm/ui/drag-handle.js

@@ -3,7 +3,7 @@ import _slicedToArray from "@babel/runtime/helpers/slicedToArray";
  * @jsxRuntime classic
  * @jsx jsx
  */
-import { useCallback, useEffect, useMemo, useRef, useState } from 'react';
+import { useCallback, useEffect, useRef, useState } from 'react';
 // eslint-disable-next-line @atlaskit/ui-styling-standard/use-compiled -- Ignored via go/DSP-18766
 import { css, jsx } from '@emotion/react';
 import { bind } from 'bind-event-listener';
@@ -112,7 +112,7 @@ var DragHandleInternal = function DragHandleInternal(_ref) {
       });
       var resolvedMovingNode = tr.doc.resolve(startPos);
       var maybeNode = resolvedMovingNode.nodeAfter;
-      fg('platform.editor.elements.drag-and-drop-long-node-scroll') && tr.setMeta('scrollIntoView', false);
+      tr.setMeta('scrollIntoView', false);
       api === null || api === void 0 || (_api$analytics = api.analytics) === null || _api$analytics === void 0 || _api$analytics.actions.attachAnalyticsEvent({
         eventType: EVENT_TYPE.UI,
         action: ACTION.CLICKED,
@@ -278,12 +278,9 @@ var DragHandleInternal = function DragHandleInternal(_ref) {
       display: 'none'
     }),
     _useState6 = _slicedToArray(_useState5, 2),
-    newPositionStyles = _useState6[0],
-    setNewPositionStyles = _useState6[1];
+    positionStyles = _useState6[0],
+    setPositionStyles = _useState6[1];
   useEffect(function () {
-    if (!fg('platform_editor_element_drag_and_drop_ed_23896')) {
-      return;
-    }
     var cleanUpTransitionListener;
     if (nodeType === 'extension' || nodeType === 'embedCard') {
       var dom = view.dom.querySelector("[data-drag-handler-anchor-name=\"".concat(anchorName, "\"]"));
@@ -293,12 +290,12 @@ var DragHandleInternal = function DragHandleInternal(_ref) {
       cleanUpTransitionListener = bind(dom, {
         type: 'transitionend',
         listener: function listener() {
-          setNewPositionStyles(calculatePosition());
+          setPositionStyles(calculatePosition());
         }
       });
     }
     var calcPos = requestAnimationFrame(function () {
-      setNewPositionStyles(calculatePosition());
+      setPositionStyles(calculatePosition());
     });
     return function () {
       var _cleanUpTransitionLis;
@@ -306,12 +303,6 @@ var DragHandleInternal = function DragHandleInternal(_ref) {
       (_cleanUpTransitionLis = cleanUpTransitionListener) === null || _cleanUpTransitionLis === void 0 || _cleanUpTransitionLis();
     };
   }, [calculatePosition, view.dom, anchorName, nodeType]);
-  var positionStyles = useMemo(function () {
-    if (fg('platform_editor_element_drag_and_drop_ed_23896')) {
-      return newPositionStyles;
-    }
-    return calculatePosition();
-  }, [calculatePosition, newPositionStyles]);
   useEffect(function () {
     if (handleOptions !== null && handleOptions !== void 0 && handleOptions.isFocused && buttonRef.current && fg('platform_editor_element_drag_and_drop_ed_23873')) {
       var id = requestAnimationFrame(function () {
@@ -345,7 +336,7 @@ var DragHandleInternal = function DragHandleInternal(_ref) {
         ref: buttonRef
         // eslint-disable-next-line @atlaskit/ui-styling-standard/enforce-style-prop -- Ignored via go/DSP-18766
         ,
-        style: fg('platform_editor_element_drag_and_drop_ed_23896') ? newPositionStyles : positionStyles,
+        style: positionStyles,
         onClick: handleOnClick,
         onMouseDown: handleMouseDown,
         onKeyDown: handleKeyDown,

package/dist/esm/ui/drop-target.js

@@ -8,7 +8,6 @@ import { useEffect, useMemo, useRef, useState } from 'react';
 // eslint-disable-next-line @atlaskit/ui-styling-standard/use-compiled -- Ignored via go/DSP-18766
 import { css, jsx } from '@emotion/react';
 import { useSharedPluginState } from '@atlaskit/editor-common/hooks';
-import { fg } from '@atlaskit/platform-feature-flags';
 import { DropIndicator } from '@atlaskit/pragmatic-drag-and-drop-react-drop-indicator/box';
 import { dropTargetForElements } from '@atlaskit/pragmatic-drag-and-drop/element/adapter';
 import { layers } from '@atlaskit/theme/constants';
@@ -46,9 +45,6 @@ var getNodeMargins = function getNodeMargins(node) {
   return nodeMargins[nodeTypeName] || nodeMargins['default'];
 };
 var getDropTargetPositionStyle = function getDropTargetPositionStyle(prevNode, nextNode) {
-  if (!fg('platform_editor_drag_and_drop_target_gap_fix')) {
-    return null;
-  }
   if (!prevNode || !nextNode) {
     return null;
   }

package/dist/esm/utils/drag-target-debug.js

@@ -1,5 +1,5 @@
 import { fg } from '@atlaskit/platform-feature-flags';
 var IS_GEMINI_TEST_ENV = Boolean(process.env.NODE_ENV === 'development') && Boolean(window.__gemini_set_feature_flag__);
 export var isBlocksDragTargetDebug = function isBlocksDragTargetDebug() {
-  return IS_GEMINI_TEST_ENV && fg('platform_editor_drag_and_drop_target_gap_fix');
+  return IS_GEMINI_TEST_ENV && fg('platform_editor_element_drag_and_drop_debug');
 };

package/dist/types/ui/drop-target.d.ts

@@ -1,16 +1,13 @@
-/// <reference types="react" />
 import { jsx } from '@emotion/react';
 import { type IntlShape } from 'react-intl-next';
 import type { ExtractInjectionAPI } from '@atlaskit/editor-common/types';
 import type { Node as PMNode } from '@atlaskit/editor-prosemirror/model';
 import type { BlockControlsPlugin } from '../types';
-export declare const DropTarget: ({ api, id, prevNode, nextNode, formatMessage, }: {
+export type DropTargetProps = {
     api: ExtractInjectionAPI<BlockControlsPlugin> | undefined;
     id: number;
-    prevNode?: PMNode | undefined;
-    nextNode?: PMNode | undefined;
-    formatMessage?: {
-        (descriptor: import("react-intl-next").MessageDescriptor, values?: Record<string, import("intl-messageformat").PrimitiveType | import("intl-messageformat").FormatXMLElementFn<string, string>> | undefined, opts?: import("intl-messageformat").Options | undefined): string;
-        (descriptor: import("react-intl-next").MessageDescriptor, values?: Record<string, string | number | boolean | {} | import("react").ReactElement<any, string | import("react").JSXElementConstructor<any>> | import("react").ReactNodeArray | import("react").ReactPortal | Date | import("intl-messageformat").FormatXMLElementFn<import("react").ReactNode, import("react").ReactNode> | null | undefined> | undefined, opts?: import("intl-messageformat").Options | undefined): import("react").ReactNode;
-    } | undefined;
-}) => jsx.JSX.Element;
+    prevNode?: PMNode;
+    nextNode?: PMNode;
+    formatMessage?: IntlShape['formatMessage'];
+};
+export declare const DropTarget: ({ api, id, prevNode, nextNode, formatMessage }: DropTargetProps) => jsx.JSX.Element;

package/dist/types-ts4.5/ui/drop-target.d.ts

@@ -1,16 +1,13 @@
-/// <reference types="react" />
 import { jsx } from '@emotion/react';
 import { type IntlShape } from 'react-intl-next';
 import type { ExtractInjectionAPI } from '@atlaskit/editor-common/types';
 import type { Node as PMNode } from '@atlaskit/editor-prosemirror/model';
 import type { BlockControlsPlugin } from '../types';
-export declare const DropTarget: ({ api, id, prevNode, nextNode, formatMessage, }: {
+export type DropTargetProps = {
     api: ExtractInjectionAPI<BlockControlsPlugin> | undefined;
     id: number;
-    prevNode?: PMNode | undefined;
-    nextNode?: PMNode | undefined;
-    formatMessage?: {
-        (descriptor: import("react-intl-next").MessageDescriptor, values?: Record<string, import("intl-messageformat").PrimitiveType | import("intl-messageformat").FormatXMLElementFn<string, string>> | undefined, opts?: import("intl-messageformat").Options | undefined): string;
-        (descriptor: import("react-intl-next").MessageDescriptor, values?: Record<string, string | number | boolean | {} | import("react").ReactElement<any, string | import("react").JSXElementConstructor<any>> | import("react").ReactNodeArray | import("react").ReactPortal | Date | import("intl-messageformat").FormatXMLElementFn<import("react").ReactNode, import("react").ReactNode> | null | undefined> | undefined, opts?: import("intl-messageformat").Options | undefined): import("react").ReactNode;
-    } | undefined;
-}) => jsx.JSX.Element;
+    prevNode?: PMNode;
+    nextNode?: PMNode;
+    formatMessage?: IntlShape['formatMessage'];
+};
+export declare const DropTarget: ({ api, id, prevNode, nextNode, formatMessage }: DropTargetProps) => jsx.JSX.Element;