@atlaskit/editor-plugin-base 0.2.13 → 0.3.1

package/CHANGELOG.md

@@ -1,5 +1,17 @@
 # @atlaskit/editor-plugin-base
 
+## 0.3.1
+
+### Patch Changes
+
+- [#64064](https://stash.atlassian.com/projects/CONFCLOUD/repos/confluence-frontend/pull-requests/64064) [`77394053290a`](https://stash.atlassian.com/projects/CONFCLOUD/repos/confluence-frontend/commits/77394053290a) - Comment change to trigger builds
+
+## 0.3.0
+
+### Minor Changes
+
+- [#63522](https://stash.atlassian.com/projects/CONFCLOUD/repos/confluence-frontend/pull-requests/63522) [`906d43c5bb6d`](https://stash.atlassian.com/projects/CONFCLOUD/repos/confluence-frontend/commits/906d43c5bb6d) - Remove hack for chrome 88 selection bug
+
 ## 0.2.13
 
 ### Patch Changes

package/dist/cjs/plugin.js

@@ -5,19 +5,16 @@ var _typeof = require("@babel/runtime/helpers/typeof");
 Object.defineProperty(exports, "__esModule", {
   value: true
 });
-exports.isChromeWithSelectionBug = exports.default = void 0;
+exports.default = void 0;
 var _defineProperty2 = _interopRequireDefault(require("@babel/runtime/helpers/defineProperty"));
 var _adfSchema = require("@atlaskit/adf-schema");
 var _keymaps = require("@atlaskit/editor-common/keymaps");
-var _utils = require("@atlaskit/editor-common/utils");
 var _commands = require("@atlaskit/editor-prosemirror/commands");
 var _history = require("@atlaskit/editor-prosemirror/history");
-var _platformFeatureFlags = require("@atlaskit/platform-feature-flags");
 var _commands2 = require("./commands");
 var _contextIdentifier = _interopRequireWildcard(require("./pm-plugins/context-identifier"));
 var _disableSpellChecking = _interopRequireDefault(require("./pm-plugins/disable-spell-checking"));
 var _filterSteps = _interopRequireDefault(require("./pm-plugins/filter-steps"));
-var _fixChrome88Selection = _interopRequireDefault(require("./pm-plugins/fix-chrome-88-selection"));
 var _frozenEditor = _interopRequireDefault(require("./pm-plugins/frozen-editor"));
 var _inlineCursorTarget = _interopRequireDefault(require("./pm-plugins/inline-cursor-target"));
 var _newlinePreserveMarks = _interopRequireDefault(require("./pm-plugins/newline-preserve-marks"));
@@ -26,8 +23,6 @@ function _getRequireWildcardCache(nodeInterop) { if (typeof WeakMap !== "functio
 function _interopRequireWildcard(obj, nodeInterop) { if (!nodeInterop && obj && obj.__esModule) { return obj; } if (obj === null || _typeof(obj) !== "object" && typeof obj !== "function") { return { default: obj }; } var cache = _getRequireWildcardCache(nodeInterop); if (cache && cache.has(obj)) { return cache.get(obj); } var newObj = {}; var hasPropertyDescriptor = Object.defineProperty && Object.getOwnPropertyDescriptor; for (var key in obj) { if (key !== "default" && Object.prototype.hasOwnProperty.call(obj, key)) { var desc = hasPropertyDescriptor ? Object.getOwnPropertyDescriptor(obj, key) : null; if (desc && (desc.get || desc.set)) { Object.defineProperty(newObj, key, desc); } else { newObj[key] = obj[key]; } } } newObj.default = obj; if (cache) { cache.set(obj, newObj); } return newObj; }
 function ownKeys(e, r) { var t = Object.keys(e); if (Object.getOwnPropertySymbols) { var o = Object.getOwnPropertySymbols(e); r && (o = o.filter(function (r) { return Object.getOwnPropertyDescriptor(e, r).enumerable; })), t.push.apply(t, o); } return t; }
 function _objectSpread(e) { for (var r = 1; r < arguments.length; r++) { var t = null != arguments[r] ? arguments[r] : {}; r % 2 ? ownKeys(Object(t), !0).forEach(function (r) { (0, _defineProperty2.default)(e, r, t[r]); }) : Object.getOwnPropertyDescriptors ? Object.defineProperties(e, Object.getOwnPropertyDescriptors(t)) : ownKeys(Object(t)).forEach(function (r) { Object.defineProperty(e, r, Object.getOwnPropertyDescriptor(t, r)); }); } return e; }
-// Chrome >= 88
-var isChromeWithSelectionBug = exports.isChromeWithSelectionBug = _utils.browser.chrome && _utils.browser.chrome_version >= 88;
 var basePlugin = function basePlugin(_ref) {
   var _api$featureFlags;
   var options = _ref.config,
@@ -55,10 +50,13 @@ var basePlugin = function basePlugin(_ref) {
 
       // In Chrome, when the selection is placed between adjacent nodes which are not contenteditatble
       // the cursor appears at the right most point of the parent container.
+      //
       // In Firefox, when the selection is placed between adjacent nodes which are not contenteditatble
       // no cursor is presented to users.
+      //
       // In Safari, when the selection is placed between adjacent nodes which are not contenteditatble
       // it is not possible to navigate with arrow keys.
+      //
       // This plugin works around the issues by inserting decorations between
       // inline nodes which are set as contenteditable, and have a zero width space.
       plugins.push({
@@ -112,14 +110,6 @@ var basePlugin = function basePlugin(_ref) {
           }
         });
       }
-      if (isChromeWithSelectionBug && !(0, _platformFeatureFlags.getBooleanFF)('platform.editor.disable-chrome-88-selection-fix_uk53m')) {
-        plugins.push({
-          name: 'fixChrome88SelectionPlugin',
-          plugin: function plugin() {
-            return (0, _fixChrome88Selection.default)();
-          }
-        });
-      }
       plugins.push({
         name: 'disableSpellcheckingPlugin',
         plugin: function plugin() {

package/dist/es2019/plugin.js

@@ -1,20 +1,15 @@
 import { doc, paragraph, text } from '@atlaskit/adf-schema';
 import { keymap } from '@atlaskit/editor-common/keymaps';
-import { browser } from '@atlaskit/editor-common/utils';
 import { baseKeymap } from '@atlaskit/editor-prosemirror/commands';
 import { history } from '@atlaskit/editor-prosemirror/history';
-import { getBooleanFF } from '@atlaskit/platform-feature-flags';
 import { setKeyboardHeight } from './commands';
 import contextIdentifierPlugin, { getContextIdentifier } from './pm-plugins/context-identifier';
 import disableSpellcheckingPlugin from './pm-plugins/disable-spell-checking';
 import filterStepsPlugin from './pm-plugins/filter-steps';
-import fixChrome88SelectionPlugin from './pm-plugins/fix-chrome-88-selection';
 import frozenEditor from './pm-plugins/frozen-editor';
 import inlineCursorTargetPlugin from './pm-plugins/inline-cursor-target';
 import newlinePreserveMarksPlugin from './pm-plugins/newline-preserve-marks';
 import scrollGutter, { getKeyboardHeight } from './pm-plugins/scroll-gutter';
-// Chrome >= 88
-export const isChromeWithSelectionBug = browser.chrome && browser.chrome_version >= 88;
 const basePlugin = ({
   config: options,
   api
@@ -42,10 +37,13 @@ const basePlugin = ({
 
       // In Chrome, when the selection is placed between adjacent nodes which are not contenteditatble
       // the cursor appears at the right most point of the parent container.
+      //
       // In Firefox, when the selection is placed between adjacent nodes which are not contenteditatble
       // no cursor is presented to users.
+      //
       // In Safari, when the selection is placed between adjacent nodes which are not contenteditatble
       // it is not possible to navigate with arrow keys.
+      //
       // This plugin works around the issues by inserting decorations between
       // inline nodes which are set as contenteditable, and have a zero width space.
       plugins.push({
@@ -88,12 +86,6 @@ const basePlugin = ({
           plugin: () => scrollGutter(options.allowScrollGutter)
         });
       }
-      if (isChromeWithSelectionBug && !getBooleanFF('platform.editor.disable-chrome-88-selection-fix_uk53m')) {
-        plugins.push({
-          name: 'fixChrome88SelectionPlugin',
-          plugin: () => fixChrome88SelectionPlugin()
-        });
-      }
       plugins.push({
         name: 'disableSpellcheckingPlugin',
         plugin: () => disableSpellcheckingPlugin(featureFlags)

package/dist/esm/plugin.js

@@ -3,21 +3,16 @@ function ownKeys(e, r) { var t = Object.keys(e); if (Object.getOwnPropertySymbol
 function _objectSpread(e) { for (var r = 1; r < arguments.length; r++) { var t = null != arguments[r] ? arguments[r] : {}; r % 2 ? ownKeys(Object(t), !0).forEach(function (r) { _defineProperty(e, r, t[r]); }) : Object.getOwnPropertyDescriptors ? Object.defineProperties(e, Object.getOwnPropertyDescriptors(t)) : ownKeys(Object(t)).forEach(function (r) { Object.defineProperty(e, r, Object.getOwnPropertyDescriptor(t, r)); }); } return e; }
 import { doc, paragraph, text } from '@atlaskit/adf-schema';
 import { keymap } from '@atlaskit/editor-common/keymaps';
-import { browser } from '@atlaskit/editor-common/utils';
 import { baseKeymap } from '@atlaskit/editor-prosemirror/commands';
 import { history } from '@atlaskit/editor-prosemirror/history';
-import { getBooleanFF } from '@atlaskit/platform-feature-flags';
 import { setKeyboardHeight } from './commands';
 import contextIdentifierPlugin, { getContextIdentifier } from './pm-plugins/context-identifier';
 import disableSpellcheckingPlugin from './pm-plugins/disable-spell-checking';
 import filterStepsPlugin from './pm-plugins/filter-steps';
-import fixChrome88SelectionPlugin from './pm-plugins/fix-chrome-88-selection';
 import frozenEditor from './pm-plugins/frozen-editor';
 import inlineCursorTargetPlugin from './pm-plugins/inline-cursor-target';
 import newlinePreserveMarksPlugin from './pm-plugins/newline-preserve-marks';
 import scrollGutter, { getKeyboardHeight } from './pm-plugins/scroll-gutter';
-// Chrome >= 88
-export var isChromeWithSelectionBug = browser.chrome && browser.chrome_version >= 88;
 var basePlugin = function basePlugin(_ref) {
   var _api$featureFlags;
   var options = _ref.config,
@@ -45,10 +40,13 @@ var basePlugin = function basePlugin(_ref) {
 
       // In Chrome, when the selection is placed between adjacent nodes which are not contenteditatble
       // the cursor appears at the right most point of the parent container.
+      //
       // In Firefox, when the selection is placed between adjacent nodes which are not contenteditatble
       // no cursor is presented to users.
+      //
       // In Safari, when the selection is placed between adjacent nodes which are not contenteditatble
       // it is not possible to navigate with arrow keys.
+      //
       // This plugin works around the issues by inserting decorations between
       // inline nodes which are set as contenteditable, and have a zero width space.
       plugins.push({
@@ -102,14 +100,6 @@ var basePlugin = function basePlugin(_ref) {
           }
         });
       }
-      if (isChromeWithSelectionBug && !getBooleanFF('platform.editor.disable-chrome-88-selection-fix_uk53m')) {
-        plugins.push({
-          name: 'fixChrome88SelectionPlugin',
-          plugin: function plugin() {
-            return fixChrome88SelectionPlugin();
-          }
-        });
-      }
       plugins.push({
         name: 'disableSpellcheckingPlugin',
         plugin: function plugin() {

package/dist/types/plugin.d.ts

@@ -23,6 +23,5 @@ export type BasePlugin = NextEditorPlugin<'base', {
         setKeyboardHeight: typeof setKeyboardHeight;
     };
 }>;
-export declare const isChromeWithSelectionBug: any;
 declare const basePlugin: BasePlugin;
 export default basePlugin;

package/dist/types-ts4.5/plugin.d.ts

@@ -25,6 +25,5 @@ export type BasePlugin = NextEditorPlugin<'base', {
         setKeyboardHeight: typeof setKeyboardHeight;
     };
 }>;
-export declare const isChromeWithSelectionBug: any;
 declare const basePlugin: BasePlugin;
 export default basePlugin;

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@atlaskit/editor-plugin-base",
-  "version": "0.2.13",
+  "version": "0.3.1",
   "description": "Base plugin for @atlaskit/editor-core",
   "author": "Atlassian Pty Ltd",
   "license": "Apache-2.0",
@@ -10,7 +10,8 @@
   "atlassian": {
     "team": "Editor",
     "singleton": true,
-    "releaseModel": "continuous"
+    "releaseModel": "continuous",
+    "runReact18": false
   },
   "repository": "https://bitbucket.org/atlassian/atlassian-frontend",
   "main": "dist/cjs/index.js",
@@ -32,10 +33,9 @@
   },
   "dependencies": {
     "@atlaskit/adf-schema": "^35.2.0",
-    "@atlaskit/editor-common": "^76.27.0",
+    "@atlaskit/editor-common": "^76.30.0",
     "@atlaskit/editor-plugin-feature-flags": "^1.0.1",
     "@atlaskit/editor-prosemirror": "1.1.0",
-    "@atlaskit/platform-feature-flags": "^0.2.0",
     "@babel/runtime": "^7.0.0"
   },
   "devDependencies": {
@@ -44,7 +44,7 @@
     "@atlaskit/editor-plugin-emoji": "^1.0.0",
     "@atlaskit/editor-plugin-guideline": "^0.5.0",
     "@atlaskit/editor-plugin-selection": "^0.1.0",
-    "@atlaskit/editor-plugin-table": "^5.6.0",
+    "@atlaskit/editor-plugin-table": "^5.7.0",
     "@atlaskit/editor-plugin-type-ahead": "^0.8.0",
     "@atlaskit/editor-plugin-width": "^0.2.0",
     "@atlaskit/util-data-test": "^17.8.0",
@@ -85,10 +85,5 @@
       ]
     }
   },
-  "prettier": "@atlassian/atlassian-frontend-prettier-config-1.0.0",
-  "platform-feature-flags": {
-    "platform.editor.disable-chrome-88-selection-fix_uk53m": {
-      "type": "boolean"
-    }
-  }
+  "prettier": "@atlassian/atlassian-frontend-prettier-config-1.0.0"
 }

package/tsconfig.app.json

@@ -37,9 +37,6 @@
     },
     {
       "path": "../editor-plugin-feature-flags/tsconfig.app.json"
-    },
-    {
-      "path": "../../platform/feature-flags/tsconfig.app.json"
     }
   ]
 }

package/dist/cjs/pm-plugins/fix-chrome-88-selection.js

@@ -1,32 +0,0 @@
-"use strict";
-
-Object.defineProperty(exports, "__esModule", {
-  value: true
-});
-exports.fixChromeSelectionKey = exports.default = void 0;
-var _safePlugin = require("@atlaskit/editor-common/safe-plugin");
-var _state = require("@atlaskit/editor-prosemirror/state");
-var _utils = require("@atlaskit/editor-prosemirror/utils");
-function isDivHTMLElement(elm) {
-  return elm.tagName.toLowerCase() === 'div';
-}
-var fixChromeSelectionKey = exports.fixChromeSelectionKey = new _state.PluginKey('fixChromeSelectionPlugin');
-var _default = exports.default = function _default() {
-  return new _safePlugin.SafePlugin({
-    key: fixChromeSelectionKey,
-    props: {
-      handleDOMEvents: {
-        focus: function focus(view) {
-          // We don't need to reset when there's a NodeSelection
-          // It creates other problem. @see HOT-94478
-          if (isDivHTMLElement(view.dom) && !(0, _utils.isNodeSelection)(view.state.selection)) {
-            view.dom.style.display = 'inline-block';
-            view.dom.offsetHeight;
-            view.dom.style.display = 'block';
-          }
-          return false;
-        }
-      }
-    }
-  });
-};

package/dist/es2019/pm-plugins/fix-chrome-88-selection.js

@@ -1,24 +0,0 @@
-import { SafePlugin } from '@atlaskit/editor-common/safe-plugin';
-import { PluginKey } from '@atlaskit/editor-prosemirror/state';
-import { isNodeSelection } from '@atlaskit/editor-prosemirror/utils';
-function isDivHTMLElement(elm) {
-  return elm.tagName.toLowerCase() === 'div';
-}
-export const fixChromeSelectionKey = new PluginKey('fixChromeSelectionPlugin');
-export default (() => new SafePlugin({
-  key: fixChromeSelectionKey,
-  props: {
-    handleDOMEvents: {
-      focus: view => {
-        // We don't need to reset when there's a NodeSelection
-        // It creates other problem. @see HOT-94478
-        if (isDivHTMLElement(view.dom) && !isNodeSelection(view.state.selection)) {
-          view.dom.style.display = 'inline-block';
-          view.dom.offsetHeight;
-          view.dom.style.display = 'block';
-        }
-        return false;
-      }
-    }
-  }
-}));

package/dist/esm/pm-plugins/fix-chrome-88-selection.js

@@ -1,26 +0,0 @@
-import { SafePlugin } from '@atlaskit/editor-common/safe-plugin';
-import { PluginKey } from '@atlaskit/editor-prosemirror/state';
-import { isNodeSelection } from '@atlaskit/editor-prosemirror/utils';
-function isDivHTMLElement(elm) {
-  return elm.tagName.toLowerCase() === 'div';
-}
-export var fixChromeSelectionKey = new PluginKey('fixChromeSelectionPlugin');
-export default (function () {
-  return new SafePlugin({
-    key: fixChromeSelectionKey,
-    props: {
-      handleDOMEvents: {
-        focus: function focus(view) {
-          // We don't need to reset when there's a NodeSelection
-          // It creates other problem. @see HOT-94478
-          if (isDivHTMLElement(view.dom) && !isNodeSelection(view.state.selection)) {
-            view.dom.style.display = 'inline-block';
-            view.dom.offsetHeight;
-            view.dom.style.display = 'block';
-          }
-          return false;
-        }
-      }
-    }
-  });
-});

package/dist/types/pm-plugins/fix-chrome-88-selection.d.ts

@@ -1,5 +0,0 @@
-import { SafePlugin } from '@atlaskit/editor-common/safe-plugin';
-import { PluginKey } from '@atlaskit/editor-prosemirror/state';
-export declare const fixChromeSelectionKey: PluginKey<any>;
-declare const _default: () => SafePlugin<any>;
-export default _default;

package/dist/types-ts4.5/pm-plugins/fix-chrome-88-selection.d.ts

@@ -1,5 +0,0 @@
-import { SafePlugin } from '@atlaskit/editor-common/safe-plugin';
-import { PluginKey } from '@atlaskit/editor-prosemirror/state';
-export declare const fixChromeSelectionKey: PluginKey<any>;
-declare const _default: () => SafePlugin<any>;
-export default _default;