@atlaskit/editor-plugin-autocomplete 4.0.0 → 4.0.1

package/CHANGELOG.md

@@ -1,5 +1,15 @@
 # @atlaskit/editor-plugin-autocomplete
 
+## 4.0.1
+
+### Patch Changes
+
+- [`560ddb7a914f6`](https://bitbucket.org/atlassian/atlassian-frontend-monorepo/commits/560ddb7a914f6) -
+  [ux] Fixes a bug where autocomplete suggestions were shown when the cursor was positioned in the
+  middle of an existing word. Suggestions are now suppressed unless the cursor is at the trailing
+  edge of a token.
+- Updated dependencies
+
 ## 4.0.0
 
 ### Major Changes

package/dist/cjs/pm-plugins/autocomplete-plugin.js

@@ -188,6 +188,38 @@ var buildSlowLaneText = function buildSlowLaneText(docText, context) {
   lines.push("reply ".concat(nextReplyNumber, ": ").concat(docText));
   return lines.join('\n');
 };
+var createMidWordCharacterRegex = function createMidWordCharacterRegex() {
+  try {
+    // string-built regex avoids TS1501 under the package's ES5 build target
+    return new RegExp('[\\p{L}\\p{N}_]', 'u');
+  } catch (_unused) {
+    return null;
+  }
+};
+var midWordCharacterRegex = createMidWordCharacterRegex();
+var isAsciiWordCharacter = function isAsciiWordCharacter(char) {
+  if (char === '_') {
+    return true;
+  }
+  var charCode = char.charCodeAt(0);
+  return charCode >= 48 && charCode <= 57 || charCode >= 65 && charCode <= 90 || charCode >= 97 && charCode <= 122;
+};
+var isMidWordCharacter = function isMidWordCharacter(char) {
+  if (midWordCharacterRegex) {
+    return midWordCharacterRegex.test(char);
+  }
+  if (isAsciiWordCharacter(char)) {
+    return true;
+  }
+  return char.toLocaleLowerCase() !== char.toLocaleUpperCase();
+};
+var getLeadingTextCharacter = function getLeadingTextCharacter(text) {
+  var firstCodePoint = text === null || text === void 0 ? void 0 : text.codePointAt(0);
+  if (firstCodePoint === undefined) {
+    return undefined;
+  }
+  return String.fromCodePoint(firstCodePoint);
+};
 var getTypedLengthForPrediction = function getTypedLengthForPrediction(textBefore) {
   var _textBefore$match$, _textBefore$match;
   if ((0, _slowLaneClient.isWordBoundary)(textBefore)) {
@@ -440,6 +472,19 @@ var createAutocompletePlugin = exports.createAutocompletePlugin = function creat
         if (!selection.empty) {
           return;
         }
+
+        // Suppress suggestions when the cursor is mid-word — only offer
+        // completions when the cursor is at the trailing edge of a token.
+        // nodeAfter correctly handles inline atoms (mentions, emojis) where
+        // parentOffset and textContent indices diverge.
+        var nodeAfter = selection.$from.nodeAfter;
+        var charAfterCursor = nodeAfter !== null && nodeAfter !== void 0 && nodeAfter.isText ? getLeadingTextCharacter(nodeAfter.text) : undefined;
+        // Only suppress for Unicode letters, digits, and underscore — hyphens,
+        // apostrophes, and similar punctuation are valid left-edge boundaries
+        // and should not block suggestions (e.g. cursor before '-' in compound-word).
+        if (charAfterCursor && isMidWordCharacter(charAfterCursor)) {
+          return;
+        }
         var textBefore = getTextBeforeCursor(state);
 
         // Suppress re-showing the same suggestion the user just dismissed.

package/dist/es2019/pm-plugins/autocomplete-plugin.js

@@ -176,6 +176,38 @@ const buildSlowLaneText = (docText, context) => {
   lines.push(`reply ${nextReplyNumber}: ${docText}`);
   return lines.join('\n');
 };
+const createMidWordCharacterRegex = () => {
+  try {
+    // string-built regex avoids TS1501 under the package's ES5 build target
+    return new RegExp('[\\p{L}\\p{N}_]', 'u');
+  } catch {
+    return null;
+  }
+};
+const midWordCharacterRegex = createMidWordCharacterRegex();
+const isAsciiWordCharacter = char => {
+  if (char === '_') {
+    return true;
+  }
+  const charCode = char.charCodeAt(0);
+  return charCode >= 48 && charCode <= 57 || charCode >= 65 && charCode <= 90 || charCode >= 97 && charCode <= 122;
+};
+const isMidWordCharacter = char => {
+  if (midWordCharacterRegex) {
+    return midWordCharacterRegex.test(char);
+  }
+  if (isAsciiWordCharacter(char)) {
+    return true;
+  }
+  return char.toLocaleLowerCase() !== char.toLocaleUpperCase();
+};
+const getLeadingTextCharacter = text => {
+  const firstCodePoint = text === null || text === void 0 ? void 0 : text.codePointAt(0);
+  if (firstCodePoint === undefined) {
+    return undefined;
+  }
+  return String.fromCodePoint(firstCodePoint);
+};
 const getTypedLengthForPrediction = textBefore => {
   var _textBefore$match$, _textBefore$match;
   if (isWordBoundary(textBefore)) {
@@ -424,6 +456,19 @@ export const createAutocompletePlugin = (options, api) => {
         if (!selection.empty) {
           return;
         }
+
+        // Suppress suggestions when the cursor is mid-word — only offer
+        // completions when the cursor is at the trailing edge of a token.
+        // nodeAfter correctly handles inline atoms (mentions, emojis) where
+        // parentOffset and textContent indices diverge.
+        const nodeAfter = selection.$from.nodeAfter;
+        const charAfterCursor = nodeAfter !== null && nodeAfter !== void 0 && nodeAfter.isText ? getLeadingTextCharacter(nodeAfter.text) : undefined;
+        // Only suppress for Unicode letters, digits, and underscore — hyphens,
+        // apostrophes, and similar punctuation are valid left-edge boundaries
+        // and should not block suggestions (e.g. cursor before '-' in compound-word).
+        if (charAfterCursor && isMidWordCharacter(charAfterCursor)) {
+          return;
+        }
         const textBefore = getTextBeforeCursor(state);
 
         // Suppress re-showing the same suggestion the user just dismissed.

package/dist/esm/pm-plugins/autocomplete-plugin.js

@@ -181,6 +181,38 @@ var buildSlowLaneText = function buildSlowLaneText(docText, context) {
   lines.push("reply ".concat(nextReplyNumber, ": ").concat(docText));
   return lines.join('\n');
 };
+var createMidWordCharacterRegex = function createMidWordCharacterRegex() {
+  try {
+    // string-built regex avoids TS1501 under the package's ES5 build target
+    return new RegExp('[\\p{L}\\p{N}_]', 'u');
+  } catch (_unused) {
+    return null;
+  }
+};
+var midWordCharacterRegex = createMidWordCharacterRegex();
+var isAsciiWordCharacter = function isAsciiWordCharacter(char) {
+  if (char === '_') {
+    return true;
+  }
+  var charCode = char.charCodeAt(0);
+  return charCode >= 48 && charCode <= 57 || charCode >= 65 && charCode <= 90 || charCode >= 97 && charCode <= 122;
+};
+var isMidWordCharacter = function isMidWordCharacter(char) {
+  if (midWordCharacterRegex) {
+    return midWordCharacterRegex.test(char);
+  }
+  if (isAsciiWordCharacter(char)) {
+    return true;
+  }
+  return char.toLocaleLowerCase() !== char.toLocaleUpperCase();
+};
+var getLeadingTextCharacter = function getLeadingTextCharacter(text) {
+  var firstCodePoint = text === null || text === void 0 ? void 0 : text.codePointAt(0);
+  if (firstCodePoint === undefined) {
+    return undefined;
+  }
+  return String.fromCodePoint(firstCodePoint);
+};
 var getTypedLengthForPrediction = function getTypedLengthForPrediction(textBefore) {
   var _textBefore$match$, _textBefore$match;
   if (isWordBoundary(textBefore)) {
@@ -433,6 +465,19 @@ export var createAutocompletePlugin = function createAutocompletePlugin(options,
         if (!selection.empty) {
           return;
         }
+
+        // Suppress suggestions when the cursor is mid-word — only offer
+        // completions when the cursor is at the trailing edge of a token.
+        // nodeAfter correctly handles inline atoms (mentions, emojis) where
+        // parentOffset and textContent indices diverge.
+        var nodeAfter = selection.$from.nodeAfter;
+        var charAfterCursor = nodeAfter !== null && nodeAfter !== void 0 && nodeAfter.isText ? getLeadingTextCharacter(nodeAfter.text) : undefined;
+        // Only suppress for Unicode letters, digits, and underscore — hyphens,
+        // apostrophes, and similar punctuation are valid left-edge boundaries
+        // and should not block suggestions (e.g. cursor before '-' in compound-word).
+        if (charAfterCursor && isMidWordCharacter(charAfterCursor)) {
+          return;
+        }
         var textBefore = getTextBeforeCursor(state);
 
         // Suppress re-showing the same suggestion the user just dismissed.

package/package.json

@@ -1,6 +1,6 @@
 {
 	"name": "@atlaskit/editor-plugin-autocomplete",
-	"version": "4.0.0",
+	"version": "4.0.1",
 	"description": "Client-side text autocomplete plugin for @atlaskit/editor-core",
 	"author": "Atlassian Pty Ltd",
 	"license": "Apache-2.0",
@@ -27,7 +27,7 @@
 		"wink-nlp": "^2.4.0"
 	},
 	"peerDependencies": {
-		"@atlaskit/editor-common": "^116.0.0",
+		"@atlaskit/editor-common": "^116.4.0",
 		"@atlaskit/editor-plugin-analytics": "^12.0.0",
 		"react": "^18.2.0"
 	},

package/src/pm-plugins/autocomplete-plugin.ts

@@ -243,6 +243,52 @@ const buildSlowLaneText = (docText: string, context?: AutocompleteContext): stri
 	return lines.join('\n');
 };
 
+const createMidWordCharacterRegex = (): RegExp | null => {
+	try {
+		// string-built regex avoids TS1501 under the package's ES5 build target
+		return new RegExp('[\\p{L}\\p{N}_]', 'u');
+	} catch {
+		return null;
+	}
+};
+
+const midWordCharacterRegex = createMidWordCharacterRegex();
+
+const isAsciiWordCharacter = (char: string): boolean => {
+	if (char === '_') {
+		return true;
+	}
+
+	const charCode = char.charCodeAt(0);
+	return (
+		(charCode >= 48 && charCode <= 57) ||
+		(charCode >= 65 && charCode <= 90) ||
+		(charCode >= 97 && charCode <= 122)
+	);
+};
+
+const isMidWordCharacter = (char: string): boolean => {
+	if (midWordCharacterRegex) {
+		return midWordCharacterRegex.test(char);
+	}
+
+	if (isAsciiWordCharacter(char)) {
+		return true;
+	}
+
+	return char.toLocaleLowerCase() !== char.toLocaleUpperCase();
+};
+
+const getLeadingTextCharacter = (text?: string): string | undefined => {
+	const firstCodePoint = text?.codePointAt(0);
+
+	if (firstCodePoint === undefined) {
+		return undefined;
+	}
+
+	return String.fromCodePoint(firstCodePoint);
+};
+
 const getTypedLengthForPrediction = (textBefore: string): number => {
 	if (isWordBoundary(textBefore)) {
 		return 0;
@@ -514,6 +560,19 @@ export const createAutocompletePlugin = (
 					return;
 				}
 
+				// Suppress suggestions when the cursor is mid-word — only offer
+				// completions when the cursor is at the trailing edge of a token.
+				// nodeAfter correctly handles inline atoms (mentions, emojis) where
+				// parentOffset and textContent indices diverge.
+				const nodeAfter = selection.$from.nodeAfter;
+				const charAfterCursor = nodeAfter?.isText ? getLeadingTextCharacter(nodeAfter.text) : undefined;
+				// Only suppress for Unicode letters, digits, and underscore — hyphens,
+				// apostrophes, and similar punctuation are valid left-edge boundaries
+				// and should not block suggestions (e.g. cursor before '-' in compound-word).
+				if (charAfterCursor && isMidWordCharacter(charAfterCursor)) {
+					return;
+				}
+
 				const textBefore = getTextBeforeCursor(state);
 
 				// Suppress re-showing the same suggestion the user just dismissed.