@atlaskit/editor-plugin-annotation 6.3.2 → 7.0.0

This diff represents the content of publicly available package versions that have been released to one of the supported registries. The information contained in this diff is provided for informational purposes only and reflects changes between package versions as they appear in their respective public registries.
package/CHANGELOG.md CHANGED
@@ -1,5 +1,22 @@
1
1
  # @atlaskit/editor-plugin-annotation
2
2
 
3
+ ## 7.0.0
4
+
5
+ ### Patch Changes
6
+
7
+ - Updated dependencies
8
+
9
+ ## 6.4.0
10
+
11
+ ### Minor Changes
12
+
13
+ - [`82d57d01a0f61`](https://bitbucket.org/atlassian/atlassian-frontend-monorepo/commits/82d57d01a0f61) -
14
+ Distinguish between collab offline and internet offline cases for connectivity mode
15
+
16
+ ### Patch Changes
17
+
18
+ - Updated dependencies
19
+
3
20
  ## 6.3.2
4
21
 
5
22
  ### Patch Changes
@@ -11,6 +11,7 @@ var _keymaps = require("@atlaskit/editor-common/keymaps");
11
11
  var _mediaSingle = require("@atlaskit/editor-common/media-single");
12
12
  var _messages = require("@atlaskit/editor-common/messages");
13
13
  var _utils = require("@atlaskit/editor-common/utils");
14
+ var _editorPluginConnectivity = require("@atlaskit/editor-plugin-connectivity");
14
15
  var _comment = _interopRequireDefault(require("@atlaskit/icon/core/comment"));
15
16
  var _platformFeatureFlags = require("@atlaskit/platform-feature-flags");
16
17
  var _expValEquals = require("@atlaskit/tmp-editor-statsig/exp-val-equals");
@@ -93,7 +94,7 @@ var buildToolbar = exports.buildToolbar = function buildToolbar(editorAnalyticsA
93
94
  var createComment = {
94
95
  type: 'button',
95
96
  showTitle: true,
96
- disabled: isCommentButtonDisabled || (api === null || api === void 0 || (_api$connectivity = api.connectivity) === null || _api$connectivity === void 0 || (_api$connectivity = _api$connectivity.sharedState) === null || _api$connectivity === void 0 || (_api$connectivity = _api$connectivity.currentState()) === null || _api$connectivity === void 0 ? void 0 : _api$connectivity.mode) === 'offline',
97
+ disabled: isCommentButtonDisabled || (0, _editorPluginConnectivity.isOfflineMode)(api === null || api === void 0 || (_api$connectivity = api.connectivity) === null || _api$connectivity === void 0 || (_api$connectivity = _api$connectivity.sharedState) === null || _api$connectivity === void 0 || (_api$connectivity = _api$connectivity.currentState()) === null || _api$connectivity === void 0 ? void 0 : _api$connectivity.mode),
97
98
  testId: _types.AnnotationTestIds.floatingToolbarCreateButton,
98
99
  interactionName: 'start-inline-comment-action',
99
100
  icon: _comment.default,
@@ -6,6 +6,7 @@ Object.defineProperty(exports, "__esModule", {
6
6
  exports.startCommentExperience = exports.shouldShowCommentButton = exports.isButtonDisabled = exports.fireOnClickAnalyticsEvent = exports.fireCommentButtonViewedAnalyticsEvent = void 0;
7
7
  var _analytics = require("@atlaskit/editor-common/analytics");
8
8
  var _mediaSingle = require("@atlaskit/editor-common/media-single");
9
+ var _editorPluginConnectivity = require("@atlaskit/editor-plugin-connectivity");
9
10
  var _expValEquals = require("@atlaskit/tmp-editor-statsig/exp-val-equals");
10
11
  var _editorCommands = require("../../editor-commands");
11
12
  var _utils = require("../../pm-plugins/utils");
@@ -16,7 +17,7 @@ var isButtonDisabled = exports.isButtonDisabled = function isButtonDisabled(_ref
16
17
  api = _ref.api,
17
18
  canAddComments = _ref.canAddComments;
18
19
  var annotationSelectionType = state ? (0, _utils.isSelectionValid)(state) : _types.AnnotationSelectionType.INVALID;
19
- return !canAddComments || annotationSelectionType === _types.AnnotationSelectionType.DISABLED || (api === null || api === void 0 || (_api$connectivity = api.connectivity) === null || _api$connectivity === void 0 || (_api$connectivity = _api$connectivity.sharedState) === null || _api$connectivity === void 0 || (_api$connectivity = _api$connectivity.currentState()) === null || _api$connectivity === void 0 ? void 0 : _api$connectivity.mode) === 'offline';
20
+ return !canAddComments || annotationSelectionType === _types.AnnotationSelectionType.DISABLED || (0, _editorPluginConnectivity.isOfflineMode)(api === null || api === void 0 || (_api$connectivity = api.connectivity) === null || _api$connectivity === void 0 || (_api$connectivity = _api$connectivity.sharedState) === null || _api$connectivity === void 0 || (_api$connectivity = _api$connectivity.currentState()) === null || _api$connectivity === void 0 ? void 0 : _api$connectivity.mode);
20
21
  };
21
22
  var shouldShowCommentButton = exports.shouldShowCommentButton = function shouldShowCommentButton(_ref2) {
22
23
  var state = _ref2.state,
@@ -13,6 +13,7 @@ var _analytics = require("@atlaskit/editor-common/analytics");
13
13
  var _hooks = require("@atlaskit/editor-common/hooks");
14
14
  var _useSharedPluginStateSelector = require("@atlaskit/editor-common/use-shared-plugin-state-selector");
15
15
  var _utils = require("@atlaskit/editor-common/utils");
16
+ var _editorPluginConnectivity = require("@atlaskit/editor-plugin-connectivity");
16
17
  var _utils2 = require("@atlaskit/editor-prosemirror/utils");
17
18
  var _experiments = require("@atlaskit/tmp-editor-statsig/experiments");
18
19
  var _editorCommands = require("../editor-commands");
@@ -149,7 +150,7 @@ function InlineCommentView(_ref) {
149
150
  },
150
151
  inlineNodeTypes: inlineNodeTypes,
151
152
  isOpeningMediaCommentFromToolbar: isOpeningMediaCommentFromToolbar,
152
- isOffline: networkStatusSelector === 'offline'
153
+ isOffline: (0, _editorPluginConnectivity.isOfflineMode)(networkStatusSelector)
153
154
  }));
154
155
  }
155
156
 
@@ -210,6 +211,6 @@ function InlineCommentView(_ref) {
210
211
  (0, _editorCommands.closeComponent)()(editorView.state, editorView.dispatch);
211
212
  },
212
213
  isOpeningMediaCommentFromToolbar: isOpeningMediaCommentFromToolbar,
213
- isOffline: networkStatusSelector === 'offline'
214
+ isOffline: (0, _editorPluginConnectivity.isOfflineMode)(networkStatusSelector)
214
215
  }));
215
216
  }
@@ -4,6 +4,7 @@ import { ToolTipContent, addInlineComment } from '@atlaskit/editor-common/keymap
4
4
  import { currentMediaNodeWithPos } from '@atlaskit/editor-common/media-single';
5
5
  import { annotationMessages } from '@atlaskit/editor-common/messages';
6
6
  import { calculateToolbarPositionAboveSelection, calculateToolbarPositionTrackHead, getRangeInlineNodeNames } from '@atlaskit/editor-common/utils';
7
+ import { isOfflineMode } from '@atlaskit/editor-plugin-connectivity';
7
8
  import CommentIcon from '@atlaskit/icon/core/comment';
8
9
  import { fg } from '@atlaskit/platform-feature-flags';
9
10
  import { expValEquals } from '@atlaskit/tmp-editor-statsig/exp-val-equals';
@@ -88,7 +89,7 @@ export const buildToolbar = editorAnalyticsAPI => ({
88
89
  const createComment = {
89
90
  type: 'button',
90
91
  showTitle: true,
91
- disabled: isCommentButtonDisabled || (api === null || api === void 0 ? void 0 : (_api$connectivity = api.connectivity) === null || _api$connectivity === void 0 ? void 0 : (_api$connectivity$sha = _api$connectivity.sharedState) === null || _api$connectivity$sha === void 0 ? void 0 : (_api$connectivity$sha2 = _api$connectivity$sha.currentState()) === null || _api$connectivity$sha2 === void 0 ? void 0 : _api$connectivity$sha2.mode) === 'offline',
92
+ disabled: isCommentButtonDisabled || isOfflineMode(api === null || api === void 0 ? void 0 : (_api$connectivity = api.connectivity) === null || _api$connectivity === void 0 ? void 0 : (_api$connectivity$sha = _api$connectivity.sharedState) === null || _api$connectivity$sha === void 0 ? void 0 : (_api$connectivity$sha2 = _api$connectivity$sha.currentState()) === null || _api$connectivity$sha2 === void 0 ? void 0 : _api$connectivity$sha2.mode),
92
93
  testId: AnnotationTestIds.floatingToolbarCreateButton,
93
94
  interactionName: 'start-inline-comment-action',
94
95
  icon: CommentIcon,
@@ -1,5 +1,6 @@
1
1
  import { ACTION, ACTION_SUBJECT, ACTION_SUBJECT_ID, EVENT_TYPE, INPUT_METHOD, MODE } from '@atlaskit/editor-common/analytics';
2
2
  import { currentMediaNodeWithPos } from '@atlaskit/editor-common/media-single';
3
+ import { isOfflineMode } from '@atlaskit/editor-plugin-connectivity';
3
4
  import { expValEquals } from '@atlaskit/tmp-editor-statsig/exp-val-equals';
4
5
  import { setInlineCommentDraftState } from '../../editor-commands';
5
6
  import { inlineCommentPluginKey, isSelectionValid } from '../../pm-plugins/utils';
@@ -11,7 +12,7 @@ export const isButtonDisabled = ({
11
12
  }) => {
12
13
  var _api$connectivity, _api$connectivity$sha, _api$connectivity$sha2;
13
14
  const annotationSelectionType = state ? isSelectionValid(state) : AnnotationSelectionType.INVALID;
14
- return !canAddComments || annotationSelectionType === AnnotationSelectionType.DISABLED || (api === null || api === void 0 ? void 0 : (_api$connectivity = api.connectivity) === null || _api$connectivity === void 0 ? void 0 : (_api$connectivity$sha = _api$connectivity.sharedState) === null || _api$connectivity$sha === void 0 ? void 0 : (_api$connectivity$sha2 = _api$connectivity$sha.currentState()) === null || _api$connectivity$sha2 === void 0 ? void 0 : _api$connectivity$sha2.mode) === 'offline';
15
+ return !canAddComments || annotationSelectionType === AnnotationSelectionType.DISABLED || isOfflineMode(api === null || api === void 0 ? void 0 : (_api$connectivity = api.connectivity) === null || _api$connectivity === void 0 ? void 0 : (_api$connectivity$sha = _api$connectivity.sharedState) === null || _api$connectivity$sha === void 0 ? void 0 : (_api$connectivity$sha2 = _api$connectivity$sha.currentState()) === null || _api$connectivity$sha2 === void 0 ? void 0 : _api$connectivity$sha2.mode);
15
16
  };
16
17
  export const shouldShowCommentButton = ({
17
18
  state,
@@ -4,6 +4,7 @@ import { ACTION, ACTION_SUBJECT, ACTION_SUBJECT_ID, CONTENT_COMPONENT, EVENT_TYP
4
4
  import { useSharedPluginStateWithSelector } from '@atlaskit/editor-common/hooks';
5
5
  import { useSharedPluginStateSelector } from '@atlaskit/editor-common/use-shared-plugin-state-selector';
6
6
  import { getAnnotationInlineNodeTypes, getRangeInlineNodeNames } from '@atlaskit/editor-common/utils';
7
+ import { isOfflineMode } from '@atlaskit/editor-plugin-connectivity';
7
8
  import { findDomRefAtPos } from '@atlaskit/editor-prosemirror/utils';
8
9
  import { editorExperiment } from '@atlaskit/tmp-editor-statsig/experiments';
9
10
  import { closeComponent, createAnnotation, removeInlineCommentNearSelection, setInlineCommentDraftState, updateInlineCommentResolvedState } from '../editor-commands';
@@ -147,7 +148,7 @@ export function InlineCommentView({
147
148
  },
148
149
  inlineNodeTypes: inlineNodeTypes,
149
150
  isOpeningMediaCommentFromToolbar: isOpeningMediaCommentFromToolbar,
150
- isOffline: networkStatusSelector === 'offline'
151
+ isOffline: isOfflineMode(networkStatusSelector)
151
152
  }));
152
153
  }
153
154
 
@@ -202,6 +203,6 @@ export function InlineCommentView({
202
203
  closeComponent()(editorView.state, editorView.dispatch);
203
204
  },
204
205
  isOpeningMediaCommentFromToolbar: isOpeningMediaCommentFromToolbar,
205
- isOffline: networkStatusSelector === 'offline'
206
+ isOffline: isOfflineMode(networkStatusSelector)
206
207
  }));
207
208
  }
@@ -4,6 +4,7 @@ import { ToolTipContent, addInlineComment } from '@atlaskit/editor-common/keymap
4
4
  import { currentMediaNodeWithPos } from '@atlaskit/editor-common/media-single';
5
5
  import { annotationMessages } from '@atlaskit/editor-common/messages';
6
6
  import { calculateToolbarPositionAboveSelection, calculateToolbarPositionTrackHead, getRangeInlineNodeNames } from '@atlaskit/editor-common/utils';
7
+ import { isOfflineMode } from '@atlaskit/editor-plugin-connectivity';
7
8
  import CommentIcon from '@atlaskit/icon/core/comment';
8
9
  import { fg } from '@atlaskit/platform-feature-flags';
9
10
  import { expValEquals } from '@atlaskit/tmp-editor-statsig/exp-val-equals';
@@ -86,7 +87,7 @@ export var buildToolbar = function buildToolbar(editorAnalyticsAPI) {
86
87
  var createComment = {
87
88
  type: 'button',
88
89
  showTitle: true,
89
- disabled: isCommentButtonDisabled || (api === null || api === void 0 || (_api$connectivity = api.connectivity) === null || _api$connectivity === void 0 || (_api$connectivity = _api$connectivity.sharedState) === null || _api$connectivity === void 0 || (_api$connectivity = _api$connectivity.currentState()) === null || _api$connectivity === void 0 ? void 0 : _api$connectivity.mode) === 'offline',
90
+ disabled: isCommentButtonDisabled || isOfflineMode(api === null || api === void 0 || (_api$connectivity = api.connectivity) === null || _api$connectivity === void 0 || (_api$connectivity = _api$connectivity.sharedState) === null || _api$connectivity === void 0 || (_api$connectivity = _api$connectivity.currentState()) === null || _api$connectivity === void 0 ? void 0 : _api$connectivity.mode),
90
91
  testId: AnnotationTestIds.floatingToolbarCreateButton,
91
92
  interactionName: 'start-inline-comment-action',
92
93
  icon: CommentIcon,
@@ -1,5 +1,6 @@
1
1
  import { ACTION, ACTION_SUBJECT, ACTION_SUBJECT_ID, EVENT_TYPE, INPUT_METHOD, MODE } from '@atlaskit/editor-common/analytics';
2
2
  import { currentMediaNodeWithPos } from '@atlaskit/editor-common/media-single';
3
+ import { isOfflineMode } from '@atlaskit/editor-plugin-connectivity';
3
4
  import { expValEquals } from '@atlaskit/tmp-editor-statsig/exp-val-equals';
4
5
  import { setInlineCommentDraftState } from '../../editor-commands';
5
6
  import { inlineCommentPluginKey, isSelectionValid } from '../../pm-plugins/utils';
@@ -10,7 +11,7 @@ export var isButtonDisabled = function isButtonDisabled(_ref) {
10
11
  api = _ref.api,
11
12
  canAddComments = _ref.canAddComments;
12
13
  var annotationSelectionType = state ? isSelectionValid(state) : AnnotationSelectionType.INVALID;
13
- return !canAddComments || annotationSelectionType === AnnotationSelectionType.DISABLED || (api === null || api === void 0 || (_api$connectivity = api.connectivity) === null || _api$connectivity === void 0 || (_api$connectivity = _api$connectivity.sharedState) === null || _api$connectivity === void 0 || (_api$connectivity = _api$connectivity.currentState()) === null || _api$connectivity === void 0 ? void 0 : _api$connectivity.mode) === 'offline';
14
+ return !canAddComments || annotationSelectionType === AnnotationSelectionType.DISABLED || isOfflineMode(api === null || api === void 0 || (_api$connectivity = api.connectivity) === null || _api$connectivity === void 0 || (_api$connectivity = _api$connectivity.sharedState) === null || _api$connectivity === void 0 || (_api$connectivity = _api$connectivity.currentState()) === null || _api$connectivity === void 0 ? void 0 : _api$connectivity.mode);
14
15
  };
15
16
  export var shouldShowCommentButton = function shouldShowCommentButton(_ref2) {
16
17
  var state = _ref2.state,
@@ -5,6 +5,7 @@ import { ACTION, ACTION_SUBJECT, ACTION_SUBJECT_ID, CONTENT_COMPONENT, EVENT_TYP
5
5
  import { useSharedPluginStateWithSelector } from '@atlaskit/editor-common/hooks';
6
6
  import { useSharedPluginStateSelector } from '@atlaskit/editor-common/use-shared-plugin-state-selector';
7
7
  import { getAnnotationInlineNodeTypes, getRangeInlineNodeNames } from '@atlaskit/editor-common/utils';
8
+ import { isOfflineMode } from '@atlaskit/editor-plugin-connectivity';
8
9
  import { findDomRefAtPos } from '@atlaskit/editor-prosemirror/utils';
9
10
  import { editorExperiment } from '@atlaskit/tmp-editor-statsig/experiments';
10
11
  import { closeComponent, createAnnotation, removeInlineCommentNearSelection, setInlineCommentDraftState, updateInlineCommentResolvedState } from '../editor-commands';
@@ -140,7 +141,7 @@ export function InlineCommentView(_ref) {
140
141
  },
141
142
  inlineNodeTypes: inlineNodeTypes,
142
143
  isOpeningMediaCommentFromToolbar: isOpeningMediaCommentFromToolbar,
143
- isOffline: networkStatusSelector === 'offline'
144
+ isOffline: isOfflineMode(networkStatusSelector)
144
145
  }));
145
146
  }
146
147
 
@@ -201,6 +202,6 @@ export function InlineCommentView(_ref) {
201
202
  closeComponent()(editorView.state, editorView.dispatch);
202
203
  },
203
204
  isOpeningMediaCommentFromToolbar: isOpeningMediaCommentFromToolbar,
204
- isOffline: networkStatusSelector === 'offline'
205
+ isOffline: isOfflineMode(networkStatusSelector)
205
206
  }));
206
207
  }
package/package.json CHANGED
@@ -1,6 +1,6 @@
1
1
  {
2
2
  "name": "@atlaskit/editor-plugin-annotation",
3
- "version": "6.3.2",
3
+ "version": "7.0.0",
4
4
  "description": "Annotation plugin for @atlaskit/editor-core",
5
5
  "author": "Atlassian Pty Ltd",
6
6
  "license": "Apache-2.0",
@@ -28,23 +28,23 @@
28
28
  "atlaskit:src": "src/index.ts",
29
29
  "dependencies": {
30
30
  "@atlaskit/adf-schema": "^51.5.0",
31
- "@atlaskit/editor-plugin-analytics": "^6.2.0",
32
- "@atlaskit/editor-plugin-connectivity": "^6.0.0",
33
- "@atlaskit/editor-plugin-editor-viewmode-effects": "^6.1.0",
34
- "@atlaskit/editor-plugin-feature-flags": "^5.0.0",
35
- "@atlaskit/editor-plugin-toolbar": "^3.4.0",
36
- "@atlaskit/editor-plugin-user-intent": "^4.0.0",
31
+ "@atlaskit/editor-plugin-analytics": "^7.0.0",
32
+ "@atlaskit/editor-plugin-connectivity": "^7.0.0",
33
+ "@atlaskit/editor-plugin-editor-viewmode-effects": "^7.0.0",
34
+ "@atlaskit/editor-plugin-feature-flags": "^6.0.0",
35
+ "@atlaskit/editor-plugin-toolbar": "^4.0.0",
36
+ "@atlaskit/editor-plugin-user-intent": "^5.0.0",
37
37
  "@atlaskit/editor-prosemirror": "^7.2.0",
38
38
  "@atlaskit/editor-toolbar": "^0.18.0",
39
39
  "@atlaskit/editor-toolbar-model": "^0.2.0",
40
40
  "@atlaskit/icon": "^29.3.0",
41
41
  "@atlaskit/platform-feature-flags": "^1.1.0",
42
- "@atlaskit/tmp-editor-statsig": "^16.0.0",
42
+ "@atlaskit/tmp-editor-statsig": "^16.3.0",
43
43
  "@babel/runtime": "^7.0.0",
44
44
  "react-intl-next": "npm:react-intl@^5.18.1"
45
45
  },
46
46
  "peerDependencies": {
47
- "@atlaskit/editor-common": "^110.46.0",
47
+ "@atlaskit/editor-common": "^111.0.0",
48
48
  "react": "^18.2.0",
49
49
  "react-dom": "^18.2.0"
50
50
  },