@atlaskit/editor-plugin-annotation 2.9.2 → 2.9.4

package/CHANGELOG.md

@@ -1,5 +1,25 @@
 # @atlaskit/editor-plugin-annotation
 
+## 2.9.4
+
+### Patch Changes
+
+- [#144021](https://bitbucket.org/atlassian/atlassian-frontend-monorepo/pull-requests/144021)
+  [`8357b7ad2daa6`](https://bitbucket.org/atlassian/atlassian-frontend-monorepo/commits/8357b7ad2daa6) -
+  Added config option for starting viewInlineCommentTraceUFOPress for inline-comments
+  annotationPlugin
+- Updated dependencies
+
+## 2.9.3
+
+### Patch Changes
+
+- [#163361](https://bitbucket.org/atlassian/atlassian-frontend-monorepo/pull-requests/163361)
+  [`76c3619bccda1`](https://bitbucket.org/atlassian/atlassian-frontend-monorepo/commits/76c3619bccda1) -
+  Changed the annotation manager feature gate to instead use the existance of the manager rather
+  then a gate
+- Updated dependencies
+
 ## 2.9.2
 
 ### Patch Changes

package/dist/cjs/annotationPlugin.js

@@ -61,6 +61,7 @@ var annotationPlugin = exports.annotationPlugin = function annotationPlugin(_ref
               editorAnalyticsAPI: api === null || api === void 0 || (_api$analytics2 = api.analytics) === null || _api$analytics2 === void 0 ? void 0 : _api$analytics2.actions,
               featureFlagsPluginState: featureFlags,
               selectCommentExperience: annotationProviders.selectCommentExperience,
+              viewInlineCommentTraceUFOPress: annotationProviders.viewInlineCommentTraceUFOPress,
               annotationManager: annotationProviders.annotationManager,
               api: api
             });

package/dist/cjs/pm-plugins/annotation-manager-hooks.js

@@ -7,7 +7,6 @@ exports.startDraft = exports.setIsAnnotationSelected = exports.setIsAnnotationHo
 var _adfSchema = require("@atlaskit/adf-schema");
 var _utils = require("@atlaskit/editor-common/utils");
 var _utils2 = require("@atlaskit/editor-prosemirror/utils");
-var _platformFeatureFlags = require("@atlaskit/platform-feature-flags");
 var _editorCommands = require("../editor-commands");
 var _types = require("../types");
 var _utils3 = require("./utils");
@@ -58,7 +57,7 @@ var startDraft = exports.startDraft = function startDraft(editorView, options) {
         reason: ERROR_REASON_DRAFT_IN_PROGRESS
       };
     }
-    if (!!(selectedAnnotations !== null && selectedAnnotations !== void 0 && selectedAnnotations.length) && (0, _platformFeatureFlags.fg)('platform_editor_comments_api_manager_select')) {
+    if (!!(selectedAnnotations !== null && selectedAnnotations !== void 0 && selectedAnnotations.length)) {
       // if there are selected annotations when starting a draft, we need to clear the selected annotations
       // before we start the draft.
       (0, _editorCommands.closeComponent)()(editorView.state, editorView.dispatch);

package/dist/cjs/pm-plugins/inline-comment.js

@@ -93,6 +93,7 @@ var fetchState = /*#__PURE__*/function () {
 var initialState = function initialState() {
   var disallowOnWhitespace = arguments.length > 0 && arguments[0] !== undefined ? arguments[0] : false;
   var featureFlagsPluginState = arguments.length > 1 ? arguments[1] : undefined;
+  var isAnnotationManagerEnabled = arguments.length > 2 && arguments[2] !== undefined ? arguments[2] : false;
   return {
     annotations: {},
     selectedAnnotations: [],
@@ -107,7 +108,8 @@ var initialState = function initialState() {
     featureFlagsPluginState: featureFlagsPluginState,
     isDrafting: false,
     pendingSelectedAnnotations: [],
-    pendingSelectedAnnotationsUpdateCount: 0
+    pendingSelectedAnnotationsUpdateCount: 0,
+    isAnnotationManagerEnabled: isAnnotationManagerEnabled
   };
 };
 var hideToolbar = function hideToolbar(state, dispatch) {
@@ -164,7 +166,7 @@ var inlineCommentPlugin = exports.inlineCommentPlugin = function inlineCommentPl
     annotationManager = options.annotationManager;
   return new _safePlugin.SafePlugin({
     key: _utils2.inlineCommentPluginKey,
-    state: (0, _pluginFactory.createPluginState)(options.dispatch, initialState(provider.disallowOnWhitespace, featureFlagsPluginState)),
+    state: (0, _pluginFactory.createPluginState)(options.dispatch, initialState(provider.disallowOnWhitespace, featureFlagsPluginState, !!annotationManager)),
     view: function view(editorView) {
       var allowAnnotationFn;
       var startDraftFn;
@@ -174,25 +176,23 @@ var inlineCommentPlugin = exports.inlineCommentPlugin = function inlineCommentPl
       var setIsAnnotationSelectedFn;
       var setIsAnnotationHoveredFn;
       var clearAnnotationFn;
-      if (annotationManager && (0, _platformFeatureFlags.fg)('platform_editor_comments_api_manager')) {
+      if (annotationManager) {
         allowAnnotationFn = (0, _annotationManagerHooks.allowAnnotation)(editorView, options);
         startDraftFn = (0, _annotationManagerHooks.startDraft)(editorView, options);
         clearDraftFn = (0, _annotationManagerHooks.clearDraft)(editorView, options);
         applyDraftFn = (0, _annotationManagerHooks.applyDraft)(editorView, options);
         getDraftFn = (0, _annotationManagerHooks.getDraft)(editorView, options);
+        setIsAnnotationSelectedFn = (0, _annotationManagerHooks.setIsAnnotationSelected)(editorView, options);
+        setIsAnnotationHoveredFn = (0, _annotationManagerHooks.setIsAnnotationHovered)(editorView, options);
+        clearAnnotationFn = (0, _annotationManagerHooks.clearAnnotation)(editorView, options);
         annotationManager.hook('allowAnnotation', allowAnnotationFn);
         annotationManager.hook('startDraft', startDraftFn);
         annotationManager.hook('clearDraft', clearDraftFn);
         annotationManager.hook('applyDraft', applyDraftFn);
         annotationManager.hook('getDraft', getDraftFn);
-        if ((0, _platformFeatureFlags.fg)('platform_editor_comments_api_manager_select')) {
-          setIsAnnotationSelectedFn = (0, _annotationManagerHooks.setIsAnnotationSelected)(editorView, options);
-          setIsAnnotationHoveredFn = (0, _annotationManagerHooks.setIsAnnotationHovered)(editorView, options);
-          clearAnnotationFn = (0, _annotationManagerHooks.clearAnnotation)(editorView, options);
-          annotationManager.hook('setIsAnnotationSelected', setIsAnnotationSelectedFn);
-          annotationManager.hook('setIsAnnotationHovered', setIsAnnotationHoveredFn);
-          annotationManager.hook('clearAnnotation', clearAnnotationFn);
-        }
+        annotationManager.hook('setIsAnnotationSelected', setIsAnnotationSelectedFn);
+        annotationManager.hook('setIsAnnotationHovered', setIsAnnotationHoveredFn);
+        annotationManager.hook('clearAnnotation', clearAnnotationFn);
       }
       // Get initial state
       // Need to pass `editorView` to mitigate editor state going stale
@@ -266,18 +266,25 @@ var inlineCommentPlugin = exports.inlineCommentPlugin = function inlineCommentPl
           var _ref5 = (0, _utils2.getPluginState)(_prevState) || {},
             prevSelectedAnnotations = _ref5.selectedAnnotations;
           var selectedAnnotationId = selectedAnnotations && selectedAnnotations.length !== 0 && selectedAnnotations[0].id ? selectedAnnotations[0].id : undefined;
+
           // If the new state has an unresolved selected annotation, and it's different from
-          // the previous one then we mark the select annotation experience as complete.
+          // the previous one then...
           if (
           //This checks the selected annotation is different from the previous one
           selectedAnnotationId && selectedAnnotationId !== (prevSelectedAnnotations === null || prevSelectedAnnotations === void 0 || (_prevSelectedAnnotati = prevSelectedAnnotations[0]) === null || _prevSelectedAnnotati === void 0 ? void 0 : _prevSelectedAnnotati.id) &&
           // This ensures that the selected annotation is unresolved
           annotations && annotations[selectedAnnotationId] === false) {
             var _options$selectCommen;
+            // ...we mark the select annotation experience as complete.
             // The selectComponentExperience is using a simplified object, which is why it's type asserted.
             (_options$selectCommen = options.selectCommentExperience) === null || _options$selectCommen === void 0 || _options$selectCommen.selectAnnotation.complete(selectedAnnotationId);
+            if ((0, _platformFeatureFlags.fg)('cc_comments_track_view_inline_comment_action')) {
+              var _options$viewInlineCo;
+              // ...and start a new UFO press trace since the selected comment is changing
+              (_options$viewInlineCo = options.viewInlineCommentTraceUFOPress) === null || _options$viewInlineCo === void 0 || _options$viewInlineCo.call(options);
+            }
           }
-          if ((0, _platformFeatureFlags.fg)('platform_editor_comments_api_manager_select')) {
+          if (annotationManager) {
             // In the Editor, Annotations can be selected in three ways:
             // 1. By clicking on the annotation in the editor
             // 2. By using the annotation manager to select the annotation
@@ -295,7 +302,7 @@ var inlineCommentPlugin = exports.inlineCommentPlugin = function inlineCommentPl
               // Need to set a lock to avoid calling gate multiple times. The lock will be released
               // when the preemptive gate is complete.
               isPreemptiveGateActive = true;
-              annotationManager === null || annotationManager === void 0 || annotationManager.checkPreemptiveGate().then(function (canSelectAnnotation) {
+              annotationManager.checkPreemptiveGate().then(function (canSelectAnnotation) {
                 var _ref8 = (0, _utils2.getPluginState)(view.state) || {},
                   isDrafting = _ref8.isDrafting,
                   latestPendingSelectedAnnotations = _ref8.pendingSelectedAnnotations,
@@ -314,8 +321,8 @@ var inlineCommentPlugin = exports.inlineCommentPlugin = function inlineCommentPl
                       return pendingAnnotation.id === annotation.id;
                     })) === -1;
                   }).forEach(function (annotation) {
-                    var _options$annotationMa, _getAnnotationInlineN;
-                    (_options$annotationMa = options.annotationManager) === null || _options$annotationMa === void 0 || _options$annotationMa.emit({
+                    var _getAnnotationInlineN;
+                    annotationManager.emit({
                       name: 'annotationSelectionChanged',
                       data: {
                         annotationId: annotation.id,
@@ -327,9 +334,9 @@ var inlineCommentPlugin = exports.inlineCommentPlugin = function inlineCommentPl
 
                   // Notify the annotation manager that the pending selection has changed.
                   latestPendingSelectedAnnotations === null || latestPendingSelectedAnnotations === void 0 || latestPendingSelectedAnnotations.forEach(function (_ref9) {
-                    var _options$annotationMa2, _getAnnotationInlineN2;
+                    var _getAnnotationInlineN2;
                     var id = _ref9.id;
-                    (_options$annotationMa2 = options.annotationManager) === null || _options$annotationMa2 === void 0 || _options$annotationMa2.emit({
+                    annotationManager.emit({
                       name: 'annotationSelectionChanged',
                       data: {
                         annotationId: id,
@@ -352,8 +359,8 @@ var inlineCommentPlugin = exports.inlineCommentPlugin = function inlineCommentPl
               });
             }
           }
-          var _ref10 = (0, _utils2.getPluginState)(view.state) || {},
-            dirtyAnnotations = _ref10.dirtyAnnotations;
+          var _ref0 = (0, _utils2.getPluginState)(view.state) || {},
+            dirtyAnnotations = _ref0.dirtyAnnotations;
           if (!dirtyAnnotations) {
             return;
           }
@@ -366,7 +373,7 @@ var inlineCommentPlugin = exports.inlineCommentPlugin = function inlineCommentPl
           if (updateSubscriber) {
             updateSubscriber.off('resolve', resolve).off('delete', resolve).off('unresolve', unResolve).off('create', unResolve).off('setvisibility', setVisibility).off('setselectedannotation', setSelectedAnnotationFn).off('sethoveredannotation', setHoveredAnnotationFn).off('removehoveredannotation', removeHoveredannotationFn).off('closeinlinecomment', closeInlineCommentFn);
           }
-          if (annotationManager && (0, _platformFeatureFlags.fg)('platform_editor_comments_api_manager')) {
+          if (annotationManager) {
             annotationManager.unhook('allowAnnotation', allowAnnotationFn);
             annotationManager.unhook('startDraft', startDraftFn);
             annotationManager.unhook('clearDraft', clearDraftFn);
@@ -416,13 +423,13 @@ var inlineCommentPlugin = exports.inlineCommentPlugin = function inlineCommentPl
           if (isSelected && !(pluginState !== null && pluginState !== void 0 && pluginState.isInlineCommentViewClosed)) {
             return false;
           }
-          var _ref11 = pluginState || {},
-            annotations = _ref11.annotations;
+          var _ref1 = pluginState || {},
+            annotations = _ref1.annotations;
           var isUnresolved = annotations && annotations[annotationId] === false;
           if (!isUnresolved) {
             return false;
           }
-          if ((0, _platformFeatureFlags.fg)('platform_editor_comments_api_manager_select')) {
+          if (annotationManager) {
             var _pluginState$pendingS;
             // The manager disable setting the selected annotation on click because in the editor this is already
             // handled by the selection update handler. When the manager is enabled, and a selection changes it's pushed into
@@ -445,13 +452,13 @@ var inlineCommentPlugin = exports.inlineCommentPlugin = function inlineCommentPl
       },
       decorations: function decorations(state) {
         // highlight comments, depending on state
-        var _ref12 = (0, _utils2.getPluginState)(state) || {},
-          draftDecorationSet = _ref12.draftDecorationSet,
-          annotations = _ref12.annotations,
-          selectedAnnotations = _ref12.selectedAnnotations,
-          isVisible = _ref12.isVisible,
-          isInlineCommentViewClosed = _ref12.isInlineCommentViewClosed,
-          hoveredAnnotations = _ref12.hoveredAnnotations;
+        var _ref10 = (0, _utils2.getPluginState)(state) || {},
+          draftDecorationSet = _ref10.draftDecorationSet,
+          annotations = _ref10.annotations,
+          selectedAnnotations = _ref10.selectedAnnotations,
+          isVisible = _ref10.isVisible,
+          isInlineCommentViewClosed = _ref10.isInlineCommentViewClosed,
+          hoveredAnnotations = _ref10.hoveredAnnotations;
         var decorations = draftDecorationSet !== null && draftDecorationSet !== void 0 ? draftDecorationSet : _view.DecorationSet.empty;
         var focusDecorations = [];
 

package/dist/cjs/pm-plugins/plugin-factory.js

@@ -9,7 +9,6 @@ var _defineProperty2 = _interopRequireDefault(require("@babel/runtime/helpers/de
 var _utils = require("@atlaskit/editor-common/utils");
 var _state = require("@atlaskit/editor-prosemirror/state");
 var _view = require("@atlaskit/editor-prosemirror/view");
-var _platformFeatureFlags = require("@atlaskit/platform-feature-flags");
 var _reducer = _interopRequireDefault(require("./reducer"));
 var _utils2 = require("./utils");
 function ownKeys(e, r) { var t = Object.keys(e); if (Object.getOwnPropertySymbols) { var o = Object.getOwnPropertySymbols(e); r && (o = o.filter(function (r) { return Object.getOwnPropertyDescriptor(e, r).enumerable; })), t.push.apply(t, o); } return t; }
@@ -111,7 +110,6 @@ var getSelectionChangeHandlerNew = function getSelectionChangeHandlerNew(reopenC
 
     // NOTE: I've left this commented code here as a reference that the previous old code would reset the selected annotations
     // if the selection is empty. If this is no longer needed, we can remove this code.
-    // clean up with platform_editor_comments_api_manager_select
     // if (selectedAnnotations.length === 0) {
     // 	return {
     // 		...pluginState,
@@ -140,7 +138,11 @@ var getSelectionChangeHandlerNew = function getSelectionChangeHandlerNew(reopenC
 };
 var getSelectionChangedHandler = function getSelectionChangedHandler(reopenCommentView) {
   return function (tr, pluginState) {
-    return (0, _platformFeatureFlags.fg)('platform_editor_comments_api_manager_select') ? getSelectionChangeHandlerNew(reopenCommentView)(tr, pluginState) : getSelectionChangeHandlerOld(reopenCommentView)(tr, pluginState);
+    return pluginState.isAnnotationManagerEnabled ?
+    // if platform_editor_comments_api_manager == true
+    getSelectionChangeHandlerNew(reopenCommentView)(tr, pluginState) :
+    // else if platform_editor_comments_api_manager == false
+    getSelectionChangeHandlerOld(reopenCommentView)(tr, pluginState);
   };
 };
 var _pluginFactory = (0, _utils.pluginFactory)(_utils2.inlineCommentPluginKey, _reducer.default, {

package/dist/cjs/pm-plugins/reducer.js

@@ -38,7 +38,7 @@ var _default = exports.default = function _default(pluginState, action) {
         isOpeningMediaCommentFromToolbar: false
       }, (0, _platformFeatureFlags.fg)('platform_editor_annotation_selected_annotation') && {
         selectedAnnotations: []
-      }), (0, _platformFeatureFlags.fg)('platform_editor_comments_api_manager_select') && {
+      }), pluginState.isAnnotationManagerEnabled && {
         selectedAnnotations: []
       });
     case _types.ACTIONS.ADD_INLINE_COMMENT:
@@ -48,7 +48,7 @@ var _default = exports.default = function _default(pluginState, action) {
         annotations: _objectSpread(_objectSpread({}, pluginState.annotations), action.data.inlineComments),
         isInlineCommentViewClosed: false,
         selectAnnotationMethod: undefined
-      }, (0, _platformFeatureFlags.fg)('platform_editor_comments_api_manager_select') && {
+      }, pluginState.isAnnotationManagerEnabled && {
         skipSelectionHandling: true
       });
     case _types.ACTIONS.INLINE_COMMENT_SET_VISIBLE:

package/dist/cjs/pm-plugins/toolbar.js

@@ -133,7 +133,7 @@ var buildToolbar = exports.buildToolbar = function buildToolbar(editorAnalyticsA
             pageMode: 'edit'
           }
         });
-        if (annotationManager && (0, _platformFeatureFlags.fg)('platform_editor_comments_api_manager')) {
+        if (annotationManager) {
           annotationManager.checkPreemptiveGate().then(function (canStartDraft) {
             if (canStartDraft) {
               createCommentExperience === null || createCommentExperience === void 0 || createCommentExperience.start({

package/dist/cjs/types/index.js

@@ -26,9 +26,4 @@ var AnnotationTestIds = exports.AnnotationTestIds = {
   floatingToolbarCreateButton: "".concat(prefix, "-toolbar-create-button"),
   componentSave: "".concat(prefix, "-dummy-save-button"),
   componentClose: "".concat(prefix, "-dummy-close-button")
-};
-
-/**
- * Alternative to SelectInlineCommentCompoundExperience, used for the annotation plugin options
- * in the confluence editor presets. See createFullPageEditorPreset.ts or annotationPluginOptions.ts for usage.
- */
+};

package/dist/cjs/ui/InlineCommentView.js

@@ -20,8 +20,7 @@ var _editorCommands = require("../editor-commands");
 var _utils3 = require("../pm-plugins/utils");
 var _types = require("../types");
 var _AnnotationViewWrapper = require("./AnnotationViewWrapper");
-function _getRequireWildcardCache(e) { if ("function" != typeof WeakMap) return null; var r = new WeakMap(), t = new WeakMap(); return (_getRequireWildcardCache = function _getRequireWildcardCache(e) { return e ? t : r; })(e); }
-function _interopRequireWildcard(e, r) { if (!r && e && e.__esModule) return e; if (null === e || "object" != _typeof(e) && "function" != typeof e) return { default: e }; var t = _getRequireWildcardCache(r); if (t && t.has(e)) return t.get(e); var n = { __proto__: null }, a = Object.defineProperty && Object.getOwnPropertyDescriptor; for (var u in e) if ("default" !== u && {}.hasOwnProperty.call(e, u)) { var i = a ? Object.getOwnPropertyDescriptor(e, u) : null; i && (i.get || i.set) ? Object.defineProperty(n, u, i) : n[u] = e[u]; } return n.default = e, t && t.set(e, n), n; }
+function _interopRequireWildcard(e, t) { if ("function" == typeof WeakMap) var r = new WeakMap(), n = new WeakMap(); return (_interopRequireWildcard = function _interopRequireWildcard(e, t) { if (!t && e && e.__esModule) return e; var o, i, f = { __proto__: null, default: e }; if (null === e || "object" != _typeof(e) && "function" != typeof e) return f; if (o = t ? n : r) { if (o.has(e)) return o.get(e); o.set(e, f); } for (var _t in e) "default" !== _t && {}.hasOwnProperty.call(e, _t) && ((i = (o = Object.defineProperty) && Object.getOwnPropertyDescriptor(e, _t)) && (i.get || i.set) ? o(f, _t, i) : f[_t] = e[_t]); return f; })(e, t); }
 var findPosForDOM = function findPosForDOM(sel) {
   var $from = sel.$from,
     from = sel.from;

package/dist/es2019/annotationPlugin.js

@@ -52,6 +52,7 @@ export const annotationPlugin = ({
             editorAnalyticsAPI: api === null || api === void 0 ? void 0 : (_api$analytics2 = api.analytics) === null || _api$analytics2 === void 0 ? void 0 : _api$analytics2.actions,
             featureFlagsPluginState: featureFlags,
             selectCommentExperience: annotationProviders.selectCommentExperience,
+            viewInlineCommentTraceUFOPress: annotationProviders.viewInlineCommentTraceUFOPress,
             annotationManager: annotationProviders.annotationManager,
             api
           });

package/dist/es2019/pm-plugins/annotation-manager-hooks.js

@@ -1,7 +1,6 @@
 import { AnnotationTypes } from '@atlaskit/adf-schema';
 import { getAnnotationInlineNodeTypes, getRangeInlineNodeNames } from '@atlaskit/editor-common/utils';
 import { findDomRefAtPos } from '@atlaskit/editor-prosemirror/utils';
-import { fg } from '@atlaskit/platform-feature-flags';
 import { setInlineCommentDraftState, createAnnotation, setSelectedAnnotation, closeComponent, setHoveredAnnotation, removeInlineCommentFromDoc } from '../editor-commands';
 import { AnnotationSelectionType } from '../types';
 import { inlineCommentPluginKey, isSelectionValid } from './utils';
@@ -51,7 +50,7 @@ export const startDraft = (editorView, options) => () => {
       reason: ERROR_REASON_DRAFT_IN_PROGRESS
     };
   }
-  if (!!(selectedAnnotations !== null && selectedAnnotations !== void 0 && selectedAnnotations.length) && fg('platform_editor_comments_api_manager_select')) {
+  if (!!(selectedAnnotations !== null && selectedAnnotations !== void 0 && selectedAnnotations.length)) {
     // if there are selected annotations when starting a draft, we need to clear the selected annotations
     // before we start the draft.
     closeComponent()(editorView.state, editorView.dispatch);

package/dist/es2019/pm-plugins/inline-comment.js

@@ -37,7 +37,7 @@ const fetchState = async (provider, annotationIds, editorView, editorAnalyticsAP
     updateInlineCommentResolvedState(editorAnalyticsAPI)(inlineCommentStates)(editorView.state, editorView.dispatch);
   }
 };
-const initialState = (disallowOnWhitespace = false, featureFlagsPluginState) => {
+const initialState = (disallowOnWhitespace = false, featureFlagsPluginState, isAnnotationManagerEnabled = false) => {
   return {
     annotations: {},
     selectedAnnotations: [],
@@ -52,7 +52,8 @@ const initialState = (disallowOnWhitespace = false, featureFlagsPluginState) =>
     featureFlagsPluginState,
     isDrafting: false,
     pendingSelectedAnnotations: [],
-    pendingSelectedAnnotationsUpdateCount: 0
+    pendingSelectedAnnotationsUpdateCount: 0,
+    isAnnotationManagerEnabled
   };
 };
 const hideToolbar = (state, dispatch) => () => {
@@ -104,7 +105,7 @@ export const inlineCommentPlugin = options => {
   } = options;
   return new SafePlugin({
     key: inlineCommentPluginKey,
-    state: createPluginState(options.dispatch, initialState(provider.disallowOnWhitespace, featureFlagsPluginState)),
+    state: createPluginState(options.dispatch, initialState(provider.disallowOnWhitespace, featureFlagsPluginState, !!annotationManager)),
     view(editorView) {
       let allowAnnotationFn;
       let startDraftFn;
@@ -114,25 +115,23 @@ export const inlineCommentPlugin = options => {
       let setIsAnnotationSelectedFn;
       let setIsAnnotationHoveredFn;
       let clearAnnotationFn;
-      if (annotationManager && fg('platform_editor_comments_api_manager')) {
+      if (annotationManager) {
         allowAnnotationFn = allowAnnotation(editorView, options);
         startDraftFn = startDraft(editorView, options);
         clearDraftFn = clearDraft(editorView, options);
         applyDraftFn = applyDraft(editorView, options);
         getDraftFn = getDraft(editorView, options);
+        setIsAnnotationSelectedFn = setIsAnnotationSelected(editorView, options);
+        setIsAnnotationHoveredFn = setIsAnnotationHovered(editorView, options);
+        clearAnnotationFn = clearAnnotation(editorView, options);
         annotationManager.hook('allowAnnotation', allowAnnotationFn);
         annotationManager.hook('startDraft', startDraftFn);
         annotationManager.hook('clearDraft', clearDraftFn);
         annotationManager.hook('applyDraft', applyDraftFn);
         annotationManager.hook('getDraft', getDraftFn);
-        if (fg('platform_editor_comments_api_manager_select')) {
-          setIsAnnotationSelectedFn = setIsAnnotationSelected(editorView, options);
-          setIsAnnotationHoveredFn = setIsAnnotationHovered(editorView, options);
-          clearAnnotationFn = clearAnnotation(editorView, options);
-          annotationManager.hook('setIsAnnotationSelected', setIsAnnotationSelectedFn);
-          annotationManager.hook('setIsAnnotationHovered', setIsAnnotationHoveredFn);
-          annotationManager.hook('clearAnnotation', clearAnnotationFn);
-        }
+        annotationManager.hook('setIsAnnotationSelected', setIsAnnotationSelectedFn);
+        annotationManager.hook('setIsAnnotationHovered', setIsAnnotationHoveredFn);
+        annotationManager.hook('clearAnnotation', clearAnnotationFn);
       }
       // Get initial state
       // Need to pass `editorView` to mitigate editor state going stale
@@ -202,18 +201,25 @@ export const inlineCommentPlugin = options => {
             selectedAnnotations: prevSelectedAnnotations
           } = getPluginState(_prevState) || {};
           const selectedAnnotationId = selectedAnnotations && selectedAnnotations.length !== 0 && selectedAnnotations[0].id ? selectedAnnotations[0].id : undefined;
+
           // If the new state has an unresolved selected annotation, and it's different from
-          // the previous one then we mark the select annotation experience as complete.
+          // the previous one then...
           if (
           //This checks the selected annotation is different from the previous one
           selectedAnnotationId && selectedAnnotationId !== (prevSelectedAnnotations === null || prevSelectedAnnotations === void 0 ? void 0 : (_prevSelectedAnnotati = prevSelectedAnnotations[0]) === null || _prevSelectedAnnotati === void 0 ? void 0 : _prevSelectedAnnotati.id) &&
           // This ensures that the selected annotation is unresolved
           annotations && annotations[selectedAnnotationId] === false) {
             var _options$selectCommen;
+            // ...we mark the select annotation experience as complete.
             // The selectComponentExperience is using a simplified object, which is why it's type asserted.
             (_options$selectCommen = options.selectCommentExperience) === null || _options$selectCommen === void 0 ? void 0 : _options$selectCommen.selectAnnotation.complete(selectedAnnotationId);
+            if (fg('cc_comments_track_view_inline_comment_action')) {
+              var _options$viewInlineCo;
+              // ...and start a new UFO press trace since the selected comment is changing
+              (_options$viewInlineCo = options.viewInlineCommentTraceUFOPress) === null || _options$viewInlineCo === void 0 ? void 0 : _options$viewInlineCo.call(options);
+            }
           }
-          if (fg('platform_editor_comments_api_manager_select')) {
+          if (annotationManager) {
             // In the Editor, Annotations can be selected in three ways:
             // 1. By clicking on the annotation in the editor
             // 2. By using the annotation manager to select the annotation
@@ -233,7 +239,7 @@ export const inlineCommentPlugin = options => {
               // Need to set a lock to avoid calling gate multiple times. The lock will be released
               // when the preemptive gate is complete.
               isPreemptiveGateActive = true;
-              annotationManager === null || annotationManager === void 0 ? void 0 : annotationManager.checkPreemptiveGate().then(canSelectAnnotation => {
+              annotationManager.checkPreemptiveGate().then(canSelectAnnotation => {
                 const {
                   isDrafting,
                   pendingSelectedAnnotations: latestPendingSelectedAnnotations,
@@ -249,8 +255,8 @@ export const inlineCommentPlugin = options => {
                   // Flush the pending selections into the selected annotations list.
                   flushPendingSelections(options.editorAnalyticsAPI)(true)(view.state, view.dispatch);
                   latestSelectedAnnotations === null || latestSelectedAnnotations === void 0 ? void 0 : latestSelectedAnnotations.filter(annotation => (latestPendingSelectedAnnotations === null || latestPendingSelectedAnnotations === void 0 ? void 0 : latestPendingSelectedAnnotations.findIndex(pendingAnnotation => pendingAnnotation.id === annotation.id)) === -1).forEach(annotation => {
-                    var _options$annotationMa, _getAnnotationInlineN;
-                    (_options$annotationMa = options.annotationManager) === null || _options$annotationMa === void 0 ? void 0 : _options$annotationMa.emit({
+                    var _getAnnotationInlineN;
+                    annotationManager.emit({
                       name: 'annotationSelectionChanged',
                       data: {
                         annotationId: annotation.id,
@@ -264,8 +270,8 @@ export const inlineCommentPlugin = options => {
                   latestPendingSelectedAnnotations === null || latestPendingSelectedAnnotations === void 0 ? void 0 : latestPendingSelectedAnnotations.forEach(({
                     id
                   }) => {
-                    var _options$annotationMa2, _getAnnotationInlineN2;
-                    (_options$annotationMa2 = options.annotationManager) === null || _options$annotationMa2 === void 0 ? void 0 : _options$annotationMa2.emit({
+                    var _getAnnotationInlineN2;
+                    annotationManager.emit({
                       name: 'annotationSelectionChanged',
                       data: {
                         annotationId: id,
@@ -303,7 +309,7 @@ export const inlineCommentPlugin = options => {
           if (updateSubscriber) {
             updateSubscriber.off('resolve', resolve).off('delete', resolve).off('unresolve', unResolve).off('create', unResolve).off('setvisibility', setVisibility).off('setselectedannotation', setSelectedAnnotationFn).off('sethoveredannotation', setHoveredAnnotationFn).off('removehoveredannotation', removeHoveredannotationFn).off('closeinlinecomment', closeInlineCommentFn);
           }
-          if (annotationManager && fg('platform_editor_comments_api_manager')) {
+          if (annotationManager) {
             annotationManager.unhook('allowAnnotation', allowAnnotationFn);
             annotationManager.unhook('startDraft', startDraftFn);
             annotationManager.unhook('clearDraft', clearDraftFn);
@@ -358,7 +364,7 @@ export const inlineCommentPlugin = options => {
           if (!isUnresolved) {
             return false;
           }
-          if (fg('platform_editor_comments_api_manager_select')) {
+          if (annotationManager) {
             var _pluginState$pendingS;
             // The manager disable setting the selected annotation on click because in the editor this is already
             // handled by the selection update handler. When the manager is enabled, and a selection changes it's pushed into

package/dist/es2019/pm-plugins/plugin-factory.js

@@ -1,7 +1,6 @@
 import { pluginFactory } from '@atlaskit/editor-common/utils';
 import { NodeSelection } from '@atlaskit/editor-prosemirror/state';
 import { DecorationSet } from '@atlaskit/editor-prosemirror/view';
-import { fg } from '@atlaskit/platform-feature-flags';
 import reducer from './reducer';
 import { decorationKey, findAnnotationsInSelection, inlineCommentPluginKey, isBlockNodeAnnotationsSelected, isSelectedAnnotationsChanged } from './utils';
 const handleDocChanged = (tr, prevPluginState) => {
@@ -111,7 +110,6 @@ const getSelectionChangeHandlerNew = reopenCommentView => (tr, pluginState) => {
 
   // NOTE: I've left this commented code here as a reference that the previous old code would reset the selected annotations
   // if the selection is empty. If this is no longer needed, we can remove this code.
-  // clean up with platform_editor_comments_api_manager_select
   // if (selectedAnnotations.length === 0) {
   // 	return {
   // 		...pluginState,
@@ -141,7 +139,11 @@ const getSelectionChangeHandlerNew = reopenCommentView => (tr, pluginState) => {
     selectAnnotationMethod: undefined
   };
 };
-const getSelectionChangedHandler = reopenCommentView => (tr, pluginState) => fg('platform_editor_comments_api_manager_select') ? getSelectionChangeHandlerNew(reopenCommentView)(tr, pluginState) : getSelectionChangeHandlerOld(reopenCommentView)(tr, pluginState);
+const getSelectionChangedHandler = reopenCommentView => (tr, pluginState) => pluginState.isAnnotationManagerEnabled ?
+// if platform_editor_comments_api_manager == true
+getSelectionChangeHandlerNew(reopenCommentView)(tr, pluginState) :
+// else if platform_editor_comments_api_manager == false
+getSelectionChangeHandlerOld(reopenCommentView)(tr, pluginState);
 export const {
   createPluginState,
   createCommand

package/dist/es2019/pm-plugins/reducer.js

@@ -35,7 +35,7 @@ export default ((pluginState, action) => {
         ...(fg('platform_editor_annotation_selected_annotation') && {
           selectedAnnotations: []
         }),
-        ...(fg('platform_editor_comments_api_manager_select') && {
+        ...(pluginState.isAnnotationManagerEnabled && {
           selectedAnnotations: []
         })
       };
@@ -50,7 +50,7 @@ export default ((pluginState, action) => {
         },
         isInlineCommentViewClosed: false,
         selectAnnotationMethod: undefined,
-        ...(fg('platform_editor_comments_api_manager_select') && {
+        ...(pluginState.isAnnotationManagerEnabled && {
           skipSelectionHandling: true
         })
       };

package/dist/es2019/pm-plugins/toolbar.js

@@ -131,7 +131,7 @@ export const buildToolbar = editorAnalyticsAPI => ({
           pageMode: 'edit'
         }
       });
-      if (annotationManager && fg('platform_editor_comments_api_manager')) {
+      if (annotationManager) {
         annotationManager.checkPreemptiveGate().then(canStartDraft => {
           if (canStartDraft) {
             createCommentExperience === null || createCommentExperience === void 0 ? void 0 : createCommentExperience.start({

package/dist/es2019/types/index.js

@@ -22,9 +22,4 @@ export const AnnotationTestIds = {
   floatingToolbarCreateButton: `${prefix}-toolbar-create-button`,
   componentSave: `${prefix}-dummy-save-button`,
   componentClose: `${prefix}-dummy-close-button`
-};
-
-/**
- * Alternative to SelectInlineCommentCompoundExperience, used for the annotation plugin options
- * in the confluence editor presets. See createFullPageEditorPreset.ts or annotationPluginOptions.ts for usage.
- */
+};

package/dist/esm/annotationPlugin.js

@@ -54,6 +54,7 @@ export var annotationPlugin = function annotationPlugin(_ref) {
               editorAnalyticsAPI: api === null || api === void 0 || (_api$analytics2 = api.analytics) === null || _api$analytics2 === void 0 ? void 0 : _api$analytics2.actions,
               featureFlagsPluginState: featureFlags,
               selectCommentExperience: annotationProviders.selectCommentExperience,
+              viewInlineCommentTraceUFOPress: annotationProviders.viewInlineCommentTraceUFOPress,
               annotationManager: annotationProviders.annotationManager,
               api: api
             });

package/dist/esm/pm-plugins/annotation-manager-hooks.js

@@ -1,7 +1,6 @@
 import { AnnotationTypes } from '@atlaskit/adf-schema';
 import { getAnnotationInlineNodeTypes, getRangeInlineNodeNames } from '@atlaskit/editor-common/utils';
 import { findDomRefAtPos } from '@atlaskit/editor-prosemirror/utils';
-import { fg } from '@atlaskit/platform-feature-flags';
 import { setInlineCommentDraftState, createAnnotation, setSelectedAnnotation, closeComponent, setHoveredAnnotation, removeInlineCommentFromDoc } from '../editor-commands';
 import { AnnotationSelectionType } from '../types';
 import { inlineCommentPluginKey, isSelectionValid } from './utils';
@@ -52,7 +51,7 @@ export var startDraft = function startDraft(editorView, options) {
         reason: ERROR_REASON_DRAFT_IN_PROGRESS
       };
     }
-    if (!!(selectedAnnotations !== null && selectedAnnotations !== void 0 && selectedAnnotations.length) && fg('platform_editor_comments_api_manager_select')) {
+    if (!!(selectedAnnotations !== null && selectedAnnotations !== void 0 && selectedAnnotations.length)) {
       // if there are selected annotations when starting a draft, we need to clear the selected annotations
       // before we start the draft.
       closeComponent()(editorView.state, editorView.dispatch);