@atlaskit/editor-core 238.0.1 → 238.0.3

package/CHANGELOG.md

@@ -1,5 +1,22 @@
 # @atlaskit/editor-core
 
+## 238.0.3
+
+### Patch Changes
+
+- [`fc2f6ea92bf86`](https://bitbucket.org/atlassian/atlassian-frontend-monorepo/commits/fc2f6ea92bf86) -
+  Behind `platform_editor_reduce_memory_leaks`: stop `editorStateNotificationPlugin` accumulating
+  every transaction in an array that is never read. The array kept each transaction, its documents
+  and any closures stored in transaction meta alive for the life of the editor, which in turn
+  retained deleted node views and their DOM.
+- Updated dependencies
+
+## 238.0.2
+
+### Patch Changes
+
+- Updated dependencies
+
 ## 238.0.1
 
 ### Patch Changes

package/dist/cjs/composable-editor/editor-internal.js

@@ -9,7 +9,7 @@ exports.EditorInternal = void 0;
 var _slicedToArray2 = _interopRequireDefault(require("@babel/runtime/helpers/slicedToArray"));
 var _defineProperty2 = _interopRequireDefault(require("@babel/runtime/helpers/defineProperty"));
 var _react = _interopRequireWildcard(require("react"));
-var _analytics = require("@atlaskit/editor-common/analytics");
+var _enums = require("@atlaskit/editor-common/analytics/types/enums");
 var _usePortalProvider5 = require("@atlaskit/editor-common/usePortalProvider");
 var _constants = require("@atlaskit/editor-shared-styles/constants");
 var _isExperimentEnabled = require("@atlaskit/platform-feature-experiments/is-experiment-enabled");
@@ -65,8 +65,8 @@ var EditorInternal = exports.EditorInternal = /*#__PURE__*/(0, _react.memo)(func
   });
   return /*#__PURE__*/_react.default.createElement(_react.Fragment, null, renderTrackingEnabled && /*#__PURE__*/_react.default.createElement(_RenderTracking.RenderTracking, {
     componentProps: props,
-    action: _analytics.ACTION.RE_RENDERED,
-    actionSubject: _analytics.ACTION_SUBJECT.EDITOR,
+    action: _enums.ACTION.RE_RENDERED,
+    actionSubject: _enums.ACTION_SUBJECT.EDITOR,
     handleAnalyticsEvent: handleAnalyticsEvent,
     propsToIgnore: propsToIgnore,
     useShallow: false

package/dist/cjs/create-editor/editorStateNotificationPlugin.js

@@ -6,6 +6,7 @@ Object.defineProperty(exports, "__esModule", {
 exports.createEditorStateNotificationPlugin = void 0;
 var _safePlugin = require("@atlaskit/editor-common/safe-plugin");
 var _state = require("@atlaskit/editor-prosemirror/state");
+var _isExperimentEnabled = require("@atlaskit/platform-feature-experiments/is-experiment-enabled");
 var key = new _state.PluginKey('editorStateNotificationPlugin');
 var createEditorStateNotificationPlugin = exports.createEditorStateNotificationPlugin = function createEditorStateNotificationPlugin(onEditorStateUpdated, onEditorViewStateUpdatedCallbacks) {
   var transactions = [];
@@ -18,7 +19,11 @@ var createEditorStateNotificationPlugin = exports.createEditorStateNotificationP
         };
       },
       apply: function apply(tr) {
-        transactions.push(tr);
+        if (!(0, _isExperimentEnabled.isExperimentEnabled)('platform_editor_reduce_memory_leaks')) {
+          // Dead accumulator: nothing reads it, so it pins every transaction for the
+          // editor's lifetime. Delete it when the experiment ships.
+          transactions.push(tr);
+        }
         return {
           latestTransaction: tr
         };

package/dist/cjs/ui/Appearance/Comment/Comment.js

@@ -16,11 +16,12 @@ var _classnames = _interopRequireDefault(require("classnames"));
 var _reactIntl = require("react-intl");
 var _buttonGroup = _interopRequireDefault(require("@atlaskit/button/button-group"));
 var _button = _interopRequireDefault(require("@atlaskit/button/default/button"));
-var _hooks = require("@atlaskit/editor-common/hooks");
 var _messages = _interopRequireDefault(require("@atlaskit/editor-common/messages"));
-var _ui = require("@atlaskit/editor-common/ui");
-var _uiMenu = require("@atlaskit/editor-common/ui-menu");
-var _editorSharedStyles = require("@atlaskit/editor-shared-styles");
+var _ToolbarArrowKeyNavigationProvider = require("@atlaskit/editor-common/ui-menu/ToolbarArrowKeyNavigationProvider");
+var _useSharedPluginState3 = require("@atlaskit/editor-common/useSharedPluginState");
+var _useSharedPluginStateWithSelector = require("@atlaskit/editor-common/useSharedPluginStateWithSelector");
+var _WidthProvider = require("@atlaskit/editor-common/WidthProvider");
+var _constants = require("@atlaskit/editor-shared-styles/constants");
 var _editorExperiment = require("@atlaskit/tmp-editor-statsig/editor-experiment");
 var _ClickAreaBlock = _interopRequireDefault(require("../../Addon/ClickAreaBlock"));
 var _contentComponentWrapper = require("../../Addon/ClickAreaBlock/contentComponentWrapper");
@@ -52,7 +53,7 @@ var CommentEditorWithIntl = exports.CommentEditorWithIntl = function CommentEdit
   // Get useStandardNodeWidth from block menu plugin shared state
   // Only access editorAPI when the experiment is enabled to avoid performance impact
   var useStandardNodeWidth = (0, _editorExperiment.editorExperiment)('platform_editor_controls', 'variant1') && ((_editorAPI$blockMenu$ = editorAPI === null || editorAPI === void 0 || (_editorAPI$blockMenu = editorAPI.blockMenu) === null || _editorAPI$blockMenu === void 0 || (_editorAPI$blockMenu = _editorAPI$blockMenu.sharedState) === null || _editorAPI$blockMenu === void 0 || (_editorAPI$blockMenu = _editorAPI$blockMenu.currentState()) === null || _editorAPI$blockMenu === void 0 ? void 0 : _editorAPI$blockMenu.useStandardNodeWidth) !== null && _editorAPI$blockMenu$ !== void 0 ? _editorAPI$blockMenu$ : false);
-  var _useSharedPluginState = (0, _hooks.useSharedPluginStateWithSelector)(editorAPI, ['maxContentSize', 'primaryToolbar', 'editorViewMode'], function (states) {
+  var _useSharedPluginState = (0, _useSharedPluginStateWithSelector.useSharedPluginStateWithSelector)(editorAPI, ['maxContentSize', 'primaryToolbar', 'editorViewMode'], function (states) {
       var _states$maxContentSiz, _states$primaryToolba, _states$editorViewMod;
       return {
         maxContentSizeReached: !!((_states$maxContentSiz = states.maxContentSizeState) !== null && _states$maxContentSiz !== void 0 && _states$maxContentSiz.maxContentSizeReached),
@@ -64,7 +65,7 @@ var CommentEditorWithIntl = exports.CommentEditorWithIntl = function CommentEdit
     primaryToolbarComponentsState = _useSharedPluginState.primaryToolbarComponentsState,
     maxContentSizeReached = _useSharedPluginState.maxContentSizeReached;
   var primaryToolbarState = (0, _getPrimaryToolbarComponents.getPrimaryToolbarComponents)(editorAPI, primaryToolbarComponentsState);
-  var _useSharedPluginState2 = (0, _hooks.useSharedPluginState)(editorAPI, ['media']),
+  var _useSharedPluginState2 = (0, _useSharedPluginState3.useSharedPluginState)(editorAPI, ['media']),
     mediaState = _useSharedPluginState2.mediaState;
   var intl = (0, _reactIntl.useIntl)();
   var editorDOMElement = props.editorDOMElement,
@@ -152,7 +153,7 @@ var CommentEditorWithIntl = exports.CommentEditorWithIntl = function CommentEdit
   }, customPrimaryToolbarComponents);
   return /*#__PURE__*/_react.default.createElement(_WithFlash.default, {
     animate: maxContentSizeReached
-  }, /*#__PURE__*/_react.default.createElement(_ui.WidthProvider, null, /*#__PURE__*/_react.default.createElement("div", {
+  }, /*#__PURE__*/_react.default.createElement(_WidthProvider.WidthProvider, null, /*#__PURE__*/_react.default.createElement("div", {
     // eslint-disable-next-line @atlaskit/ui-styling-standard/enforce-style-prop -- dynamic minHeight/maxHeight from props
     style: wrapperStyle
     // eslint-disable-next-line @atlaskit/ui-styling-standard/no-classname-prop -- Ignored via go/DSP-18766
@@ -164,7 +165,7 @@ var CommentEditorWithIntl = exports.CommentEditorWithIntl = function CommentEdit
     useStickyToolbar: useStickyToolbar,
     twoLineEditorToolbar: isTwoLineToolbarEnabled,
     isNewToolbarEnabled: isToolbarAIFCEnabled
-  }, isToolbarAIFCEnabled ? /*#__PURE__*/_react.default.createElement(_uiMenu.ToolbarArrowKeyNavigationProvider, {
+  }, isToolbarAIFCEnabled ? /*#__PURE__*/_react.default.createElement(_ToolbarArrowKeyNavigationProvider.ToolbarArrowKeyNavigationProvider, {
     editorView: editorView,
     childComponentSelector: "[data-testid='ak-editor-main-toolbar']",
     isShortcutToFocusToolbar: isShortcutToFocusToolbar,
@@ -180,7 +181,7 @@ var CommentEditorWithIntl = exports.CommentEditorWithIntl = function CommentEdit
     popupsBoundariesElement: popupsBoundariesElement,
     popupsScrollableElement: popupsScrollableElement,
     popupsMountPoint: popupsMountPoint
-  }), customPrimaryToolbarComponents ? customToolbarSlot : null) : /*#__PURE__*/_react.default.createElement(_uiMenu.ToolbarArrowKeyNavigationProvider, {
+  }), customPrimaryToolbarComponents ? customToolbarSlot : null) : /*#__PURE__*/_react.default.createElement(_ToolbarArrowKeyNavigationProvider.ToolbarArrowKeyNavigationProvider, {
     editorView: editorView,
     childComponentSelector: "[data-testid='ak-editor-main-toolbar']",
     isShortcutToFocusToolbar: isShortcutToFocusToolbar,
@@ -214,7 +215,7 @@ var CommentEditorWithIntl = exports.CommentEditorWithIntl = function CommentEdit
   }), customToolbarSlot)), /*#__PURE__*/_react.default.createElement(_ClickAreaBlock.default, {
     editorView: editorView,
     editorDisabled: disabled
-  }, /*#__PURE__*/_react.default.createElement(_ui.WidthConsumer, null, function (_ref) {
+  }, /*#__PURE__*/_react.default.createElement(_WidthProvider.WidthConsumer, null, function (_ref) {
     var width = _ref.width;
     return /*#__PURE__*/_react.default.createElement(_EditorContentContainer.default, {
       ref: containerElement,
@@ -222,7 +223,7 @@ var CommentEditorWithIntl = exports.CommentEditorWithIntl = function CommentEdit
       // eslint-disable-next-line @atlaskit/ui-styling-standard/no-classname-prop -- Ignored via go/DSP-18766
       ,
       className: (0, _runtime.ax)([maxHeight && commentEditorCompiledStyles.contentAreaMaxHeight, (0, _classnames.default)('ak-editor-content-area', {
-        'less-margin': width < _editorSharedStyles.akEditorMobileBreakoutPoint
+        'less-margin': width < _constants.akEditorMobileBreakoutPoint
       })]),
       featureFlags: featureFlags,
       viewMode: editorViewMode,

package/dist/cjs/ui/Appearance/FullPage/FullPageContentArea.js

@@ -12,9 +12,9 @@ var _runtime = require("@compiled/react/runtime");
 var _react = _interopRequireWildcard(require("react"));
 var _classnames = _interopRequireDefault(require("classnames"));
 var _reactIntl = require("react-intl");
-var _hooks = require("@atlaskit/editor-common/hooks");
-var _messages = require("@atlaskit/editor-common/messages");
-var _editorSharedStyles = require("@atlaskit/editor-shared-styles");
+var _fullPage = require("@atlaskit/editor-common/messages/full-page");
+var _useSharedPluginStateWithSelector = require("@atlaskit/editor-common/useSharedPluginStateWithSelector");
+var _constants = require("@atlaskit/editor-shared-styles/constants");
 var _editorExperiment = require("@atlaskit/tmp-editor-statsig/editor-experiment");
 var _expValEqualsNoExposure = require("@atlaskit/tmp-editor-statsig/exp-val-equals-no-exposure");
 var _ClickAreaBlock = require("../../Addon/ClickAreaBlock");
@@ -35,7 +35,7 @@ var akLayoutGutterOffset = 12;
 var SWOOP_ANIMATION = "0.5s ".concat(akEditorSwoopCubicBezier);
 var AK_NESTED_DND_GUTTER_OFFSET = 8;
 var getTotalPadding = function getTotalPadding() {
-  return (0, _editorSharedStyles.akEditorGutterPaddingDynamic)() * 2;
+  return (0, _constants.akEditorGutterPaddingDynamic)() * 2;
 };
 
 // Isolates the scroll container's layout and size from the rest of the page.
@@ -74,7 +74,7 @@ var Content = /*#__PURE__*/_react.default.forwardRef(function (props, ref) {
   var contentAreaRef = (0, _react.useRef)(null);
   var containerRef = (0, _react.useRef)(null);
   var allowScrollGutter = (_props$editorAPI = props.editorAPI) === null || _props$editorAPI === void 0 || (_props$editorAPI = _props$editorAPI.base) === null || _props$editorAPI === void 0 || (_props$editorAPI = _props$editorAPI.sharedState.currentState()) === null || _props$editorAPI === void 0 ? void 0 : _props$editorAPI.allowScrollGutter;
-  var contentAreaMaxWidth = getTotalPadding() + (!fullWidthMode ? maxWidthMode ? akEditorUltraWideLayoutWidth : _editorSharedStyles.akEditorDefaultLayoutWidth : akEditorFullWidthLayoutWidth);
+  var contentAreaMaxWidth = getTotalPadding() + (!fullWidthMode ? maxWidthMode ? akEditorUltraWideLayoutWidth : _constants.akEditorDefaultLayoutWidth : akEditorFullWidthLayoutWidth);
 
   // Get useStandardNodeWidth from block menu plugin shared state
   // Only access editorAPI when the experiment is enabled to avoid performance impact
@@ -92,11 +92,11 @@ var Content = /*#__PURE__*/_react.default.forwardRef(function (props, ref) {
       }
     };
   }, []);
-  var markdownPluginCurrentView = (0, _hooks.useSharedPluginStateWithSelector)(props.editorAPI, ['markdownMode'], function (states) {
+  var markdownPluginCurrentView = (0, _useSharedPluginStateWithSelector.useSharedPluginStateWithSelector)(props.editorAPI, ['markdownMode'], function (states) {
     var _states$markdownModeS;
     return (_states$markdownModeS = states.markdownModeState) === null || _states$markdownModeS === void 0 ? void 0 : _states$markdownModeS.view;
   });
-  var markdownPluginCurrentIsMarkdownMode = (0, _hooks.useSharedPluginStateWithSelector)(props.editorAPI, ['markdownMode'], function (states) {
+  var markdownPluginCurrentIsMarkdownMode = (0, _useSharedPluginStateWithSelector.useSharedPluginStateWithSelector)(props.editorAPI, ['markdownMode'], function (states) {
     var _states$markdownModeS2;
     return (_states$markdownModeS2 = states.markdownModeState) === null || _states$markdownModeS2 === void 0 ? void 0 : _states$markdownModeS2.isMarkdownMode;
   });
@@ -130,7 +130,7 @@ var Content = /*#__PURE__*/_react.default.forwardRef(function (props, ref) {
     compiledStyles.editorContentAreaContainerStyleExcludeCodeBlockNew, compiledStyles.editorContentAreaContainerNestedDndStyle, "ak-editor-content-area-region"]),
     "data-editor-editable-content": true,
     role: "region",
-    "aria-label": props.intl.formatMessage(_messages.fullPageMessages.editableContentLabel),
+    "aria-label": props.intl.formatMessage(_fullPage.messages.editableContentLabel),
     ref: contentAreaRef,
     "data-vc": "editor-content-area-region"
   }, /*#__PURE__*/_react.default.createElement("div", {

package/dist/cjs/utils/performance/components/RenderTracking.js

@@ -7,7 +7,7 @@ Object.defineProperty(exports, "__esModule", {
 exports.RenderTracking = RenderTracking;
 var _react = require("react");
 var _debounce = _interopRequireDefault(require("lodash/debounce"));
-var _analytics = require("@atlaskit/editor-common/analytics");
+var _enums = require("@atlaskit/editor-common/analytics/types/enums");
 var _useComponentRenderTracking = require("@atlaskit/editor-common/use-component-render-tracking");
 function RenderTracking(props) {
   var debouncedHandleAnalyticsEvent = (0, _react.useMemo)(function () {
@@ -28,7 +28,7 @@ function RenderTracking(props) {
             count: renderCount,
             propsDifference: propsDifference
           },
-          eventType: _analytics.EVENT_TYPE.OPERATIONAL
+          eventType: _enums.EVENT_TYPE.OPERATIONAL
         }
       });
     },

package/dist/cjs/version-wrapper.js

@@ -6,4 +6,4 @@ Object.defineProperty(exports, "__esModule", {
 exports.version = exports.name = void 0;
 var name = exports.name = "@atlaskit/editor-core";
 // eslint-disable-next-line @atlaskit/volt-strict-mode/no-multiple-exports
-var version = exports.version = "238.0.0";
+var version = exports.version = "238.0.2";

package/dist/es2019/composable-editor/editor-internal.js

@@ -1,5 +1,5 @@
 import React, { Fragment, memo } from 'react';
-import { ACTION, ACTION_SUBJECT } from '@atlaskit/editor-common/analytics';
+import { ACTION, ACTION_SUBJECT } from '@atlaskit/editor-common/analytics/types/enums';
 import { usePortalProvider } from '@atlaskit/editor-common/usePortalProvider';
 import { editorFontSize } from '@atlaskit/editor-shared-styles/constants';
 import { isExperimentEnabled } from '@atlaskit/platform-feature-experiments/is-experiment-enabled';

package/dist/es2019/create-editor/editorStateNotificationPlugin.js

@@ -1,5 +1,6 @@
 import { SafePlugin } from '@atlaskit/editor-common/safe-plugin';
 import { PluginKey } from '@atlaskit/editor-prosemirror/state';
+import { isExperimentEnabled } from '@atlaskit/platform-feature-experiments/is-experiment-enabled';
 const key = new PluginKey('editorStateNotificationPlugin');
 export const createEditorStateNotificationPlugin = (onEditorStateUpdated, onEditorViewStateUpdatedCallbacks) => {
   const transactions = [];
@@ -12,7 +13,11 @@ export const createEditorStateNotificationPlugin = (onEditorStateUpdated, onEdit
         };
       },
       apply(tr) {
-        transactions.push(tr);
+        if (!isExperimentEnabled('platform_editor_reduce_memory_leaks')) {
+          // Dead accumulator: nothing reads it, so it pins every transaction for the
+          // editor's lifetime. Delete it when the experiment ships.
+          transactions.push(tr);
+        }
         return {
           latestTransaction: tr
         };

package/dist/es2019/ui/Appearance/Comment/Comment.js

@@ -6,11 +6,12 @@ import classnames from 'classnames';
 import { useIntl } from 'react-intl';
 import ButtonGroup from '@atlaskit/button/button-group';
 import Button from '@atlaskit/button/default/button';
-import { useSharedPluginState, useSharedPluginStateWithSelector } from '@atlaskit/editor-common/hooks';
 import messages from '@atlaskit/editor-common/messages';
-import { WidthConsumer, WidthProvider } from '@atlaskit/editor-common/ui';
-import { ToolbarArrowKeyNavigationProvider } from '@atlaskit/editor-common/ui-menu';
-import { akEditorMobileBreakoutPoint } from '@atlaskit/editor-shared-styles';
+import { ToolbarArrowKeyNavigationProvider } from '@atlaskit/editor-common/ui-menu/ToolbarArrowKeyNavigationProvider';
+import { useSharedPluginState } from '@atlaskit/editor-common/useSharedPluginState';
+import { useSharedPluginStateWithSelector } from '@atlaskit/editor-common/useSharedPluginStateWithSelector';
+import { WidthConsumer, WidthProvider } from '@atlaskit/editor-common/WidthProvider';
+import { akEditorMobileBreakoutPoint } from '@atlaskit/editor-shared-styles/constants';
 import { editorExperiment } from '@atlaskit/tmp-editor-statsig/editor-experiment';
 // Ignored via go/ees005
 // eslint-disable-next-line import/no-named-as-default

package/dist/es2019/ui/Appearance/FullPage/FullPageContentArea.js

@@ -4,9 +4,9 @@ import { ax, ix } from "@compiled/react/runtime";
 import React, { useImperativeHandle, useRef } from 'react';
 import classnames from 'classnames';
 import { injectIntl } from 'react-intl';
-import { useSharedPluginStateWithSelector } from '@atlaskit/editor-common/hooks';
-import { fullPageMessages as messages } from '@atlaskit/editor-common/messages';
-import { akEditorGutterPaddingDynamic, akEditorDefaultLayoutWidth } from '@atlaskit/editor-shared-styles';
+import { messages } from '@atlaskit/editor-common/messages/full-page';
+import { useSharedPluginStateWithSelector } from '@atlaskit/editor-common/useSharedPluginStateWithSelector';
+import { akEditorGutterPaddingDynamic, akEditorDefaultLayoutWidth } from '@atlaskit/editor-shared-styles/constants';
 import { editorExperiment } from '@atlaskit/tmp-editor-statsig/editor-experiment';
 import { expValEqualsNoExposure } from '@atlaskit/tmp-editor-statsig/exp-val-equals-no-exposure';
 

package/dist/es2019/utils/performance/components/RenderTracking.js

@@ -1,6 +1,6 @@
 import { useMemo } from 'react';
 import debounce from 'lodash/debounce';
-import { EVENT_TYPE } from '@atlaskit/editor-common/analytics';
+import { EVENT_TYPE } from '@atlaskit/editor-common/analytics/types/enums';
 import { useComponentRenderTracking } from '@atlaskit/editor-common/use-component-render-tracking';
 export function RenderTracking(props) {
   const debouncedHandleAnalyticsEvent = useMemo(() => debounce(props.handleAnalyticsEvent, 500), [props.handleAnalyticsEvent]);

package/dist/es2019/version-wrapper.js

@@ -1,3 +1,3 @@
 export const name = "@atlaskit/editor-core";
 // eslint-disable-next-line @atlaskit/volt-strict-mode/no-multiple-exports
-export const version = "238.0.0";
+export const version = "238.0.2";

package/dist/esm/composable-editor/editor-internal.js

@@ -3,7 +3,7 @@ import _defineProperty from "@babel/runtime/helpers/defineProperty";
 function ownKeys(e, r) { var t = Object.keys(e); if (Object.getOwnPropertySymbols) { var o = Object.getOwnPropertySymbols(e); r && (o = o.filter(function (r) { return Object.getOwnPropertyDescriptor(e, r).enumerable; })), t.push.apply(t, o); } return t; }
 function _objectSpread(e) { for (var r = 1; r < arguments.length; r++) { var t = null != arguments[r] ? arguments[r] : {}; r % 2 ? ownKeys(Object(t), !0).forEach(function (r) { _defineProperty(e, r, t[r]); }) : Object.getOwnPropertyDescriptors ? Object.defineProperties(e, Object.getOwnPropertyDescriptors(t)) : ownKeys(Object(t)).forEach(function (r) { Object.defineProperty(e, r, Object.getOwnPropertyDescriptor(t, r)); }); } return e; }
 import React, { Fragment, memo } from 'react';
-import { ACTION, ACTION_SUBJECT } from '@atlaskit/editor-common/analytics';
+import { ACTION, ACTION_SUBJECT } from '@atlaskit/editor-common/analytics/types/enums';
 import { usePortalProvider } from '@atlaskit/editor-common/usePortalProvider';
 import { editorFontSize } from '@atlaskit/editor-shared-styles/constants';
 import { isExperimentEnabled } from '@atlaskit/platform-feature-experiments/is-experiment-enabled';

package/dist/esm/create-editor/editorStateNotificationPlugin.js

@@ -1,5 +1,6 @@
 import { SafePlugin } from '@atlaskit/editor-common/safe-plugin';
 import { PluginKey } from '@atlaskit/editor-prosemirror/state';
+import { isExperimentEnabled } from '@atlaskit/platform-feature-experiments/is-experiment-enabled';
 var key = new PluginKey('editorStateNotificationPlugin');
 export var createEditorStateNotificationPlugin = function createEditorStateNotificationPlugin(onEditorStateUpdated, onEditorViewStateUpdatedCallbacks) {
   var transactions = [];
@@ -12,7 +13,11 @@ export var createEditorStateNotificationPlugin = function createEditorStateNotif
         };
       },
       apply: function apply(tr) {
-        transactions.push(tr);
+        if (!isExperimentEnabled('platform_editor_reduce_memory_leaks')) {
+          // Dead accumulator: nothing reads it, so it pins every transaction for the
+          // editor's lifetime. Delete it when the experiment ships.
+          transactions.push(tr);
+        }
         return {
           latestTransaction: tr
         };

package/dist/esm/ui/Appearance/Comment/Comment.js

@@ -10,11 +10,12 @@ import classnames from 'classnames';
 import { useIntl } from 'react-intl';
 import ButtonGroup from '@atlaskit/button/button-group';
 import Button from '@atlaskit/button/default/button';
-import { useSharedPluginState, useSharedPluginStateWithSelector } from '@atlaskit/editor-common/hooks';
 import messages from '@atlaskit/editor-common/messages';
-import { WidthConsumer, WidthProvider } from '@atlaskit/editor-common/ui';
-import { ToolbarArrowKeyNavigationProvider } from '@atlaskit/editor-common/ui-menu';
-import { akEditorMobileBreakoutPoint } from '@atlaskit/editor-shared-styles';
+import { ToolbarArrowKeyNavigationProvider } from '@atlaskit/editor-common/ui-menu/ToolbarArrowKeyNavigationProvider';
+import { useSharedPluginState } from '@atlaskit/editor-common/useSharedPluginState';
+import { useSharedPluginStateWithSelector } from '@atlaskit/editor-common/useSharedPluginStateWithSelector';
+import { WidthConsumer, WidthProvider } from '@atlaskit/editor-common/WidthProvider';
+import { akEditorMobileBreakoutPoint } from '@atlaskit/editor-shared-styles/constants';
 import { editorExperiment } from '@atlaskit/tmp-editor-statsig/editor-experiment';
 // Ignored via go/ees005
 // eslint-disable-next-line import/no-named-as-default

package/dist/esm/ui/Appearance/FullPage/FullPageContentArea.js

@@ -4,9 +4,9 @@ import { ax, ix } from "@compiled/react/runtime";
 import React, { useImperativeHandle, useRef } from 'react';
 import classnames from 'classnames';
 import { injectIntl } from 'react-intl';
-import { useSharedPluginStateWithSelector } from '@atlaskit/editor-common/hooks';
-import { fullPageMessages as messages } from '@atlaskit/editor-common/messages';
-import { akEditorGutterPaddingDynamic, akEditorDefaultLayoutWidth } from '@atlaskit/editor-shared-styles';
+import { messages } from '@atlaskit/editor-common/messages/full-page';
+import { useSharedPluginStateWithSelector } from '@atlaskit/editor-common/useSharedPluginStateWithSelector';
+import { akEditorGutterPaddingDynamic, akEditorDefaultLayoutWidth } from '@atlaskit/editor-shared-styles/constants';
 import { editorExperiment } from '@atlaskit/tmp-editor-statsig/editor-experiment';
 import { expValEqualsNoExposure } from '@atlaskit/tmp-editor-statsig/exp-val-equals-no-exposure';
 

package/dist/esm/utils/performance/components/RenderTracking.js

@@ -1,6 +1,6 @@
 import { useMemo } from 'react';
 import debounce from 'lodash/debounce';
-import { EVENT_TYPE } from '@atlaskit/editor-common/analytics';
+import { EVENT_TYPE } from '@atlaskit/editor-common/analytics/types/enums';
 import { useComponentRenderTracking } from '@atlaskit/editor-common/use-component-render-tracking';
 export function RenderTracking(props) {
   var debouncedHandleAnalyticsEvent = useMemo(function () {

package/dist/esm/version-wrapper.js

@@ -1,3 +1,3 @@
 export var name = "@atlaskit/editor-core";
 // eslint-disable-next-line @atlaskit/volt-strict-mode/no-multiple-exports
-export var version = "238.0.0";
+export var version = "238.0.2";

package/dist/types/composable-editor/editor-internal.d.ts

@@ -1,7 +1,7 @@
 import React from 'react';
 import type { MemoExoticComponent } from 'react';
 import type { CreateUIAnalyticsEvent } from '@atlaskit/analytics-next/types';
-import type { FireAnalyticsCallback } from '@atlaskit/editor-common/analytics';
+import type { FireAnalyticsCallback } from '@atlaskit/editor-common/analytics/types/events';
 import type { EventDispatcher } from '@atlaskit/editor-common/event-dispatcher';
 import type { AllEditorPresetPluginTypes, EditorPresetBuilder } from '@atlaskit/editor-common/preset/builder';
 import type ProviderFactory from '@atlaskit/editor-common/provider-factory/provider-factory';

package/dist/types/composable-editor/hooks/useProviders.d.ts

@@ -10,7 +10,7 @@ import type { EmojiPlugin } from '@atlaskit/editor-plugins/emoji';
 import type { MediaPlugin } from '@atlaskit/editor-plugins/media';
 import type { MentionsPlugin } from '@atlaskit/editor-plugins/mentions';
 import type { TasksAndDecisionsPlugin } from '@atlaskit/editor-plugins/tasks-and-decisions';
-import type { EmojiProvider } from '@atlaskit/emoji';
+import type { EmojiProvider } from '@atlaskit/emoji/types';
 import type { MentionProvider } from '@atlaskit/mention/types';
 import type { TaskDecisionProvider } from '@atlaskit/task-decision/types';
 interface UseProvidersProps {

package/dist/types/types/editor-props.d.ts

@@ -38,7 +38,7 @@ import type { Node, Schema } from '@atlaskit/editor-prosemirror/model';
 import type { EditorView } from '@atlaskit/editor-prosemirror/view';
 import type { SyncedBlockProvider } from '@atlaskit/editor-synced-block-provider/syncBlockProvider';
 import type { MentionProvider } from '@atlaskit/mention/types';
-import type { TaskDecisionProvider } from '@atlaskit/task-decision';
+import type { TaskDecisionProvider } from '@atlaskit/task-decision/types';
 import type EditorActions from '../actions';
 import type { EditorOnChangeHandler } from './editor-onchange';
 import type { ExtensionConfig } from './extension-config';

package/dist/types/ui/Appearance/Comment/Comment.d.ts

@@ -3,8 +3,8 @@
  * @jsx jsx
  */
 import React from 'react';
-import type { OptionalPlugin } from '@atlaskit/editor-common/types';
-import type { BlockMenuPlugin } from '@atlaskit/editor-plugin-block-menu';
+import type { OptionalPlugin } from '@atlaskit/editor-common/types/next-editor-plugin';
+import type { BlockMenuPlugin } from '@atlaskit/editor-plugin-block-menu/blockMenuPluginType';
 import type { MaxContentSizePlugin } from '@atlaskit/editor-plugins/max-content-size';
 import type { MediaPlugin } from '@atlaskit/editor-plugins/media';
 import type { PrimaryToolbarPlugin } from '@atlaskit/editor-plugins/primary-toolbar';

package/dist/types/ui/Appearance/FullPage/FullPageContentArea.d.ts

@@ -5,10 +5,13 @@
 import type { ReactElement } from 'react';
 import React from 'react';
 import type { WithIntlProps, WrappedComponentProps } from 'react-intl';
-import type { DispatchAnalyticsEvent } from '@atlaskit/editor-common/analytics';
+import type { DispatchAnalyticsEvent } from '@atlaskit/editor-common/analytics/types/dispatch-analytics-event';
 import type { EventDispatcher } from '@atlaskit/editor-common/event-dispatcher';
-import type { ProviderFactory } from '@atlaskit/editor-common/provider-factory';
-import type { EditorAppearance, EditorContentMode, FeatureFlags, OptionalPlugin, PublicPluginAPI, ReactHookFactory, UIComponentFactory } from '@atlaskit/editor-common/types';
+import type ProviderFactory from '@atlaskit/editor-common/provider-factory/provider-factory';
+import type { EditorAppearance, EditorContentMode } from '@atlaskit/editor-common/types/editor-appearance';
+import type { FeatureFlags } from '@atlaskit/editor-common/types/feature-flags';
+import type { OptionalPlugin, PublicPluginAPI } from '@atlaskit/editor-common/types/next-editor-plugin';
+import type { ReactHookFactory, UIComponentFactory } from '@atlaskit/editor-common/types/ui-components';
 import type { BasePlugin } from '@atlaskit/editor-plugins/base';
 import type { BlockMenuPlugin } from '@atlaskit/editor-plugins/block-menu';
 import type { ContextPanelPlugin } from '@atlaskit/editor-plugins/context-panel';

package/dist/types/ui/quick-insert/QuickInsertSkillMenuItem.d.ts

@@ -1,7 +1,7 @@
 import React from 'react';
 import type { CreateUIAnalyticsEvent } from '@atlaskit/analytics-next/types';
-import type { MenuItem } from '@atlaskit/editor-common/extensions';
-import type { PublicPluginAPI } from '@atlaskit/editor-common/types';
+import type { MenuItem } from '@atlaskit/editor-common/extensions/types/utils';
+import type { PublicPluginAPI } from '@atlaskit/editor-common/types/next-editor-plugin';
 import type { ExtensionPlugin } from '@atlaskit/editor-plugins/extension';
 import type EditorActions from '../../actions';
 export declare const QuickInsertSkillMenuItem: ({ apiRef, createAnalyticsEvent, editorActions, item, onInsert, }: {

package/dist/types/utils/performance/components/RenderTracking.d.ts

@@ -1,4 +1,5 @@
-import type { ACTION, ACTION_SUBJECT, FireAnalyticsCallback } from '@atlaskit/editor-common/analytics';
+import type { ACTION, ACTION_SUBJECT } from '@atlaskit/editor-common/analytics/types/enums';
+import type { FireAnalyticsCallback } from '@atlaskit/editor-common/analytics/types/events';
 type RenderActions = ACTION.RE_RENDERED;
 type RenderActionSubjects = ACTION_SUBJECT.EDITOR | ACTION_SUBJECT.REACT_EDITOR_VIEW;
 export type RenderTrackingProps<ComponentProps> = {

package/package.json

@@ -1,6 +1,6 @@
 {
 	"name": "@atlaskit/editor-core",
-	"version": "238.0.1",
+	"version": "238.0.3",
 	"description": "A package contains Atlassian editor core functionality",
 	"publishConfig": {
 		"registry": "https://registry.npmjs.org/"
@@ -72,12 +72,12 @@
 		"@atlaskit/platform-feature-experiments": "^0.3.0",
 		"@atlaskit/platform-feature-flags": "^2.2.0",
 		"@atlaskit/platform-feature-flags-react": "^1.2.0",
-		"@atlaskit/popup": "^9.0.0",
+		"@atlaskit/popup": "^10.0.0",
 		"@atlaskit/primitives": "^22.6.0",
 		"@atlaskit/react-compiler-gating": "^0.2.0",
 		"@atlaskit/react-ufo": "^8.1.0",
 		"@atlaskit/task-decision": "^21.12.0",
-		"@atlaskit/tmp-editor-statsig": "^240.0.0",
+		"@atlaskit/tmp-editor-statsig": "^241.0.0",
 		"@atlaskit/tokens": "^20.6.0",
 		"@atlaskit/tooltip": "^24.4.0",
 		"@atlaskit/width-detector": "^7.2.0",
@@ -106,6 +106,7 @@
 	"devDependencies": {
 		"@af/editor-examples-helpers": "workspace:^",
 		"@af/editor-libra": "workspace:^",
+		"@af/integration-testing": "workspace:^",
 		"@af/suppress-react-warnings": "workspace:^",
 		"@af/visual-regression": "workspace:^",
 		"@atlaskit/adf-utils": "^20.9.0",
@@ -116,7 +117,7 @@
 		"@atlaskit/docs": "^12.3.0",
 		"@atlaskit/drawer": "^14.3.0",
 		"@atlaskit/editor-plugin-alignment": "^29.0.0",
-		"@atlaskit/editor-plugin-annotation": "^28.0.0",
+		"@atlaskit/editor-plugin-annotation": "^28.1.0",
 		"@atlaskit/editor-plugin-base": "^29.0.0",
 		"@atlaskit/editor-plugin-card": "^34.0.0",
 		"@atlaskit/editor-plugin-code-block-advanced": "^28.0.0",
@@ -127,11 +128,13 @@
 		"@atlaskit/editor-plugin-grid": "^28.0.0",
 		"@atlaskit/editor-plugin-guideline": "^28.0.0",
 		"@atlaskit/editor-plugin-highlight": "^28.0.0",
+		"@atlaskit/editor-plugin-hyperlink": "^30.0.0",
 		"@atlaskit/editor-plugin-insert-block": "^29.0.0",
 		"@atlaskit/editor-plugin-layout": "^29.0.0",
 		"@atlaskit/editor-plugin-limited-mode": "^25.0.0",
 		"@atlaskit/editor-plugin-list": "^30.0.0",
 		"@atlaskit/editor-plugin-media": "^30.0.0",
+		"@atlaskit/editor-plugin-media-insert": "^46.0.0",
 		"@atlaskit/editor-plugin-paste": "^29.0.0",
 		"@atlaskit/editor-plugin-selection-marker": "^28.0.0",
 		"@atlaskit/editor-plugin-show-diff": "^26.0.0",
@@ -139,10 +142,13 @@
 		"@atlaskit/editor-plugin-table": "^40.0.0",
 		"@atlaskit/editor-plugin-tasks-and-decisions": "^31.0.0",
 		"@atlaskit/editor-plugin-text-color": "^28.0.0",
+		"@atlaskit/editor-plugin-text-formatting": "^28.0.0",
+		"@atlaskit/editor-plugin-toolbar": "^25.0.0",
 		"@atlaskit/editor-plugin-toolbar-lists-indentation": "^29.0.0",
 		"@atlaskit/editor-plugin-track-changes": "^27.0.0",
 		"@atlaskit/editor-synced-block-provider": "^24.0.0",
 		"@atlaskit/editor-synced-block-renderer": "^26.0.0",
+		"@atlaskit/editor-tables": "^3.2.0",
 		"@atlaskit/editor-test-helpers": "workspace:^",
 		"@atlaskit/form": "^18.2.0",
 		"@atlaskit/link-provider": "^6.0.0",
@@ -153,11 +159,11 @@
 		"@atlaskit/media-picker": "^73.2.0",
 		"@atlaskit/media-test-helpers": "^43.0.0",
 		"@atlaskit/media-ui": "^31.3.0",
-		"@atlaskit/modal-dialog": "^17.0.0",
+		"@atlaskit/modal-dialog": "^17.1.0",
 		"@atlaskit/navigation-system": "^11.3.0",
 		"@atlaskit/popper": "^9.4.0",
 		"@atlaskit/portal": "^7.0.0",
-		"@atlaskit/profilecard": "^27.1.0",
+		"@atlaskit/profilecard": "^27.2.0",
 		"@atlaskit/radio": "^10.2.0",
 		"@atlaskit/renderer": "^151.0.0",
 		"@atlaskit/section-message": "^10.2.0",
@@ -172,12 +178,13 @@
 		"@atlassian/adf-schema-json": "^1.35.0",
 		"@atlassian/editor-rovo-bridge": "^27.0.0",
 		"@atlassian/experiment-test-utils": "^0.2.0",
+		"@atlassian/feature-flags-storybook-utils": "^0.5.0",
 		"@atlassian/feature-flags-test-utils": "^1.3.0",
 		"@atlassian/search-client": "^3.9.0",
 		"@atlassian/search-provider": "^29.0.0",
 		"@atlassian/structured-docs-types": "workspace:^",
 		"@atlassian/testing-library": "^0.12.0",
-		"@atlassian/user-profile-card": "^1.45.0",
+		"@atlassian/user-profile-card": "^1.46.0",
 		"@emotion/jest": "^11.8.0",
 		"@testing-library/react": "^16.3.0",
 		"@types/diff": "^5.0.2",