@atlaskit/editor-core 221.4.1 → 221.5.0

This diff represents the content of publicly available package versions that have been released to one of the supported registries. The information contained in this diff is provided for informational purposes only and reflects changes between package versions as they appear in their respective public registries.
package/CHANGELOG.md CHANGED
@@ -1,5 +1,29 @@
1
1
  # @atlaskit/editor-core
2
2
 
3
+ ## 221.5.0
4
+
5
+ ### Minor Changes
6
+
7
+ - [`cd097a2111788`](https://bitbucket.org/atlassian/atlassian-frontend-monorepo/commits/cd097a2111788) -
8
+ Republish packages depending on `@atlaskit/react-compiler-gating` so their published dependency
9
+ reference is updated to the renamed `@atlaskit/react-compiler-gating` scope.
10
+
11
+ The earlier rename of `@atlassian/react-compiler-gating` to `@atlaskit/react-compiler-gating` only
12
+ bumped the renamed package itself, so dependent packages were never republished and their
13
+ published versions still referenced the old `@atlassian/react-compiler-gating` name, which is not
14
+ available in the public npm registry. This minor bump republishes all affected packages with the
15
+ corrected dependency.
16
+
17
+ ### Patch Changes
18
+
19
+ - [`6e885938419af`](https://bitbucket.org/atlassian/atlassian-frontend-monorepo/commits/6e885938419af) -
20
+ Fix scrollbar behaviour in the markdown source view (MVP layout): CodeMirror now owns its own
21
+ scrolling so its native horizontal and vertical scrollbars sit at the viewport edges with the
22
+ status-bar footer in-flow below them, and the editor's scroll container no longer renders a
23
+ redundant second vertical scrollbar. The top content inset is applied inside the scroller so it no
24
+ longer leaves a gap above the vertical scrollbar.
25
+ - Updated dependencies
26
+
3
27
  ## 221.4.1
4
28
 
5
29
  ### Patch Changes
@@ -235,7 +235,17 @@ var contentAreaHeightNoToolbar = (0, _react2.css)({
235
235
  // the WYSIWYG "preview" view) we tint the whole editor container with the
236
236
  // sunken surface so the source editor reads as a distinct, inset surface.
237
237
  var markdownModeContainerBackgroundStyle = (0, _react2.css)({
238
- backgroundColor: "var(--ds-surface-sunken, #F8F8F8)"
238
+ backgroundColor: "var(--ds-surface-sunken, #F8F8F8)",
239
+ // In the markdown MVP layout the source view (CodeMirror) is bounded to the
240
+ // viewport and owns its own scrolling, so the editor's scroll container must
241
+ // not also own vertical scrolling — its always-on `overflow-y: scroll` track
242
+ // would otherwise render a second, redundant scrollbar alongside CodeMirror's.
243
+ // This style is only applied in markdown source mode, so WYSIWYG / preview
244
+ // scrolling is unaffected.
245
+ // eslint-disable-next-line @atlaskit/ui-styling-standard/no-nested-selectors -- scoped override of the descendant scroll container
246
+ '& [data-editor-scroll-container="true"]': {
247
+ overflowY: 'hidden'
248
+ }
239
249
  });
240
250
  var markdownModeContentAreaStyle = (0, _react2.css)({
241
251
  boxSizing: 'border-box',
@@ -244,7 +254,12 @@ var markdownModeContentAreaStyle = (0, _react2.css)({
244
254
  maxWidth: 'none',
245
255
  minWidth: 0,
246
256
  paddingBottom: 0,
247
- paddingTop: "var(--ds-space-500, 40px)",
257
+ // No top padding here: it would inset the whole source view (including
258
+ // CodeMirror's `.cm-scroller`), leaving a gap above the editor's vertical
259
+ // scrollbar. The top inset is applied inside the scroller instead (see the
260
+ // `.cm-scroller` `paddingTop` in MarkdownSourceView) so the scrollbar still
261
+ // spans the full height.
262
+ paddingTop: 0,
248
263
  width: '100%',
249
264
  // The markdown source view is rendered through PluginSlot. Stretch those
250
265
  // intermediate wrappers so its in-flow footer can sit at the bottom without
@@ -6,4 +6,4 @@ Object.defineProperty(exports, "__esModule", {
6
6
  exports.version = exports.name = void 0;
7
7
  var name = exports.name = "@atlaskit/editor-core";
8
8
  // eslint-disable-next-line @atlaskit/volt-strict-mode/no-multiple-exports
9
- var version = exports.version = "221.4.0";
9
+ var version = exports.version = "221.4.1";
@@ -229,7 +229,17 @@ const contentAreaHeightNoToolbar = css({
229
229
  // the WYSIWYG "preview" view) we tint the whole editor container with the
230
230
  // sunken surface so the source editor reads as a distinct, inset surface.
231
231
  const markdownModeContainerBackgroundStyle = css({
232
- backgroundColor: "var(--ds-surface-sunken, #F8F8F8)"
232
+ backgroundColor: "var(--ds-surface-sunken, #F8F8F8)",
233
+ // In the markdown MVP layout the source view (CodeMirror) is bounded to the
234
+ // viewport and owns its own scrolling, so the editor's scroll container must
235
+ // not also own vertical scrolling — its always-on `overflow-y: scroll` track
236
+ // would otherwise render a second, redundant scrollbar alongside CodeMirror's.
237
+ // This style is only applied in markdown source mode, so WYSIWYG / preview
238
+ // scrolling is unaffected.
239
+ // eslint-disable-next-line @atlaskit/ui-styling-standard/no-nested-selectors -- scoped override of the descendant scroll container
240
+ '& [data-editor-scroll-container="true"]': {
241
+ overflowY: 'hidden'
242
+ }
233
243
  });
234
244
  const markdownModeContentAreaStyle = css({
235
245
  boxSizing: 'border-box',
@@ -238,7 +248,12 @@ const markdownModeContentAreaStyle = css({
238
248
  maxWidth: 'none',
239
249
  minWidth: 0,
240
250
  paddingBottom: 0,
241
- paddingTop: "var(--ds-space-500, 40px)",
251
+ // No top padding here: it would inset the whole source view (including
252
+ // CodeMirror's `.cm-scroller`), leaving a gap above the editor's vertical
253
+ // scrollbar. The top inset is applied inside the scroller instead (see the
254
+ // `.cm-scroller` `paddingTop` in MarkdownSourceView) so the scrollbar still
255
+ // spans the full height.
256
+ paddingTop: 0,
242
257
  width: '100%',
243
258
  // The markdown source view is rendered through PluginSlot. Stretch those
244
259
  // intermediate wrappers so its in-flow footer can sit at the bottom without
@@ -1,3 +1,3 @@
1
1
  export const name = "@atlaskit/editor-core";
2
2
  // eslint-disable-next-line @atlaskit/volt-strict-mode/no-multiple-exports
3
- export const version = "221.4.0";
3
+ export const version = "221.4.1";
@@ -225,7 +225,17 @@ var contentAreaHeightNoToolbar = css({
225
225
  // the WYSIWYG "preview" view) we tint the whole editor container with the
226
226
  // sunken surface so the source editor reads as a distinct, inset surface.
227
227
  var markdownModeContainerBackgroundStyle = css({
228
- backgroundColor: "var(--ds-surface-sunken, #F8F8F8)"
228
+ backgroundColor: "var(--ds-surface-sunken, #F8F8F8)",
229
+ // In the markdown MVP layout the source view (CodeMirror) is bounded to the
230
+ // viewport and owns its own scrolling, so the editor's scroll container must
231
+ // not also own vertical scrolling — its always-on `overflow-y: scroll` track
232
+ // would otherwise render a second, redundant scrollbar alongside CodeMirror's.
233
+ // This style is only applied in markdown source mode, so WYSIWYG / preview
234
+ // scrolling is unaffected.
235
+ // eslint-disable-next-line @atlaskit/ui-styling-standard/no-nested-selectors -- scoped override of the descendant scroll container
236
+ '& [data-editor-scroll-container="true"]': {
237
+ overflowY: 'hidden'
238
+ }
229
239
  });
230
240
  var markdownModeContentAreaStyle = css({
231
241
  boxSizing: 'border-box',
@@ -234,7 +244,12 @@ var markdownModeContentAreaStyle = css({
234
244
  maxWidth: 'none',
235
245
  minWidth: 0,
236
246
  paddingBottom: 0,
237
- paddingTop: "var(--ds-space-500, 40px)",
247
+ // No top padding here: it would inset the whole source view (including
248
+ // CodeMirror's `.cm-scroller`), leaving a gap above the editor's vertical
249
+ // scrollbar. The top inset is applied inside the scroller instead (see the
250
+ // `.cm-scroller` `paddingTop` in MarkdownSourceView) so the scrollbar still
251
+ // spans the full height.
252
+ paddingTop: 0,
238
253
  width: '100%',
239
254
  // The markdown source view is rendered through PluginSlot. Stretch those
240
255
  // intermediate wrappers so its in-flow footer can sit at the bottom without
@@ -1,3 +1,3 @@
1
1
  export var name = "@atlaskit/editor-core";
2
2
  // eslint-disable-next-line @atlaskit/volt-strict-mode/no-multiple-exports
3
- export var version = "221.4.0";
3
+ export var version = "221.4.1";
package/package.json CHANGED
@@ -1,6 +1,6 @@
1
1
  {
2
2
  "name": "@atlaskit/editor-core",
3
- "version": "221.4.1",
3
+ "version": "221.5.0",
4
4
  "description": "A package contains Atlassian editor core functionality",
5
5
  "publishConfig": {
6
6
  "registry": "https://registry.npmjs.org/"
@@ -40,37 +40,37 @@
40
40
  "@atlaskit/activity-provider": "^3.0.0",
41
41
  "@atlaskit/adf-schema": "^56.0.0",
42
42
  "@atlaskit/afm-i18n-platform-editor-editor-core": "2.168.0",
43
- "@atlaskit/analytics-namespaced-context": "^8.0.0",
44
- "@atlaskit/analytics-next": "^12.0.0",
43
+ "@atlaskit/analytics-namespaced-context": "^8.1.0",
44
+ "@atlaskit/analytics-next": "^12.1.0",
45
45
  "@atlaskit/analytics-next-stable-react-context": "1.0.1",
46
- "@atlaskit/button": "^24.1.0",
46
+ "@atlaskit/button": "^24.2.0",
47
47
  "@atlaskit/css": "^1.0.0",
48
48
  "@atlaskit/editor-json-transformer": "^9.0.0",
49
- "@atlaskit/editor-performance-metrics": "^3.0.0",
49
+ "@atlaskit/editor-performance-metrics": "^3.1.0",
50
50
  "@atlaskit/editor-plugin-connectivity": "^12.0.0",
51
51
  "@atlaskit/editor-plugin-quick-insert": "^12.0.0",
52
52
  "@atlaskit/editor-plugin-user-preferences": "^10.0.0",
53
53
  "@atlaskit/editor-plugins": "^14.0.0",
54
54
  "@atlaskit/editor-prosemirror": "^8.0.0",
55
55
  "@atlaskit/editor-shared-styles": "^4.0.0",
56
- "@atlaskit/editor-ssr-renderer": "^7.0.0",
57
- "@atlaskit/editor-toolbar": "^2.0.0",
58
- "@atlaskit/editor-toolbar-model": "^1.0.0",
56
+ "@atlaskit/editor-ssr-renderer": "^7.1.0",
57
+ "@atlaskit/editor-toolbar": "^2.1.0",
58
+ "@atlaskit/editor-toolbar-model": "^1.1.0",
59
59
  "@atlaskit/emoji": "^71.6.0",
60
60
  "@atlaskit/feature-gate-js-client": "^6.0.0",
61
- "@atlaskit/icon": "^36.0.0",
62
- "@atlaskit/link": "^4.0.0",
63
- "@atlaskit/media-card": "^81.1.0",
64
- "@atlaskit/mention": "^27.4.0",
61
+ "@atlaskit/icon": "^36.1.0",
62
+ "@atlaskit/link": "^4.1.0",
63
+ "@atlaskit/media-card": "^81.2.0",
64
+ "@atlaskit/mention": "^27.5.0",
65
65
  "@atlaskit/platform-feature-flags": "^2.0.0",
66
- "@atlaskit/platform-feature-flags-react": "^1.0.0",
66
+ "@atlaskit/platform-feature-flags-react": "^1.1.0",
67
67
  "@atlaskit/react-compiler-gating": "^0.2.0",
68
- "@atlaskit/react-ufo": "^7.2.0",
69
- "@atlaskit/task-decision": "^21.3.0",
68
+ "@atlaskit/react-ufo": "^7.3.0",
69
+ "@atlaskit/task-decision": "^21.4.0",
70
70
  "@atlaskit/tmp-editor-statsig": "^114.0.0",
71
- "@atlaskit/tokens": "^15.0.0",
72
- "@atlaskit/tooltip": "^23.0.0",
73
- "@atlaskit/width-detector": "^6.0.0",
71
+ "@atlaskit/tokens": "^15.1.0",
72
+ "@atlaskit/tooltip": "^23.1.0",
73
+ "@atlaskit/width-detector": "^6.1.0",
74
74
  "@babel/runtime": "^7.0.0",
75
75
  "@compiled/react": "^0.20.0",
76
76
  "@emotion/react": "^11.7.1",
@@ -85,8 +85,8 @@
85
85
  "uuid": "^3.1.0"
86
86
  },
87
87
  "peerDependencies": {
88
- "@atlaskit/editor-common": "^116.14.0",
89
- "@atlaskit/link-provider": "^5.0.0",
88
+ "@atlaskit/editor-common": "^116.15.0",
89
+ "@atlaskit/link-provider": "^5.1.0",
90
90
  "@atlaskit/media-core": "^38.0.0",
91
91
  "react": "^18.2.0",
92
92
  "react-dom": "^18.2.0",
@@ -97,34 +97,34 @@
97
97
  "@af/suppress-react-warnings": "workspace:^",
98
98
  "@af/visual-regression": "workspace:^",
99
99
  "@atlaskit/adf-utils": "^20.0.0",
100
- "@atlaskit/analytics-listeners": "^11.0.0",
101
- "@atlaskit/code": "^18.1.0",
100
+ "@atlaskit/analytics-listeners": "^11.1.0",
101
+ "@atlaskit/code": "^18.2.0",
102
102
  "@atlaskit/collab-provider": "^21.0.0",
103
103
  "@atlaskit/editor-plugin-annotation": "^12.0.0",
104
104
  "@atlaskit/editor-plugin-card": "^18.0.0",
105
105
  "@atlaskit/editor-plugin-list": "^14.1.0",
106
106
  "@atlaskit/editor-plugin-paste": "^13.3.0",
107
107
  "@atlaskit/editor-test-helpers": "workspace:^",
108
- "@atlaskit/link-provider": "^5.0.0",
108
+ "@atlaskit/link-provider": "^5.1.0",
109
109
  "@atlaskit/linking-common": "^11.0.0",
110
- "@atlaskit/logo": "^21.1.0",
110
+ "@atlaskit/logo": "^21.2.0",
111
111
  "@atlaskit/media-core": "^38.0.0",
112
112
  "@atlaskit/media-integration-test-helpers": "workspace:^",
113
- "@atlaskit/media-test-helpers": "^42.0.0",
114
- "@atlaskit/modal-dialog": "^16.0.0",
115
- "@atlaskit/popper": "^8.1.0",
116
- "@atlaskit/portal": "^6.0.0",
117
- "@atlaskit/renderer": "^133.6.0",
118
- "@atlaskit/section-message": "^9.1.0",
113
+ "@atlaskit/media-test-helpers": "^42.1.0",
114
+ "@atlaskit/modal-dialog": "^16.1.0",
115
+ "@atlaskit/popper": "^8.2.0",
116
+ "@atlaskit/portal": "^6.1.0",
117
+ "@atlaskit/renderer": "^133.7.0",
118
+ "@atlaskit/section-message": "^9.2.0",
119
119
  "@atlaskit/synchrony-test-helpers": "workspace:^",
120
- "@atlaskit/toggle": "^17.0.0",
121
- "@atlaskit/util-data-test": "^19.0.0",
120
+ "@atlaskit/toggle": "^17.1.0",
121
+ "@atlaskit/util-data-test": "^19.1.0",
122
122
  "@atlassian/a11y-jest-testing": "^0.13.0",
123
123
  "@atlassian/a11y-playwright-testing": "^0.10.0",
124
124
  "@atlassian/adf-schema-json": "^1.33.0",
125
125
  "@atlassian/editor-rovo-bridge": "^10.2.0",
126
126
  "@atlassian/feature-flags-test-utils": "^1.1.0",
127
- "@atlassian/search-client": "^1.18.0",
127
+ "@atlassian/search-client": "^1.19.0",
128
128
  "@atlassian/search-provider": "^13.0.0",
129
129
  "@atlassian/structured-docs-types": "workspace:^",
130
130
  "@atlassian/user-profile-card": "^1.15.0",