@atlaskit/editor-core 219.9.9 → 219.9.10

package/CHANGELOG.md

@@ -1,5 +1,14 @@
 # @atlaskit/editor-core
 
+## 219.9.10
+
+### Patch Changes
+
+- [`96b390b511102`](https://bitbucket.org/atlassian/atlassian-frontend-monorepo/commits/96b390b511102) -
+  Add the `platform_editor_per_plugin_error_boundary` experiment and use it to isolate editor
+  PluginSlot failures to the failing plugin.
+- Updated dependencies
+
 ## 219.9.9
 
 ### Patch Changes

package/dist/cjs/ui/Appearance/FullPage/FullPageContentArea.js

@@ -259,7 +259,7 @@ var Content = /*#__PURE__*/_react.default.forwardRef(function (props, ref) {
     var _states$markdownModeS2;
     return (_states$markdownModeS2 = states.markdownModeState) === null || _states$markdownModeS2 === void 0 ? void 0 : _states$markdownModeS2.isMarkdownMode;
   });
-  var shouldHideProseMirrorForMarkdownMode = (0, _expValEqualsNoExposure.expValEqualsNoExposure)('cc-markdown-mode', 'isEnabled', true) && markdownPluginCurrentView !== 'wysiwyg' && markdownPluginCurrentIsMarkdownMode;
+  var shouldHideProseMirrorForMarkdownMode = (0, _expValEqualsNoExposure.expValEqualsNoExposure)('cc-markdown-mode', 'isEnabled', true) && markdownPluginCurrentView !== 'preview' && markdownPluginCurrentIsMarkdownMode;
   return (0, _react2.jsx)("div", {
     css: [contentAreaNew, props.isEditorToolbarHidden && contentAreaHeightNoToolbar],
     "data-testid": CONTENT_AREA_TEST_ID,

package/dist/cjs/ui/PluginSlot/index.js

@@ -17,8 +17,8 @@ var _PluginSlotEmotion = require("./PluginSlot-emotion");
 var PluginsComponentsWrapperMigration = (0, _platformFeatureFlagsReact.componentWithCondition)(function () {
   return (0, _expValEquals.expValEquals)('platform_editor_core_non_ecc_static_css', 'isEnabled', true);
 }, _PluginSlotCompiled.PluginsComponentsWrapperCompiled, _PluginSlotEmotion.PluginsComponentsWrapperEmotion);
-var PluginSlot = function PluginSlot(_ref) {
-  var items = _ref.items,
+var PluginComponent = function PluginComponent(_ref) {
+  var component = _ref.component,
     editorView = _ref.editorView,
     editorActions = _ref.editorActions,
     eventDispatcher = _ref.eventDispatcher,
@@ -30,11 +30,43 @@ var PluginSlot = function PluginSlot(_ref) {
     containerElement = _ref.containerElement,
     disabled = _ref.disabled,
     dispatchAnalyticsEvent = _ref.dispatchAnalyticsEvent,
-    wrapperElement = _ref.wrapperElement,
-    pluginHooks = _ref.pluginHooks;
+    wrapperElement = _ref.wrapperElement;
+  return component({
+    editorView: editorView,
+    editorActions: editorActions,
+    eventDispatcher: eventDispatcher,
+    providerFactory: providerFactory,
+    dispatchAnalyticsEvent: dispatchAnalyticsEvent,
+    // Ignored via go/ees005
+    // eslint-disable-next-line @typescript-eslint/no-non-null-assertion
+    appearance: appearance,
+    popupsMountPoint: popupsMountPoint,
+    popupsBoundariesElement: popupsBoundariesElement,
+    popupsScrollableElement: popupsScrollableElement,
+    containerElement: containerElement,
+    disabled: disabled,
+    wrapperElement: wrapperElement
+  });
+};
+var PluginSlot = function PluginSlot(_ref2) {
+  var items = _ref2.items,
+    editorView = _ref2.editorView,
+    editorActions = _ref2.editorActions,
+    eventDispatcher = _ref2.eventDispatcher,
+    providerFactory = _ref2.providerFactory,
+    appearance = _ref2.appearance,
+    popupsMountPoint = _ref2.popupsMountPoint,
+    popupsBoundariesElement = _ref2.popupsBoundariesElement,
+    popupsScrollableElement = _ref2.popupsScrollableElement,
+    containerElement = _ref2.containerElement,
+    disabled = _ref2.disabled,
+    dispatchAnalyticsEvent = _ref2.dispatchAnalyticsEvent,
+    wrapperElement = _ref2.wrapperElement,
+    pluginHooks = _ref2.pluginHooks;
   if (!items && !pluginHooks) {
     return null;
   }
+  var isolatePluginSlotFailures = Boolean(items === null || items === void 0 ? void 0 : items.length) && (0, _expValEquals.expValEquals)('platform_editor_per_plugin_error_boundary', 'isEnabled', true);
   return /*#__PURE__*/_react.default.createElement(_ErrorBoundary.ErrorBoundary, {
     component: _analytics.ACTION_SUBJECT.PLUGIN_SLOT,
     fallbackComponent: null
@@ -44,9 +76,41 @@ var PluginSlot = function PluginSlot(_ref) {
     containerElement: containerElement
   }), /*#__PURE__*/_react.default.createElement(PluginsComponentsWrapperMigration, {
     "data-testid": "plugins-components-wrapper"
-  }, items === null || items === void 0 ? void 0 : items.map(function (component, key) {
+  }, items === null || items === void 0 ? void 0 : items.map(function (component, index) {
+    if (isolatePluginSlotFailures) {
+      return (
+        /*#__PURE__*/
+        // The wrapper adds a small amount of overhead, but moves the plugin factory call
+        // inside the per-plugin boundary while still invoking it as a factory.
+        _react.default.createElement(_ErrorBoundary.ErrorBoundary
+        // Switching to a data-derived key currently breaks editor-plugin-ai's
+        // Discard flow (which relies on positional remounts to reset modal
+        // state). Tracked for follow-up behind a separate gate.
+        // eslint-disable-next-line react/no-array-index-key
+        , {
+          key: index,
+          component: _analytics.ACTION_SUBJECT.PLUGIN_SLOT,
+          dispatchAnalyticsEvent: dispatchAnalyticsEvent,
+          fallbackComponent: null
+        }, /*#__PURE__*/_react.default.createElement(PluginComponent, {
+          component: component,
+          editorView: editorView,
+          editorActions: editorActions,
+          eventDispatcher: eventDispatcher,
+          providerFactory: providerFactory,
+          appearance: appearance,
+          popupsMountPoint: popupsMountPoint,
+          popupsBoundariesElement: popupsBoundariesElement,
+          popupsScrollableElement: popupsScrollableElement,
+          containerElement: containerElement,
+          disabled: disabled,
+          dispatchAnalyticsEvent: dispatchAnalyticsEvent,
+          wrapperElement: wrapperElement
+        }))
+      );
+    }
     var props = {
-      key: key
+      key: index
     };
     var element = component({
       editorView: editorView,

package/dist/cjs/version-wrapper.js

@@ -5,4 +5,4 @@ Object.defineProperty(exports, "__esModule", {
 });
 exports.version = exports.name = void 0;
 var name = exports.name = "@atlaskit/editor-core";
-var version = exports.version = "219.9.8";
+var version = exports.version = "219.9.9";

package/dist/es2019/ui/Appearance/FullPage/FullPageContentArea.js

@@ -251,7 +251,7 @@ const Content = /*#__PURE__*/React.forwardRef((props, ref) => {
     var _states$markdownModeS2;
     return (_states$markdownModeS2 = states.markdownModeState) === null || _states$markdownModeS2 === void 0 ? void 0 : _states$markdownModeS2.isMarkdownMode;
   });
-  const shouldHideProseMirrorForMarkdownMode = expValEqualsNoExposure('cc-markdown-mode', 'isEnabled', true) && markdownPluginCurrentView !== 'wysiwyg' && markdownPluginCurrentIsMarkdownMode;
+  const shouldHideProseMirrorForMarkdownMode = expValEqualsNoExposure('cc-markdown-mode', 'isEnabled', true) && markdownPluginCurrentView !== 'preview' && markdownPluginCurrentIsMarkdownMode;
   return jsx("div", {
     css: [contentAreaNew, props.isEditorToolbarHidden && contentAreaHeightNoToolbar],
     "data-testid": CONTENT_AREA_TEST_ID,

package/dist/es2019/ui/PluginSlot/index.js

@@ -8,6 +8,38 @@ import { MountPluginHooks } from './mount-plugin-hooks';
 import { PluginsComponentsWrapperCompiled } from './PluginSlot-compiled';
 import { PluginsComponentsWrapperEmotion } from './PluginSlot-emotion';
 const PluginsComponentsWrapperMigration = componentWithCondition(() => expValEquals('platform_editor_core_non_ecc_static_css', 'isEnabled', true), PluginsComponentsWrapperCompiled, PluginsComponentsWrapperEmotion);
+const PluginComponent = ({
+  component,
+  editorView,
+  editorActions,
+  eventDispatcher,
+  providerFactory,
+  appearance,
+  popupsMountPoint,
+  popupsBoundariesElement,
+  popupsScrollableElement,
+  containerElement,
+  disabled,
+  dispatchAnalyticsEvent,
+  wrapperElement
+}) => {
+  return component({
+    editorView: editorView,
+    editorActions: editorActions,
+    eventDispatcher: eventDispatcher,
+    providerFactory,
+    dispatchAnalyticsEvent,
+    // Ignored via go/ees005
+    // eslint-disable-next-line @typescript-eslint/no-non-null-assertion
+    appearance: appearance,
+    popupsMountPoint,
+    popupsBoundariesElement,
+    popupsScrollableElement,
+    containerElement,
+    disabled,
+    wrapperElement
+  });
+};
 const PluginSlot = ({
   items,
   editorView,
@@ -27,6 +59,7 @@ const PluginSlot = ({
   if (!items && !pluginHooks) {
     return null;
   }
+  const isolatePluginSlotFailures = Boolean(items === null || items === void 0 ? void 0 : items.length) && expValEquals('platform_editor_per_plugin_error_boundary', 'isEnabled', true);
   return /*#__PURE__*/React.createElement(ErrorBoundary, {
     component: ACTION_SUBJECT.PLUGIN_SLOT,
     fallbackComponent: null
@@ -36,9 +69,41 @@ const PluginSlot = ({
     containerElement: containerElement
   }), /*#__PURE__*/React.createElement(PluginsComponentsWrapperMigration, {
     "data-testid": "plugins-components-wrapper"
-  }, items === null || items === void 0 ? void 0 : items.map((component, key) => {
+  }, items === null || items === void 0 ? void 0 : items.map((component, index) => {
+    if (isolatePluginSlotFailures) {
+      return (
+        /*#__PURE__*/
+        // The wrapper adds a small amount of overhead, but moves the plugin factory call
+        // inside the per-plugin boundary while still invoking it as a factory.
+        React.createElement(ErrorBoundary
+        // Switching to a data-derived key currently breaks editor-plugin-ai's
+        // Discard flow (which relies on positional remounts to reset modal
+        // state). Tracked for follow-up behind a separate gate.
+        // eslint-disable-next-line react/no-array-index-key
+        , {
+          key: index,
+          component: ACTION_SUBJECT.PLUGIN_SLOT,
+          dispatchAnalyticsEvent: dispatchAnalyticsEvent,
+          fallbackComponent: null
+        }, /*#__PURE__*/React.createElement(PluginComponent, {
+          component: component,
+          editorView: editorView,
+          editorActions: editorActions,
+          eventDispatcher: eventDispatcher,
+          providerFactory: providerFactory,
+          appearance: appearance,
+          popupsMountPoint: popupsMountPoint,
+          popupsBoundariesElement: popupsBoundariesElement,
+          popupsScrollableElement: popupsScrollableElement,
+          containerElement: containerElement,
+          disabled: disabled,
+          dispatchAnalyticsEvent: dispatchAnalyticsEvent,
+          wrapperElement: wrapperElement
+        }))
+      );
+    }
     const props = {
-      key
+      key: index
     };
     const element = component({
       editorView: editorView,

package/dist/es2019/version-wrapper.js

@@ -1,2 +1,2 @@
 export const name = "@atlaskit/editor-core";
-export const version = "219.9.8";
+export const version = "219.9.9";

package/dist/esm/ui/Appearance/FullPage/FullPageContentArea.js

@@ -249,7 +249,7 @@ var Content = /*#__PURE__*/React.forwardRef(function (props, ref) {
     var _states$markdownModeS2;
     return (_states$markdownModeS2 = states.markdownModeState) === null || _states$markdownModeS2 === void 0 ? void 0 : _states$markdownModeS2.isMarkdownMode;
   });
-  var shouldHideProseMirrorForMarkdownMode = expValEqualsNoExposure('cc-markdown-mode', 'isEnabled', true) && markdownPluginCurrentView !== 'wysiwyg' && markdownPluginCurrentIsMarkdownMode;
+  var shouldHideProseMirrorForMarkdownMode = expValEqualsNoExposure('cc-markdown-mode', 'isEnabled', true) && markdownPluginCurrentView !== 'preview' && markdownPluginCurrentIsMarkdownMode;
   return jsx("div", {
     css: [contentAreaNew, props.isEditorToolbarHidden && contentAreaHeightNoToolbar],
     "data-testid": CONTENT_AREA_TEST_ID,

package/dist/esm/ui/PluginSlot/index.js

@@ -10,8 +10,8 @@ import { PluginsComponentsWrapperEmotion } from './PluginSlot-emotion';
 var PluginsComponentsWrapperMigration = componentWithCondition(function () {
   return expValEquals('platform_editor_core_non_ecc_static_css', 'isEnabled', true);
 }, PluginsComponentsWrapperCompiled, PluginsComponentsWrapperEmotion);
-var PluginSlot = function PluginSlot(_ref) {
-  var items = _ref.items,
+var PluginComponent = function PluginComponent(_ref) {
+  var component = _ref.component,
     editorView = _ref.editorView,
     editorActions = _ref.editorActions,
     eventDispatcher = _ref.eventDispatcher,
@@ -23,11 +23,43 @@ var PluginSlot = function PluginSlot(_ref) {
     containerElement = _ref.containerElement,
     disabled = _ref.disabled,
     dispatchAnalyticsEvent = _ref.dispatchAnalyticsEvent,
-    wrapperElement = _ref.wrapperElement,
-    pluginHooks = _ref.pluginHooks;
+    wrapperElement = _ref.wrapperElement;
+  return component({
+    editorView: editorView,
+    editorActions: editorActions,
+    eventDispatcher: eventDispatcher,
+    providerFactory: providerFactory,
+    dispatchAnalyticsEvent: dispatchAnalyticsEvent,
+    // Ignored via go/ees005
+    // eslint-disable-next-line @typescript-eslint/no-non-null-assertion
+    appearance: appearance,
+    popupsMountPoint: popupsMountPoint,
+    popupsBoundariesElement: popupsBoundariesElement,
+    popupsScrollableElement: popupsScrollableElement,
+    containerElement: containerElement,
+    disabled: disabled,
+    wrapperElement: wrapperElement
+  });
+};
+var PluginSlot = function PluginSlot(_ref2) {
+  var items = _ref2.items,
+    editorView = _ref2.editorView,
+    editorActions = _ref2.editorActions,
+    eventDispatcher = _ref2.eventDispatcher,
+    providerFactory = _ref2.providerFactory,
+    appearance = _ref2.appearance,
+    popupsMountPoint = _ref2.popupsMountPoint,
+    popupsBoundariesElement = _ref2.popupsBoundariesElement,
+    popupsScrollableElement = _ref2.popupsScrollableElement,
+    containerElement = _ref2.containerElement,
+    disabled = _ref2.disabled,
+    dispatchAnalyticsEvent = _ref2.dispatchAnalyticsEvent,
+    wrapperElement = _ref2.wrapperElement,
+    pluginHooks = _ref2.pluginHooks;
   if (!items && !pluginHooks) {
     return null;
   }
+  var isolatePluginSlotFailures = Boolean(items === null || items === void 0 ? void 0 : items.length) && expValEquals('platform_editor_per_plugin_error_boundary', 'isEnabled', true);
   return /*#__PURE__*/React.createElement(ErrorBoundary, {
     component: ACTION_SUBJECT.PLUGIN_SLOT,
     fallbackComponent: null
@@ -37,9 +69,41 @@ var PluginSlot = function PluginSlot(_ref) {
     containerElement: containerElement
   }), /*#__PURE__*/React.createElement(PluginsComponentsWrapperMigration, {
     "data-testid": "plugins-components-wrapper"
-  }, items === null || items === void 0 ? void 0 : items.map(function (component, key) {
+  }, items === null || items === void 0 ? void 0 : items.map(function (component, index) {
+    if (isolatePluginSlotFailures) {
+      return (
+        /*#__PURE__*/
+        // The wrapper adds a small amount of overhead, but moves the plugin factory call
+        // inside the per-plugin boundary while still invoking it as a factory.
+        React.createElement(ErrorBoundary
+        // Switching to a data-derived key currently breaks editor-plugin-ai's
+        // Discard flow (which relies on positional remounts to reset modal
+        // state). Tracked for follow-up behind a separate gate.
+        // eslint-disable-next-line react/no-array-index-key
+        , {
+          key: index,
+          component: ACTION_SUBJECT.PLUGIN_SLOT,
+          dispatchAnalyticsEvent: dispatchAnalyticsEvent,
+          fallbackComponent: null
+        }, /*#__PURE__*/React.createElement(PluginComponent, {
+          component: component,
+          editorView: editorView,
+          editorActions: editorActions,
+          eventDispatcher: eventDispatcher,
+          providerFactory: providerFactory,
+          appearance: appearance,
+          popupsMountPoint: popupsMountPoint,
+          popupsBoundariesElement: popupsBoundariesElement,
+          popupsScrollableElement: popupsScrollableElement,
+          containerElement: containerElement,
+          disabled: disabled,
+          dispatchAnalyticsEvent: dispatchAnalyticsEvent,
+          wrapperElement: wrapperElement
+        }))
+      );
+    }
     var props = {
-      key: key
+      key: index
     };
     var element = component({
       editorView: editorView,

package/dist/esm/version-wrapper.js

@@ -1,2 +1,2 @@
 export var name = "@atlaskit/editor-core";
-export var version = "219.9.8";
+export var version = "219.9.9";

package/dist/types/types/markdown-mode.d.ts

@@ -1,5 +1,5 @@
 import type { NextEditorPlugin } from '@atlaskit/editor-common/types';
-export type MarkdownModeView = 'syntax' | 'wysiwyg' | 'preview';
+export type MarkdownModeView = 'syntax' | 'split-view' | 'preview';
 export type MarkdownModePlugin = NextEditorPlugin<'markdownMode', {
     actions: {
         setView: (view: MarkdownModeView) => void;

package/dist/types/ui/Appearance/Chromeless-compiled.d.ts

@@ -15,4 +15,4 @@ export interface ChromelessEditorContainerProps extends HTMLAttributes<HTMLDivEl
     maxHeight?: number;
     minHeight: number;
 }
-export declare const ChromelessEditorContainerCompiled: ({ children, containerRef, maxHeight, minHeight }: ChromelessEditorContainerProps) => React.JSX.Element;
+export declare const ChromelessEditorContainerCompiled: ({ children, containerRef, maxHeight, minHeight, }: ChromelessEditorContainerProps) => React.JSX.Element;

package/dist/types-ts4.5/types/markdown-mode.d.ts

@@ -1,5 +1,5 @@
 import type { NextEditorPlugin } from '@atlaskit/editor-common/types';
-export type MarkdownModeView = 'syntax' | 'wysiwyg' | 'preview';
+export type MarkdownModeView = 'syntax' | 'split-view' | 'preview';
 export type MarkdownModePlugin = NextEditorPlugin<'markdownMode', {
     actions: {
         setView: (view: MarkdownModeView) => void;

package/dist/types-ts4.5/ui/Appearance/Chromeless-compiled.d.ts

@@ -15,4 +15,4 @@ export interface ChromelessEditorContainerProps extends HTMLAttributes<HTMLDivEl
     maxHeight?: number;
     minHeight: number;
 }
-export declare const ChromelessEditorContainerCompiled: ({ children, containerRef, maxHeight, minHeight }: ChromelessEditorContainerProps) => React.JSX.Element;
+export declare const ChromelessEditorContainerCompiled: ({ children, containerRef, maxHeight, minHeight, }: ChromelessEditorContainerProps) => React.JSX.Element;

package/package.json

@@ -1,6 +1,6 @@
 {
 	"name": "@atlaskit/editor-core",
-	"version": "219.9.9",
+	"version": "219.9.10",
 	"description": "A package contains Atlassian editor core functionality",
 	"publishConfig": {
 		"registry": "https://registry.npmjs.org/"
@@ -66,7 +66,7 @@
 		"@atlaskit/editor-toolbar-model": "^0.5.0",
 		"@atlaskit/emoji": "^70.10.0",
 		"@atlaskit/feature-gate-js-client": "^5.7.0",
-		"@atlaskit/icon": "^35.1.0",
+		"@atlaskit/icon": "^35.2.0",
 		"@atlaskit/link": "^3.4.0",
 		"@atlaskit/media-card": "^80.5.0",
 		"@atlaskit/mention": "^26.0.0",
@@ -74,7 +74,7 @@
 		"@atlaskit/platform-feature-flags-react": "^0.5.0",
 		"@atlaskit/react-ufo": "^6.1.0",
 		"@atlaskit/task-decision": "^20.1.0",
-		"@atlaskit/tmp-editor-statsig": "^83.0.0",
+		"@atlaskit/tmp-editor-statsig": "^83.1.0",
 		"@atlaskit/tokens": "^13.0.0",
 		"@atlaskit/tooltip": "^22.3.0",
 		"@atlaskit/width-detector": "^5.1.0",
@@ -92,7 +92,7 @@
 		"uuid": "^3.1.0"
 	},
 	"peerDependencies": {
-		"@atlaskit/editor-common": "^114.46.0",
+		"@atlaskit/editor-common": "^114.47.0",
 		"@atlaskit/link-provider": "^4.4.0",
 		"@atlaskit/media-core": "^37.1.0",
 		"react": "^18.2.0",
@@ -113,7 +113,7 @@
 		"@atlaskit/editor-plugin-paste": "^11.2.0",
 		"@atlaskit/editor-test-helpers": "workspace:^",
 		"@atlaskit/link-provider": "^4.4.0",
-		"@atlaskit/linking-common": "^9.11.0",
+		"@atlaskit/linking-common": "^9.12.0",
 		"@atlaskit/logo": "^20.1.0",
 		"@atlaskit/media-core": "^37.1.0",
 		"@atlaskit/media-integration-test-helpers": "workspace:^",
@@ -124,7 +124,7 @@
 		"@atlaskit/renderer": "^131.1.0",
 		"@atlaskit/section-message": "^8.13.0",
 		"@atlaskit/synchrony-test-helpers": "workspace:^",
-		"@atlaskit/toggle": "^15.6.0",
+		"@atlaskit/toggle": "^16.0.0",
 		"@atlaskit/util-data-test": "^18.6.0",
 		"@atlassian/a11y-jest-testing": "^0.11.0",
 		"@atlassian/a11y-playwright-testing": "^0.10.0",