@atlaskit/editor-core 219.5.1 → 219.6.0

package/CHANGELOG.md

@@ -1,5 +1,24 @@
 # @atlaskit/editor-core
 
+## 219.6.0
+
+### Minor Changes
+
+- [`80e6f41ddfce4`](https://bitbucket.org/atlassian/atlassian-frontend-monorepo/commits/80e6f41ddfce4) -
+  Reconcile editor plugin set on reconfigureState across preset switches: drop plugins whose schema
+  nodes/marks aren't in the current schema, and evict plugins from the injection API that aren't
+  part of the new preset. Behind feature gate `platform_editor_reconfigure_filter_plugins`.
+
+  Adds the `NamedReactHookFactory` type to `@atlaskit/editor-common/types` and annotates each
+  plugin's `usePluginHook` with its plugin name in `processPluginsList` so `MountPluginHooks` can
+  key React fibers stably per plugin. The shape of `EditorConfig.pluginHooks` is unchanged
+  (`ReactHookFactory[]`); the annotation is a non-breaking additive property on the function value
+  that falls back to the array index when absent.
+
+### Patch Changes
+
+- Updated dependencies
+
 ## 219.5.1
 
 ### Patch Changes

package/dist/cjs/create-editor/ReactEditorView.js

@@ -49,6 +49,7 @@ var _consts = require("./consts");
 var _createEditor = require("./create-editor");
 var _createPluginsList = _interopRequireDefault(require("./create-plugins-list"));
 var _createSchema = require("./create-schema");
+var _filterPluginsForReconfigure = require("./filter-plugins-for-reconfigure");
 var _messages = require("./messages");
 var _focusEditorElement = require("./ReactEditorView/focusEditorElement");
 var _getUAPrefix = require("./ReactEditorView/getUAPrefix");
@@ -362,6 +363,10 @@ function ReactEditorView(props) {
   var _useState = (0, _react.useState)(0),
     _useState2 = (0, _slicedToArray2.default)(_useState, 2),
     bumpConfigVersion = _useState2[1];
+
+  // Preset reference last processed by the schema/API reconciliation below.
+  // Used to skip that work when reconfigure is called with the same preset.
+  var lastFilteredPresetRef = (0, _react.useRef)(null);
   var reconfigureState = (0, _react.useCallback)(function (props) {
     if (!viewRef.current) {
       return;
@@ -371,7 +376,47 @@ function ReactEditorView(props) {
     // so we blur here to stop ProseMirror from trying to apply selection to detached nodes or
     // nodes that haven't been re-rendered to the document yet.
     blur();
+
+    // Snapshot plugin names registered before createPluginsList runs, so
+    // we can tell which plugins are newly added by the new preset vs.
+    // which ones already coexisted with the current schema.
+    var previousPluginNames = new Set(pluginInjectionAPI.current.getRegisteredPluginNames());
     var editorPlugins = (0, _createPluginsList.default)(props.preset, 'allowBlockType' in props.editorProps ? props.editorProps : {}, pluginInjectionAPI.current);
+
+    // `state.reconfigure` keeps the original schema, so switching presets
+    // can leave the editor inconsistent in two ways:
+    //   1. The new preset may add plugins that reference schema nodes or
+    //      marks the original schema doesn't have.
+    //   2. Plugins registered by a previous preset can linger in the
+    //      injection API even when the new preset doesn't re-register
+    //      them, so listeners still fire against a state that no longer
+    //      has their pmPlugin.
+    if (lastFilteredPresetRef.current !== props.preset && (0, _platformFeatureFlags.fg)('platform_editor_reconfigure_filter_plugins')) {
+      var _filterPluginsForReco = (0, _filterPluginsForReconfigure.filterPluginsForReconfigure)(editorPlugins, viewRef.current.state.schema, previousPluginNames),
+        kept = _filterPluginsForReco.kept,
+        dropped = _filterPluginsForReco.dropped;
+      editorPlugins = kept;
+
+      // Reconcile the injection API with the post-filter plugin set.
+      // This evicts both the plugins we just dropped above (re-registered
+      // by createPluginsList but no longer in editorPlugins) AND any
+      // plugin from a previous preset that the new preset doesn't
+      // re-register.
+      var keptPluginNames = new Set(editorPlugins.map(function (p) {
+        return p === null || p === void 0 ? void 0 : p.name;
+      }).filter(function (n) {
+        return Boolean(n);
+      }));
+      var evictedFromApi = pluginInjectionAPI.current.retainPlugins(keptPluginNames);
+      if (dropped.length > 0 || evictedFromApi.length > 0) {
+        // eslint-disable-next-line no-console
+        console.warn('[reconfigureState] Cleanup summary:', {
+          dropped: dropped,
+          evictedFromApi: evictedFromApi
+        });
+      }
+      lastFilteredPresetRef.current = props.preset;
+    }
     config.current = (0, _createEditor.processPluginsList)(editorPlugins);
     if ((0, _expValEquals.expValEquals)('platform_editor_appearance_shared_state', 'isEnabled', true)) {
       var _config$current$pmPlu2;

package/dist/cjs/create-editor/create-editor.js

@@ -72,7 +72,12 @@ function processPluginsList(plugins) {
       acc.contentComponents.push(plugin.contentComponent);
     }
     if (plugin.usePluginHook) {
-      acc.pluginHooks.push(plugin.usePluginHook);
+      // Wrap with .bind(null) so we can annotate the function with the
+      // plugin name without mutating the plugin's original hook reference.
+      // MountPluginHooks reads `pluginName` to derive a stable React key.
+      var named = plugin.usePluginHook.bind(null);
+      named.pluginName = plugin.name;
+      acc.pluginHooks.push(named);
     }
     if (plugin.primaryToolbarComponent) {
       acc.primaryToolbarComponents.push(plugin.primaryToolbarComponent);

package/dist/cjs/create-editor/filter-plugins-for-reconfigure.js

@@ -0,0 +1,49 @@
+"use strict";
+
+Object.defineProperty(exports, "__esModule", {
+  value: true
+});
+exports.filterPluginsForReconfigure = filterPluginsForReconfigure;
+/**
+ * Used by `reconfigureState` to drop plugins from a freshly-built preset that
+ * declare schema nodes/marks the current schema doesn't have. Plugins already
+ * present before this reconfigure are kept untouched: they have demonstrably
+ * coexisted with the schema (e.g. tests that mock a stripped-down schema), so
+ * removing them now would be a regression.
+ */
+function filterPluginsForReconfigure(editorPlugins, schema, previousPluginNames) {
+  var availableNodeNames = new Set(Object.keys(schema.nodes));
+  var availableMarkNames = new Set(Object.keys(schema.marks));
+  var dropped = [];
+  var kept = editorPlugins.filter(function (plugin) {
+    if (!plugin) {
+      return false;
+    }
+    if (previousPluginNames.has(plugin.name)) {
+      return true;
+    }
+    var missingNodes = plugin.nodes ? plugin.nodes().map(function (n) {
+      return n.name;
+    }).filter(function (n) {
+      return !availableNodeNames.has(n);
+    }) : [];
+    var missingMarks = plugin.marks ? plugin.marks().map(function (m) {
+      return m.name;
+    }).filter(function (m) {
+      return !availableMarkNames.has(m);
+    }) : [];
+    if (missingNodes.length > 0 || missingMarks.length > 0) {
+      dropped.push({
+        name: plugin.name,
+        missingNodes: missingNodes,
+        missingMarks: missingMarks
+      });
+      return false;
+    }
+    return true;
+  });
+  return {
+    kept: kept,
+    dropped: dropped
+  };
+}

package/dist/cjs/test-utils.js

@@ -56,7 +56,9 @@ function lightProcessPluginsList(editorPlugins) {
       acc.contentComponents.push(editorPlugin.contentComponent);
     }
     if (editorPlugin.usePluginHook) {
-      acc.pluginHooks.push(editorPlugin.usePluginHook);
+      var named = editorPlugin.usePluginHook.bind(null);
+      named.pluginName = editorPlugin.name;
+      acc.pluginHooks.push(named);
     }
     if (editorPlugin.onEditorViewStateUpdated) {
       acc.onEditorViewStateUpdatedCallbacks.push(editorPlugin.onEditorViewStateUpdated);

package/dist/cjs/ui/PluginSlot/mount-plugin-hooks.js

@@ -23,12 +23,19 @@ function MountPluginHooks(_ref2) {
   if (!editorView) {
     return null;
   }
-  return /*#__PURE__*/_react.default.createElement(_react.default.Fragment, null, pluginHooks === null || pluginHooks === void 0 ? void 0 : pluginHooks.map(function (usePluginHook, key) {
+
+  // Key each fiber by the plugin name carried on the hook function (set by
+  // `processPluginsList`). This keeps fibers stable across `reconfigureState`
+  // calls that change the plugin set — keying by array index would let React
+  // reuse the same fiber for a different `usePluginHook`, which calls a
+  // different sequence of hooks (Rules of Hooks violation).
+  // Falls back to the array index for any hook that wasn't annotated.
+  return /*#__PURE__*/_react.default.createElement(_react.default.Fragment, null, pluginHooks === null || pluginHooks === void 0 ? void 0 : pluginHooks.map(function (usePluginHook, index) {
+    var pluginName = usePluginHook.pluginName;
     return /*#__PURE__*/_react.default.createElement(MountPluginHook
-    // Ignored via go/ees005
     // eslint-disable-next-line react/no-array-index-key
     , {
-      key: key,
+      key: pluginName !== null && pluginName !== void 0 ? pluginName : index,
       usePluginHook: usePluginHook,
       editorView: editorView,
       containerElement: containerElement

package/dist/cjs/version-wrapper.js

@@ -5,4 +5,4 @@ Object.defineProperty(exports, "__esModule", {
 });
 exports.version = exports.name = void 0;
 var name = exports.name = "@atlaskit/editor-core";
-var version = exports.version = "219.5.0";
+var version = exports.version = "219.5.1";

package/dist/es2019/create-editor/ReactEditorView.js

@@ -38,6 +38,7 @@ import { PROSEMIRROR_RENDERED_DEGRADED_SEVERITY_THRESHOLD, PROSEMIRROR_RENDERED_
 import { createErrorReporter, createPMPlugins, processPluginsList } from './create-editor';
 import createPluginsList from './create-plugins-list';
 import { createSchema } from './create-schema';
+import { filterPluginsForReconfigure } from './filter-plugins-for-reconfigure';
 import { editorMessages } from './messages';
 import { focusEditorElement } from './ReactEditorView/focusEditorElement';
 import { getUAPrefix } from './ReactEditorView/getUAPrefix';
@@ -336,6 +337,10 @@ export function ReactEditorView(props) {
   // in-place-mutated `config.current` (contentComponents / toolbar
   // components from the rebuilt preset).
   const [, bumpConfigVersion] = useState(0);
+
+  // Preset reference last processed by the schema/API reconciliation below.
+  // Used to skip that work when reconfigure is called with the same preset.
+  const lastFilteredPresetRef = useRef(null);
   const reconfigureState = useCallback(props => {
     if (!viewRef.current) {
       return;
@@ -345,7 +350,44 @@ export function ReactEditorView(props) {
     // so we blur here to stop ProseMirror from trying to apply selection to detached nodes or
     // nodes that haven't been re-rendered to the document yet.
     blur();
-    const editorPlugins = createPluginsList(props.preset, 'allowBlockType' in props.editorProps ? props.editorProps : {}, pluginInjectionAPI.current);
+
+    // Snapshot plugin names registered before createPluginsList runs, so
+    // we can tell which plugins are newly added by the new preset vs.
+    // which ones already coexisted with the current schema.
+    const previousPluginNames = new Set(pluginInjectionAPI.current.getRegisteredPluginNames());
+    let editorPlugins = createPluginsList(props.preset, 'allowBlockType' in props.editorProps ? props.editorProps : {}, pluginInjectionAPI.current);
+
+    // `state.reconfigure` keeps the original schema, so switching presets
+    // can leave the editor inconsistent in two ways:
+    //   1. The new preset may add plugins that reference schema nodes or
+    //      marks the original schema doesn't have.
+    //   2. Plugins registered by a previous preset can linger in the
+    //      injection API even when the new preset doesn't re-register
+    //      them, so listeners still fire against a state that no longer
+    //      has their pmPlugin.
+    if (lastFilteredPresetRef.current !== props.preset && fg('platform_editor_reconfigure_filter_plugins')) {
+      const {
+        kept,
+        dropped
+      } = filterPluginsForReconfigure(editorPlugins, viewRef.current.state.schema, previousPluginNames);
+      editorPlugins = kept;
+
+      // Reconcile the injection API with the post-filter plugin set.
+      // This evicts both the plugins we just dropped above (re-registered
+      // by createPluginsList but no longer in editorPlugins) AND any
+      // plugin from a previous preset that the new preset doesn't
+      // re-register.
+      const keptPluginNames = new Set(editorPlugins.map(p => p === null || p === void 0 ? void 0 : p.name).filter(n => Boolean(n)));
+      const evictedFromApi = pluginInjectionAPI.current.retainPlugins(keptPluginNames);
+      if (dropped.length > 0 || evictedFromApi.length > 0) {
+        // eslint-disable-next-line no-console
+        console.warn('[reconfigureState] Cleanup summary:', {
+          dropped,
+          evictedFromApi
+        });
+      }
+      lastFilteredPresetRef.current = props.preset;
+    }
     config.current = processPluginsList(editorPlugins);
     if (expValEquals('platform_editor_appearance_shared_state', 'isEnabled', true)) {
       config.current.pmPlugins.push(...pluginInjectionAPI.current.getInternalPMPlugins());

package/dist/es2019/create-editor/create-editor.js

@@ -53,7 +53,12 @@ export function processPluginsList(plugins) {
       acc.contentComponents.push(plugin.contentComponent);
     }
     if (plugin.usePluginHook) {
-      acc.pluginHooks.push(plugin.usePluginHook);
+      // Wrap with .bind(null) so we can annotate the function with the
+      // plugin name without mutating the plugin's original hook reference.
+      // MountPluginHooks reads `pluginName` to derive a stable React key.
+      const named = plugin.usePluginHook.bind(null);
+      named.pluginName = plugin.name;
+      acc.pluginHooks.push(named);
     }
     if (plugin.primaryToolbarComponent) {
       acc.primaryToolbarComponents.push(plugin.primaryToolbarComponent);

package/dist/es2019/create-editor/filter-plugins-for-reconfigure.js

@@ -0,0 +1,35 @@
+/**
+ * Used by `reconfigureState` to drop plugins from a freshly-built preset that
+ * declare schema nodes/marks the current schema doesn't have. Plugins already
+ * present before this reconfigure are kept untouched: they have demonstrably
+ * coexisted with the schema (e.g. tests that mock a stripped-down schema), so
+ * removing them now would be a regression.
+ */
+export function filterPluginsForReconfigure(editorPlugins, schema, previousPluginNames) {
+  const availableNodeNames = new Set(Object.keys(schema.nodes));
+  const availableMarkNames = new Set(Object.keys(schema.marks));
+  const dropped = [];
+  const kept = editorPlugins.filter(plugin => {
+    if (!plugin) {
+      return false;
+    }
+    if (previousPluginNames.has(plugin.name)) {
+      return true;
+    }
+    const missingNodes = plugin.nodes ? plugin.nodes().map(n => n.name).filter(n => !availableNodeNames.has(n)) : [];
+    const missingMarks = plugin.marks ? plugin.marks().map(m => m.name).filter(m => !availableMarkNames.has(m)) : [];
+    if (missingNodes.length > 0 || missingMarks.length > 0) {
+      dropped.push({
+        name: plugin.name,
+        missingNodes,
+        missingMarks
+      });
+      return false;
+    }
+    return true;
+  });
+  return {
+    kept,
+    dropped
+  };
+}

package/dist/es2019/test-utils.js

@@ -43,7 +43,9 @@ function lightProcessPluginsList(editorPlugins) {
       acc.contentComponents.push(editorPlugin.contentComponent);
     }
     if (editorPlugin.usePluginHook) {
-      acc.pluginHooks.push(editorPlugin.usePluginHook);
+      const named = editorPlugin.usePluginHook.bind(null);
+      named.pluginName = editorPlugin.name;
+      acc.pluginHooks.push(named);
     }
     if (editorPlugin.onEditorViewStateUpdated) {
       acc.onEditorViewStateUpdatedCallbacks.push(editorPlugin.onEditorViewStateUpdated);

package/dist/es2019/ui/PluginSlot/mount-plugin-hooks.js

@@ -18,13 +18,22 @@ export function MountPluginHooks({
   if (!editorView) {
     return null;
   }
-  return /*#__PURE__*/React.createElement(React.Fragment, null, pluginHooks === null || pluginHooks === void 0 ? void 0 : pluginHooks.map((usePluginHook, key) => /*#__PURE__*/React.createElement(MountPluginHook
-  // Ignored via go/ees005
-  // eslint-disable-next-line react/no-array-index-key
-  , {
-    key: key,
-    usePluginHook: usePluginHook,
-    editorView: editorView,
-    containerElement: containerElement
-  })));
+
+  // Key each fiber by the plugin name carried on the hook function (set by
+  // `processPluginsList`). This keeps fibers stable across `reconfigureState`
+  // calls that change the plugin set — keying by array index would let React
+  // reuse the same fiber for a different `usePluginHook`, which calls a
+  // different sequence of hooks (Rules of Hooks violation).
+  // Falls back to the array index for any hook that wasn't annotated.
+  return /*#__PURE__*/React.createElement(React.Fragment, null, pluginHooks === null || pluginHooks === void 0 ? void 0 : pluginHooks.map((usePluginHook, index) => {
+    const pluginName = usePluginHook.pluginName;
+    return /*#__PURE__*/React.createElement(MountPluginHook
+    // eslint-disable-next-line react/no-array-index-key
+    , {
+      key: pluginName !== null && pluginName !== void 0 ? pluginName : index,
+      usePluginHook: usePluginHook,
+      editorView: editorView,
+      containerElement: containerElement
+    });
+  }));
 }

package/dist/es2019/version-wrapper.js

@@ -1,2 +1,2 @@
 export const name = "@atlaskit/editor-core";
-export const version = "219.5.0";
+export const version = "219.5.1";

package/dist/esm/create-editor/ReactEditorView.js

@@ -46,6 +46,7 @@ import { PROSEMIRROR_RENDERED_DEGRADED_SEVERITY_THRESHOLD, PROSEMIRROR_RENDERED_
 import { createErrorReporter, createPMPlugins, processPluginsList } from './create-editor';
 import createPluginsList from './create-plugins-list';
 import { createSchema } from './create-schema';
+import { filterPluginsForReconfigure } from './filter-plugins-for-reconfigure';
 import { editorMessages } from './messages';
 import { focusEditorElement } from './ReactEditorView/focusEditorElement';
 import { getUAPrefix } from './ReactEditorView/getUAPrefix';
@@ -353,6 +354,10 @@ export function ReactEditorView(props) {
   var _useState = useState(0),
     _useState2 = _slicedToArray(_useState, 2),
     bumpConfigVersion = _useState2[1];
+
+  // Preset reference last processed by the schema/API reconciliation below.
+  // Used to skip that work when reconfigure is called with the same preset.
+  var lastFilteredPresetRef = useRef(null);
   var reconfigureState = useCallback(function (props) {
     if (!viewRef.current) {
       return;
@@ -362,7 +367,47 @@ export function ReactEditorView(props) {
     // so we blur here to stop ProseMirror from trying to apply selection to detached nodes or
     // nodes that haven't been re-rendered to the document yet.
     blur();
+
+    // Snapshot plugin names registered before createPluginsList runs, so
+    // we can tell which plugins are newly added by the new preset vs.
+    // which ones already coexisted with the current schema.
+    var previousPluginNames = new Set(pluginInjectionAPI.current.getRegisteredPluginNames());
     var editorPlugins = createPluginsList(props.preset, 'allowBlockType' in props.editorProps ? props.editorProps : {}, pluginInjectionAPI.current);
+
+    // `state.reconfigure` keeps the original schema, so switching presets
+    // can leave the editor inconsistent in two ways:
+    //   1. The new preset may add plugins that reference schema nodes or
+    //      marks the original schema doesn't have.
+    //   2. Plugins registered by a previous preset can linger in the
+    //      injection API even when the new preset doesn't re-register
+    //      them, so listeners still fire against a state that no longer
+    //      has their pmPlugin.
+    if (lastFilteredPresetRef.current !== props.preset && fg('platform_editor_reconfigure_filter_plugins')) {
+      var _filterPluginsForReco = filterPluginsForReconfigure(editorPlugins, viewRef.current.state.schema, previousPluginNames),
+        kept = _filterPluginsForReco.kept,
+        dropped = _filterPluginsForReco.dropped;
+      editorPlugins = kept;
+
+      // Reconcile the injection API with the post-filter plugin set.
+      // This evicts both the plugins we just dropped above (re-registered
+      // by createPluginsList but no longer in editorPlugins) AND any
+      // plugin from a previous preset that the new preset doesn't
+      // re-register.
+      var keptPluginNames = new Set(editorPlugins.map(function (p) {
+        return p === null || p === void 0 ? void 0 : p.name;
+      }).filter(function (n) {
+        return Boolean(n);
+      }));
+      var evictedFromApi = pluginInjectionAPI.current.retainPlugins(keptPluginNames);
+      if (dropped.length > 0 || evictedFromApi.length > 0) {
+        // eslint-disable-next-line no-console
+        console.warn('[reconfigureState] Cleanup summary:', {
+          dropped: dropped,
+          evictedFromApi: evictedFromApi
+        });
+      }
+      lastFilteredPresetRef.current = props.preset;
+    }
     config.current = processPluginsList(editorPlugins);
     if (expValEquals('platform_editor_appearance_shared_state', 'isEnabled', true)) {
       var _config$current$pmPlu2;

package/dist/esm/create-editor/create-editor.js

@@ -61,7 +61,12 @@ export function processPluginsList(plugins) {
       acc.contentComponents.push(plugin.contentComponent);
     }
     if (plugin.usePluginHook) {
-      acc.pluginHooks.push(plugin.usePluginHook);
+      // Wrap with .bind(null) so we can annotate the function with the
+      // plugin name without mutating the plugin's original hook reference.
+      // MountPluginHooks reads `pluginName` to derive a stable React key.
+      var named = plugin.usePluginHook.bind(null);
+      named.pluginName = plugin.name;
+      acc.pluginHooks.push(named);
     }
     if (plugin.primaryToolbarComponent) {
       acc.primaryToolbarComponents.push(plugin.primaryToolbarComponent);

package/dist/esm/create-editor/filter-plugins-for-reconfigure.js

@@ -0,0 +1,43 @@
+/**
+ * Used by `reconfigureState` to drop plugins from a freshly-built preset that
+ * declare schema nodes/marks the current schema doesn't have. Plugins already
+ * present before this reconfigure are kept untouched: they have demonstrably
+ * coexisted with the schema (e.g. tests that mock a stripped-down schema), so
+ * removing them now would be a regression.
+ */
+export function filterPluginsForReconfigure(editorPlugins, schema, previousPluginNames) {
+  var availableNodeNames = new Set(Object.keys(schema.nodes));
+  var availableMarkNames = new Set(Object.keys(schema.marks));
+  var dropped = [];
+  var kept = editorPlugins.filter(function (plugin) {
+    if (!plugin) {
+      return false;
+    }
+    if (previousPluginNames.has(plugin.name)) {
+      return true;
+    }
+    var missingNodes = plugin.nodes ? plugin.nodes().map(function (n) {
+      return n.name;
+    }).filter(function (n) {
+      return !availableNodeNames.has(n);
+    }) : [];
+    var missingMarks = plugin.marks ? plugin.marks().map(function (m) {
+      return m.name;
+    }).filter(function (m) {
+      return !availableMarkNames.has(m);
+    }) : [];
+    if (missingNodes.length > 0 || missingMarks.length > 0) {
+      dropped.push({
+        name: plugin.name,
+        missingNodes: missingNodes,
+        missingMarks: missingMarks
+      });
+      return false;
+    }
+    return true;
+  });
+  return {
+    kept: kept,
+    dropped: dropped
+  };
+}

package/dist/esm/test-utils.js

@@ -50,7 +50,9 @@ function lightProcessPluginsList(editorPlugins) {
       acc.contentComponents.push(editorPlugin.contentComponent);
     }
     if (editorPlugin.usePluginHook) {
-      acc.pluginHooks.push(editorPlugin.usePluginHook);
+      var named = editorPlugin.usePluginHook.bind(null);
+      named.pluginName = editorPlugin.name;
+      acc.pluginHooks.push(named);
     }
     if (editorPlugin.onEditorViewStateUpdated) {
       acc.onEditorViewStateUpdatedCallbacks.push(editorPlugin.onEditorViewStateUpdated);

package/dist/esm/ui/PluginSlot/mount-plugin-hooks.js

@@ -16,12 +16,19 @@ export function MountPluginHooks(_ref2) {
   if (!editorView) {
     return null;
   }
-  return /*#__PURE__*/React.createElement(React.Fragment, null, pluginHooks === null || pluginHooks === void 0 ? void 0 : pluginHooks.map(function (usePluginHook, key) {
+
+  // Key each fiber by the plugin name carried on the hook function (set by
+  // `processPluginsList`). This keeps fibers stable across `reconfigureState`
+  // calls that change the plugin set — keying by array index would let React
+  // reuse the same fiber for a different `usePluginHook`, which calls a
+  // different sequence of hooks (Rules of Hooks violation).
+  // Falls back to the array index for any hook that wasn't annotated.
+  return /*#__PURE__*/React.createElement(React.Fragment, null, pluginHooks === null || pluginHooks === void 0 ? void 0 : pluginHooks.map(function (usePluginHook, index) {
+    var pluginName = usePluginHook.pluginName;
     return /*#__PURE__*/React.createElement(MountPluginHook
-    // Ignored via go/ees005
     // eslint-disable-next-line react/no-array-index-key
     , {
-      key: key,
+      key: pluginName !== null && pluginName !== void 0 ? pluginName : index,
       usePluginHook: usePluginHook,
       editorView: editorView,
       containerElement: containerElement

package/dist/esm/version-wrapper.js

@@ -1,2 +1,2 @@
 export var name = "@atlaskit/editor-core";
-export var version = "219.5.0";
+export var version = "219.5.1";

package/dist/types/create-editor/filter-plugins-for-reconfigure.d.ts

@@ -0,0 +1,19 @@
+import type { EditorPlugin } from '@atlaskit/editor-common/types';
+import type { Schema } from '@atlaskit/editor-prosemirror/model';
+export interface DroppedPlugin {
+    missingMarks: string[];
+    missingNodes: string[];
+    name: string;
+}
+export interface FilterPluginsForReconfigureResult {
+    dropped: DroppedPlugin[];
+    kept: EditorPlugin[];
+}
+/**
+ * Used by `reconfigureState` to drop plugins from a freshly-built preset that
+ * declare schema nodes/marks the current schema doesn't have. Plugins already
+ * present before this reconfigure are kept untouched: they have demonstrably
+ * coexisted with the schema (e.g. tests that mock a stripped-down schema), so
+ * removing them now would be a regression.
+ */
+export declare function filterPluginsForReconfigure(editorPlugins: Array<EditorPlugin | undefined | null>, schema: Schema, previousPluginNames: ReadonlySet<string>): FilterPluginsForReconfigureResult;

package/dist/types/ui/PluginSlot/mount-plugin-hooks.d.ts

@@ -1,10 +1,10 @@
 import React from 'react';
-import type { ReactHookFactory } from '@atlaskit/editor-common/types';
+import type { NamedReactHookFactory } from '@atlaskit/editor-common/types';
 import type { EditorView } from '@atlaskit/editor-prosemirror/view';
 interface MountPluginHooksProps {
     containerElement: HTMLElement | null;
     editorView: EditorView | undefined;
-    pluginHooks: ReactHookFactory[] | undefined;
+    pluginHooks: NamedReactHookFactory[] | undefined;
 }
 export declare function MountPluginHooks({ pluginHooks, editorView, containerElement, }: MountPluginHooksProps): React.JSX.Element | null;
 export {};

package/dist/types-ts4.5/create-editor/filter-plugins-for-reconfigure.d.ts

@@ -0,0 +1,19 @@
+import type { EditorPlugin } from '@atlaskit/editor-common/types';
+import type { Schema } from '@atlaskit/editor-prosemirror/model';
+export interface DroppedPlugin {
+    missingMarks: string[];
+    missingNodes: string[];
+    name: string;
+}
+export interface FilterPluginsForReconfigureResult {
+    dropped: DroppedPlugin[];
+    kept: EditorPlugin[];
+}
+/**
+ * Used by `reconfigureState` to drop plugins from a freshly-built preset that
+ * declare schema nodes/marks the current schema doesn't have. Plugins already
+ * present before this reconfigure are kept untouched: they have demonstrably
+ * coexisted with the schema (e.g. tests that mock a stripped-down schema), so
+ * removing them now would be a regression.
+ */
+export declare function filterPluginsForReconfigure(editorPlugins: Array<EditorPlugin | undefined | null>, schema: Schema, previousPluginNames: ReadonlySet<string>): FilterPluginsForReconfigureResult;

package/dist/types-ts4.5/ui/PluginSlot/mount-plugin-hooks.d.ts

@@ -1,10 +1,10 @@
 import React from 'react';
-import type { ReactHookFactory } from '@atlaskit/editor-common/types';
+import type { NamedReactHookFactory } from '@atlaskit/editor-common/types';
 import type { EditorView } from '@atlaskit/editor-prosemirror/view';
 interface MountPluginHooksProps {
     containerElement: HTMLElement | null;
     editorView: EditorView | undefined;
-    pluginHooks: ReactHookFactory[] | undefined;
+    pluginHooks: NamedReactHookFactory[] | undefined;
 }
 export declare function MountPluginHooks({ pluginHooks, editorView, containerElement, }: MountPluginHooksProps): React.JSX.Element | null;
 export {};

package/package.json

@@ -1,6 +1,6 @@
 {
 	"name": "@atlaskit/editor-core",
-	"version": "219.5.1",
+	"version": "219.6.0",
 	"description": "A package contains Atlassian editor core functionality",
 	"publishConfig": {
 		"registry": "https://registry.npmjs.org/"
@@ -64,7 +64,7 @@
 		"@atlaskit/editor-ssr-renderer": "^5.1.0",
 		"@atlaskit/editor-toolbar": "^1.0.0",
 		"@atlaskit/editor-toolbar-model": "^0.4.0",
-		"@atlaskit/emoji": "^70.4.0",
+		"@atlaskit/emoji": "^70.5.0",
 		"@atlaskit/feature-gate-js-client": "^5.5.0",
 		"@atlaskit/icon": "^34.5.0",
 		"@atlaskit/link": "^3.4.0",
@@ -92,7 +92,7 @@
 		"uuid": "^3.1.0"
 	},
 	"peerDependencies": {
-		"@atlaskit/editor-common": "^114.26.0",
+		"@atlaskit/editor-common": "^114.27.0",
 		"@atlaskit/link-provider": "^4.4.0",
 		"@atlaskit/media-core": "^37.0.0",
 		"react": "^18.2.0",
@@ -106,7 +106,7 @@
 		"@atlaskit/adf-utils": "^19.29.0",
 		"@atlaskit/analytics-listeners": "^10.0.0",
 		"@atlaskit/collab-provider": "^18.2.0",
-		"@atlaskit/editor-plugin-annotation": "^10.2.0",
+		"@atlaskit/editor-plugin-annotation": "^10.3.0",
 		"@atlaskit/editor-plugin-card": "^16.5.0",
 		"@atlaskit/editor-plugin-list": "^12.0.0",
 		"@atlaskit/editor-plugin-paste": "^11.1.0",
@@ -167,6 +167,9 @@
 		}
 	},
 	"platform-feature-flags": {
+		"platform_editor_reconfigure_filter_plugins": {
+			"type": "boolean"
+		},
 		"linking_platform_datasource_assets_objects": {
 			"type": "boolean",
 			"referenceOnly": "true"