@atlaskit/editor-core 219.1.11 → 219.1.13

package/CHANGELOG.md

@@ -1,5 +1,29 @@
 # @atlaskit/editor-core
 
+## 219.1.13
+
+### Patch Changes
+
+- Updated dependencies
+
+## 219.1.12
+
+### Patch Changes
+
+- [`673df46586c14`](https://bitbucket.org/atlassian/atlassian-frontend-monorepo/commits/673df46586c14) -
+  Fix `contentComponents` / `primaryToolbarComponents` going stale after a preset reconfigure.
+
+  `ReactEditorView.reconfigureState` mutates `config.current` (a `useRef`) but didn't schedule a
+  re-render, so the `render` prop kept passing the pre-reconfigure component arrays to the editor's
+  `AppearanceComponent`. Plugins added via reconfigure (e.g. `markdownModePlugin` flipping in via
+  `.maybeAdd(..., isMarkdownMode)`) had their `contentComponent` / `primaryToolbarComponent` ignored
+  until some unrelated state change (focus, selection) re-rendered the editor view. Now bumps a
+  state counter at the end of `reconfigureState` to trigger a follow-up render with the
+  freshly-mutated config. Gated on the `cc-markdown-mode` experiment for now since that's the only
+  known consumer flipping plugins via `.maybeAdd` mid-life.
+
+- Updated dependencies
+
 ## 219.1.11
 
 ### Patch Changes

package/dist/cjs/create-editor/ReactEditorView.js

@@ -7,8 +7,8 @@ Object.defineProperty(exports, "__esModule", {
 });
 exports.ReactEditorView = ReactEditorView;
 exports.default = void 0;
-var _slicedToArray2 = _interopRequireDefault(require("@babel/runtime/helpers/slicedToArray"));
 var _defineProperty2 = _interopRequireDefault(require("@babel/runtime/helpers/defineProperty"));
+var _slicedToArray2 = _interopRequireDefault(require("@babel/runtime/helpers/slicedToArray"));
 var _toConsumableArray2 = _interopRequireDefault(require("@babel/runtime/helpers/toConsumableArray"));
 var _react = _interopRequireWildcard(require("react"));
 var _reactIntl = require("react-intl");
@@ -35,6 +35,7 @@ var _platformFeatureFlags = require("@atlaskit/platform-feature-flags");
 var _interactionIdContext = require("@atlaskit/react-ufo/interaction-id-context");
 var _interactionMetrics = require("@atlaskit/react-ufo/interaction-metrics");
 var _expValEquals = require("@atlaskit/tmp-editor-statsig/exp-val-equals");
+var _expValEqualsNoExposure = require("@atlaskit/tmp-editor-statsig/exp-val-equals-no-exposure");
 var _useProviders = require("../composable-editor/hooks/useProviders");
 var _featureFlagsFromProps = require("../utils/feature-flags-from-props");
 var _getNodesCount = require("../utils/getNodesCount");
@@ -354,6 +355,13 @@ function ReactEditorView(props) {
       // this.view will be destroyed when React unmounts in handleEditorViewRef
     };
   }, [eventDispatcher]);
+
+  // Bumped after `reconfigureState` so the render prop re-reads the
+  // in-place-mutated `config.current` (contentComponents / toolbar
+  // components from the rebuilt preset).
+  var _useState = (0, _react.useState)(0),
+    _useState2 = (0, _slicedToArray2.default)(_useState, 2),
+    bumpConfigVersion = _useState2[1];
   var reconfigureState = (0, _react.useCallback)(function (props) {
     if (!viewRef.current) {
       return;
@@ -393,9 +401,18 @@ function ReactEditorView(props) {
     // need to update the state first so when the view builds the nodeviews it is
     // using the latest plugins
     viewRef.current.updateState(newState);
-    return viewRef.current.update(_objectSpread(_objectSpread({}, viewRef.current.props), {}, {
+    var result = viewRef.current.update(_objectSpread(_objectSpread({}, viewRef.current.props), {}, {
       state: newState
     }));
+
+    // EDITOR-6702: gated until we have a broader gate; reconfigure is a
+    // low-level path so use NoExposure.
+    if ((0, _expValEqualsNoExposure.expValEqualsNoExposure)('cc-markdown-mode', 'isEnabled', true)) {
+      bumpConfigVersion(function (v) {
+        return v + 1;
+      });
+    }
+    return result;
   }, [blur, dispatchAnalyticsEvent, eventDispatcher, dispatch, errorReporter, featureFlags]);
   var onEditorViewUpdated = (0, _react.useCallback)(function (_ref2) {
     var _config$current;
@@ -581,10 +598,10 @@ function ReactEditorView(props) {
     });
     return view;
   }, [getDirectEditorProps, dispatchAnalyticsEvent]);
-  var _useState = (0, _react.useState)(undefined),
-    _useState2 = (0, _slicedToArray2.default)(_useState, 2),
-    editorView = _useState2[0],
-    setEditorView = _useState2[1];
+  var _useState3 = (0, _react.useState)(undefined),
+    _useState4 = (0, _slicedToArray2.default)(_useState3, 2),
+    editorView = _useState4[0],
+    setEditorView = _useState4[1];
 
   // Detects if the editor is nested inside an extension - ie. it is a Legacy Content Extension (LCE)
   var isNestedEditor = (0, _react.useRef)(null);

package/dist/cjs/version-wrapper.js

@@ -5,4 +5,4 @@ Object.defineProperty(exports, "__esModule", {
 });
 exports.version = exports.name = void 0;
 var name = exports.name = "@atlaskit/editor-core";
-var version = exports.version = "0.0.0-development";
+var version = exports.version = "219.1.12";

package/dist/es2019/create-editor/ReactEditorView.js

@@ -24,6 +24,7 @@ import { fg } from '@atlaskit/platform-feature-flags';
 import { getInteractionId } from '@atlaskit/react-ufo/interaction-id-context';
 import { abortAll, getActiveInteraction } from '@atlaskit/react-ufo/interaction-metrics';
 import { expValEquals } from '@atlaskit/tmp-editor-statsig/exp-val-equals';
+import { expValEqualsNoExposure } from '@atlaskit/tmp-editor-statsig/exp-val-equals-no-exposure';
 import { useProviders } from '../composable-editor/hooks/useProviders';
 import { createFeatureFlagsFromProps } from '../utils/feature-flags-from-props';
 import { getNodesCount } from '../utils/getNodesCount';
@@ -330,6 +331,11 @@ export function ReactEditorView(props) {
       // this.view will be destroyed when React unmounts in handleEditorViewRef
     };
   }, [eventDispatcher]);
+
+  // Bumped after `reconfigureState` so the render prop re-reads the
+  // in-place-mutated `config.current` (contentComponents / toolbar
+  // components from the rebuilt preset).
+  const [, bumpConfigVersion] = useState(0);
   const reconfigureState = useCallback(props => {
     if (!viewRef.current) {
       return;
@@ -366,10 +372,17 @@ export function ReactEditorView(props) {
     // need to update the state first so when the view builds the nodeviews it is
     // using the latest plugins
     viewRef.current.updateState(newState);
-    return viewRef.current.update({
+    const result = viewRef.current.update({
       ...viewRef.current.props,
       state: newState
     });
+
+    // EDITOR-6702: gated until we have a broader gate; reconfigure is a
+    // low-level path so use NoExposure.
+    if (expValEqualsNoExposure('cc-markdown-mode', 'isEnabled', true)) {
+      bumpConfigVersion(v => v + 1);
+    }
+    return result;
   }, [blur, dispatchAnalyticsEvent, eventDispatcher, dispatch, errorReporter, featureFlags]);
   const onEditorViewUpdated = useCallback(({
     originalTransaction,

package/dist/es2019/version-wrapper.js

@@ -1,2 +1,2 @@
 export const name = "@atlaskit/editor-core";
-export const version = "0.0.0-development";
+export const version = "219.1.12";

package/dist/esm/create-editor/ReactEditorView.js

@@ -1,5 +1,5 @@
-import _slicedToArray from "@babel/runtime/helpers/slicedToArray";
 import _defineProperty from "@babel/runtime/helpers/defineProperty";
+import _slicedToArray from "@babel/runtime/helpers/slicedToArray";
 import _toConsumableArray from "@babel/runtime/helpers/toConsumableArray";
 function _createForOfIteratorHelper(r, e) { var t = "undefined" != typeof Symbol && r[Symbol.iterator] || r["@@iterator"]; if (!t) { if (Array.isArray(r) || (t = _unsupportedIterableToArray(r)) || e && r && "number" == typeof r.length) { t && (r = t); var _n = 0, F = function F() {}; return { s: F, n: function n() { return _n >= r.length ? { done: !0 } : { done: !1, value: r[_n++] }; }, e: function e(r) { throw r; }, f: F }; } throw new TypeError("Invalid attempt to iterate non-iterable instance.\nIn order to be iterable, non-array objects must have a [Symbol.iterator]() method."); } var o, a = !0, u = !1; return { s: function s() { t = t.call(r); }, n: function n() { var r = t.next(); return a = r.done, r; }, e: function e(r) { u = !0, o = r; }, f: function f() { try { a || null == t.return || t.return(); } finally { if (u) throw o; } } }; }
 function _unsupportedIterableToArray(r, a) { if (r) { if ("string" == typeof r) return _arrayLikeToArray(r, a); var t = {}.toString.call(r).slice(8, -1); return "Object" === t && r.constructor && (t = r.constructor.name), "Map" === t || "Set" === t ? Array.from(r) : "Arguments" === t || /^(?:Ui|I)nt(?:8|16|32)(?:Clamped)?Array$/.test(t) ? _arrayLikeToArray(r, a) : void 0; } }
@@ -32,6 +32,7 @@ import { fg } from '@atlaskit/platform-feature-flags';
 import { getInteractionId } from '@atlaskit/react-ufo/interaction-id-context';
 import { abortAll, getActiveInteraction } from '@atlaskit/react-ufo/interaction-metrics';
 import { expValEquals } from '@atlaskit/tmp-editor-statsig/exp-val-equals';
+import { expValEqualsNoExposure } from '@atlaskit/tmp-editor-statsig/exp-val-equals-no-exposure';
 import { useProviders } from '../composable-editor/hooks/useProviders';
 import { createFeatureFlagsFromProps } from '../utils/feature-flags-from-props';
 import { getNodesCount } from '../utils/getNodesCount';
@@ -345,6 +346,13 @@ export function ReactEditorView(props) {
       // this.view will be destroyed when React unmounts in handleEditorViewRef
     };
   }, [eventDispatcher]);
+
+  // Bumped after `reconfigureState` so the render prop re-reads the
+  // in-place-mutated `config.current` (contentComponents / toolbar
+  // components from the rebuilt preset).
+  var _useState = useState(0),
+    _useState2 = _slicedToArray(_useState, 2),
+    bumpConfigVersion = _useState2[1];
   var reconfigureState = useCallback(function (props) {
     if (!viewRef.current) {
       return;
@@ -384,9 +392,18 @@ export function ReactEditorView(props) {
     // need to update the state first so when the view builds the nodeviews it is
     // using the latest plugins
     viewRef.current.updateState(newState);
-    return viewRef.current.update(_objectSpread(_objectSpread({}, viewRef.current.props), {}, {
+    var result = viewRef.current.update(_objectSpread(_objectSpread({}, viewRef.current.props), {}, {
       state: newState
     }));
+
+    // EDITOR-6702: gated until we have a broader gate; reconfigure is a
+    // low-level path so use NoExposure.
+    if (expValEqualsNoExposure('cc-markdown-mode', 'isEnabled', true)) {
+      bumpConfigVersion(function (v) {
+        return v + 1;
+      });
+    }
+    return result;
   }, [blur, dispatchAnalyticsEvent, eventDispatcher, dispatch, errorReporter, featureFlags]);
   var onEditorViewUpdated = useCallback(function (_ref2) {
     var _config$current;
@@ -572,10 +589,10 @@ export function ReactEditorView(props) {
     });
     return view;
   }, [getDirectEditorProps, dispatchAnalyticsEvent]);
-  var _useState = useState(undefined),
-    _useState2 = _slicedToArray(_useState, 2),
-    editorView = _useState2[0],
-    setEditorView = _useState2[1];
+  var _useState3 = useState(undefined),
+    _useState4 = _slicedToArray(_useState3, 2),
+    editorView = _useState4[0],
+    setEditorView = _useState4[1];
 
   // Detects if the editor is nested inside an extension - ie. it is a Legacy Content Extension (LCE)
   var isNestedEditor = useRef(null);

package/dist/esm/version-wrapper.js

@@ -1,2 +1,2 @@
 export var name = "@atlaskit/editor-core";
-export var version = "0.0.0-development";
+export var version = "219.1.12";

package/package.json

@@ -1,6 +1,6 @@
 {
 	"name": "@atlaskit/editor-core",
-	"version": "219.1.11",
+	"version": "219.1.13",
 	"description": "A package contains Atlassian editor core functionality",
 	"publishConfig": {
 		"registry": "https://registry.npmjs.org/"
@@ -46,7 +46,7 @@
 	},
 	"dependencies": {
 		"@atlaskit/activity-provider": "^2.5.0",
-		"@atlaskit/adf-schema": "^52.6.0",
+		"@atlaskit/adf-schema": "^52.7.0",
 		"@atlaskit/afm-i18n-platform-editor-editor-core": "2.10.0",
 		"@atlaskit/analytics-namespaced-context": "^7.2.0",
 		"@atlaskit/analytics-next": "^11.2.0",
@@ -58,7 +58,7 @@
 		"@atlaskit/editor-plugin-connectivity": "^10.0.0",
 		"@atlaskit/editor-plugin-quick-insert": "^10.2.0",
 		"@atlaskit/editor-plugin-user-preferences": "^8.0.0",
-		"@atlaskit/editor-plugins": "^13.0.0",
+		"@atlaskit/editor-plugins": "^13.1.0",
 		"@atlaskit/editor-prosemirror": "^7.3.0",
 		"@atlaskit/editor-shared-styles": "^3.10.0",
 		"@atlaskit/editor-ssr-renderer": "^5.1.0",
@@ -68,13 +68,13 @@
 		"@atlaskit/feature-gate-js-client": "^5.5.0",
 		"@atlaskit/icon": "^34.3.0",
 		"@atlaskit/link": "^3.4.0",
-		"@atlaskit/media-card": "^80.3.0",
+		"@atlaskit/media-card": "^80.4.0",
 		"@atlaskit/mention": "^25.0.0",
 		"@atlaskit/platform-feature-flags": "^1.1.0",
 		"@atlaskit/platform-feature-flags-react": "^0.4.0",
-		"@atlaskit/react-ufo": "^5.17.0",
+		"@atlaskit/react-ufo": "^5.18.0",
 		"@atlaskit/task-decision": "^20.0.0",
-		"@atlaskit/tmp-editor-statsig": "^73.0.0",
+		"@atlaskit/tmp-editor-statsig": "^74.0.0",
 		"@atlaskit/tokens": "^13.0.0",
 		"@atlaskit/tooltip": "^21.2.0",
 		"@atlaskit/width-detector": "^5.1.0",
@@ -91,7 +91,7 @@
 		"uuid": "^3.1.0"
 	},
 	"peerDependencies": {
-		"@atlaskit/editor-common": "^114.13.0",
+		"@atlaskit/editor-common": "^114.15.0",
 		"@atlaskit/link-provider": "^4.3.0",
 		"@atlaskit/media-core": "^37.0.0",
 		"react": "^18.2.0",
@@ -102,7 +102,7 @@
 		"@af/editor-libra": "workspace:^",
 		"@af/suppress-react-warnings": "workspace:^",
 		"@af/visual-regression": "workspace:^",
-		"@atlaskit/adf-utils": "^19.27.0",
+		"@atlaskit/adf-utils": "^19.28.0",
 		"@atlaskit/analytics-listeners": "^10.0.0",
 		"@atlaskit/collab-provider": "^18.1.0",
 		"@atlaskit/editor-plugin-annotation": "^10.1.0",
@@ -128,7 +128,7 @@
 		"@atlassian/editor-rovo-bridge": "^8.4.0",
 		"@atlassian/feature-flags-test-utils": "^1.0.0",
 		"@atlassian/react-compiler-gating": "workspace:^",
-		"@atlassian/search-client": "^1.5.0",
+		"@atlassian/search-client": "^1.6.0",
 		"@atlassian/search-provider": "^11.0.0",
 		"@atlassian/structured-docs-types": "workspace:^",
 		"@emotion/jest": "^11.8.0",