@atlaskit/editor-core 217.12.8 → 217.12.10

This diff represents the content of publicly available package versions that have been released to one of the supported registries. The information contained in this diff is provided for informational purposes only and reflects changes between package versions as they appear in their respective public registries.
package/CHANGELOG.md CHANGED
@@ -1,5 +1,36 @@
1
1
  # @atlaskit/editor-core
2
2
 
3
+ ## 217.12.10
4
+
5
+ ### Patch Changes
6
+
7
+ - [`0ad738e8f896e`](https://bitbucket.org/atlassian/atlassian-frontend-monorepo/commits/0ad738e8f896e) -
8
+ Remove `support_table_in_comment` and `support_table_in_comment_jira` experiment references. Both
9
+ experiments are fully rolled out — table resizing, alignment, scaling, and distribute columns are
10
+ now enabled unconditionally in comment editors.
11
+ - Updated dependencies
12
+
13
+ ## 217.12.9
14
+
15
+ ### Patch Changes
16
+
17
+ - [`a9fb116e4a8d8`](https://bitbucket.org/atlassian/atlassian-frontend-monorepo/commits/a9fb116e4a8d8) -
18
+ fix(editor): fix paragraph nodes not highlighting on hover over block menu delete action
19
+
20
+ Two root causes fixed:
21
+ 1. CSS danger styles were gated behind
22
+ `expValNoExposure('platform_editor_block_menu', 'isEnabled', false)`, meaning they were
23
+ excluded when the new block menu was enabled. Removed the gate so danger styles are always
24
+ injected.
25
+
26
+ 2. `hoverDecorationCommand` used `tr.selection` directly, which for paragraphs is a collapsed
27
+ `TextSelection` (cursor inside text). This caused `getSourceNodesFromSelectionRange` to return
28
+ an empty array, so no decorations were created. Fixed by passing `preservedSelection` (a
29
+ `NodeSelection` pointing at the whole paragraph node) from `blockControls` shared state through
30
+ to `hoverDecoration`.
31
+
32
+ - Updated dependencies
33
+
3
34
  ## 217.12.8
4
35
 
5
36
  ### Patch Changes
@@ -163,16 +163,7 @@ function createUniversalPresetInternal(_ref) {
163
163
  emojiProvider: props.emojiProvider
164
164
  }, initialPluginConfiguration === null || initialPluginConfiguration === void 0 ? void 0 : initialPluginConfiguration.emojiPlugin)], Boolean(props.emojiProvider)).maybeAdd([_table.tablesPlugin, {
165
165
  tableOptions: !props.allowTables || typeof props.allowTables === 'boolean' ? {} : props.allowTables,
166
- dragAndDropEnabled: (featureFlags === null || featureFlags === void 0 ? void 0 : featureFlags.tableDragAndDrop) && (isFullPage || (isComment || isChromeless) && (0, _experiments.editorExperiment)('support_table_in_comment', true, {
167
- exposure: true
168
- })) || isComment && (0, _experiments.editorExperiment)('support_table_in_comment_jira', true, {
169
- exposure: true
170
- }),
171
- isTableScalingEnabled: isFullPage || isComment && (0, _experiments.editorExperiment)('support_table_in_comment', true, {
172
- exposure: true
173
- }) || isComment && (0, _experiments.editorExperiment)('support_table_in_comment_jira', true, {
174
- exposure: true
175
- }),
166
+ isTableScalingEnabled: isFullPage || isComment,
176
167
  allowContextualMenu: true,
177
168
  fullWidthEnabled: appearance === 'full-width',
178
169
  wasFullWidthEnabled: prevAppearance && prevAppearance === 'full-width',
@@ -15,7 +15,6 @@ var _platformFeatureFlags = require("@atlaskit/platform-feature-flags");
15
15
  var _expValEquals = require("@atlaskit/tmp-editor-statsig/exp-val-equals");
16
16
  var _expValEqualsNoExposure = require("@atlaskit/tmp-editor-statsig/exp-val-equals-no-exposure");
17
17
  var _experiments = require("@atlaskit/tmp-editor-statsig/experiments");
18
- var _expVal = require("@atlaskit/tmp-editor-statsig/expVal");
19
18
  var _tokens = require("@atlaskit/tokens");
20
19
  var _getBaseFontSize = require("../../composable-editor/utils/getBaseFontSize");
21
20
  var _aiPanel = require("./styles/aiPanel");
@@ -539,7 +538,7 @@ var EditorContentContainer = /*#__PURE__*/_react.default.forwardRef(function (pr
539
538
  // eslint-disable-next-line @atlaskit/ui-styling-standard/no-imported-style-values
540
539
  _selectionToolbarStyles.selectionToolbarAnimationStyles,
541
540
  // eslint-disable-next-line @atlaskit/ui-styling-standard/no-imported-style-values
542
- (0, _expVal.expValNoExposure)('platform_editor_block_menu', 'isEnabled', false) && [
541
+ (0, _experiments.editorExperiment)('platform_editor_block_menu', true) && [
543
542
  // eslint-disable-next-line @atlaskit/ui-styling-standard/no-imported-style-values
544
543
  _blockTypeStyles.blockquoteDangerStyles,
545
544
  // eslint-disable-next-line @atlaskit/ui-styling-standard/no-imported-style-values
@@ -5,4 +5,4 @@ Object.defineProperty(exports, "__esModule", {
5
5
  });
6
6
  exports.version = exports.name = void 0;
7
7
  var name = exports.name = "@atlaskit/editor-core";
8
- var version = exports.version = "217.12.8";
8
+ var version = exports.version = "217.12.9";
@@ -159,16 +159,7 @@ export default function createUniversalPresetInternal({
159
159
  ...(initialPluginConfiguration === null || initialPluginConfiguration === void 0 ? void 0 : initialPluginConfiguration.emojiPlugin)
160
160
  }], Boolean(props.emojiProvider)).maybeAdd([tablesPlugin, {
161
161
  tableOptions: !props.allowTables || typeof props.allowTables === 'boolean' ? {} : props.allowTables,
162
- dragAndDropEnabled: (featureFlags === null || featureFlags === void 0 ? void 0 : featureFlags.tableDragAndDrop) && (isFullPage || (isComment || isChromeless) && editorExperiment('support_table_in_comment', true, {
163
- exposure: true
164
- })) || isComment && editorExperiment('support_table_in_comment_jira', true, {
165
- exposure: true
166
- }),
167
- isTableScalingEnabled: isFullPage || isComment && editorExperiment('support_table_in_comment', true, {
168
- exposure: true
169
- }) || isComment && editorExperiment('support_table_in_comment_jira', true, {
170
- exposure: true
171
- }),
162
+ isTableScalingEnabled: isFullPage || isComment,
172
163
  allowContextualMenu: true,
173
164
  fullWidthEnabled: appearance === 'full-width',
174
165
  wasFullWidthEnabled: prevAppearance && prevAppearance === 'full-width',
@@ -14,7 +14,6 @@ import { fg } from '@atlaskit/platform-feature-flags';
14
14
  import { expValEquals } from '@atlaskit/tmp-editor-statsig/exp-val-equals';
15
15
  import { expValEqualsNoExposure } from '@atlaskit/tmp-editor-statsig/exp-val-equals-no-exposure';
16
16
  import { editorExperiment } from '@atlaskit/tmp-editor-statsig/experiments';
17
- import { expValNoExposure } from '@atlaskit/tmp-editor-statsig/expVal';
18
17
  import { useThemeObserver } from '@atlaskit/tokens';
19
18
  import { getBaseFontSize } from '../../composable-editor/utils/getBaseFontSize';
20
19
  import { aiPanelBaseFirefoxStyles, aiPanelBaseStyles, aiPanelDarkFirefoxStyles, aiPanelDarkStyles } from './styles/aiPanel';
@@ -535,7 +534,7 @@ const EditorContentContainer = /*#__PURE__*/React.forwardRef((props, ref) => {
535
534
  // eslint-disable-next-line @atlaskit/ui-styling-standard/no-imported-style-values
536
535
  selectionToolbarAnimationStyles,
537
536
  // eslint-disable-next-line @atlaskit/ui-styling-standard/no-imported-style-values
538
- expValNoExposure('platform_editor_block_menu', 'isEnabled', false) && [
537
+ editorExperiment('platform_editor_block_menu', true) && [
539
538
  // eslint-disable-next-line @atlaskit/ui-styling-standard/no-imported-style-values
540
539
  blockquoteDangerStyles,
541
540
  // eslint-disable-next-line @atlaskit/ui-styling-standard/no-imported-style-values
@@ -1,2 +1,2 @@
1
1
  export const name = "@atlaskit/editor-core";
2
- export const version = "217.12.8";
2
+ export const version = "217.12.9";
@@ -156,16 +156,7 @@ export default function createUniversalPresetInternal(_ref) {
156
156
  emojiProvider: props.emojiProvider
157
157
  }, initialPluginConfiguration === null || initialPluginConfiguration === void 0 ? void 0 : initialPluginConfiguration.emojiPlugin)], Boolean(props.emojiProvider)).maybeAdd([tablesPlugin, {
158
158
  tableOptions: !props.allowTables || typeof props.allowTables === 'boolean' ? {} : props.allowTables,
159
- dragAndDropEnabled: (featureFlags === null || featureFlags === void 0 ? void 0 : featureFlags.tableDragAndDrop) && (isFullPage || (isComment || isChromeless) && editorExperiment('support_table_in_comment', true, {
160
- exposure: true
161
- })) || isComment && editorExperiment('support_table_in_comment_jira', true, {
162
- exposure: true
163
- }),
164
- isTableScalingEnabled: isFullPage || isComment && editorExperiment('support_table_in_comment', true, {
165
- exposure: true
166
- }) || isComment && editorExperiment('support_table_in_comment_jira', true, {
167
- exposure: true
168
- }),
159
+ isTableScalingEnabled: isFullPage || isComment,
169
160
  allowContextualMenu: true,
170
161
  fullWidthEnabled: appearance === 'full-width',
171
162
  wasFullWidthEnabled: prevAppearance && prevAppearance === 'full-width',
@@ -15,7 +15,6 @@ import { fg } from '@atlaskit/platform-feature-flags';
15
15
  import { expValEquals } from '@atlaskit/tmp-editor-statsig/exp-val-equals';
16
16
  import { expValEqualsNoExposure } from '@atlaskit/tmp-editor-statsig/exp-val-equals-no-exposure';
17
17
  import { editorExperiment } from '@atlaskit/tmp-editor-statsig/experiments';
18
- import { expValNoExposure } from '@atlaskit/tmp-editor-statsig/expVal';
19
18
  import { useThemeObserver } from '@atlaskit/tokens';
20
19
  import { getBaseFontSize } from '../../composable-editor/utils/getBaseFontSize';
21
20
  import { aiPanelBaseFirefoxStyles, aiPanelBaseStyles, aiPanelDarkFirefoxStyles, aiPanelDarkStyles } from './styles/aiPanel';
@@ -531,7 +530,7 @@ var EditorContentContainer = /*#__PURE__*/React.forwardRef(function (props, ref)
531
530
  // eslint-disable-next-line @atlaskit/ui-styling-standard/no-imported-style-values
532
531
  selectionToolbarAnimationStyles,
533
532
  // eslint-disable-next-line @atlaskit/ui-styling-standard/no-imported-style-values
534
- expValNoExposure('platform_editor_block_menu', 'isEnabled', false) && [
533
+ editorExperiment('platform_editor_block_menu', true) && [
535
534
  // eslint-disable-next-line @atlaskit/ui-styling-standard/no-imported-style-values
536
535
  blockquoteDangerStyles,
537
536
  // eslint-disable-next-line @atlaskit/ui-styling-standard/no-imported-style-values
@@ -1,2 +1,2 @@
1
1
  export var name = "@atlaskit/editor-core";
2
- export var version = "217.12.8";
2
+ export var version = "217.12.9";
package/package.json CHANGED
@@ -1,6 +1,6 @@
1
1
  {
2
2
  "name": "@atlaskit/editor-core",
3
- "version": "217.12.8",
3
+ "version": "217.12.10",
4
4
  "description": "A package contains Atlassian editor core functionality",
5
5
  "publishConfig": {
6
6
  "registry": "https://registry.npmjs.org/"
@@ -67,7 +67,7 @@
67
67
  "@atlaskit/platform-feature-flags-react": "^0.4.0",
68
68
  "@atlaskit/react-ufo": "^5.13.0",
69
69
  "@atlaskit/task-decision": "^19.3.0",
70
- "@atlaskit/tmp-editor-statsig": "^59.1.0",
70
+ "@atlaskit/tmp-editor-statsig": "^61.0.0",
71
71
  "@atlaskit/tokens": "^13.0.0",
72
72
  "@atlaskit/tooltip": "^21.1.0",
73
73
  "@atlaskit/width-detector": "^5.0.0",