@atlaskit/editor-core 216.7.10 → 216.7.11

package/CHANGELOG.md

@@ -1,5 +1,17 @@
 # @atlaskit/editor-core
 
+## 216.7.11
+
+### Patch Changes
+
+- [`cb86382757a72`](https://bitbucket.org/atlassian/atlassian-frontend-monorepo/commits/cb86382757a72) -
+  Cleanup stale flag confluence_floating_toolbar_animation
+- [`4641b85ef8eab`](https://bitbucket.org/atlassian/atlassian-frontend-monorepo/commits/4641b85ef8eab) -
+  Update the default aria-lable for page appearance editors
+- [`5c3f8d87c2290`](https://bitbucket.org/atlassian/atlassian-frontend-monorepo/commits/5c3f8d87c2290) -
+  Cleanup general AIFC bug fix feature gate
+- Updated dependencies
+
 ## 216.7.10
 
 ### Patch Changes

package/dist/cjs/create-editor/ReactEditorView.js

@@ -681,6 +681,7 @@ function ReactEditorView(props) {
       viewRef.current = undefined;
     }
   }, [createEditorView, onEditorCreated, eventDispatcher, onEditorDestroyed, handleAnalyticsEvent, mitigateScrollJump]);
+  var isPageAppearance = (0, _isFullPage.isFullPage)(nextAppearance) || nextAppearance === 'max';
   var createEditor = (0, _react.useCallback)(function (assistiveLabel, assistiveDescribedBy) {
     return /*#__PURE__*/_react.default.createElement(_react.default.Fragment, null, (0, _platformFeatureFlags.fg)('cc_editor_focus_before_editor_on_load') && /*#__PURE__*/_react.default.createElement("div", {
       tabIndex: -1,
@@ -691,7 +692,7 @@ function ReactEditorView(props) {
       className: "ProseMirror ".concat((0, _getUAPrefix.getUAPrefix)()),
       key: "ProseMirror",
       ref: handleEditorViewRef,
-      "aria-label": assistiveLabel || props.intl.formatMessage(_messages.editorMessages.editorAssistiveLabel)
+      "aria-label": assistiveLabel || (isPageAppearance && (0, _platformFeatureFlags.fg)('platform_editor_a11y_9262') ? props.intl.formatMessage(_messages.editorMessages.fullPageEditorAssistiveLabel) : props.intl.formatMessage(_messages.editorMessages.editorAssistiveLabel))
       // setting aria-multiline to true when not mobile appearance.
       //  because somehow mobile tests are failing when it set.
       //  don't know why that is happening.
@@ -710,7 +711,7 @@ function ReactEditorView(props) {
         __html: ''
       } : undefined
     }));
-  }, [handleEditorViewRef, props.intl]);
+  }, [handleEditorViewRef, isPageAppearance, props.intl]);
   var previousPreset = (0, _hooks.usePreviousState)(preset);
   (0, _react.useLayoutEffect)(function () {
     if ((0, _coreUtils.isSSR)() && (0, _expValEquals.expValEquals)('platform_editor_ssr_renderer', 'isEnabled', true)) {
@@ -807,7 +808,7 @@ function ReactEditorView(props) {
       ,
       className: "ProseMirror ".concat((0, _getUAPrefix.getUAPrefix)()),
       key: "ProseMirror",
-      "aria-label": assistiveLabel || props.intl.formatMessage(_messages.editorMessages.editorAssistiveLabel),
+      "aria-label": assistiveLabel || (isPageAppearance && (0, _platformFeatureFlags.fg)('platform_editor_a11y_9262') ? props.intl.formatMessage(_messages.editorMessages.fullPageEditorAssistiveLabel) : props.intl.formatMessage(_messages.editorMessages.editorAssistiveLabel)),
       id: EDIT_AREA_ID,
       "aria-describedby": assistiveDescribedBy,
       "data-editor-id": editorId.current,
@@ -820,7 +821,7 @@ function ReactEditorView(props) {
         });
       }
     });
-  }, [ssrDeps, props.intl, props.portalProviderAPI, assistiveLabel, assistiveDescribedBy]);
+  }, [ssrDeps, props.intl, props.portalProviderAPI, assistiveLabel, assistiveDescribedBy, isPageAppearance]);
   var editor = (0, _react.useMemo)(function () {
     // SSR editor will be available only in SSR environment,
     // in a browser `ssrEditor` will be `null`, and we will render a normal one ProseMirror.

package/dist/cjs/create-editor/messages.js

@@ -10,5 +10,10 @@ var editorMessages = exports.editorMessages = (0, _reactIntlNext.defineMessages)
     id: 'fabric.editor.editorAssistiveLabel',
     defaultMessage: 'Main content area, start typing to enter text.',
     description: 'Text that is read out by screen reader when the main editor is in focus'
+  },
+  fullPageEditorAssistiveLabel: {
+    id: 'fabric.editor.fullPageEditorAssistiveLabel',
+    defaultMessage: 'Page editing area, start typing to enter text.',
+    description: 'The aria-label for the full page editor'
   }
 });

package/dist/cjs/ui/EditorContentContainer/EditorContentContainer.js

@@ -237,11 +237,11 @@ var EditorContentContainer = /*#__PURE__*/_react.default.forwardRef(function (pr
     // eslint-disable-next-line @atlaskit/ui-styling-standard/no-imported-style-values
     _rule.ruleStyles,
     // eslint-disable-next-line @atlaskit/ui-styling-standard/no-imported-style-values
-    _smartCardStyles.smartCardDiffStyles, (0, _platformFeatureFlags.fg)('platform_editor_ai_generic_prep_for_aifc_2') && ((0, _platformFeatureFlags.fg)('platform_editor_jan_a11y_fixes')
+    _smartCardStyles.smartCardDiffStyles, (0, _platformFeatureFlags.fg)('platform_editor_jan_a11y_fixes') ?
     // eslint-disable-next-line @atlaskit/ui-styling-standard/no-imported-style-values
-    ? _smartCardStyles.showDiffDeletedNodeStylesNew
+    _smartCardStyles.showDiffDeletedNodeStylesNew :
     // eslint-disable-next-line @atlaskit/ui-styling-standard/no-imported-style-values
-    : _smartCardStyles.showDiffDeletedNodeStyles),
+    _smartCardStyles.showDiffDeletedNodeStyles,
     // eslint-disable-next-line @atlaskit/ui-styling-standard/no-imported-style-values
     _mediaStyles.mediaStyles, contentMode === 'compact' && ((0, _expValEquals.expValEquals)('confluence_compact_text_format', 'isEnabled', true) ||
     // eslint-disable-next-line @atlaskit/platform/no-preconditioning
@@ -493,7 +493,7 @@ var EditorContentContainer = /*#__PURE__*/_react.default.forwardRef(function (pr
     // eslint-disable-next-line @atlaskit/ui-styling-standard/no-imported-style-values
     _link.hyperLinkFloatingToolbarStyles,
     // eslint-disable-next-line @atlaskit/ui-styling-standard/no-imported-style-values
-    (0, _platformFeatureFlags.fg)('confluence_floating_toolbar_animation') && _selectionToolbarStyles.selectionToolbarAnimationStyles,
+    _selectionToolbarStyles.selectionToolbarAnimationStyles,
     // eslint-disable-next-line @atlaskit/ui-styling-standard/no-imported-style-values
     (0, _platformFeatureFlags.fg)('platform_editor_vanilla_codebidi_warning') && _codeBidiWarningStyles.codeBidiWarningStyles,
     // eslint-disable-next-line @atlaskit/ui-styling-standard/no-imported-style-values

package/dist/cjs/version-wrapper.js

@@ -5,4 +5,4 @@ Object.defineProperty(exports, "__esModule", {
 });
 exports.version = exports.name = void 0;
 var name = exports.name = "@atlaskit/editor-core";
-var version = exports.version = "216.7.9";
+var version = exports.version = "216.7.10";

package/dist/es2019/create-editor/ReactEditorView.js

@@ -632,6 +632,7 @@ export function ReactEditorView(props) {
       viewRef.current = undefined;
     }
   }, [createEditorView, onEditorCreated, eventDispatcher, onEditorDestroyed, handleAnalyticsEvent, mitigateScrollJump]);
+  const isPageAppearance = isFullPage(nextAppearance) || nextAppearance === 'max';
   const createEditor = useCallback((assistiveLabel, assistiveDescribedBy) => {
     return /*#__PURE__*/React.createElement(React.Fragment, null, fg('cc_editor_focus_before_editor_on_load') && /*#__PURE__*/React.createElement("div", {
       tabIndex: -1,
@@ -642,7 +643,7 @@ export function ReactEditorView(props) {
       className: `ProseMirror ${getUAPrefix()}`,
       key: "ProseMirror",
       ref: handleEditorViewRef,
-      "aria-label": assistiveLabel || props.intl.formatMessage(editorMessages.editorAssistiveLabel)
+      "aria-label": assistiveLabel || (isPageAppearance && fg('platform_editor_a11y_9262') ? props.intl.formatMessage(editorMessages.fullPageEditorAssistiveLabel) : props.intl.formatMessage(editorMessages.editorAssistiveLabel))
       // setting aria-multiline to true when not mobile appearance.
       //  because somehow mobile tests are failing when it set.
       //  don't know why that is happening.
@@ -661,7 +662,7 @@ export function ReactEditorView(props) {
         __html: ''
       } : undefined
     }));
-  }, [handleEditorViewRef, props.intl]);
+  }, [handleEditorViewRef, isPageAppearance, props.intl]);
   const previousPreset = usePreviousState(preset);
   useLayoutEffect(() => {
     if (isSSR() && expValEquals('platform_editor_ssr_renderer', 'isEnabled', true)) {
@@ -758,7 +759,7 @@ export function ReactEditorView(props) {
       ,
       className: `ProseMirror ${getUAPrefix()}`,
       key: "ProseMirror",
-      "aria-label": assistiveLabel || props.intl.formatMessage(editorMessages.editorAssistiveLabel),
+      "aria-label": assistiveLabel || (isPageAppearance && fg('platform_editor_a11y_9262') ? props.intl.formatMessage(editorMessages.fullPageEditorAssistiveLabel) : props.intl.formatMessage(editorMessages.editorAssistiveLabel)),
       id: EDIT_AREA_ID,
       "aria-describedby": assistiveDescribedBy,
       "data-editor-id": editorId.current,
@@ -771,7 +772,7 @@ export function ReactEditorView(props) {
         });
       }
     });
-  }, [ssrDeps, props.intl, props.portalProviderAPI, assistiveLabel, assistiveDescribedBy]);
+  }, [ssrDeps, props.intl, props.portalProviderAPI, assistiveLabel, assistiveDescribedBy, isPageAppearance]);
   const editor = useMemo(() => {
     // SSR editor will be available only in SSR environment,
     // in a browser `ssrEditor` will be `null`, and we will render a normal one ProseMirror.

package/dist/es2019/create-editor/messages.js

@@ -4,5 +4,10 @@ export const editorMessages = defineMessages({
     id: 'fabric.editor.editorAssistiveLabel',
     defaultMessage: 'Main content area, start typing to enter text.',
     description: 'Text that is read out by screen reader when the main editor is in focus'
+  },
+  fullPageEditorAssistiveLabel: {
+    id: 'fabric.editor.fullPageEditorAssistiveLabel',
+    defaultMessage: 'Page editing area, start typing to enter text.',
+    description: 'The aria-label for the full page editor'
   }
 });

package/dist/es2019/ui/EditorContentContainer/EditorContentContainer.js

@@ -233,11 +233,11 @@ const EditorContentContainer = /*#__PURE__*/React.forwardRef((props, ref) => {
     // eslint-disable-next-line @atlaskit/ui-styling-standard/no-imported-style-values
     ruleStyles,
     // eslint-disable-next-line @atlaskit/ui-styling-standard/no-imported-style-values
-    smartCardDiffStyles, fg('platform_editor_ai_generic_prep_for_aifc_2') && (fg('platform_editor_jan_a11y_fixes')
+    smartCardDiffStyles, fg('platform_editor_jan_a11y_fixes') ?
     // eslint-disable-next-line @atlaskit/ui-styling-standard/no-imported-style-values
-    ? showDiffDeletedNodeStylesNew
+    showDiffDeletedNodeStylesNew :
     // eslint-disable-next-line @atlaskit/ui-styling-standard/no-imported-style-values
-    : showDiffDeletedNodeStyles),
+    showDiffDeletedNodeStyles,
     // eslint-disable-next-line @atlaskit/ui-styling-standard/no-imported-style-values
     mediaStyles, contentMode === 'compact' && (expValEquals('confluence_compact_text_format', 'isEnabled', true) ||
     // eslint-disable-next-line @atlaskit/platform/no-preconditioning
@@ -489,7 +489,7 @@ const EditorContentContainer = /*#__PURE__*/React.forwardRef((props, ref) => {
     // eslint-disable-next-line @atlaskit/ui-styling-standard/no-imported-style-values
     hyperLinkFloatingToolbarStyles,
     // eslint-disable-next-line @atlaskit/ui-styling-standard/no-imported-style-values
-    fg('confluence_floating_toolbar_animation') && selectionToolbarAnimationStyles,
+    selectionToolbarAnimationStyles,
     // eslint-disable-next-line @atlaskit/ui-styling-standard/no-imported-style-values
     fg('platform_editor_vanilla_codebidi_warning') && codeBidiWarningStyles,
     // eslint-disable-next-line @atlaskit/ui-styling-standard/no-imported-style-values

package/dist/es2019/version-wrapper.js

@@ -1,2 +1,2 @@
 export const name = "@atlaskit/editor-core";
-export const version = "216.7.9";
+export const version = "216.7.10";

package/dist/esm/create-editor/ReactEditorView.js

@@ -672,6 +672,7 @@ export function ReactEditorView(props) {
       viewRef.current = undefined;
     }
   }, [createEditorView, onEditorCreated, eventDispatcher, onEditorDestroyed, handleAnalyticsEvent, mitigateScrollJump]);
+  var isPageAppearance = isFullPage(nextAppearance) || nextAppearance === 'max';
   var createEditor = useCallback(function (assistiveLabel, assistiveDescribedBy) {
     return /*#__PURE__*/React.createElement(React.Fragment, null, fg('cc_editor_focus_before_editor_on_load') && /*#__PURE__*/React.createElement("div", {
       tabIndex: -1,
@@ -682,7 +683,7 @@ export function ReactEditorView(props) {
       className: "ProseMirror ".concat(getUAPrefix()),
       key: "ProseMirror",
       ref: handleEditorViewRef,
-      "aria-label": assistiveLabel || props.intl.formatMessage(editorMessages.editorAssistiveLabel)
+      "aria-label": assistiveLabel || (isPageAppearance && fg('platform_editor_a11y_9262') ? props.intl.formatMessage(editorMessages.fullPageEditorAssistiveLabel) : props.intl.formatMessage(editorMessages.editorAssistiveLabel))
       // setting aria-multiline to true when not mobile appearance.
       //  because somehow mobile tests are failing when it set.
       //  don't know why that is happening.
@@ -701,7 +702,7 @@ export function ReactEditorView(props) {
         __html: ''
       } : undefined
     }));
-  }, [handleEditorViewRef, props.intl]);
+  }, [handleEditorViewRef, isPageAppearance, props.intl]);
   var previousPreset = usePreviousState(preset);
   useLayoutEffect(function () {
     if (isSSR() && expValEquals('platform_editor_ssr_renderer', 'isEnabled', true)) {
@@ -798,7 +799,7 @@ export function ReactEditorView(props) {
       ,
       className: "ProseMirror ".concat(getUAPrefix()),
       key: "ProseMirror",
-      "aria-label": assistiveLabel || props.intl.formatMessage(editorMessages.editorAssistiveLabel),
+      "aria-label": assistiveLabel || (isPageAppearance && fg('platform_editor_a11y_9262') ? props.intl.formatMessage(editorMessages.fullPageEditorAssistiveLabel) : props.intl.formatMessage(editorMessages.editorAssistiveLabel)),
       id: EDIT_AREA_ID,
       "aria-describedby": assistiveDescribedBy,
       "data-editor-id": editorId.current,
@@ -811,7 +812,7 @@ export function ReactEditorView(props) {
         });
       }
     });
-  }, [ssrDeps, props.intl, props.portalProviderAPI, assistiveLabel, assistiveDescribedBy]);
+  }, [ssrDeps, props.intl, props.portalProviderAPI, assistiveLabel, assistiveDescribedBy, isPageAppearance]);
   var editor = useMemo(function () {
     // SSR editor will be available only in SSR environment,
     // in a browser `ssrEditor` will be `null`, and we will render a normal one ProseMirror.

package/dist/esm/create-editor/messages.js

@@ -4,5 +4,10 @@ export var editorMessages = defineMessages({
     id: 'fabric.editor.editorAssistiveLabel',
     defaultMessage: 'Main content area, start typing to enter text.',
     description: 'Text that is read out by screen reader when the main editor is in focus'
+  },
+  fullPageEditorAssistiveLabel: {
+    id: 'fabric.editor.fullPageEditorAssistiveLabel',
+    defaultMessage: 'Page editing area, start typing to enter text.',
+    description: 'The aria-label for the full page editor'
   }
 });

package/dist/esm/ui/EditorContentContainer/EditorContentContainer.js

@@ -229,11 +229,11 @@ var EditorContentContainer = /*#__PURE__*/React.forwardRef(function (props, ref)
     // eslint-disable-next-line @atlaskit/ui-styling-standard/no-imported-style-values
     ruleStyles,
     // eslint-disable-next-line @atlaskit/ui-styling-standard/no-imported-style-values
-    smartCardDiffStyles, fg('platform_editor_ai_generic_prep_for_aifc_2') && (fg('platform_editor_jan_a11y_fixes')
+    smartCardDiffStyles, fg('platform_editor_jan_a11y_fixes') ?
     // eslint-disable-next-line @atlaskit/ui-styling-standard/no-imported-style-values
-    ? showDiffDeletedNodeStylesNew
+    showDiffDeletedNodeStylesNew :
     // eslint-disable-next-line @atlaskit/ui-styling-standard/no-imported-style-values
-    : showDiffDeletedNodeStyles),
+    showDiffDeletedNodeStyles,
     // eslint-disable-next-line @atlaskit/ui-styling-standard/no-imported-style-values
     mediaStyles, contentMode === 'compact' && (expValEquals('confluence_compact_text_format', 'isEnabled', true) ||
     // eslint-disable-next-line @atlaskit/platform/no-preconditioning
@@ -485,7 +485,7 @@ var EditorContentContainer = /*#__PURE__*/React.forwardRef(function (props, ref)
     // eslint-disable-next-line @atlaskit/ui-styling-standard/no-imported-style-values
     hyperLinkFloatingToolbarStyles,
     // eslint-disable-next-line @atlaskit/ui-styling-standard/no-imported-style-values
-    fg('confluence_floating_toolbar_animation') && selectionToolbarAnimationStyles,
+    selectionToolbarAnimationStyles,
     // eslint-disable-next-line @atlaskit/ui-styling-standard/no-imported-style-values
     fg('platform_editor_vanilla_codebidi_warning') && codeBidiWarningStyles,
     // eslint-disable-next-line @atlaskit/ui-styling-standard/no-imported-style-values

package/dist/esm/version-wrapper.js

@@ -1,2 +1,2 @@
 export var name = "@atlaskit/editor-core";
-export var version = "216.7.9";
+export var version = "216.7.10";

package/dist/types/create-editor/messages.d.ts

@@ -4,4 +4,9 @@ export declare const editorMessages: {
         defaultMessage: string;
         description: string;
     };
+    fullPageEditorAssistiveLabel: {
+        id: string;
+        defaultMessage: string;
+        description: string;
+    };
 };

package/dist/types-ts4.5/create-editor/messages.d.ts

@@ -4,4 +4,9 @@ export declare const editorMessages: {
         defaultMessage: string;
         description: string;
     };
+    fullPageEditorAssistiveLabel: {
+        id: string;
+        defaultMessage: string;
+        description: string;
+    };
 };

package/package.json

@@ -1,6 +1,6 @@
 {
 	"name": "@atlaskit/editor-core",
-	"version": "216.7.10",
+	"version": "216.7.11",
 	"description": "A package contains Atlassian editor core functionality",
 	"publishConfig": {
 		"registry": "https://registry.npmjs.org/"
@@ -111,7 +111,7 @@
 		"@atlaskit/section-message": "^8.12.0",
 		"@atlaskit/synchrony-test-helpers": "workspace:^",
 		"@atlaskit/toggle": "^15.2.0",
-		"@atlaskit/util-data-test": "^18.4.0",
+		"@atlaskit/util-data-test": "^18.5.0",
 		"@atlassian/a11y-jest-testing": "^0.8.0",
 		"@atlassian/adf-schema-json": "^1.33.0",
 		"@atlassian/feature-flags-test-utils": "^1.0.0",
@@ -151,16 +151,10 @@
 		}
 	},
 	"platform-feature-flags": {
-		"confluence_floating_toolbar_animation": {
-			"type": "boolean"
-		},
 		"linking_platform_datasource_assets_objects": {
 			"type": "boolean",
 			"referenceOnly": "true"
 		},
-		"platform_editor_ai_generic_prep_for_aifc_2": {
-			"type": "boolean"
-		},
 		"editor_inline_comments_on_inline_nodes": {
 			"type": "boolean",
 			"referenceOnly": "true"
@@ -361,6 +355,9 @@
 		},
 		"platform_editor_jan_a11y_fixes": {
 			"type": "boolean"
+		},
+		"platform_editor_a11y_9262": {
+			"type": "boolean"
 		}
 	},
 	"stricter": {