@atlaskit/editor-core 215.4.0 → 215.5.0

package/CHANGELOG.md

@@ -1,5 +1,24 @@
 # @atlaskit/editor-core
 
+## 215.5.0
+
+### Minor Changes
+
+- [`c1691aca7fb1d`](https://bitbucket.org/atlassian/atlassian-frontend-monorepo/commits/c1691aca7fb1d) -
+  Surface extension keys into quick insert provider
+
+### Patch Changes
+
+- Updated dependencies
+
+## 215.4.1
+
+### Patch Changes
+
+- [`2fc927b3b7437`](https://bitbucket.org/atlassian/atlassian-frontend-monorepo/commits/2fc927b3b7437) -
+  [ux] ED29532 Add keyboard navigation provider to comment toolbar
+- Updated dependencies
+
 ## 215.4.0
 
 ### Minor Changes

package/dist/cjs/ui/Appearance/Comment/Comment.js

@@ -19,6 +19,7 @@ var _messages = _interopRequireDefault(require("@atlaskit/editor-common/messages
 var _ui = require("@atlaskit/editor-common/ui");
 var _uiMenu = require("@atlaskit/editor-common/ui-menu");
 var _editorSharedStyles = require("@atlaskit/editor-shared-styles");
+var _platformFeatureFlags = require("@atlaskit/platform-feature-flags");
 var _expValEquals = require("@atlaskit/tmp-editor-statsig/exp-val-equals");
 var _ClickAreaBlock = _interopRequireDefault(require("../../Addon/ClickAreaBlock"));
 var _contentComponentWrapper = require("../../Addon/ClickAreaBlock/contentComponentWrapper");
@@ -191,7 +192,23 @@ var CommentEditorWithIntl = exports.CommentEditorWithIntl = function CommentEdit
     useStickyToolbar: useStickyToolbar,
     twoLineEditorToolbar: isTwoLineToolbarEnabled,
     isNewToolbarEnabled: isToolbarAIFCEnabled
-  }, isToolbarAIFCEnabled ? (0, _react2.jsx)(_react.default.Fragment, null, (0, _react2.jsx)(_CommentToolbar.CommentToolbar, {
+  }, isToolbarAIFCEnabled ? (0, _platformFeatureFlags.fg)('platform_editor_toolbar_aifc_patch_7') ? (0, _react2.jsx)(_uiMenu.ToolbarArrowKeyNavigationProvider, {
+    editorView: editorView,
+    childComponentSelector: "[data-testid='ak-editor-main-toolbar']",
+    isShortcutToFocusToolbar: isShortcutToFocusToolbar,
+    handleEscape: handleEscape,
+    editorAppearance: appearance,
+    useStickyToolbar: useStickyToolbar,
+    intl: intl
+  }, (0, _react2.jsx)(_CommentToolbar.CommentToolbar, {
+    editorAPI: editorAPI,
+    editorView: editorView,
+    editorAppearance: appearance,
+    disabled: patch6Enabled ? !!disabled : undefined,
+    popupsBoundariesElement: popupsBoundariesElement,
+    popupsScrollableElement: popupsScrollableElement,
+    popupsMountPoint: popupsMountPoint
+  })) : (0, _react2.jsx)(_react.default.Fragment, null, (0, _react2.jsx)(_CommentToolbar.CommentToolbar, {
     editorAPI: editorAPI,
     editorView: editorView,
     editorAppearance: appearance,

package/dist/cjs/utils/extensions.js

@@ -15,6 +15,7 @@ var _analytics = require("@atlaskit/editor-common/analytics");
 var _extensions = require("@atlaskit/editor-common/extensions");
 var _providerHelpers = require("@atlaskit/editor-common/provider-helpers");
 var _analytics2 = require("@atlaskit/editor-common/utils/analytics");
+var _platformFeatureFlags = require("@atlaskit/platform-feature-flags");
 function ownKeys(e, r) { var t = Object.keys(e); if (Object.getOwnPropertySymbols) { var o = Object.getOwnPropertySymbols(e); r && (o = o.filter(function (r) { return Object.getOwnPropertyDescriptor(e, r).enumerable; })), t.push.apply(t, o); } return t; }
 function _objectSpread(e) { for (var r = 1; r < arguments.length; r++) { var t = null != arguments[r] ? arguments[r] : {}; r % 2 ? ownKeys(Object(t), !0).forEach(function (r) { (0, _defineProperty2.default)(e, r, t[r]); }) : Object.getOwnPropertyDescriptors ? Object.defineProperties(e, Object.getOwnPropertyDescriptors(t)) : ownKeys(Object(t)).forEach(function (r) { Object.defineProperty(e, r, Object.getOwnPropertyDescriptor(t, r)); }); } return e; }
 /**
@@ -95,7 +96,9 @@ function _extensionProviderToQuickInsertProvider() {
                     return null;
                   }
                 });
-                return {
+                return _objectSpread(_objectSpread({}, (0, _platformFeatureFlags.fg)('confluence-whiteboards-quick-insert-l10n-eligible') && {
+                  key: item.key
+                }), {}, {
                   title: item.title,
                   description: item.description,
                   icon: function icon() {
@@ -138,7 +141,7 @@ function _extensionProviderToQuickInsertProvider() {
                       return insert(item.node);
                     }
                   }
-                };
+                });
               });
               return Promise.all(quickInsertItems);
             }

package/dist/cjs/version-wrapper.js

@@ -5,4 +5,4 @@ Object.defineProperty(exports, "__esModule", {
 });
 exports.version = exports.name = void 0;
 var name = exports.name = "@atlaskit/editor-core";
-var version = exports.version = "215.3.3";
+var version = exports.version = "215.4.1";

package/dist/es2019/ui/Appearance/Comment/Comment.js

@@ -15,6 +15,7 @@ import messages from '@atlaskit/editor-common/messages';
 import { WidthConsumer, WidthProvider } from '@atlaskit/editor-common/ui';
 import { ToolbarArrowKeyNavigationProvider } from '@atlaskit/editor-common/ui-menu';
 import { akEditorMobileBreakoutPoint } from '@atlaskit/editor-shared-styles';
+import { fg } from '@atlaskit/platform-feature-flags';
 import { expValEquals } from '@atlaskit/tmp-editor-statsig/exp-val-equals';
 // Ignored via go/ees005
 // eslint-disable-next-line import/no-named-as-default
@@ -179,7 +180,23 @@ export const CommentEditorWithIntl = props => {
     useStickyToolbar: useStickyToolbar,
     twoLineEditorToolbar: isTwoLineToolbarEnabled,
     isNewToolbarEnabled: isToolbarAIFCEnabled
-  }, isToolbarAIFCEnabled ? jsx(React.Fragment, null, jsx(CommentToolbar, {
+  }, isToolbarAIFCEnabled ? fg('platform_editor_toolbar_aifc_patch_7') ? jsx(ToolbarArrowKeyNavigationProvider, {
+    editorView: editorView,
+    childComponentSelector: "[data-testid='ak-editor-main-toolbar']",
+    isShortcutToFocusToolbar: isShortcutToFocusToolbar,
+    handleEscape: handleEscape,
+    editorAppearance: appearance,
+    useStickyToolbar: useStickyToolbar,
+    intl: intl
+  }, jsx(CommentToolbar, {
+    editorAPI: editorAPI,
+    editorView: editorView,
+    editorAppearance: appearance,
+    disabled: patch6Enabled ? !!disabled : undefined,
+    popupsBoundariesElement: popupsBoundariesElement,
+    popupsScrollableElement: popupsScrollableElement,
+    popupsMountPoint: popupsMountPoint
+  })) : jsx(React.Fragment, null, jsx(CommentToolbar, {
     editorAPI: editorAPI,
     editorView: editorView,
     editorAppearance: appearance,

package/dist/es2019/utils/extensions.js

@@ -4,6 +4,7 @@ import { ACTION, ACTION_SUBJECT, ACTION_SUBJECT_ID, EVENT_TYPE, fireAnalyticsEve
 import { getQuickInsertItemsFromModule, resolveImport } from '@atlaskit/editor-common/extensions';
 import { combineProviders } from '@atlaskit/editor-common/provider-helpers';
 import { findInsertLocation } from '@atlaskit/editor-common/utils/analytics';
+import { fg } from '@atlaskit/platform-feature-flags';
 /**
  * Utils to send analytics event when a extension is inserted using quickInsert
  */
@@ -58,6 +59,12 @@ export async function extensionProviderToQuickInsertProvider(extensionProvider,
           loading: () => null
         });
         return {
+          // Add module key so typeahead/quick-insert can identify items
+          // **locale-agnostically**! nb: we _already_ send key in analytics
+          // events, this standardises and makes our items more predictable.
+          ...(fg('confluence-whiteboards-quick-insert-l10n-eligible') && {
+            key: item.key
+          }),
           title: item.title,
           description: item.description,
           icon: () => /*#__PURE__*/React.createElement(Icon, {

package/dist/es2019/version-wrapper.js

@@ -1,2 +1,2 @@
 export const name = "@atlaskit/editor-core";
-export const version = "215.3.3";
+export const version = "215.4.1";

package/dist/esm/ui/Appearance/Comment/Comment.js

@@ -17,6 +17,7 @@ import messages from '@atlaskit/editor-common/messages';
 import { WidthConsumer, WidthProvider } from '@atlaskit/editor-common/ui';
 import { ToolbarArrowKeyNavigationProvider } from '@atlaskit/editor-common/ui-menu';
 import { akEditorMobileBreakoutPoint } from '@atlaskit/editor-shared-styles';
+import { fg } from '@atlaskit/platform-feature-flags';
 import { expValEquals } from '@atlaskit/tmp-editor-statsig/exp-val-equals';
 // Ignored via go/ees005
 // eslint-disable-next-line import/no-named-as-default
@@ -180,7 +181,23 @@ export var CommentEditorWithIntl = function CommentEditorWithIntl(props) {
     useStickyToolbar: useStickyToolbar,
     twoLineEditorToolbar: isTwoLineToolbarEnabled,
     isNewToolbarEnabled: isToolbarAIFCEnabled
-  }, isToolbarAIFCEnabled ? jsx(React.Fragment, null, jsx(CommentToolbar, {
+  }, isToolbarAIFCEnabled ? fg('platform_editor_toolbar_aifc_patch_7') ? jsx(ToolbarArrowKeyNavigationProvider, {
+    editorView: editorView,
+    childComponentSelector: "[data-testid='ak-editor-main-toolbar']",
+    isShortcutToFocusToolbar: isShortcutToFocusToolbar,
+    handleEscape: handleEscape,
+    editorAppearance: appearance,
+    useStickyToolbar: useStickyToolbar,
+    intl: intl
+  }, jsx(CommentToolbar, {
+    editorAPI: editorAPI,
+    editorView: editorView,
+    editorAppearance: appearance,
+    disabled: patch6Enabled ? !!disabled : undefined,
+    popupsBoundariesElement: popupsBoundariesElement,
+    popupsScrollableElement: popupsScrollableElement,
+    popupsMountPoint: popupsMountPoint
+  })) : jsx(React.Fragment, null, jsx(CommentToolbar, {
     editorAPI: editorAPI,
     editorView: editorView,
     editorAppearance: appearance,

package/dist/esm/utils/extensions.js

@@ -9,6 +9,7 @@ import { ACTION, ACTION_SUBJECT, ACTION_SUBJECT_ID, EVENT_TYPE, fireAnalyticsEve
 import { getQuickInsertItemsFromModule, resolveImport } from '@atlaskit/editor-common/extensions';
 import { combineProviders } from '@atlaskit/editor-common/provider-helpers';
 import { findInsertLocation } from '@atlaskit/editor-common/utils/analytics';
+import { fg } from '@atlaskit/platform-feature-flags';
 /**
  * Utils to send analytics event when a extension is inserted using quickInsert
  */
@@ -89,7 +90,9 @@ function _extensionProviderToQuickInsertProvider() {
                     return null;
                   }
                 });
-                return {
+                return _objectSpread(_objectSpread({}, fg('confluence-whiteboards-quick-insert-l10n-eligible') && {
+                  key: item.key
+                }), {}, {
                   title: item.title,
                   description: item.description,
                   icon: function icon() {
@@ -132,7 +135,7 @@ function _extensionProviderToQuickInsertProvider() {
                       return insert(item.node);
                     }
                   }
-                };
+                });
               });
               return Promise.all(quickInsertItems);
             }

package/dist/esm/version-wrapper.js

@@ -1,2 +1,2 @@
 export var name = "@atlaskit/editor-core";
-export var version = "215.3.3";
+export var version = "215.4.1";

package/package.json

@@ -1,6 +1,6 @@
 {
 	"name": "@atlaskit/editor-core",
-	"version": "215.4.0",
+	"version": "215.5.0",
 	"description": "A package contains Atlassian editor core functionality",
 	"publishConfig": {
 		"registry": "https://registry.npmjs.org/"
@@ -64,7 +64,7 @@
 		"@atlaskit/platform-feature-flags-react": "^0.3.0",
 		"@atlaskit/react-ufo": "^4.12.0",
 		"@atlaskit/task-decision": "^19.2.0",
-		"@atlaskit/tmp-editor-statsig": "^13.14.0",
+		"@atlaskit/tmp-editor-statsig": "^13.16.0",
 		"@atlaskit/tokens": "^7.0.0",
 		"@atlaskit/tooltip": "^20.6.0",
 		"@atlaskit/width-detector": "^5.0.0",
@@ -450,6 +450,9 @@
 		"platform_editor_toolbar_aifc_patch_7": {
 			"type": "boolean"
 		},
+		"confluence-whiteboards-quick-insert-l10n-eligible": {
+			"type": "boolean"
+		},
 		"platform_editor_table_container_y_overflow_fix": {
 			"type": "boolean"
 		}