@atlaskit/editor-core 204.7.1 → 204.7.2

package/CHANGELOG.md

@@ -1,5 +1,23 @@
 # @atlaskit/editor-core
 
+## 204.7.2
+
+### Patch Changes
+
+- [#131485](https://bitbucket.org/atlassian/atlassian-frontend-monorepo/pull-requests/131485)
+  [`bd6274bb72cb1`](https://bitbucket.org/atlassian/atlassian-frontend-monorepo/commits/bd6274bb72cb1) -
+  ENGHEALTH-23692 Iconography uplift for editor-core
+- [#131407](https://bitbucket.org/atlassian/atlassian-frontend-monorepo/pull-requests/131407)
+  [`59a88ee61a0c5`](https://bitbucket.org/atlassian/atlassian-frontend-monorepo/commits/59a88ee61a0c5) -
+  [ux] EDF-2626: Add view isDestroyed check in editor auto-focusing logic to ensure bail before
+  posFromDOM and editor selection operations committed on destroyed docView instance, behind
+  platform_editor_posfromdom_null_fix
+- [#131280](https://bitbucket.org/atlassian/atlassian-frontend-monorepo/pull-requests/131280)
+  [`9ff92ea2432f2`](https://bitbucket.org/atlassian/atlassian-frontend-monorepo/commits/9ff92ea2432f2) -
+  [ED-27082] Fix media overflow toolbar to show correct options + update separators between button
+  groups
+- Updated dependencies
+
 ## 204.7.1
 
 ### Patch Changes

package/dist/cjs/create-editor/ReactEditorView/handleEditorFocus.js

@@ -25,6 +25,14 @@ function handleEditorFocus(view) {
     return window.setTimeout(fn, 0);
   };
   return react16OnlySetTimeout(function () {
+    // Due to race conditions during editor lifecycle transitions (e.g. SPA route changes during opening or closing)
+    // where the view (and its internal docView) may have been destroyed, the timeout callback may fire on a stale view.
+    // Bail out in that scenario to prevent operating on an unmounted view.
+    if ((0, _platformFeatureFlags.fg)('platform_editor_posfromdom_null_fix')) {
+      if (view !== null && view !== void 0 && view.isDestroyed) {
+        return;
+      }
+    }
     if (view !== null && view !== void 0 && view.hasFocus()) {
       return;
     }
@@ -43,6 +51,7 @@ function handleEditorFocus(view) {
       view.focus();
       return;
     }
+
     // set cursor/selection and focus
     var anchor = view === null || view === void 0 ? void 0 : view.posAtDOM(range.startContainer, range.startOffset);
     var head = view === null || view === void 0 ? void 0 : view.posAtDOM(range.endContainer, range.endOffset);

package/dist/cjs/ui/ToolbarHelp/index.js

@@ -8,7 +8,7 @@ exports.default = void 0;
 var _react = _interopRequireDefault(require("react"));
 var _reactIntlNext = require("react-intl-next");
 var _uiMenu = require("@atlaskit/editor-common/ui-menu");
-var _question = _interopRequireDefault(require("@atlaskit/icon/glyph/question"));
+var _questionCircleQuestion = _interopRequireDefault(require("@atlaskit/icon/core/migration/question-circle--question"));
 var _EditorContext = require("../EditorContext");
 var _messages = require("./messages");
 // Please, do not copy or use this kind of code below
@@ -59,7 +59,7 @@ var TooltipHelpTrigger = function TooltipHelpTrigger(_ref) {
     onClick: showHelp,
     title: displayTitle,
     titlePosition: titlePosition,
-    iconBefore: /*#__PURE__*/_react.default.createElement(_question.default, {
+    iconBefore: /*#__PURE__*/_react.default.createElement(_questionCircleQuestion.default, {
       label: displayTitle
     })
   });

package/dist/cjs/version-wrapper.js

@@ -5,4 +5,4 @@ Object.defineProperty(exports, "__esModule", {
 });
 exports.version = exports.name = void 0;
 var name = exports.name = "@atlaskit/editor-core";
-var version = exports.version = "204.7.1";
+var version = exports.version = "204.7.2";

package/dist/es2019/create-editor/ReactEditorView/handleEditorFocus.js

@@ -14,6 +14,14 @@ export function handleEditorFocus(view) {
    */
   const react16OnlySetTimeout = React !== null && React !== void 0 && React.startTransition && fg('platform_editor_react_18_autofocus_fix') ? fn => fn() : fn => window.setTimeout(fn, 0);
   return react16OnlySetTimeout(() => {
+    // Due to race conditions during editor lifecycle transitions (e.g. SPA route changes during opening or closing)
+    // where the view (and its internal docView) may have been destroyed, the timeout callback may fire on a stale view.
+    // Bail out in that scenario to prevent operating on an unmounted view.
+    if (fg('platform_editor_posfromdom_null_fix')) {
+      if (view !== null && view !== void 0 && view.isDestroyed) {
+        return;
+      }
+    }
     if (view !== null && view !== void 0 && view.hasFocus()) {
       return;
     }
@@ -32,6 +40,7 @@ export function handleEditorFocus(view) {
       view.focus();
       return;
     }
+
     // set cursor/selection and focus
     const anchor = view === null || view === void 0 ? void 0 : view.posAtDOM(range.startContainer, range.startOffset);
     const head = view === null || view === void 0 ? void 0 : view.posAtDOM(range.endContainer, range.endOffset);

package/dist/es2019/ui/ToolbarHelp/index.js

@@ -1,7 +1,7 @@
 import React from 'react';
 import { injectIntl } from 'react-intl-next';
 import { ToolbarButton } from '@atlaskit/editor-common/ui-menu';
-import QuestionIcon from '@atlaskit/icon/glyph/question';
+import QuestionIcon from '@atlaskit/icon/core/migration/question-circle--question';
 import { useEditorContext } from '../EditorContext';
 import { messages } from './messages';
 // Please, do not copy or use this kind of code below

package/dist/es2019/version-wrapper.js

@@ -1,2 +1,2 @@
 export const name = "@atlaskit/editor-core";
-export const version = "204.7.1";
+export const version = "204.7.2";

package/dist/esm/create-editor/ReactEditorView/handleEditorFocus.js

@@ -18,6 +18,14 @@ export function handleEditorFocus(view) {
     return window.setTimeout(fn, 0);
   };
   return react16OnlySetTimeout(function () {
+    // Due to race conditions during editor lifecycle transitions (e.g. SPA route changes during opening or closing)
+    // where the view (and its internal docView) may have been destroyed, the timeout callback may fire on a stale view.
+    // Bail out in that scenario to prevent operating on an unmounted view.
+    if (fg('platform_editor_posfromdom_null_fix')) {
+      if (view !== null && view !== void 0 && view.isDestroyed) {
+        return;
+      }
+    }
     if (view !== null && view !== void 0 && view.hasFocus()) {
       return;
     }
@@ -36,6 +44,7 @@ export function handleEditorFocus(view) {
       view.focus();
       return;
     }
+
     // set cursor/selection and focus
     var anchor = view === null || view === void 0 ? void 0 : view.posAtDOM(range.startContainer, range.startOffset);
     var head = view === null || view === void 0 ? void 0 : view.posAtDOM(range.endContainer, range.endOffset);

package/dist/esm/ui/ToolbarHelp/index.js

@@ -1,7 +1,7 @@
 import React from 'react';
 import { injectIntl } from 'react-intl-next';
 import { ToolbarButton } from '@atlaskit/editor-common/ui-menu';
-import QuestionIcon from '@atlaskit/icon/glyph/question';
+import QuestionIcon from '@atlaskit/icon/core/migration/question-circle--question';
 import { useEditorContext } from '../EditorContext';
 import { messages } from './messages';
 // Please, do not copy or use this kind of code below

package/dist/esm/version-wrapper.js

@@ -1,2 +1,2 @@
 export var name = "@atlaskit/editor-core";
-export var version = "204.7.1";
+export var version = "204.7.2";

package/package.json

@@ -1,6 +1,6 @@
 {
 	"name": "@atlaskit/editor-core",
-	"version": "204.7.1",
+	"version": "204.7.2",
 	"description": "A package contains Atlassian editor core functionality",
 	"publishConfig": {
 		"registry": "https://registry.npmjs.org/"
@@ -100,7 +100,7 @@
 		"@atlaskit/media-test-helpers": "^35.0.0",
 		"@atlaskit/modal-dialog": "^13.4.0",
 		"@atlaskit/primitives": "^14.2.0",
-		"@atlaskit/renderer": "^114.4.0",
+		"@atlaskit/renderer": "^114.5.0",
 		"@atlaskit/smart-card": "^36.0.0",
 		"@atlaskit/synchrony-test-helpers": "^3.1.0",
 		"@atlaskit/toggle": "^15.0.0",
@@ -567,6 +567,9 @@
 		},
 		"platform_editor_keep_focus_on_content_comp_clicks": {
 			"type": "boolean"
+		},
+		"platform_editor_posfromdom_null_fix": {
+			"type": "boolean"
 		}
 	},
 	"stricter": {