@atlaskit/editor-core 203.2.7 → 203.2.8

package/CHANGELOG.md

@@ -1,5 +1,14 @@
 # @atlaskit/editor-core
 
+## 203.2.8
+
+### Patch Changes
+
+- [#174977](https://stash.atlassian.com/projects/CONFCLOUD/repos/confluence-frontend/pull-requests/174977)
+  [`d96316360ee1d`](https://stash.atlassian.com/projects/CONFCLOUD/repos/confluence-frontend/commits/d96316360ee1d) -
+  Block stale transactions when the react editor view is unmounted
+- Updated dependencies
+
 ## 203.2.7
 
 ### Patch Changes

package/dist/cjs/create-editor/ReactEditorViewNext.js

@@ -252,14 +252,6 @@ function ReactEditorView(props) {
   // Initialise phase
   // Using constructor hook so we setup and dispatch analytics before anything else
   (0, _hooks.useConstructor)(function () {
-    // Transaction dispatching is already enabled by default prior to
-    // mounting, but we reset it here, just in case the editor view
-    // instance is ever recycled (mounted again after unmounting) with
-    // the same key.
-    // Although storing mounted state is an anti-pattern in React,
-    // we do so here so that we can intercept and abort asynchronous
-    // ProseMirror transactions when a dismount is imminent.
-    canDispatchTransactions.current = true;
     // This needs to be before initialising editorState because
     // we dispatch analytics events in plugin initialisation
     eventDispatcher.on(_analytics2.analyticsEventKey, handleAnalyticsEvent);
@@ -274,6 +266,24 @@ function ReactEditorView(props) {
       eventType: _analytics.EVENT_TYPE.UI
     });
   });
+  (0, _react.useLayoutEffect)(function () {
+    // Transaction dispatching is already enabled by default prior to
+    // mounting, but we reset it here, just in case the editor view
+    // instance is ever recycled (mounted again after unmounting) with
+    // the same key.
+    // AND since React 18 effects may run multiple times so we need to ensure
+    // this is reset so that transactions are still allowed.
+    // Although storing mounted state is an anti-pattern in React,
+    // we do so here so that we can intercept and abort asynchronous
+    // ProseMirror transactions when a dismount is imminent.
+    canDispatchTransactions.current = true;
+    return function () {
+      // We can ignore any transactions from this point onwards.
+      // This serves to avoid potential runtime exceptions which could arise
+      // from an async dispatched transaction after it's unmounted.
+      canDispatchTransactions.current = false;
+    };
+  }, []);
 
   // Cleanup
   (0, _react.useLayoutEffect)(function () {

package/dist/cjs/version-wrapper.js

@@ -5,4 +5,4 @@ Object.defineProperty(exports, "__esModule", {
 });
 exports.version = exports.name = void 0;
 var name = exports.name = "@atlaskit/editor-core";
-var version = exports.version = "203.2.7";
+var version = exports.version = "203.2.8";

package/dist/es2019/create-editor/ReactEditorViewNext.js

@@ -227,14 +227,6 @@ function ReactEditorView(props) {
   // Initialise phase
   // Using constructor hook so we setup and dispatch analytics before anything else
   useConstructor(() => {
-    // Transaction dispatching is already enabled by default prior to
-    // mounting, but we reset it here, just in case the editor view
-    // instance is ever recycled (mounted again after unmounting) with
-    // the same key.
-    // Although storing mounted state is an anti-pattern in React,
-    // we do so here so that we can intercept and abort asynchronous
-    // ProseMirror transactions when a dismount is imminent.
-    canDispatchTransactions.current = true;
     // This needs to be before initialising editorState because
     // we dispatch analytics events in plugin initialisation
     eventDispatcher.on(analyticsEventKey, handleAnalyticsEvent);
@@ -249,6 +241,24 @@ function ReactEditorView(props) {
       eventType: EVENT_TYPE.UI
     });
   });
+  useLayoutEffect(() => {
+    // Transaction dispatching is already enabled by default prior to
+    // mounting, but we reset it here, just in case the editor view
+    // instance is ever recycled (mounted again after unmounting) with
+    // the same key.
+    // AND since React 18 effects may run multiple times so we need to ensure
+    // this is reset so that transactions are still allowed.
+    // Although storing mounted state is an anti-pattern in React,
+    // we do so here so that we can intercept and abort asynchronous
+    // ProseMirror transactions when a dismount is imminent.
+    canDispatchTransactions.current = true;
+    return () => {
+      // We can ignore any transactions from this point onwards.
+      // This serves to avoid potential runtime exceptions which could arise
+      // from an async dispatched transaction after it's unmounted.
+      canDispatchTransactions.current = false;
+    };
+  }, []);
 
   // Cleanup
   useLayoutEffect(() => {

package/dist/es2019/version-wrapper.js

@@ -1,2 +1,2 @@
 export const name = "@atlaskit/editor-core";
-export const version = "203.2.7";
+export const version = "203.2.8";

package/dist/esm/create-editor/ReactEditorViewNext.js

@@ -242,14 +242,6 @@ function ReactEditorView(props) {
   // Initialise phase
   // Using constructor hook so we setup and dispatch analytics before anything else
   useConstructor(function () {
-    // Transaction dispatching is already enabled by default prior to
-    // mounting, but we reset it here, just in case the editor view
-    // instance is ever recycled (mounted again after unmounting) with
-    // the same key.
-    // Although storing mounted state is an anti-pattern in React,
-    // we do so here so that we can intercept and abort asynchronous
-    // ProseMirror transactions when a dismount is imminent.
-    canDispatchTransactions.current = true;
     // This needs to be before initialising editorState because
     // we dispatch analytics events in plugin initialisation
     eventDispatcher.on(analyticsEventKey, handleAnalyticsEvent);
@@ -264,6 +256,24 @@ function ReactEditorView(props) {
       eventType: EVENT_TYPE.UI
     });
   });
+  useLayoutEffect(function () {
+    // Transaction dispatching is already enabled by default prior to
+    // mounting, but we reset it here, just in case the editor view
+    // instance is ever recycled (mounted again after unmounting) with
+    // the same key.
+    // AND since React 18 effects may run multiple times so we need to ensure
+    // this is reset so that transactions are still allowed.
+    // Although storing mounted state is an anti-pattern in React,
+    // we do so here so that we can intercept and abort asynchronous
+    // ProseMirror transactions when a dismount is imminent.
+    canDispatchTransactions.current = true;
+    return function () {
+      // We can ignore any transactions from this point onwards.
+      // This serves to avoid potential runtime exceptions which could arise
+      // from an async dispatched transaction after it's unmounted.
+      canDispatchTransactions.current = false;
+    };
+  }, []);
 
   // Cleanup
   useLayoutEffect(function () {

package/dist/esm/version-wrapper.js

@@ -1,2 +1,2 @@
 export var name = "@atlaskit/editor-core";
-export var version = "203.2.7";
+export var version = "203.2.8";

package/package.json

@@ -1,6 +1,6 @@
 {
 	"name": "@atlaskit/editor-core",
-	"version": "203.2.7",
+	"version": "203.2.8",
 	"description": "A package contains Atlassian editor core functionality",
 	"publishConfig": {
 		"registry": "https://registry.npmjs.org/"
@@ -43,7 +43,7 @@
 		"@atlaskit/analytics-next": "^10.2.0",
 		"@atlaskit/analytics-next-stable-react-context": "1.0.1",
 		"@atlaskit/button": "^20.3.0",
-		"@atlaskit/editor-common": "^96.3.0",
+		"@atlaskit/editor-common": "^96.4.0",
 		"@atlaskit/editor-json-transformer": "^8.21.0",
 		"@atlaskit/editor-plugin-quick-insert": "1.8.0",
 		"@atlaskit/editor-plugins": "^5.8.0",
@@ -83,7 +83,7 @@
 		"@af/visual-regression": "*",
 		"@atlaskit/adf-utils": "^19.14.0",
 		"@atlaskit/analytics-listeners": "^8.13.0",
-		"@atlaskit/collab-provider": "10.2.1",
+		"@atlaskit/collab-provider": "10.2.2",
 		"@atlaskit/editor-plugin-annotation": "1.26.2",
 		"@atlaskit/editor-plugin-card": "^4.5.0",
 		"@atlaskit/editor-plugin-list": "^3.9.0",
@@ -103,7 +103,7 @@
 		"@atlaskit/visual-regression": "*",
 		"@atlassian/adf-schema-json": "^1.22.0",
 		"@atlassian/feature-flags-test-utils": "*",
-		"@atlassian/search-provider": "3.0.6",
+		"@atlassian/search-provider": "3.0.7",
 		"@emotion/jest": "^11.8.0",
 		"@storybook/addon-knobs": "^6.4.0",
 		"@testing-library/react": "^12.1.5",