@atlaskit/editor-core 197.5.2 → 197.5.3

package/CHANGELOG.md

@@ -1,5 +1,13 @@
 # @atlaskit/editor-core
 
+## 197.5.3
+
+### Patch Changes
+
+- [#138334](https://stash.atlassian.com/projects/CONFCLOUD/repos/confluence-frontend/pull-requests/138334)
+  [`5bc7950824d2d`](https://stash.atlassian.com/projects/CONFCLOUD/repos/confluence-frontend/commits/5bc7950824d2d) -
+  Removing dangerous and deprecated internal API
+
 ## 197.5.2
 
 ### Patch Changes

package/dist/cjs/composable-editor/editor-internal.js

@@ -12,7 +12,6 @@ var _react = require("react");
 var _react2 = require("@emotion/react");
 var _analytics = require("@atlaskit/editor-common/analytics");
 var _portal = require("@atlaskit/editor-common/portal");
-var _platformFeatureFlags = require("@atlaskit/platform-feature-flags");
 var _ErrorBoundary = _interopRequireDefault(require("../create-editor/ErrorBoundary"));
 var _featureFlagsFromProps = require("../create-editor/feature-flags-from-props");
 var _ReactEditorView = _interopRequireDefault(require("../create-editor/ReactEditorView"));
@@ -51,16 +50,6 @@ var EditorInternal = exports.EditorInternal = /*#__PURE__*/(0, _react.memo)(func
     onEditorDestroyed = _ref.onEditorDestroyed,
     preset = _ref.preset,
     AppearanceComponent = _ref.AppearanceComponent;
-  var setEditorApi = (0, _react.useCallback)(
-  // eslint-disable-next-line @typescript-eslint/no-explicit-any
-  function (api) {
-    if (!(0, _platformFeatureFlags.fg)('platform_editor_remove_editor_actions_workaround')) {
-      // This is an workaround to unblock Editor Lego Decoupling project, if you have questions ping us #cc-editor-lego
-      // We may clean up this code when EditorActions deprecation process starts
-      // @ts-expect-error 2339: Property '__EDITOR_INTERNALS_DO_NOT_USE__API' does not exist on type 'EditorActions<any>'.
-      editorActions.__EDITOR_INTERNALS_DO_NOT_USE__API = api;
-    }
-  }, [editorActions]);
   var overriddenEditorProps = _objectSpread(_objectSpread({}, props), {}, {
     onSave: props.onSave ? handleSave : undefined,
     // noop all analytic events, even if a handler is still passed.
@@ -104,7 +93,6 @@ var EditorInternal = exports.EditorInternal = /*#__PURE__*/(0, _react.memo)(func
     onEditorDestroyed: onEditorDestroyed,
     disabled: props.disabled,
     preset: preset,
-    setEditorApi: setEditorApi,
     render: function render(_ref2) {
       var _props$featureFlags, _props$featureFlags2;
       var editor = _ref2.editor,
@@ -155,7 +143,6 @@ var EditorInternal = exports.EditorInternal = /*#__PURE__*/(0, _react.memo)(func
 function ReactEditorViewContextWrapper(props) {
   var _props$editorProps$me, _props$editorProps$li;
   var setInternalEditorAPI = (0, _context.useSetPresetContext)();
-  var setExternalEditorAPI = props.setEditorApi;
 
   /**
    * We use the context to retrieve the editorAPI
@@ -169,8 +156,7 @@ function ReactEditorViewContextWrapper(props) {
   // eslint-disable-next-line @typescript-eslint/no-explicit-any
   function (api) {
     setInternalEditorAPI === null || setInternalEditorAPI === void 0 || setInternalEditorAPI(api);
-    setExternalEditorAPI === null || setExternalEditorAPI === void 0 || setExternalEditorAPI(api);
-  }, [setInternalEditorAPI, setExternalEditorAPI]);
+  }, [setInternalEditorAPI]);
 
   // TODO: Remove these when we deprecate these props from editor-props - smartLinks is unfortunately still used in some places, we can sidestep this problem if we move everyone across to ComposableEditor and deprecate Editor
   var UNSAFE_cards = props.editorProps.UNSAFE_cards;

package/dist/cjs/create-editor/ReactEditorView.js

@@ -30,7 +30,6 @@ var _ufo = require("@atlaskit/editor-common/ufo");
 var _analytics2 = require("@atlaskit/editor-common/utils/analytics");
 var _state2 = require("@atlaskit/editor-prosemirror/state");
 var _view = require("@atlaskit/editor-prosemirror/view");
-var _platformFeatureFlags = require("@atlaskit/platform-feature-flags");
 var _eventDispatcher = require("../event-dispatcher");
 var _context = require("../presets/context");
 var _findChangedNodesFromTransaction = require("../utils/findChangedNodesFromTransaction");
@@ -558,10 +557,6 @@ var ReactEditorView = exports.ReactEditorView = /*#__PURE__*/function (_React$Co
     });
     var _api = _this.pluginInjectionAPI.api();
     (_props$setEditorApi = props.setEditorApi) === null || _props$setEditorApi === void 0 || _props$setEditorApi.call(props, _api);
-    if (props.editorProps.editorActions && !(0, _platformFeatureFlags.fg)('platform_editor_remove_editor_actions_workaround')) {
-      // @ts-expect-error
-      props.editorProps.editorActions.__EDITOR_INTERNALS_DO_NOT_USE__API = _api;
-    }
     _this.eventDispatcher = new _eventDispatcher.EventDispatcher();
     _this.dispatch = (0, _eventDispatcher.createDispatch)(_this.eventDispatcher);
     _this.errorReporter = (0, _createEditor.createErrorReporter)(props.editorProps.errorReporterHandler);

package/dist/cjs/version-wrapper.js

@@ -5,4 +5,4 @@ Object.defineProperty(exports, "__esModule", {
 });
 exports.version = exports.name = void 0;
 var name = exports.name = "@atlaskit/editor-core";
-var version = exports.version = "197.5.2";
+var version = exports.version = "197.5.3";

package/dist/es2019/composable-editor/editor-internal.js

@@ -9,7 +9,6 @@ import { Fragment, memo, useCallback } from 'react';
 import { css, jsx } from '@emotion/react';
 import { ACTION, ACTION_SUBJECT } from '@atlaskit/editor-common/analytics';
 import { usePortalProvider } from '@atlaskit/editor-common/portal';
-import { fg } from '@atlaskit/platform-feature-flags';
 import ErrorBoundary from '../create-editor/ErrorBoundary';
 import { createFeatureFlagsFromProps } from '../create-editor/feature-flags-from-props';
 import ReactEditorView from '../create-editor/ReactEditorView';
@@ -44,16 +43,6 @@ export const EditorInternal = /*#__PURE__*/memo(({
   AppearanceComponent
 }) => {
   var _props$performanceTra, _props$performanceTra2, _props$performanceTra3, _props$performanceTra4;
-  const setEditorApi = useCallback(
-  // eslint-disable-next-line @typescript-eslint/no-explicit-any
-  api => {
-    if (!fg('platform_editor_remove_editor_actions_workaround')) {
-      // This is an workaround to unblock Editor Lego Decoupling project, if you have questions ping us #cc-editor-lego
-      // We may clean up this code when EditorActions deprecation process starts
-      // @ts-expect-error 2339: Property '__EDITOR_INTERNALS_DO_NOT_USE__API' does not exist on type 'EditorActions<any>'.
-      editorActions.__EDITOR_INTERNALS_DO_NOT_USE__API = api;
-    }
-  }, [editorActions]);
   const overriddenEditorProps = {
     ...props,
     onSave: props.onSave ? handleSave : undefined,
@@ -95,7 +84,6 @@ export const EditorInternal = /*#__PURE__*/memo(({
     onEditorDestroyed: onEditorDestroyed,
     disabled: props.disabled,
     preset: preset,
-    setEditorApi: setEditorApi,
     render: ({
       editor,
       view,
@@ -147,9 +135,6 @@ export const EditorInternal = /*#__PURE__*/memo(({
 function ReactEditorViewContextWrapper(props) {
   var _props$editorProps$me, _props$editorProps$li, _props$editorProps$li2;
   const setInternalEditorAPI = useSetPresetContext();
-  const {
-    setEditorApi: setExternalEditorAPI
-  } = props;
 
   /**
    * We use the context to retrieve the editorAPI
@@ -163,8 +148,7 @@ function ReactEditorViewContextWrapper(props) {
   // eslint-disable-next-line @typescript-eslint/no-explicit-any
   api => {
     setInternalEditorAPI === null || setInternalEditorAPI === void 0 ? void 0 : setInternalEditorAPI(api);
-    setExternalEditorAPI === null || setExternalEditorAPI === void 0 ? void 0 : setExternalEditorAPI(api);
-  }, [setInternalEditorAPI, setExternalEditorAPI]);
+  }, [setInternalEditorAPI]);
 
   // TODO: Remove these when we deprecate these props from editor-props - smartLinks is unfortunately still used in some places, we can sidestep this problem if we move everyone across to ComposableEditor and deprecate Editor
   const UNSAFE_cards = props.editorProps.UNSAFE_cards;

package/dist/es2019/create-editor/ReactEditorView.js

@@ -16,7 +16,6 @@ import { EditorExperience, ExperienceStore, RELIABILITY_INTERVAL } from '@atlask
 import { analyticsEventKey, getAnalyticsEventSeverity } from '@atlaskit/editor-common/utils/analytics';
 import { EditorState, Selection, TextSelection } from '@atlaskit/editor-prosemirror/state';
 import { EditorView } from '@atlaskit/editor-prosemirror/view';
-import { fg } from '@atlaskit/platform-feature-flags';
 import { createDispatch, EventDispatcher } from '../event-dispatcher';
 import { EditorAPIContext } from '../presets/context';
 import { findChangedNodesFromTransaction } from '../utils/findChangedNodesFromTransaction';
@@ -557,10 +556,6 @@ export class ReactEditorView extends React.Component {
     });
     const _api = this.pluginInjectionAPI.api();
     (_props$setEditorApi = props.setEditorApi) === null || _props$setEditorApi === void 0 ? void 0 : _props$setEditorApi.call(props, _api);
-    if (props.editorProps.editorActions && !fg('platform_editor_remove_editor_actions_workaround')) {
-      // @ts-expect-error
-      props.editorProps.editorActions.__EDITOR_INTERNALS_DO_NOT_USE__API = _api;
-    }
     this.eventDispatcher = new EventDispatcher();
     this.dispatch = createDispatch(this.eventDispatcher);
     this.errorReporter = createErrorReporter(props.editorProps.errorReporterHandler);

package/dist/es2019/version-wrapper.js

@@ -1,2 +1,2 @@
 export const name = "@atlaskit/editor-core";
-export const version = "197.5.2";
+export const version = "197.5.3";

package/dist/esm/composable-editor/editor-internal.js

@@ -13,7 +13,6 @@ import { Fragment, memo, useCallback } from 'react';
 import { css, jsx } from '@emotion/react';
 import { ACTION, ACTION_SUBJECT } from '@atlaskit/editor-common/analytics';
 import { usePortalProvider } from '@atlaskit/editor-common/portal';
-import { fg } from '@atlaskit/platform-feature-flags';
 import ErrorBoundary from '../create-editor/ErrorBoundary';
 import { createFeatureFlagsFromProps } from '../create-editor/feature-flags-from-props';
 import ReactEditorView from '../create-editor/ReactEditorView';
@@ -47,16 +46,6 @@ export var EditorInternal = /*#__PURE__*/memo(function (_ref) {
     onEditorDestroyed = _ref.onEditorDestroyed,
     preset = _ref.preset,
     AppearanceComponent = _ref.AppearanceComponent;
-  var setEditorApi = useCallback(
-  // eslint-disable-next-line @typescript-eslint/no-explicit-any
-  function (api) {
-    if (!fg('platform_editor_remove_editor_actions_workaround')) {
-      // This is an workaround to unblock Editor Lego Decoupling project, if you have questions ping us #cc-editor-lego
-      // We may clean up this code when EditorActions deprecation process starts
-      // @ts-expect-error 2339: Property '__EDITOR_INTERNALS_DO_NOT_USE__API' does not exist on type 'EditorActions<any>'.
-      editorActions.__EDITOR_INTERNALS_DO_NOT_USE__API = api;
-    }
-  }, [editorActions]);
   var overriddenEditorProps = _objectSpread(_objectSpread({}, props), {}, {
     onSave: props.onSave ? handleSave : undefined,
     // noop all analytic events, even if a handler is still passed.
@@ -100,7 +89,6 @@ export var EditorInternal = /*#__PURE__*/memo(function (_ref) {
     onEditorDestroyed: onEditorDestroyed,
     disabled: props.disabled,
     preset: preset,
-    setEditorApi: setEditorApi,
     render: function render(_ref2) {
       var _props$featureFlags, _props$featureFlags2;
       var editor = _ref2.editor,
@@ -151,7 +139,6 @@ export var EditorInternal = /*#__PURE__*/memo(function (_ref) {
 function ReactEditorViewContextWrapper(props) {
   var _props$editorProps$me, _props$editorProps$li;
   var setInternalEditorAPI = useSetPresetContext();
-  var setExternalEditorAPI = props.setEditorApi;
 
   /**
    * We use the context to retrieve the editorAPI
@@ -165,8 +152,7 @@ function ReactEditorViewContextWrapper(props) {
   // eslint-disable-next-line @typescript-eslint/no-explicit-any
   function (api) {
     setInternalEditorAPI === null || setInternalEditorAPI === void 0 || setInternalEditorAPI(api);
-    setExternalEditorAPI === null || setExternalEditorAPI === void 0 || setExternalEditorAPI(api);
-  }, [setInternalEditorAPI, setExternalEditorAPI]);
+  }, [setInternalEditorAPI]);
 
   // TODO: Remove these when we deprecate these props from editor-props - smartLinks is unfortunately still used in some places, we can sidestep this problem if we move everyone across to ComposableEditor and deprecate Editor
   var UNSAFE_cards = props.editorProps.UNSAFE_cards;

package/dist/esm/create-editor/ReactEditorView.js

@@ -27,7 +27,6 @@ import { EditorExperience, ExperienceStore, RELIABILITY_INTERVAL } from '@atlask
 import { analyticsEventKey, getAnalyticsEventSeverity } from '@atlaskit/editor-common/utils/analytics';
 import { EditorState, Selection, TextSelection } from '@atlaskit/editor-prosemirror/state';
 import { EditorView } from '@atlaskit/editor-prosemirror/view';
-import { fg } from '@atlaskit/platform-feature-flags';
 import { createDispatch, EventDispatcher } from '../event-dispatcher';
 import { EditorAPIContext } from '../presets/context';
 import { findChangedNodesFromTransaction } from '../utils/findChangedNodesFromTransaction';
@@ -551,10 +550,6 @@ export var ReactEditorView = /*#__PURE__*/function (_React$Component) {
     });
     var _api = _this.pluginInjectionAPI.api();
     (_props$setEditorApi = props.setEditorApi) === null || _props$setEditorApi === void 0 || _props$setEditorApi.call(props, _api);
-    if (props.editorProps.editorActions && !fg('platform_editor_remove_editor_actions_workaround')) {
-      // @ts-expect-error
-      props.editorProps.editorActions.__EDITOR_INTERNALS_DO_NOT_USE__API = _api;
-    }
     _this.eventDispatcher = new EventDispatcher();
     _this.dispatch = createDispatch(_this.eventDispatcher);
     _this.errorReporter = createErrorReporter(props.editorProps.errorReporterHandler);

package/dist/esm/version-wrapper.js

@@ -1,2 +1,2 @@
 export var name = "@atlaskit/editor-core";
-export var version = "197.5.2";
+export var version = "197.5.3";

package/package.json

@@ -1,6 +1,6 @@
 {
 	"name": "@atlaskit/editor-core",
-	"version": "197.5.2",
+	"version": "197.5.3",
 	"description": "A package contains Atlassian editor core functionality",
 	"publishConfig": {
 		"registry": "https://registry.npmjs.org/"
@@ -49,7 +49,7 @@
 		"@atlaskit/editor-prosemirror": "6.0.0",
 		"@atlaskit/editor-shared-styles": "^2.13.0",
 		"@atlaskit/emoji": "^67.7.0",
-		"@atlaskit/icon": "^22.16.0",
+		"@atlaskit/icon": "^22.17.0",
 		"@atlaskit/media-card": "^78.2.0",
 		"@atlaskit/mention": "^23.2.0",
 		"@atlaskit/platform-feature-flags": "^0.3.0",
@@ -188,9 +188,6 @@
 			"type": "boolean",
 			"referenceOnly": "true"
 		},
-		"platform_editor_remove_editor_actions_workaround": {
-			"type": "boolean"
-		},
 		"platform.editor.table.use-shared-state-hook": {
 			"type": "boolean",
 			"referenceOnly": true