@atlaskit/editor-core 193.28.0 → 193.28.4

package/CHANGELOG.md

@@ -1,5 +1,14 @@
 # @atlaskit/editor-core
 
+## 193.28.4
+
+### Patch Changes
+
+- [#114683](https://stash.atlassian.com/projects/CONFCLOUD/repos/confluence-frontend/pull-requests/114683)
+  [`ff0815316ab38`](https://stash.atlassian.com/projects/CONFCLOUD/repos/confluence-frontend/commits/ff0815316ab38) -
+  Removes usage of custom theme button in places where its API is not being used and the default
+  button is able to be used instead. This should give a slight performance (runtime) improvement.
+
 ## 193.28.0
 
 ### Minor Changes

package/afm-jira/tsconfig.json

@@ -0,0 +1,85 @@
+{
+  "extends": "../../../../tsconfig.entry-points.jira.json",
+  "compilerOptions": {
+    "declaration": true,
+    "target": "es5",
+    "outDir": "../../../../../tsDist/@atlaskit__editor-core/app",
+    "composite": true,
+    "rootDir": "../"
+  },
+  "include": [
+    "../src/**/*.ts",
+    "../src/**/*.tsx"
+  ],
+  "exclude": [
+    "../src/**/__tests__/*",
+    "../src/**/*.test.*",
+    "../src/**/test.*",
+    "../src/stories/*"
+  ],
+  "references": [
+    {
+      "path": "../../activity-provider/afm-jira/tsconfig.json"
+    },
+    {
+      "path": "../../../analytics/analytics-namespaced-context/afm-jira/tsconfig.json"
+    },
+    {
+      "path": "../../../analytics/analytics-next/afm-jira/tsconfig.json"
+    },
+    {
+      "path": "../../../design-system/button/afm-jira/tsconfig.json"
+    },
+    {
+      "path": "../../editor-common/afm-jira/tsconfig.json"
+    },
+    {
+      "path": "../../editor-json-transformer/afm-jira/tsconfig.json"
+    },
+    {
+      "path": "../../editor-plugins/afm-jira/tsconfig.json"
+    },
+    {
+      "path": "../../editor-shared-styles/afm-jira/tsconfig.json"
+    },
+    {
+      "path": "../../../elements/emoji/afm-jira/tsconfig.json"
+    },
+    {
+      "path": "../../../design-system/icon/afm-jira/tsconfig.json"
+    },
+    {
+      "path": "../../../media/media-card/afm-jira/tsconfig.json"
+    },
+    {
+      "path": "../../../elements/mention/afm-jira/tsconfig.json"
+    },
+    {
+      "path": "../../../platform/feature-flags/afm-jira/tsconfig.json"
+    },
+    {
+      "path": "../../../design-system/spinner/afm-jira/tsconfig.json"
+    },
+    {
+      "path": "../../../elements/task-decision/afm-jira/tsconfig.json"
+    },
+    {
+      "path": "../../../design-system/theme/afm-jira/tsconfig.json"
+    },
+    {
+      "path": "../../../design-system/tokens/afm-jira/tsconfig.json"
+    },
+    {
+      "path": "../../../design-system/tooltip/afm-jira/tsconfig.json"
+    },
+    {
+      "path": "../../../design-system/width-detector/afm-jira/tsconfig.json"
+    },
+    {
+      "path": "../../../linking-platform/link-provider/afm-jira/tsconfig.json"
+    },
+    {
+      "path": "../../../media/media-core/afm-jira/tsconfig.json"
+    }
+  ]
+}

package/dist/cjs/create-editor/ErrorBoundary.js

@@ -134,7 +134,7 @@ var ErrorBoundaryWithEditorView = exports.ErrorBoundaryWithEditorView = /*#__PUR
         browserInfo: attributes.browserInfo,
         error: attributes.error.toString(),
         errorInfo: {
-          componentStack: attributes.errorInfo.componentStack
+          componentStack: attributes.errorInfo.componentStack || undefined
         },
         errorId: attributes.errorId,
         browserExtensions: (_attributes$browserEx = attributes.browserExtensions) === null || _attributes$browserEx === void 0 ? void 0 : _attributes$browserEx.toString(),

package/dist/cjs/ui/Appearance/Comment/Comment.js

@@ -18,8 +18,8 @@ var _react = _interopRequireWildcard(require("react"));
 var _react2 = require("@emotion/react");
 var _classnames = _interopRequireDefault(require("classnames"));
 var _reactIntlNext = require("react-intl-next");
+var _button = _interopRequireDefault(require("@atlaskit/button"));
 var _buttonGroup = _interopRequireDefault(require("@atlaskit/button/button-group"));
-var _customThemeButton = _interopRequireDefault(require("@atlaskit/button/custom-theme-button"));
 var _hooks = require("@atlaskit/editor-common/hooks");
 var _styles = require("@atlaskit/editor-common/styles");
 var _ui = require("@atlaskit/editor-common/ui");
@@ -236,12 +236,12 @@ var Editor = /*#__PURE__*/function (_React$Component) {
       }))), showSecondaryToolbar && (0, _react2.jsx)("div", {
         css: secondaryToolbarStyles,
         "data-testid": "ak-editor-secondary-toolbar"
-      }, (0, _react2.jsx)(_buttonGroup.default, null, !!onSave && (0, _react2.jsx)(_customThemeButton.default, {
+      }, (0, _react2.jsx)(_buttonGroup.default, null, !!onSave && (0, _react2.jsx)(_button.default, {
         appearance: "primary",
         onClick: _this.handleSave,
         testId: "comment-save-button",
         isDisabled: disabled || mediaState && !mediaState.allUploadsFinished
-      }, intl.formatMessage(_messages.default.saveButton)), !!onCancel && (0, _react2.jsx)(_customThemeButton.default, {
+      }, intl.formatMessage(_messages.default.saveButton)), !!onCancel && (0, _react2.jsx)(_button.default, {
         appearance: "subtle",
         onClick: _this.handleCancel,
         isDisabled: disabled
@@ -435,12 +435,12 @@ var EditorNext = function EditorNext(props) {
   }))), showSecondaryToolbar && (0, _react2.jsx)("div", {
     css: secondaryToolbarStyles,
     "data-testid": "ak-editor-secondary-toolbar"
-  }, (0, _react2.jsx)(_buttonGroup.default, null, !!onSave && (0, _react2.jsx)(_customThemeButton.default, {
+  }, (0, _react2.jsx)(_buttonGroup.default, null, !!onSave && (0, _react2.jsx)(_button.default, {
     appearance: "primary",
     onClick: handleSave,
     testId: "comment-save-button",
     isDisabled: disabled || saveButtonDisabled
-  }, intl.formatMessage(_messages.default.saveButton)), !!onCancel && (0, _react2.jsx)(_customThemeButton.default, {
+  }, intl.formatMessage(_messages.default.saveButton)), !!onCancel && (0, _react2.jsx)(_button.default, {
     appearance: "subtle",
     onClick: handleCancel,
     isDisabled: disabled

package/dist/cjs/ui/ToolbarFeedback/index.js

@@ -19,8 +19,8 @@ var _react = require("react");
 var _react2 = require("@emotion/react");
 var _propTypes = _interopRequireDefault(require("prop-types"));
 var _reactDom = _interopRequireDefault(require("react-dom"));
+var _button = _interopRequireDefault(require("@atlaskit/button"));
 var _buttonGroup = _interopRequireDefault(require("@atlaskit/button/button-group"));
-var _customThemeButton = _interopRequireDefault(require("@atlaskit/button/custom-theme-button"));
 var _analytics = require("@atlaskit/editor-common/analytics");
 var _ui = require("@atlaskit/editor-common/ui");
 var _utils = require("@atlaskit/editor-common/utils");
@@ -193,10 +193,10 @@ var ToolbarFeedbackInternal = /*#__PURE__*/function (_PureComponent) {
         src: EDITOR_IMAGE_URL
       })), (0, _react2.jsx)("div", {
         css: _styles.confirmationText
-      }, (0, _react2.jsx)("div", null, "We are rolling out a new editing experience across Atlassian products. Help us improve by providing feedback."), (0, _react2.jsx)("div", null, "You can opt-out for now by turning off the \"Atlassian Editor\" feature on the Labs page in Bitbucket settings."), (0, _react2.jsx)(_buttonGroup.default, null, (0, _react2.jsx)(_customThemeButton.default, {
+      }, (0, _react2.jsx)("div", null, "We are rolling out a new editing experience across Atlassian products. Help us improve by providing feedback."), (0, _react2.jsx)("div", null, "You can opt-out for now by turning off the \"Atlassian Editor\" feature on the Labs page in Bitbucket settings."), (0, _react2.jsx)(_buttonGroup.default, null, (0, _react2.jsx)(_button.default, {
         appearance: "primary",
         onClick: this.openFeedbackPopup
-      }, "Give feedback"), (0, _react2.jsx)(_customThemeButton.default, {
+      }, "Give feedback"), (0, _react2.jsx)(_button.default, {
         appearance: "default",
         onClick: this.openLearnMorePage
       }, "Learn more")))))) : null;

package/dist/cjs/version-wrapper.js

@@ -5,4 +5,4 @@ Object.defineProperty(exports, "__esModule", {
 });
 exports.version = exports.name = void 0;
 var name = exports.name = "@atlaskit/editor-core";
-var version = exports.version = "193.28.0";
+var version = exports.version = "193.28.4";

package/dist/es2019/create-editor/ErrorBoundary.js

@@ -85,7 +85,7 @@ export class ErrorBoundaryWithEditorView extends React.Component {
         browserInfo: attributes.browserInfo,
         error: attributes.error.toString(),
         errorInfo: {
-          componentStack: attributes.errorInfo.componentStack
+          componentStack: attributes.errorInfo.componentStack || undefined
         },
         errorId: attributes.errorId,
         browserExtensions: (_attributes$browserEx = attributes.browserExtensions) === null || _attributes$browserEx === void 0 ? void 0 : _attributes$browserEx.toString(),

package/dist/es2019/ui/Appearance/Comment/Comment.js

@@ -6,8 +6,8 @@ import React, { Fragment, useCallback, useEffect, useMemo, useState } from 'reac
 import { css, jsx } from '@emotion/react';
 import classnames from 'classnames';
 import { injectIntl } from 'react-intl-next';
+import Button from '@atlaskit/button';
 import ButtonGroup from '@atlaskit/button/button-group';
-import Button from '@atlaskit/button/custom-theme-button';
 import { useSharedPluginState } from '@atlaskit/editor-common/hooks';
 import { GRID_GUTTER } from '@atlaskit/editor-common/styles';
 import { WidthConsumer } from '@atlaskit/editor-common/ui';

package/dist/es2019/ui/ToolbarFeedback/index.js

@@ -7,8 +7,8 @@ import { PureComponent } from 'react';
 import { jsx } from '@emotion/react';
 import PropTypes from 'prop-types';
 import ReactDOM from 'react-dom';
+import Button from '@atlaskit/button';
 import ButtonGroup from '@atlaskit/button/button-group';
-import Button from '@atlaskit/button/custom-theme-button';
 import { ACTION, ACTION_SUBJECT, ACTION_SUBJECT_ID, EVENT_TYPE } from '@atlaskit/editor-common/analytics';
 import { Popup } from '@atlaskit/editor-common/ui';
 import { analyticsEventKey } from '@atlaskit/editor-common/utils';

package/dist/es2019/version-wrapper.js

@@ -1,2 +1,2 @@
 export const name = "@atlaskit/editor-core";
-export const version = "193.28.0";
+export const version = "193.28.4";

package/dist/esm/create-editor/ErrorBoundary.js

@@ -127,7 +127,7 @@ export var ErrorBoundaryWithEditorView = /*#__PURE__*/function (_React$Component
         browserInfo: attributes.browserInfo,
         error: attributes.error.toString(),
         errorInfo: {
-          componentStack: attributes.errorInfo.componentStack
+          componentStack: attributes.errorInfo.componentStack || undefined
         },
         errorId: attributes.errorId,
         browserExtensions: (_attributes$browserEx = attributes.browserExtensions) === null || _attributes$browserEx === void 0 ? void 0 : _attributes$browserEx.toString(),

package/dist/esm/ui/Appearance/Comment/Comment.js

@@ -15,8 +15,8 @@ import React, { Fragment, useCallback, useEffect, useMemo, useState } from 'reac
 import { css, jsx } from '@emotion/react';
 import classnames from 'classnames';
 import { injectIntl } from 'react-intl-next';
+import Button from '@atlaskit/button';
 import ButtonGroup from '@atlaskit/button/button-group';
-import Button from '@atlaskit/button/custom-theme-button';
 import { useSharedPluginState } from '@atlaskit/editor-common/hooks';
 import { GRID_GUTTER } from '@atlaskit/editor-common/styles';
 import { WidthConsumer } from '@atlaskit/editor-common/ui';

package/dist/esm/ui/ToolbarFeedback/index.js

@@ -19,8 +19,8 @@ import { PureComponent } from 'react';
 import { jsx } from '@emotion/react';
 import PropTypes from 'prop-types';
 import ReactDOM from 'react-dom';
+import Button from '@atlaskit/button';
 import ButtonGroup from '@atlaskit/button/button-group';
-import Button from '@atlaskit/button/custom-theme-button';
 import { ACTION, ACTION_SUBJECT, ACTION_SUBJECT_ID, EVENT_TYPE } from '@atlaskit/editor-common/analytics';
 import { Popup } from '@atlaskit/editor-common/ui';
 import { analyticsEventKey } from '@atlaskit/editor-common/utils';

package/dist/esm/version-wrapper.js

@@ -1,2 +1,2 @@
 export var name = "@atlaskit/editor-core";
-export var version = "193.28.0";
+export var version = "193.28.4";

package/dist/types/create-editor/ErrorBoundary.d.ts

@@ -1,4 +1,4 @@
-import React from 'react';
+import React, { type ErrorInfo } from 'react';
 import type { CreateUIAnalyticsEvent } from '@atlaskit/analytics-next';
 import type { ContextIdentifierProvider } from '@atlaskit/editor-common/provider-factory';
 import { ExperienceStore } from '@atlaskit/editor-common/ufo';
@@ -17,9 +17,6 @@ export type ErrorBoundaryProps = {
 export type ErrorBoundaryState = {
     error?: Error;
 };
-type AnalyticsErrorBoundaryErrorInfo = {
-    componentStack: string;
-};
 export declare class ErrorBoundaryWithEditorView extends React.Component<ErrorBoundaryProps, ErrorBoundaryState> {
     featureFlags: FeatureFlags;
     browserExtensions?: UserBrowserExtensionResults;
@@ -36,7 +33,7 @@ export declare class ErrorBoundaryWithEditorView extends React.Component<ErrorBo
     private getProductName;
     private fireAnalyticsEvent;
     private getExperienceMetadata;
-    componentDidCatch(error: Error, errorInfo: AnalyticsErrorBoundaryErrorInfo): void;
+    componentDidCatch(error: Error, errorInfo: ErrorInfo): void;
     componentDidMount(): Promise<void>;
     render(): JSX.Element;
 }

package/dist/types-ts4.5/create-editor/ErrorBoundary.d.ts

@@ -1,4 +1,4 @@
-import React from 'react';
+import React, { type ErrorInfo } from 'react';
 import type { CreateUIAnalyticsEvent } from '@atlaskit/analytics-next';
 import type { ContextIdentifierProvider } from '@atlaskit/editor-common/provider-factory';
 import { ExperienceStore } from '@atlaskit/editor-common/ufo';
@@ -17,9 +17,6 @@ export type ErrorBoundaryProps = {
 export type ErrorBoundaryState = {
     error?: Error;
 };
-type AnalyticsErrorBoundaryErrorInfo = {
-    componentStack: string;
-};
 export declare class ErrorBoundaryWithEditorView extends React.Component<ErrorBoundaryProps, ErrorBoundaryState> {
     featureFlags: FeatureFlags;
     browserExtensions?: UserBrowserExtensionResults;
@@ -36,7 +33,7 @@ export declare class ErrorBoundaryWithEditorView extends React.Component<ErrorBo
     private getProductName;
     private fireAnalyticsEvent;
     private getExperienceMetadata;
-    componentDidCatch(error: Error, errorInfo: AnalyticsErrorBoundaryErrorInfo): void;
+    componentDidCatch(error: Error, errorInfo: ErrorInfo): void;
     componentDidMount(): Promise<void>;
     render(): JSX.Element;
 }

package/package.json

@@ -1,6 +1,6 @@
 {
 	"name": "@atlaskit/editor-core",
-	"version": "193.28.0",
+	"version": "193.28.4",
 	"description": "A package contains Atlassian editor core functionality",
 	"publishConfig": {
 		"registry": "https://registry.npmjs.org/"
@@ -45,7 +45,7 @@
 		"@atlaskit/analytics-next": "^9.3.0",
 		"@atlaskit/analytics-next-stable-react-context": "1.0.1",
 		"@atlaskit/button": "^18.0.0",
-		"@atlaskit/editor-common": "^82.12.0",
+		"@atlaskit/editor-common": "^82.14.0",
 		"@atlaskit/editor-json-transformer": "^8.14.0",
 		"@atlaskit/editor-plugins": "^3.3.0",
 		"@atlaskit/editor-prosemirror": "4.0.1",
@@ -81,7 +81,7 @@
 		"react-intl-next": "npm:react-intl@^5.18.1"
 	},
 	"devDependencies": {
-		"@af/editor-examples-helpers": "0.0.6",
+		"@af/editor-examples-helpers": "0.0.8",
 		"@af/editor-libra": "*",
 		"@af/visual-regression": "*",
 		"@atlaskit/adf-utils": "^19.3.0",
@@ -99,9 +99,9 @@
 		"@atlaskit/media-integration-test-helpers": "^3.0.0",
 		"@atlaskit/media-test-helpers": "^33.0.27",
 		"@atlaskit/modal-dialog": "^12.14.0",
-		"@atlaskit/primitives": "^8.1.0",
-		"@atlaskit/renderer": "^109.34.0",
-		"@atlaskit/smart-card": "^27.6.0",
+		"@atlaskit/primitives": "^8.2.0",
+		"@atlaskit/renderer": "^109.36.0",
+		"@atlaskit/smart-card": "^27.7.0",
 		"@atlaskit/synchrony-test-helpers": "^2.4.0",
 		"@atlaskit/toggle": "^13.2.0",
 		"@atlaskit/util-data-test": "^17.9.0",