@atlaskit/editor-core 193.24.6 → 193.24.18

package/.eslintrc.js

@@ -1,39 +1,39 @@
 module.exports = {
-  rules: {
-    '@atlaskit/design-system/ensure-design-token-usage/preview': [
-      'error',
-      { domains: ['spacing'], shouldEnforceFallbacks: false },
-    ],
-    'import/no-restricted-paths': [
-      'warn',
-      {
-        zones: [
-          {
-            target: 'packages/editor/editor-core/src/**/*',
-            from: `packages/editor/editor-core/src/plugins/*/!(types)*`,
-            message:
-              '[ELR101] Avoid importing dependencies from editor plugins. Type-only imports are an exception. Move shared code to a common location. go/elr101',
-          },
-          {
-            target: 'packages/editor/editor-core/src/**/*',
-            from: `packages/editor/editor-core/src/plugins/*/!(types)**/*`,
-            message:
-              '[ELR101] Avoid importing dependencies from editor plugins. Type-only imports are an exception. Move shared code to a common location. go/elr101',
-          },
-        ],
-      },
-    ],
-  },
-  overrides: [
-    {
-      files: [
-        '**/__tests__/**/*.{js,ts,tsx}',
-        'examples/**/*.{js,ts,tsx}',
-        '**/*.{test,spec}.{js,ts,tsx}',
-      ],
-      rules: {
-        'import/no-restricted-paths': ['off'],
-      },
-    },
-  ],
+	rules: {
+		'@atlaskit/design-system/ensure-design-token-usage/preview': [
+			'error',
+			{ domains: ['spacing'], shouldEnforceFallbacks: false },
+		],
+		'import/no-restricted-paths': [
+			'warn',
+			{
+				zones: [
+					{
+						target: 'packages/editor/editor-core/src/**/*',
+						from: `packages/editor/editor-core/src/plugins/*/!(types)*`,
+						message:
+							'[ELR101] Avoid importing dependencies from editor plugins. Type-only imports are an exception. Move shared code to a common location. go/elr101',
+					},
+					{
+						target: 'packages/editor/editor-core/src/**/*',
+						from: `packages/editor/editor-core/src/plugins/*/!(types)**/*`,
+						message:
+							'[ELR101] Avoid importing dependencies from editor plugins. Type-only imports are an exception. Move shared code to a common location. go/elr101',
+					},
+				],
+			},
+		],
+	},
+	overrides: [
+		{
+			files: [
+				'**/__tests__/**/*.{js,ts,tsx}',
+				'examples/**/*.{js,ts,tsx}',
+				'**/*.{test,spec}.{js,ts,tsx}',
+			],
+			rules: {
+				'import/no-restricted-paths': ['off'],
+			},
+		},
+	],
 };

package/CHANGELOG.md

@@ -1,5 +1,21 @@
 # @atlaskit/editor-core
 
+## 193.24.18
+
+### Patch Changes
+
+- [#107335](https://stash.atlassian.com/projects/CONFCLOUD/repos/confluence-frontend/pull-requests/107335)
+  [`d5457c8afe5f`](https://stash.atlassian.com/projects/CONFCLOUD/repos/confluence-frontend/commits/d5457c8afe5f) -
+  Cleaned up FF platform.editor.media.autoselect-inserted-image_oumto
+
+## 193.24.15
+
+### Patch Changes
+
+- [#105930](https://stash.atlassian.com/projects/CONFCLOUD/repos/confluence-frontend/pull-requests/105930)
+  [`939b873db211`](https://stash.atlassian.com/projects/CONFCLOUD/repos/confluence-frontend/commits/939b873db211) -
+  [ux] Sets increased table scaling percent when FF is enabled.
+
 ## 193.24.6
 
 ### Patch Changes

package/architecture/0001-record-architecture-decisions.md

@@ -16,10 +16,13 @@ As a mechanism for a more "lightweight" RFC approach for smaller decisions.
 
 Scope could also include larger ones summarised once an RFC/DACI might be accepted.
 
-Some of the dates will be backdated to port/transfer over some of the decisions from our decision log/registry.
+Some of the dates will be backdated to port/transfer over some of the decisions from our decision
+log/registry.
 
-We will use Architecture Decision Records, as [described by Michael Nygard](http://thinkrelevance.com/blog/2011/11/15/documenting-architecture-decisions).
+We will use Architecture Decision Records, as
+[described by Michael Nygard](http://thinkrelevance.com/blog/2011/11/15/documenting-architecture-decisions).
 
 ## Consequences
 
-See Michael Nygard's article, linked above. For a lightweight ADR toolset, see Nat Pryce's [adr-tools](https://github.com/npryce/adr-tools).
+See Michael Nygard's article, linked above. For a lightweight ADR toolset, see Nat Pryce's
+[adr-tools](https://github.com/npryce/adr-tools).

package/architecture/0002-deep-equality-check-for-getsharedstate.md

@@ -12,7 +12,8 @@ via @Rodrigo Vieira https://atlassian.slack.com/archives/C046RBH9HT5/p1679018928
 
 People, we have a optimisation situation with the getSharedState.
 
-Right now, it is expect to be a pure function, That means return the same value for the same input, but you could do something like that
+Right now, it is expect to be a pure function, That means return the same value for the same input,
+but you could do something like that
 
 ```ts
 getSharedState(editorState) {
@@ -33,11 +34,9 @@ Right we are doing a shallow check before call the onChange listeners:
 ```ts
 // Dumb check - should we do a deepcheck?
 if (isInitialization || prevSharedState !== nextSharedState) {
-  (listeners.get(pluginName) || new Set<Callback>()).forEach((callback) => {
-    callbacks.push(
-      callback.bind(callback, { nextSharedState, prevSharedState }),
-    );
-  });
+	(listeners.get(pluginName) || new Set<Callback>()).forEach((callback) => {
+		callbacks.push(callback.bind(callback, { nextSharedState, prevSharedState }));
+	});
 }
 ```
 
@@ -50,7 +49,8 @@ We have two possible approaches
 
 ### Same as ProseMirror does
 
-We can give the last shared state to the getSharedState and the dev would be responsible to return the same object in case there is no change
+We can give the last shared state to the getSharedState and the dev would be responsible to return
+the same object in case there is no change
 
 ### Do a deep check
 
@@ -64,4 +64,5 @@ See https://bitbucket.org/%7B%7D/%7Bc8e2f021-38d2-46d0-9b7a-b3f7b428f724%7D/pull
 
 ## Consequences
 
-Slight additional performance cost incurred, trading off for safety against plugins having to do the deep check itself.
+Slight additional performance cost incurred, trading off for safety against plugins having to do the
+deep check itself.

package/architecture/0003-explicit-plugin-dependencies.md

@@ -16,22 +16,34 @@ This has many massive side effects, to name just a few:
 
 - Complexity!
   - devs not being able to clearly reason about the implicit dependencies between plugins
-  - extremely difficult to ship features, bug fixes, without breaking something unintended or even unrelated
+  - extremely difficult to ship features, bug fixes, without breaking something unintended or even
+    unrelated
 - Performance!
   - products not being able to integrate a lighter weight of the Atlassian Editor
-  - single bundle size whether you only use a handful of features in a small Editor, or the entire weight of the Full Page Editor
+  - single bundle size whether you only use a handful of features in a small Editor, or the entire
+    weight of the Full Page Editor
 
-We learned from the [table extraction effort](https://product-fabric.atlassian.net/wiki/spaces/E/pages/3289779107/Editor+DACI+019+Bring+Tables+back) that it was feasible to extract and untangle one of our most complex Editor Plugins, with some temporary APIs to prevent cross importing.
+We learned from the
+[table extraction effort](https://product-fabric.atlassian.net/wiki/spaces/E/pages/3289779107/Editor+DACI+019+Bring+Tables+back)
+that it was feasible to extract and untangle one of our most complex Editor Plugins, with some
+temporary APIs to prevent cross importing.
 
 ## Decision
 
-We must now prevent plugins from importing one another to reduce complexity within the Editor. In doing so, we can eliminate intricate dependency chains and, using the `getSharedState()` and `actions()` APIs, offer a clear understanding of how different plugins share their state.
+We must now prevent plugins from importing one another to reduce complexity within the Editor. In
+doing so, we can eliminate intricate dependency chains and, using the `getSharedState()` and
+`actions()` APIs, offer a clear understanding of how different plugins share their state.
 
-Although making this choice is essential, the aim is to address the initial necessity for cross imports to begin with by outlining some "migration examples" and documentation below. This ADR outlines two of the APIs that are now in place, to address some of the challenges and insights gained from the initial table plugin extraction.
+Although making this choice is essential, the aim is to address the initial necessity for cross
+imports to begin with by outlining some "migration examples" and documentation below. This ADR
+outlines two of the APIs that are now in place, to address some of the challenges and insights
+gained from the initial table plugin extraction.
 
 ### Prevention
 
-Linting errors will now be present for any new code that gets added, where we continue to attempt importing from one plugin into another. (See `ELR101`, `ELR102` in `repo-docs/content/cloud/framework/atlassian-frontend/editor/lint.md`).
+Linting errors will now be present for any new code that gets added, where we continue to attempt
+importing from one plugin into another. (See `ELR101`, `ELR102` in
+`repo-docs/content/cloud/framework/atlassian-frontend/editor/lint.md`).
 
 ### Other resources
 
@@ -42,15 +54,21 @@ Linting errors will now be present for any new code that gets added, where we co
 
 ## Consequences
 
-Devs will need to stop importing from one plugin into another, and eventually be blocked on it when we upgrade the lint error from warning to erroring.
+Devs will need to stop importing from one plugin into another, and eventually be blocked on it when
+we upgrade the lint error from warning to erroring.
 
-We are mitigating this, by presenting some samples of how to quickly migrate / "turn on" a plugin into utilising the new `actions()` and `getSharedState()` APIs in EditorPlugin.
+We are mitigating this, by presenting some samples of how to quickly migrate / "turn on" a plugin
+into utilising the new `actions()` and `getSharedState()` APIs in EditorPlugin.
 
-A brief "HOWTO" / "HOW TO" guide of how you can migrate existing or new "cross imports", and get the same functionality:
+A brief "HOWTO" / "HOW TO" guide of how you can migrate existing or new "cross imports", and get the
+same functionality:
 
 ## 1. `getSharedState()` (and `useSharedPluginState()` hook for React Components)
 
-**Problem**: Let's say you want to access the state from `Foo` plugin, into a second Plugin `Bar`. Something like `previouslyInternalStateA`. Previously, you needed to import that plugin key, and then use it. Now we can use `getSharedState()` and 2 methods `currentState()` & `onChange` methods on `api.dependencies.[plugin-name].sharedState`.
+**Problem**: Let's say you want to access the state from `Foo` plugin, into a second Plugin `Bar`.
+Something like `previouslyInternalStateA`. Previously, you needed to import that plugin key, and
+then use it. Now we can use `getSharedState()` and 2 methods `currentState()` & `onChange` methods
+on `api.dependencies.[plugin-name].sharedState`.
 
 ### **Before**
 
@@ -67,7 +85,8 @@ doSomethingBasedOnAnotherPluginInternalState(previouslyInternalStateC);
 
 ### **After**
 
-**Explicit state dependency**, `Foo` plugin "pushes" out, explicitly publicly, shares state surfaced from `internalFooPlugin` prosemirror state internals, for _any_ plugin to use.
+**Explicit state dependency**, `Foo` plugin "pushes" out, explicitly publicly, shares state surfaced
+from `internalFooPlugin` prosemirror state internals, for _any_ plugin to use.
 
 ### Usage inside general `EditorPlugin` and prosemirror plugins:
 
@@ -172,7 +191,8 @@ const fooPlugin: NextEditorPlugin <...> {
 
 ### Usage inside a React component
 
-(See date plugin at `packages/editor/editor-plugin-date/src/plugin.tsx` for a full code sample of using `useSharedPluginState`)
+(See date plugin at `packages/editor/editor-plugin-date/src/plugin.tsx` for a full code sample of
+using `useSharedPluginState`)
 
 ```ts
 // editor-core/src/plugins/bar-some-react-component-based-plugin/index.tsx
@@ -204,19 +224,28 @@ const barPlugin: NextEditorPlugin<
 
 Important parts to note:
 
-1. You will need to implement a new `getSharedState()` function inside the current `EditorPlugin` that you require the state from, to expose any "public state" that you would like to make available to other plugins. **Treat this state as "public API" for other plugins**, as any plugin will be able to depend on this and react to it.
+1. You will need to implement a new `getSharedState()` function inside the current `EditorPlugin`
+   that you require the state from, to expose any "public state" that you would like to make
+   available to other plugins. **Treat this state as "public API" for other plugins**, as any plugin
+   will be able to depend on this and react to it.
 
-2. You _may_ need to update `packages/editor/editor-core/src/labs/next/presets/universal.ts`, if you are creating a new EditorPlugin to depend on.
+2. You _may_ need to update `packages/editor/editor-core/src/labs/next/presets/universal.ts`, if you
+   are creating a new EditorPlugin to depend on.
 
-3. Anywhere where we used to use `WithPluginState` and import plugin keys, you can now use `useSharedPluginState`
+3. Anywhere where we used to use `WithPluginState` and import plugin keys, you can now use
+   `useSharedPluginState`
 
 ## 2. `actions()`
 
-For a full code sample, please see `actions()` implementation in https://bitbucket.org/atlassian/atlassian-frontend/pull-requests/31264?w=1#chg_packages/editor/editor-core/src/plugins/analytics/plugin.ts_newline116
+For a full code sample, please see `actions()` implementation in
+https://bitbucket.org/atlassian/atlassian-frontend/pull-requests/31264?w=1#chg_packages/editor/editor-core/src/plugins/analytics/plugin.ts_newline116
 
-Our first attempt with actions, was on the analytics plugin, which touches almost all plugins and surfaced some other issues. However the same approach can be applied at a smaller scale, for smaller plugins that have "cross action dependencies".
+Our first attempt with actions, was on the analytics plugin, which touches almost all plugins and
+surfaced some other issues. However the same approach can be applied at a smaller scale, for smaller
+plugins that have "cross action dependencies".
 
-**Problem**: Let's say you had an "`addAnalytics()`" action, used in the `Foo` plugin, and wanted to use it inside of a second, `Bar` plugin.
+**Problem**: Let's say you had an "`addAnalytics()`" action, used in the `Foo` plugin, and wanted to
+use it inside of a second, `Bar` plugin.
 
 ### **Before**
 

package/codemods/140.0.0-rc-kraken-fix-type-errors.ts

@@ -1,8 +1,6 @@
 import { removeConfigPanelWidthProp } from './migrates/remove-config-panel-width-prop';
 import { createTransformer } from './utils';
 
-const transformer = createTransformer('@atlaskit/editor-core', [
-  removeConfigPanelWidthProp,
-]);
+const transformer = createTransformer('@atlaskit/editor-core', [removeConfigPanelWidthProp]);
 
 export default transformer;

package/codemods/145.0.0-deprecate-props.ts

@@ -1,8 +1,6 @@
 import { renameUnsafeCardProp } from './migrates/rename-unsafe-cards-prop';
 import { createTransformer } from './utils';
 
-const transformer = createTransformer('@atlaskit/editor-core', [
-  renameUnsafeCardProp,
-]);
+const transformer = createTransformer('@atlaskit/editor-core', [renameUnsafeCardProp]);
 
 export default transformer;

package/codemods/172.0.0-transform-smartlinks-prop.ts

@@ -1,8 +1,6 @@
 import { renameSmartLinksProp } from './migrates/rename-smartlinks-prop';
 import { createTransformer } from './utils';
 
-const transformer = createTransformer('@atlaskit/editor-core', [
-  renameSmartLinksProp,
-]);
+const transformer = createTransformer('@atlaskit/editor-core', [renameSmartLinksProp]);
 
 export default transformer;

package/codemods/175.0.0-rename-unsafe-allowUndoRedoButton-prop.ts

@@ -2,7 +2,7 @@ import { renameUnsafeAllowUndoRedoButtonsProp } from './migrates/rename-unsafe-a
 import { createTransformer } from './utils';
 
 const transformer = createTransformer('@atlaskit/editor-core', [
-  renameUnsafeAllowUndoRedoButtonsProp,
+	renameUnsafeAllowUndoRedoButtonsProp,
 ]);
 
 export default transformer;

package/codemods/180.1.0-update-to-editor-migration-component.ts

@@ -1,8 +1,6 @@
 import { renameEditorToMigrationComponent } from './migrates/rename-editor-to-editor-migration-component';
 import { createTransformer } from './utils';
 
-const transformer = createTransformer('@atlaskit/editor-core', [
-  renameEditorToMigrationComponent,
-]);
+const transformer = createTransformer('@atlaskit/editor-core', [renameEditorToMigrationComponent]);
 
 export default transformer;

package/codemods/__tests__/next-remove-allow-more-text-colors-prop.ts

@@ -4,14 +4,12 @@ import { createTransformer } from '../utils';
 
 // This stays as require() since changing to import will trigger a linter error
 const defineInlineTest = require('jscodeshift/dist/testUtils').defineInlineTest;
-const transformer = createTransformer('@atlaskit/editor-core', [
-  removeAllowMoreColorsProp,
-]);
+const transformer = createTransformer('@atlaskit/editor-core', [removeAllowMoreColorsProp]);
 describe('remove `allowMoreTextColors` field from `allowTextColor` Editor prop.', () => {
-  defineInlineTest(
-    { default: transformer, parser: 'tsx' },
-    {},
-    `
+	defineInlineTest(
+		{ default: transformer, parser: 'tsx' },
+		{},
+		`
     import React from 'react';
     import { Editor } from '@atlaskit/editor-core';
     export default () => <Editor
@@ -24,7 +22,7 @@ describe('remove `allowMoreTextColors` field from `allowTextColor` Editor prop.'
       allowStatus={true}
     />
     `, // -----
-    `
+		`
     import React from 'react';
     import { Editor } from '@atlaskit/editor-core';
     export default () => <Editor
@@ -36,12 +34,12 @@ describe('remove `allowMoreTextColors` field from `allowTextColor` Editor prop.'
       allowStatus={true}
     />
     `, // -----
-    'remove allowMoreTextColors field if it exists',
-  );
-  defineInlineTest(
-    { default: transformer, parser: 'tsx' },
-    {},
-    `
+		'remove allowMoreTextColors field if it exists',
+	);
+	defineInlineTest(
+		{ default: transformer, parser: 'tsx' },
+		{},
+		`
     import React from 'react';
     import { Editor } from '@atlaskit/editor-core';
     export default () => <Editor
@@ -53,7 +51,7 @@ describe('remove `allowMoreTextColors` field from `allowTextColor` Editor prop.'
       }
     />
     `, // -----
-    `
+		`
     import React from 'react';
     import { Editor } from '@atlaskit/editor-core';
     export default () => <Editor
@@ -61,12 +59,12 @@ describe('remove `allowMoreTextColors` field from `allowTextColor` Editor prop.'
       allowTextColor={true}
     />
     `, // -----
-    'set allowTextColor prop value to `true` if allowMoreTextColors is its only field',
-  );
-  defineInlineTest(
-    { default: transformer, parser: 'tsx' },
-    {},
-    `
+		'set allowTextColor prop value to `true` if allowMoreTextColors is its only field',
+	);
+	defineInlineTest(
+		{ default: transformer, parser: 'tsx' },
+		{},
+		`
     import React from 'react';
     import { Editor as MyEditor } from '@atlaskit/editor-core';
     export default () => <Editor
@@ -79,7 +77,7 @@ describe('remove `allowMoreTextColors` field from `allowTextColor` Editor prop.'
       }
     />
     `, // -----
-    `
+		`
     import React from 'react';
     import { Editor as MyEditor } from '@atlaskit/editor-core';
     export default () => <Editor
@@ -91,12 +89,12 @@ describe('remove `allowMoreTextColors` field from `allowTextColor` Editor prop.'
       }
     />
     `, // -----
-    'remove allowMoreTextColors prop prop when Editor is renamed',
-  );
-  defineInlineTest(
-    { default: transformer, parser: 'tsx' },
-    {},
-    `
+		'remove allowMoreTextColors prop prop when Editor is renamed',
+	);
+	defineInlineTest(
+		{ default: transformer, parser: 'tsx' },
+		{},
+		`
     import React from 'react';
     const Editor = (props) => {
       <div>{props.children}</div>
@@ -111,7 +109,7 @@ describe('remove `allowMoreTextColors` field from `allowTextColor` Editor prop.'
       }
     />
     `, // -----
-    `
+		`
     import React from 'react';
     const Editor = (props) => {
       <div>{props.children}</div>
@@ -126,6 +124,6 @@ describe('remove `allowMoreTextColors` field from `allowTextColor` Editor prop.'
       }
     />
     `, // -----
-    'only remove allowMoreTextColors prop for Editor from @atlaskit/editor-core',
-  );
+		'only remove allowMoreTextColors prop for Editor from @atlaskit/editor-core',
+	);
 });

package/codemods/__tests__/remove-config-panel-width-prop.ts

@@ -6,15 +6,13 @@ import { createTransformer } from '../utils';
 // This stays as require() since changing to import will trigger a linter error
 const defineInlineTest = require('jscodeshift/dist/testUtils').defineInlineTest;
 
-const transformer = createTransformer('@atlaskit/editor-core', [
-  removeConfigPanelWidthProp,
-]);
+const transformer = createTransformer('@atlaskit/editor-core', [removeConfigPanelWidthProp]);
 
 describe('Remove ContextPanel "width" prop', () => {
-  defineInlineTest(
-    { default: transformer, parser: 'tsx' },
-    {},
-    `
+	defineInlineTest(
+		{ default: transformer, parser: 'tsx' },
+		{},
+		`
     import React from 'react';
     import { ContextPanel } from '@atlaskit/editor-core';
 
@@ -24,7 +22,7 @@ describe('Remove ContextPanel "width" prop', () => {
       </ContextPanel>
     );
     `, // -----
-    `
+		`
     import React from 'react';
     import { ContextPanel } from '@atlaskit/editor-core';
 
@@ -34,13 +32,13 @@ describe('Remove ContextPanel "width" prop', () => {
       </ContextPanel>
     );
     `, // -----
-    'remove if width prop is set',
-  );
+		'remove if width prop is set',
+	);
 
-  defineInlineTest(
-    { default: transformer, parser: 'tsx' },
-    {},
-    `
+	defineInlineTest(
+		{ default: transformer, parser: 'tsx' },
+		{},
+		`
     import React from 'react';
     import { ContextPanel } from '@atlaskit/editor-core';
 
@@ -50,7 +48,7 @@ describe('Remove ContextPanel "width" prop', () => {
       </ContextPanel>
     );
     `, // -----
-    `
+		`
     import React from 'react';
     import { ContextPanel } from '@atlaskit/editor-core';
 
@@ -60,13 +58,13 @@ describe('Remove ContextPanel "width" prop', () => {
       </ContextPanel>
     );
     `, // -----
-    'remove nothing if width prop not set',
-  );
+		'remove nothing if width prop not set',
+	);
 
-  defineInlineTest(
-    { default: transformer, parser: 'tsx' },
-    {},
-    `
+	defineInlineTest(
+		{ default: transformer, parser: 'tsx' },
+		{},
+		`
     import React from 'react';
     import { ContextPanel as AKContextPanel } from '@atlaskit/editor-core';
 
@@ -76,7 +74,7 @@ describe('Remove ContextPanel "width" prop', () => {
       </AKContextPanel>
     );
     `, // -----
-    `
+		`
     import React from 'react';
     import { ContextPanel as AKContextPanel } from '@atlaskit/editor-core';
 
@@ -86,13 +84,13 @@ describe('Remove ContextPanel "width" prop', () => {
       </AKContextPanel>
     );
     `, // -----
-    'remove width prop when ContextPanel is renamed',
-  );
+		'remove width prop when ContextPanel is renamed',
+	);
 
-  defineInlineTest(
-    { default: transformer, parser: 'tsx' },
-    {},
-    `
+	defineInlineTest(
+		{ default: transformer, parser: 'tsx' },
+		{},
+		`
     import React from 'react';
 
     const ContextPanel = (props) => {
@@ -105,7 +103,7 @@ describe('Remove ContextPanel "width" prop', () => {
       </ContextPanel>
     );
     `, // -----
-    `
+		`
     import React from 'react';
 
     const ContextPanel = (props) => {
@@ -118,6 +116,6 @@ describe('Remove ContextPanel "width" prop', () => {
       </ContextPanel>
     );
     `, // -----
-    'only remove width for ContextPanel from @atlaskit/editor-core',
-  );
+		'only remove width for ContextPanel from @atlaskit/editor-core',
+	);
 });