@atlaskit/editor-core 193.10.11 → 193.10.19

package/CHANGELOG.md

@@ -1,5 +1,17 @@
 # @atlaskit/editor-core
 
+## 193.10.19
+
+### Patch Changes
+
+- [#92786](https://stash.atlassian.com/projects/CONFCLOUD/repos/confluence-frontend/pull-requests/92786) [`1dc6fc4f1a1d`](https://stash.atlassian.com/projects/CONFCLOUD/repos/confluence-frontend/commits/1dc6fc4f1a1d) - fix: onPluginObservation type error with collab plugin state being empty
+
+## 193.10.12
+
+### Patch Changes
+
+- [#91801](https://stash.atlassian.com/projects/CONFCLOUD/repos/confluence-frontend/pull-requests/91801) [`6d8876d9f604`](https://stash.atlassian.com/projects/CONFCLOUD/repos/confluence-frontend/commits/6d8876d9f604) - [ux] ED-23023: Fix for comments on media button visible in template editor
+
 ## 193.10.11
 
 ### Patch Changes

package/dist/cjs/create-editor/ReactEditorView.js

@@ -102,7 +102,7 @@ var ReactEditorView = exports.ReactEditorView = /*#__PURE__*/function (_React$Co
         eventType: _analytics.EVENT_TYPE.OPERATIONAL,
         attributes: {
           report: report,
-          participants: ((_this$pluginInjection = _this.pluginInjectionAPI.api().collabEdit) === null || _this$pluginInjection === void 0 ? void 0 : _this$pluginInjection.sharedState.currentState().participants.size()) || 1
+          participants: ((_this$pluginInjection = _this.pluginInjectionAPI.api().collabEdit) === null || _this$pluginInjection === void 0 || (_this$pluginInjection = _this$pluginInjection.sharedState.currentState()) === null || _this$pluginInjection === void 0 || (_this$pluginInjection = _this$pluginInjection.participants) === null || _this$pluginInjection === void 0 ? void 0 : _this$pluginInjection.size()) || 1
         }
       });
     });

package/dist/cjs/presets/universal.js

@@ -108,7 +108,7 @@ function createUniversalPreset(appearance, props, featureFlags, prevAppearance,
     allowLazyLoading: !isMobile,
     allowBreakoutSnapPoints: isFullPage,
     allowAdvancedToolBarOptions: typeof ((_props$media = props.media) === null || _props$media === void 0 ? void 0 : _props$media.allowAdvancedToolBarOptions) !== 'undefined' ? (_props$media2 = props.media) === null || _props$media2 === void 0 ? void 0 : _props$media2.allowAdvancedToolBarOptions : isFullPage || isComment,
-    allowCommentsOnMedia: isFullPage,
+    allowCommentsOnMedia: isFullPage && Boolean(props.annotationProviders),
     allowDropzoneDropLine: isFullPage,
     allowMediaSingleEditable: !isMobile,
     allowRemoteDimensionsFetch: !isMobile,

package/dist/cjs/version-wrapper.js

@@ -5,4 +5,4 @@ Object.defineProperty(exports, "__esModule", {
 });
 exports.version = exports.name = void 0;
 var name = exports.name = "@atlaskit/editor-core";
-var version = exports.version = "193.10.11";
+var version = exports.version = "193.10.19";

package/dist/es2019/create-editor/ReactEditorView.js

@@ -93,14 +93,14 @@ export class ReactEditorView extends React.Component {
     // so we allow transactions by default, to avoid discarding the initial one.
     _defineProperty(this, "canDispatchTransactions", true);
     _defineProperty(this, "onPluginObservation", report => {
-      var _this$pluginInjection;
+      var _this$pluginInjection, _this$pluginInjection2, _this$pluginInjection3;
       this.dispatchAnalyticsEvent({
         action: ACTION.TRANSACTION_DISPATCHED,
         actionSubject: ACTION_SUBJECT.EDITOR,
         eventType: EVENT_TYPE.OPERATIONAL,
         attributes: {
           report,
-          participants: ((_this$pluginInjection = this.pluginInjectionAPI.api().collabEdit) === null || _this$pluginInjection === void 0 ? void 0 : _this$pluginInjection.sharedState.currentState().participants.size()) || 1
+          participants: ((_this$pluginInjection = this.pluginInjectionAPI.api().collabEdit) === null || _this$pluginInjection === void 0 ? void 0 : (_this$pluginInjection2 = _this$pluginInjection.sharedState.currentState()) === null || _this$pluginInjection2 === void 0 ? void 0 : (_this$pluginInjection3 = _this$pluginInjection2.participants) === null || _this$pluginInjection3 === void 0 ? void 0 : _this$pluginInjection3.size()) || 1
         }
       });
     });
@@ -398,10 +398,10 @@ export class ReactEditorView extends React.Component {
         const forceSeverityTracking = typeof proseMirrorRenderedTracking === 'undefined' && shouldForceTracking();
         this.proseMirrorRenderedSeverity = !!forceSeverityTracking || proseMirrorRenderedTracking !== null && proseMirrorRenderedTracking !== void 0 && proseMirrorRenderedTracking.trackSeverity ? getAnalyticsEventSeverity(duration, (_proseMirrorRenderedT = proseMirrorRenderedTracking === null || proseMirrorRenderedTracking === void 0 ? void 0 : proseMirrorRenderedTracking.severityNormalThreshold) !== null && _proseMirrorRenderedT !== void 0 ? _proseMirrorRenderedT : PROSEMIRROR_RENDERED_NORMAL_SEVERITY_THRESHOLD, (_proseMirrorRenderedT2 = proseMirrorRenderedTracking === null || proseMirrorRenderedTracking === void 0 ? void 0 : proseMirrorRenderedTracking.severityDegradedThreshold) !== null && _proseMirrorRenderedT2 !== void 0 ? _proseMirrorRenderedT2 : PROSEMIRROR_RENDERED_DEGRADED_SEVERITY_THRESHOLD) : undefined;
         if (this.view) {
-          var _this$pluginInjection2, _this$experienceStore10;
+          var _this$pluginInjection4, _this$experienceStore10;
           const nodes = getNodesCount(this.view.state.doc);
           const ttfb = getResponseEndTime();
-          const contextIdentifier = (_this$pluginInjection2 = this.pluginInjectionAPI.api().base) === null || _this$pluginInjection2 === void 0 ? void 0 : _this$pluginInjection2.sharedState.currentState();
+          const contextIdentifier = (_this$pluginInjection4 = this.pluginInjectionAPI.api().base) === null || _this$pluginInjection4 === void 0 ? void 0 : _this$pluginInjection4.sharedState.currentState();
           this.dispatchAnalyticsEvent({
             action: ACTION.PROSEMIRROR_RENDERED,
             actionSubject: ACTION_SUBJECT.EDITOR,

package/dist/es2019/presets/universal.js

@@ -97,7 +97,7 @@ export default function createUniversalPreset(appearance, props, featureFlags, p
     allowLazyLoading: !isMobile,
     allowBreakoutSnapPoints: isFullPage,
     allowAdvancedToolBarOptions: typeof ((_props$media = props.media) === null || _props$media === void 0 ? void 0 : _props$media.allowAdvancedToolBarOptions) !== 'undefined' ? (_props$media2 = props.media) === null || _props$media2 === void 0 ? void 0 : _props$media2.allowAdvancedToolBarOptions : isFullPage || isComment,
-    allowCommentsOnMedia: isFullPage,
+    allowCommentsOnMedia: isFullPage && Boolean(props.annotationProviders),
     allowDropzoneDropLine: isFullPage,
     allowMediaSingleEditable: !isMobile,
     allowRemoteDimensionsFetch: !isMobile,

package/dist/es2019/version-wrapper.js

@@ -1,2 +1,2 @@
 export const name = "@atlaskit/editor-core";
-export const version = "193.10.11";
+export const version = "193.10.19";

package/dist/esm/create-editor/ReactEditorView.js

@@ -96,7 +96,7 @@ export var ReactEditorView = /*#__PURE__*/function (_React$Component) {
         eventType: EVENT_TYPE.OPERATIONAL,
         attributes: {
           report: report,
-          participants: ((_this$pluginInjection = _this.pluginInjectionAPI.api().collabEdit) === null || _this$pluginInjection === void 0 ? void 0 : _this$pluginInjection.sharedState.currentState().participants.size()) || 1
+          participants: ((_this$pluginInjection = _this.pluginInjectionAPI.api().collabEdit) === null || _this$pluginInjection === void 0 || (_this$pluginInjection = _this$pluginInjection.sharedState.currentState()) === null || _this$pluginInjection === void 0 || (_this$pluginInjection = _this$pluginInjection.participants) === null || _this$pluginInjection === void 0 ? void 0 : _this$pluginInjection.size()) || 1
         }
       });
     });

package/dist/esm/presets/universal.js

@@ -100,7 +100,7 @@ export default function createUniversalPreset(appearance, props, featureFlags, p
     allowLazyLoading: !isMobile,
     allowBreakoutSnapPoints: isFullPage,
     allowAdvancedToolBarOptions: typeof ((_props$media = props.media) === null || _props$media === void 0 ? void 0 : _props$media.allowAdvancedToolBarOptions) !== 'undefined' ? (_props$media2 = props.media) === null || _props$media2 === void 0 ? void 0 : _props$media2.allowAdvancedToolBarOptions : isFullPage || isComment,
-    allowCommentsOnMedia: isFullPage,
+    allowCommentsOnMedia: isFullPage && Boolean(props.annotationProviders),
     allowDropzoneDropLine: isFullPage,
     allowMediaSingleEditable: !isMobile,
     allowRemoteDimensionsFetch: !isMobile,

package/dist/esm/version-wrapper.js

@@ -1,2 +1,2 @@
 export var name = "@atlaskit/editor-core";
-export var version = "193.10.11";
+export var version = "193.10.19";

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@atlaskit/editor-core",
-  "version": "193.10.11",
+  "version": "193.10.19",
   "description": "A package contains Atlassian editor core functionality",
   "publishConfig": {
     "registry": "https://registry.npmjs.org/"
@@ -45,9 +45,9 @@
     "@atlaskit/analytics-next": "^9.2.0",
     "@atlaskit/analytics-next-stable-react-context": "1.0.1",
     "@atlaskit/button": "^17.12.0",
-    "@atlaskit/editor-common": "^78.29.0",
+    "@atlaskit/editor-common": "^78.30.0",
     "@atlaskit/editor-json-transformer": "^8.10.0",
-    "@atlaskit/editor-plugins": "^2.2.0",
+    "@atlaskit/editor-plugins": "^2.3.0",
     "@atlaskit/editor-prosemirror": "3.0.0",
     "@atlaskit/editor-shared-styles": "^2.9.0",
     "@atlaskit/emoji": "^67.6.0",
@@ -87,15 +87,15 @@
     "@atlaskit/adf-utils": "^19.0.0",
     "@atlaskit/analytics-listeners": "^8.9.1",
     "@atlaskit/checkbox": "^13.1.0",
-    "@atlaskit/collab-provider": "9.26.2",
+    "@atlaskit/collab-provider": "9.26.5",
     "@atlaskit/dropdown-menu": "^12.9.0",
-    "@atlaskit/editor-plugin-annotation": "1.5.9",
+    "@atlaskit/editor-plugin-annotation": "1.5.10",
     "@atlaskit/editor-plugin-card": "^1.8.0",
     "@atlaskit/editor-plugin-editor-viewmode": "^1.0.0",
     "@atlaskit/editor-plugin-list": "^3.1.5",
     "@atlaskit/editor-plugin-paste": "^1.0.0",
     "@atlaskit/editor-test-helpers": "*",
-    "@atlaskit/flag": "^15.3.0",
+    "@atlaskit/flag": "^15.4.0",
     "@atlaskit/link-provider": "^1.9.0",
     "@atlaskit/link-test-helpers": "^7.0.0",
     "@atlaskit/logo": "^13.15.0",
@@ -113,7 +113,7 @@
     "@atlassian/adf-schema-json": "^1.0.7",
     "@atlassian/atlassian-frontend-prettier-config-1.0.1": "npm:@atlassian/atlassian-frontend-prettier-config@1.0.1",
     "@atlassian/link-picker-plugins": "^24.0.0",
-    "@atlassian/search-provider": "2.4.56",
+    "@atlassian/search-provider": "2.4.57",
     "@atlassian/ufo": "^0.2.0",
     "@emotion/jest": "^11.8.0",
     "@storybook/addon-knobs": "^5.3.18",