@atlaskit/editor-core 189.3.23 → 189.3.24

package/CHANGELOG.md

@@ -1,5 +1,11 @@
 # @atlaskit/editor-core
 
+## 189.3.24
+
+### Patch Changes
+
+- [#42256](https://bitbucket.org/atlassian/atlassian-frontend/pull-requests/42256) [`9c1a79051b6`](https://bitbucket.org/atlassian/atlassian-frontend/commits/9c1a79051b6) - Avoid submitting certain attributes for config panel analytic events
+
 ## 189.3.23
 
 ### Patch Changes

package/dist/cjs/ui/ConfigPanel/ConfigPanel.js

@@ -6,9 +6,8 @@ Object.defineProperty(exports, "__esModule", {
   value: true
 });
 exports.default = void 0;
-var _extends2 = _interopRequireDefault(require("@babel/runtime/helpers/extends"));
-var _objectWithoutProperties2 = _interopRequireDefault(require("@babel/runtime/helpers/objectWithoutProperties"));
 var _regenerator = _interopRequireDefault(require("@babel/runtime/regenerator"));
+var _extends2 = _interopRequireDefault(require("@babel/runtime/helpers/extends"));
 var _asyncToGenerator2 = _interopRequireDefault(require("@babel/runtime/helpers/asyncToGenerator"));
 var _classCallCheck2 = _interopRequireDefault(require("@babel/runtime/helpers/classCallCheck"));
 var _createClass2 = _interopRequireDefault(require("@babel/runtime/helpers/createClass"));
@@ -37,14 +36,10 @@ var _WithPluginState = _interopRequireDefault(require("../WithPluginState"));
 var _FormContent = _interopRequireDefault(require("./FormContent"));
 var _messages = require("./messages");
 var _FormErrorBoundary = require("./FormErrorBoundary");
-var _excluded = ["page", "labels", "types", "name", "width"];
 function _getRequireWildcardCache(nodeInterop) { if (typeof WeakMap !== "function") return null; var cacheBabelInterop = new WeakMap(); var cacheNodeInterop = new WeakMap(); return (_getRequireWildcardCache = function _getRequireWildcardCache(nodeInterop) { return nodeInterop ? cacheNodeInterop : cacheBabelInterop; })(nodeInterop); }
 function _interopRequireWildcard(obj, nodeInterop) { if (!nodeInterop && obj && obj.__esModule) { return obj; } if (obj === null || _typeof(obj) !== "object" && typeof obj !== "function") { return { default: obj }; } var cache = _getRequireWildcardCache(nodeInterop); if (cache && cache.has(obj)) { return cache.get(obj); } var newObj = {}; var hasPropertyDescriptor = Object.defineProperty && Object.getOwnPropertyDescriptor; for (var key in obj) { if (key !== "default" && Object.prototype.hasOwnProperty.call(obj, key)) { var desc = hasPropertyDescriptor ? Object.getOwnPropertyDescriptor(obj, key) : null; if (desc && (desc.get || desc.set)) { Object.defineProperty(newObj, key, desc); } else { newObj[key] = obj[key]; } } } newObj.default = obj; if (cache) { cache.set(obj, newObj); } return newObj; }
-function ownKeys(e, r) { var t = Object.keys(e); if (Object.getOwnPropertySymbols) { var o = Object.getOwnPropertySymbols(e); r && (o = o.filter(function (r) { return Object.getOwnPropertyDescriptor(e, r).enumerable; })), t.push.apply(t, o); } return t; }
-function _objectSpread(e) { for (var r = 1; r < arguments.length; r++) { var t = null != arguments[r] ? arguments[r] : {}; r % 2 ? ownKeys(Object(t), !0).forEach(function (r) { (0, _defineProperty2.default)(e, r, t[r]); }) : Object.getOwnPropertyDescriptors ? Object.defineProperties(e, Object.getOwnPropertyDescriptors(t)) : ownKeys(Object(t)).forEach(function (r) { Object.defineProperty(e, r, Object.getOwnPropertyDescriptor(t, r)); }); } return e; }
 function _createSuper(Derived) { var hasNativeReflectConstruct = _isNativeReflectConstruct(); return function _createSuperInternal() { var Super = (0, _getPrototypeOf2.default)(Derived), result; if (hasNativeReflectConstruct) { var NewTarget = (0, _getPrototypeOf2.default)(this).constructor; result = Reflect.construct(Super, arguments, NewTarget); } else { result = Super.apply(this, arguments); } return (0, _possibleConstructorReturn2.default)(this, result); }; }
 function _isNativeReflectConstruct() { if (typeof Reflect === "undefined" || !Reflect.construct) return false; if (Reflect.construct.sham) return false; if (typeof Proxy === "function") return true; try { Boolean.prototype.valueOf.call(Reflect.construct(Boolean, [], function () {})); return true; } catch (e) { return false; } }
-var LOGGED_MACRO_KEYS = ['children', 'recently-updated', 'excerpt'];
 function ConfigForm(_ref) {
   var canSave = _ref.canSave,
     errorMessage = _ref.errorMessage,
@@ -342,50 +337,15 @@ var ConfigPanel = /*#__PURE__*/function (_React$Component) {
       var _this$props4 = this.props,
         createAnalyticsEvent = _this$props4.createAnalyticsEvent,
         extensionManifest = _this$props4.extensionManifest;
-      var currentParameters = this.state.currentParameters;
-
-      // PGXT-4393 We need to collect configuration analytics for the macros in LOGGED_MACRO_KEYS.
-      // This function takes the parameters and filters out anything which might have UGC.
-      var getMacroParameters = function getMacroParameters() {
-        var page = currentParameters.page,
-          labels = currentParameters.labels,
-          types = currentParameters.types,
-          name = currentParameters.name,
-          width = currentParameters.width,
-          safeParams = (0, _objectWithoutProperties2.default)(currentParameters, _excluded);
-        var ugcFreeParams = _objectSpread({}, safeParams);
-        // Parse types field as an array of valid content types and include in the result
-        if (types) {
-          var contentTypes = ['page', 'blogpost', 'comment', 'attachment'];
-          var parsedTypes = types.split(',').map(function (type) {
-            return type.trim();
-          }).filter(function (type) {
-            return contentTypes.includes(type);
-          });
-          ugcFreeParams = _objectSpread({
-            types: parsedTypes
-          }, ugcFreeParams);
-        }
-        // Since width is a raw string input, parse then return
-        if (width) {
-          var parsedWidth = parseFloat(width);
-          ugcFreeParams = _objectSpread({
-            width: parsedWidth
-          }, ugcFreeParams);
-        }
-        return ugcFreeParams;
-      };
       (0, _analytics.fireAnalyticsEvent)(createAnalyticsEvent)({
         payload: {
           action: _analytics.ACTION.CLOSED,
           actionSubject: _analytics.ACTION_SUBJECT.CONFIG_PANEL,
           eventType: _analytics.EVENT_TYPE.UI,
-          attributes: _objectSpread({
+          attributes: {
             extensionKey: extensionManifest === null || extensionManifest === void 0 ? void 0 : extensionManifest.key,
             extensionType: extensionManifest === null || extensionManifest === void 0 ? void 0 : extensionManifest.type
-          }, extensionManifest !== null && extensionManifest !== void 0 && extensionManifest.key && LOGGED_MACRO_KEYS.includes(extensionManifest.key) ? {
-            parameters: getMacroParameters()
-          } : {})
+          }
         }
       });
     }

package/dist/cjs/version-wrapper.js

@@ -5,4 +5,4 @@ Object.defineProperty(exports, "__esModule", {
 });
 exports.version = exports.name = void 0;
 var name = exports.name = "@atlaskit/editor-core";
-var version = exports.version = "189.3.23";
+var version = exports.version = "189.3.24";

package/dist/es2019/ui/ConfigPanel/ConfigPanel.js

@@ -21,7 +21,6 @@ import WithPluginState from '../WithPluginState';
 import FormContent from './FormContent';
 import { messages } from './messages';
 import { FormErrorBoundary } from './FormErrorBoundary';
-const LOGGED_MACRO_KEYS = ['children', 'recently-updated', 'excerpt'];
 function ConfigForm({
   canSave,
   errorMessage,
@@ -279,43 +278,6 @@ class ConfigPanel extends React.Component {
       createAnalyticsEvent,
       extensionManifest
     } = this.props;
-    const {
-      currentParameters
-    } = this.state;
-
-    // PGXT-4393 We need to collect configuration analytics for the macros in LOGGED_MACRO_KEYS.
-    // This function takes the parameters and filters out anything which might have UGC.
-    const getMacroParameters = () => {
-      const {
-        page,
-        labels,
-        types,
-        name,
-        width,
-        ...safeParams
-      } = currentParameters;
-      let ugcFreeParams = {
-        ...safeParams
-      };
-      // Parse types field as an array of valid content types and include in the result
-      if (types) {
-        const contentTypes = ['page', 'blogpost', 'comment', 'attachment'];
-        const parsedTypes = types.split(',').map(type => type.trim()).filter(type => contentTypes.includes(type));
-        ugcFreeParams = {
-          types: parsedTypes,
-          ...ugcFreeParams
-        };
-      }
-      // Since width is a raw string input, parse then return
-      if (width) {
-        const parsedWidth = parseFloat(width);
-        ugcFreeParams = {
-          width: parsedWidth,
-          ...ugcFreeParams
-        };
-      }
-      return ugcFreeParams;
-    };
     fireAnalyticsEvent(createAnalyticsEvent)({
       payload: {
         action: ACTION.CLOSED,
@@ -323,10 +285,7 @@ class ConfigPanel extends React.Component {
         eventType: EVENT_TYPE.UI,
         attributes: {
           extensionKey: extensionManifest === null || extensionManifest === void 0 ? void 0 : extensionManifest.key,
-          extensionType: extensionManifest === null || extensionManifest === void 0 ? void 0 : extensionManifest.type,
-          ...(extensionManifest !== null && extensionManifest !== void 0 && extensionManifest.key && LOGGED_MACRO_KEYS.includes(extensionManifest.key) ? {
-            parameters: getMacroParameters()
-          } : {})
+          extensionType: extensionManifest === null || extensionManifest === void 0 ? void 0 : extensionManifest.type
         }
       }
     });

package/dist/es2019/version-wrapper.js

@@ -1,2 +1,2 @@
 export const name = "@atlaskit/editor-core";
-export const version = "189.3.23";
+export const version = "189.3.24";

package/dist/esm/ui/ConfigPanel/ConfigPanel.js

@@ -1,5 +1,4 @@
 import _extends from "@babel/runtime/helpers/extends";
-import _objectWithoutProperties from "@babel/runtime/helpers/objectWithoutProperties";
 import _asyncToGenerator from "@babel/runtime/helpers/asyncToGenerator";
 import _classCallCheck from "@babel/runtime/helpers/classCallCheck";
 import _createClass from "@babel/runtime/helpers/createClass";
@@ -8,9 +7,6 @@ import _inherits from "@babel/runtime/helpers/inherits";
 import _possibleConstructorReturn from "@babel/runtime/helpers/possibleConstructorReturn";
 import _getPrototypeOf from "@babel/runtime/helpers/getPrototypeOf";
 import _defineProperty from "@babel/runtime/helpers/defineProperty";
-var _excluded = ["page", "labels", "types", "name", "width"];
-function ownKeys(e, r) { var t = Object.keys(e); if (Object.getOwnPropertySymbols) { var o = Object.getOwnPropertySymbols(e); r && (o = o.filter(function (r) { return Object.getOwnPropertyDescriptor(e, r).enumerable; })), t.push.apply(t, o); } return t; }
-function _objectSpread(e) { for (var r = 1; r < arguments.length; r++) { var t = null != arguments[r] ? arguments[r] : {}; r % 2 ? ownKeys(Object(t), !0).forEach(function (r) { _defineProperty(e, r, t[r]); }) : Object.getOwnPropertyDescriptors ? Object.defineProperties(e, Object.getOwnPropertyDescriptors(t)) : ownKeys(Object(t)).forEach(function (r) { Object.defineProperty(e, r, Object.getOwnPropertyDescriptor(t, r)); }); } return e; }
 import _regeneratorRuntime from "@babel/runtime/regenerator";
 function _createSuper(Derived) { var hasNativeReflectConstruct = _isNativeReflectConstruct(); return function _createSuperInternal() { var Super = _getPrototypeOf(Derived), result; if (hasNativeReflectConstruct) { var NewTarget = _getPrototypeOf(this).constructor; result = Reflect.construct(Super, arguments, NewTarget); } else { result = Super.apply(this, arguments); } return _possibleConstructorReturn(this, result); }; }
 function _isNativeReflectConstruct() { if (typeof Reflect === "undefined" || !Reflect.construct) return false; if (Reflect.construct.sham) return false; if (typeof Proxy === "function") return true; try { Boolean.prototype.valueOf.call(Reflect.construct(Boolean, [], function () {})); return true; } catch (e) { return false; } }
@@ -35,7 +31,6 @@ import WithPluginState from '../WithPluginState';
 import FormContent from './FormContent';
 import { messages } from './messages';
 import { FormErrorBoundary } from './FormErrorBoundary';
-var LOGGED_MACRO_KEYS = ['children', 'recently-updated', 'excerpt'];
 function ConfigForm(_ref) {
   var canSave = _ref.canSave,
     errorMessage = _ref.errorMessage,
@@ -333,50 +328,15 @@ var ConfigPanel = /*#__PURE__*/function (_React$Component) {
       var _this$props4 = this.props,
         createAnalyticsEvent = _this$props4.createAnalyticsEvent,
         extensionManifest = _this$props4.extensionManifest;
-      var currentParameters = this.state.currentParameters;
-
-      // PGXT-4393 We need to collect configuration analytics for the macros in LOGGED_MACRO_KEYS.
-      // This function takes the parameters and filters out anything which might have UGC.
-      var getMacroParameters = function getMacroParameters() {
-        var page = currentParameters.page,
-          labels = currentParameters.labels,
-          types = currentParameters.types,
-          name = currentParameters.name,
-          width = currentParameters.width,
-          safeParams = _objectWithoutProperties(currentParameters, _excluded);
-        var ugcFreeParams = _objectSpread({}, safeParams);
-        // Parse types field as an array of valid content types and include in the result
-        if (types) {
-          var contentTypes = ['page', 'blogpost', 'comment', 'attachment'];
-          var parsedTypes = types.split(',').map(function (type) {
-            return type.trim();
-          }).filter(function (type) {
-            return contentTypes.includes(type);
-          });
-          ugcFreeParams = _objectSpread({
-            types: parsedTypes
-          }, ugcFreeParams);
-        }
-        // Since width is a raw string input, parse then return
-        if (width) {
-          var parsedWidth = parseFloat(width);
-          ugcFreeParams = _objectSpread({
-            width: parsedWidth
-          }, ugcFreeParams);
-        }
-        return ugcFreeParams;
-      };
       fireAnalyticsEvent(createAnalyticsEvent)({
         payload: {
           action: ACTION.CLOSED,
           actionSubject: ACTION_SUBJECT.CONFIG_PANEL,
           eventType: EVENT_TYPE.UI,
-          attributes: _objectSpread({
+          attributes: {
             extensionKey: extensionManifest === null || extensionManifest === void 0 ? void 0 : extensionManifest.key,
             extensionType: extensionManifest === null || extensionManifest === void 0 ? void 0 : extensionManifest.type
-          }, extensionManifest !== null && extensionManifest !== void 0 && extensionManifest.key && LOGGED_MACRO_KEYS.includes(extensionManifest.key) ? {
-            parameters: getMacroParameters()
-          } : {})
+          }
         }
       });
     }

package/dist/esm/version-wrapper.js

@@ -1,2 +1,2 @@
 export var name = "@atlaskit/editor-core";
-export var version = "189.3.23";
+export var version = "189.3.24";

package/dist/types/ui/ConfigPanel/ConfigPanel.d.ts

@@ -1,7 +1,8 @@
 import React from 'react';
-import type { WithAnalyticsEventsProps } from '@atlaskit/analytics-next';
-import type { ExtensionManifest, FieldDefinition, Parameters, OnSaveCallback } from '@atlaskit/editor-common/extensions';
-import type { FeatureFlags } from '@atlaskit/editor-common/types';
+import { WithAnalyticsEventsProps } from '@atlaskit/analytics-next';
+import type { ExtensionManifest } from '@atlaskit/editor-common/extensions';
+import { FieldDefinition, Parameters, OnSaveCallback } from '@atlaskit/editor-common/extensions';
+import { FeatureFlags } from '@atlaskit/editor-common/types';
 type Props = {
     extensionManifest?: ExtensionManifest;
     fields?: FieldDefinition[];

package/dist/types-ts4.5/ui/ConfigPanel/ConfigPanel.d.ts

@@ -1,7 +1,8 @@
 import React from 'react';
-import type { WithAnalyticsEventsProps } from '@atlaskit/analytics-next';
-import type { ExtensionManifest, FieldDefinition, Parameters, OnSaveCallback } from '@atlaskit/editor-common/extensions';
-import type { FeatureFlags } from '@atlaskit/editor-common/types';
+import { WithAnalyticsEventsProps } from '@atlaskit/analytics-next';
+import type { ExtensionManifest } from '@atlaskit/editor-common/extensions';
+import { FieldDefinition, Parameters, OnSaveCallback } from '@atlaskit/editor-common/extensions';
+import { FeatureFlags } from '@atlaskit/editor-common/types';
 type Props = {
     extensionManifest?: ExtensionManifest;
     fields?: FieldDefinition[];

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@atlaskit/editor-core",
-  "version": "189.3.23",
+  "version": "189.3.24",
   "description": "A package contains Atlassian editor core functionality",
   "publishConfig": {
     "registry": "https://registry.npmjs.org/"