@atlaskit/editor-core 187.48.5 → 187.48.6

package/CHANGELOG.md

@@ -1,5 +1,13 @@
 # @atlaskit/editor-core
 
+## 187.48.6
+
+### Patch Changes
+
+- [#40691](https://bitbucket.org/atlassian/atlassian-frontend/pull-requests/40691) [`cffa2089176`](https://bitbucket.org/atlassian/atlassian-frontend/commits/cffa2089176) - Decouple Help Dialog Plugin from Editor Core
+- [#40485](https://bitbucket.org/atlassian/atlassian-frontend/pull-requests/40485) [`14a726ecf5d`](https://bitbucket.org/atlassian/atlassian-frontend/commits/14a726ecf5d) - [ux] Respect allowResizingInTables for pixel entry component
+- Updated dependencies
+
 ## 187.48.5
 
 ### Patch Changes

package/README.md

@@ -6,7 +6,7 @@ Main package for the Atlassian Editor.
 
 Current devloop involves leveraging the atlaskit website shell to build out examples.
 
-0. After following https://developer.atlassian.com/cloud/framework/atlassian-frontend/getting-started/getting-started/
+0. After following https://hello.atlassian.net/wiki/spaces/AF/pages/2634599657/Getting+Started
 1. `yarn start editor-core`
 
 Then hit http://localhost:9000/examples/editor/editor-core

package/dist/cjs/plugins/media/toolbar/index.js

@@ -262,7 +262,9 @@ var generateMediaSingleFloatingToolbar = function generateMediaSingleFloatingToo
     }
 
     // Pixel Entry Toolbar Support
-    if ((0, _platformFeatureFlags.getBooleanFF)('platform.editor.media.extended-resize-experience') && allowResizing) {
+    var selection = state.selection;
+    var isWithinTable = (0, _utils.hasParentNodeOfType)([state.schema.nodes.table])(selection);
+    if ((0, _platformFeatureFlags.getBooleanFF)('platform.editor.media.extended-resize-experience') && allowResizing && (!isWithinTable || allowResizingInTables === true)) {
       var selectedMediaSingleNode = (0, _utils2.getSelectedMediaSingle)(state);
       var sizeInput = {
         type: 'custom',

package/dist/cjs/ui/ToolbarHelp/index.js

@@ -11,7 +11,7 @@ var _ToolbarButton = _interopRequireDefault(require("../ToolbarButton"));
 var _WithHelpTrigger = _interopRequireDefault(require("../WithHelpTrigger"));
 var _reactIntlNext = require("react-intl-next");
 var _messages = require("./messages");
-var tooltipHelpTrigger = function tooltipHelpTrigger(_ref) {
+var TooltipHelpTrigger = function TooltipHelpTrigger(_ref) {
   var _ref$title = _ref.title,
     title = _ref$title === void 0 ? 'Open help dialog' : _ref$title,
     _ref$titlePosition = _ref.titlePosition,
@@ -35,5 +35,5 @@ var tooltipHelpTrigger = function tooltipHelpTrigger(_ref) {
     }
   });
 };
-var _default = (0, _reactIntlNext.injectIntl)(tooltipHelpTrigger);
+var _default = (0, _reactIntlNext.injectIntl)(TooltipHelpTrigger);
 exports.default = _default;

package/dist/cjs/ui/WithHelpTrigger/index.js

@@ -16,10 +16,14 @@ var _react = _interopRequireDefault(require("react"));
 var _propTypes = _interopRequireDefault(require("prop-types"));
 var _analytics = require("../../plugins/analytics");
 var _eventDispatcher = require("../../event-dispatcher");
-var _commands = require("../../plugins/help-dialog/commands");
 var _consts = require("../../plugins/analytics/consts");
+var _commands = require("../../plugins/help-dialog/commands");
 function _createSuper(Derived) { var hasNativeReflectConstruct = _isNativeReflectConstruct(); return function _createSuperInternal() { var Super = (0, _getPrototypeOf2.default)(Derived), result; if (hasNativeReflectConstruct) { var NewTarget = (0, _getPrototypeOf2.default)(this).constructor; result = Reflect.construct(Super, arguments, NewTarget); } else { result = Super.apply(this, arguments); } return (0, _possibleConstructorReturn2.default)(this, result); }; }
-function _isNativeReflectConstruct() { if (typeof Reflect === "undefined" || !Reflect.construct) return false; if (Reflect.construct.sham) return false; if (typeof Proxy === "function") return true; try { Boolean.prototype.valueOf.call(Reflect.construct(Boolean, [], function () {})); return true; } catch (e) { return false; } }
+function _isNativeReflectConstruct() { if (typeof Reflect === "undefined" || !Reflect.construct) return false; if (Reflect.construct.sham) return false; if (typeof Proxy === "function") return true; try { Boolean.prototype.valueOf.call(Reflect.construct(Boolean, [], function () {})); return true; } catch (e) { return false; } } // TODO - ED-20189 Source deprecatedOpenHelpCommand from help-dialog-plugin
+/**
+ * @deprecated
+ * Use WithHelpTrigger from @atlaskit/editor-plugin-help-dialog which uses pluginInjectionApi
+ */
 var WithHelpTrigger = /*#__PURE__*/function (_React$Component) {
   (0, _inherits2.default)(WithHelpTrigger, _React$Component);
   var _super = _createSuper(WithHelpTrigger);

package/dist/cjs/version-wrapper.js

@@ -6,7 +6,7 @@ Object.defineProperty(exports, "__esModule", {
 exports.version = exports.nextMajorVersion = exports.name = void 0;
 var name = "@atlaskit/editor-core";
 exports.name = name;
-var version = "187.48.5";
+var version = "187.48.6";
 exports.version = version;
 var nextMajorVersion = function nextMajorVersion() {
   return [Number(version.split('.')[0]) + 1, 0, 0].join('.');

package/dist/es2019/plugins/media/toolbar/index.js

@@ -1,6 +1,6 @@
 import React from 'react';
 import { NodeSelection } from '@atlaskit/editor-prosemirror/state';
-import { findParentNodeOfType, removeSelectedNode } from '@atlaskit/editor-prosemirror/utils';
+import { findParentNodeOfType, hasParentNodeOfType, removeSelectedNode } from '@atlaskit/editor-prosemirror/utils';
 import RemoveIcon from '@atlaskit/icon/glyph/editor/remove';
 import DownloadIcon from '@atlaskit/icon/glyph/download';
 import { mediaFilmstripItemDOMSelector } from '@atlaskit/media-filmstrip';
@@ -260,7 +260,11 @@ const generateMediaSingleFloatingToolbar = (state, intl, options, pluginState, m
     }
 
     // Pixel Entry Toolbar Support
-    if (getBooleanFF('platform.editor.media.extended-resize-experience') && allowResizing) {
+    const {
+      selection
+    } = state;
+    const isWithinTable = hasParentNodeOfType([state.schema.nodes.table])(selection);
+    if (getBooleanFF('platform.editor.media.extended-resize-experience') && allowResizing && (!isWithinTable || allowResizingInTables === true)) {
       const selectedMediaSingleNode = getSelectedMediaSingle(state);
       const sizeInput = {
         type: 'custom',

package/dist/es2019/ui/ToolbarHelp/index.js

@@ -4,7 +4,7 @@ import ToolbarButton from '../ToolbarButton';
 import WithHelpTrigger from '../WithHelpTrigger';
 import { injectIntl } from 'react-intl-next';
 import { messages } from './messages';
-const tooltipHelpTrigger = ({
+const TooltipHelpTrigger = ({
   title = 'Open help dialog',
   titlePosition = 'left',
   intl
@@ -25,4 +25,4 @@ const tooltipHelpTrigger = ({
     })
   });
 };
-export default injectIntl(tooltipHelpTrigger);
+export default injectIntl(TooltipHelpTrigger);

package/dist/es2019/ui/WithHelpTrigger/index.js

@@ -3,8 +3,13 @@ import React from 'react';
 import PropTypes from 'prop-types';
 import { ACTION, ACTION_SUBJECT, INPUT_METHOD, EVENT_TYPE, ACTION_SUBJECT_ID } from '../../plugins/analytics';
 import { createDispatch } from '../../event-dispatcher';
-import { openHelpCommand } from '../../plugins/help-dialog/commands';
 import { analyticsEventKey } from '../../plugins/analytics/consts';
+// TODO - ED-20189 Source deprecatedOpenHelpCommand from help-dialog-plugin
+import { openHelpCommand } from '../../plugins/help-dialog/commands';
+/**
+ * @deprecated
+ * Use WithHelpTrigger from @atlaskit/editor-plugin-help-dialog which uses pluginInjectionApi
+ */
 export default class WithHelpTrigger extends React.Component {
   constructor(...args) {
     super(...args);

package/dist/es2019/version-wrapper.js

@@ -1,5 +1,5 @@
 export const name = "@atlaskit/editor-core";
-export const version = "187.48.5";
+export const version = "187.48.6";
 export const nextMajorVersion = () => {
   return [Number(version.split('.')[0]) + 1, 0, 0].join('.');
 };

package/dist/esm/plugins/media/toolbar/index.js

@@ -4,7 +4,7 @@ function ownKeys(e, r) { var t = Object.keys(e); if (Object.getOwnPropertySymbol
 function _objectSpread(e) { for (var r = 1; r < arguments.length; r++) { var t = null != arguments[r] ? arguments[r] : {}; r % 2 ? ownKeys(Object(t), !0).forEach(function (r) { _defineProperty(e, r, t[r]); }) : Object.getOwnPropertyDescriptors ? Object.defineProperties(e, Object.getOwnPropertyDescriptors(t)) : ownKeys(Object(t)).forEach(function (r) { Object.defineProperty(e, r, Object.getOwnPropertyDescriptor(t, r)); }); } return e; }
 import React from 'react';
 import { NodeSelection } from '@atlaskit/editor-prosemirror/state';
-import { findParentNodeOfType, removeSelectedNode } from '@atlaskit/editor-prosemirror/utils';
+import { findParentNodeOfType, hasParentNodeOfType, removeSelectedNode } from '@atlaskit/editor-prosemirror/utils';
 import RemoveIcon from '@atlaskit/icon/glyph/editor/remove';
 import DownloadIcon from '@atlaskit/icon/glyph/download';
 import { mediaFilmstripItemDOMSelector } from '@atlaskit/media-filmstrip';
@@ -253,7 +253,9 @@ var generateMediaSingleFloatingToolbar = function generateMediaSingleFloatingToo
     }
 
     // Pixel Entry Toolbar Support
-    if (getBooleanFF('platform.editor.media.extended-resize-experience') && allowResizing) {
+    var selection = state.selection;
+    var isWithinTable = hasParentNodeOfType([state.schema.nodes.table])(selection);
+    if (getBooleanFF('platform.editor.media.extended-resize-experience') && allowResizing && (!isWithinTable || allowResizingInTables === true)) {
       var selectedMediaSingleNode = getSelectedMediaSingle(state);
       var sizeInput = {
         type: 'custom',

package/dist/esm/ui/ToolbarHelp/index.js

@@ -4,7 +4,7 @@ import ToolbarButton from '../ToolbarButton';
 import WithHelpTrigger from '../WithHelpTrigger';
 import { injectIntl } from 'react-intl-next';
 import { messages } from './messages';
-var tooltipHelpTrigger = function tooltipHelpTrigger(_ref) {
+var TooltipHelpTrigger = function TooltipHelpTrigger(_ref) {
   var _ref$title = _ref.title,
     title = _ref$title === void 0 ? 'Open help dialog' : _ref$title,
     _ref$titlePosition = _ref.titlePosition,
@@ -28,4 +28,4 @@ var tooltipHelpTrigger = function tooltipHelpTrigger(_ref) {
     }
   });
 };
-export default injectIntl(tooltipHelpTrigger);
+export default injectIntl(TooltipHelpTrigger);

package/dist/esm/ui/WithHelpTrigger/index.js

@@ -11,8 +11,13 @@ import React from 'react';
 import PropTypes from 'prop-types';
 import { ACTION, ACTION_SUBJECT, INPUT_METHOD, EVENT_TYPE, ACTION_SUBJECT_ID } from '../../plugins/analytics';
 import { createDispatch } from '../../event-dispatcher';
-import { openHelpCommand } from '../../plugins/help-dialog/commands';
 import { analyticsEventKey } from '../../plugins/analytics/consts';
+// TODO - ED-20189 Source deprecatedOpenHelpCommand from help-dialog-plugin
+import { openHelpCommand } from '../../plugins/help-dialog/commands';
+/**
+ * @deprecated
+ * Use WithHelpTrigger from @atlaskit/editor-plugin-help-dialog which uses pluginInjectionApi
+ */
 var WithHelpTrigger = /*#__PURE__*/function (_React$Component) {
   _inherits(WithHelpTrigger, _React$Component);
   var _super = _createSuper(WithHelpTrigger);

package/dist/esm/version-wrapper.js

@@ -1,5 +1,5 @@
 export var name = "@atlaskit/editor-core";
-export var version = "187.48.5";
+export var version = "187.48.6";
 export var nextMajorVersion = function nextMajorVersion() {
   return [Number(version.split('.')[0]) + 1, 0, 0].join('.');
 };

package/dist/types/ui/ToolbarHelp/index.d.ts

@@ -1,6 +1,6 @@
 import React from 'react';
-import { PositionType } from '@atlaskit/tooltip/types';
-import { WrappedComponentProps } from 'react-intl-next';
+import type { PositionType } from '@atlaskit/tooltip/types';
+import type { WrappedComponentProps } from 'react-intl-next';
 interface Props {
     title?: string;
     titlePosition?: PositionType;

package/dist/types/ui/WithHelpTrigger/index.d.ts

@@ -1,11 +1,17 @@
 import React from 'react';
 import PropTypes from 'prop-types';
-export default class WithHelpTrigger extends React.Component<{
+interface WithHelpTriggerProps {
     render: (openHelp: () => void) => React.ReactNode;
-}, any> {
+}
+/**
+ * @deprecated
+ * Use WithHelpTrigger from @atlaskit/editor-plugin-help-dialog which uses pluginInjectionApi
+ */
+export default class WithHelpTrigger extends React.Component<WithHelpTriggerProps, any> {
     static contextTypes: {
         editorActions: PropTypes.Validator<object>;
     };
     openHelp: () => void;
     render(): React.ReactNode;
 }
+export {};

package/dist/types-ts4.5/ui/ToolbarHelp/index.d.ts

@@ -1,6 +1,6 @@
 import React from 'react';
-import { PositionType } from '@atlaskit/tooltip/types';
-import { WrappedComponentProps } from 'react-intl-next';
+import type { PositionType } from '@atlaskit/tooltip/types';
+import type { WrappedComponentProps } from 'react-intl-next';
 interface Props {
     title?: string;
     titlePosition?: PositionType;

package/dist/types-ts4.5/ui/WithHelpTrigger/index.d.ts

@@ -1,11 +1,17 @@
 import React from 'react';
 import PropTypes from 'prop-types';
-export default class WithHelpTrigger extends React.Component<{
+interface WithHelpTriggerProps {
     render: (openHelp: () => void) => React.ReactNode;
-}, any> {
+}
+/**
+ * @deprecated
+ * Use WithHelpTrigger from @atlaskit/editor-plugin-help-dialog which uses pluginInjectionApi
+ */
+export default class WithHelpTrigger extends React.Component<WithHelpTriggerProps, any> {
     static contextTypes: {
         editorActions: PropTypes.Validator<object>;
     };
     openHelp: () => void;
     render(): React.ReactNode;
 }
+export {};

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@atlaskit/editor-core",
-  "version": "187.48.5",
+  "version": "187.48.6",
   "description": "A package contains Atlassian editor core functionality",
   "publishConfig": {
     "registry": "https://registry.npmjs.org/"
@@ -112,7 +112,7 @@
     "@atlaskit/radio": "^5.6.0",
     "@atlaskit/section-message": "^6.4.0",
     "@atlaskit/select": "^16.7.0",
-    "@atlaskit/smart-card": "^26.28.0",
+    "@atlaskit/smart-card": "^26.29.0",
     "@atlaskit/smart-user-picker": "^6.3.0",
     "@atlaskit/spinner": "^15.6.0",
     "@atlaskit/status": "^1.4.0",

package/report.api.md

@@ -124,7 +124,7 @@ import { PMPlugin } from '@atlaskit/editor-common/types';
 import { PortalProvider } from '@atlaskit/editor-common/portal-provider';
 import { PortalProviderAPI } from '@atlaskit/editor-common/portal-provider';
 import { PortalRenderer } from '@atlaskit/editor-common/portal-provider';
-import { PositionType } from '@atlaskit/tooltip/types';
+import type { PositionType } from '@atlaskit/tooltip/types';
 import { PresenceProvider } from '@atlaskit/mention/resource';
 import { PresenceResource } from '@atlaskit/mention/resource';
 import PropTypes from 'prop-types';
@@ -2073,11 +2073,9 @@ interface WithEditorActionsProps {
   render(actions: EditorActions): React_2.ReactElement<any> | null;
 }
 
-// @public (undocumented)
+// @public @deprecated (undocumented)
 export class WithHelpTrigger extends React_2.Component<
-  {
-    render: (openHelp: () => void) => React_2.ReactNode;
-  },
+  WithHelpTriggerProps,
   any
 > {
   // (undocumented)
@@ -2090,6 +2088,12 @@ export class WithHelpTrigger extends React_2.Component<
   render(): React_2.ReactNode;
 }
 
+// @public (undocumented)
+interface WithHelpTriggerProps {
+  // (undocumented)
+  render: (openHelp: () => void) => React_2.ReactNode;
+}
+
 export { WithPluginState };
 
 // (No @packageDocumentation comment for this package)

package/tmp/api-report-tmp.d.ts

@@ -113,7 +113,7 @@ import { PMPlugin } from '@atlaskit/editor-common/types';
 import { PortalProvider } from '@atlaskit/editor-common/portal-provider';
 import { PortalProviderAPI } from '@atlaskit/editor-common/portal-provider';
 import { PortalRenderer } from '@atlaskit/editor-common/portal-provider';
-import { PositionType } from '@atlaskit/tooltip/types';
+import type { PositionType } from '@atlaskit/tooltip/types';
 import { PresenceProvider } from '@atlaskit/mention/resource';
 import { PresenceResource } from '@atlaskit/mention/resource';
 import PropTypes from 'prop-types';
@@ -1854,10 +1854,8 @@ interface WithEditorActionsProps {
     render(actions: EditorActions): React_2.ReactElement<any> | null;
 }
 
-// @public (undocumented)
-export class WithHelpTrigger extends React_2.Component<{
-    render: (openHelp: () => void) => React_2.ReactNode;
-}, any> {
+// @public @deprecated (undocumented)
+export class WithHelpTrigger extends React_2.Component<WithHelpTriggerProps, any> {
     // (undocumented)
     static contextTypes: {
         editorActions: PropTypes.Validator<object>;
@@ -1868,6 +1866,12 @@ export class WithHelpTrigger extends React_2.Component<{
     render(): React_2.ReactNode;
 }
 
+// @public (undocumented)
+interface WithHelpTriggerProps {
+    // (undocumented)
+    render: (openHelp: () => void) => React_2.ReactNode;
+}
+
 export { WithPluginState }
 
 // (No @packageDocumentation comment for this package)