@atlaskit/editor-core 187.41.1 → 187.41.3

package/CHANGELOG.md

@@ -1,5 +1,11 @@
 # @atlaskit/editor-core
 
+## 187.41.3
+
+### Patch Changes
+
+- [`85b6a5da67a`](https://bitbucket.org/atlassian/atlassian-frontend/commits/85b6a5da67a) - [ux] Fix [Regression] keyboard selections within actions are unpredictable
+
 ## 187.41.1
 
 ### Patch Changes

package/dist/cjs/plugins/selection/pm-plugins/events/create-selection-between.js

@@ -10,7 +10,7 @@ function findEmptySelectableParentNodePosition($pos, isValidPosition) {
   if ($pos.pos + 1 > doc.content.size) {
     return null;
   }
-  if ($pos.depth === 0) {
+  if ($pos.nodeBefore !== null) {
     if (isValidPosition($pos)) {
       return $pos;
     }

package/dist/cjs/plugins/selection/pm-plugins/events/keydown.js

@@ -26,8 +26,20 @@ var isCollpasedExpand = function isCollpasedExpand(node) {
 var isBodiedExtension = function isBodiedExtension(node) {
   return Boolean(node && ['bodiedExtension'].includes(node.type.name));
 };
+
+/**
+ * ED-19861 - [Regression] keyboard selections within action items are unpredicatable
+ * Table was added to the list of problematic nodes because the desired behaviour when Shift+Up from outside the
+ * table is to select the table node itself, rather than the table cell content. Previously this behaviour was handled
+ * in `packages/editor/editor-core/src/plugins/selection/pm-plugins/events/create-selection-between.ts` but there was
+ * a bug in `create-selection-between` which after fixing the bug that code was no longer handling table selection
+ * correctly, so to fix that table was added here.
+ */
+var isTable = function isTable(node) {
+  return Boolean(node && ['table'].includes(node.type.name));
+};
 var isProblematicNode = function isProblematicNode(node) {
-  return isCollpasedExpand(node) || isBodiedExtension(node);
+  return isCollpasedExpand(node) || isBodiedExtension(node) || isTable(node);
 };
 var findFixedProblematicNodePosition = function findFixedProblematicNodePosition(doc, $head, direction) {
   if ($head.pos === 0 || $head.depth === 0) {

package/dist/cjs/version-wrapper.js

@@ -6,7 +6,7 @@ Object.defineProperty(exports, "__esModule", {
 exports.version = exports.nextMajorVersion = exports.name = void 0;
 var name = "@atlaskit/editor-core";
 exports.name = name;
-var version = "187.41.1";
+var version = "187.41.3";
 exports.version = version;
 var nextMajorVersion = function nextMajorVersion() {
   return [Number(version.split('.')[0]) + 1, 0, 0].join('.');

package/dist/es2019/plugins/selection/pm-plugins/events/create-selection-between.js

@@ -6,7 +6,7 @@ function findEmptySelectableParentNodePosition($pos, isValidPosition) {
   if ($pos.pos + 1 > doc.content.size) {
     return null;
   }
-  if ($pos.depth === 0) {
+  if ($pos.nodeBefore !== null) {
     if (isValidPosition($pos)) {
       return $pos;
     }

package/dist/es2019/plugins/selection/pm-plugins/events/keydown.js

@@ -21,8 +21,20 @@ const isCollpasedExpand = node => {
 const isBodiedExtension = node => {
   return Boolean(node && ['bodiedExtension'].includes(node.type.name));
 };
+
+/**
+ * ED-19861 - [Regression] keyboard selections within action items are unpredicatable
+ * Table was added to the list of problematic nodes because the desired behaviour when Shift+Up from outside the
+ * table is to select the table node itself, rather than the table cell content. Previously this behaviour was handled
+ * in `packages/editor/editor-core/src/plugins/selection/pm-plugins/events/create-selection-between.ts` but there was
+ * a bug in `create-selection-between` which after fixing the bug that code was no longer handling table selection
+ * correctly, so to fix that table was added here.
+ */
+const isTable = node => {
+  return Boolean(node && ['table'].includes(node.type.name));
+};
 const isProblematicNode = node => {
-  return isCollpasedExpand(node) || isBodiedExtension(node);
+  return isCollpasedExpand(node) || isBodiedExtension(node) || isTable(node);
 };
 const findFixedProblematicNodePosition = (doc, $head, direction) => {
   if ($head.pos === 0 || $head.depth === 0) {

package/dist/es2019/version-wrapper.js

@@ -1,5 +1,5 @@
 export const name = "@atlaskit/editor-core";
-export const version = "187.41.1";
+export const version = "187.41.3";
 export const nextMajorVersion = () => {
   return [Number(version.split('.')[0]) + 1, 0, 0].join('.');
 };

package/dist/esm/plugins/selection/pm-plugins/events/create-selection-between.js

@@ -4,7 +4,7 @@ function findEmptySelectableParentNodePosition($pos, isValidPosition) {
   if ($pos.pos + 1 > doc.content.size) {
     return null;
   }
-  if ($pos.depth === 0) {
+  if ($pos.nodeBefore !== null) {
     if (isValidPosition($pos)) {
       return $pos;
     }

package/dist/esm/plugins/selection/pm-plugins/events/keydown.js

@@ -21,8 +21,20 @@ var isCollpasedExpand = function isCollpasedExpand(node) {
 var isBodiedExtension = function isBodiedExtension(node) {
   return Boolean(node && ['bodiedExtension'].includes(node.type.name));
 };
+
+/**
+ * ED-19861 - [Regression] keyboard selections within action items are unpredicatable
+ * Table was added to the list of problematic nodes because the desired behaviour when Shift+Up from outside the
+ * table is to select the table node itself, rather than the table cell content. Previously this behaviour was handled
+ * in `packages/editor/editor-core/src/plugins/selection/pm-plugins/events/create-selection-between.ts` but there was
+ * a bug in `create-selection-between` which after fixing the bug that code was no longer handling table selection
+ * correctly, so to fix that table was added here.
+ */
+var isTable = function isTable(node) {
+  return Boolean(node && ['table'].includes(node.type.name));
+};
 var isProblematicNode = function isProblematicNode(node) {
-  return isCollpasedExpand(node) || isBodiedExtension(node);
+  return isCollpasedExpand(node) || isBodiedExtension(node) || isTable(node);
 };
 var findFixedProblematicNodePosition = function findFixedProblematicNodePosition(doc, $head, direction) {
   if ($head.pos === 0 || $head.depth === 0) {

package/dist/esm/version-wrapper.js

@@ -1,5 +1,5 @@
 export var name = "@atlaskit/editor-core";
-export var version = "187.41.1";
+export var version = "187.41.3";
 export var nextMajorVersion = function nextMajorVersion() {
   return [Number(version.split('.')[0]) + 1, 0, 0].join('.');
 };

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@atlaskit/editor-core",
-  "version": "187.41.1",
+  "version": "187.41.3",
   "description": "A package contains Atlassian editor core functionality",
   "publishConfig": {
     "registry": "https://registry.npmjs.org/"